Jenn Magder
a2678be7ad
Platform view devicelab ad banner scroll list real ads ( #145239 )
...
Reland https://github.com/flutter/flutter/pull/144745 , which was reverted due to a the Android app ads not being set up correctly, crashing on launch: https://github.com/flutter/flutter/pull/145228
Add the missing [`com.google.android.gms.ads.APPLICATION_ID` `meta-data` tag](https://developers.google.com/admob/android/quick-start#import_the_mobile_ads_sdk ) to the manifest.
Validated both `platform_views_scroll_perf__timeline_summary` and `platform_views_scroll_perf_impeller__timeline_summary` ran locally on an Android emulator.
Successful presubmit runs:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/4/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_pixel_7pro%20platform_views_scroll_perf_impeller__timeline_summary/4/overview
Original commit message:
_________
This benchmark is to measure the platform view performance improvement.
It is similar to https://github.com/lucalooz/flutter_ads_list_perf
There's still a pending issue https://github.com/flutter/flutter/issues/144339
Fixes https://github.com/flutter/flutter/issues/143534
Fixes https://github.com/flutter/flutter/issues/143257
2024-03-16 05:44:21 +00:00
Bartek Pacia
deaa600204
Reland "Update gradle lockfiles template ( #140115 )" ( #143081 )
...
Trying to reland #140115 which I had to revert in #142889 because [it broke the tree](https://github.com/flutter/flutter/pull/140115#issuecomment-1925774719 ).
In this PR I fixed the post-submit following tests:
2024-02-08 16:22:15 +00:00
auto-submit[bot]
f8a77225f3
Reverts "Update gradle lockfiles template" ( #142889 )
...
Reverts flutter/flutter#140115
Initiated by: bartekpacia
Reason for reverting: broke the tree
- [`Linux firebase_abstract_method_smoke_test`](https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20firebase_abstract_method_smoke_test/15844/overview )
- [`Linux_android android_view_scroll_perf__timeline_summary`](https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20android_view_scroll_perf__timeline_summary/13453/overview )
- [`Linux_android platform_views
Original PR Author: bartekpacia
Reviewed By: {gmackall}
This change reverts the following previous change:
Original Description:
This PR updates almost* all Gradle buildscripts in the Flutter repo the `example` and `dev` (in particular, in `dev/integration_tests` and in `dev/benchmarks`) directories to apply Flutter's Gradle plugins using the declarative `plugins {}` block.
*almost, because:
- add-to-app (aka hybrid) apps are not migrated (related https://github.com/flutter/flutter/issues/138756 )
- apps that purposefully use build files to ensure backward compatibility (e.g. [`gradle_deprecated_settings`](https://github.com/flutter/flutter/tree/3.16.0/dev/integration_tests/gradle_deprecated_settings ))
2024-02-04 14:28:18 +00:00
Bartek Pacia
85888bccf2
Update gradle lockfiles template ( #140115 )
...
This PR updates almost* all Gradle buildscripts in the Flutter repo the `example` and `dev` (in particular, in `dev/integration_tests` and in `dev/benchmarks`) directories to apply Flutter's Gradle plugins using the declarative `plugins {}` block.
*almost, because:
- add-to-app (aka hybrid) apps are not migrated (related https://github.com/flutter/flutter/issues/138756 )
- apps that purposefully use build files to ensure backward compatibility (e.g. [`gradle_deprecated_settings`](https://github.com/flutter/flutter/tree/3.16.0/dev/integration_tests/gradle_deprecated_settings ))
2024-02-04 13:10:49 +00:00
Camille Simon
c66bb0a18a
[Android] Support Android 34 (take 2) ( #137967 )
...
Re-lands https://github.com/flutter/flutter/pull/137191 .
The fix for the issue causing that PR to be reverted was tested in this PR but ultimately landed separately in https://github.com/flutter/flutter/pull/138093 .
2023-11-09 22:40:15 +00:00
auto-submit[bot]
c4ce9479bb
Reverts "[Android] Support Android 34" ( #137865 )
...
Reverts flutter/flutter#137191
Initiated by: camsim99
This change reverts the following previous change:
Original Description:
Adds support for Android 34 in the following ways:
- Bumps integration tests compile SDK versions 33 --> 34
- Bumps template compile SDK version 33 --> 34
- Also changes deprecated `compileSdkVersion` to `compileSdk`
Part of https://github.com/flutter/flutter/issues/134220
2023-11-03 20:14:19 +00:00
Camille Simon
675fec805a
[Android] Support Android 34 ( #137191 )
...
Adds support for Android 34 in the following ways:
- Bumps integration tests compile SDK versions 33 --> 34
- Bumps template compile SDK version 33 --> 34
- Also changes deprecated `compileSdkVersion` to `compileSdk`
Part of https://github.com/flutter/flutter/issues/134220
2023-11-02 22:18:11 +00:00
Bartek Pacia
b915f68d7a
Fix warning in flutter create
d project ("package attribute is deprecated" in AndroidManifest) ( #123426 )
...
Fix warning in `flutter create`d project ("package attribute is deprecated" in AndroidManifest)
2023-03-29 04:21:03 +00:00
Gary Qian
7cfbdadc33
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108472 ( #108510 )
2022-07-28 19:38:07 -07:00
Kate Lovett
716533925b
Revert "Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355 ( #108472 )" ( #108488 )
...
This reverts commit 1f8c490c82
.
2022-07-27 17:20:20 -05:00
Gary Qian
1f8c490c82
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355 ( #108472 )
2022-07-27 14:23:09 -07:00
Zachary Anderson
9876b0d6d6
Revert "Benchmark cannot run in Android12 phone ( #100761 )" ( #102649 )
...
This reverts commit 3d148821eb
.
2022-04-27 07:27:34 -07:00
JsouLiang
3d148821eb
Benchmark cannot run in Android12 phone ( #100761 )
2022-04-27 05:54:06 -07:00
Gary Qian
02b1146cff
Reland "Exit on deprecated v1 embedding when trying to run or build" ( #92901 ) ( #93566 )
2021-11-12 15:52:32 -08:00
Yegor
24b9346c9b
Revert "Reland "Exit on deprecated v1 embedding when trying to run or build ( #92901 )" ( #93386 )" ( #93518 )
...
This reverts commit eabb7cbc34
.
It broke multiple tests.
2021-11-11 16:45:40 -08:00
Gary Qian
eabb7cbc34
Reland "Exit on deprecated v1 embedding when trying to run or build ( #92901 )" ( #93386 )
2021-11-11 14:49:35 -08:00
Zachary Anderson
858a328712
Revert "Exit on deprecated v1 embedding when trying to run or build ( #92901 )" ( #93365 )
...
This reverts commit 6153bbef3e
.
2021-11-09 22:22:14 -08:00
Gary Qian
6153bbef3e
Exit on deprecated v1 embedding when trying to run or build ( #92901 )
2021-11-09 17:38:03 -08:00
Zachary Anderson
366648ae90
Revert "Reland: "Update outdated runners in the benchmarks folder ( #91126 )" ( #92535 )" ( #93323 )
...
This reverts commit bfe9c59831
.
2021-11-09 08:44:56 -08:00
Greg Spencer
bfe9c59831
Reland: "Update outdated runners in the benchmarks folder ( #91126 )" ( #92535 )
2021-11-08 21:28:02 -08:00
Zachary Anderson
b412f6fff8
Revert "Update outdated runners in the benchmarks folder ( #91126 )" ( #92106 )
...
This reverts commit 31e3364771
.
2021-10-19 10:35:15 -07:00
Greg Spencer
31e3364771
Update outdated runners in the benchmarks folder ( #91126 )
...
This change updates the platform runners in the benchmarks subdir.
I've attempted to replace the entire group with new code as if the project were recreated with flutter create so that they don't become a Frankenstein of minor changes to make it work again, but just plain old generated code that can be replaced and updated in place.
2021-10-19 08:27:29 -07:00
Emmanuel Garcia
d7631275fe
Bump targetSdkVersion to 31 and organize static values ( #91719 )
2021-10-15 13:41:48 -07:00
Emmanuel Garcia
42f21fd780
Standardize how Java8 is set in gradle files ( #80600 )
2021-04-19 20:19:03 -07:00
Emmanuel Garcia
8dd0de7f58
Relands: Migrate template to Gradle 6.7 and AGP 4.1.0 ( #71446 )
2020-12-01 19:01:09 -08:00
Amir Hardon
7df04fdbd3
Revert "Migrate template to Gradle 6.7 and AGP 4.1.0 ( #70808 )" ( #71096 )
...
This reverts commit 8e73bab94c
.
2020-11-23 12:27:36 -08:00
Emmanuel Garcia
8e73bab94c
Migrate template to Gradle 6.7 and AGP 4.1.0 ( #70808 )
2020-11-20 13:05:35 -08:00
xster
df8e537f96
move compile/target sdk versions to 29 ( #62799 ) ( #63008 )
2020-08-11 14:51:02 -07:00
Jonah Williams
e8ad863a08
Revert "move compile/target sdk versions to 29 ( #62799 )" ( #62884 )
...
This reverts commit 5b3dc5251b
.
2020-08-04 11:20:16 -07:00
xster
5b3dc5251b
move compile/target sdk versions to 29 ( #62799 )
2020-08-04 08:26:08 -07:00
Kate Lovett
560c72287b
TODO Audits - 1 ( #53604 )
2020-03-31 11:21:01 -07:00
Emmanuel Garcia
bec7f84a57
Fix package name ( #52870 )
2020-03-19 09:31:02 -07:00
Emmanuel Garcia
a3c6e4a0b9
Reland: Add Platform View benchmark ( #52839 )
2020-03-18 13:24:52 -07:00
Emmanuel Garcia
dc8ffe0430
Revert "Add benchmark for platform views ( #52717 )" ( #52834 )
...
This reverts commit 1f1731842a
.
2020-03-18 11:16:38 -07:00
Emmanuel Garcia
1f1731842a
Add benchmark for platform views ( #52717 )
2020-03-18 10:55:50 -07:00