Commit Graph

10 Commits

Author SHA1 Message Date
David Martos
d242d1368f
Fix gen_defaults test randomness (#142743)
This PR improves the gen_defaults tests to not be tied to a particular order of execution.
Since there is a global class that holds the state of the used/not used tokens, we need to clear this logger before each test.

Fixes https://github.com/flutter/flutter/issues/142716

cc @zanderso @QuncCccccc 

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-02-01 21:22:51 +00:00
Zachary Anderson
8a5509ea6a
Add no-shuffle tag to gen_defaults_test.dart (#142717)
For https://github.com/flutter/flutter/issues/142716
2024-02-01 16:16:12 +00:00
David Martos
63018fe6cb
Relax the warning of unavailable tokens in gen_defaults when a default value is provided (#140872)
Fixes some false positives and false negatives from the `gen_defaults` tool regarding unavailable tokens in the Material spec.

Fixes #140871 

# Before

![image](https://github.com/flutter/flutter/assets/22084723/eb6c43ee-d919-4203-80ee-e36869e5bbcf)

# After

![image](https://github.com/flutter/flutter/assets/22084723/67093dcb-1ab0-439f-9338-a6f364d2a9e1)

These new issues that are logged are being fixed in https://github.com/flutter/flutter/pull/140573

---

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-01-23 09:35:22 +00:00
Pierre-Louis
66cda5917d
Improve defaults generation with logging, stats, and token validation (#128244)
## Description

This improves defaults generation with logging, stats, and token validation. 

This PR includes these changes:
* introduce `TokenLogger`, with a verbose mode
  * prints versions and tokens usage to the console
  * outputs `generated/used_tokens.csv`, a list of all used tokens, for use by Google
* find token files in `data` automatically
* hide tokens `Map`
  * tokens can be obtained using existing resolvers (e.g. `color`, `shape`), or directly through `getToken`.
  * tokens can be checked for existence with `tokenAvailable`
* remove version from template, since the tokens are aggregated and multiple versions are possible (as is the case currently), it does not make sense to attribute a single version
* improve documentation

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/122602

## Tests
 - Added tests for `TokenLogger`
 - Regenerated tokens, no-op except version removal

## Future work
A future PR should replace or remove the following invalid tokens usages

<img width="578" alt="image" src="https://github.com/flutter/flutter/assets/6655696/b6f9e5a7-523f-4f72-94f9-1b0bf4cc9f00">
2023-06-09 11:28:18 +00:00
Darren Austin
d4061c19f4
Refactor gen_defaults to support multiple generated code blocks in the same file independently. (#107278) 2022-07-10 17:17:09 -07:00
Michael Goderbauer
195a1cc413
Prepare dev (minus flutter_gallery) for use_super_parameters (#100516) 2022-03-29 12:52:42 -07:00
Darren Austin
ca2a751661
Migrate NavigationBar to M3 tokens. (#98285) 2022-02-15 00:40:20 -08:00
Darren Austin
21a6c06491
Update Material tokens to v0.81. (#98149) 2022-02-10 22:56:17 -08:00
Darren Austin
97124d7bf9
Updated gen_defaults to use new JSON output from the Material token database. (#97596) 2022-02-02 10:22:57 -08:00
Darren Austin
78f53bed51
Script to generate widget theme data defaults from the Material token database. (#95370) 2022-01-06 11:15:20 -08:00