Chris Bracken
4743a806cb
Minor flutter_tools test reorganization ( #10356 )
...
Relocates two tests alongside other related tests:
* moved code_signing_test.dart alongside other lib/src/ios tests
* moved terminal_test.dart alongside other lib/src/base tests
2017-05-26 16:12:42 -07:00
Hans Muller
f68c6fb814
Fix package_test flakiness, init ensure terminal context entry is set ( #10333 )
2017-05-25 16:35:38 -07:00
Mikkel Nygaard Ravn
251d83a4b5
Add org option to flutter create ( #10290 )
2017-05-24 16:19:16 +02:00
Mikkel Nygaard Ravn
6762e86953
Change template indentation to 2 spaces ( #10289 )
2017-05-24 12:37:23 +02:00
Mikkel Nygaard Ravn
10f6483003
Add Swift and Kotlin templates ( #10259 )
2017-05-24 08:22:50 +02:00
xster
04aeef84db
Let iOS flutter run auto-sign default to first profile ( #10181 )
...
* Let run default to first profile
* fix
* review notes
2017-05-23 18:05:47 -07:00
Chris Bracken
49cec4593a
Apply minor formatting fixes ( #10261 )
2017-05-22 17:08:49 -07:00
Chris Bracken
dd1456ffbc
Make most ios_workflow host tool calls async ( #10260 )
...
Does not yet migrate hasIdeviceId since that results in a cascade of
breaking interface changes that's significant enough for a separate
patch.
2017-05-22 16:09:48 -07:00
Michael Goderbauer
9a908f7558
Revert "Partial rollback of #10204 " ( #10258 )
...
* Revert "Test installation status when ideviceid is not installed (#10254 )"
This reverts commit 0e5d4a8771#10204 (#10256 )"
This reverts commit b291bf5d6a
2017-05-22 16:06:22 -07:00
Chris Bracken
0e5d4a8771
Test installation status when ideviceid is not installed ( #10254 )
...
Ensure that flutter doctor returns a partial installation status when
ideviceid is not installed.
2017-05-22 14:09:37 -07:00
Michael Goderbauer
b291bf5d6a
Partial rollback of #10204 ( #10256 )
...
This broke Fuchsia as they haven't updated to Dart 1.24 yet :(
2017-05-22 13:28:59 -07:00
Todd Volkert
aa9c782693
Add initial list of known Android hardware ( #10249 )
...
Our emulator detection was based on a simple heuristic that was
failing for the Samsung Galaxy S8. Any heuristic is flawed since
Android devices can report whatever they want to adb, but this
change attempts to tighten the detection by listing known models
(by their ro.hardware property). Again, these values could be
spoofed by emulator system images, but it's less likely to be
an issue than with our previous (and fall-back) heuristic.
Fixes #10203
Related: #10248
2017-05-22 10:47:02 -07:00
Michael Goderbauer
d33fd923bf
Print locale in flutter doctor ( #10204 )
...
This helps to debug encoding issues that are believed to only happen for certain locales (see https://github.com/flutter/flutter/issues/10198 fo example).
DO NOT SUBMIT until Dart SDK has been bumped (https://github.com/flutter/flutter/pull/10110 ) as this depends on new API.
2017-05-22 10:21:10 -07:00
Rafal Wachol
ee34516491
Moved FLUTTER_HOME to FLUTTER_ROOT in gradle plugin ( #10100 )
2017-05-22 07:50:31 -07:00
Alexander Aprelev
5b1e972948
Filter out '\n' from terminal input. ( #10220 )
...
* Remove '\n' from terminal input.
* Use trim instead of replaceAll
* Add unit test
* Cleanup the test
* Fixed lint
* Style adjustments
* Forgotten @override
* Revert "Forgotten @override"
Accidently added extra files.
This reverts commit 0aba24fc8e
2017-05-21 15:15:44 -07:00
Brian Slesinsky
922c2d1213
rename Android module file to include project name ( #10163 )
...
IDEA users sometimes want to create multiple Flutter modules
in the same IDEA project. See discussion:
https://github.com/flutter/flutter-intellij/issues/1014
In this case, we will actually have pairs of modules,
one for Flutter and one for Android. Renaming the
android module to make the relationship obvious.
But, don't delete the old file yet to avoid breaking
existing users. We can do that after the next
Flutter plugin release.
2017-05-19 13:36:53 -07:00
Todd Volkert
a88379399e
Don't fail assert when we send an error to the plugin. ( #10207 )
2017-05-19 12:34:41 -07:00
Collin Jackson
f5f0895990
Comment out use_frameworks by default so that codelab users don't have to. ( #10205 )
2017-05-19 10:45:35 -07:00
Ian Hickson
77d67c9d30
fix flutter analyze --dartdocs ( #10182 )
2017-05-19 08:46:34 -07:00
Chris Bracken
d3fbf2ae6f
Avoid duplicate exceptions on VM Service Mock failure ( #10197 )
...
On failure to configure a mock VM service, we get a useful exception in
setUpAll(). This change prevents an additional failure in tearDownAll()
that provides no additional useful diagnostic info.
2017-05-18 22:56:12 -07:00
Todd Volkert
a253605c76
Fall back to IPv4 in devfs_test.dart ( #10196 )
...
Fixes the broken build in the Chromium bots
2017-05-18 22:41:41 -07:00
Todd Volkert
e8ac331d87
Change devfs_test to use IPv6 ( #10194 )
2017-05-18 21:45:24 -07:00
Michael Goderbauer
fdbb1fbbc7
Add a note about how to edit platform code in IDE to flutter create --plugin ( #10189 )
2017-05-18 18:18:51 -07:00
xster
9d3fb1f309
Auto provision iOS deploy 2/3 - prompt user to choose a certificate ( #10025 )
...
* first pass
* improvements
* extract terminal.dart
* rebase
* add default terminal to context
* The analyzer wants the ../ imports in front of the ./ imports
* review notes
2017-05-18 11:26:43 -07:00
Mikkel Nygaard Ravn
bae5a5cdf3
Simplify flutter create AppDelegate template ( #10139 )
2017-05-18 10:01:05 +02:00
Sarah Zakarias
c67b46e328
Update plugin README with link to plugin guide ( #10137 )
2017-05-17 23:06:40 +02:00
Ian Hickson
73dcca65f7
Nits for protocol discovery ( #10112 )
...
Rather than complain about these in a code review I figured I'd just fix them. :-)
2017-05-16 11:38:07 -07:00
Collin Jackson
7154ac48db
Merge remote-tracking branch 'origin/alpha'
2017-05-16 09:32:27 -07:00
Collin Jackson
00214fa7bd
Fix call to unimplemented application:openURL:options: in iOS template ( #10107 )
...
Fixes #10106
2017-05-16 09:31:35 -07:00
Todd Volkert
10decc7c19
Fix race condition in protocol_discovery.dart ( #10092 )
...
For some reaosn, when we discovered our URI, we were re-instantiating
the `Completer` instance variable whose future we listen to in `nextUri()`.
This led to a race between a caller calling `nextUri()` and us discovering
the URI. If we happened to discover our URI before a caller called
`nextUri()`, then they would be left waiting on a future from the newly
allocated `Completer` (which would never complete).
Fixes #10064
2017-05-16 08:25:51 -07:00
xster
b232a84b0d
Auto provision iOS deploy 1/3 - find and use the first valid code signing certs ( #9946 )
...
* blind wrote everything except the user prompt
* works
* Add some logical refinements
* Make certificates unique and add more instructinos
* print more info
* Add test
* use string is empty
* review notes
* some formatting around commands
* add a newline
2017-05-15 12:54:32 -07:00
Ian Hickson
db84df230d
Some tools to dump other trees. ( #9999 )
2017-05-12 15:51:58 -07:00
Ian Hickson
292abf7223
"flutter packages pub ..." to passthrough to dart pub ( #10044 )
2017-05-12 15:40:35 -07:00
Ian Hickson
7c9c5a296c
Rearrange tests to more closely match code structure ( #10043 )
2017-05-12 10:44:52 -07:00
Ian Hickson
18eac03d76
VerboseLogger should just wrap the parent Logger ( #10020 )
...
This way, you can test things even with a VerboseLogger.
2017-05-12 10:00:11 -07:00
Devon Carew
2f737cf94e
change a printStatus() to a printTrace() ( #9992 )
2017-05-11 08:49:26 -07:00
Ian Hickson
dddf572780
Minor tweaks to flutter doctor ( #9963 )
2017-05-10 16:28:12 -07:00
Todd Volkert
ff7d9432b8
Allow for different adb server version messages in device detection ( #9974 )
2017-05-10 15:51:08 -07:00
Jason Simmons
d1fa21166b
Use runCommand to start sdkmanager and adjust the executable name for Windows ( #9962 )
...
Fixes https://github.com/flutter/flutter/issues/9954
2017-05-10 12:42:42 -07:00
Alexandre Ardhuin
1f0b2d8a68
bump to linter-0.1.31 ( #9947 )
2017-05-10 08:20:13 +02:00
Ian Hickson
9f1d5ba50e
Rev versions for alpha cut ( #9940 )
...
And add a script to rev the versions.
2017-05-09 17:06:52 -07:00
Jason Simmons
d780c4b205
Revert "Gracefully handle !isValid in AndroidStudio.gradleExecutable ( #9893 )" ( #9934 )
...
Fixes https://github.com/flutter/flutter/issues/9929
2017-05-09 13:11:29 -07:00
Todd Volkert
a667bf935e
Gracefully handle !isValid in AndroidStudio.gradleExecutable ( #9893 )
...
Fixes #9866
2017-05-09 10:54:54 -07:00
Jason Simmons
f44ba8b9c9
Add a flutter doctor --android-licenses command that locates and runs the Android SDK license manager ( #9892 )
...
See https://github.com/flutter/flutter/issues/8438
2017-05-09 10:18:45 -07:00
Michael Thomsen
5cec108023
Roll android build tools to 25.0.3 ( #9922 )
...
* Roll android build tools to 25.0.3
* Roll android build tools to 25.0.3 in templates
2017-05-09 18:58:46 +02:00
Mikkel Nygaard Ravn
76dbfe9a38
Fixed android template ( #9917 )
2017-05-09 14:41:39 +02:00
Mikkel Nygaard Ravn
200952bc65
Fix of android template ( #9915 )
2017-05-09 14:24:32 +02:00
Mikkel Nygaard Ravn
c1feee93d3
iOS plugin registry ( #9818 )
2017-05-09 12:00:07 +02:00
Mikkel Nygaard Ravn
24a3e58cd0
Android plugin registry ( #9715 )
2017-05-09 11:43:19 +02:00
Yegor
aba6095444
make zero-device test hermetic ( #9891 )
2017-05-08 17:57:20 -07:00
Michael Goderbauer
ca4d7211b0
Enforce valid package names on flutter create ( #9854 )
...
* Enforce valid package names on flutter create
Fixes #9564
* refactor
* fix other tests
2017-05-08 14:08:59 -07:00
Yegor
fa47c34f76
fix version stamp Map check ( #9890 )
2017-05-08 12:59:33 -07:00
Todd Volkert
a29585298e
Add level field to the "showMessage" daemon event. ( #9889 )
...
Spawned from a discussion in https://github.com/flutter/flutter-intellij/pull/1003
2017-05-08 11:49:47 -07:00
Michael Thomsen
a625d3e140
Revert "Upgrade to most recent android build tools version ( #9878 )" ( #9888 )
...
This reverts commit 5ed2984e75
2017-05-08 20:33:12 +02:00
Michael Thomsen
5ed2984e75
Upgrade to most recent android build tools version ( #9878 )
2017-05-08 20:12:32 +02:00
xster
31b958378a
Report flutter doctor success/failure ( #9664 )
...
* record doctor failures
* fully mock out analytics dependencies
2017-05-08 11:10:36 -07:00
xster
c74225e00d
Report timing on failed executions too ( #9661 )
...
* handle errors
* review notes
2017-05-08 11:10:21 -07:00
P.Y. Laligand
8cef5232d5
Use the correct set of options to analyze Flutter packages. ( #9758 )
...
This affects the Fuchsia build which will soon run analysis by default.
2017-05-05 17:18:58 -07:00
Michael Goderbauer
6337a0553c
Don't crash on flutter create . on Windows ( #9850 )
...
* Don't crash on `flutter create .`
Fixes #9828
* review comments
2017-05-05 15:47:13 -07:00
Todd Volkert
2841497344
Support IPv6 in coverage collection ( #9841 )
...
Builds on engine fixes to #9813
Also fixes #7366
2017-05-05 11:09:55 -07:00
Jakob Andersen
6b54137a15
Improve Android builds. ( #9801 )
...
Eagerly generate local.properties, and always update the flutter.sdk
setting in it, in case FLUTTER_ROOT has changed.
Fixes #8365 .
Fixes #9716 - at least the specific issue reported. My Android Studio
still complains about Gradle versions - it ships with v3.2, but requires
v3.3...
Add a 'generate dependencies' task to the Gradle build, which checks if
the snapshot dependencies file exists, and runs an extra build before
the actual FlutterTask if it doesn't. This makes the first build slower,
but sub-sequent builds (without source changes) much faster.
Fixes #9717 .
2017-05-05 14:53:51 +02:00
Jakob Andersen
7818ea43dc
Workaround for intermittent pub crash on macOS. ( #9832 )
...
Eagerly initialize libnotify by accessing the current date. See dart-lang/sdk#29539 for details.
Fixes #9727 .
2017-05-05 13:30:48 +02:00
Jason Simmons
b7ceed6b9d
Handle missing directories in the flutter doctor IntelliJ check ( #9812 )
2017-05-04 14:48:41 -07:00
xster
837f101056
Let (almost) all flutter create CocoaPods references be dynamically generated later ( #9791 )
...
* Remove all initial cocoapod traces from flutter create except Podfile
* Make updateXcodeGeneratedProperties parameters named
* review notes
2017-05-04 12:26:58 -07:00
Ian Hickson
e504dabdd2
Minor style tweaks ( #9766 )
2017-05-04 10:28:17 -07:00
Todd Volkert
ba4bba7498
Support IPv6 in test platform ( #9795 )
2017-05-03 22:50:24 -07:00
Todd Volkert
6a4b08bec6
Make DeviceDomain echo a msg if doctor says it can't list anything ( #9749 )
...
This message will be picked up by IntelliJ and shown to the user in a toast.
2017-05-03 16:12:08 -07:00
xster
b8b6a14d8b
Make a few error messages bold ( #9774 )
2017-05-03 16:01:04 -07:00
Todd Volkert
3b5b46b07c
Revert "Switch test platform to use IPv6 ( #9775 )" ( #9779 )
...
This reverts commit 9f5fa31ebd
2017-05-03 14:46:28 -07:00
Todd Volkert
9f5fa31ebd
Switch test platform to use IPv6 ( #9775 )
2017-05-03 14:33:38 -07:00
xster
2051669ac7
CocoaPods flow step 2 - don't pod install unless project has plugins ( #9741 )
...
* Revert "Revert "Don't try to resolve CocoaPods unless project has plugins" (#9719 )"
This reverts commit f739e9e022
2017-05-03 11:19:59 -07:00
xster
87d0010adb
Let printError be able to print bold also ( #9714 )
...
* Let printError print bold as well
* review notes
2017-05-02 22:20:14 -07:00
Todd Volkert
31000ef77e
Remove unused code in adb.dart ( #9732 )
2017-05-02 21:12:28 -07:00
xster
85b2b86939
CocoaPods flow step 3 - don't automatically pod setup ( #9703 )
...
* Don’t automatically pod setup if the user never did it
* fix/add test
* rename getters
2017-05-02 16:11:37 -07:00
Devon Carew
7fb6646c96
fix an issue with reloading when paused at a breakpoint ( #9733 )
...
* fix an issues with reloading when paused at a breakpoint
* update docs
2017-05-02 16:09:57 -07:00
Michael Goderbauer
c256e6d557
Populate PUB_ENVIRONMENT for initial pub get and correctly detect APPVEYOR as bot ( #9725 )
...
* Populate PUB_ENVIRONMENT for initial pub get
* review comments
* change order
2017-05-02 11:25:59 -07:00
Devon Carew
6957eabe2c
tweak the doctor check for host compatibility ( #9720 )
2017-05-02 10:32:00 -07:00
Ian Hickson
f739e9e022
Revert "Don't try to resolve CocoaPods unless project has plugins" ( #9719 )
...
* Revert "Document ScrollController (#9705 )"
This reverts commit ff8609f273#9713 )"
This reverts commit aace622d3f#9712 )"
This reverts commit 1a4bf9b66d#9704 )"
This reverts commit ffa8483f3b#9699 )"
This reverts commit 3b237a8c62#9701 )"
This reverts commit 732f79eed7
2017-05-02 08:57:05 -07:00
xster
732f79eed7
Don’t pod unless there are plugins ( #9701 )
2017-05-01 13:37:45 -07:00
xster
9a61b8713c
CocoaPods flow step 1 ( #9687 )
...
* Add cocoapods reason
* s/native/iOS
2017-05-01 12:47:25 -07:00
Todd Volkert
9c1aba2abe
Skip adb server restarts during device discovery ( #9693 )
2017-05-01 10:10:16 -07:00
Devon Carew
6716904385
return the result from calling a service extension ( #9636 )
2017-04-28 07:39:14 -07:00
xster
66ed8de745
Record flutter run success/fail, build mode, platform, start time in analytics ( #9597 )
...
FlutterCommand.runCommand subclasses can optionally return a FlutterCommandResult which is used to append additional analytics.
Fix flutter run timing report and add a bunch of dimensional data
2017-04-27 15:28:15 -07:00
Michael Goderbauer
b432af51fd
Don't crash when ADB exits with non-zero exit code ( #9653 )
2017-04-27 14:57:56 -07:00
Todd Volkert
ffdca6f7e8
Fix getDevicesById() ( #9646 )
...
If the user specified a non-exact device id, it was producing
an exception whereby we were trying to listen to the
`getAllConnectedDevies()` stream twice.
2017-04-27 13:12:59 -07:00
Devon Carew
9ac2e44ee7
add a regression test for daemon device notification ( #9618 )
...
* add a regression test for daemon device notification
* revert event send simplification
2017-04-27 09:30:47 -07:00
P.Y. Laligand
d2c6b0a637
Get rid of unnecessary flutter_root argument. ( #9622 )
2017-04-27 09:10:48 -07:00
Zachary Anderson
0770c3c14f
[flutter_tools] Adds some support for '-d all' ( #9585 )
2017-04-26 21:49:38 -07:00
Todd Volkert
e2cd78358f
Fix missing await ( #9617 )
...
Fixes #9612
2017-04-26 13:14:31 -07:00
Michael Goderbauer
b7ec82014d
move collection to dev dependency ( #9613 )
2017-04-26 10:38:11 -07:00
Michael Goderbauer
460561bad8
Make Flutter plugins usable from a Windows host ( #9599 )
...
Note: In a cross-platform context `Uri.path` is not a valid file path. Allways use `fs.path.fromUri` to convert.
2017-04-26 10:02:22 -07:00
Todd Volkert
aaaae265ae
Run async when calling adb shell getprop ( #9611 )
...
Also, add a timeout so a hung `adb` will not cause the
tools process to hang.
Fixes #9567
2017-04-26 09:58:20 -07:00
Todd Volkert
21f57a85e8
Wait for stderr in runCommandAndStreamOutput() ( #9598 )
2017-04-25 17:40:28 -07:00
Todd Volkert
60c5ffc1a9
Switch many Device methods to be async ( #9587 )
...
`adb` can sometimes hang, which will in turn hang the Dart isolate if
we're using `Process.runSync()`. This changes many of the `Device` methods
to return `Future<T>` in order to allow them to use the async process
methods. A future change will add timeouts to the associated calls so
that we can properly alert the user to the hung `adb` process.
This is work towards #7102 , #9567
2017-04-25 17:23:00 -07:00
Michael Goderbauer
ad1c497c03
Do not lower-case paths during canonicalization. ( #9571 )
...
* Do not lower-case paths during canonicalization.
This breaks hot reload on some platfroms with case insensitive file systems.
* Add unit tests
2017-04-25 10:34:43 -07:00
Alexandre Ardhuin
31828609dc
add @required ( #9579 )
2017-04-25 08:59:43 +02:00
Todd Volkert
a3f0f6911b
Remove replay test ( #9542 )
...
It's going to be replaced by #8963
Fixes #8947
2017-04-24 08:47:38 -07:00
Michael Thomsen
f10326d28e
Add app id to build.gradle template ( #9552 )
2017-04-24 17:13:04 +02:00
Michael Thomsen
c313984409
Exclude generated PluginRegistry files from git ( #9555 )
2017-04-24 15:23:18 +02:00
Michael Thomsen
7a57d37195
Add Pods cache dir to ios/.gitignore ( #9464 )
...
* Add Pods cache dir to ios/.gitngnore
* Add missing ending newlines
2017-04-21 13:18:05 +02:00
