Emmanuel Garcia
2cf8213468
Break down flutter doctor validations and results ( #34624 )
2019-06-25 10:22:08 -07:00
Jonah Williams
25b5656969
Reland: rename web device ( #34885 )
2019-06-24 11:09:07 -07:00
Danny Tuppeny
8dbfc82bc7
Tweak the display name of emulators ( #34785 )
2019-06-24 11:41:02 +01:00
Todd Volkert
bb6c3f8131
Remove flutter_tools support for old AOT snapshotting ( #34895 )
...
Android now exclusively uses ELF shared libraries, and
iOS uses assembly.
2019-06-22 19:30:24 -07:00
Jonah Williams
d644015620
Revert "set web device name to Chrome ( #34856 )" ( #34884 )
2019-06-21 15:04:44 -07:00
Jonah Williams
19d7925f1f
set web device name to Chrome ( #34856 )
2019-06-21 14:26:25 -07:00
Jonah Williams
25a3121dfd
Prefer ephemeral devices from command line run ( #34802 )
2019-06-20 14:33:58 -07:00
Jenn Magder
fa491fc9fe
Close platform when tests are complete (dispose compiler and delete font files) ( #34685 )
2019-06-20 08:47:54 -07:00
Jonah Williams
b9932d55e7
Add linux doctor implementation ( #34755 )
2019-06-20 08:20:57 -07:00
Jonah Williams
830fb38640
Revert "Add basic desktop linux checks ( #31873 )" ( #34753 )
...
This reverts commit f221ad1f92
2019-06-19 16:03:05 -07:00
Jonah Williams
f221ad1f92
Add basic desktop linux checks ( #31873 )
2019-06-19 15:51:21 -07:00
Jonah Williams
d4d10dac61
Revert "Check whether FLUTTER_ROOT and FLUTTER_ROOT/bin are writable. ( #34291 )" ( #34750 )
...
This reverts commit 49449505b6
2019-06-19 15:37:04 -07:00
Jonah Williams
0d9a1b201e
Remove environment variable guards for command line desktop and web ( #33867 )
2019-06-19 13:39:27 -07:00
Jonah Williams
7851a75183
Fix NPE in flutter tools ( #34725 )
2019-06-19 11:43:06 -07:00
Jonah Williams
0d4f4bddb6
Don't crash on invalid .packages file in initial run( #34527 )
2019-06-19 10:52:23 -07:00
Jonah Williams
49449505b6
Check whether FLUTTER_ROOT and FLUTTER_ROOT/bin are writable. ( #34291 )
2019-06-19 09:12:43 -07:00
Danny Tuppeny
d9983e1be7
Add category/platformType to emulators ( #34721 )
2019-06-19 17:10:39 +01:00
Jonah Williams
7472fad194
Remove most of the target logic for build web, cleanup rules ( #34589 )
2019-06-18 17:04:11 -07:00
Jonah Williams
5c52498d4e
Add device category, ephemeral, platformType for daemon ( #33990 )
2019-06-18 15:23:14 -07:00
Jonah Williams
73330e1241
Remove compilation trace and dynamic support code ( #34529 )
2019-06-18 15:22:04 -07:00
Jenn Magder
8be46a0c4a
Kill compiler process when test does not exit cleanly ( #34616 )
2019-06-18 11:24:19 -07:00
stuartmorgan
cc541e6724
Add missing pieces for 'driver' support on macOS ( #34376 )
...
- Adds desktop projects to ApplicationPackageStore
- Plumbs target overrides through the macOS build
2019-06-18 11:14:46 -07:00
Jonah Williams
a772d4d314
retry on HttpException ( #34526 )
2019-06-17 10:48:01 -07:00
Josh Burton
07dc236237
Handles parsing APK manifests with additional namespaces or attributes ( #34535 )
2019-06-16 00:18:38 -07:00
Zachary Anderson
dfecafa4ab
[flutter_tool,fuchsia] Update the install flow for packaging migration. ( #34447 )
2019-06-14 09:46:23 -07:00
Todd Volkert
530824f423
Skip flaky test on Windows ( #34464 )
...
https://github.com/flutter/flutter/issues/34446
2019-06-13 17:56:07 -07:00
Emmanuel Garcia
afdc783ce5
Report commands that resulted in success or failure ( #34288 )
...
This is added as a dimension cd26
2019-06-13 10:27:23 -07:00
Todd Volkert
8163c0aebb
Re-apply compressionState changes. ( #34341 )
...
This re-applies the changes that were made in #33697 and #33729 ,
but which were reverted in #33792 and #33790 , respectively due to
the Dart SDK not having received the update within Google yet.
The SDK has now rolled, so these changes can be re-applied.
https://github.com/flutter/flutter/issues/32374
https://github.com/flutter/flutter/issues/33791
2019-06-12 13:47:47 -07:00
Zachary Anderson
22ca3f96ca
[flutter_tool] Don't truncate verbose logs from _flutter.listViews ( #34255 )
2019-06-12 11:18:53 -07:00
Todd Volkert
fb2f18e7e8
Prepare for Uint8List SDK breaking changes ( #34295 )
...
https://github.com/dart-lang/sdk/issues/36900
2019-06-12 10:22:50 -07:00
Emmanuel Garcia
d9c1962973
Instrument usage of include_flutter.groovy and xcode_backend.sh ( #34189 )
...
This is done via `flutter build bundle`. As a consequence, this PR introduces a new way to disable analytics via the `FLUTTER_SUPPRESS_ANALYTICS` env flag.
2019-06-11 14:46:00 -07:00
Jason Simmons
89d887f331
Strip debug symbols from ELF library snapshots ( #34250 )
...
AOT compiled code is now packaged as an ELF library for Android targets.
By default gen_snapshot's output contains debug symbols. The symbols could
be stripped as a separate step, but that requires NDK tools that the user
may not have available.
This change passes a gen_snapshot flag that omits the symbols, and it filters
out a warning printed when that flag is used.
2019-06-11 13:34:24 -07:00
Ben Konyi
e59d9a815d
Reland "Added --dart-flags option to flutter run ( #33924 )" ( #34181 )
...
Reland "Added --dart-flags option to flutter run (#33924 )"
This reverts commit 587687eedf
2019-06-11 11:37:47 -07:00
Todd Volkert
1b3fc53595
Consider all non-interactive terminals to be bots ( #34179 )
2019-06-10 16:32:08 -07:00
Jonah Williams
f530b809b6
Reland: More verification on flutter build web, add tests and cleanup ( #34173 )
2019-06-10 15:37:23 -07:00
Jenn Magder
c8bf7abeee
Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system ( #34167 )
...
Updates the Podfile template to use the CocoaPod disable_input_output_paths installation option which prevents the [CP] Embed Pods Frameworks build phase from outputting the Flutter.framework files.
2019-06-10 14:30:28 -07:00
Emmanuel Garcia
8627ff433b
Allow multi-abi shared libraries in APKs and App bundles ( #34123 )
...
* Gradle generates ELF shared libraries instead of AOT snapshots.
* `flutter build apk/appbundle` supports multiple `--target-platform` and defaults to `android-arm` and `android-arm64`.
* `flutter build apk` now has a flag called `--split-per-abi`.
2019-06-10 13:16:09 -07:00
Jonah Williams
71bfe3be9f
Revert "More verification on flutter build web, add tests and cleanup ( #34090 )" ( #34166 )
2019-06-10 12:01:14 -07:00
Jonah Williams
354ce1aa5a
More verification on flutter build web, add tests and cleanup ( #34090 )
2019-06-10 11:27:25 -07:00
Alexander Aprelev
d91797807e
Report async callback errors that currently go unreported. ( #34081 )
...
* Report async callback errors that currently go unreported.
* Add a test
2019-06-10 09:52:22 -07:00
Jonah Williams
f8f7b89976
Revert "Generate ELF shared libraries and allow multi-abi libs in APKs and App bundles ( #33696 )" ( #34121 )
2019-06-08 18:43:25 -07:00
Emmanuel Garcia
966b15b4a4
Generate ELF shared libraries and allow multi-abi libs in APKs and App bundles ( #33696 )
...
* Gradle generates ELF shared libraries instead of AOT snapshots.
* `flutter build apk/appbundle` supports multiple `--target-platform` and defaults to `android-arm` and `android-arm64`.
* `flutter build apk` now has a flag called `--split-per-abi`.
2019-06-08 18:02:32 -07:00
Jonah Williams
587687eedf
Revert "Added --dart-flags option to flutter run ( #33924 )" ( #34092 )
2019-06-07 19:33:14 -07:00
Ben Konyi
67a529b895
Added --dart-flags option to flutter run ( #33924 )
2019-06-07 18:53:42 -07:00
Jonah Williams
317e4cb013
don't warn on CHROME_EXECUTABLE missing if we've already located it. ( #34079 )
2019-06-07 18:16:54 -07:00
Josh Burton
9223a44b8a
Adds the androidX flag to a modules pubspec.yaml template so it is se… ( #34066 )
...
This is a small follow up to the previous AndroidX PR: https://github.com/flutter/flutter/pull/31028
This fixes an issue mentioned [here](https://github.com/flutter/flutter/issues/28805 ) where the androidX flag for a module is not set when creating a new project:
`flutter create --androidx -t module my_flutter`
2019-06-07 16:09:21 -07:00
Jonah Williams
c91b657116
Codegen an entrypoint for flutter web applications ( #33956 )
2019-06-06 21:05:55 -07:00
stuartmorgan
fb8df82c06
Add 'doctor' support for Windows ( #33872 )
...
Moves the logic for finding vcvars64.bat to a new VisualStudio class
that encapsulates finding, and providing information about, VisualStudio
installations. Adds a validator for it, and runs it for Windows
workflows in doctor.
2019-06-06 14:02:27 -07:00
Alexander Aprelev
30dbc4c767
Whitelist adb.exe heap corruption exit code. ( #33951 )
...
* Whitelist adb.exe heap corruption exit code.
In android platform tools 29.0.0 adb.exe shell seems to be exiting with heap corruption exit code, otherwise producing results as expected. This PR whitelists this exit code on Windows.
Fixes https://github.com/flutter/flutter/issues/33938 .
* Fix condition
* Fix 'shell am start' command
* Fix stop command
* Refactor into runAdbMostlyChecked(Sync/Async)
* runAdbMostlyChecked -> runAdbChecked
2019-06-06 12:01:03 -07:00
Zachary Anderson
5555725fe3
[flutter_tool] Fix 'q' for Fuchsia profile/debug mode ( #33846 )
2019-06-06 11:16:19 -07:00
Jonah Williams
7548614350
Prevent windows web doctor from launching chrome ( #33874 )
2019-06-05 15:16:50 -07:00
Jonah Williams
50ea6f32d3
add benchmarks to track web size ( #33892 )
2019-06-05 12:40:21 -07:00
Jenn Magder
035e3d37d7
Revert "Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system ( #33852 )" ( #33882 )
...
This reverts commit d053fe5cb3
2019-06-04 15:35:35 -07:00
Jenn Magder
d053fe5cb3
Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system ( #33852 )
...
Updates the Podfile template to use the CocoaPod disable_input_output_paths installation option which prevents the [CP] Embed Pods Frameworks build phase from outputting the Flutter.framework files.
2019-06-04 12:17:57 -07:00
Jonah Williams
83986acbdb
Add a real-er web restart, doctor, workflow ( #33786 )
2019-06-03 23:19:42 -07:00
Jenn Magder
9734f4ed43
Revert "Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system ( #33684 )"
...
This reverts commit ef792fc30d
2019-06-03 17:19:53 -07:00
Jenn Magder
ef792fc30d
Disable CocoaPods input and output paths in Xcode build phase and adopt new Xcode build system ( #33684 )
...
Updates the Podfile template to use the CocoaPod disable_input_output_paths installation option which prevents the [CP] Embed Pods Frameworks build phase from outputting the Flutter.framework files.
2019-06-03 16:11:33 -07:00
Todd Volkert
52fc807dd2
Remove references to HttpClientResponseCompressionState ( #33792 )
...
https://github.com/flutter/flutter/issues/33791
2019-06-03 14:53:43 -07:00
Dan Field
639c9935ae
wire in fuchsiaApp ( #33781 )
2019-06-03 14:31:56 -07:00
Chris Bracken
98ea501995
Revert "Add real-er restart for web using webkit inspection protocol ( #33629 )" ( #33703 )
...
Revert "fix devicelab manfiest (#33698 )"
This reverts commit 5a6a00dc540d79f0fc79
2019-05-31 21:53:30 -07:00
Chris Bracken
2467c528f5
Roll engine 69ebe5fb28fc..a4b7d1c2895d (3 commits) ( #33697 )
...
69ebe5fb28..68a3ca46b4#9158 )
68a3ca46b Roll src/third_party/dart 445a23a9bc..0e6b74543c (29 commits) (#9159 )
1d1cff1fa Roll src/third_party/skia 3cd435eecf5e..09f5aedf2cc8 (3 commits) (#9160 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-05-31 21:17:43 -07:00
Josh Burton
d0e45a2369
Adds support for generating projects that use AndroidX support libraries ( #31028 )
2019-05-31 18:33:02 -07:00
Jonah Williams
5a6a00dc54
Add real-er restart for web using webkit inspection protocol ( #33629 )
2019-05-31 17:37:01 -07:00
stuartmorgan
3ebebebb8d
Implement plugin tooling support for macOS ( #33636 )
...
Enables the CocoaPods-based plugin workflow for macOS. This allows a
macOS project to automatically fetch and add native plugin
implementations via CocoaPods for anything in pubspec.yaml, as is done
on iOS.
2019-05-31 13:19:44 -07:00
Jonah Williams
27876e09be
Revert "Devfs cleanup and testing ( #33374 )" ( #33673 )
...
This reverts commit 445505d6f2
2019-05-31 13:17:12 -07:00
Jonah Williams
445505d6f2
Devfs cleanup and testing ( #33374 )
2019-05-30 16:13:46 -07:00
Jonah Williams
7263c127ed
Add local overrides to testbed and provide more defaults ( #33264 )
2019-05-29 22:49:53 -07:00
Jonah Williams
da600bacfe
Reland - Wire up hot restart and incremental rebuilds for web ( #33533 )
2019-05-29 22:46:28 -07:00
Emmanuel Garcia
3bbdf017c4
Add to app measurement ( #33458 )
2019-05-29 20:56:28 -07:00
Jason Simmons
311cde98a6
Reland "Clean up some flutter_tools tests and roll dependencies" ( #33225 )
...
This relands flutter/flutter#33163 with a fix to the integration_ui test.
2019-05-29 19:04:35 -07:00
Zachary Anderson
b84ac50dfe
[flutter_tool] Misc. fixes for Fuchsia ( #33466 )
2019-05-29 15:37:07 -07:00
stuartmorgan
79ae04d4ed
Build the solution on Windows ( #33528 )
...
Switch from building Runner.vcxproj to Runner.sln on Windows, to allow
for multiple-project builds (e.g., separate plugin projects).
2019-05-29 13:17:23 -07:00
Jonah Williams
925f5f1c53
Revert "Wire up hot restart and incremental rebuilds for web ( #33197 )" ( #33529 )
...
This reverts commit 52ae99682e
2019-05-29 12:09:01 -07:00
Zachary Anderson
8139a368ea
[flutter_tool] Use product runner in Fuchsia release build ( #33282 )
2019-05-29 10:08:58 -07:00
Jonah Williams
52ae99682e
Wire up hot restart and incremental rebuilds for web ( #33197 )
2019-05-29 09:49:16 -07:00
stuartmorgan
aecf053ee0
Use vswhere to find Visual Studio ( #33448 )
...
Rather than hard-coding a set of locations to check, use vswhere (which
is installed by VS 2017 and later), and construct the vcvars64.bat path
relative to that. This will allow Windows builds to work without special
configuration for people who have VS installed at a custom path.
Also adds error logging with different messages for each failure point,
so that rather than the not-very-informative 'failed to find
vcvars64.bat' message, the failure will provide feedback about what to
do.
This is an interim solution; later this will be replaced by a
VisualStudio class with associated validator to match the structure of
the other toolchains.
Fixes #33249
2019-05-29 09:17:17 -07:00
stuartmorgan
e1a784ae3f
Wrap Windows build invocation in a batch script ( #33443 )
...
Invoking msbuild with runInShell makes handling path escaping more
error-prone, and substantially increases the chances of running into
maximum path limits. This replaces the direct call with a .bat wrapper
that calls vsvars64.bat then msbuild, and uses relative paths within the
script to keep command lengths short.
Fixes https://github.com/flutter/flutter/issues/32792
2019-05-28 21:53:03 -07:00
Jonah Williams
8e3e0a89f4
Revert "Instrument add to app flows ( #33297 )" ( #33449 )
...
This reverts commit faec4ca361
2019-05-28 12:52:58 -07:00
Emmanuel Garcia
faec4ca361
Instrument add to app flows ( #33297 )
2019-05-28 11:11:20 -07:00
stuartmorgan
81c38b22cb
Implement macOS support in flutter doctor ( #33277 )
...
Splits Xcode validation out of the iOS validator and into a stand-alone
validator, and groups the CocoaPods validator with that top-level
validator instead of the iOS validator. iOS now validates only the
iOS-specific tools (e.g., ideviceinstaller).
Reorganizes many of the associated clases so that those that are used by
both macOS and iOS live in macos/ rather than ios/. Moves some
validators to their own files as part of the restructuring.
This is the macOS portion of #31368
2019-05-24 22:51:02 -04:00
Chris Bracken
156b4220b4
Americanise spellings ( #33323 )
...
Updates documentation and non-public API to use American spellings for
consistency with the rest of the codebase.
No changes to behaviour... other than how it's spelt.
2019-05-24 19:13:02 -07:00
Chris Bracken
4d9923201b
Correct typos ( #33322 )
...
Corects a bnuch of typeos throuhgout teh Fluter codebsae.
Made use of the `misspell` tool:
https://github.com/client9/misspell
2019-05-24 19:12:45 -07:00
Zachary Anderson
f5827f0f07
[flutter_tool] Improve Fuchsia 'run' tests ( #33263 )
2019-05-24 07:48:41 -07:00
Emmanuel Garcia
12a0e475e2
Make paths absolute in settings.gradle ( #33228 )
2019-05-23 23:32:11 -07:00
Jonah Williams
1bd85dd6c2
disable flaky devfs test ( #33285 )
2019-05-23 17:05:29 -07:00
stuartmorgan
ef9866bf27
Build macOS via workspace, rather than project ( #33198 )
...
This is necesasry to integrate CocoaPods, since CocoaPods operates
primarily on the workspace rather than the project.
2019-05-22 19:58:29 -04:00
Jonah Williams
a30ffb60ad
Revert "Clean up some flutter_tools tests and roll dependencies ( #33163 )" ( #33206 )
2019-05-22 12:20:02 -07:00
Ian Hickson
e5f81e1048
Clean up some flutter_tools tests and roll dependencies ( #33163 )
...
* Clean up some flutter_tools tests
* Remove arbitrary retry that happens even for fundamental errors, and generally clean up _DevFSHttpWriter.
* Update dependencies (requires fixes; see next commit)
* Fixes for new dependencies.
2019-05-22 09:31:37 -07:00
Christopher Fujino
041755faad
don't send crash reports if on a user branch ( #33078 )
...
* don't send crash reports if on a user branch.
* add test to test/crash_reporting_test.dart
2019-05-21 11:58:41 -07:00
Zachary Anderson
94ce956f0a
[flutter_tool] Adds support for 'run' for Fuchsia devices ( #32849 )
2019-05-21 08:49:43 -07:00
Michael Thomsen
7ae3caf309
Rename flutter packages to flutter pub ( #33041 )
2019-05-21 16:38:58 +02:00
Sam Rawlins
c2a93bd545
Fix missing return statements on function literals ( #33058 )
2019-05-20 12:51:57 -07:00
Devon Carew
50a9c31f5e
reduce retry attempts for flutter creatte --list-samples ( #32833 )
2019-05-16 18:20:30 -07:00
Alexandre Ardhuin
4fa32df141
use null aware operators ( #32711 )
...
* use null aware operators
* rollback changes about null-aware operator
* disable lint prefer_is_not_empty
2019-05-16 22:25:51 +02:00
stuartmorgan
6722fb448c
Teach flutter msbuild for Windows ( #32335 )
...
Eliminates the need for a build.bat in the Windows build workflow, adding
preliminary support for building using msbuild. The handling of
vcvars64.bat may be refined in the future, but this serves as a starting point.
2019-05-14 19:24:40 -04:00
Zachary Anderson
8841afeb1f
[flutter_tool] Build a Fuchsia package ( #32519 )
2019-05-14 10:59:23 -07:00
Jonah Williams
8b0243f413
Teach Linux to use local engine ( #31631 )
2019-05-11 00:08:29 -07:00
Sam Rawlins
9c77e8e8a0
Fix missing return statements on function literals ( #31825 )
2019-05-09 12:43:51 -07:00
Jonah Williams
eb996afaa8
make hotfix use a plus instead of minus ( #32060 )
2019-05-07 10:11:00 -07:00
Zachary Anderson
61236c873e
[flutter_tool] In 'attach' use platform dill and patched sdk dir from the Fuchsia SDK ( #32071 )
2019-05-06 09:26:58 -07:00
