Hans Muller
0d4b5ae122
Dev, examples/api, etc updated for Material 3 by default ( #129683 )
...
Updated tests in dev, examples/api, and tests/widgets to ensure that
they continue to pass when the default for `ThemeData.useMaterial3` is
changed to true.
This is the final set of changes required for
https://github.com/flutter/flutter/issues/127064 .
2023-06-28 09:41:58 -07:00
Devin
5047690b53
ExpansionPanel isExpanded callback parameter (Ticket 74114) ( #128082 )
...
Fixes https://github.com/flutter/flutter/issues/74114
This PR addresses the issue detailed here: https://github.com/flutter/flutter/issues/74114 . The boolean isExpanded returned by the expansion panel callback now reflects the state of the panel that the user is seeing. If it's expanded on screen then the callback returns true. When you close the panel the callback returns false. When another panel is open and you open a different one, the callback executes twice. It returns isExpanded == false for the panel you are closing and true for the panel that is being opened.
I had to change the code in a couple existing tests because some tests are using the old behavior of the callback. This PR addresses feedback listed in closed PR -> https://github.com/flutter/flutter/pull/127876 . The reasone the original PR is closed is that I was having some struggles with git. A couple of the commits in this PR are just reverts of commits I meant not to happen.
Pre-launch Checklist
[ X] I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview ) and followed the process outlined there for submitting PRs.
[ X] I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene ) wiki page, which explains my responsibilities.
[ X] I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo ), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement ).
[ X] I signed the [CLA](https://cla.developers.google.com/ ).
[ X] I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
[ X] I added new tests to check the change I am making, or this PR is [test-exempt](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests ).
[ X] All existing and new tests are passing.
2023-06-09 17:47:59 +00:00
Tomasz Gucio
99c7e9f088
Add spaces after flow control statements ( #126320 )
2023-05-15 11:07:30 +02:00
Jacob MacDonald
b212e7b32b
implement Iterator and Comparable instead of extending them ( #123282 )
...
implement Iterator and Comparable instead of extending them
2023-03-23 17:10:31 +00:00
Michael Goderbauer
fda9ecfef7
Remove 1745 decorative breaks ( #123259 )
...
Remove 1745 decorative breaks
2023-03-22 21:12:22 +00:00
Lioness100
26b6c1bedd
Fix typos ( #121171 )
...
* Fix typos
* lowercase animated & opacity
* Undo typo fix
---------
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
Michael Goderbauer
b0f1714b7b
Make Flex,Row,Column const for real ( #119673 )
...
* Make Flex,Row,Column const for real
* dart fix --apply
* fix snippets
* fix integration test
* add comment
2023-02-02 19:33:57 +00:00
Michael Goderbauer
fdc25a1700
Reland "Remove single-view assumption from ScrollPhysics ( #117503 )" ( #117916 )
...
This reverts commit c956121ac0
2023-01-03 21:34:08 +00:00
Xilai Zhang
c956121ac0
Revert "Remove single-view assumption from ScrollPhysics ( #117503 )" ( #117647 )
...
This reverts commit 999356b776
2022-12-27 21:22:16 +00:00
Michael Goderbauer
999356b776
Remove single-view assumption from ScrollPhysics ( #117503 )
...
* Remove single-view assumption from ScrollPhysics
* fix scrollable_dispose_test.dart
* add deprecated method back
2022-12-22 21:54:09 +00:00
Michael Goderbauer
81bc54be75
Enable use_colored_box lint ( #117370 )
2022-12-20 14:09:55 -08:00
Greg Spencer
37b72342b0
Add maybeOf for all the cases where of returns nullable. ( #114120 )
2022-10-31 23:09:09 +00:00
Dan Field
eaff1562a9
Dispose Paragraph objects ( #110627 )
2022-09-06 20:45:55 +00:00
Pierre-Louis
8853926601
Deprecate ThemeData errorColor and backgroundColor ( #110162 )
2022-09-02 04:02:55 +00:00
Pierre-Louis
0c2f7bc2a2
Remove errant double spaces ( #110758 )
2022-09-02 04:00:58 +00:00
Kate Lovett
7e12b37111
Deprecate 2018 text theme parameters ( #109817 )
2022-08-22 20:00:34 +00:00
Michael Goderbauer
10a7c9ba22
Unify analysis options ( #108462 )
2022-07-28 09:07:49 -07:00
Darren Austin
2532584bf3
Update parameters to the styleFrom button methods. ( #105291 )
...
* Update parameters to the `styleFrom` button methods.
* Updated the Flutter fix data to point to this PR.
* Updated handling of background color to better maintain backwards compatibility with previous API.
2022-06-21 19:08:22 -07:00
Kate Lovett
784520bd04
Updating PrimaryScrollController for Desktop ( #102099 )
2022-06-09 16:49:45 -05:00
Alexandre Ardhuin
552c50e67c
more const immutable classes ( #104988 )
...
* more const immutable classes
* more const constructors in dev/ and examples/
2022-05-31 21:56:24 +02:00
Jason Simmons
275fb0286c
Fix avoid_redundant_argument_values analyzer warnings enabled in the latest Dart SDK ( #103734 )
...
See https://github.com/flutter/flutter/pull/103719
2022-05-13 12:57:59 -07:00
Alexandre Ardhuin
d40ee2149c
remove unnecessary .toString() ( #103226 )
2022-05-06 16:04:13 -07:00
Phil Quitslund
80849adee1
[dev, bots, examples] rename local functions with _s ( #102703 )
2022-04-28 10:44:06 -07:00
Michael Goderbauer
89b437e663
Prepare flutter_gallery for use_super_parameters ( #100515 )
2022-03-28 16:04:22 -07:00
Viren Khatri
671aa9e95e
complete migration of flutter repo to Object.hash* ( #99505 )
2022-03-04 12:56:21 -08:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint ( #98753 )
2022-02-22 14:39:20 -08:00
Konstantin Scheglov
06515fe058
Ignore in _Location ( #96553 )
2022-01-13 13:25:05 -08:00
Ian Hickson
840e109e07
Improve tracing ( #93086 )
2021-12-10 10:09:24 -08:00
Darren Austin
128c723445
Added Material 3 colors to ColorScheme. ( #93427 )
...
* Added the new Material 3 colors to ColorScheme.
* Deprecated primaryVariant and secondaryVariant colors in the ColorScheme.
* Added a flutter fix for the deprecated colors.
2021-11-23 13:56:16 -08:00
Ian Hickson
f90b019c68
Enable prefer_relative_imports and fix files. ( #91573 )
2021-10-11 10:28:07 -07:00
Ian Hickson
7b01346c5c
Enable no_default_cases lint ( #91530 )
2021-10-11 10:23:04 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be24
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Kate Lovett
68836deabf
Fix shrine ( #89698 )
2021-09-17 18:13:06 -07:00
Michael Goderbauer
b0e51db8d5
Fixes for upcoming changes to avoid_classes_with_only_static_members ( #86744 )
2021-07-20 16:12:12 -07:00
Hans Muller
3eca034ffd
AppBar.backwardsCompatibility now default false, deprecated ( #86198 )
2021-07-12 13:38:12 -07:00
Justin McCandless
32e6de84db
Remove out dated todos from integration tests with no issue links ( #85461 )
2021-06-28 13:21:03 -07:00
Hans Muller
93ca2b5ac0
Removed ButtonBar from flutter_gallery ( #85351 )
2021-06-28 13:01:04 -07:00
chunhtai
50a2fad986
Remove namesless todo ( #85151 )
2021-06-23 14:29:14 -07:00
Greg Spencer
88f3811055
Turn on avoid_dynamic_calls lint, except packages/flutter tests, make appropriate changes. ( #84476 )
...
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated.
Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
2021-06-14 14:16:57 -07:00
Anis Alibegić
c99ed373b3
Fixed large amount of spelling errors ( #83744 )
2021-06-02 10:14:06 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings ( #83407 )
2021-06-01 11:14:06 -07:00
Abhishek Ghaskata
e989d6b1fa
Assign late variable without initstate in flutter_gallery ( #83020 )
2021-05-24 18:59:03 -07:00
nt4f04uNd
80a2b6b015
Fix typos ( #82589 )
2021-05-20 17:19:09 -07:00
Alexandre Ardhuin
157bc92d4a
end of sort_child_properties_last ( #82457 )
2021-05-13 13:39:04 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint ( #81578 )
2021-05-10 16:26:16 -07:00
Alexandre Ardhuin
9bca38c5e5
remove unnecessary String.toString() ( #81859 )
2021-05-07 14:54:02 -07:00
Dan Field
0866005f70
Add benchmark for number of GCs in animated GIF ( #81240 )
2021-04-27 10:39:02 -07:00
Jason Simmons
a21a22a666
Convert AnimatedSize to a StatefulWidget ( #80554 )
2021-04-21 18:44:03 -07:00
