Devin
5047690b53
ExpansionPanel isExpanded callback parameter (Ticket 74114) ( #128082 )
...
Fixes https://github.com/flutter/flutter/issues/74114
This PR addresses the issue detailed here: https://github.com/flutter/flutter/issues/74114 . The boolean isExpanded returned by the expansion panel callback now reflects the state of the panel that the user is seeing. If it's expanded on screen then the callback returns true. When you close the panel the callback returns false. When another panel is open and you open a different one, the callback executes twice. It returns isExpanded == false for the panel you are closing and true for the panel that is being opened.
I had to change the code in a couple existing tests because some tests are using the old behavior of the callback. This PR addresses feedback listed in closed PR -> https://github.com/flutter/flutter/pull/127876 . The reasone the original PR is closed is that I was having some struggles with git. A couple of the commits in this PR are just reverts of commits I meant not to happen.
Pre-launch Checklist
[ X] I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview ) and followed the process outlined there for submitting PRs.
[ X] I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene ) wiki page, which explains my responsibilities.
[ X] I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo ), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement ).
[ X] I signed the [CLA](https://cla.developers.google.com/ ).
[ X] I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
[ X] I added new tests to check the change I am making, or this PR is [test-exempt](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests ).
[ X] All existing and new tests are passing.
2023-06-09 17:47:59 +00:00
Tomasz Gucio
99c7e9f088
Add spaces after flow control statements ( #126320 )
2023-05-15 11:07:30 +02:00
Michael Goderbauer
fda9ecfef7
Remove 1745 decorative breaks ( #123259 )
...
Remove 1745 decorative breaks
2023-03-22 21:12:22 +00:00
Michael Goderbauer
b0f1714b7b
Make Flex,Row,Column const for real ( #119673 )
...
* Make Flex,Row,Column const for real
* dart fix --apply
* fix snippets
* fix integration test
* add comment
2023-02-02 19:33:57 +00:00
Michael Goderbauer
81bc54be75
Enable use_colored_box lint ( #117370 )
2022-12-20 14:09:55 -08:00
Greg Spencer
37b72342b0
Add maybeOf for all the cases where of returns nullable. ( #114120 )
2022-10-31 23:09:09 +00:00
Pierre-Louis
8853926601
Deprecate ThemeData errorColor and backgroundColor ( #110162 )
2022-09-02 04:02:55 +00:00
Pierre-Louis
0c2f7bc2a2
Remove errant double spaces ( #110758 )
2022-09-02 04:00:58 +00:00
Kate Lovett
7e12b37111
Deprecate 2018 text theme parameters ( #109817 )
2022-08-22 20:00:34 +00:00
Michael Goderbauer
10a7c9ba22
Unify analysis options ( #108462 )
2022-07-28 09:07:49 -07:00
Darren Austin
2532584bf3
Update parameters to the styleFrom button methods. ( #105291 )
...
* Update parameters to the `styleFrom` button methods.
* Updated the Flutter fix data to point to this PR.
* Updated handling of background color to better maintain backwards compatibility with previous API.
2022-06-21 19:08:22 -07:00
Kate Lovett
784520bd04
Updating PrimaryScrollController for Desktop ( #102099 )
2022-06-09 16:49:45 -05:00
Alexandre Ardhuin
552c50e67c
more const immutable classes ( #104988 )
...
* more const immutable classes
* more const constructors in dev/ and examples/
2022-05-31 21:56:24 +02:00
Jason Simmons
275fb0286c
Fix avoid_redundant_argument_values analyzer warnings enabled in the latest Dart SDK ( #103734 )
...
See https://github.com/flutter/flutter/pull/103719
2022-05-13 12:57:59 -07:00
Alexandre Ardhuin
d40ee2149c
remove unnecessary .toString() ( #103226 )
2022-05-06 16:04:13 -07:00
Michael Goderbauer
89b437e663
Prepare flutter_gallery for use_super_parameters ( #100515 )
2022-03-28 16:04:22 -07:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint ( #98753 )
2022-02-22 14:39:20 -08:00
Konstantin Scheglov
06515fe058
Ignore in _Location ( #96553 )
2022-01-13 13:25:05 -08:00
Ian Hickson
7b01346c5c
Enable no_default_cases lint ( #91530 )
2021-10-11 10:23:04 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be24
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Hans Muller
93ca2b5ac0
Removed ButtonBar from flutter_gallery ( #85351 )
2021-06-28 13:01:04 -07:00
chunhtai
50a2fad986
Remove namesless todo ( #85151 )
2021-06-23 14:29:14 -07:00
Anis Alibegić
c99ed373b3
Fixed large amount of spelling errors ( #83744 )
2021-06-02 10:14:06 -07:00
Alexandre Ardhuin
34059eec2c
enable lint prefer_interpolation_to_compose_strings ( #83407 )
2021-06-01 11:14:06 -07:00
Alexandre Ardhuin
157bc92d4a
end of sort_child_properties_last ( #82457 )
2021-05-13 13:39:04 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint ( #81578 )
2021-05-10 16:26:16 -07:00
Alexandre Ardhuin
9bca38c5e5
remove unnecessary String.toString() ( #81859 )
2021-05-07 14:54:02 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations ( #80817 )
2021-04-21 13:49:03 -07:00
Jason Simmons
408c52fd70
Fix an NNBD error in the Gallery text form field demo ( #79816 )
2021-04-07 14:29:07 -07:00
Hans Muller
7c4c3419ae
Remove accentColor et al. from tests ( #78449 )
2021-03-17 13:28:09 -07:00
Hans Muller
87c40326e8
Removed accentColor and accentTextTheme dependencies from flutter_gallery ( #78378 )
2021-03-17 10:24:02 -07:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint ( #77434 )
2021-03-05 18:38:15 -08:00
Michael Goderbauer
ed755fba5e
Enable avoid_unnecessary_containers lint ( #77294 )
2021-03-04 15:29:03 -08:00
Michael Goderbauer
7b251f5f37
Enable use_function_type_syntax_for_parameters lint ( #77163 )
2021-03-04 08:59:17 -08:00
Greg Spencer
c6ef4c75d9
Turn on sized_box_for_whitespace lint, fix instances. ( #77099 )
2021-03-03 17:29:02 -08:00
Michael Goderbauer
0f568298d8
enable use_key_in_widget_constructors lint ( #77032 )
2021-03-02 10:14:02 -08:00
Alexandre Ardhuin
d546e1d311
fix for upcoming lint use_named_constants ( #74788 )
2021-01-27 20:20:44 +01:00
Sam Rawlins
006638839c
Remove "unnecessary" imports. ( #74383 )
2021-01-25 19:04:05 -08:00
Michael Goderbauer
5d1306e7ab
Update outdated links ( #73514 )
2021-01-07 16:28:12 -08:00
xubaolin
27b7ec348c
Fix Gallery subtitle not updating correctly upon selection ( #73303 )
2021-01-05 23:27:59 +08:00
xubaolin
8817c0d28c
RefreshIndicator can be shown when dragging from non-zero scroll position ( #71303 )
2020-12-03 13:28:04 -08:00
Greg Spencer
de884f1afe
Remove the nullOk parameter from Navigator.of and add Navigator.maybeOf ( #70726 )
...
Adds Navigator.maybeOf to replace calling Navigator.of(context, nullOk: true), and removes the nullOk parameter. Also changes Navigator.of to return a non-nullable value, and removes many (120!) instances of the ! operator, reducing the possible places where a null dereference could occur.
2020-11-20 09:10:46 -08:00
Chinmoy
830bdfa301
added none property in a DismissDirection ( #68987 )
2020-11-18 13:28:03 -08:00
tiya
adc8a42b38
Add bottom to search bar ( #68794 )
2020-11-16 12:07:20 -05:00
Emmanuel Garcia
21e802746b
Migrate Flutter Gallery test to null safety ( #70116 )
2020-11-09 12:29:14 -08:00
Michael Thomsen
e4d94f7ccd
Revert "Migrate Flutter gallery test to null safety ( #69048 )" ( #70023 )
...
This reverts commit 7ba775a994
2020-11-07 12:15:22 +01:00
Emmanuel Garcia
7ba775a994
Migrate Flutter gallery test to null safety ( #69048 )
2020-11-06 20:38:12 -08:00
Kate Lovett
cd60da784f
Migrate Scaffold SnackBars in the framework to ScaffoldMessenger ( #67946 )
2020-10-14 13:12:03 -07:00
