github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
NaN Commits 822 Branches 1,017 Tags 2 GiB
127b7c8b05
Commit Graph

270 Commits

Author SHA1 Message Date
Chris Bracken
27c6cdb416
Roll dependendencies (#103771) 
Roll dependendencies

This rolls depdendencies to latest using
flutter update-packages --force-upgrade

This change includes three code changes:

* Removes charcode from the dependencies allowlist since it no longer
  appears in the transitive closure of dependencies of the flutter,
  flutter_test, flutter_driver, flutter_localizations, and
  integration_test packages.

* Uses Resolver.create instead of the deprecated Resolver constructor.
  The default Resolver constructor has been deprecated in favour of the
  static Resolver.create() factory function, which unfortunately happens
  to be async. Propagated the async-ness up the chain.
  This change was partially reverted and the deprecation ignored in this
  patch until package:coverage can be rolled internally at Google.

* Eliminates the use of the deprecated packagesPath parameter to
  HitMap.parseJson. This parameter was deprecated and replaced with
  packagePath in https://github.com/dart-lang/coverage/pull/370 which
  was part of the overall deprecation of the .packages file in Dart
  itself https://github.com/dart-lang/sdk/issues/48272. The overall goal
  being that end-user code shouldn't need to know about implementation
  details such as whether dependency information is stored in a
  .packages file or a package_info.json file, but rather use the
  package_config package to obtain the package metadata and perform
  other functions such as resolving its dependencies to filesystem
  paths. packagesPath was replaced by packagePath, which takes the path
  to the package directory itself. Internally, package:coverage then
  uses package_config to do the rest of the package/script URI
  resolution to filesystem paths.
  This change was partially reverted and the deprecation ignored in this
  patch until package:coverage can be rolled internally at Google.

This is a pre-update prior to updating flutter_template_images in
https://github.com/flutter/flutter/pull/103739

Issue: https://github.com/flutter/flutter/issues/103371
Issue: https://github.com/flutter/flutter/issues/103775
Issue: https://github.com/flutter/flutter/issues/103830

When re-applying the partially-reverted changes to code coverage,
we'll need to patch host_entrypoint.dart internally to await the Future
that we'll be returning rather than a non-async value.
 2022-05-14 16:34:10 -07:00
Christopher Fujino
e8c01a8aa8
[flutter_tools] pub roll (#103220) 
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
 2022-05-10 10:26:54 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
Anna Gringauze
74944d528f
Run update-packages (#101450) 
* Run update-packages

* Update DwdsLauncher, disable failing test

* Fix analyze error

Co-authored-by: Jenn Magder <magder@google.com>
 2022-04-07 17:07:05 -07:00
Michael Goderbauer
195a1cc413
Prepare dev (minus flutter_gallery) for use_super_parameters (#100516) 2022-03-29 12:52:42 -07:00
Christopher Fujino
ef8e3578c1
[flutter_tools] update pub packages (#100726) 2022-03-25 16:45:09 -07:00
Ben Konyi
1880066dd3
Update dependencies (#99874) 2022-03-10 14:13:59 -07:00
Jonah Williams
67f25caf72
Remove package:typed_data from package:flutter dependencies (#99604) 2022-03-07 10:41:21 -08:00
Harry Terkelsen
03f1d37935
Add a benchmark for a scrolling list of Links (#94638) 2022-02-03 14:38:58 -08:00
Pierre-Louis
a22cf5d6b9
Update packages (#97592) 
* update packages

* implement

* remove trailing spaces

* Revert "remove trailing spaces"

This reverts commit d3bffbef57.

* Revert "implement"

This reverts commit 6b6172a827.
 2022-02-02 09:16:05 +01:00
Jenn Magder
3e6e996f9e
Run update-packages --force-upgrade (#96325) 2022-01-10 13:55:16 -08:00
Rami
1a3dc1b32a
Update color scheme seed generation to use color utils package (#95175) 
* Update color scheme seed generation to use color utils package
 2021-12-14 13:53:36 -08:00
Darren Austin
418cd95661
Added material_color_utilities as a dependency for flutter package. (#94377) 2021-12-01 14:19:04 -08:00
Nate Bosch
6d1a840bc5
Roll packages, remove unnecessary overrides (#94172) 2021-11-24 14:43:05 -08:00
Jacob MacDonald
a4fa2affe9
Update packages (#92924) 2021-11-05 12:03:03 -07:00
Greg Spencer
5883a6628d
Differentiate between TalkBack versions for semantics tests. (#92602) 
Makes the android_semantics_testing test not fail for newer versions of Talkback.

Also, since the test now depends on pub_semver, upgraded the pubspec files.

The only substantive changes in the PR are in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart
 2021-10-29 16:38:09 -07:00
Ian Hickson
bb5cbdc635
Enable depend_on_referenced_packages lint (#91653) 2021-10-12 11:28:02 -07:00
Greg Spencer
ab2b0851a2
Add smoke tests for all the examples, fix 17 broken examples. (#89021) 
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
 2021-09-28 09:32:06 -07:00
Kate Lovett
65d8dd988d
Update md5 method in flutter_goldens_client (#90154) 2021-09-15 17:42:05 -07:00
Christopher Fujino
81eb54bf78
update-packages (#88387) 2021-08-17 18:49:32 -07:00
Gary Qian
a562b3cb3d
Deferred components integration test app (#88030) 2021-08-16 15:32:05 -07:00
Anna Gringauze
cc63c81408
Update all packages (#87579) 
- Update dwds and and the rest of the packages

Closes: https://github.com/flutter/flutter/issues/87100
 2021-08-03 16:37:48 -07:00
Jacob MacDonald
fdb80f916d
update packages to the latest (#86880) 2021-07-22 13:26:05 -07:00
Eng Zer Jun
57a4b023f1
build: update dependencies (#86433) 2021-07-14 13:46:04 -07:00
Yegor
78e06e716b
[web] move e2e tests from flutter/engine to flutter/flutter (#86119) 
* [web] move e2e tests from flutter/engine to flutter/flutter
* flutter update-packages --force-upgrade
 2021-07-09 15:31:49 -07:00
Dan Field
e36e62e9a6
Revert "Revert "Audit hashCode overrides outside of packages/flutter (#85370)" (#85451)" (#85567) 
This reverts commit 2be0d57fa2.
 2021-06-30 09:46:54 -07:00
Ren You
2be0d57fa2
Revert "Audit hashCode overrides outside of packages/flutter (#85370)" (#85451) 
This reverts commit 9846fa5145.
 2021-06-28 09:55:31 -07:00
Dan Field
9846fa5145
Audit hashCode overrides outside of packages/flutter (#85370) 2021-06-26 17:36:04 -07:00
Phil Quitslund
875b420cc8
remove deprecated author fields (#84997) 2021-06-22 06:06:03 -07:00
Jonah Williams
cd13c91119
[versions] update dependencies (#84639) 2021-06-15 11:08:57 -07:00
Michael Goderbauer
5a2530b28e
Remove unused protobuf dependency (#84148) 2021-06-07 15:34:06 -07:00
Michael Goderbauer
2f88966935
Migrate vitool to null safety (#84011) 2021-06-04 13:58:21 -07:00
Michael Goderbauer
14b2e7ffee
flutter update-packages --force-upgrade (#83911) 2021-06-03 10:50:11 -07:00
Jonah Williams
025a3a7da3
[versions] roll package test redux (#83367) 2021-05-26 17:22:28 -07:00
Kenzie Schmoll
766b4509c6
Add 'v' hotkey to open DevTools in the browser (#82227) 
* Add 'v' hotkey to open DevTools in the browser
 2021-05-13 09:54:10 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint (#81578) 2021-05-10 16:26:16 -07:00
Jonah Williams
2b0d09dd81
[versions] roll versions and add ffi dep (#81403) 2021-04-28 11:19:03 -07:00
Jenn Magder
0f899f2b64
Roll packages (#80989) 2021-04-22 15:01:49 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations (#80817) 2021-04-21 13:49:03 -07:00
Dan Field
d7da6190ff
roll packages (#80307) 2021-04-13 18:19:02 -07:00
Jonah Williams
443d07b707
[versions] roll to latest test (#79099) 2021-03-31 07:45:40 -07:00
Jonah Williams
dfc134dd9a
[versions] roll many versions (#79088) 2021-03-25 15:43:44 -07:00
Jason Simmons
73ec544238
Update all packages and upgrade to path_provider 2.0.0-nullsafety (#76420) 2021-02-19 16:40:24 -08:00
Jonah Williams
db1e9f053f
update all packages (#76254) 2021-02-17 17:33:56 -08:00
Jonah Williams
7088c5ba2a
Update all packages (#76143) 2021-02-16 15:29:12 -08:00
Dan Field
bc1cf49458
roll packages (#75370) 2021-02-04 11:41:03 -08:00
Dan Field
d1538320d2
Roll packages to null safe (vm_service, test, etc.) (#74671) 2021-01-26 09:15:54 -08:00
Jia Hao
22f1700427
[flutter_tools] Make setting of CWD consistent for flutter test (#74622) 2021-01-25 22:34:03 -08:00
Ian Hickson
544a41eb55
Remove an obsolete comment from pubspec.yaml (#73505) 2021-01-07 15:59:04 -08:00
George Wright
a109fe68b0
Stop using the List constructor (#71957) 2020-12-08 17:03:03 -08:00
Jonah Williams
e8efde6a54
[versions] update more null safe versions (#69892) 2020-11-05 09:09:03 -08:00
Jonah Williams
580cacf4bd
[versions] roll versions (#69810) 2020-11-04 15:38:58 -08:00
Jacob MacDonald
193fe3e980
Update null safe deps to prepare for the 2.12 sdk version (#69041) 
* update pinned null safety deps

* run update-packages

* add http dep to devicelab package

* rerun update-packages
 2020-10-26 14:31:13 -07:00
Martin Kustermann
6fae89c8b5
Update package:stack_trace dependency to 1.10.0-nullsafety.4 (#68132) 2020-10-16 16:35:20 +02:00
Sam Rawlins
23c7ee9deb
Bump meta to 1.3.0-nullsafety.4 (#67744) 2020-10-12 09:50:30 -07:00
Jacob MacDonald
b95c3d7d56
update stack_trace dep (and others) (#67057) 2020-10-01 09:54:07 -07:00
Jacob MacDonald
9cee75ba61
update to the latest null safe packages (#66384) 
Updates all null safe dependencies to versions that allow 2.10 stable and 2.11 dev releases.

Also updates flutter_goldens and flutter_goldens_client to allow 2.11 dev.
 2020-09-23 11:03:29 -07:00
Yegor
905feb7771
roll source_span 1.8.0-nullsafety.2 (#66290) 2020-09-21 15:02:07 -07:00
Jonah Williams
689ca09cd0
[versions] update to latest source span and roll engine to 4b8477d11573d233e6791204191c0090f733b05d (#66136) 2020-09-19 11:22:07 -07:00
Ben Konyi
577de1c44e
Roll forward package:test to 1.16.0-nullsafety.4 to prepare for (#65571) 2020-09-10 15:55:03 -07:00
Jonah Williams
829ef147d1
[null-safety] roll to null-safe platform (#64160) 2020-08-19 15:47:08 -07:00
Jonah Williams
1b69983c6d
[versions] update gallery, roll versions (#64067) 2020-08-19 08:07:15 -07:00
Jonah Williams
c24772e8fb
[versions] update to the latest sdk versions (#62687) 2020-08-03 10:31:06 -07:00
Jonah Williams
d834673033
roll dart/engine to f27729e97b5a00c3a8d8d49edc7b998fa755b97a (#62368) 2020-07-27 17:51:31 -07:00
Zachary Anderson
ab3a4b0e69
Revert "bump nullsafety deps (#61978)" (#62234) 
This reverts commit c46aa360b0.
 2020-07-24 16:31:42 -07:00
Alexandre Ardhuin
c46aa360b0
bump nullsafety deps (#61978) 2020-07-24 16:17:08 -07:00
Yazeed Al-Khalaf
d41b1fbb50
✒ Spell Check All .md Files Related to Flutter 💙 (#61564) 
* 🐛 Fix Spelling Issues in Main README.md

* 🐛 Fix spelling issues in dev README.md

* 🐛 Fix spelling issues in complex_layout README.md

* 🐛 Fix spelling issues in macrobenchmarks README.md

* 🐛 Fix spelling issues in platform_views_layout README.md

* 🐛 Fix spelling issues in test_Apps/stocks README.md

* 🐛 Fix spelling issues in bots README.md

* ✒ Spell Check dev/ci README.md

* ✒ Spell Check dev/ci/docker_linux README.md

* ✒ Spell Check dev/devicelab README.md

* ✒ Spell Check dev/docs README.md

* ✒ Spell Check dev/snippets README.md

* ✒ Spell Check dev/snippets/config/templates README.md

* ✒ Spell Check dev/tools/gen_keycodes README.md

* ✒ Spell Check dev/tools/vitool README.md

* ✒ Spell Check examples/catalog README.md

* ✒ Spell Check examples/flutter_view README.md

* ✒ Spell Check examples/image_list README.md

* ✒ Spell Check examples/layers README.md

* ✒ Spell Check examples/platform_channel README.md

* ✒ Spell Check examples/platform_channel_swift README.md

* ✒ Spell Check examples/platform_view README.md

* ✒ Spell Check packages/_flutter_web_build_script README.md

* ✒ Spell Check packages/flutter_localizations README.md

* ✒ Spell Check packages/flutter_tools README.md

* ✒ Spell Check CODE_OF_CONDUCT.md

* ✒ Spell Check dev/integration_test/android_splash_screens/splash_Screen_load_rotate README.md

* ✒ Spell Check dev/integration_test/android_views README.md

* ✒ Spell Check dev/integration_tests/flutter_driver_screenshot_test README.md

* ✒ Spell Check dev/integration_tests/flutter_gallery README.md

* ✒ Spell Check dev/integration_tests/gradle_deprecated_settings README.md

* ✒ Spell Check dev/integration_tests/ios_add2app_life_cycle README.md

* ✒ Spell Check dev/integration_tests/ios_host_app README.md

* ✒ Spell Check dev/integration_tests/ios_platform_view_tests README.md

* ✒ Spell Check dev/automated_tests/flutter_test README.md

* ✒ Spell Check .github/PULL_REQUEST_TEMPLATE.md

* ✒ Spell Check .hithub/ISSUE_TEMPLATE/ACTIVATION.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/BUG.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/feature_request.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_others.md

* ✒ Spell Check .github/ISSUE_TEMPLATE/performance_speed.md

* ✒ Spell Check packages/flutter_tools/doc/daemon.md

* ✒ Spell Check packages/flutter_tools/fuchsia_enrtypoint_shim/README.md

* ✒ Minimize line to 80 columns

* ✒ Minimize line to 80 columns

* ✒ Fix Typo

* ✒ Chnaged numbers to 1 for testing purposes

* ✒ Changed numbers to 1 for testing purposes

* ❌ Remove 'a' which is a typo

* ✒ Change a sentence to be better

* ✒ Remove 'a' which is a typo

* ✒ Fix small issue

* ✒ Fix small typo

* ✒ Fix some typos

* ❌ Remove trailing space

* ❌ Remove trailing space

* 🐛 Fix small typo

* ✒ Fix Typo

* 🐛 Fix small bug
 2020-07-22 18:23:47 -07:00
Ben Konyi
adc9dde3ba
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61975)" (#61993) 
This reverts commit f7a1c87ffd.
 2020-07-21 16:17:23 -07:00
Ben Konyi
f7a1c87ffd
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61975) 
This reverts commit 4867f5931f.
 2020-07-21 15:44:38 -07:00
Ben Konyi
4867f5931f
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61882)" (#61909) 
This reverts commit 895b7ef6fa.
 2020-07-20 16:41:01 -07:00
Ben Konyi
895b7ef6fa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61882) 
This reverts commit 38fe887342.
 2020-07-20 16:01:58 -07:00
Christopher Fujino
df542b6831
update packages and update template (#61678) 2020-07-16 18:32:46 -07:00
Ming Lyu (CareF)
8badf93609
Revert "update packages (#61647)" (#61674) 
This reverts commit b7b60a2d2c.
 2020-07-16 20:13:18 -04:00
Ming Lyu (CareF)
b7b60a2d2c
update packages (#61647) 2020-07-16 18:55:42 -04:00
Ben Konyi
38fe887342
Revert "Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61633)" (#61641) 
This reverts commit 594c3541aa.
 2020-07-16 11:43:54 -07:00
Ben Konyi
594c3541aa
Reland "Add support for Dart Development Service (DDS) in Flutter Tools (#61276)" (#61633) 
This reverts commit a1a5a8f635.
 2020-07-16 11:38:17 -07:00
Alexandre Ardhuin
f32a73711a
use nnbd deps (#61177) 2020-07-09 23:01:22 +02:00
Dan Field
33aa457604
Roll packages (#61034) 
Roll packages, update XML deprecations.
 2020-07-07 16:40:33 -07:00
Jonah Williams
37db92beeb
[versions] update all versions and fix tool tests (#60127) 
Update all versions, specifically file which fixes some bugs that caused tests to fail if run in different orders:

- systemTemp directories created by MemoryFileSystem will allot names based on the file system instance instead of globally.
- MemoryFile.readAsLines()/readAsLinesSync() no longer treat a final newline in the file as the start of a new, empty line.
- RecordingFile.readAsLine()/readAsLinesSync() now always record a final newline.
 2020-06-23 15:48:37 -07:00
Jonah Williams
fbdc79e448
[versions] update all versions (#59832) 
Fixes #59718

Update all versions, specifically dwds which has a hot restart fix
 2020-06-19 14:48:57 -07:00
Jonah Williams
bf94520644
[versions] Update all the versions (#59283) 2020-06-11 16:40:22 -07:00
Tianguang
03c74eb42e
Run flutter update-packages --force-upgrade. (#58104) 
* Run `flutter update-packages --force-upgrade`.
* Update test to 1.14.5.
 2020-05-30 00:13:33 +02:00
Jacob MacDonald
6399be62d2
remove flutter_test quiver dep, use fake_async and clock instead (#54125) 
## Description

Removes the `flutter_test` dependency on `quiver`, instead using the more targeted `clock` and `fake_async` packages.

## Related Issues

https://github.com/flutter/flutter/issues/53908

## Tests

No changes to tests

## Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.

- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] I signed the [CLA].
- [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] All existing and new tests are passing.
- [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.
- [x] I am willing to follow-up on review comments in a timely manner.

## Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

- [ ] No, no existing tests failed, so this is *not* a breaking change.
- [x] Yes, this is a breaking change. *If not, delete the remainder of this section.*
   - [x] I wrote a design doc: https://docs.google.com/document/d/1EkkLbECNBwHgddBQAZqEy7iQLTIxR1rgChKzxcLwhio/edit
   - [x] I got input from the developer relations team, specifically from: @RedBrogdon
   - [x] I wrote a migration guide:  https://github.com/flutter/website/pull/3932

<!-- Links -->
[issue database]: https://github.com/flutter/flutter/issues
[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter
[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
 2020-04-15 12:10:26 -07:00
tauu
846e8fe812
force upgraded package dependencies (#54787) 
Co-authored-by: Georg Wechslberger <wechslbe@ma.tum.de>
 2020-04-14 18:21:14 -07:00
Jacob MacDonald
efdce3cf72
drop image package dependency for goldens (#54144) 2020-04-09 11:21:23 -07:00
Michael Thomsen
98e7791ec9
Roll pinned xml and petitparser versions (#54181) 2020-04-07 12:16:03 -07:00
Alexandre Ardhuin
f5a9902577
enable avoid_equals_and_hash_code_on_mutable_classes (#52507) 2020-04-06 13:36:01 -07:00
Jonah Williams
8cb1d269f6
[versions] update EVERYTHING (#53467) 2020-03-30 14:09:38 -07:00
Ben Konyi
3edd3eb4a2
Updated package:test, package:test_core, package:coverage, package:package_config (#51946) 
This is required to roll forward package:vm_service to 3.0.0 and is
blocking a DevTools release.
 2020-03-04 11:40:52 -08:00
Jonah Williams
9b4cb4da72
[versions] reland update test to 1.12.0 (#50879) 2020-02-18 10:38:54 -08:00
Jonah Williams
e481fcae52
Revert "[version] update to package:test 1.12.0 (#50818)" (#50853) 
This reverts commit d3387bc916.
 2020-02-14 22:34:30 -08:00
Jonah Williams
d3387bc916
[version] update to package:test 1.12.0 (#50818) 2020-02-14 21:51:47 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping (#50322) 2020-02-07 16:35:55 +01:00
Alexandre Ardhuin
5c28e3eeea
unnecessary escapes fixes (#50178) 
* unnecessary escapes fixes

* replace some strings with raw strings

* update regexp

* address review comments
 2020-02-07 06:35:50 +01:00
Dan Field
8b2993337a
revert #48985 (#49572) 2020-01-27 14:36:02 -08:00
Alexandre Ardhuin
3800bb7b10 fix missing spaces in adjacent strings (#49159) 2020-01-21 16:43:03 -08:00
Anthony
b67d5ec6e9 [a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#48985) 2020-01-17 15:13:01 -08:00
Alexandre Ardhuin
003541499b use isA<Xxx>() matcher (#48482) 2020-01-16 12:43:03 -08:00
Alexandre Ardhuin
82262d8896 format operator== according to flutter style guide (#48449) 2020-01-09 08:23:02 -08:00