stuartmorgan
e1a784ae3f
Wrap Windows build invocation in a batch script ( #33443 )
...
Invoking msbuild with runInShell makes handling path escaping more
error-prone, and substantially increases the chances of running into
maximum path limits. This replaces the direct call with a .bat wrapper
that calls vsvars64.bat then msbuild, and uses relative paths within the
script to keep command lengths short.
Fixes https://github.com/flutter/flutter/issues/32792
2019-05-28 21:53:03 -07:00
Jonah Williams
8e3e0a89f4
Revert "Instrument add to app flows ( #33297 )" ( #33449 )
...
This reverts commit faec4ca361
.
2019-05-28 12:52:58 -07:00
Emmanuel Garcia
faec4ca361
Instrument add to app flows ( #33297 )
2019-05-28 11:11:20 -07:00
stuartmorgan
81c38b22cb
Implement macOS support in flutter doctor
( #33277 )
...
Splits Xcode validation out of the iOS validator and into a stand-alone
validator, and groups the CocoaPods validator with that top-level
validator instead of the iOS validator. iOS now validates only the
iOS-specific tools (e.g., ideviceinstaller).
Reorganizes many of the associated clases so that those that are used by
both macOS and iOS live in macos/ rather than ios/. Moves some
validators to their own files as part of the restructuring.
This is the macOS portion of #31368
2019-05-24 22:51:02 -04:00
Chris Bracken
156b4220b4
Americanise spellings ( #33323 )
...
Updates documentation and non-public API to use American spellings for
consistency with the rest of the codebase.
No changes to behaviour... other than how it's spelt.
2019-05-24 19:13:02 -07:00
Chris Bracken
4d9923201b
Correct typos ( #33322 )
...
Corects a bnuch of typeos throuhgout teh Fluter codebsae.
Made use of the `misspell` tool:
https://github.com/client9/misspell
2019-05-24 19:12:45 -07:00
Zachary Anderson
f5827f0f07
[flutter_tool] Improve Fuchsia 'run' tests ( #33263 )
2019-05-24 07:48:41 -07:00
Emmanuel Garcia
12a0e475e2
Make paths absolute in settings.gradle ( #33228 )
2019-05-23 23:32:11 -07:00
Jonah Williams
1bd85dd6c2
disable flaky devfs test ( #33285 )
2019-05-23 17:05:29 -07:00
stuartmorgan
ef9866bf27
Build macOS via workspace, rather than project ( #33198 )
...
This is necesasry to integrate CocoaPods, since CocoaPods operates
primarily on the workspace rather than the project.
2019-05-22 19:58:29 -04:00
Jonah Williams
a30ffb60ad
Revert "Clean up some flutter_tools tests and roll dependencies ( #33163 )" ( #33206 )
2019-05-22 12:20:02 -07:00
Ian Hickson
e5f81e1048
Clean up some flutter_tools tests and roll dependencies ( #33163 )
...
* Clean up some flutter_tools tests
* Remove arbitrary retry that happens even for fundamental errors, and generally clean up _DevFSHttpWriter.
* Update dependencies (requires fixes; see next commit)
* Fixes for new dependencies.
2019-05-22 09:31:37 -07:00
Christopher Fujino
041755faad
don't send crash reports if on a user branch ( #33078 )
...
* don't send crash reports if on a user branch.
* add test to test/crash_reporting_test.dart
2019-05-21 11:58:41 -07:00
Zachary Anderson
94ce956f0a
[flutter_tool] Adds support for 'run' for Fuchsia devices ( #32849 )
2019-05-21 08:49:43 -07:00
Michael Thomsen
7ae3caf309
Rename flutter packages
to flutter pub
( #33041 )
2019-05-21 16:38:58 +02:00
Sam Rawlins
c2a93bd545
Fix missing return statements on function literals ( #33058 )
2019-05-20 12:51:57 -07:00
Devon Carew
50a9c31f5e
reduce retry attempts for flutter creatte --list-samples ( #32833 )
2019-05-16 18:20:30 -07:00
Alexandre Ardhuin
4fa32df141
use null aware operators ( #32711 )
...
* use null aware operators
* rollback changes about null-aware operator
* disable lint prefer_is_not_empty
2019-05-16 22:25:51 +02:00
stuartmorgan
6722fb448c
Teach flutter msbuild for Windows ( #32335 )
...
Eliminates the need for a build.bat in the Windows build workflow, adding
preliminary support for building using msbuild. The handling of
vcvars64.bat may be refined in the future, but this serves as a starting point.
2019-05-14 19:24:40 -04:00
Zachary Anderson
8841afeb1f
[flutter_tool] Build a Fuchsia package ( #32519 )
2019-05-14 10:59:23 -07:00
Jonah Williams
8b0243f413
Teach Linux to use local engine ( #31631 )
2019-05-11 00:08:29 -07:00
Sam Rawlins
9c77e8e8a0
Fix missing return statements on function literals ( #31825 )
2019-05-09 12:43:51 -07:00
Jonah Williams
eb996afaa8
make hotfix use a plus instead of minus ( #32060 )
2019-05-07 10:11:00 -07:00
Zachary Anderson
61236c873e
[flutter_tool] In 'attach' use platform dill and patched sdk dir from the Fuchsia SDK ( #32071 )
2019-05-06 09:26:58 -07:00
Jonah Williams
99e7b0a0ff
dont NPE with empty pubspec ( #32072 )
2019-05-06 08:01:45 -07:00
Antti Ahti
526113db32
Fix tab indentation ( #31798 )
...
Code indentation was done with tabs in some places. Replaced with spaces.
2019-05-06 14:09:54 +02:00
Jonah Williams
1d91bd2583
Revert "Start abstracting platform logic builds behind a shared interface ( #31889 )" ( #32003 )
...
This reverts commit e5459942c8
.
2019-05-02 14:14:46 -07:00
Jonah Williams
e5459942c8
Start abstracting platform logic builds behind a shared interface ( #31889 )
2019-05-02 13:31:00 -07:00
Jonas Termansen
8b9eb3e2b2
Report CompileTime metric in flutter build aot --report-timings. ( #31895 )
...
This is the correct metric to report for compilation time benchmarks rather
than RunTime. Rename the 'gen_snapshot' value to merely 'snapshot' for
backwards compatibility and overall simplicity.
This change simplifies Dart's benchmarking of Flutter by making it easier to
adopt --report-timings (made for Dart to use), which makes the benchmarks
much more robust.
2019-05-02 15:22:43 +02:00
Dan Field
df669ab1ea
Avoid NPE for flutter attach mDNS ( #31926 )
2019-05-01 13:41:00 -07:00
Zachary Anderson
6a69f8c98c
[fuchsia] Add support for the 'device' command using the SDK ( #31910 )
2019-05-01 13:24:09 -07:00
Jacob Richman
63aa5b3647
Refactor core uses of FlutterError. ( #30983 )
...
Make FlutterError objects more structured so they can be displayed better in debugging tools such as Dart DevTools.
2019-05-01 11:20:12 -07:00
Victor Maraccini
74c6237abc
Fix bundle id on iOS launch using flutter run ( #31039 )
2019-05-01 10:21:43 -07:00
Emmanuel Garcia
3e65bb060f
Fix #31764 : Show appropriate error message when fonts pubspec.yaml isn't iterable
...
Show appropriate error message when fonts isn't iterable
2019-05-01 09:49:39 -07:00
Jonah Williams
c82fc132a8
add stderr to log processor for desktop ( #31874 )
2019-04-30 19:18:15 -07:00
Jonah Williams
5e77d6508e
Initial sketch of tools testbed ( #31765 )
2019-04-30 15:42:16 -07:00
Jonah Williams
48936d9a95
Remove deprecated commands ( #31759 )
2019-04-30 14:43:03 -07:00
Dan Field
fe9512fa72
Re-enable const ( #31600 )
...
* Re-enable const
2019-04-29 16:02:42 -07:00
Jonah Williams
4ff467191b
make FlutterProject synchronous ( #31757 )
2019-04-29 08:21:32 -07:00
Danny Tuppeny
fdcc8aafa7
Allow adb stdout to contain the port number without failing ( #31491 )
...
* Allow adb stdout to contain the port number without failing
* Add tests that port forwarder correctly responds to known ADB output
2019-04-26 21:03:25 +01:00
Jonah Williams
9d364043af
Refactor the test compiler into a separate library ( #31642 )
2019-04-26 12:33:41 -07:00
Jonah Williams
fdae7bb871
add check that xcode project configuration is not missing ( #31621 )
2019-04-25 15:51:25 -07:00
Jonah Williams
0acd3e6b04
refactor context to be implicit-downcast safe ( #31622 )
2019-04-25 15:51:08 -07:00
Jonah Williams
52415cb0a5
baby-steps to testing/refactoring flutter_platform ( #31616 )
2019-04-25 14:01:28 -07:00
Jonah Williams
6b191841f3
Allow filtering devices to only those supported by current project ( #31446 )
2019-04-25 12:25:12 -07:00
Dan Field
1db5d66932
Capture JSON RPC errors that presently get swallowed ( #31584 )
...
* Update packages
* Capture JSON RPC errors that presently get swallowed
2019-04-25 08:27:00 -07:00
Jonah Williams
482078387e
make sure we exit early if the Runner.xcodeproj file is missing ( #31591 )
2019-04-25 00:12:17 -07:00
Jonah Williams
37c73e77f1
Remove need for build/name scripts on Linux desktop ( #31567 )
2019-04-24 13:34:56 -07:00
Jonah Williams
15f271ef07
if there is no .ios or ios sub-project, don't attempt building for iOS ( #31406 )
2019-04-23 09:49:49 -07:00
Jonah Williams
7f959d8b78
Add Xcode build script for macOS target ( #31329 )
2019-04-22 13:51:00 -07:00
Stanislav Baranov
e2a3c2ee45
Remove support for building dynamic patches on Android. ( #31359 )
2019-04-22 10:40:50 -07:00
Stanislav Baranov
08445c8a01
Stop precaching the artifacts for dynamic mode. ( #31282 )
2019-04-22 09:05:38 -07:00
Ben Konyi
3764cb8515
Added support for authentication codes for the VM service. ( #30857 )
...
* Added support for authentication codes for the VM service.
Previously, a valid web socket connection would use the following URI:
`ws://127.0.0.1/ws`
Now, by default, the VM service requires a connection to be made with a
URI similar to the following:
`ws://127.0.0.1:8181/Ug_U0QVsqFs=/ws`
where `Ug_U0QVsqFs` is an authentication code generated and shared by
the
service.
This behavior can be disabled with the `--disable-service-auth-codes`
flag.
2019-04-18 21:01:50 -07:00
Jonah Williams
ac36e4423e
Add flutter run support for linux and windows ( #31229 )
2019-04-18 18:05:04 -07:00
Jonah Williams
65f45999a3
initial work on coverage generating script for tool ( #29494 )
2019-04-18 17:59:14 -07:00
Jonah Williams
f5672b9316
add --force flag to precache ( #31278 )
2019-04-18 16:04:21 -07:00
Jonah Williams
e69a8a15b3
pass track widget creation flag through to build script ( #31277 )
2019-04-18 15:03:34 -07:00
Devon Carew
d075d647c3
remove the unused hintMessage and hintId fields from the reload results ( #31267 )
2019-04-18 11:00:54 -07:00
Jonah Williams
da92fc1109
Add run capability for macOS target ( #31218 )
2019-04-17 22:40:26 -07:00
Jonah Williams
3c8c630f01
Allow disabling all fingerprint caches via environment variable ( #31171 )
2019-04-17 17:27:50 -07:00
Jonah Williams
86c938b5b3
Add desktop projects and build commands (experimental) ( #31205 )
2019-04-17 12:16:55 -07:00
Jonah Williams
5228a7851a
Fuchsia step 1: add SDK version file and artifact download ( #31073 )
2019-04-16 13:24:58 -07:00
Alexander Aprelev
d775908c7e
Download and handle product version of flutter patched sdk ( #31063 )
...
* Support release/debug flavors of flutter_patched_sdk
* Use [anyNamed] instead of [any] for mocking named arguments
* Fix use of local engine in release mode
2019-04-15 21:02:20 -07:00
Christopher Fujino
be5f345f33
New flag to flutter drive
to skip installing fresh app on device ( #30818 )
...
* add a --build/--no-build flag to flutter drive command
2019-04-15 09:31:51 -07:00
Jonah Williams
301eaa8c32
Make coverage, like, really fast ( #30811 )
2019-04-15 08:59:28 -07:00
Jonah Williams
259641c4b3
Allow downloading of desktop embedding artifacts ( #30648 )
2019-04-10 22:08:44 -07:00
Jonah Williams
316d44989a
warn on uncomitted changes ( #30235 )
2019-04-10 12:24:53 -07:00
Michael Thomsen
811f1ad98f
Forward missing pub commands ( #30115 )
2019-04-09 17:03:09 +02:00
Jonah Williams
9baffb97ca
Reland: Ensure that flutter run/drive/test/update_packages only downloads required artifacts ( #30254 )
2019-04-08 13:49:09 -07:00
Jonah Williams
99b4459944
Allow disabling experimental commands, devices on stable branch ( #30153 )
2019-04-08 13:48:21 -07:00
Lau Ching Jun
294d7ea0cf
Mark ios-deploy version 2.0.0 as bad ( #30578 )
...
Mark ios-deploy version 2.0.0 as bad.
ios-deploy before version 1.9.4 declares itself as v2.0.0
https://github.com/ios-control/ios-deploy/commits/master/src/ios-deploy/version.h
2019-04-08 12:37:43 -07:00
Tim Sneath
529189791c
Replace flutter.io with flutter.dev ( #30562 )
2019-04-05 11:39:30 -07:00
Vyacheslav Egorov
01e3496ad9
Introduce --report-timings flag for flutter build aot command. ( #30032 )
...
This flag makes flutter build aot report timings for substeps (e.g.
frontend compilation and gen_snapshot) in a machine readable form.
2019-04-03 12:12:18 +02:00
Jonah Williams
c10e7ba6e9
Revert "Ensure that flutter run/drive/test/update_packages only downloads required artifacts ( #30075 )" ( #30232 )
2019-03-29 20:41:07 -07:00
Jonah Williams
89807e68d0
Ensure that flutter run/drive/test/update_packages only downloads required artifacts ( #30075 )
2019-03-29 20:33:37 -07:00
Jonah Williams
8220f8f4e3
add missing test case and handle wildcard removal ( #30205 )
2019-03-29 14:26:56 -07:00
Christopher Fujino
ec93c87c89
Move spinner _defaultSlowWarning
message to a new line ( #30071 )
...
* write newline before adding slow restart message to spinner
* update existing test
2019-03-28 10:08:44 -07:00
Jonah Williams
99866f4a3d
Make timeout durations configurable ( #30053 )
2019-03-27 16:21:16 -07:00
Jonah Williams
7d678f2adc
Lazy cache 5: The Empire Strikes Back ( #29986 )
2019-03-27 13:54:09 -07:00
Jonah Williams
bafe7cbbb4
Watch wildcard directories in addition to asset bundle ( #29883 )
2019-03-26 21:40:53 -07:00
Jonah Williams
164dae3bf1
Revert "Lazy cache 4 ( #29785 )" ( #29985 )
2019-03-26 10:01:22 -07:00
Jonah Williams
d71f324e48
Lazy cache 4 ( #29785 )
2019-03-26 08:45:29 -07:00
Jonah Williams
44b22c7b04
Fix cache location, artifacts, and re-enable dart2js test ( #29783 )
2019-03-25 18:47:37 -07:00
Jonah Williams
beaf7e28fa
Update upgrade to reset off of hotfix branches ( #29786 )
2019-03-25 09:42:28 -07:00
Alexandre Ardhuin
bfa1d25bf9
some formatting of map, parameters and spaces ( #29760 )
2019-03-23 00:02:21 +01:00
Amir Hardon
e2cd5931a7
Revert "Update upgrade to rebase and stash local changes. ( #29192 )" ( #29780 )
...
This reverts commit e38be671a7
.
2019-03-21 20:34:07 -07:00
Jonah Williams
e38be671a7
Update upgrade to rebase and stash local changes. ( #29192 )
2019-03-21 14:32:52 -07:00
Jonah Williams
fc9f7dea1a
Allowing adding/updating packages during hot reload ( #29747 )
2019-03-21 13:59:38 -07:00
Jonah Williams
469a859c72
Enable code generation features in tool ( #29399 )
2019-03-21 13:12:10 -07:00
Christopher Fujino
a4b9ef2e79
Fix more tests for ANSI terminals ( #29699 )
...
* have tests that log error messages use a FakePlatform that does not support Ansi color, to fix tests started from color terminals
* add the override to the other tests too, in case someone copy & pastes them in the future for a test involving an error message
2019-03-21 09:11:58 -07:00
Jonah Williams
377f4451ca
fix asset reloading ( #29469 )
2019-03-21 09:03:28 -07:00
Alexander Aprelev
12c4e050be
Use source list from the compiler to track invalidated files for hot reload. ( #29693 )
...
* Use source list from the compiler to track invalidated files.
* Revert accidental change
* Fix first-time-seen-the-file logic
* Fix/simplify invalidate logic now that we can rely on compiler to let us know what is the cut-off point for invalidation.
* Update devfs mock to accommodate for new fields
* Fix deleted files case
* Analyzer found missing final
2019-03-20 21:58:15 -07:00
Alexandre Ardhuin
a6af422874
some spaces formatting ( #29452 )
...
* some space formattings
* always use blocks in if-else if a block is used
* format spaces in for and while
* allow multiline if conditions
* fix missing space
2019-03-20 23:23:31 +01:00
Jonah Williams
b123846cb0
Improve flutter test startup time ( #29404 )
2019-03-20 13:58:57 -07:00
Ben Konyi
e8b98f9648
Manual engine roll for 2019-03-19 ( #29627 )
...
* Manual engine roll for 2019-03-19
* Applying patch for Dart SDK changes (see PR #29004 )
2019-03-19 20:01:03 -07:00
Priit Lätt
cdbd0f9ddd
Use async execution for xcodebuild commands ( #29048 )
2019-03-19 09:19:34 -07:00
Jonah Williams
cd803ac7f2
Improve hot reload performance ( #28152 )
2019-03-15 15:02:45 -07:00
Jason Simmons
e5696c2e7c
Use fs.identical to compare paths when finding the engine source path ( #29386 )
...
This will handle paths with symlinks that resolve to the same location.
2019-03-15 09:32:10 -07:00
Danny Tuppeny
126c58ef7c
Add a flutter create --list-samples
command ( #28938 )
...
* Add a `flutter create --list-samples` command
* Add some comments/docs
* Tweak text
2019-03-12 11:47:17 +00:00
Alexandre Ardhuin
a0d1f93b07
fix block formatting ( #29051 )
2019-03-09 09:03:11 +01:00