Jonah Williams
f5de6aadd4
[flutter_tools] remove zone level overrides of verbose and daemon logging ( #57448 )
...
Make it possible for all FlutterCommands to be global free, by moving instantiation to inside the Zone context. Additionally, provide VerboseLogger and NotifyLogger (daemon) at the top level and remove from command-specific overrides.
This allows removing a work around where web devices needed to look up directly from the context in non-test code.
Technically the output preferences are still zone injected, but these will be moved soon as they were not being used correctly by the top level command (the injection comes after ArgParser reads the overflow values, causing numerous wrap issues)
2020-06-04 16:35:36 -07:00
xster
1376746237
Reland #53153 to attach to existing modules and apps for Android ( #53289 )
2020-03-25 16:45:49 -07:00
Jenn Magder
b684041bb8
Revert "Let flutter attach find the service port by looking through old logs again ( #53153 )" ( #53282 )
...
This reverts commit 0c5ffdc9ef
2020-03-25 10:53:45 -07:00
xster
0c5ffdc9ef
Let flutter attach find the service port by looking through old logs again ( #53153 )
2020-03-24 23:26:01 -07:00
Jonah Williams
377879825e
[flutter_tools] prevent StateError when log reader is disposed ( #52173 )
...
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
2020-03-10 11:34:40 -07:00
Jonah Williams
c1112d3f7e
[flutter_tools] Reland: Allow providing dart-defines to Android, iOS, macOS builds ( #52044 )
2020-03-06 14:53:36 -08:00
Zachary Anderson
6c408a0567
Reland: [flutter_tool] Where possible, catch only subtypes of Exception ( #52021 )
...
* Reland: [flutter_tool] Where possible, catch only subtypes of Exception
* Add armv7f to getIOSArchForName
2020-03-06 10:22:12 -08:00
Jonah Williams
ee476a7bd1
Revert "[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds ( #51714 )" ( #52041 )
...
This reverts commit ee60eeea3e
2020-03-05 12:51:42 -08:00
Jonah Williams
ee60eeea3e
[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds ( #51714 )
2020-03-05 12:38:40 -08:00
Jenn Magder
cbbb7ec5a7
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception ( #51774 )" ( #51960 )
...
This reverts commit 57c6721cd5
2020-03-04 12:40:15 -08:00
Flutter GitHub Bot
57c6721cd5
Reland: [flutter_tool] Where possible, catch only subtypes of Exception ( #51774 )
2020-03-04 11:41:02 -08:00
Zachary Anderson
b32ee2f15c
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception ( #51567 )" ( #51616 )
...
This reverts commit 9de7787f25
2020-02-27 22:57:13 -08:00
Zachary Anderson
9de7787f25
Reland: [flutter_tool] Where possible, catch only subtypes of Exception ( #51567 )
2020-02-27 22:46:23 -08:00
Zachary Anderson
483f49962c
Revert "[flutter_tool] Where possible, catch only subtypes of Exception ( #51440 )" ( #51539 )
...
This reverts commit f1cd47ef5c
2020-02-26 23:42:19 -08:00
Zachary Anderson
f1cd47ef5c
[flutter_tool] Where possible, catch only subtypes of Exception ( #51440 )
2020-02-26 21:45:02 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes ( #50368 )
2020-02-11 20:58:27 +01:00
Zachary Anderson
29490887e0
Reland: [flutter_tools] File system utilities ( #48757 )
...
* Reland: [flutter_tools] File system utilities
* Remove unused imports
2020-01-14 09:40:39 -08:00
Zachary Anderson
ef62092b9b
Revert "[flutter_tools] File system utilities ( #48738 )" ( #48755 )
...
This reverts commit 0349660622
2020-01-13 14:30:37 -08:00
Zachary Anderson
0349660622
[flutter_tools] File system utilities ( #48738 )
2020-01-13 13:17:45 -08:00
Emmanuel Garcia
fca5917519
Test hot reload targeting a Fuchsia device ( #48472 )
2020-01-10 14:38:01 -08:00
Emmanuel Garcia
ec2d58335a
Make subcommands return success instead of null ( #48100 )
2020-01-10 11:28:01 -08:00
Alexandre Ardhuin
4f9b6cf017
enable lint prefer_final_in_for_each ( #47724 )
2020-01-07 16:32:04 +01:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable ( #47398 )
2020-01-06 11:04:20 -08:00
Ian Hickson
449f4a6673
License update ( #45373 )
...
* Update project.pbxproj files to say Flutter rather than Chromium
Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
* Update the copyright notice checker to require a standard notice on all files
* Update copyrights on Dart files. (This was a mechanical commit.)
* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).
* Clean up the copyrights in non-Dart files. (Manual edits.)
Also, make sure templates don't have copyrights.
* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Emmanuel Garcia
81724bd60f
Fallback to protocol discovery if mdns returns null ( #45439 )
2019-11-25 11:51:54 -08:00
Alexandre Ardhuin
980f14e0c5
implicit-casts:false on flutter_tools ( #45153 )
...
* implicit-casts:false on flutter_tools
* use castStringKeyedMap
* address review comments
* address review comments
* fix issues after rebase
2019-11-24 06:54:43 +01:00
Yegor
aa3943316b
Fix dartDefines in daemon mode ( #45317 )
...
* de-null dartDefines in daemon mode
* remove daemonCommand; pipe through dartDefines into Daemon
* pass dartDefiles in attach; add test for --machine mode
2019-11-22 08:57:14 -08:00
Zachary Anderson
05226d2a61
Reland: [flutter_tool] Fuchsia AOT builds ( #45350 )
...
* Reland: [flutter_tool] Fuchsia AOT builds
* Fixes
2019-11-21 12:55:39 -08:00
Zachary Anderson
0216953674
Revert "[flutter_tool] Fuchsia AOT builds ( #45187 )" ( #45349 )
...
This reverts commit a57dddd217
2019-11-21 09:41:46 -08:00
Zachary Anderson
a57dddd217
[flutter_tool] Fuchsia AOT builds ( #45187 )
2019-11-21 08:32:58 -08:00
Emmanuel Garcia
5df4b7db23
Reland: Attach looks at future observatory URIs ( #45307 )
2019-11-20 18:51:25 -08:00
Emmanuel Garcia
fb5e49082b
Revert "Attach looks at future observatory URIs ( #45228 )" ( #45237 )
...
This reverts commit 2135e9fb1e
2019-11-19 23:14:25 -08:00
Emmanuel Garcia
2135e9fb1e
Reland: Attach looks at future observatory URIs ( #45228 )
2019-11-19 21:43:52 -08:00
Emmanuel Garcia
7a0911b47a
Revert "Attach looks at future observatory URIs ( #44637 )" ( #45211 )
...
This reverts commit 6d77996d6a
2019-11-19 16:47:39 -08:00
Emmanuel Garcia
6d77996d6a
Attach looks at future observatory URIs ( #44637 )
2019-11-19 15:11:41 -08:00
Alexandre Ardhuin
adc7351046
implicit-casts:false on flutter_tools/lib ( #44447 )
...
* implicit-casts:false on flutter_tools/lib
* address review comments
* use castStringKeyedMap
* introduce {bool,string,strings}Arg
* fix ci
2019-11-19 07:57:42 +01:00
Jonah Williams
e3cb2c3fcf
Reland: Allow specifying device-vmservice-port and host-vmservice-port ( #44853 )
2019-11-13 16:02:46 -08:00
Jonah Williams
985da83139
Revert "Allow specifying device-vmservice-port and host-vmservice-port ( #44027 )" ( #44843 )
...
This reverts commit c0af77bf87
2019-11-13 14:35:07 -08:00
Jonah Williams
c0af77bf87
Allow specifying device-vmservice-port and host-vmservice-port ( #44027 )
2019-11-13 13:01:41 -08:00
Yegor
e7073f9a1f
add --dart-defines option ( #44083 )
2019-11-09 17:08:53 -08:00
Christopher Fujino
0b24a5a2ff
Implement mdns for flutter run ( #40447 )
2019-09-18 11:01:08 -07:00
Zachary Anderson
e2340c641d
[flutter_tool] Use curly braces around single statment control structures ( #40446 )
2019-09-13 14:51:35 -07:00
Jonah Williams
6f71ce26d6
Place terminalUi flag on terminal interface ( #39214 )
2019-08-27 14:20:51 -07:00
Zachary Anderson
a40ab895cf
[flutter_tool] Observatory connection error handling cleanup ( #38353 )
2019-08-15 12:13:03 -07:00
Jonah Williams
2ab469952b
Flutter assemble for macos take 2! ( #36987 )
2019-07-31 16:19:22 -07:00
Ian Hickson
e8d7306828
Some minor cleanup for flutter_tools ( #36569 )
2019-07-24 10:58:09 -07:00
Jonah Williams
adf45d1e40
Refactor signal and command line handler from resident runner ( #35406 )
2019-07-09 13:10:26 -07:00
Emmanuel Garcia
afdc783ce5
Report commands that resulted in success or failure ( #34288 )
...
This is added as a dimension cd26
2019-06-13 10:27:23 -07:00
Emmanuel Garcia
3bbdf017c4
Add to app measurement ( #33458 )
2019-05-29 20:56:28 -07:00
Jonah Williams
8e3e0a89f4
Revert "Instrument add to app flows ( #33297 )" ( #33449 )
...
This reverts commit faec4ca361
2019-05-28 12:52:58 -07:00
