Commit Graph

96 Commits

Author SHA1 Message Date
Justin McCandless
5c48d90691
Multiline Selection Menu Position Bug (#36974)
Fix bug where selection menu appeared at top of screen for multiline inputs.
2019-08-02 15:40:11 -07:00
Kate Lovett
0379dd1c26
Updating cirrus fingerprint script to include goldens version (#36690) 2019-07-23 09:30:41 -07:00
Dan Field
7a20148548
Add colorFilterLayer/Widget (#35468) 2019-07-11 15:49:51 -07:00
Jonah Williams
95ca768976
Revert "Revert "Manual engine roll, Update goldens, improved wavy text decoration 0f9e297ad..185087a65f (#35066)" (#35237)" (#35242) 2019-06-27 22:58:54 -07:00
Jonah Williams
b43b8bab94
Revert "Manual engine roll, Update goldens, improved wavy text decoration 0f9e297ad..185087a65f (#35066)" (#35237) 2019-06-27 18:38:40 -07:00
Gary Qian
9c01d3a9cc
Manual engine roll, Update goldens, improved wavy text decoration 0f9e297ad..185087a65f (#35066) 2019-06-27 15:37:13 -07:00
Kate Lovett
005fa1c689
Updating names to correct versioning convention (#33865) 2019-06-06 12:15:44 -07:00
Gary Qian
14414f350a
Reland "Text inline widgets, TextSpan rework" (#33946) 2019-06-05 18:14:17 -07:00
Gary Qian
2db7918eb5
Revert "Text inline widgets, TextSpan rework (#33794)" (#33928)
This reverts commit 86862c1e62.
2019-06-05 11:35:46 -07:00
Gary Qian
86862c1e62
Text inline widgets, TextSpan rework (#33794)
* Merge in changes for inline widgets

* Make analyzer happy, fix tests

* Fix analyzer

* Add missing doc

* Docs on RichText

* Fix analyzer some more

* Remove whitespace at end of line

* Update goldens

* Text fixes

* Analyzer
2019-06-04 16:27:53 -07:00
Kate Lovett
04015b987b
Fixing duplicate test names. (#33805) 2019-06-04 07:01:52 -07:00
SimonIT
683238e82a Fix disabled CupertinoTextField style (#32974) 2019-06-03 10:34:47 -07:00
Tong Mu
fa3fbc89a3
Material allows "select all" when not collapsed (#32950)
This PR enables "Select all" on MaterialTextSelection when text is partially selected.
2019-05-30 10:03:31 -07:00
Justin McCandless
6031c56d4c
Material Long Press Text Handle Flash (#32911)
Fix a bug where holding down on text selection caused the handles to flash. The fix was to only update selection when it actually changed.
2019-05-23 08:15:59 -07:00
Gary Qian
4102486d63
Center iOS caret, remove constant offsets that do not scale (#31687) 2019-04-30 17:41:01 -07:00
liyuqian
71a89a469a
Reland "Fix text field selection toolbar under Opacity (#31097)" (#31802)
This reverts commit 120a1fc47f.

Updated the golden file
2019-04-30 09:47:32 -07:00
xster
8cfc92465d
CupertinoPicker fidelity revision (#31464) 2019-04-25 00:03:04 -07:00
Dan Field
06e1f8fc15
Roll engine to 3e47b4bb39bb4993f03a278ea7b1c11ee6459b06 (#31569)
* Manual roll with updated test
2019-04-24 17:20:02 -07:00
Gary Qian
3c8e3b097f
Use full height of the glyph for caret height on Android v2 (#31210)
Will cause golden and Scuba changes. Caret will become taller and shift upwards by 2 pixels.
2019-04-17 15:50:03 -07:00
Gary Qian
96e1fc9c34
Use full height of the glyph for caret height on Android (#30991) 2019-04-16 10:42:36 -07:00
LongCatIsLooong
b8a1870d92
add golden tests for CupertinoDatePicker (#30828)
Add golden tests for CupertinoDatePicker
2019-04-10 19:46:23 -07:00
Dan Field
5c258366d4
Reland composite physical layers for all platforms (#29701)
* Composite physical layers even if elevation is 0
2019-03-20 17:37:47 -07:00
liyuqian
79e3bf4ad3
Manually roll engine to 5088735e5 (#29566)
Need this manual roll because of golden changes.

flutter/engine@5088735e5 Clip to clip_rect instead of paint bounds (flutter/engine#8183)
flutter/engine@8818a6c41 Roll src/third_party/skia 2c043c288169..4a522b7e916c (3 commits) (flutter/engine#8201)
flutter/engine@048d70bc0 Support dartdevc, dart2js with shared source files, dartdevc sdk (flutter/engine#8105)
flutter/engine@e0782dec7 Roll src/third_party/skia 576b2a5596bc..2c043c288169 (2 commits) (flutter/engine#8200)
2019-03-18 17:34:20 -07:00
Dan Field
a29906d5f5
Roll engine to 403337ebb893380101d1fa9cc435ce9b6cfeb22c (#29377)
* Manual engine roll with goldens
2019-03-14 19:06:23 -07:00
Jonah Williams
8d5cb658fb
Revert "Manual engine roll with goldens (#29363)" (#29374)
This reverts commit c2e08913c0.
2019-03-14 13:07:06 -07:00
Dan Field
c2e08913c0
Manual engine roll with goldens (#29363) 2019-03-14 11:35:01 -07:00
Dan Field
7ac2486a4c Revert "Always composite PhysicalModels (#28919)" (#29314)
This reverts commit 58fb183298.
2019-03-13 22:19:31 -04:00
Dan Field
58fb183298
Always composite PhysicalModels (#28919)
* Always composite PhysicalModels
* Update tests to check layer tree instead of canvas for Physical shadows
2019-03-12 16:34:13 -07:00
Chris Bracken
01a29b85ef
Roll engine 4f54a1d...2e97618 (#28899)
flutter/engine@f4951df19 (upstream/master) Minor cleanups to CONTRIBUTING.md (flutter/engine#8043)
flutter/engine@effee2f80 remove extra statement (flutter/engine#8041)
flutter/engine@14e082fa0 (master) add lint script for Android with baseline (flutter/engine#8036)
flutter/engine@5fed42197 Roll src/third_party/skia 25bc174cf682..72542816cadb (14 commits) (flutter/engine#8040)
flutter/engine@e6a5201f0 Add missing values to semantics action enums (flutter/engine#8033)
flutter/engine@75d4db31d Roll src/third_party/skia fbc887df72ec..25bc174cf682 (7 commits) (flutter/engine#8039)
flutter/engine@c46226980 Roll src/third_party/skia 0a57971f0544..fbc887df72ec (1 commits) (flutter/engine#8037)
flutter/engine@ed628da00 Add missing kHasImplicitScrolling enum value (flutter/engine#8030)
flutter/engine@052774e1c Roll src/third_party/skia e3e80b7edfd1..0a57971f0544 (16 commits) (flutter/engine#8035)
flutter/engine@2cd9b41ba Select MPL instead of LGPL (flutter/engine#7991)
flutter/engine@629c0d836 Roll src/third_party/dart 7d8ffe0daf..571ea80e11 (3 commits)
flutter/engine@8f1fdcd19 Android Embedding PR 14: Almost done with FlutterFragment. (flutter/engine#8000)
flutter/engine@fb3e35d6a Android Embedding PR15: Add Viewport Metrics to FlutterView (flutter/engine#8029)
flutter/engine@36ca5740c (flutter/engine#8026)
flutter/engine@3d53e2026 Roll src/third_party/skia 5800f2e8a920..e3e80b7edfd1 (2 commits) (flutter/engine#8028)
flutter/engine@f3d4a7f71 Roll src/third_party/dart 7c70ab1817..7d8ffe0daf (77 commits)
flutter/engine@a2246c199 Start of linting Android embedding (flutter/engine#8023)
flutter/engine@48bf4803e [fuchsia] Fix snapshot BUILD.gn file for Fuchsia roll (flutter/engine#8024)
2019-03-05 18:18:44 -08:00
xster
e100ddfe26
Rename SuperellipseShare ContinuousRectangleBorder (#28183) 2019-02-20 15:35:22 -08:00
Dan Field
dd23be3936
Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560 (#28178)
* Roll engine to f45572e95f93edb89b6750a4f36ad8ed7c0a2560

* update goldens

* update goldens version
2019-02-19 21:35:31 -08:00
Ian Hickson
f4d5646b31
Make NotchedShape more practical to use (#27487)
This PR does two things:

- It allows BottomAppBar to have a custom shape even when it doesn't
  have a notch.

- It adds AutomaticNotchedShape, an adapter from ShapeBorder to
  NotchedShape.
2019-02-04 22:24:41 -08:00
Gary Qian
c6cc3cdeda
Integrate Strut: Add StrutStyle, expose Strut API, wire up strut with dart:ui, Roll engine 31a7f4d..e7eb1c8 (7 commits) (#26332)
Includes a breaking change to dart:ui ParagraphStyle where lineHeight is renamed to height for consistency with TextStyle.
2019-02-04 10:17:25 -08:00
rami-a
327e3eff77
Add Material/Card borderOnForeground flag to allow border to be painted behind the child widget (#27297)
In certain situations, a developer may require the border of a Material to be painted behind its child. For example a Card widget that has a full width image across the top half. In that scenario, the image should ideally be painted above the border with regards to z-position.

This change exposes a flag on Material widget to achieve this behavior. Additionally, the same flag is exposed on Card widget to allow the Card widget to pass this down to its Material.

I added a couple golden tests to verify this new behavior. Goldens are here:
46a3d26acb
2019-01-30 15:59:50 -05:00
jslavitz
d2a2a5cfe2
Adds a fade in and out, rounds corners, fixes offset and fixes height of cursor on iOS (#24876)
* Fixes cursor on iOS devices
2019-01-28 19:49:19 -08:00
Will Larche
c362d8da07 [Material] Theme data type for cards (#26796)
This change adds a CardTheme and tests for it.

Golden is here:
ec26eeebb4/packages/flutter/test/material/card_theme.custom_shape.png

From commit:
ec26eeebb4 (diff-7564b206413654283ddc5cb59ecd64d4)
2019-01-24 11:01:21 -05:00
Dan Field
450abfe96d
Roll engine to 10eb972fc15b8a3f97ed7c26032cae03b10fca2c (#26926) 2019-01-22 18:26:17 -08:00
Michael Goderbauer
e4c8f1b993
3D SemanticsTree (#25670) 2019-01-16 10:29:00 -08:00
Gary Qian
fc779c69a7
Add Golden test for background painting order. (#25988) 2019-01-15 19:40:39 -05:00
Ian Hickson
29928a46ed
Support setting the elevation of disabled floating action buttons (#24728)
Previously, a disabled floating action button always had zero
elevation, which looks dumb.

This also fixes the issue whereby highlightElevation was not honoured
on floating action buttons.

This also fixes an issue I found during testing whereby setState was
being called during build when onHighlightChanged fired due to
onPressed becoming null while a gesture is ongoing (which triggers an
onTapCancel synchronously during build).
2019-01-15 15:06:29 -08:00
Sander Dalby Larsen
6c6fdaff81 Added the superellipse (a.k.a. squircle) shape to flutter. (#26295)
* Added the superellipse (a.k.a. squircle) shape to flutter, which is needed to recreate some cupertino components, e.g. buttons in pixel-perfect detail (issue #13914).
2019-01-10 12:17:01 -08:00
xster
b8a035a3d4
Adds CupertinoTheme (#23759) 2018-12-18 20:36:35 -08:00
liyuqian
ba635a643a
Add golden tests for Opacity with offset (#24253)
See https://github.com/flutter/flutter/issues/23890
2018-11-14 15:00:39 -08:00
Michael Beckler
9abce96e8e BottomNavigationBar: bug fix for dealing with animations with shifting tabs (#22264)
Should fix #22226.

Code introduced in #20890 caused a regression that broke color flooding animations in a BottomNavigationBar that has BottomNavigationBarType.shifting.

The original issue (#19653) dealt with background color changes not occurring until another tab was selected. The result is that the background color instantly changes whenever the state changes and when the widget changes, instead of allowing a new widget to animate the background color change.
2018-11-07 09:20:27 -08:00
Michael Goderbauer
a0e667857e Roll engine to dd32b3fbc21439df90c872eee88de9cb35633697 2018-11-05 16:06:54 -08:00
MH Johnson
50098f149d
[Material] Theme for Dialogs (#23569)
* [Material] Add dialog theme.

* Address Hans' first round comments.

* Address Hans' Second round comments.

* Fix theme tests

* Address Will's comments, add golden test

* Update goldens

* Custom Border radius 16.0

* Address Hans' Comments

* Second round comments

* fix imports
2018-10-30 22:54:49 -04:00
Gary Qian
6827d0920b
Same cursor offset within lines for all TextAffinities to prevent cursor shifting/moving. (#23485) 2018-10-26 10:21:25 -07:00
Gary Qian
02d659e82a
Support null locale before locale initialization, Roll engine to cdd592f5be97e824 (#23417)
cdd592f5b Reland 'Pass null instead of 'none' locale' (#6632)
2cd89200c Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) (#6631)
edfe02481 13771 - iOS dictation bug (#6607)
cadf4405b Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (#6626)
2018-10-23 13:57:43 -07:00
liyuqian
b0787b900f
Roll engine 04c860fa1dba..8cc49cac3b4a (3 commits) (#23223)
And update goldens.

git log 04c860fa1dba..8cc49cac3b4a --no-merges --oneline
8cc49cac3 Ensure that the isolate shutdown callback occurs in an isolate scope. (flutter/engine#6572)
04a1ffa42 Roll src/third_party/skia cb65ce7f77c9..3a0c66da5fc2 (10 commits) (flutter/engine#6571)
35340ceaf Pass full locale list with script and variant codes to framework (flutter/engine#6557)
2018-10-17 21:49:37 -07:00
Gary Qian
bdc3dda5f2
Add support for text shadows and roll engine (26 commits) (#22449)
* Add support for shadows in text.

* Use dart:ui Shadow as base class for Shadows

* Update lerp definition

* Roll engine 3ffa3629523..84fe4a9f7e24e4 - Text Shadows and update goldens for skia roll.

git log 50c2e69daff4e207c54e463d2304139985c7511c..32f417db0d566d354605305cb29c251276fa65ee --oneline --no-merges
32f417db0 Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (#6541)
4ee77256c Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)" (#6537)
964acafeb Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (#6536)
d4bae4ca4 Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (#6535)
ff93ccf47 Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (#6534)
a4161c895 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (#6532)
116072e46 Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (#6531)
ef0b0f6e9 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (#6530)
f46b7b971 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (#6529)
9033c3902 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (#6528)
e6887a412 Add missing imports for unicode/utf16.h (#6524)
1242f6dfe Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (#6527)
a1bbea77c Add a no-op platform view layer. (#6505)
2bb3afad8 Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (#6526)
75e875240 Fix the Mac embedder build (#6525)
436f9707b Add version check for dismissable (#6522)
7767c785b Provide a default GL function resolver in the embedder (#6523)
32841dd89 Case-insensitive matching of family names for custom fonts (#6519)
a9076c7e6 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (#6520)
f2e7441b5 An API for loading fonts from a buffer provided by the application (#6508)
05aac0f27 fix ResourceExtractor npe. (#6461)
cf5a2a145 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (#6517)
84fe4a9f7 Re-revert invalid line height tests (#6516)
5f529566c Add support for text shadows (#6385)
e44c10c96 Reland "Share engine layers with the framework" (#6412) (#6468)
ba0449971 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)
2018-10-15 15:03:02 -07:00