Commit Graph

62 Commits

Author SHA1 Message Date
Kate Lovett
20078f89bc
Remove deprecated TimelineSummary.writeSummaryToFile (#143983)
https://github.com/flutter/flutter/issues/143956
2024-02-23 01:55:20 +00:00
Jonah Williams
ec12ba2875
[Impeller] GPU frame timings summarization. (#136408)
Allow processing GPU start and end events to get processed by flutter driver. To figure out whether or not this works we'll ship in on CI :)
2023-10-13 22:18:37 +00:00
Callum Moffat
b097d24022
Add "Frame Request Pending" lag to collected metrics (#135279)
This measures the wall clock time between a new frame being scheduled in dart code to the Vsync callback in the engine

It's an important source of lag which isn't shown in the top-level UI / Build time graphs, and can correlate with "invisible" missed/non-scheduled frames

I had to change a few unrelated timings in the test, it was only passing based on luck of sort order, and broke when I added more entries to the timeline.

Part of #129150
2023-09-26 00:35:57 +00:00
Ian Hickson
b29069ec0b
Document that missed_frame_build_budget_count is misleading (#132137)
Fixes https://github.com/flutter/flutter/issues/109745
2023-08-08 22:08:30 +00:00
gaaclarke
947367aaa2
Added standard deviation to rasterizer results. (#131781)
This calculation is important if you want to calculate the probability that one thing is better than another.
2023-08-02 16:40:07 +00:00
Jonah Williams
0053b089a6
[flutter_driver] make empty duration messages more helpful (#110441) 2022-08-28 19:54:08 +00:00
Alexandre Ardhuin
ccd33631e3
enable combinators_ordering (#107847) 2022-07-18 22:04:07 +00:00
Pierre-Louis
74cfc3db67
Use curly_braces_in_flow_control_structures for non-flutter packages (#104629)
* Use `curly_braces_in_flow_control_structures` for `packages/flutter_driver`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_goldens_client`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_localizations`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_test`

* Use `curly_braces_in_flow_control_structures` for `packages/flutter_web_plugins`

* fix comments

* Use `curly_braces_in_flow_control_structures` for `packages/integration_test`

* fix indentation
2022-05-25 20:01:11 +02:00
Chris Yang
e6bd208196
Reland "Add the refresh rate fields to perf_test #99710" (#99854) 2022-03-21 15:55:13 -07:00
Zachary Anderson
5f76ac35bc
Revert "Add the refresh rate fields to perf_test (#99710)" (#99801)
This reverts commit a7c85996b8.
2022-03-08 23:04:49 -08:00
Chris Yang
a7c85996b8
Add the refresh rate fields to perf_test (#99710) 2022-03-08 17:25:15 -08:00
Chris Yang
0ce527eb91
[flutter_driver] show refresh rate status in timeline summary (#95699) 2022-02-09 15:05:03 -08:00
Kaushik Iska
8e9bca802f
Compute the total time spent on UI thread for GC (#95692) 2021-12-22 17:04:35 -05:00
Jason Simmons
2004afae06
Use async timeline events for the phases of the scheduler binding (#88825) 2021-09-10 10:17:05 -07:00
Jim Graham
abfb889fff
Add raster cache metrics to timeline summaries (#89393) 2021-09-04 18:31:03 -07:00
Dan Field
0866005f70
Add benchmark for number of GCs in animated GIF (#81240) 2021-04-27 10:39:02 -07:00
Dan Field
d377c1baed
Always write full timeline before summary (#79310) 2021-03-31 13:01:28 -07:00
Kaushik Iska
2e7e5b4530
Add timeline summary entries to capture vsync frame lag (#79090) 2021-03-26 19:44:01 -07:00
Michael Goderbauer
7b251f5f37
Enable use_function_type_syntax_for_parameters lint (#77163) 2021-03-04 08:59:17 -08:00
Dan Field
3ece9c63d9
Flutter_driver nnbd (#74856) 2021-01-27 23:55:26 -08:00
Jonah Williams
4f2fcca6a9
Reland "[null-safety] reland: migrate app side flutter driver to null-safety" (#67570) 2020-10-08 17:42:02 -07:00
Dan Field
ad49e25a6b
Revert "[null-safety] reland: migrate app side flutter driver to null-safety (#67441)" (#67561)
This reverts commit d411242468.
2020-10-07 13:57:49 -07:00
Jonah Williams
d411242468
[null-safety] reland: migrate app side flutter driver to null-safety (#67441)
Reland: #67155

Fixes analysis error caused by landing of material migration, and g3 error caused by moving of fuchsia lib.
2020-10-06 16:51:37 -07:00
Jonah Williams
4818537044
Revert "[null-safety] migrate app dependencies of flutter driver (#67155)" (#67433)
This reverts commit e826442ef4.
2020-10-06 10:41:45 -07:00
Jonah Williams
e826442ef4
[null-safety] migrate app dependencies of flutter driver (#67155)
Ensures all of the libraries that the application side code import are migrated to null safety. full null safety migration is blocked by json rpc 2 and a breaking change to vm service client.
2020-10-06 10:30:15 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. (#65568) 2020-09-16 14:14:06 -07:00
Michael Goderbauer
f4e10b4fb5
Make dartdoc warnings fatal (& cleanup of warnings) (#62367) 2020-07-28 16:11:04 -07:00
Kaushik Iska
afd745e893
Filter profiling events by names not category (#61185)
Category isn't preserved by timeline events as `Dart_TimelineEvent`
specifies the category as `embedder`.

Fixes: https://github.com/flutter/flutter/issues/60008
2020-07-10 12:13:56 -07:00
Ming Lyu (CareF)
9c3f0faa6d
Add comments to flutter_driver for timeline class (#58823)
* Add comments to flutter_driver for timeline class

Mostly about explanation for the json items from
timeline.dart and timeline_summary.dart.
2020-06-17 18:47:54 -04:00
Kaushik Iska
60cfe4957a
Timeline summary contains CPU, GPU and Memory usage (#58820)
As of flutter.dev/go/engine-cpu-profiling, we collect the CPU and
Memory usage. With work being done to collect GPU usage on iOS as well.

This adds them to the timeline summary.

Fixes: https://github.com/flutter/flutter/issues/58803
2020-06-08 17:17:46 -07:00
Jim Graham
e48e2e6ab9
add rasterizer start times to timeline summaries (#58514) 2020-06-03 16:18:02 -07:00
Kaushik Iska
7b9aeb2ff2
[flutter_driver] Reland add SceneDisplayLag stats to timeline summary (#54490) 2020-04-11 15:30:01 -07:00
Kaushik Iska
50b4c39c5d
Revert "[flutter_driver] Add SceneDisplayLag stats to timeline summary (#54218)" (#54480)
This reverts commit ce92333bf7.
2020-04-10 12:48:48 -07:00
Kaushik Iska
ce92333bf7
[flutter_driver] Add SceneDisplayLag stats to timeline summary (#54218) 2020-04-10 12:20:01 -07:00
Kaushik Iska
4987210ab6
[benchmarks] Handle multiple begin/end trace events (#54220)
Parser would earlier alternate after finding the first
begin event, not it looks for pairs.

Fixes: https://github.com/flutter/flutter/issues/54095
2020-04-10 10:32:41 -07:00
Filip Hracek
1593788cd9
Rename GPU thread to raster thread in API docs (#53422) 2020-04-08 18:57:03 -07:00
liyuqian
54d75a515a
Print frame begin time in summary (#50272) 2020-04-02 10:16:03 -07:00
Francisco Magdaleno
bc0d35c34e
Reland "fix duration event of timeline summary (#47742)" (#47889)
This reverts commit 50d421224d.
2019-12-27 11:15:48 -08:00
Francisco Magdaleno
50d421224d
Revert "fix duration event of timeline summary (#47742)" (#47888)
This reverts commit e43fd1c54d.
2019-12-27 10:26:49 -08:00
Gityuan
e43fd1c54d fix duration event of timeline summary (#47742)
* fix duration event of timeline summary

* Revert "fix duration event of timeline summary"

This reverts commit 699aa45ed3.

* fix duration event of timeline summary
2019-12-27 09:36:59 -08:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Alexandre Ardhuin
bfa1d25bf9
some formatting of map, parameters and spaces (#29760) 2019-03-23 00:02:21 +01:00
Alexandre Ardhuin
5169ab5974
format parameter list (#27261) 2019-02-21 09:27:07 +01:00
liyuqian
7390cc5cdb
Increase our build budget to 16ms (#27709)
Because we now have 2 separate GPU and UI threads.
2019-02-15 16:12:36 -08:00
Alexandre Ardhuin
0fb84e96c7
Prefer void to null (#22977)
* Future<void> main

* Future<void>.delayed

* prefer_void_to_Null

* address review comments
2018-10-16 22:03:06 +02:00
Alexandre Ardhuin
5de96bb734
unnecessary this in field initializers (#22522) 2018-10-02 17:14:59 +02:00
Alexandre Ardhuin
f62afdcf57
add missing type parameter on methods (#22096) 2018-10-01 21:29:08 +02:00
liyuqian
872eba2d4c
Track 90th, 99th percentile instead of missed_frame_build_budget_count (#21754)
See https://github.com/flutter/flutter/pull/19121#issuecomment-419520765
2018-09-14 13:24:13 -07:00
Alexandre Ardhuin
d927c93310
Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
Ian Hickson
1993a67381
Performance test cleanup (#20652)
* Fix TODO syntax.
* Clarify messages for some timeouts, to aid debugging.
* Increase some other timeouts that were a needlessly short, to reduce sources of flakes.
* Remove some more timeouts that were mostly redundant, to remove complexity.
* Minor style cleanup.
* Remove some dangerous traps (specifically, hide the explicit start/end times in TimedEvent since they shouldn't matter).
2018-08-17 13:19:28 -07:00