Commit Graph

9920 Commits

Author SHA1 Message Date
Bjarte Bore
1c374c6598
Added support for MaterialState to InputDecorator (#91182) 2021-10-06 09:36:06 -07:00
Kate Lovett
3aed0b671f
Fix scrollbar dragging into overscroll when not allowed (#90634) 2021-10-05 15:33:03 -07:00
Alexander Aprelev
947ffa1f90
Use recently introduced Isolate.exit() in compute implementation (#91124)
* Use recently introduced Isolate.exit() in compute implementation

* Remove unused isolate variable
2021-10-05 12:04:20 -07:00
Ian Hickson
2bab6514b0
Enable avoid_implementing_value_types lint (#91078) 2021-10-04 13:48:04 -07:00
Greg Spencer
fd9ce27748
Clean up examples, remove section markers and --template args (#91133)
This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder.

I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed.

I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
2021-10-04 12:16:17 -07:00
Ian Hickson
126cd7388e
Clean up dependency pins and update all packages (#91109) 2021-10-04 10:28:03 -07:00
xubaolin
905ac63e34
Fix some scrollbar track and border painting issues (#90311) 2021-10-04 08:13:04 -07:00
Fernando Moraes
7ff13ca405
Update TabPageSelector Semantics Label Localization (#87430) 2021-10-01 14:28:04 -07:00
LongCatIsLooong
0e72f99237
Restart input connection after EditableText.onSubmitted (#84307) 2021-10-01 14:23:05 -07:00
Kate Lovett
5ab6c7bce1
Fix overflow edge case in overscrolled RenderShrinkWrappingViewport (#90419) 2021-10-01 09:08:02 -07:00
Kate Lovett
778876597a
Remove AndroidViewController.id deprecation (#90294) 2021-10-01 09:03:02 -07:00
Kate Lovett
eda41e5720
Remove vsync deprecation (#90293) 2021-10-01 08:58:03 -07:00
Ian Hickson
989f864497
Enable avoid_setters_without_getters (#91067) 2021-10-01 00:58:05 -07:00
Hans Muller
50604c614e
Add a warning about Icon.size to IconButton (#91051) 2021-09-30 23:18:02 -07:00
Greg Spencer
d94c18d2b9
Add external focus node constructor to Focus widget (#90843)
I've added a Focus.withExternalFocusNode constructor to the Focus widget (and the FocusScope widget) that makes it explicit that the widget's attributes won't affect the settings of the given focus node.

This is to help address #83023, which is a snag in the API that people run into occasionally.

This should help make it explicit when you want the widget attributes to take precedence, and when you don't.
2021-09-30 16:46:38 -07:00
Hans Muller
0438bdfe12
TextStyle.apply,copyWith,merge should support a package parameter (#90986) 2021-09-29 15:35:28 -07:00
Kenzie (Schmoll) Davisson
15967669b2
Add richMessage parameter to the Tooltip widget. (#88539) 2021-09-29 15:31:54 -07:00
Justin McCandless
cf09d99372
Handle invalid selection in TextEditingActionTarget (#90826)
Prevents bugs related to invalid (-1,-1) selection in keyboard shortcuts
2021-09-29 13:14:10 -07:00
nt4f04uNd
96a63cfe48
use FadeTransition instead of Opacity where applicable (#75110) 2021-09-29 12:18:03 -07:00
Greg Spencer
bac1af32ee
Reland: "Fix tooltip so only one shows at a time when hovering (#90457)" (#90917)
This reverts commit ab51a02 and fixes the test that broke the first time it landed.
2021-09-29 08:56:52 -07:00
LongCatIsLooong
7684f8b7c5
Reland "Make FilteringTextInputFormatter's filtering Selection/Composing Region agnostic" #89327 (#90211) 2021-09-28 16:48:06 -07:00
Greg Spencer
ab51a0260d
Revert "Fix tooltip so only one shows at a time when hovering (#90457)" (#90909)
This reverts commit 885b2f56e1 to green up the build.

Submitting on red to fix the build.
2021-09-28 15:18:53 -07:00
Greg Spencer
777463c276
Adjust size of delete button to take up at most less than half of chip. (#90845)
This adjusts the size of the delete button so that it takes up just slightly less than half of the chip, so that legacy tests that tap on the center of the chip still hit the chip, and not the delete button.

A follow-on change for #90531
2021-09-28 14:20:36 -07:00
Greg Spencer
885b2f56e1
Fix tooltip so only one shows at a time when hovering (#90457)
In the process of fixing #90044, I realized that it's also possible for hovered tooltips to show more than one at a time if the widgets are nested, so this PR is a fix that prevents more than one tooltip from showing at a time with hovered tooltips.
2021-09-28 14:20:01 -07:00
yk3372
d2c8b62351
make Elevated&Outlined&TextButton support onHover&onFocus callback (#90688) 2021-09-28 10:51:14 -07:00
Greg Spencer
ab2b0851a2
Add smoke tests for all the examples, fix 17 broken examples. (#89021)
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
2021-09-28 09:32:06 -07:00
Hans Muller
3a6c18daec
Correct notch geometry when MediaQuery padding.top is non-zero (#90703) 2021-09-27 17:31:23 -07:00
Callum Moffat
8ed704d8e7
CupertinoContextMenu: Use root Overlay (#89331) 2021-09-27 12:28:07 -07:00
nt4f04uNd
c70df378ae
Change hitTest signatures to be non-nullable (#87792) 2021-09-27 10:38:05 -07:00
Aayan
0082ff973e
Material banner updates (#90380) 2021-09-27 13:14:52 -04:00
David Iglesias
92a55d0a9c
Add DDC regression test. (#90692) 2021-09-27 08:23:06 -07:00
MH Johnson
f3049c7762
add navigation bar component (#83047) 2021-09-26 08:03:04 -07:00
Greg Spencer
0b7dc66298
Fix Chip tooltip so that useDeleteButtonTooltip only applies to the delete button. (#90464)
This fixes #90044 by limiting the effect of useDeleteButtonTooltip to the delete button, instead of both the main tooltip and the delete button. This means that when useDeleteButtonTooltip was false, it used to not display the main tooltip either, but now it does.
2021-09-24 16:56:03 -07:00
Kate Lovett
610ca324c3
Update scrollbar for hover events (#90636) 2021-09-24 14:13:05 -07:00
Greg Spencer
cf89a787a9
Fix various problems with Chip delete button. (#90531) 2021-09-24 13:03:07 -07:00
Kate Lovett
ca1dbb949e
Fix stretch recede edge case (#90629) 2021-09-23 15:33:05 -07:00
HeavenOSK
115b953559
Fix index of TabBarView when decrementing (#88878)
Small change to the calculation of the page to move to when flinging on a TabBarView
2021-09-23 14:23:04 -07:00
Mouad Debbar
870cc27f0c
Unskip some editable tests on web (#90526) 2021-09-22 15:03:05 -07:00
Casey Rogers
ec2e041e3d
Make DraggableScrollableSheet Reflect Parameter Updates (#90354) 2021-09-22 14:58:05 -07:00
nt4f04uNd
6fabdd049a
Make structuredErrors to not mess up with onError (#88253) 2021-09-22 14:53:04 -07:00
Gary Qian
375c72681d
Add clipBeheavior support to TextFields (#90423) 2021-09-22 13:43:58 -07:00
Justin McCandless
c603d8aa06
Revert "Issue 88543: TextField labelText doesn't get hintTextStyle when labelTextStyle is non-null Fixed (#89386)" (#90406) 2021-09-22 13:28:05 -07:00
Bonsai11
6d2d9b2f3c
Adding onLongPress for DataRow (#87172)
* Adding onLongPress for DataRow

Useful to be able to e.g. start a selection mode of rows or show a drop down menu.

* Test for onLongPress

* Changed parameter
2021-09-21 11:17:08 -07:00
nt4f04uNd
49332da76a
Fix Dismissible confirmDismiss errors (#88672)
* Fix Dismissible confirmDismiss errors

* +

* refactor test

* fix rebase

* remove new line
2021-09-20 13:50:32 -07:00
Casey Rogers
76b3c6758c
Allow Developers to Stop Navigator From Requesting Focus (#90097) 2021-09-20 13:13:03 -07:00
chunhtai
c9751c9292
Fixes dialog title announce twice (#90075) 2021-09-20 12:48:05 -07:00
Kate Lovett
d50ec2469f
Fix overflow in stretching overscroll (#90215) 2021-09-20 12:23:05 -07:00
Pierre-Louis
8d5d37d6df
Exclude semantics is semanticslabel is present (#90136) 2021-09-20 12:18:05 -07:00
Greg Spencer
19722fb96c
Clean up dismissable_test to be less fragile (#89870)
This cleans up the dismissable_test to be less fragile, and make it harder to forget to reset things between runs.

I eliminated a bunch of globals that were susceptible to being missed and passed them in to buildTest instead, and removed some values that were always the same (itemExtent).
2021-09-20 09:07:28 -07:00
Varun Kamani
de0aab1751
Issue 88543: TextField labelText doesn't get hintTextStyle when labelTextStyle is non-null Fixed (#89386)
labelText now gets hintTextStyle when no labelStyle, per the docs
2021-09-17 16:19:55 -07:00