Commit Graph

6402 Commits

Author SHA1 Message Date
Emmanuel Garcia
975e04ba6d
Move corrupted zip to a separate handler and ask user (#105054) 2022-06-03 10:08:08 -07:00
jensjoha
9929446ea3
Extra timing on hot reload (#104242)
This PR adds extra timings for a hot reload.
As an example, before a user might see

> Performing hot reload...                                                
> Reloaded 1 of 788 libraries in 554ms.

With this PR it would instead be something like

> Performing hot reload...                                                
> Reloaded 1 of 788 libraries in 554ms (compile: 33 ms, reload: 153 ms, reassemble: 310 ms).
2022-06-03 08:41:14 +02:00
Elliott Brooks (she/her)
81734be7ec
Remove package:shelf version pin (#105261) 2022-06-02 21:23:09 -07:00
Jenn Magder
208a418abc
flutter drive --enable-software-rendering --skia-deterministic-rendering (#105161) 2022-06-02 13:33:08 -07:00
Jenn Magder
dffddf00a2
Refactor BuildIOSFrameworkCommand with common darwin baseclass (#105194) 2022-06-02 10:28:08 -07:00
Christopher Fujino
99d0f8f279
[flutter_tools] handle HandshakeException in httphostvalidator (#105076) 2022-06-01 14:08:13 -07:00
Christopher Fujino
ac791adbc0
[flutter_tools] flutter daemon handles a closed stdout IOSink (#105075) 2022-06-01 10:08:13 -07:00
Emmanuel Garcia
3b20fb3f89
Retry builds when SSL exceptions are thrown (#105078) 2022-05-31 19:53:12 -07:00
Chris Bracken
73ae3243de
[tool] Migrate off deprecated coverage paramters (#104997)
In https://github.com/flutter/flutter/pull/103771, we rolled
dependencies in Flutter, which triggered an update of package:coverage
to v1.3.1. The new version includes
https://github.com/dart-lang/coverage/pull/370 in which two deprecations
landed:

* The `Resolver` default constructor was deprecated and replaced with
  the `Resolver.create` static factory method, which unfortunately
  happens to be async.
* The `packagesPath` parameter to `HitMap.parseJson`, which takes the
  path to the `.packages` file of the package for which coverage is to
  be collected, was deprecated. This parameter was replaced with
  `packagePath` in https://github.com/dart-lang/coverage/pull/370 which
  was part of the overall deprecation of the .packages file in Dart
  itself https://github.com/dart-lang/sdk/issues/48272. The overall goal
  being that end-user code shouldn't need to know about implementation
  details such as whether dependency information is stored in a
  .packages file or a package_info.json file, but rather use the
  package_config package to obtain the package metadata and perform
  other functions such as resolving its dependencies to filesystem
  paths. packagesPath was replaced by packagePath, which takes the path
  to the package directory itself. Internally, package:coverage then
  uses package_config to do the rest of the package/script URI
  resolution to filesystem paths.

This migrates off the deprecated `packagesPath` parameter to the
replacement `packagePath` paramter.

Issue: https://github.com/flutter/flutter/issues/103830
2022-05-31 16:15:28 -07:00
Darren Austin
c27a1a70f3
Update material_color_utilities dependency to 0.1.5. (#104771) 2022-05-27 11:18:12 -07:00
David Iglesias
b7eaad8b14
[tool][web] Fix flutter.js in Safari 13 (#104761) 2022-05-26 17:50:10 -07:00
Anna Gringauze
5cd979e441
Retry getting tabs in chrome launcher on ConnectionException (#104218) 2022-05-26 15:20:11 -07:00
Gary Qian
cc733660ed
Add link to more detailed multidex information. (#104558) 2022-05-26 13:05:08 -07:00
Danny Tuppeny
147020366a
Fix issues running integration tests through DAP debug adapter (#104618)
* Fix issues running integration tests through DAP

These adapters were incorrectly trying to connect a DDS instance even when Flutter would create its own. This change disables DDS in the DAP layer and leaves it to Flutter (although it passes `--no-dds` on to Flutter if provided to the DAP process).

Also fixes an issue where we would unnecessarily connect the VM Service for tests even in 'noDebug' mode because of a change/fix that now includes a 'vmServiceUri' in the `test.startedProcess` event.
2022-05-26 09:36:30 +01:00
Jenn Magder
f3e567c901
Create static plugin frameworks build ios-framework --static (#104576) 2022-05-25 09:03:12 -07:00
Jenn Magder
09987dc00a
Migrate create command to null safety (#104484) 2022-05-24 18:48:10 -07:00
Jesús S Guerrero
336aa267f9
[flutter_tools] General info project validator (#103653) 2022-05-24 16:28:10 -07:00
Dacian Florea
680bc17cde
[web] [fix] Cache resource data only if the fetching succeed (#103816) 2022-05-24 16:23:06 -07:00
Konstantin Scheglov
c27e88a5b1
Fix existing DUPLICATE_IMPORT diagnostics. (#104533) 2022-05-24 14:18:31 -07:00
Loïc Sharma
c29a7a2d22
Ignore replacement characters from vswhere.exe output (#104284)
Flutter uses `vswhere.exe` to find Visual Studio installations and determine if they satisfy Flutter's requirements. However, `vswhere.exe`'s JSON output is known to contain bad UTF-8. This change ignores bad UTF-8 as long as they affect JSON properties that are either unused, or, used only for display purposes by Flutter.

Fixes: https://github.com/flutter/flutter/issues/102451
2022-05-24 13:30:37 -07:00
Chris Sells
4c66e304d1
fixes 103234 to enable debugging Flutter apps on VR headset (#104135) 2022-05-20 21:58:09 -07:00
Loïc Sharma
52e19ef7ec
Refactor vswhere.exe integration (#104133)
`VisualStudio` calls `vswhere.exe` to find Visual Studio installations and determine if they satisfy Flutter's requirements. Previously, `VisualStudio` stored the JSON output from `vswhere.exe` as `Map`s, resulting in duplicated logic to read the JSON output (once to validate values, second to expose values). Also, `VisualStudio` stored two copies of the JSON output (the latest valid installation as well as the latest VS installation).

This change simplifies `VisualStudio` by introducing a new `VswhereDetails`. This type contains the logic to read `vswhere.exe`'s JSON output, and, understand whether an installation is usable by Flutter. In the future, this `VswhereDetails` type will be used to make Flutter doctor resilient to bad UTF-8 output from `vswhere.exe`.

Part of https://github.com/flutter/flutter/issues/102451.
2022-05-20 10:12:25 -07:00
Zachary Anderson
ab7f6e5cfe
Pass --verbosity=error to the Dart front-end (#104020) 2022-05-20 09:10:31 -07:00
Emmanuel Garcia
0052566c7e
Show custom error message when Kotlin or Gradle bump is required (#102421) 2022-05-19 14:38:13 -07:00
Christopher Fujino
586b15cbcb
[flutter_tools] Upgrade only from flutter update-packages (#103924) 2022-05-19 13:33:11 -07:00
Liam Appelbe
d2ba83d421
Use libraryFilters flag to speed up coverage collection (#104122)
* Use libraryFilters flag to speed up coverage collection

* Allow libraryNames to be null

* Unconditionally enable the reportLines flag

* Fix analysis errors
2022-05-19 12:19:52 -07:00
Jonah Williams
851c9521c7
[flutter_tools] pass --compact-async to frontend_server (#104026) 2022-05-17 19:52:10 -07:00
Jenn Magder
52ddc9d174
Handle null values during yaml metadata parsing validation (#104022) 2022-05-17 18:32:09 -07:00
Christopher Fujino
0116b2e77d
[flutter_tools] fix RangeError in flutter channel command (#103766) 2022-05-17 16:22:12 -07:00
Jonah Williams
2ad7ced916
[flutter_tools] pass --enable-impeller to android (#104014) 2022-05-17 15:52:09 -07:00
Aman Verma
8fbf89b9f2
[flutter_tools] throw error when argResults is null (#103827) 2022-05-17 12:37:08 -07:00
Lau Ching Jun
a633f3df32
Add ability for PrebuiltWindowsApp to accept a zip archive. (#103918) 2022-05-17 11:27:11 -07:00
Jenn Magder
bf7a32628e
Up CocoaPods minumum to 1.10 (#103655) 2022-05-16 17:42:19 -07:00
Chris Bracken
6eb12c6843
[macOS] Update template icons to Big Sur style (#103739)
Updates the AppIcon assets in the macOS app template to meet Apple's
icon guidelines as of macOS Big Sur. Assets were moved to the
[flutter_template_images][1] package, which includes them as of version
4.1.0.

Ref: https://developer.apple.com/design/human-interface-guidelines/macos/icons-and-images/app-icon/

Issue: https://github.com/flutter/flutter/issues/103371

[1]: https://github.com/flutter/packages/tree/main/packages/flutter_template_images
2022-05-14 17:20:24 -07:00
Chris Bracken
27c6cdb416
Roll dependendencies (#103771)
Roll dependendencies

This rolls depdendencies to latest using
flutter update-packages --force-upgrade

This change includes three code changes:

* Removes charcode from the dependencies allowlist since it no longer
  appears in the transitive closure of dependencies of the flutter,
  flutter_test, flutter_driver, flutter_localizations, and
  integration_test packages.

* Uses Resolver.create instead of the deprecated Resolver constructor.
  The default Resolver constructor has been deprecated in favour of the
  static Resolver.create() factory function, which unfortunately happens
  to be async. Propagated the async-ness up the chain.
  This change was partially reverted and the deprecation ignored in this
  patch until package:coverage can be rolled internally at Google.

* Eliminates the use of the deprecated packagesPath parameter to
  HitMap.parseJson. This parameter was deprecated and replaced with
  packagePath in https://github.com/dart-lang/coverage/pull/370 which
  was part of the overall deprecation of the .packages file in Dart
  itself https://github.com/dart-lang/sdk/issues/48272. The overall goal
  being that end-user code shouldn't need to know about implementation
  details such as whether dependency information is stored in a
  .packages file or a package_info.json file, but rather use the
  package_config package to obtain the package metadata and perform
  other functions such as resolving its dependencies to filesystem
  paths. packagesPath was replaced by packagePath, which takes the path
  to the package directory itself. Internally, package:coverage then
  uses package_config to do the rest of the package/script URI
  resolution to filesystem paths.
  This change was partially reverted and the deprecation ignored in this
  patch until package:coverage can be rolled internally at Google.

This is a pre-update prior to updating flutter_template_images in
https://github.com/flutter/flutter/pull/103739

Issue: https://github.com/flutter/flutter/issues/103371
Issue: https://github.com/flutter/flutter/issues/103775
Issue: https://github.com/flutter/flutter/issues/103830

When re-applying the partially-reverted changes to code coverage,
we'll need to patch host_entrypoint.dart internally to await the Future
that we'll be returning rather than a non-async value.
2022-05-14 16:34:10 -07:00
Christopher Fujino
0ad0dc255d
[flutter_tools] fix missing cmake (#103761) 2022-05-14 11:59:07 -07:00
Jonah Williams
90a592bf36
[flutter_tools] fix test asset loading (#103667) 2022-05-14 10:59:07 -07:00
Chris Bracken
f2116cb0b2
[tool] Fix BuildInfo.packagesPath doc comment (#103785)
Until recently, BuildInfo.packagesPath defaulted to `.packages` however,
the .packages file has been deprecated [1] and is being removed. In
https://github.com/flutter/flutter/pull/99677 the default was changed to
`.dart_tool/package_config.json` but the doc comment was accidentally
updated to `.dart_tool/packages`. This corrects it to the true default
value.

1: https://github.com/dart-lang/sdk/issues/48272

Spotted in the midst of some related cleanup relating to
https://github.com/flutter/flutter/issues/103775
2022-05-14 10:28:35 -07:00
Chris Bracken
28aaa1e99e
Fix deprecation doc comment (#103776)
Point users of boolArgDeprecated to boolArg rather than to
boolArgDeprecated in order to avoid losing users to infinite loops or
stack overflows depending on their implementation.
2022-05-13 19:23:07 -07:00
Christopher Fujino
4c417884c2
[flutter_tools] ensure linux doctor validator finishes when pkg-config is not installed (#103755) 2022-05-13 18:24:13 -07:00
engine-flutter-autoroll
7d234c966a
Roll Flutter Engine from 58193a3b6ef1 to 10e0e15347d3 (5 revisions) (#103742)
* c4b899f63 Roll dart sdk to 7b24ff4d92e2d2136020fc5bedadfe7025861510 (flutter/engine#33309)

* 7956603cc [web] Migrate Flutter Web DOM usage to JS static interop - 12. (flutter/engine#33241)

* 1d0c2ae6f Roll Skia from 1e43dce386c9 to f6e31bf1dcfb (6 revisions) (flutter/engine#33320)

* ed5a2fef0 Roll Skia from f6e31bf1dcfb to 69fecd6c2d85 (1 revision) (flutter/engine#33322)

* 10e0e1534 Revert "[web] Migrate Flutter Web DOM usage to JS static interop - 12. (#33241)" (flutter/engine#33321)

* fix local tests

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2022-05-13 14:30:19 -07:00
Jason Simmons
275fb0286c
Fix avoid_redundant_argument_values analyzer warnings enabled in the latest Dart SDK (#103734)
See https://github.com/flutter/flutter/pull/103719
2022-05-13 12:57:59 -07:00
Alex Li
aa39fa5a88
[gen_l10n] Better blank lines in the header of generated files (#103414) 2022-05-12 16:04:18 -07:00
David Iglesias
1af8cc1183
[tools][web] Make Plugin Registrant file ephemeral. (#102185) 2022-05-11 17:54:11 -07:00
Gary Qian
e997a3abd2
Add tests for migrate command methods (#103466) 2022-05-11 11:09:08 -07:00
Anna Gringauze
29fecb5980
Provide flutter sdk kernel files to dwds launcher instead of dart ones (#103436)
* Provide flutter sdk kernel files to dwds launcher instead of dart ones

* Update log test to report all warnings

* Update licences for new files

* Addressed CR comments

* Addressed CR comments
2022-05-11 08:52:43 -07:00
Christopher Fujino
e8c01a8aa8
[flutter_tools] pub roll (#103220)
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2022-05-10 10:26:54 -07:00
Aman Verma
f86dfdd2b7
[flutter_tools] boolArg refactor (#102088) 2022-05-09 21:54:08 -07:00
Gary Qian
90a8b0561d
[flutter_tools] MigrateUtils and MigrateManifest classes (#101937) 2022-05-09 15:23:50 -07:00
Jesús S Guerrero
596e9d1c47
[flutter_tools] stringArg refactor (#103231) 2022-05-09 09:54:12 -07:00
Christopher Fujino
09686a04c9
[flutter_tools] add --uninstall-first flag and pipe it through to ios-deploy (#102948) 2022-05-07 11:49:07 -07:00
Jenn Magder
c6ced845e3
Remove custom unawaited, prefer dart:async version (#103212) 2022-05-07 08:49:04 -07:00
Alexandre Ardhuin
d40ee2149c
remove unnecessary .toString() (#103226) 2022-05-06 16:04:13 -07:00
Jenn Magder
35513c265c
Remove unused flutterMacOSPodspec artifact (#103088) 2022-05-04 16:59:07 -07:00
Jenn Magder
2e1c146eec
Update ffi gem installation instructions (#103008) 2022-05-04 13:24:08 -07:00
Zachary Anderson
577919dbfe
Don't hardcode ink sparkle spir-v (#102674) 2022-05-04 09:28:45 -07:00
Christopher Fujino
9d59532a7b
[flutter_tools] update feature defaults (#102937) 2022-05-02 15:14:09 -07:00
Jenn Magder
36be63ba19
Embed Flutter and App frameworks for add-to-app on iOS (#102538) 2022-05-02 10:44:12 -07:00
Jesús S Guerrero
780a6c422b
[flutter_tool] New command project (#102118) 2022-04-29 23:09:06 -07:00
Tim Sneath
e4bd552e59
Update features.dart (#102766) 2022-04-28 16:34:08 -07:00
Phil Quitslund
6a443138cd
fix unnecessary_null_checks (#102705) 2022-04-28 10:39:06 -07:00
Phil Quitslund
b5e7fb076c
[flutter_tools] rename local functions with _s (#102688) 2022-04-27 16:19:07 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
Zachary Anderson
4a2ed00231
[flutter_tools] Add entries to HostArtifacts for impellerc, libtessellator (#102593) 2022-04-26 13:30:45 -07:00
Jonah Williams
944fcda67f
[flutter_tools] remove UWP tooling (#102174) 2022-04-26 11:19:07 -07:00
Emmanuel Garcia
46cb9ede2f
Reduce Gradle log level in verbose output (#102422) 2022-04-25 10:30:40 -07:00
Alex Li
dca58a289b
[gen_l10n] Throw a specified exception when the language code is invalid (#102431) 2022-04-24 11:04:06 -07:00
Christopher Fujino
5a3e10047f
[flutter_tools] Add test that "Unresolve URI" warnings from DWDS are filtered from logs (#102399) 2022-04-22 15:29:07 -07:00
Elliott Brooks (she/her)
5414ef4c86
Hide unresolved DartUri log messages (#102338) 2022-04-22 12:43:39 -07:00
Kaushik Iska
512cbdb9da
Enable jank metric collection in profile mode (#102334) 2022-04-21 15:54:13 -07:00
Jenn Magder
c9825d24dd
Handle CocoaPods ffi stderr (#102327) 2022-04-21 15:49:08 -07:00
Elsabe Ros
606e91ad63
Use the maven-publish plugin to publish AAR files. (#101891) 2022-04-19 16:34:07 -07:00
Chris Yang
a8da7ced35
Hide default bundle id error when xcresult detects an error (#101993) 2022-04-15 11:44:08 -07:00
Jenn Magder
1756ccc541
Set template and migrate apps to iOS 11 minimum (#101963) 2022-04-15 11:34:08 -07:00
Jason Simmons
d05d43431e
Provide a flag for controlling the dart2js optimization level when building for web targets (#101945) 2022-04-15 00:19:06 -07:00
Anurag Roy
ae805de468
[flutter_tools] Remove usage of globals.flutterGit from version (#100744) 2022-04-14 14:44:09 -07:00
Jenn Magder
fe11f57c61
Detect ARM ffi CocoaPods bus error (#101796) 2022-04-14 14:34:10 -07:00
DetachHead
ba89942fb4
ignore prefer_final_parameters in generated_plugin_registrant template (#101253) 2022-04-14 14:19:09 -07:00
Kaushik Iska
aeaeded715
Add VMService command to get frame rasterization metrics (#100696) 2022-04-14 13:44:05 -07:00
Michael Goderbauer
d5cbb36c91
Migrate remaining files to super parameters (#101919) 2022-04-14 12:04:07 -07:00
Lau Ching Jun
c2dc92ca88
Default to the newer version path when checking Android Studio Java path (#101862) 2022-04-13 22:49:06 -07:00
Yegor
52d17b6672
[web] remove timeout when waiting for browser to launch (#101843) 2022-04-13 13:38:51 -07:00
Zachary Anderson
6190c5df09
Revert "Use the maven-publish plugin to publish AAR files. (#101276)" (#101827)
This reverts commit 2b0255f0d9.
2022-04-13 08:12:07 -07:00
Elsabe Ros
2b0255f0d9
Use the maven-publish plugin to publish AAR files. (#101276) 2022-04-12 22:19:08 -07:00
Jenn Magder
6ccd993976
Add flutter build ipa --no-codesign flag (#101766) 2022-04-12 14:49:09 -07:00
Jenn Magder
d4bfb01336
Do not build for iOS armv7 (#97341) 2022-04-12 14:44:09 -07:00
Jenn Magder
888208c1f4
Disallow flutter run-ing on 32-bit development devices (#97339) 2022-04-12 14:39:07 -07:00
Christopher Fujino
d07ce92b15
[flutter_tools] Re-land Dump backtrace on ios app startup timeout (#101763) 2022-04-12 13:24:04 -07:00
Christopher Fujino
2a6582997d
Revert "[flutter_tools] Dump backtrace on ios app startup timeout (#101610)" (#101761)
This reverts commit 2978b59be7.
2022-04-12 09:09:32 -07:00
Christopher Fujino
2978b59be7
[flutter_tools] Dump backtrace on ios app startup timeout (#101610) 2022-04-12 08:49:08 -07:00
Emmanuel Garcia
9e0f0fe9d7
Add Gradle stacktrace and debug log level to verbose builds (#101734) 2022-04-11 20:14:08 -07:00
David Iglesias
bee95b6984
[flutter.js] Wait for reg.update, then activate sw (if not active yet). (#101464) 2022-04-11 19:04:08 -07:00
Yang Chao
343713727a
Enable track widget creation when generating Generated.xcconfig (#101123) 2022-04-11 14:29:11 -07:00
Danny Tuppeny
675b961573
Unpause and remove breakpoints when detaching from Flutter process with DAP (#101695) 2022-04-11 21:15:37 +01:00
Danny Tuppeny
b086473769
Pass multidex flag when using --machine mode (#101689) 2022-04-11 12:19:09 -07:00
Jesús S Guerrero
2302daa3aa
Create when offline style (#101589) 2022-04-11 12:14:05 -07:00
Janko Djuric
78ae72b0b2
[flutter_tools] Add --build-number and --build-name support to web and linux (#100377) 2022-04-10 11:42:39 -07:00
Chris Yang
1755819cb1
Log XCResult before other build issues (#100787) 2022-04-08 16:27:08 -07:00
Jenn Magder
71d52f27fb
Test Flutter.xcframework directory ios-arm64_armv7 or ios-arm64 (#101592) 2022-04-08 16:12:09 -07:00
Michael Goderbauer
a01424773e
Enable unnecessary_import (#101600) 2022-04-08 12:56:45 -07:00
Michael Goderbauer
cae740b903
Enable strict-casts (as replacement for implicit-casts) (#101567) 2022-04-08 11:15:34 -07:00
Anna Gringauze
74944d528f
Run update-packages (#101450)
* Run update-packages

* Update DwdsLauncher, disable failing test

* Fix analyze error

Co-authored-by: Jenn Magder <magder@google.com>
2022-04-07 17:07:05 -07:00
Jesús S Guerrero
3394fb4a58
[flutter_tools] fix flutter create --offline (#100941)
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
2022-04-07 17:05:49 -07:00
Emmanuel Garcia
b528310f58
Specify Kotlin version in modules and refactor (#101315) 2022-04-07 13:20:33 -07:00
Jenn Magder
d745eec051
Add --use-application-binary to "flutter install" (#101324) 2022-04-06 13:17:26 -07:00
Michael Goderbauer
296221a90d
Partial revert of super params in tools (#101436) 2022-04-06 11:04:38 -07:00
creativecreatorormaybenot
96add4192e
Use single quotes for dartSdkVersionBounds (#101270)
* Use single quotes for `dartSdkVersionBounds`

* Update update_packages_test.dart

* Update test_project.dart

* Update tests_project.dart

* Update compile_error_project.dart

* Update hot_reload_with_asset.dart

* Update break_on_framework_exceptions_test.dart

* Update basic_project.dart
2022-04-06 09:54:10 -07:00
Lau Ching Jun
7f64e2ae02
Catch errors in ProxiedDevice to make sure we don't crash on errors. (#101332) 2022-04-06 09:51:10 -07:00
gaaclarke
35b18ba2e9
Made flag for debugging build time of user created widgets (#100926)
* Added a bool that allows us to limit debugProfileBuildsEnabled to user
created widgets.

* made it turned on by default

* switched to hashmap

* Cleaned everything up and added tests

* fixed an odd test where it wants to be able to add asserts and run in profile mode

* hixie feedback

* hixie2

* made it default to false

* updated docstring as per dans request
2022-04-05 10:54:21 -07:00
Jenn Magder
839a183ea6
Add note to doctor validator if script is running Rosetta (#101309) 2022-04-05 10:37:35 -07:00
Michael Goderbauer
dcde8163ce
migrate to super params (#100509) 2022-03-31 11:46:47 -07:00
Gary Qian
ead5b1c2f4
Retire v1 embedding compatibility from automatic multidex support (#100685) 2022-03-31 10:24:42 -07:00
Chris Bracken
1a072f9aee
[winuwp] Add removal warning in config help text (#101086) 2022-03-31 09:30:04 -07:00
David Iglesias
e52b777a2c
[web] flutter.js initialization with ui.webOnlyWarmupEngine (#100177) 2022-03-30 23:00:09 -07:00
Emmanuel Garcia
5c6918933e
Migrate AGP and Gradle versions to 7.1.2/7.4 (#99723) 2022-03-30 20:30:09 -07:00
Ben Konyi
75baed585e
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#100995) 2022-03-30 13:50:13 -07:00
Sigurd Meldgaard
66ed64be4f
Migrate .packages -> package_config.json (#99677) 2022-03-30 13:56:03 +02:00
Christopher Fujino
b4325b68a2
[flutter_tool] Have long-running validators fail (#100936) 2022-03-28 21:57:44 -07:00
Jenn Magder
a452c92d5d
Set ARCHS to single-arch for local engine macOS builds (#100917) 2022-03-28 18:45:06 -07:00
gaaclarke
912873baa7
Relands "Starts using the --source flag to compile the dart registrant. (#98046)" (#100572) 2022-03-28 18:15:10 -07:00
Chris Bracken
bd6beb4ed7
[Linux] Update doctor wording for Linux (#99700)
Removes the beta-quality wording for Linux from messages in the tool.

Issue: https://github.com/flutter/flutter/issues/99697
2022-03-28 15:45:27 -07:00
Chris Bracken
b6bf325d0a
[macOS] Update doctor wording for macOS (#99699)
Removes the beta-quality wording for macOS from messages in the tool.

Issue: https://github.com/flutter/flutter/issues/98680
2022-03-28 15:44:28 -07:00
Christopher Fujino
9c138f9c76
[flutter_tools] warn when doctor takes long (#100805)
* warn when doctor takes long
2022-03-28 14:13:28 -07:00
Zachary Anderson
47f08a3fd6
[flutter_tool] Adds --enable-impeller flag to the run command (#100835) 2022-03-26 20:07:24 -07:00
Chris Yang
c01cbd23cc
Add CADisableMinimumFrameDurationOnPhone migration (#100647) 2022-03-25 17:50:09 -07:00
Anurag Roy
e7ab846d14
[flutter_tools] Fix VersionUpstreamValidator to respect FLUTTER_GIT_URL (#100605) 2022-03-25 17:35:10 -07:00
Jenn Magder
12da4a2aff
Filter out some stray Xcode logging during macOS builds (#100707) 2022-03-25 16:35:11 -07:00
Danny Tuppeny
801ad5cd5a
Don't terminate Dart process pids from VM Service, record flutter_tools VM pid (#100223)
* Don't terminate Dart process pids from VM Service

These processes may be on another device, and in the case of attach the debugee should not be terminated anyway.
2022-03-23 16:31:31 +00:00
Danny Tuppeny
ea8aeb7427
[dap] Remove some code that's not longer required (#98928) 2022-03-22 14:20:12 -07:00
Anurag Roy
74f08c7352
[flutter_tools] Skip version freshness check for non-standard remotes (#97202) 2022-03-22 12:50:21 -07:00
Michael Goderbauer
8560d914eb
Upgrade to flutter_lints 2.0 (#99881) 2022-03-22 11:00:23 -07:00
Chris Bracken
fd3c34c9d4
[macOS] Use arm64 snapshot in arm64 App.framework (#100504)
Previously, https://github.com/flutter/flutter/pull/100271 enabled
building universal macOS binaries by default, but included a bug causing
the arm64 App.framework to be built such that the TEXT section
containing the app instructions built by gen_snapshot incorrectly
contained x86_64 instructions rather than arm64 instructions.

When building macOS (and iOS) apps, Flutter builds them in three
components:
* The Runner application: built by Xcode
* The bundled App.framework: built from assembly code generated by
  gen_snapshot from the application's Dart sources.
* The bundled FlutterMacOS.framework: built as part of the engine build
  and packaged by copying the distributed binary framework from our
  artifacts cache.

Building App.framework consists of the following steps:
* For each architecture, invoke gen_snapshot to generate
  architecture-specific assembly code, which is then built to object
  code and linked into an architecture-specific App.framework.
* Use the `lipo` tool to generate a universal binary that includes both
  x86_64 and arm64 architectures.

Previously, we were building architecture specific App.framework
binaries. However, for all architectures we were (mistakenly) invoking
the general `gen_snapshot` tool (which emitted x64 instructions, and
which is now deprecated) instead of the architecture-specific
`gen_snapshot_x86` and `gen_snapshot_arm64` builds which emit
instructions for the correct architecture.

This change introduces a small refactoring, which is to split the
`getNameForDarwinArch` function into two functions:
* `getDartNameForDarwinArch`: the name for the specified architecture as
  used in the Dart SDK, for example as the suffix of `gen_snapshot`.
* `getNameForDarwinArch`: the name for the specified architecture
  as used in Apple tools, for example as an argument to `lipo`. For
  consistency, and to match developer expectations on Darwin platforms,
  this is also the name used in Flutter's build outputs.

Issue: https://github.com/flutter/flutter/issues/100348
2022-03-21 20:36:57 -07:00
Jesús S Guerrero
50f3e47b67
Revert "[flutter_tools] remove pub dependencies from universal #97722" (#100508) 2022-03-21 19:20:10 -07:00
gaaclarke
97258979df
Revert "Starts using the --source flag to compile the dart registrant. (#98046) (#100493) 2022-03-21 13:40:23 -07:00
Dan Field
ff74557c3a
Specify destination when building for macOS (#100315)
Fixes #86590
2022-03-17 16:39:05 -07:00
Jesús S Guerrero
03b4f2bf50
[flutter_tools] process exception during linux_doctor is handled (#100159) 2022-03-17 16:15:22 -07:00
Danny Tuppeny
b39a9473f8
Handle Flutter.Error events and disable structure errors for noDebug mode (#100149) 2022-03-17 16:05:21 -07:00
Christopher Fujino
e99a66a47e
[flutter_tools] check if stream is open before sending message in ios device (#99947) 2022-03-17 15:55:24 -07:00
Liam Appelbe
1d2f9c975b
Reintroduce the ability to override the coverage formatter (#100320) 2022-03-17 13:38:36 -07:00
Christopher Fujino
0d83e80104
[flutter_tools] Null safe update packages (#99357) 2022-03-17 13:35:17 -07:00
Chris Bracken
a618ca27a7
[macOS] Enable universal binary builds by default (#100271)
This changes the default build architectures for Flutter macOS apps to
x86_64 and arm64. Previously, we manually excluded arm64 builds via the
EXCLUDE_ARCHS Xcode setting in Flutter's generated xcconfig file. This
eliminates setting EXCLUDE_ARCHS during the build and updates the
default architectures in the tool and in the macos_assemble.sh wrapper.

Issue: https://github.com/flutter/flutter/issues/97681
Umbrella issue: https://github.com/flutter/flutter/issues/60113
2022-03-17 12:28:39 -07:00
Gary Qian
63ff7a199b
MigrateConfig and migrate integration testing base (#99092) 2022-03-16 11:10:22 -07:00
iroiroys
6f6b5647f5
Add more specific cause on web development tool error output (#98553) 2022-03-15 18:15:07 -07:00
Lau Ching Jun
722cbc52b8
Add portForwarder for ProxiedDevice. (#100111) 2022-03-15 14:30:21 -07:00
nicolasvac
201a64c98f
Fix flutter web app not respecting assets path when in non-root folder (#96774) 2022-03-10 15:50:16 -08:00
Jeff Ward
0aab22807c
First pass at using platform abstraction for plugins (#92672) 2022-03-09 14:10:21 -08:00
Lau Ching Jun
dbed10bb59
Pass 'assume-initialize-from-dill-up-to-date' flag to the frontend server (#99791) 2022-03-09 00:30:17 -08:00
Jenn Magder
dd97133df2
Remove tool crash git.io link shortener (#99574) 2022-03-08 17:00:06 -08:00
Tacca
c8538873c8
95533 min sdk error msgs enhancements (#99550) 2022-03-08 16:20:21 -08:00
Felix
cd9e30bb5d
[flutter_tools] Fix Typo in tool error message (#97793)
Fixes a typo mutidex to multidex in a console hint to the user.
2022-03-08 15:24:51 -08:00
Jesús S Guerrero
fbbf3ec471
Support route on ios (#99078) 2022-03-07 11:31:21 -08:00
Anurag Roy
b02150781f
[flutter_tools] Add timeout duration to error and handle exceptions for HttpHostValidator. (#98290) 2022-03-07 11:21:06 -08:00
Jenn Magder
7596a3daf6
Add logging when first frame is not rendering (#99566) 2022-03-04 17:16:21 -08:00
Jonah Williams
59859df126
Add Windows performance benchmark (#99564) 2022-03-04 15:41:14 -08:00
Viren Khatri
671aa9e95e
complete migration of flutter repo to Object.hash* (#99505) 2022-03-04 12:56:21 -08:00
Mathieu Dubois-Briand
020bf31c99
Fix custom-device default forwardPortSuccessRegex (#97719) 2022-03-04 11:06:22 -08:00
Jenn Magder
8f360c977a
Update minimum required version to Xcode 13 (#97746) 2022-03-01 16:26:11 -08:00
gaaclarke
fdcd14464c
Starts using the --source flag to compile the dart registrant. (#98046)
* Starts using the `--source` flag to compile the dart registrant.

* updated general.shard tests

* Fixed the resident compiler flow

* added integration test

* made the integration test self contained

* renamed generated_main to dart_plugin_registrant

* cleaned up for review

* added task runner for ci

* added bringup and TESTOWNERS

* updated failure message
2022-03-01 16:24:47 -08:00
Emmanuel Garcia
9cb60c9828
Revert "reads min/target sdk versions from localproperties" (#99191) 2022-02-28 11:41:22 -08:00
Jenn Magder
c80ff45afe
Print events and views when first frame is taking awhile during tracing (#98957) 2022-02-28 11:16:12 -08:00
stuartmorgan
80660b2d5e
Work around VS CMake generation bug (#98945) 2022-02-26 11:56:22 -08:00
Jonah Williams
0a9a43b99a
Use flutter pub instead of dart pub (#99159) 2022-02-25 11:31:23 -08:00
Jenn Magder
9369bd3222
Wait for ios-deploy stdout before closing logLine stream (#99041) 2022-02-24 19:21:23 -08:00
Danny Tuppeny
76758ef960
[dap] Don't use --start-paused when running in Profile/Release mode (#98926) 2022-02-24 17:06:24 -08:00
Tacca
37a1aaf8c1
reads min/target sdk versions from localproperties (#98450) 2022-02-24 12:16:15 -08:00
Jenn Magder
320d2cff64
Increase recommended CocoaPods version to 1.11 (#98621) 2022-02-24 12:11:21 -08:00
Lau Ching Jun
6a9ac4509b
Add option in ProxiedDevice to only transfer the delta when deploying. (#97462) 2022-02-23 12:09:16 -08:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint (#98753) 2022-02-22 14:39:20 -08:00
Zachary Anderson
54a9d65282
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)"" (#98803) 2022-02-19 10:09:26 -08:00
Christopher Fujino
4b2e828924
[flutter_tools] deprecate the dev branch from the feature system (#98689) 2022-02-18 16:24:22 -08:00
Emmanuel Garcia
c8266d34f4
Improve Gradle retry logic (#96554) 2022-02-18 13:54:41 -08:00
Ben Konyi
4add01ab68
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#98769)
This reverts commit ac3c44355a.
2022-02-18 13:28:42 -08:00
Ben Konyi
50c4720913
Update dependencies to pull in new vm_service, dds, dwds, coverage, etc (#98513) 2022-02-18 12:32:08 -08:00
Tim Sneath
5c7ca2e738
Remove "beta-quality" for Windows (#98614) 2022-02-17 16:44:23 -08:00
Jenn Magder
cef6823637
Dump backtrace when cannot attach to observatory (#98550) 2022-02-16 14:10:18 -08:00
Christopher Fujino
4a11cc4b9c
[flutter_tools] do not validate maven upstream if cloud storage override provided (#98293) 2022-02-15 11:40:15 -08:00
Ben Konyi
2a2f973120
Update flutter_tools to look for new VM service message (#97683)
* Update flutter_tools to look for new VM service message

The Dart SDK will soon move away from the current Observatory message:

"Observatory listening on ..."

To a new message that no longer references Observatory:

"Dart VM Service listening on ..."

This change updates all tests with mocks to check for the new message
and also adds support for the new message in ProtocolDiscovery.

See https://github.com/dart-lang/sdk/issues/46756

* Fix some parsing locations

* Fix analysis failures

* Update message

* Remove extra comment

* Update message

* Add globals prefix
2022-02-15 07:33:57 -08:00
Jesús S Guerrero
f523ddd2d6
[flutter_tools] remove pub dependencies from universal (#97722) 2022-02-12 12:10:11 -08:00
Christopher Fujino
289988dc62
[flutter_tools] fix type error in flutter update-packages --jobs=n (#98283) 2022-02-11 14:50:18 -08:00
Taha Tesser
d6d3283c8d
Fix flutter gen-l10n help message (#98147) 2022-02-11 01:40:14 -08:00
Swift Kim
2a010d9673
[flutter_tools] Make variants of Pub have consistent method signatures (#98119) 2022-02-11 00:45:20 -08:00
bannzai
0ee8e0e6fe
Fix typo FutterApplication -> FlutterApplication (#97897) 2022-02-08 10:25:57 -08:00
Danny Tuppeny
c659ad6ace
Add support for attachRequest in DAP, running "flutter attach" (#97652)
* Add support for attachRequest in DAP, which runs "flutter attach"

* Update DAP docs for attachRequest

* Improve doc comments

* Fix comments

* Remove noDebug from attach + create a getter for `debug`

* Fix indent
2022-02-07 18:54:07 +00:00
Christopher Fujino
1d59d8d341
[flutter_tools] increment y instead of m when calling flutter --version on master (#97827) 2022-02-04 13:35:29 -08:00
Lau Ching Jun
26d1da4188
Fix error in type cast. (#97778) 2022-02-04 12:40:11 -08:00
Michael Tamm
1fcb076eb7
[flutter_tools] Fix bundle file not found when flavor contains upperc… (#92660) 2022-02-04 11:55:20 -08:00
Jenn Magder
ac52901c14
Export an IPA for distribution via "flutter build ipa" without --export-options-plist (#97672) 2022-02-02 19:28:25 -08:00
Jonah Williams
0b72d5ca58
[flutter_tool] allow disabling profile mode timeline traces (#97622) 2022-02-02 16:00:16 -08:00
Jason Simmons
ba4d63a47b
Exit the tool if a DevTools subprocess fails when running on a bot (#97613) 2022-02-02 14:55:18 -08:00
Zachary Anderson
e50ca9acbc
Reland: [flutter_tool] Download gen_snapshot.zip for macOS desktop (#97671) 2022-02-02 14:43:55 -08:00
Lau Ching Jun
a504b93774
Addresses the feedbacks in #95738 (#97457) 2022-02-02 13:55:22 -08:00
Zachary Anderson
f82c020071
Revert "[flutter_tool] Download gen_snapshot.zip for macOS desktop (#97627)" (#97664)
This reverts commit 32abf42a00.
2022-02-02 11:29:28 -08:00
Lau Ching Jun
d7688ca093
Change all instance of throwing strings to throw specific error classes. (#97325) 2022-02-02 10:45:18 -08:00
Zachary Anderson
32abf42a00
[flutter_tool] Download gen_snapshot.zip for macOS desktop (#97627) 2022-02-02 10:21:31 -08:00
Collin Jackson
10fbbafe09
[flutter_tools] Use proper project name in templates (#96373) 2022-02-02 06:50:14 -08:00
Jenn Magder
802d872d40
Revert "Export an IPA for distribution via "flutter build ipa" without --export-options-plist" (#97616) 2022-02-01 18:26:23 -08:00
Jenn Magder
6ceb418b58
Export an IPA for distribution via "flutter build ipa" without --export-options-plist (#97243) 2022-02-01 16:13:21 -08:00
Jenn Magder
a599c23b2b
Disallow running on unsupported devices (#97338) 2022-02-01 16:13:03 -08:00
Christopher Fujino
da88baffd7
[flutter_tools] remove dummy implementation from abstract class .isEnabled() (#96888) 2022-01-28 16:40:12 -08:00
Daco Harkes
0e2f51dfd0
FFI plugins (#96225) 2022-01-26 23:44:45 +01:00
Lau Ching Jun
1065826686
ProxiedDevice, connection to a remotely connected device via flutter daemon. (#95738)
Also allow daemon commands to pass binary streams
2022-01-25 23:46:14 -08:00
Christopher Fujino
610b41e88c
[flutter_tools] add validation of paths of contained files to os_utils _unpackArchive() (#96565) 2022-01-25 18:10:12 -08:00
Jenn Magder
c1710723f7
Take drive screenshot on test failure before app is stopped (#96973) 2022-01-25 11:50:14 -08:00
Christopher Fujino
6b95add2fe
[flutter_tools] auto-migrate dev users to beta (#97028) 2022-01-25 11:00:14 -08:00
stuartmorgan
2dd8cb1ca2
Don't use example folder as a project type signal (#97157)
The code to generate platform files used to use the presence of an
'example' folder to determine whether or not a project was a plugin (in
which case that generation is bypassed). Later, robust detection was
added based on the pubspec.yaml `plugin` key, but the old check was left
in place. This creates false positives where people who add an example
folder to their app project start getting mysterious failures.

Since the pubspec check is definitive, there's no reason to continue to
use the presence of `example` as an indicator at all.

Fixes https://github.com/flutter/flutter/issues/87007
2022-01-24 19:28:38 -08:00
Jesús S Guerrero
75127a8007
[flutter_tools] support files in flutter analyze #96231 (#97021) 2022-01-24 17:10:16 -08:00
Zachary Anderson
62e745612a
Use frontend_server from the Dart SDK (#97078) 2022-01-24 11:34:57 -08:00
Zachary Anderson
761b109bc8
Adjust lipo thinning input/output for macOS (#97111) 2022-01-24 10:21:22 -08:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers (#96422) 2022-01-21 14:43:59 -08:00
Swift Kim
91e3a5772f
Remove unused code from android_device.dart (#95450) 2022-01-20 14:55:18 -08:00
Jenn Magder
ef8a841035
Take screenshot when drive fails to start app or test (#96828) 2022-01-19 21:35:19 -08:00
Jenn Magder
114185f686
Pass 'build ios' device ID into xcodebuild (#96669) 2022-01-19 10:20:11 -08:00
stuartmorgan
25b2edbda0
Enable inline Dart plugin implementation on Desktop (#96610) 2022-01-19 09:35:23 -08:00
Jenn Magder
3c0f3f4ee1
Add boxes around version freshness alerts (#96152) 2022-01-18 17:28:32 -08:00
wangying
3138cce7b2
feat: support configure a custom launch url for flutter web (#95002) 2022-01-18 09:50:20 -08:00
Jenn Magder
219dd6ca38
Migrate assemble and integration_test_device to null safety (#96630) 2022-01-14 15:50:12 -08:00
Jonah Williams
e25e1f9037
[framework] dont null assert in _debugVerifyIllFatedPopulation (#96551) 2022-01-14 13:50:29 -08:00
Spt
7de1e225de
fix rsync output utf8decode bug (#95881) 2022-01-13 10:20:20 -08:00
stuartmorgan
2df7dca858
Fully support Dart-only mobile and macOS plugins (#96183) 2022-01-13 08:30:22 -08:00
Emmanuel Garcia
f01556ab75
Bump Android dependencies that rely on Jcenter (#96558)
* Bump video_player in flutter gallery

* Update packages

* Update dependencies

* Bump device_info

* Update dev/devicelab/bin/tasks/build_ios_framework_module_test.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Update dev/devicelab/bin/tasks/module_custom_host_app_name_test.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Update dev/devicelab/bin/tasks/module_test.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Remove deprecated device_info from ios-frameworks test

Co-authored-by: Jenn Magder <magder@google.com>
2022-01-12 20:13:32 -08:00
Chris Bracken
20ff180ae8
Update Flutter desktop doc URL in error message (#96559)
When desktop support is not present in an existing project, certain
flutter tool commands raise an error that direct the user to
documentation on how to add desktop support to an existing Flutter
project. In a recent revamp of the webside, the URL was very slightly
changed (flutter.dev -> docs.flutter.dev).

This updates the error message to output the new URL.

Issue: https://github.com/flutter/flutter/issues/94398
2022-01-12 18:21:05 -08:00
Emmanuel Garcia
683590d1c6
Add suggestion for compileSdkVersion warning (#95369) 2022-01-10 20:30:13 -08:00
Zachary Anderson
fb29403c42
Revert "feat(flutter_tools): Added doctor path printing on verbose" (#96414) 2022-01-10 15:35:13 -08:00
Jenn Magder
1c0eade94c
Hide PII from doctor validators for GitHub template (#96250) 2022-01-10 13:20:21 -08:00
Greg Spencer
23e7449a07
Warm cache with all transitive dependencies in flutter update-packages command (#96258) 2022-01-10 10:35:13 -08:00
Jenn Magder
db5c71f448
Fix analyze --watch command iterator (#96264) 2022-01-07 17:15:08 -08:00
crisboarna
0fef7a140a
feat(flutter_tools): Changed NoIdeValidator validation type from error to warning (#95492) 2022-01-06 14:05:19 -08:00
crisboarna
f8e70a8463
feat(flutter_tools): Added doctor path printing on verbose (#95453) 2022-01-06 13:50:19 -08:00
Jenn Magder
410d9921bc
Migrate emulators, packages, upgrade, and downgrade to null safety (#95712) 2022-01-05 16:50:19 -08:00
Jenn Magder
18c59cdb1c
Migrate build commands to null safety (#95649) 2022-01-05 16:45:12 -08:00
Jenn Magder
0287449c14
Do not show v1 Android embedding message for non-Android commands (#96148) 2022-01-05 12:55:10 -08:00
Lau Ching Jun
7f0050f5b3
Add a new PrebuiltFlutterApplicationPackage interface. (#95290)
* Add a new PrebuiltFlutterApplicationPackage interface.

* Review feedback

* Rename bundleDir to uncompressedBundle
2022-01-05 07:54:57 -08:00
Zachary Anderson
65c6e88223
Revert "FFI plugins (#94101)" (#96122)
This reverts commit 5257f0290c.
2022-01-04 08:09:12 -08:00
Daco Harkes
5257f0290c
FFI plugins (#94101)
* Building shared C source code as part of the native build for platforms Android, iOS, Linux desktop, MacOS desktop, and Windows desktop.
* Sample code doing a synchronous FFI call.
* Sample code doing a long running synchronous FFI call on a helper isolate.
* Use of `package:ffigen` to generate the bindings.
2022-01-04 10:14:27 +01:00
Christopher Fujino
2d2cd1f5c0
[flutter_tools] Refactor checkVersionFreshness (#95056) 2021-12-28 17:59:16 -08:00
Jenn Magder
d561fe7289
Migrate flutter_device_manager to null safety (#95657) 2021-12-23 12:39:18 -08:00
Jenn Magder
5432688561
Migrate install command to null safety (#95433) 2021-12-22 14:54:10 -08:00
Jenn Magder
a5137399dd
Migrate analyze commands to null safety (#95442) 2021-12-22 12:14:19 -08:00
Lau Ching Jun
df384c4809
Reland "Add an option for flutter daemon to listen on a TCP port (#95418)" (#95689)
Fixes the test brekage and reverts commit caed03df05.
2021-12-22 10:53:31 -08:00
Zachary Anderson
caed03df05
Revert "Add an option for flutter daemon to listen on a TCP port (#95418)" (#95686)
This reverts commit 2b46ea447f.
2021-12-22 08:47:58 -08:00
Lau Ching Jun
2b46ea447f
Add an option for flutter daemon to listen on a TCP port (#95418)
* Add an option for flutter daemon to listen on a TCP port

Added a new class DaemonConnection to reuse the connection handling
between daemon server and client, and handle connection with different
medium (stdio, socket).

Added a new option `listen-on-tcp-port` to the flutter daemon command,
when passed, the daemon will accept commands on a port instead of stdio.

* Review feedback and add test for TcpDaemonStreams

* Review feedbacks
2021-12-22 06:21:04 -08:00
Jenn Magder
c584a5ead4
Migrate fuchsia_device to null safety (#95438) 2021-12-21 18:39:04 -08:00
Chris Yang
1c4128c703
Xcode error message (#94747) 2021-12-21 08:39:18 -08:00
Sam Rawlins
412e329af2
Correct missing return statements in nullably-typed functions (#95428) 2021-12-16 15:29:17 -08:00
Emmanuel Garcia
1bfb7400c8
Bump Kotlin version to the latest (#95383) 2021-12-16 09:19:13 -08:00
crisboarna
eb1a851f58
feat(flutter_tools): Added doctor host validation feat (#95386) 2021-12-16 08:02:13 -08:00
crisboarna
1fb9b5b3d2
feat(flutter_tools): Added proxy validator IPV6 loopback check (#95159)
* feat(flutter_tools): Added proxy validator IPV6 lookback check

* Remove whitespace.

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2021-12-16 07:56:45 -08:00
Danny Tuppeny
7e1e98c356
Add support for executing custom tools in place of Flutter for DAP (#94475) 2021-12-15 13:29:05 -08:00
Emmanuel Garcia
79bc1bfa89
Add ability to wrap text messages in a box (#94391) 2021-12-15 13:19:11 -08:00
Emmanuel Garcia
935d1478aa
Apply the Kotlin plugin in a java project (#95225) 2021-12-14 23:04:05 -08:00
Chris Yang
e4dadf788b
[tool] xcresult issue discarder (#95273) 2021-12-14 13:29:13 -08:00
Lau Ching Jun
8186fb7435
Use XML format in PlistParser (#94863)
* Switch to use xml in PlistParser

* Review feedbacks: Change dynamic to Object, remove getValueFromFile
2021-12-13 18:22:29 -08:00
Chris Yang
70fea6d250
[tool] XCResult also parses "url" in xcresult bundle (#95054) 2021-12-13 16:04:04 -08:00
Jia Hao
2f80384a7f
[flutter_tools] Remove --enable-background-compilation (#94012) 2021-12-13 10:24:08 -08:00
Lau Ching Jun
5cb09e779a
Removed unused method packagesFile from ApplicationPackage. (#95033)
The method name is confusing and the implementation in different
subclasses are pointing to different things.
2021-12-13 06:46:04 -08:00
Dan Field
ab0a335973
Ban sync*/async* from user facing code (#95050) 2021-12-12 13:05:03 -08:00
Ian Hickson
cd239599e7
Attempt to mitigate flakiness around devtools (#94879) 2021-12-10 14:54:17 -08:00
Ian Hickson
9c73e91f7f
Add more detail to error messages (#94820) 2021-12-09 11:29:14 -08:00
Sergey Fedotov
2a4e573dcd
Serve assets with correct content-type header value (#94357) 2021-12-08 12:29:07 -08:00
Jenn Magder
f7bd20fc09
Detect additional ARM ffi CocoaPods error (#94385) 2021-12-07 15:29:03 -08:00
Anna Gringauze
d7466d8963
Update dwds and other packages (#94634) 2021-12-07 14:29:07 -08:00
Gary Qian
da4e997ed3
Short circuit v1 deprecation warning on plugin projects (#94769) 2021-12-07 01:53:50 -08:00
Gary Qian
dd6a11b7aa
Add reason logging to v1 embedding warning message (#94636) 2021-12-06 14:21:58 -08:00
Jia Hao
4517d16b53
[flutter_tools] Fix incorrect todo (#94597) 2021-12-03 11:34:10 -08:00
Yegor
48a5cf9225
[tool] verify download URLs; docs for base URLs (#94178) 2021-12-02 10:11:36 -08:00
Hannes Winkler
bccc9eaca7
Fix a stream lifecycle bug in CustomDeviceLogReader (#94310) 2021-12-01 18:34:04 -08:00
Anna Gringauze
ca62470796
De-flake web tool tests (#93948) 2021-11-30 17:39:05 -08:00
Chris Wong
7ef5226799
Migrate to process 4.2.4 (#92630) 2021-11-30 17:14:07 -08:00
Nate Bosch
6d1a840bc5
Roll packages, remove unnecessary overrides (#94172) 2021-11-24 14:43:05 -08:00
Yegor
a2a888ec13
make CIPD url customizable using FLUTTER_STORAGE_BASE_URL (#94137) 2021-11-24 07:53:03 -08:00
Mouad Debbar
30b6b9e7f0
Revert "Update Xcode toolsVersion encoded in generated Main.storyboard (#94084)" (#94164)
This reverts commit 6a3ea7eb83.
2021-11-24 10:12:53 -05:00
Jenn Magder
6a3ea7eb83
Update Xcode toolsVersion encoded in generated Main.storyboard (#94084) 2021-11-23 17:38:02 -08:00
Wizz.Xu
45a34e83b4
Master analyze_base.dart to null-safety (#93954) 2021-11-22 20:17:32 -08:00
Danny Tuppeny
77fca35877
[DAP] Add a custom event to pass flutter.serviceExtensionStateChanged… (#93870) 2021-11-22 20:12:33 -08:00
Tarekk Mohamed Abdalla
fae84f6714
[gen_l10n] Add support for adding placeholders inside select (#92753) 2021-11-22 20:08:03 -08:00
Ian Hickson
bde9f11831
Add a test to verify that we only link to real issue templates (#93528) 2021-11-19 13:13:05 -08:00
Danny Tuppeny
99e85b1c5f
Disable pause-on-exceptions for (outgoing) isolates during hot restart (#93411) 2021-11-18 22:23:09 -08:00
Jenn Magder
b460d0ee34
Migrate emulators to null safety (#92738) 2021-11-18 22:13:06 -08:00
Jenn Magder
e56c83a1ac
Migrate build_system targets to null safety (#92869) 2021-11-17 16:31:37 -08:00
Danny Tuppeny
c6d4625232
Ensure the flutter_gen project is correctly created as part of "flutter create" (#92975) 2021-11-17 12:03:04 -08:00
Hans Muller
09d08510d0
Revert "allow full locale in .arb files (#93401)" (#93806)
This reverts commit 16f441188c.
2021-11-17 11:26:16 -08:00
Taha Tesser
16f441188c
allow full locale in .arb files (#93401) 2021-11-17 09:35:47 -08:00
Konoshenko Vlad
ee87f6113e
fix: removed unnecessary checks (#93735) 2021-11-16 18:43:05 -08:00
Gary Qian
02b1146cff
Reland "Exit on deprecated v1 embedding when trying to run or build" (#92901) (#93566) 2021-11-12 15:52:32 -08:00
Christopher Fujino
e8ec8a0dfb
[flutter_tools] Catch lack of flutter tools source missing (#93168) 2021-11-12 14:43:52 -08:00
Jenn Magder
a25dca4a06
Ad-hoc codesign Flutter.framework when code signing is disabled (#93556) 2021-11-12 12:56:03 -08:00
pan
7ce6d414d4
add --extra-gen-snapshot-options support for build_aar command. (#91590) 2021-11-12 11:11:02 -08:00
Yegor
24b9346c9b
Revert "Reland "Exit on deprecated v1 embedding when trying to run or build (#92901)" (#93386)" (#93518)
This reverts commit eabb7cbc34.

It broke multiple tests.
2021-11-11 16:45:40 -08:00
Gary Qian
eabb7cbc34
Reland "Exit on deprecated v1 embedding when trying to run or build (#92901)" (#93386) 2021-11-11 14:49:35 -08:00
Kenzie (Schmoll) Davisson
7748731903
Add DevTools version to flutter --version and flutter doctor -v output. (#93065)
* Add DevTools version to `flutter --version` output.

* review comments

* fix test

* add explanatory comment

* dummy commit to kick bots

Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
2021-11-11 14:40:22 -08:00
Core
d8034538bd
feat: enable flavor option on test command (#89045) 2021-11-11 09:23:02 -08:00
stuartmorgan
7e05d103e9
Add support for Visual Studio 2022 (#93426) 2021-11-10 16:43:02 -08:00
Greg Spencer
52ae102f18
Adds tool warning log level and command line options to fail on warning/error output (#92031) 2021-11-10 16:13:04 -08:00
Shueh Chou Lu
e8b3fe8aa6
Use num on plural (#93228) 2021-11-10 08:47:25 -08:00
Nate Bosch
4aad63a63d
Ignore upcoming warning for unnecessary override (#93353) 2021-11-10 07:33:05 -08:00
Zachary Anderson
858a328712
Revert "Exit on deprecated v1 embedding when trying to run or build (#92901)" (#93365)
This reverts commit 6153bbef3e.
2021-11-09 22:22:14 -08:00
Gary Qian
6153bbef3e
Exit on deprecated v1 embedding when trying to run or build (#92901) 2021-11-09 17:38:03 -08:00
J-P Nurmi
550281e581
[gen_l10n] retain full output file suffix (#88362) 2021-11-08 13:55:19 -08:00
Jenn Magder
6cbed01db3
Migrate windows_device to null safety (#92956) 2021-11-07 01:27:34 -07:00
Jenn Magder
31933af486
Update minimum required version to Xcode 12.3 (#93094) 2021-11-05 16:08:04 -07:00
Jenn Magder
296eeb5971
Migrate custom_device to null safety (#92955) 2021-11-05 16:03:03 -07:00
Jenn Magder
f4d1bfedd2
Migrate tracing to null safety (#92849) 2021-11-05 15:58:07 -07:00
Jacob MacDonald
a4fa2affe9
Update packages (#92924) 2021-11-05 12:03:03 -07:00
Jenn Magder
261ea1baef
Suppress created file list for new "flutter create" projects (#93041) 2021-11-04 10:03:02 -07:00
Yegor
773789344e
[web:tools] always use CanvasKit from the cache when building web apps (#93002) 2021-11-03 17:48:25 -07:00
Jenn Magder
5be462f550
Migrate doctor, format, and a few other commands to null safety (#92952) 2021-11-03 17:36:32 -07:00
Jenn Magder
cdbd0a92e3
Migrate channel, clean and a few other commands to null safety (#92950) 2021-11-03 17:33:05 -07:00
Jenn Magder
868e417e57
Remove globals_null_migrated.dart, move into globals.dart (#92948) 2021-11-03 12:53:04 -07:00
Jenn Magder
a4e7b5994c
Migrate flutter_command to null safety (#92871) 2021-11-02 14:31:35 -07:00
jensjoha
a6441004aa
[flutter_tools] Instruct compiler before processing bundle (#92255) 2021-11-02 13:46:46 +01:00
Jenn Magder
9e88fe328e
Remove globals_null_migrated.dart, move into globals.dart (#92861) 2021-11-01 17:18:03 -07:00
Jenn Magder
8865212254
Migrate doctor to null safety (#92131) 2021-11-01 12:13:02 -07:00
Chris Yang
04156b6636
[flutter_tools] xcresult parser. (#92604) 2021-10-29 18:29:31 -07:00
Jenn Magder
0c9a420583
Migrate android_device to null safety (#92128) 2021-10-29 17:19:33 -07:00
Jenn Magder
53e04de681
Migrate mdns_discovery and ios simulator to null safety (#92124) 2021-10-29 17:18:03 -07:00
Christopher Fujino
b0810bc939
Fix analysis throwing string (#91435) 2021-10-29 17:02:05 -07:00
嘟囔
41167c957d
feat: migrate macos/macos_device.dart to null safety (#92633) 2021-10-29 16:14:35 -07:00
嘟囔
7f177087c5
feat: migrate ios/bitcode.dart to null safety (#92557) 2021-10-28 10:33:05 -07:00
Danny Tuppeny
57dbf7f7e7
Add support for running tests through debug-adapter (#92587)
* Add support for running tests through debug-adapter

* Improve comments about stdout + remove pedantic
2021-10-28 11:34:05 +01:00
Jenn Magder
aff69e43ef
Add integration_test to flavor test project (#92520) 2021-10-27 12:53:05 -07:00
Jenn Magder
b279ff4178
Run flutter tester with arch -x86_64 on arm64 Mac (#92508) 2021-10-27 10:48:03 -07:00
stuartmorgan
ed61608a9d
Set TargetFile define for resident builds (#92511)
Dart plugin registration generation depends on the target main file
being set as a define so that it's available in the environment, but the
resident runner wasn't setting it. That worked for initial builds
because of the re-entrant call to `assemble` (which does set it), but
caused Hot Restart to always re-generate the wrapper using
lib/main.dart.

This ensures that the define is set in that codepath as well.

Fixes https://github.com/flutter/flutter/issues/91535
2021-10-27 09:25:15 -07:00
Danny Tuppeny
de966d8a49
Add a "flutter debug_adapter" command that runs a DAP server (#91802) 2021-10-27 06:48:06 -07:00
Emmanuel Garcia
4d79bb02c4
Bump Kotlin version in templates and projects (#92052) 2021-10-25 13:13:03 -07:00
Sigurd Meldgaard
67499b50cc
Add new pub command 'Token' (#91014) 2021-10-25 11:35:27 +02:00
嘟囔
c0e0f4f82e
feat: migrate install_manifest.dart to null-safety (#92062) 2021-10-21 21:26:36 -07:00
Yegor
ad7727a21c
[web] enable CanvasKit tests using a local bundle fetched from CIPD (#92134) 2021-10-21 11:13:18 -07:00
Ben Konyi
ac3c44355a
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)" (#92220)" (#92235)
This reverts commit ba0321e95d.
2021-10-20 22:05:49 -07:00
Ben Konyi
ba0321e95d
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#92220)
This reverts commit dc7fea8d19.
2021-10-20 19:20:17 -07:00
Chris Yang
42eb903200
[flutter_tools] iOS: display name defaults to the Title Case of flutter project name. (#91529) 2021-10-20 10:33:02 -07:00
Emmanuel Garcia
2bdbe7238c
Rewire all Dart entrypoints when the Dart plugin registrant is used. (#91856) 2021-10-19 20:23:04 -07:00
Jenn Magder
8ab4de021c
Migrate desktop_device to null safety (#92055) 2021-10-19 12:28:04 -07:00
Jenn Magder
8474f41e90
Migrate xcdevice and ios devices to null safety (#92056) 2021-10-19 12:23:03 -07:00
Gary Qian
0407aa4480
Reland "Add multidex flag and automatic multidex support (#90944)" (#92049) 2021-10-19 02:20:39 -07:00
Christopher Fujino
34ec94a16d
[flutter_tools] migrate web_device.dart to null-safety (#91632) 2021-10-19 01:33:08 -07:00
Jenn Magder
a82c50f1f6
Revert "Migrate xcdevice and ios devices to null safety (#91704)" (#91912)
This reverts commit 0065873670.
2021-10-15 09:48:08 -07:00
Jenn Magder
6c9259ae7c
Revert "Migrate desktop_device to null safety (#91705)" (#91911)
This reverts commit 59a6ba7cf8.
2021-10-15 09:41:03 -07:00
Ian Hickson
2f4e3ce5b0
Improve error message for when you're not running chromedriver (#91789) 2021-10-14 22:38:05 -07:00
Jenn Magder
59a6ba7cf8
Migrate desktop_device to null safety (#91705) 2021-10-14 22:33:02 -07:00
Jenn Magder
0065873670
Migrate xcdevice and ios devices to null safety (#91704) 2021-10-14 22:28:02 -07:00
Ian Hickson
299d484903
Enable more lints (#91642) 2021-10-14 22:03:03 -07:00
Zachary Anderson
a9c31eca48
Revert "Add multidex flag and automatic multidex support (#90944)" (#91791)
This reverts commit 1d9edde079.
2021-10-13 23:09:50 -07:00
Gary Qian
1d9edde079
Add multidex flag and automatic multidex support (#90944) 2021-10-13 17:48:04 -07:00
omerlevran46
4b1b65118e
[fuchsia] - remove device-finder for device discovery (#91502)
device-finder binary is being from removed from the Fuchsia SDK
in fxb/85985.
2021-10-13 16:04:27 -04:00
Ben Konyi
dc7fea8d19
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)" (#90611)" (#91754)
This reverts commit e89a885fab.
2021-10-13 12:45:45 -04:00
Ben Konyi
e89a885fab
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#90611)
This reverts commit 58944e6b88.
2021-10-13 10:13:30 -04:00
Jenn Magder
6987c9fb82
Migrate crash_reporting and github_template (#91516) 2021-10-12 13:48:03 -07:00
Jenn Magder
1dbafdb53b
Migrate protocol_discovery to null safety (#91267) 2021-10-12 12:13:02 -07:00
Jenn Magder
1f25644719
Migrate android build target to null safety (#91455) 2021-10-11 17:55:01 -07:00
Ian Hickson
7b01346c5c
Enable no_default_cases lint (#91530) 2021-10-11 10:23:04 -07:00
Ian Hickson
b3f63d38ac
Document why some lints aren't enabled and fix some minor issues. (#91527) 2021-10-09 04:03:03 -07:00
Zachary Anderson
8b245d081f
[flutter_tools] Fix redundant argument value lint (#91534) 2021-10-08 22:59:29 -07:00
Jenn Magder
8930e9b892
Catch FormatException parsing XCDevice._getAllDevices (#90967) 2021-10-08 13:08:04 -07:00
Jenn Magder
6253f9018c
Move DeviceManager into null migrated globals library (#91457) 2021-10-08 12:37:48 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Zachary Anderson
5188df0821
Revert gradle roll (#91459)
* Revert "Mark last failing test after gradle update as flaky. (#91423)"

This reverts commit 46a52d03bd.

* Revert "fix android template for Gradle 7 (#91411)"

This reverts commit 51d06d537f.

* Revert "Add explicit version for mac and windows openjdk. (#91408)"

This reverts commit bf429f2771.

* Revert "Update the openjdk version used by linux android tests. (#91405)"

This reverts commit 2144ab8b45.

* Revert "Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642)"

This reverts commit b6459f9b63.
2021-10-07 19:42:24 -07:00
Christopher Fujino
f753168cb6
[flutter_tools] add working directory to ProcessException when pub get fails (#91436) 2021-10-07 18:08:04 -07:00
Majid Hajian
6c10f19b80
add package_name for consistency across all platforms (#88457) 2021-10-07 17:08:02 -07:00
Ian Hickson
f25b833f27
Enable avoid_print lint. (#91444) 2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. (#91332)" (#91438)
This reverts commit cb378edc9e.
2021-10-07 16:16:17 -04:00
Jenn Magder
91d1e3ed8b
Default new project to the ios-signing-cert development team (#90021) 2021-10-07 10:23:02 -07:00
Ian Hickson
cb378edc9e
Enable avoid_print lint. (#91332) 2021-10-07 09:53:03 -07:00
Taha Tesser
b6459f9b63
Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642) 2021-10-06 17:01:13 -07:00
Jenn Magder
afbfc1f33a
Migrate assets, common, icon_tree_shaker to null safety (#91309) 2021-10-06 15:16:33 -07:00
Pierre-Louis
3e43c3e110
Categorize flutter tool commands (#87747) 2021-10-05 17:28:04 -07:00
stuartmorgan
64fd68ed42
Don't generate plugin registry in ResidentWebRunner (#91281)
* Don't generate plugin registry in ResidentWebRunner

generateDartPluginRegistry was being set to true unconditionally in
ResidentRunner, bypassing the primary check in
DartPluginRegistrantTarget, and the targetPlatform was not set in that
codepath, bypassing the second after the changes in
https://github.com/flutter/flutter/pull/87991. This caused web hot
restarts to be slower due to doing unnecessary work.

This ensures that generateDartPluginRegistry is false in the
ResidentWebRunner to skip that unnecessary step.

Fixes https://github.com/flutter/flutter/issues/91262

* Formatting

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2021-10-05 12:27:53 -07:00
Ian Hickson
126cd7388e
Clean up dependency pins and update all packages (#91109) 2021-10-04 10:28:03 -07:00
Jenn Magder
61e2e86611
Add iOS build -destination flag (#90915) 2021-10-04 10:18:03 -07:00
Christopher Fujino
91dd3276fd
migrate vm service to null safety (#88320) 2021-10-02 10:18:03 -07:00
stuartmorgan
23cea26715
Add dartPluginClass support for Android and iOS (#87991) 2021-10-01 16:03:04 -07:00
Ian Hickson
989f864497
Enable avoid_setters_without_getters (#91067) 2021-10-01 00:58:05 -07:00
stuartmorgan
97fb8c0560
Fix Dart plugin registrant interaction with 'flutter test' (#90288)
Building an application for a desktop platform that transitively included any Dart-based plugins (such as path_provider) broke `flutter test`, because its compilation was overriding the provided main (in this case, the test main) with `generated_main.dart` if it was present. This PR:
- Changes the `flutter test` compilation path to update `generated_main.dart`, so that the tests will work, and will include any registered Dart plugins.
- Makes using `generated_main.dart` during recompile opt-in, to try to reduce the chance of a similar bug happening with other codepaths in the future.

Fixes https://github.com/flutter/flutter/issues/88794
2021-09-30 20:25:13 -07:00
Christopher Fujino
738a7747cc
[flutter_tools] Handle disk device not found (#90996) 2021-09-30 17:28:57 -07:00
Jenn Magder
c48c428e46
Xcode 13 as minimum recommended version (#90906) 2021-09-30 12:23:55 -07:00
Greg Spencer
01af8e5987
Make flutter update-packages run in parallel (#91006)
This modifies the flutter update-packages and flutter update-packages --force-upgrade commands so that the many invocations of "dart pub get" in each repo project run in parallel instead of in series.
2021-09-30 10:26:31 -07:00
Jenn Magder
faaca13f22
Catch FormatException from bad simulator log output (#90966) 2021-09-30 09:33:04 -07:00
Kenzie (Schmoll) Davisson
5a85c0d81c
Launch DevTools from the 'dart devtools' command instead of pub (#90894) 2021-09-29 15:32:24 -07:00
Greg Spencer
ab2b0851a2
Add smoke tests for all the examples, fix 17 broken examples. (#89021)
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
2021-09-28 09:32:06 -07:00
Jason Simmons
cd19bc6007
Do not retry if pub get is run in offline mode (#90394) 2021-09-27 08:18:06 -07:00
Christopher Fujino
61bce1d83b
[flutter_tools] remove non-null check from AndroidValidator (#90090) 2021-09-25 16:53:06 -07:00
Jenn Magder
1b53f7beba
Migrate iOS project to Xcode 13 compatibility (#90304) 2021-09-22 13:23:05 -07:00
Jason Simmons
58056bbe74
Close the IntegrationTestTestDevice stream when the VM service shuts down (#90022) 2021-09-17 19:18:03 -07:00
Liam Appelbe
9afbab8477
Use report_lines flag in flutter coverage (#90142)
* Use the report lines flag

* Handle major version bumps in the version check

* Fix existing tests and add a new test
2021-09-16 11:33:32 -07:00
Ahmed Ashour
eb185d73ce
internationalization: fix select with incorrect message (#90096) 2021-09-16 09:23:22 -07:00
Jenn Magder
ab6f2fc8ce
Set BUILD_DIR when determining if plugins support arm64 simulators (#90088) 2021-09-15 18:37:04 -07:00
Michael Thomsen
b889915997
Change min Dart SDK constraint to track actual version (#88743) 2021-09-14 14:08:36 +02:00
Phil Quitslund
975fcc1f2f
master->main deafult branch migration (#89782) 2021-09-10 15:42:03 -07:00
Chase Latta
aed4315a7d
Replace amber_ctl with pkgctl for Fuchsia (#89785)
Fuchsia is deprecating amber_ctl and replacing it with pkgctl.
This change removes the FuchsiaAmberCtl class and replaces it
with the FuchsiaPkgctl class and updates the usages appropriately.

BUG: fxbug.dev/83865
2021-09-10 10:33:45 -07:00
Jenn Magder
84086d8a9c
Clean up null assumptions in vmservice for null safe migration (#89009) 2021-09-09 19:32:02 -07:00
Jenn Magder
855af29084
Migrate ios_deploy to null safety (#88851) 2021-09-09 17:32:05 -07:00
Jenn Magder
58944e6b88
Revert "Enable caching of CPU samples collected at application startup (#89600)" (#89704)
This reverts commit 619121b095.
2021-09-08 19:37:34 -07:00
Ben Konyi
619121b095
Enable caching of CPU samples collected at application startup (#89600) 2021-09-08 17:22:04 -07:00
Jenn Magder
34ba64738e
Clean up null assumptions in devfs to prep for null safety migration (#88934) 2021-09-08 15:27:05 -07:00
Anis Alibegić
a753d09cc9
Fixed several typos (#89485) 2021-09-07 14:56:04 -07:00
Chris Bracken
1c36271b05
Reduce required Windows CMake version to 3.14 (#89390)
When we landed the CMake minimum requirement constraint for Visual
Studio 2019, we landed it with minimum version 3.15, since that's what
was shipping with the current version of VS 2019 at the time. Looking at
the release notes of earlier versions, it's clear that earlier versions
of Visual Studio 2019 shipped with version 3.14. See:
https://devblogs.microsoft.com/cppblog/visual-studio-cmake-support-clang-llvm-cmake-3-14-vcpkg-and-performance-improvements/

Looking at release notes for CMake 3.15, there are no features/fixes
introduced in that version that we are dependent on.
https://cmake.org/cmake/help/latest/release/3.15.html

Issue: https://github.com/flutter/flutter/issues/88589
2021-09-03 21:05:58 -07:00
arfy slowy
202fc02ca1
fix: typo spelling grammar (#88439) 2021-09-03 15:09:31 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets (#86821) 2021-08-30 15:41:02 -07:00
Sigurd Meldgaard
bce366203a
Stop calling top level pub (#89032)
* Use `dart __deprecated_pub` instead of `pub` to invoke pub from tools

The top level `pub` commmand has been deprecated and will print
a message. It is however implemented via the __deprecated_pub command
that prints no message.
2021-08-30 10:40:10 -07:00
Jenn Magder
e6535f6da1
Changed tool cached properties to late finals (#88923) 2021-08-26 14:01:05 -07:00
Jenn Magder
0cb6d5983c
Migrate fuchsia sdk and dependencies to null safety (#88920) 2021-08-25 19:51:04 -07:00
Jenn Magder
d550d497f1
Migrate some flutter_tools tests to null safety (#88850) 2021-08-25 16:21:04 -07:00
Jenn Magder
125451bc2e
Migrate mac.dart to null safety (#88846) 2021-08-25 13:31:03 -07:00
Zachary Anderson
b4e0472b04
Revert "Use dart pub instead of pub to invoke pub from tools (#88509)" (#88792)
This reverts commit 7c24ff2c5b.
2021-08-24 09:00:22 -07:00
Sigurd Meldgaard
7c24ff2c5b
Use dart pub instead of pub to invoke pub from tools (#88509)
Top level `pub` is being deprecated.
2021-08-24 15:51:08 +02:00
Jonah Williams
fa0782b696
reassign jonahwilliams todos (#88707) 2021-08-23 12:27:07 -07:00
Taha Tesser
d72287522b
[tools] Fix Android Studio duplicate detection (#88384) 2021-08-18 02:02:03 -07:00
Jenn Magder
2d55032939
Migrate dds.dart to null safety (#88382) 2021-08-17 21:12:03 -07:00
Taha Tesser
42a6b7913c
[tools] Add Xcode version to non-verbose Flutter doctor (#87022) 2021-08-17 15:52:03 -07:00
Zachary Anderson
3572a7e8b7
Revert "feat: migrate base/dds.dart to null-safety (#88015)" (#88367) 2021-08-17 11:52:05 -07:00
Jonah Williams
060e4608b1
clean up stale or unnecessary TODOS (#88308) 2021-08-16 21:37:03 -07:00
Jason Simmons
ddb8bfb72b
Fix URL construction in the test entry point generated by the web bootstrap script (#88201) 2021-08-16 14:12:05 -07:00
Jenn Magder
57efbd5310
Rename IOSDeviceInterface to IOSDeviceConnectionInterface (#88144) 2021-08-16 10:27:03 -07:00
Zachary Anderson
c5d5463c30
[flutter_tools] Fix hang in DesktopLogReader (#88178) 2021-08-13 17:12:04 -07:00
Jenn Magder
325cfb0f4c
Make doctor Xcode version requirement clearer (#88137) 2021-08-13 17:07:03 -07:00
嘟囔
bf3ff7ec71
feat: migrate fuchsia/application_package.dart to null-safe (#88095) 2021-08-13 00:22:07 -07:00
Anurag Roy
758c28b813
[flutter_tools] Reland "Make upgrade only work with standard remotes" (#87731) 2021-08-12 15:52:07 -07:00
Zachary Anderson
f0e832cdea
[flutter_tool] Fix DesktopLogReader to capture all output (#88116) 2021-08-12 14:57:07 -07:00
Ahmed Ashour
5848a1620d
[gen_l10n] to handle arbitrary DateFormat patterns (#86844) 2021-08-12 14:34:52 -07:00
Jenn Magder
9764d861ca
Support flutter create --platform singular flag (#88076) 2021-08-12 11:42:04 -07:00
嘟囔
047d35d8ba
feat: refactor IosProject and MacOSProject to extends XcodeBasedProject to share common (#87930) 2021-08-11 21:47:05 -07:00
嘟囔
a17723d46b
feat: migrate windows/application_package.dart to null-safety (#88081) 2021-08-11 21:02:03 -07:00
嘟囔
d2f9c6c752
feat: migrate base/dds.dart to null-safety (#88015) 2021-08-11 14:47:06 -07:00
嘟囔
4ef8088ce8
feat: migrate macos/application_package.dart to null-safety (#87976) 2021-08-11 14:42:05 -07:00
Greg Spencer
cb651352dd
Fix errors in examples (#87962) 2021-08-11 14:37:06 -07:00
嘟囔
bffa11e2b6
fix: fix BuildableMacOSApp pass no projectBundleId to super error (#87264) 2021-08-06 14:30:07 -07:00
Lau Ching Jun
95217eb72a
Add new hook for setupHotReload and after updating devFS is complete (#87532)
* Add new hook for setupHotReload and after updating devFS is complete

* Handle the case where updateDevFS failed
2021-08-03 21:09:56 -07:00
Anna Gringauze
44d9af80cb
Flutter_tools for web: report error messages with stacks on exit (#87386)
* Flutter_tools for web platform: report error messages with stacks on toolExit

Print error messages and stacks in verbose mode before calling
`throwToolExit` on communication errors to chrome and dwds.

This will help us disagnose CI flakes:

Helps: https://github.com/flutter/flutter/issues/84012
Closes: https://github.com/flutter/flutter/issues/87149

* Added tests

* Extend timeout for testing failure to connect to chrome

* Update rest of chrome tests to await until matching is finished
2021-08-03 10:51:35 -07:00
Ahmed Ashour
92e02457d5
Handle reserved Kotlin keywords (#86518) 2021-08-02 14:35:05 -07:00
Jenn Magder
7424db448d
Exclude arm64 from iOS app archs if unsupported by plugins on x64 Macs (#87362) 2021-07-30 14:44:04 -07:00
Jenn Magder
a69b3ca5d3
Exclude arm64 from iOS app archs if unsupported by plugins (#87244) 2021-07-30 10:54:34 -07:00
Anurag Roy
ade9f6a9f0
[flutter_tools] Improve toolexit error messages for flutter upgrade (#86351) 2021-07-29 22:00:44 -07:00
Taha Tesser
f9aa5842c2
[tools] Fix Android Studio Arctic Fox Java path on macOS (#87267) 2021-07-29 10:24:07 -07:00
Jenn Magder
2f91679058
Show Android SDK path in doctor on partial installation (#87232) 2021-07-28 19:14:02 -07:00
Greg Spencer
0bab3604b0
Make the startup lock message print to stderr. (#86520)
This changes the "Waiting for another flutter command to release the startup lock..." message output so that it appears on stderr instead of stdout. When it appears on stdout, it can mess up collection of the output. For instance, if you run flutter --version --machine and you're expecting JSON output, then you'll get non-JSON output even though the lock is released and you eventually would get what you're asking for.
2021-07-28 15:12:03 -07:00
Jenn Magder
89637e4e47
Replace iOS physical/simulator bools with enum (#87138) 2021-07-27 16:39:04 -07:00
Emmanuel Garcia
e7a9adeeab
Remove AndroidX workarounds (#86911) 2021-07-23 17:41:04 -07:00
Ahmed Ashour
bf132daef3
[gen_l10n] correct variable name when the placeholder requiresFormatting (#86842) 2021-07-22 13:55:18 -07:00
Ahmed Ashour
9492e13c45
Reland [flutter_tools] show only supported sub commands (#86153) 2021-07-22 13:41:03 -07:00
Jenn Magder
81aeb33ce3
Increase Flutter framework minimum iOS version to 9.0 (#86840) 2021-07-22 13:21:05 -07:00
Jonah Williams
7f26dbe0d4
[flutter] remove elevation checker (#86837) 2021-07-21 21:51:06 -07:00
Emmanuel Garcia
0a8c03dc8a
Show warning when an app or plugin uses the V1 Android embedding (#86750) 2021-07-21 12:51:43 -07:00
Ahmed Ashour
f568d929db
[gen_l10n] Support plurals and selects inside string (#86167) 2021-07-21 12:41:06 -07:00
Taha Tesser
94f71f374f
[flutter_tools] Refactor Android Studio Detection on Windows (support 4.x and 202x releases detection) (#86624) 2021-07-20 12:16:03 -07:00
Remi Rousselet
1995da2c0c
Disable the automatic "pub get" if the project is using a third-party tool for linking dependencies. (#86177) 2021-07-19 08:06:03 -07:00
Ahmed Ashour
838ad83705
Explicitly show "Currently not on an official channel." (#84992) 2021-07-15 21:55:39 -07:00
Lau Ching Jun
f25e4fea18
Remove unnecessary variables. (#86444) 2021-07-15 16:56:04 -07:00
Zachary Anderson
09a38d7a17
Revert "Handle reserved Kotlin keywords (#84973)" (#86512)
This reverts commit a67f618a29.
2021-07-15 14:43:53 -07:00
Ahmed Ashour
a67f618a29
Handle reserved Kotlin keywords (#84973) 2021-07-15 14:26:05 -07:00
Jonah Williams
b549e829e8
[flutter_tools] support trailing args (#86431) 2021-07-14 15:51:10 -07:00
Yegor
81c91924f0
[web] use resident resident runner in flutter drive (#86381)
* [web] use resident resident runner in flutter drive
2021-07-14 08:46:38 -07:00
Jonah Williams
63a4013160
Revert "[flutter_tools] let the logger know about machine mode (#86116)" (#86363)
This reverts commit 53d8cba3ec.
2021-07-13 10:39:35 -07:00
Ian Hickson
d3c17acf9d
Run "pub global activate devtools" before overall_experience_test (#85812) 2021-07-12 14:36:05 -07:00
michaellee8
6a51e0c237
[flutter_tools] Add support for launching fuchsia app using session_control (#85752) 2021-07-12 13:26:05 -07:00
Jonah Williams
53d8cba3ec
[flutter_tools] let the logger know about machine mode (#86116) 2021-07-12 10:41:03 -07:00
Jonah Williams
9d70d9d589
[flutter_tools] fix -n workaround (#86142) 2021-07-09 09:41:04 -07:00
Zachary Anderson
c589a0c322
Revert "[flutter_tools] show only supported sub commands (#85125)" (#86131)
This reverts commit 84e576786c.
2021-07-08 15:58:05 -07:00
Zachary Anderson
53125203ea
[flutter_tool] Pin DevTools to 2.4.0 (#86124) 2021-07-08 15:01:00 -07:00
Ahmed Ashour
84e576786c
[flutter_tools] show only supported sub commands (#85125) 2021-07-08 14:56:06 -07:00
Jacob Richman
1a0d873e2e
Switch drive_service from using deprecated version of --record-memory-profile flag. (#86122) 2021-07-08 14:29:41 -07:00
Alexandre Ardhuin
80990c21e2
code formatting (#85783) 2021-07-07 23:06:05 -07:00
Hannes Winkler
a1e9f2057f
[custom-devices] general improvements, add custom-devices subcommand, better error handling (#82043) 2021-07-07 09:16:04 -07:00
Jonah Williams
ba143ae21e
Update devtools_launcher.dart (#85995) 2021-07-06 22:01:02 -07:00
Shi-Hao Hong
b0bd7cf1d8
make app localizations lookup a public method (#84732) 2021-07-01 15:01:03 -07:00
Ahmed Ashour
a3dc90c4f5
Add space before curly parentheses. (#85306) 2021-07-01 13:51:05 -07:00
Ahmed Ashour
529a599ce6
Fix some indentation (#84967) 2021-07-01 13:41:04 -07:00
Shouichi Kamiya
6c2c702f43
Update outdated ios setup link in error message (#84246) 2021-07-01 13:36:05 -07:00
Jenn Magder
f76b292626
Support iOS arm64 simulator (#85642) 2021-06-30 14:31:04 -07:00
Zachary Anderson
407916d44f
Revert "Support iOS arm64 simulator (#85059)" (#85641)
This reverts commit a1020512ef.
2021-06-30 12:44:49 -07:00
Jenn Magder
a1020512ef
Support iOS arm64 simulator (#85059) 2021-06-30 11:56:17 -07:00
Dan Field
e36e62e9a6
Revert "Revert "Audit hashCode overrides outside of packages/flutter (#85370)" (#85451)" (#85567)
This reverts commit 2be0d57fa2.
2021-06-30 09:46:54 -07:00
Filip Hracek
76d5e62f42
Add a more complete app template for Flutter (skeleton) (#83530) 2021-06-28 15:26:04 -07:00
Lau Ching Jun
af42e7d730
Only set assets directory after assets are uploaded onto devfs. (#85418) 2021-06-28 13:16:04 -07:00
Danny Tuppeny
dec122a4d8
Remove incorrect text about web renderer default (#85214) 2021-06-28 12:56:06 -07:00
Jenn Magder
e028d0f046
Split project.dart into CMake and Xcode projects (#85359) 2021-06-28 11:31:04 -07:00
Ren You
2be0d57fa2
Revert "Audit hashCode overrides outside of packages/flutter (#85370)" (#85451)
This reverts commit 9846fa5145.
2021-06-28 09:55:31 -07:00
Chase Latta
6dd9e8c153
[fuchsia] pm serve should not use the device address (#85341)
BUG: fxbug.dev/77566
BUG: https://github.com/flutter/flutter/issues/83609
2021-06-27 16:58:20 -07:00
Dan Field
9846fa5145
Audit hashCode overrides outside of packages/flutter (#85370) 2021-06-26 17:36:04 -07:00
Lau Ching Jun
8251f55256
Revert "Make sure that the asset directory on devfs always exist. (#85267)" (#85353) 2021-06-25 16:46:02 -07:00
Jonah Williams
a362e1166d
[flutter_tools] add un-discoverable preview device (#85253) 2021-06-25 15:36:04 -07:00
Jonah Williams
1977ee75b3
[flutter_tools] ensure kernel paths match between init from dill and persist (#85252) 2021-06-25 11:11:04 -07:00
Jenn Magder
d145938406
Migrate flutter_cache to null safety (#85242) 2021-06-25 10:56:03 -07:00
Lau Ching Jun
102acbe39d
Make sure that the asset directory on devfs always exist. (#85267) 2021-06-24 22:51:02 -07:00
Jonah Williams
88e756d19e
[flutter_tools] well known device ids (#85184) 2021-06-24 18:46:04 -07:00
Jenn Magder
0de6bd41ba
Migrate iOS app deployment target from 8.0 to 9.0 (#85174) 2021-06-24 10:21:05 -07:00
Jonah Williams
21fc0c3a7a
[flutter_tools] remove online requirement for devtools (#85176) 2021-06-24 09:26:02 -07:00
Jonah Williams
ff5258a5e2
[flutter_tools] convert devtools URL to a better format (#85170) 2021-06-23 19:31:02 -07:00
Jonah Williams
ad540e4f3f
[flutter_tools] retry chrome launch up to 3 times (#85162) 2021-06-23 19:26:02 -07:00
Jonah Williams
e67113c16f
[flutter_tools] use UWP cpp wrapper for UWP build (#85167) 2021-06-23 19:21:02 -07:00
Ahmed Ashour
49c08b7353
Fix checking of index.html (#85016) 2021-06-23 16:41:03 -07:00
Jenn Magder
2e5284a26b
Do not list Android or iOS devices when feature disabled (#85145) 2021-06-23 15:41:04 -07:00
Balvinder Singh Gambhir
604c59e522
adds build number of ios device in flutter devices command (#84512) 2021-06-23 11:31:03 -07:00
Jenn Magder
40428fa0ea
macOS unzip then rsync to delete stale artifacts (#85075) 2021-06-22 17:10:56 -07:00
Phil Quitslund
2c9de5ab49
remove deprecated author section (#85036) 2021-06-22 09:41:04 -07:00
Mirko Mucaria
bce1706f1c
Fix watchOS build when companion app is configured with xcode variable (#84519) 2021-06-17 14:14:03 -07:00
Jenn Magder
53f5b90209
Use -miphonesimulator-version-min when building App.framework for simulator (#84729) 2021-06-16 15:54:38 -07:00
Anurag Roy
ce7df25ae7
Move flutterGit from version.dart (#79568) 2021-06-16 11:51:37 -07:00
Tim Sneath
57a565c706
Clean up podspec template (#84662) 2021-06-15 18:44:02 -07:00
Jenn Magder
db930ba32f
Migrate build_macos and web_test_compiler to null safety (#84469) 2021-06-14 18:29:03 -07:00