Commit Graph

556 Commits

Author SHA1 Message Date
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints (#117365) 2022-12-20 16:03:21 -08:00
Jackson Gardner
9f2c5d8e21
Support flutter build web --wasm (#117075)
* Work in progress.

* Some fixes to the command line.

* Bootstrapping works.

* Change kickoff order to maximize concurrency.

* Fix analyzer errors and formatting issues.

* Fix doc comment.

* Added unit tests for some of the web targets.

* Format issue.

* Add an integration test that builds an app to wasm.

* Add a todo for depfiles.

* Formatting.

* Apparently the license header needs to say 2014.

* `file://` URIs confuse dart2wasm on Windows. Just use absolute paths.

* Update unit tests to match new path passing.

* Have a distinct build directory for wasm, and fixes for some upstream changes.
2022-12-19 20:09:02 +00:00
Jackson Gardner
ebeb491895
Use the name of errors, not the diagnostic messages. (#117229)
* Use the name of errors, not the diagnostic messages.

* Trailing comma.
2022-12-16 22:19:55 +00:00
Ian Hickson
9fdb64b7e7
Taboo the word "simply" from our API documentation. (#116061) 2022-12-11 22:43:22 +00:00
Siva
7c8e171320
Manual Roll of Flutter Engine from 67254d6e4b03 to 8d83b98c55b3 (#116635)
* Roll Flutter Engine from 67254d6e4b03 to 8d83b98c55b3

* Roll Dart SDK from 35a9facce191 to e517487c5679 (Dart 3.0) (#38105)

* Bump SDK versions.

* Bump Dart SDK version constraints

* Update shrine package to 2.0.1 (null safe version)

* Fix more tests.

* Include patches from Jason for min android sdk version

* Fix analyzer warning
2022-12-08 18:03:51 -08:00
Jackson Gardner
db1c3e208d
Platform binaries reland (#115502)
You can now specify a --local-web-sdk flag to point to a wasm_release folder. This will make it so that only artifacts that pertain to the web sdk are overridden to point to the wasm_release folder. Other artifacts (such as impellerc) will pull from the cache, or from the --local-engine path if that is specified.

This also uses precompiled platform kernel files for both ddc and dart2js
2022-12-02 14:13:40 -08:00
Nehal Patel
3b15d6a501
Removes retries from "dart pub get" and un-buffers its stdout/stderr output (#115801)
* Removes retries from "pub get" and proxies its stdout output

* Fix issue where ErrorHandlingProcessManager does not forward "mode" parameter to backing ProcessManager's "start" method

* Make "pub get" use ProcessStartMode.inheritStdio instead of forwarding bytes to stdout and stderr

* Fix tests

* Remove unused env var

* Add back 'Running "flutter pub get"...' status log

* Fix indent

* Add Pub.test() constructor which lets tests mock stdio
2022-12-01 19:30:17 +00:00
Gary Qian
6e8ebb3771
Reland "Upgrade targetSdkVersion and compileSdkVersion to 33" (#116146) 2022-12-01 07:12:47 -08:00
Sam Rawlins
f255390f4d
Remove redundant arguments passed to redirecting factory constructors (#115497) 2022-11-17 00:47:14 +00:00
Christopher Fujino
a2233eabed
[flutter_tools] remove all body_might_complete_normally_catch_error ignores (#115184)
* remove all body_might_complete_normally_catch_error ignores

* add a test
2022-11-16 18:20:45 +00:00
Elias Yishak
d7454d552a
removing default values for [reporter] and [timeout] in flutter test (#115160)
* removing default values for [reporter] and [timeout]]

* passing reporter arg to see tests pass

* added test to confirm TestCommand is not passing defaults

* add'l helper message for [reporter] arg

* default behavior for github actions + fixed tests

* removing github conditional for reporter + related test

* removing unused import
2022-11-16 18:20:42 +00:00
Jonah Williams
59ecc75748
[flutter_tools] add uint compilation test (#115317)
* [flutter_tools] add uint compilation test

* Update shader_compiler_test.dart
2022-11-15 01:39:59 +00:00
Danny Tuppeny
09a4f23467
Prevent tests from producing dill files alongside the test file (#115075)
Fixes https://github.com/Dart-Code/Dart-Code/issues/4243.
2022-11-10 20:00:19 +00:00
Zachary Anderson
a84e369bd2
Revert "Allow Flutter golden file tests to be flaky (#114450)" (#114902)
This reverts commit 53e6876226.
2022-11-08 09:26:55 -08:00
Kate Lovett
53e6876226
Allow Flutter golden file tests to be flaky (#114450)
* allow marking a golden check as flaky

* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib

* Pause

* ++

* ++

* Analyzer therapy

* Once more with feeling

* Nits

* Review feedback

* Silly oops

* Test progress

* More tests

* Finish

* Nits

* Analyzer

* Review feedback

Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
Jonah Williams
e4e902dced
[flutter_tools] add compilation failure tests for new cases added in impellerc (#114757) 2022-11-07 20:59:13 +00:00
Tae Hyung Kim
cef4c2aac8
ICU Message Syntax Parser (#112390)
* init

* code generation

* improve syntax error, add tests

* add tests and fix bugs

* code generation fix

* fix all tests :)

* fix bug

* init

* fix all code gen issues

* FIXED ALL TESTS :D

* add license

* remove trailing spaces

* remove print

* tests fix

* specify type annotation

* fix test

* lint

* fix todos

* fix subclass issues

* final fix; flutter gallery runs

* escaping for later pr

* fix comment

* address PR comments

* more

* more descriptive errors

* last fixes
2022-11-05 10:26:46 -07:00
Gary Qian
7ab2bf8ff7
Delete flutter_migrate code (#114253) 2022-10-31 17:52:05 +00:00
Jonah Williams
4f19a9fa46
[flutter_tools] Add support for compiling shaders to JSON bundle for web (#114295) 2022-10-31 16:52:09 +00:00
Lucas Britto
5d93894264
[flutter_tools] Decouple fatal-warnings check from fatal-infos (#113748) 2022-10-26 16:44:25 +00:00
Danny Tuppeny
3599b3a877
Add support for expression compilation when debugging integration tests (#113481)
Fixes #79439.
2022-10-25 15:34:22 +01:00
Jenn Magder
f059dd40ea
Show Xcode compilation errors at end of build, suppress stdout and stderr from Xcode (#113302) 2022-10-17 17:47:25 +00:00
Zachary Anderson
1587ee0123
Revert "Upgrade targetSdkVersion and compileSdkVersion to 33 (#112936)" (#113064)
This reverts commit f80411d893.
2022-10-06 13:52:31 -07:00
Gary Qian
f80411d893
Upgrade targetSdkVersion and compileSdkVersion to 33 (#112936) 2022-10-06 20:11:28 +00:00
Gary Qian
21861423f2
[flutter_tools] analyze --suggestions --machine command (#112217) 2022-10-03 17:40:58 +00:00
Danny Tuppeny
5655225cd7
Send progress notifications to clients during hot reload / hot restart (#112455) 2022-09-29 16:27:40 +01:00
姚春锋
148a0b264b
let the plugin's output generated in flutter/.android/plugins_build_output/${androidPlugin.name} (#94645) 2022-09-14 15:47:16 +00:00
Ivan Dlugos
d63442c1da
refactor: strip all local symbols from macOS and iOS App.framework - reduces app size (#111264) 2022-09-09 21:13:10 +00:00
Sigurd Meldgaard
d80e994a62
Reland: Show output from pub get in flutter pub get (#110851) 2022-09-08 15:13:23 +02:00
Christopher Fujino
08d5d51a98
[flutter_tools] Instantiate shutdown hooks before localfilesystem (#110693) 2022-09-02 17:38:56 +00:00
David Iglesias
9cb9f6bca4
[tool] Fix flutter.js regression with hot-reload on promise-based init. (#110805) 2022-09-01 22:25:16 +00:00
Gary Qian
ddfcda73cd
Track platform in MigratePlaformConfig and enforce metadata file being provided (#110540) 2022-08-31 19:04:22 +00:00
Zachary Anderson
0e195e9d46
Revert "Show output from pub get in flutter pub get (#106300)" (#110478)
This reverts commit 3802eb627e.
2022-08-29 08:02:50 -07:00
Sigurd Meldgaard
3802eb627e
Show output from pub get in flutter pub get (#106300) 2022-08-29 07:37:19 +00:00
Kate Lovett
7e12b37111
Deprecate 2018 text theme parameters (#109817) 2022-08-22 20:00:34 +00:00
Jackson Gardner
5aad12cab1
Generate syntax for plugin registration that works both with and without null safety. (#109480) 2022-08-19 16:16:41 +00:00
Michael Goderbauer
2b9beda0d0
Reland "Keep dirty manipulations private to Element base class (#109401)" (#109562) 2022-08-15 19:59:13 +00:00
Jesús S Guerrero
edd466811d
Disable jank metrics for web (#109356) 2022-08-11 19:58:06 +00:00
Zachary Anderson
4dd9d49608
[flutter_tools] Adds test of impellerc output file mode (#109190) 2022-08-09 15:08:06 +00:00
Daco Harkes
c2e58cdb18
Add quotes to Gradle NDK version error message (#109026) 2022-08-07 11:46:08 +00:00
Phil Quitslund
fd0da75cc9
fix noop toString() diagnostics (#108836) 2022-08-02 21:51:06 +00:00
Danny Tuppeny
14626c0a6d
[flutter_tools] Test that DAP process terminates at the end of a session (#108301) 2022-08-02 20:44:06 +00:00
Gary Qian
7cfbdadc33
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108472 (#108510) 2022-07-28 19:38:07 -07:00
Michael Goderbauer
10a7c9ba22
Unify analysis options (#108462) 2022-07-28 09:07:49 -07:00
Kate Lovett
716533925b
Revert "Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355 (#108472)" (#108488)
This reverts commit 1f8c490c82.
2022-07-27 17:20:20 -05:00
Gary Qian
1f8c490c82
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" #108355 (#108472) 2022-07-27 14:23:09 -07:00
Zachary Anderson
1e69683688
Revert "Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" (#108355)" (#108407)
This reverts commit c4b3625d62.
2022-07-26 19:30:28 -07:00
Gary Qian
c4b3625d62
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchmarks+examples" (#108355) 2022-07-26 16:23:08 -07:00
Jenn Magder
50474b29ce
Only run pod install on the first iOS build (#108205) 2022-07-26 19:39:06 +00:00
Danny Tuppeny
5d31b07ed5
[flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (#108310)
* [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate

Fixes an issue where the flutter_tester device may not be cleaned up correctly if we just terminate the Flutter process.

* Update integration test expectations

* Revert accidental commit
2022-07-26 10:48:38 +01:00
Zachary Anderson
d155bc1bad
Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (#108349)
This reverts commit ca6cecf034.
2022-07-25 22:20:37 -07:00
Gary Qian
ca6cecf034
Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197) 2022-07-25 15:23:08 -07:00
Rich Kadel
549f70c914
Remove outdated Fuchsia concepts (#107335)
Fuchsia will soon remove all support for Component Framework version 1
components (recognized by component manifests ending in `.cmx`).
Notably, some of the `flutter` tool commands for Fuchsia devices--
notably, but not limited to, those related to CFv1--are outdated, and
either do not work today or soon won't work.

This PR removes the outdated components and commands, replacing some
with the newer version, or simply removing the non-working features,
in some cases.
2022-07-22 16:42:48 -07:00
Danny Tuppeny
c67d2587d5
Provide more useful error message if a non-compliant DAP tool (or user) sends bad input to DAP server (#107827) 2022-07-19 11:48:05 -07:00
Jesús S Guerrero
cdf5b1d40d
Pub dependencies project validator (#106895) 2022-07-15 23:12:05 +00:00
Jason Simmons
95a5a8d741
Check for analyzer rule names instead of descriptions in a flutter_tools test (#107541)
The descriptions can change between different versions of the analyzer.
2022-07-13 09:53:40 -07:00
David Iglesias
c4aaa394ac
[tool][web] Create an early web plugin_registrant for dartpad. (#106921) 2022-07-02 00:51:06 +00:00
Loïc Sharma
6026eea9a4
[Windows] Flow version information to the build output (#106145)
Previously developers had to edit their `Runner.rc` file to update their executable's version information. Now, version information will automatically be set from `flutter build`'s arguments or the `pubspec.yaml` file for new projects. 

Addresses https://github.com/flutter/flutter/issues/73652
2022-06-27 10:45:56 -07:00
Brandon DeRosier
097c162cce
Fix .packages breakage and roll engine to 83b9a591a3d5 (#106584)
* 9508a368d Roll Dart SDK from 692562354d6d to d3b8091c30f0 (1 revision) (flutter/engine#34273)

* a2985c034 Roll Fuchsia Linux SDK from F1U6IH2Nf... to aRT7s0Yct... (flutter/engine#34251)

* 54867f360 Roll Skia from bdd0205ae470 to 4345a2ea731a (1 revision) (flutter/engine#34268)

* 98221a22d Clean up text input configuration in clearTextInputClient (flutter/engine#34209)

* b9e02cc83 Adds a license check shard to CI (flutter/engine#34274)

* 1daf7ba98 [Impeller] Metal:Reset Encoder viewport and scissor rect in case the command specifies no opinion (flutter/engine#34252)

* 83b9a591a [Linux] remove duplicate clone_string() in favor of g_strdup() (flutter/engine#34031)

* Don't use .packages

* Another attempt

Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
2022-06-24 17:27:17 -07:00
Jesús S Guerrero
ddd493b927
[flutter_tools] migrate project-validate to analyze --suggestions (#106149) 2022-06-24 18:43:07 +00:00
Danny Tuppeny
e2ef8cfe44
Pass app.started events to the DAP client + dart.debuggerUris for Profile mode (#106337) 2022-06-21 12:09:06 -07:00
Jonah Williams
db829c1e20
[flutter_tools] migrate more unit tests to null safety (#106153) 2022-06-17 21:34:27 -07:00
Loïc Sharma
2efa2e44fe
Add integration test for flutter build windows (#106053)
Add an integration test that verifies that `flutter build windows` produces the expected executable. In the future, this will be used to test that version information is properly stamped on the executable.

Part of https://github.com/flutter/flutter/issues/73652.
2022-06-17 17:14:18 -07:00
Sam Rawlins
f104be7ae9
Ignore body_might_complete_normally_catch_error violations (#105795) 2022-06-16 23:12:06 +00:00
Lau Ching Jun
d30ad47eda
Make flutter attach respect the --dds-port flag. (#105560) 2022-06-09 13:03:09 -07:00
Nils Reichardt
64db621980
Remove new keyword in a few files (#104438) 2022-06-06 16:08:06 -07:00
jensjoha
9929446ea3
Extra timing on hot reload (#104242)
This PR adds extra timings for a hot reload.
As an example, before a user might see

> Performing hot reload...                                                
> Reloaded 1 of 788 libraries in 554ms.

With this PR it would instead be something like

> Performing hot reload...                                                
> Reloaded 1 of 788 libraries in 554ms (compile: 33 ms, reload: 153 ms, reassemble: 310 ms).
2022-06-03 08:41:14 +02:00
Gary Qian
c02be8cd47
Support string compileSdkVersion for preview android SDKs (#104662) 2022-05-31 13:08:09 -07:00
Danny Tuppeny
147020366a
Fix issues running integration tests through DAP debug adapter (#104618)
* Fix issues running integration tests through DAP

These adapters were incorrectly trying to connect a DDS instance even when Flutter would create its own. This change disables DDS in the DAP layer and leaves it to Flutter (although it passes `--no-dds` on to Flutter if provided to the DAP process).

Also fixes an issue where we would unnecessarily connect the VM Service for tests even in 'noDebug' mode because of a change/fix that now includes a 'vmServiceUri' in the `test.startedProcess` event.
2022-05-26 09:36:30 +01:00
Michael Goderbauer
3fa355c97d
Remove dead code in tools tests (#104567) 2022-05-25 12:48:17 -07:00
Jenn Magder
a56c5e51ae
Migrate some test files to null safety (#104469) 2022-05-24 16:53:08 -07:00
Jesús S Guerrero
336aa267f9
[flutter_tools] General info project validator (#103653) 2022-05-24 16:28:10 -07:00
Jonah Williams
9f28b83c19
[flutter_tools] migrate some integration tests to null safety (#103560) 2022-05-13 09:39:10 -07:00
David Iglesias
1af8cc1183
[tools][web] Make Plugin Registrant file ephemeral. (#102185) 2022-05-11 17:54:11 -07:00
Gary Qian
e997a3abd2
Add tests for migrate command methods (#103466) 2022-05-11 11:09:08 -07:00
Gary Qian
90a8b0561d
[flutter_tools] MigrateUtils and MigrateManifest classes (#101937) 2022-05-09 15:23:50 -07:00
Danny Tuppeny
4ab68bd04d
Use consistent date instead of DateTime.now() in evaluation tests (#103269) 2022-05-08 19:32:14 +01:00
Jenn Magder
c6ced845e3
Remove custom unawaited, prefer dart:async version (#103212) 2022-05-07 08:49:04 -07:00
Alexandre Ardhuin
d40ee2149c
remove unnecessary .toString() (#103226) 2022-05-06 16:04:13 -07:00
Gary Qian
1b16d23747
Add debug logging to deferred components test for deflaking (#103161) 2022-05-06 02:39:08 -07:00
Jenn Magder
36be63ba19
Embed Flutter and App frameworks for add-to-app on iOS (#102538) 2022-05-02 10:44:12 -07:00
Phil Quitslund
b5e7fb076c
[flutter_tools] rename local functions with _s (#102688) 2022-04-27 16:19:07 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
Kaushik Iska
aeaeded715
Add VMService command to get frame rasterization metrics (#100696) 2022-04-14 13:44:05 -07:00
Christopher Fujino
fd5356ff60
[flutter_tools] shard out two integration tests we want to run on macOS arm64 (#101769) 2022-04-13 12:09:11 -07:00
Christopher Fujino
355fd23a79
[flutter_tools] add test for dart binary arch (#101604) 2022-04-11 16:28:37 -07:00
Danny Tuppeny
675b961573
Unpause and remove breakpoints when detaching from Flutter process with DAP (#101695) 2022-04-11 21:15:37 +01:00
Daco Harkes
85aac37ccf
Add more debugging info to android_plugin_example_app_build_test (#101685) 2022-04-11 08:24:09 -07:00
Michael Goderbauer
a01424773e
Enable unnecessary_import (#101600) 2022-04-08 12:56:45 -07:00
creativecreatorormaybenot
96add4192e
Use single quotes for dartSdkVersionBounds (#101270)
* Use single quotes for `dartSdkVersionBounds`

* Update update_packages_test.dart

* Update test_project.dart

* Update tests_project.dart

* Update compile_error_project.dart

* Update hot_reload_with_asset.dart

* Update break_on_framework_exceptions_test.dart

* Update basic_project.dart
2022-04-06 09:54:10 -07:00
keyonghan
95f4f473ff
[Revert] Skip overall_experience_test.dart: flutter run writes and clears pidfile appropriately (#101267)
* restore test

* use seed 20211102

* restore seed
2022-04-04 13:26:27 -07:00
Michael Goderbauer
dcde8163ce
migrate to super params (#100509) 2022-03-31 11:46:47 -07:00
Gary Qian
ead5b1c2f4
Retire v1 embedding compatibility from automatic multidex support (#100685) 2022-03-31 10:24:42 -07:00
Jenn Magder
231c1a4b55
Pass ARCHS build setting to flutter assemble on macOS (#100811) 2022-03-28 10:55:14 -07:00
Alex Li
543a7e8588
Android Q transition by default (#100812) 2022-03-25 22:25:07 -07:00
Danny Tuppeny
b39a9473f8
Handle Flutter.Error events and disable structure errors for noDebug mode (#100149) 2022-03-17 16:05:21 -07:00
Gary Qian
63ff7a199b
MigrateConfig and migrate integration testing base (#99092) 2022-03-16 11:10:22 -07:00
Christopher Fujino
bb4a5fa7ab
[flutter_tools] exec rather than spawn subprocess from bin/internal/shared.sh (#99871) 2022-03-14 13:35:18 -07:00
Greg Spencer
fa68ecf7c6
Fix the race condition in cache_test.dart (#99423)
This fixes a race condition in test/integration.shard/cache_test.dart which allowed the test to fail if the machine took a very long time to acquire a lock or launch a process.
2022-03-03 12:55:47 -08:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint (#98753) 2022-02-22 14:39:20 -08:00