Jenn Magder
e9abf5a940
Profiling Xcode app should use Flutter profile mode ( #71748 )
2020-12-04 16:59:19 -08:00
Jenn Magder
b372c52b2f
Remove unused local from xcode_backend ( #71752 )
2020-12-04 16:23:05 -08:00
Jenn Magder
f0b17f3e26
Remove missing macOS RunnerUITests ( #71750 )
2020-12-04 15:58:03 -08:00
Jenn Magder
f78b6d6a51
Remove Flutter Authors from macOS project organization name ( #71744 )
2020-12-04 14:38:13 -08:00
Jenn Magder
d4150d3f6d
Adopt Flutter.xcframework in tool ( #71495 )
2020-12-04 13:57:11 -08:00
Zachary Anderson
cd3aec3660
[flutter_tool] Report analytics as disabled when suppressed ( #71728 )
2020-12-04 11:52:32 -08:00
Jonah Williams
afb6b95593
[flutter_tool] fix incorrect coverage file generation ( #71726 )
2020-12-04 11:15:11 -08:00
Shi-Hao Hong
95e444ce9a
[gen-l10n] Fix forwarding of output-dir in l10n.yaml file ( #71128 )
2020-12-03 16:18:04 -08:00
Ian Hickson
bb29c88ae7
Simplify the flutter_web_plugins plugin registration API. ( #70337 ) ( #70722 )
...
In principle this is backwards compatible; I just merged all the classes into one and deprecated everything that became redundant as a result.
2020-12-03 15:35:41 -08:00
Jason Simmons
2c3ba5b635
Create symlinks for local engine Maven metadata files required by the Android Gradle plugin ( #71600 )
2020-12-03 15:28:06 -08:00
Jonah Williams
c92cc25830
[flutter_tools] report basic analytics for null-safety ( #71487 )
2020-12-03 15:14:20 -08:00
J-P Nurmi
b358854172
[flutter_tools] Set basic error matcher for Linux builds ( #71003 )
2020-12-03 13:41:37 -08:00
Jonah Williams
4e85a67f3e
[flutter_tools] roll deps, fix completion bug ( #71671 )
2020-12-03 11:58:03 -08:00
Martin Kustermann
625ecda083
Remove left-overs from causal async stacks. ( #71663 )
2020-12-03 11:03:07 -08:00
Jonah Williams
9e5c8771d4
[flutter_tools] wire up native-null-assertions for flutter web ( #71618 )
2020-12-03 08:59:31 -08:00
Jonah Williams
088b7c36c3
[flutter_tools] hide web server by default ( #71491 )
2020-12-03 08:59:20 -08:00
Jenn Magder
a8bed5e405
Add sysctl file fallbacks ( #71623 )
2020-12-03 08:53:07 -08:00
Kate Lovett
8e05e59c29
Revert "Add integration_test template to create template ( #70240 )" ( #71660 )
...
This reverts commit d047d108eb
2020-12-03 09:54:28 -06:00
Jonah Williams
81e1f7d1ed
[flutter_tools] mode code size output to ~/.flutter-devtools ( #71601 )
2020-12-02 17:19:57 -08:00
Dan Field
d047d108eb
Add integration_test template to create template ( #70240 )
2020-12-02 17:08:03 -08:00
Jonah Williams
e8b87f7cd2
[flutter_tools] enable CK restart tests ( #71598 )
2020-12-02 13:10:54 -08:00
Emmanuel Garcia
8dd0de7f58
Relands: Migrate template to Gradle 6.7 and AGP 4.1.0 ( #71446 )
2020-12-01 19:01:09 -08:00
Jonah Williams
f8883445ca
Revert "[flutter_tools] post process the gradle log output ( #71499 )" ( #71527 )
...
This reverts commit d688b52a93
2020-12-01 17:53:14 -08:00
Jonah Williams
d688b52a93
[flutter_tools] post process the gradle log output ( #71499 )
2020-12-01 17:13:33 -08:00
Jonah Williams
70e70ebb62
[flutter_tools] Catch all exception subtypes when unzipping a file ( #70967 )
2020-12-01 12:00:24 -08:00
Jenn Magder
8522ec7e11
Validate empty observatory URI for screenshot ( #71451 )
2020-12-01 10:00:30 -08:00
Jenn Magder
a5ee7f7cfc
Add XCFramework artifacts ( #71113 )
2020-12-01 10:00:16 -08:00
Gary Roumanis
7477524db6
Upgrade deps ( #71450 )
2020-12-01 09:57:27 -08:00
Jonah Williams
ffbca11f1b
[flutter_tools] delete BuildRunnerWebCompilationProxy and WebCompilationProxy ( #70914 )
2020-12-01 09:54:43 -08:00
Jonah Williams
1816778529
[flutter_tools] wire up alternative invalidation strategy to features ( #71439 )
2020-12-01 09:54:23 -08:00
Jonah Williams
b1d65e3168
[flutter_tools] support canvaskit unit testing ( #70969 )
2020-12-01 09:54:09 -08:00
Jonah Williams
e5000f6cea
[flutter_tools] Remove usage of --precompiled flag for web tests ( #70977 )
2020-12-01 09:54:01 -08:00
Jonah Williams
7ab0442868
Add testing shard for release mode guard ( #71411 )
2020-12-01 09:53:50 -08:00
Jonah Williams
a264c2bee2
[flutter_tools] do not validate unused services key ( #71417 )
2020-12-01 09:53:41 -08:00
Jonah Williams
1c4791e604
[flutter_tools] update some web configuration defaults ( #71433 )
2020-12-01 09:53:35 -08:00
Jonah Williams
5d201a35aa
[flutter_tools] allow hiding web server device, provide flags to re-enable ( #71434 )
2020-12-01 09:53:27 -08:00
Chris Yang
0a08f8afff
[flutter_tools] Display "no platforms" message based on results when creating plugins project ( #70215 )
2020-12-01 09:53:07 -08:00
Jia Hao
8de72126e9
[flutter_tools] Don't fail copying files if the destination is not writable ( #71215 )
2020-11-25 15:48:03 -08:00
Jenn Magder
9bbc2177ec
Move Flutter.podspec to add-to-app project template ( #71103 )
2020-11-24 10:16:09 -08:00
Jenn Magder
e6bd95bc5c
Use module Profile scheme when profiling ( #70896 )
2020-11-23 14:10:58 -08:00
Jenn Magder
3379435185
iOS aot assembly requires SDK root ( #71094 )
2020-11-23 14:10:10 -08:00
Jenn Magder
3a479e7efd
Rename SdkType -> EnvironmentType ( #71095 )
2020-11-23 14:03:03 -08:00
Amir Hardon
7df04fdbd3
Revert "Migrate template to Gradle 6.7 and AGP 4.1.0 ( #70808 )" ( #71096 )
...
This reverts commit 8e73bab94c
2020-11-23 12:27:36 -08:00
Masaaki Kakimoto(柿本匡章)
accedc6794
Add current version to the upgrade message of the Flutter tool ( #68421 )
2020-11-23 12:08:53 -08:00
Jonah Williams
cf6c33e58a
[flutter_tools] fix port leak in flutter_driver ( #70999 )
2020-11-21 14:04:01 -08:00
Emmanuel Garcia
61dfbfe105
Wait for Android plugin to load before configuring plugin dependency ( #70970 )
2020-11-20 18:03:39 -08:00
Jonah Williams
974661924b
[flutter_tools] disable SWR optimization on dev ( #70912 )
2020-11-20 16:27:21 -08:00
Jonah Williams
613a959878
only use code single path for verification of target file existence ( #70962 )
2020-11-20 14:17:11 -08:00
Chris Yang
ffe5197e19
refactor ( #70959 )
2020-11-20 13:13:04 -08:00
Emmanuel Garcia
8e73bab94c
Migrate template to Gradle 6.7 and AGP 4.1.0 ( #70808 )
2020-11-20 13:05:35 -08:00
Jonah Williams
c07661cbc5
[flutter_tools] share bootstrap module between run and test ( #70903 )
2020-11-20 12:11:24 -08:00
Jonah Williams
1efb36035e
[flutter_tools] display message for current null safety mode ( #70718 )
2020-11-20 11:53:02 -08:00
Chris Yang
4e88f6a103
flutter_tools: refactor CreateCommand. ( #70874 )
2020-11-20 10:58:03 -08:00
Jenn Magder
c2d1203f26
Remove deprecated 'flutter build aot' ( #70898 )
2020-11-20 10:46:12 -08:00
J-P Nurmi
e51183763b
[flutter_tools] deploy version.json asset on Linux ( #69920 )
2020-11-20 10:23:04 -08:00
Anurag Roy
05dadb0120
[flutter_tools] Make flutter upgrade --verify-only display framework version differences instead of commit hashes ( #69420 )
2020-11-19 18:03:05 -08:00
Jonah Williams
a76289bb1b
[flutter_tools] run web unit tests in sound null safety ( #70799 )
2020-11-19 16:49:05 -08:00
Pierre-Louis
598627cd3b
Fix typo ( #70834 )
2020-11-19 16:43:09 -08:00
Yegor
535a4ac3ab
Clean-up docs for the --web-renderer option ( #70880 )
2020-11-19 16:41:09 -08:00
Jonah Williams
7086a2f43b
Revert "[flutter_tools] wire up alternative invalidation strategy to features ( #70865 )" ( #70884 )
...
This reverts commit ef4741540b
2020-11-19 14:01:39 -08:00
Jenn Magder
37f4f1f281
Detect ARM ffi CocoaPods error, suggest gem install ( #70801 )
2020-11-19 13:17:57 -08:00
Jonah Williams
ef4741540b
[flutter_tools] wire up alternative invalidation strategy to features ( #70865 )
2020-11-19 13:13:51 -08:00
Jonah Williams
4832e64cad
[flutter_tools] remove globals from flutter web platform ( #70863 )
2020-11-19 13:06:30 -08:00
Jonah Williams
085ff127ae
[flutter_tools] skip ck restart on all platforms ( #70853 )
2020-11-19 12:24:22 -08:00
Jonah Williams
c6290500f8
[flutter_tools] update dependencies ( #70797 )
2020-11-18 17:29:28 -08:00
Jonah Williams
f8940709b2
[flutter_tools] refactor shared memory filesystem logic ( #70795 )
2020-11-18 17:29:13 -08:00
Jonah Williams
42c9c22553
Revert "Stop extra framework copy during build ios-framework ( #70790 )" ( #70802 )
...
This reverts commit a9a35d10a4
2020-11-18 17:05:33 -08:00
Jenn Magder
a9a35d10a4
Stop extra framework copy during build ios-framework ( #70790 )
2020-11-18 15:00:28 -08:00
Jonah Williams
cfb63356c3
[flutter_tools] use frontend_server for web test compilation ( #70714 )
2020-11-18 14:55:26 -08:00
Jonah Williams
f4e79e6828
[flutter_tools] add support for dart defines to flutter test ( #70791 )
2020-11-18 14:52:49 -08:00
Jenn Magder
e26c7f98ff
Force regeneration of old Podfile ( #70735 )
2020-11-18 13:33:04 -08:00
stuartmorgan
be4cc764de
Clean up Windows plugin template ( #70403 )
...
Removes a comment that is left over from early iterations of the
template.
2020-11-18 10:01:53 -08:00
Dan Field
be2e7bb1c0
Revert "Revert "Allow any iOS app to be added to an existing host app ( #70647 )" ( #70739 )" ( #70740 )
...
This reverts commit aab9a76ee4
2020-11-17 22:19:50 -08:00
Dan Field
aab9a76ee4
Revert "Allow any iOS app to be added to an existing host app ( #70647 )" ( #70739 )
...
This reverts commit abdd65fc29
2020-11-17 21:40:28 -08:00
Jenn Magder
abdd65fc29
Allow any iOS app to be added to an existing host app ( #70647 )
2020-11-17 18:53:03 -08:00
Shi-Hao Hong
94ca7b4ad2
[gen-l10n] NNBD generated code ( #70415 )
...
* NNBD gen-l10n generated code
2020-11-18 10:14:38 +08:00
Ben Konyi
4cbafda853
Roll package:dds to 1.5.1 and add isCompleted guards around completers in base/dds.dart ( #70712 )
2020-11-17 16:03:18 -08:00
Ben Konyi
f6bedddd9f
Support legacy behavior for --host-vmservice-port and --observatory-port with DDS ( #70336 )
...
Implements the following:
- If both --host-vmservice-port and --dds-port are specified, use the current behavior
- If only --host-vmservice-port is specified and dds is enabled, use that for the dds port
- If only --dds-port is specified, use that for the dds port
Fixes https://github.com/flutter/flutter/issues/70332
2020-11-17 16:03:02 -08:00
Jonah Williams
fa41afa82e
[flutter_tools] reduce build bundle API ( #70514 )
2020-11-17 11:55:20 -08:00
Jonah Williams
8d15fa3936
[flutter_tools] remove unused/deprecated asset flags ( #70509 )
2020-11-17 11:02:14 -08:00
Jenn Magder
2529e358b6
Move Flutter.framework to build directory instead of ios/Flutter ( #70224 )
2020-11-17 10:09:29 -08:00
Jonah Williams
9618788e28
[flutter_tools] remove globals from features ( #70515 )
2020-11-16 15:00:37 -08:00
Jenn Magder
148ae7bf71
Always build x86 mac apps ( #70649 )
2020-11-16 14:53:04 -08:00
Marcus Tomlinson
343577afb6
Add liblzma as an explicit dependancy on Linux ( #70617 )
2020-11-16 14:48:02 -08:00
Jenn Magder
b84fb90400
Remove unused host_app_editable_cocoapods template files ( #70518 )
2020-11-16 14:33:43 -08:00
Anna Gringauze
f9df1935fe
[flutter_tools] Add bot configuration to run web_tool_tests for linux, mac, and windows ( #70412 )
...
* Move web integration tool tests to web.shard
Web integration tool tests depend on DDC changes in SDK. This change
moves them to a separate shard and subshard so CI bot configurations
can run them separately.
In particular, with will allow running those tests on dart CI flutter
HHH web bot instead of a non-web one, allowing early detection and easy
classification of issues caused by SDK changes as VM- or Web related.
* Enabled verbose mode for flaky web_tool_tests
* fixed local engine crash with --enable-asserts
* Disable failing tests, fix local engine with asserts
* Removed mac web_tool_tests bot
* Addressed CR comments
* Add disabled mac web_tool_tests and disable win web_tool_tests
2020-11-16 11:50:57 -08:00
Jonah Williams
836efaecf0
[flutter_tools] stop unit test from writing real file ( #70511 )
2020-11-13 21:51:04 -08:00
Jonah Williams
6e84a14294
Revert "Simplify the flutter_web_plugins plugin registration API. ( #70337 )" ( #70505 )
...
This reverts commit 8749d95521
2020-11-13 16:04:53 -08:00
Anna Gringauze
d5b1cc5b9f
Disable failing test due to SDK issue ( #70485 )
...
* Disable failing test due to SDK issue
* Disable failing debugger and hot reload windows tests
2020-11-13 14:15:31 -08:00
Ian Hickson
8749d95521
Simplify the flutter_web_plugins plugin registration API. ( #70337 )
...
In principle this is backwards compatible; I just merged all the classes into one and deprecated everything that became redundant as a result.
2020-11-13 14:05:34 -08:00
Jonah Williams
8436c6ab7e
remove testUsingContext ( #70482 )
2020-11-13 13:23:03 -08:00
Jonah Williams
f98c468317
[flutter_tools] remove unused JSON schema ( #70480 )
2020-11-13 13:02:40 -08:00
Jonah Williams
a86dab0c40
[flutter_tools] remove automatic doctor from flutter create ( #70475 )
2020-11-13 11:44:10 -08:00
Jonah Williams
0a73ecf6df
[flutter_tools] use initially parsed package config for language version, sound mode determination ( #70323 )
2020-11-13 09:41:11 -08:00
Jonah Williams
0b88269807
[flutter_tools] remove branch migration and standardize constructor style for version interface ( #70058 )
2020-11-12 15:29:03 -08:00
Jenn Magder
d11859fee7
Add -miphoneos-version-min=8.0 to App framework stub ( #70405 )
2020-11-12 15:14:53 -08:00
Jonah Williams
5fedad9173
[flutter_tools] allow using flutter test for testing the tool too ( #69911 )
2020-11-12 13:52:09 -08:00
Jonah Williams
0c79659900
[flutter_tools] make most integration tests null safe ( #70334 )
2020-11-12 10:23:03 -08:00
Anna Gringauze
edf26e756d
Move web integration tool tests to web.shard ( #70226 )
...
* Move web integration tool tests to web.shard
Web integration tool tests depend on DDC changes in SDK. This change
moves them to a separate shard and subshard so CI bot configurations
can run them separately.
In particular, with will allow running those tests on dart CI flutter
HHH web bot instead of a non-web one, allowing early detection and easy
classification of issues caused by SDK changes as VM- or Web related.
* Enabled verbose mode for flaky web_tool_tests
* Split out the test changes to be commited first
2020-11-11 15:42:15 -08:00
Jonah Williams
22ec357bc4
[flutter_tools] make getBuildInfo async ( #70320 )
2020-11-11 15:33:23 -08:00
Jonah Williams
0f80116a63
[flutter_tools] improve hash performance in build_system ( #70065 )
2020-11-11 15:31:07 -08:00
Jonah Williams
a40ee8a3fb
[flutter_tools] migrate .packages to package_config, partial ( #70200 )
2020-11-11 13:50:41 -08:00
Jonah Williams
fb28ee2860
[flutter_tools] reland: cache pub invocations ( #70180 )
...
Disabled caching of pub invocations on flutter drive.
2020-11-10 13:56:36 -08:00
Jonah Williams
0bbd9020ed
[flutter_tools] remove experiment tracking analytics for null safety ( #70183 )
2020-11-10 12:49:50 -08:00
Jonah Williams
39bc68b6a2
[flutter_tools] dont use autodetect enum for web ( #70189 )
2020-11-10 12:49:38 -08:00
Jonah Williams
84a8bd3f5a
Revert "[flutter_tools] always use dart to run test script. ( #70146 )" ( #70175 )
...
This reverts commit a90880a8c3
2020-11-10 05:21:14 -08:00
Jonah Williams
a90880a8c3
[flutter_tools] always use dart to run test script. ( #70146 )
2020-11-10 05:02:56 -08:00
Jonah Williams
dbcd7868a4
[flutter_tools] remove most globals from asset system and remove Cache manipulation in unit tests ( #70011 )
2020-11-09 18:01:04 -08:00
Jonah Williams
1c4b50ecf1
Revert "[flutter_tools] restore pub caching functionality ( #70133 )" ( #70144 )
...
This reverts commit ff953e4f83
2020-11-09 16:38:07 -08:00
Jonah Williams
3fb389c75a
[null-safety] implement null-safe autodetection for the web ( #70126 )
...
Fixes #69416
Fixes #70121
2020-11-09 16:13:38 -08:00
Jonah Williams
ff953e4f83
[flutter_tools] restore pub caching functionality ( #70133 )
...
Necessary to work around #70013 (this looks like it will be fixed, but should protect us in the future)
Restores some notion of skipping pub, with differences from the prior implementation:
Off by default, and only used by the flutter command automatic pub get
A single check parameter. Uses the framework version cached per-project instead of a timestamp of the tool, to avoid cases where downloading a prebuilt framework would cause this check to no longer work.
2020-11-09 16:11:55 -08:00
Greg Spencer
bbc0161669
Remove references to Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow ( #69617 )
...
* Remove references to dart:ui.Window, and point usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate
* remove new test platform dispatchers
* Amend documentation
2020-11-09 15:26:29 -08:00
Jonah Williams
8c02c300d9
[flutter_tools] always run pub with prebuilt applicaitons on drive ( #70136 )
2020-11-09 14:55:04 -08:00
Yegor
879466eac2
default to unsound nullability for web ( #70120 )
2020-11-09 13:49:02 -08:00
Jonah Williams
f1cdf2e6f3
Revert "[flutter_tools] restore pub caching functionality on run/test ( #70056 )" ( #70132 )
...
This reverts commit 6e5845f025
2020-11-09 13:31:01 -08:00
Jonah Williams
6e5845f025
[flutter_tools] restore pub caching functionality on run/test ( #70056 )
2020-11-09 12:52:22 -08:00
Emmanuel Garcia
21e802746b
Migrate Flutter Gallery test to null safety ( #70116 )
2020-11-09 12:29:14 -08:00
Jonah Williams
4c511fbde2
[flutter_tools] remove workaround for caching sound dill ( #70014 )
2020-11-09 11:53:56 -08:00
Michael Thomsen
168ad5dc4d
Roll engine and fix pubspecs that do not have a Dart SDK constraint ( #70078 )
2020-11-09 19:02:10 +01:00
xster
d18bd9a5bb
move cupertino_icon template to 1.0.1 for null safety ( #69997 )
2020-11-09 09:54:42 -08:00
Yuqian Li
8e7748e74c
Reland migration ( #69996 )
...
This reverts ae0a9cb560#69629 .
Additionally, `flutter update-packages --force-upgrade` has been run to update `pubspec.yaml` to resolve the analyze test failures.
2020-11-08 20:32:04 -08:00
Michael Thomsen
e4d94f7ccd
Revert "Migrate Flutter gallery test to null safety ( #69048 )" ( #70023 )
...
This reverts commit 7ba775a994
2020-11-07 12:15:22 +01:00
Emmanuel Garcia
7ba775a994
Migrate Flutter gallery test to null safety ( #69048 )
2020-11-06 20:38:12 -08:00
Jonah Williams
52d49fb358
[flutter_tools] remove material design schema, use dart code ( #69987 )
...
Instead of loading the use-material-design asset data from a yaml file in the repo, leave it in dart code and simplify. Remove some of the globals, but not enough to update to testWithoutContext
2020-11-06 19:55:55 -08:00
George Wright
2b512781a0
Add a --dart-entrypoint-args flag to flutter run to pass through Dart entrypoint arguments on Flutter Desktop ( #69607 )
2020-11-06 15:34:02 -08:00
Jonah Williams
2fb53d83f2
[flutter_tools] remove all globals from cache and cache_test ( #69505 )
2020-11-06 15:26:45 -08:00
Jonah Williams
1f210275aa
[flutter_tools] wrap http send in async guard ( #69972 )
2020-11-06 11:00:20 -08:00
Mokusesei
6269abb75b
Reland: fix android studio 4.1 plugin path for mac ( #69954 )
2020-11-06 10:57:04 -08:00
Devon Carew
5ba2d79ad2
remove the use of the analysis server --enable-experiments flag from flutter analyze ( #69966 )
2020-11-06 10:56:34 -08:00
Jonah Williams
e18533e7ab
[flutter_tools] remove globals from android_workflow ( #69548 )
2020-11-06 10:55:52 -08:00
Jonah Williams
ef288c1720
[flutter_tools] work around bug in plugins CI ( #69971 )
2020-11-06 10:55:40 -08:00
Gary Roumanis
16daed86c3
Persist Chrome Default Directory ( #69921 )
2020-11-06 10:54:04 -08:00
Dan Field
76784651d4
Move package:integration_test to flutter/flutter ( #69622 )
2020-11-05 17:28:47 -08:00
Jonah Williams
a3f6ea6f38
[flutter_tools] split web integration tests into new shard ( #69914 )
2020-11-05 17:21:44 -08:00
Shi-Hao Hong
a1a096e35a
[gen-l10n] Fix untranslated messages ( #68553 )
2020-11-05 16:24:02 -08:00
Jonah Williams
dd8820bcc1
[flutter_tool] initialize flutter root in executable ( #69549 )
...
initialize the flutter root as early as possible. This allows all interfaces to be normally injected into commands, even if those objects might read from the flutter root.
2020-11-05 15:21:05 -08:00
Jenn Magder
bc2a4a6498
Update CocoaPods recommended version to 1.9 ( #69809 )
2020-11-05 15:13:22 -08:00
Jonah Williams
ed1189259e
[flutter_tools] forward all args to pub ( #69784 )
...
Change forwarding command to pass through all args, even -h - this allows flutter to support all of the pub flags without needing to declare them.
2020-11-05 14:23:24 -08:00
Jenn Magder
1be922c353
Build either iphoneos or iphonesimulator App.framework, not both ( #69840 )
2020-11-05 14:22:24 -08:00
Dan Field
cfcb9887c9
Do not use --first-parent when determining version on master ( #69726 )
2020-11-05 10:11:32 -08:00
Jonah Williams
e8efde6a54
[versions] update more null safe versions ( #69892 )
2020-11-05 09:09:03 -08:00
Vyacheslav Egorov
4c24eb10b8
Revert "Fix: fix android studio 4.1 plugin path for macOS" ( #69870 )
...
This reverts commit 422a97d1e5https://github.com/flutter/flutter/issues/69863
2020-11-05 11:18:00 +01:00
Jenn Magder
58ba70a6e7
Remove add-to-app Xcode build phase input files ( #69846 )
2020-11-04 23:26:59 -08:00
Jenn Magder
2f3cccc4f5
Run more xcodebuild commands in native arm on Apple Silicon ( #69837 )
2020-11-04 19:54:02 -08:00
Jenn Magder
3145c835ed
Deprecate build ios-framework --universal ( #69720 )
2020-11-04 19:44:04 -08:00
Mokusesei
422a97d1e5
Fix: fix android studio 4.1 plugin path for macOS ( #69364 )
2020-11-04 17:25:53 -08:00
Shi-Hao Hong
0963d72582
Make resource attributes optional for simple cases ( #68774 )
2020-11-05 08:11:53 +08:00
Jenn Magder
cb5263e191
Methods in build_ios_framework for universal and XCFrameworks ( #69736 )
2020-11-04 15:44:03 -08:00
Jonah Williams
580cacf4bd
[versions] roll versions ( #69810 )
2020-11-04 15:38:58 -08:00
Jonah Williams
7ceb20417c
disable hot reload web tests on CI due to flakes ( #69802 )
2020-11-04 12:36:33 -08:00
Jonah Williams
0ddb1ae713
fix hot reload benchmark data ( #69798 )
2020-11-04 11:43:24 -08:00
Jonah Williams
6cec03c7c1
[flutter_tools] do not reload sources if no sources changed ( #69450 )
...
If no source files were changed by a hot reload, do not send the reload sources RPC. This slightly speeds up the no-op reloads and gives users a faster way to force a re-render.
2020-11-04 11:15:30 -08:00
Jenn Magder
53410c4bb9
Compile snapshot_assembly with sdk root set in Xcode ( #69731 )
2020-11-04 10:32:01 -08:00
Anna Gringauze
5034d57546
Disable web expression evaluation tests ( #69728 )
...
Temporarily disable web expression evaluation tests,
until we figure out how to disable the only on non-web bot.
2020-11-03 23:36:54 -08:00
Jenn Magder
91b82347af
Build App.framework directly to build directory ( #69699 )
2020-11-03 12:48:25 -08:00
Emmanuel Garcia
212967449b
Update plugins dependencies for the Gallery test ( #69630 )
2020-11-03 12:03:18 -08:00
Jonah Williams
d0202131fd
[flutter_tools] support --extra-gen-snapshot-options everywhere --extra-front-end-options is specified ( #69592 )
...
support --extra-gen-snapshot-options everywhere --extra-front-end-options is specified
2020-11-03 10:11:14 -08:00
Jonah Williams
9ec5d7131b
Remove usage of --enable-experiment to analysis server ( #69614 )
2020-11-03 08:02:19 -08:00
Jonah Williams
fb90544cab
[flutter_tools] remove unused or no longer useful code ( #69547 )
2020-11-02 22:48:03 -08:00
Jonah Williams
a2a4e9eda4
Revert "Build App.framework directly to build directory ( #69612 )" ( #69641 )
...
This reverts commit b77088319a
2020-11-02 20:12:47 -08:00
Jenn Magder
b77088319a
Build App.framework directly to build directory ( #69612 )
2020-11-02 18:48:03 -08:00
Jonah Williams
9383ec793b
mark flaky tests as flaky ( #69633 )
2020-11-02 18:15:20 -08:00
Jason Simmons
88bf732ec5
Make the launch background drawable compatible with older Android API levels ( #69255 )
2020-11-02 16:08:03 -08:00
Jonah Williams
8291f4810f
[flutter_tools] add canvaskit hot reload integration test ( #69550 )
2020-11-02 10:40:46 -08:00
Andy Weiss
c4ceea397a
[flutter_tools] Support zipped application bundles for macOS ( #68854 )
...
* [flutter_tools] Support zipped application bundles for macOS
It is not possible to directly produce a directory (.app) in some build systems
but rather it must be zip'ed before being passed to the tool for
running. This adds support for attempting to extract an application
bundle from a zip file if the bundle is not already a directory. This
uses very similar code from lib/src/application_package.dart which is
used for extracting an ipa for iOS.
This introduces tests for the macos/application_package.dart behavior which did not exist before. These tests cover the changes in the PR and some of the existing behavior, but do not cover everything in that file.
2020-11-02 08:58:33 -08:00
Shi-Hao Hong
4996f60b20
[gen_l10n] Fix unintended use of raw string in generateString ( #69382 )
...
* Fix failing tests from introducing raw string generation in gen_l10n tool
2020-10-31 19:24:53 +08:00
Jonah Williams
324b78eb12
[null-safety] enable null safety ( #69440 )
...
* [null-safety] enable null safety
* opt expression evaluation web test out of null safety
2020-10-30 15:26:22 -07:00
Jenn Magder
de5bf09e7a
Show macOS arm64 architecture in doctor and devices list ( #69245 )
2020-10-30 13:48:04 -07:00
Jonah Williams
3e41962dff
[null-safety] update tests and tool auto-detection for null safe dart ( #69405 )
...
Disable null safety auto-detection for the web
2020-10-30 13:42:54 -07:00
Jonah Williams
22724370cb
[flutter_tools] do not delete web directory during flutter build web ( #69115 )
2020-10-30 11:00:24 -07:00
Jonah Williams
a0860f6e87
[flutter_tools] retry sever socket setup (and port selection if port is unspecified) ( #69351 )
...
Fixes #69348
If the web development server fails to bind, then retry up to 5 times. If a port was not provided, select a new free port each time.
2020-10-29 20:07:34 -07:00
Jonah Williams
44d0e52d20
[flutter_tools] remove fallback discovery and observatory timeout ( #68756 )
...
The flutter run failures are cause by the application occasionally taking a long time to start up. This caused the ios fallback discovery to kick in, which will always fail if the application hasn't started. Solution: remove the iOS fallback discovery and wait up to 30 seconds.
This has not proven to reduce the flakes, but it does at least remove one error case and removes code that will no longer work without the mDNS fallback.
2020-10-29 18:43:47 -07:00
George Wright
e48446af17
Send command line arguments through to the Flutter Engine on Windows ( #68931 )
2020-10-29 18:08:04 -07:00
George Wright
678f3cb4fb
Update Linux template app to pass through command line arguments to the Dart entrypoint ( #68535 )
2020-10-30 12:26:16 +13:00
Jonah Williams
ca47b4e12c
[flutter_tools] disable failing gen l10n test ( #69340 )
2020-10-29 15:04:46 -07:00
Angjie Li
3056f4194a
Fix issue with --web-renderer. ( #69319 )
2020-10-29 14:43:06 -07:00
Yegor
2fa03438de
add web_long_running_tests shard containing long-running web tests ( #67324 )
2020-10-29 14:23:02 -07:00
Shi-Hao Hong
7b0f38b117
Remove intl_translation from tool integration test ( #69155 )
2020-10-29 14:05:39 -07:00
Shi-Hao Hong
a2b93b86f6
[gen_l10n] Add base method code comments for improved discoverability ( #69016 )
2020-10-29 14:03:05 -07:00
Jonah Williams
470346f775
[flutter_tools] Reland: Stage web tests ( #69264 )
...
Enable web tool integration tests: expression evaluation, stepping, and basic hot restart
2020-10-29 09:56:28 -07:00
Jonah Williams
2ceb34e6fb
Revert "[flutter_tools] enable web integration tests ( #69114 )" ( #69261 )
...
This reverts commit d0cdfa4176
2020-10-28 18:22:41 -07:00
Jonah Williams
7629758ed7
[flutter_tools] measure driver success and failure ( #69226 )
...
Currently we only have a test that measures if flutter drive can fail. Unfortunately it has been failing for multiple years based on the fact that the error is due to a missing Gradle config.
Add a smoke success test case, and update both tests to use the test API and the tester-device.
2020-10-28 18:15:23 -07:00
Angjie Li
2bbd004682
Support --web-renderer options which would allow user to specify which rendering backend to use. ( #68848 )
2020-10-28 17:32:09 -07:00
Jonah Williams
ed5d8718c4
[flutter_tools] conditionally invoke pub run test for drive scripts based on presence of dependency ( #69246 )
...
* [flutter_tools] conditionally invoke pub run test for drive scripts based on presence of dependency
2020-10-28 17:32:05 -07:00
Jonah Williams
d0cdfa4176
[flutter_tools] enable web integration tests ( #69114 )
...
* [flutter_tools] stage web integration tests
2020-10-28 17:31:44 -07:00
Jonah Williams
735f6eec2c
[flutter_tools] support ws scheme in use-existing-app ( #69244 )
2020-10-28 15:09:46 -07:00
Jonah Williams
d306c37bc4
[flutter_tools] fix --use-existing-app ( #69237 )
2020-10-28 13:55:29 -07:00
Jacob MacDonald
506d0f09c0
opt out the listener.dart generated file ( #69223 )
2020-10-28 12:52:04 -07:00
Jonah Williams
8b9e9680d2
[flutter_tools] use throwToolExit in flutter drive ( #69220 )
...
* [flutter_tools] use throwToolExit
* Update drive.dart
2020-10-28 11:40:39 -07:00
Danny Tuppeny
e71655b7e9
Include VS Code + Android Studio URLs in the No IDE message ( #69194 )
2020-10-28 11:17:06 -07:00
Konstantin Scheglov
7b86be228e
Use runZonedGuarded() instead of deprecated onError. ( #69160 )
2020-10-28 08:43:31 -07:00
Jonah Williams
9e5e763ebe
[flutter_tools] document flutter root initialization ( #67884 )
...
Moves the flutter root initialization to a static method on the cache. This is a small step towards making this functionality non-static and instead injected like normal members - however, completely removing all of the static-ness at once was too large of a change.
Instead document and add unit tests and change existing code as little as possible.
#47161
2020-10-27 15:20:07 -07:00
Anurag Roy
cd690f9559
[flutter_tools] Add --verify-only flag to flutter upgrade ( #68866 )
...
* Add --verify-only flag for flutter upgrade
2020-10-27 14:06:39 -07:00
Jonah Williams
18f0a2288e
[flutter_tools] update to vm_service 5.2.0, update to dwds 7.0.0 ( #69067 )
...
Rolls in several fixes to web tooling, including better handling of absolute file imports. Updates to latest vm service to unblock null safety mode query
Co-authored-by: Gary Roumanis <grouma@google.com>
Co-authored-by: Anna Gringauze <annagrin@google.com>
2020-10-27 13:55:32 -07:00
Dan Field
36f9af3f55
reland driver vm_service migration ( #69126 )
...
* One more reland of "Driver vm service (#68654 )" (#69074 )" (#69077 )" (#69089 )"
This reverts commit e5814756a2
2020-10-27 11:30:24 -07:00
Jonah Williams
8c3d564ded
[flutter_tools] fix test expectation in resident_runner.dart ( #69121 )
2020-10-27 10:11:02 -07:00
Jonah Williams
3300a1bd68
[flutter_tools] eagerly set asset directory path, cache flutter views, simplify error handling ( #68978 )
...
Performs some small cleanup on the hot reload code path.
- Combines nested try/catch into single try catch, update on clause now that package:vm_service is used and Map does not need to be caught.
- Cache FlutterViews for the lifetime of the hot reload method handler
- Set asset directory path once during startup and remove conditional set during hot reload
2020-10-27 09:20:05 -07:00
Dan Field
e5814756a2
Revert "Revert "Revert "Driver vm service ( #68654 )" ( #69074 )" ( #69077 )" ( #69089 )
...
This reverts commit 05ab0eba19
2020-10-27 01:47:03 -07:00
Dan Field
05ab0eba19
Revert "Revert "Driver vm service ( #68654 )" ( #69074 )" ( #69077 )
...
This reverts commit 19ce7a86af
2020-10-26 19:22:25 -07:00
Jonah Williams
19ce7a86af
Revert "Driver vm service ( #68654 )" ( #69074 )
...
This reverts commit 3ecac303b4
2020-10-26 18:56:34 -07:00
Jonah Williams
6cd847c767
[flutter_tools] update test platform to use buildInfo instead of mode + additional params ( #69033 )
2020-10-26 18:50:17 -07:00
Dan Field
3ecac303b4
Driver vm service ( #68654 )
...
Migrate flutter_driver to use package:vm_service
2020-10-26 17:09:14 -07:00
Jonah Williams
e0ec9a06dc
[flutter_tools] Make ApplicationPackageFactory inject dependencies for Android Builds ( #67827 )
...
* [flutter_tools] simplication of application store logic
* maybe return null
* fix install tests
* Clean up imports
* revert windows test
* remove unused import
2020-10-26 16:51:32 -07:00
Jonah Williams
e7b66ac7ad
[flutter_tools] do not include AS validator if android is not enabled ( #69047 )
2020-10-26 15:59:00 -07:00
Jonah Williams
2e54c4a8ea
[flutter_tools] implement safe file copy with multiple fallbacks ( #69000 )
...
The tool observes a large number of unhandled exceptions during the file copy portion of flutter create. it is difficult to tell whether the permission issue is caused by the source/destination, or whether it is due to a bug in dart:io.
To work around this, implement a permission check for both the source and dest files. If either fails, the tool can exit with a more specific message.
If these checks pass, then perform the actual copy. If the copy fails, fallback to manually copying the bytes
2020-10-26 15:49:07 -07:00
Jonah Williams
8b973f01c4
[flutter_tools] add package_config.json to analyze_once_test.dart ( #69059 )
...
* [flutter_tools] add package_config.json to analyze_once_test.dart
2020-10-26 15:46:51 -07:00
Jacob MacDonald
193fe3e980
Update null safe deps to prepare for the 2.12 sdk version ( #69041 )
...
* update pinned null safety deps
* run update-packages
* add http dep to devicelab package
* rerun update-packages
2020-10-26 14:31:13 -07:00
Alexandre Ardhuin
17cdf5559d
enable unnecessary_string_escapes and use_raw_strings ( #68302 ) ( #69025 )
2020-10-26 12:42:05 -07:00
Jonah Williams
183fe75d58
[flutter_tools] reland: drive service ( #68887 )
...
Overhaul of flutter drive in order to deliver a better experience, namely:
* flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
* Removes web-initialize-platform as this is no longer used
* flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
* VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)
Web changes
* Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible
Additional NNBD related bug fixes:
No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
2020-10-26 10:11:30 -07:00
Jonah Williams
0f28edac65
[flutter_tools] null safety mode is used for dill naming ( #68898 )
...
* [flutter_tools] null safety mode is used for dill naming
* add bad test case
2020-10-23 15:39:58 -07:00
Jenn Magder
832d776b15
Stop debugger when iOS app crashes ( #68844 )
2020-10-23 14:12:04 -07:00
Jenn Magder
59544e377d
Apple silicon arch -arm64 -> -arm64e ( #68855 )
2020-10-23 13:48:38 -07:00
Jonah Williams
424ea0958b
[flutter_tools] make android deps no longer required for flutter doctor ( #68533 )
2020-10-23 12:37:04 -07:00
Jonah Williams
cb67513f29
[flutter_tools] Reland: simplify pub cache logic ( #67589 )
...
There have been some more additional reports of a missing 'package:characters' import after upgrading flutter. This has me concerned that our pub caching logic is incorrect. Instead of the tool attempting to guess when pub should be run, always delegate to pub.
Also takes an opportunity to fix the kernel snapshot depending on the .packages or package_config. Due to the generated: date field this causes extra rebuilds. Instead when pub get is run, write out an additional file with just the package contents and version.
Fixes #66777
Fixes #65723
2020-10-23 10:00:56 -07:00
Jenn Magder
351ccf7eaf
Better error message when export options plist does not a fix ( #68826 )
2020-10-22 23:28:51 -07:00
Jenn Magder
aea070790f
Turn off CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER in CocoaPod targets ( #68817 )
2020-10-22 22:02:04 -07:00
Jonah Williams
1edec6fc20
Revert "[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web ( #68451 )" ( #68845 )
...
This reverts commit 2e75f52ae4
2020-10-22 19:39:33 -07:00
Jonah Williams
2e75f52ae4
[flutter_tools] refactor drive launch into separate service, split by mobile+desktop and web ( #68451 )
...
Overhaul of flutter drive in order to deliver a better experience, namely:
flutter run and flutter drive now share more flags, so code paths that were previously only testable on run are now testable on drive.
Removes web-initialize-platform as this is no longer used
flutter drive correctly sets up a logger that shows native exceptions, by connecting to the vm service.
VM service connection now provides access to memory info without launching devtools (only for debug/profile mode)
Web changes
Passes on the one test in the repo, otherwise the webdriver code has been isolated as much as possible
Additional NNBD related bug fixes:
No longer passes --enable-experiment to the test script. (FYI @blasten ). earlier we might have assumed that the flutter gallery benchmarks would be migrated along side the app and flutter driver, but only the app under test needs to be migrated. The test scripts should never be run with the experiment.
2020-10-22 15:07:02 -07:00
Jenn Magder
f63d56e455
App.framework must support iOS 8 for older Flutter projects ( #68729 )
...
* App.framework must support iOS 8 for older Flutter projects
* Fix test
2020-10-22 13:50:54 -07:00
stuartmorgan
3ff334d68d
Add a missing include to the Linux plugin template ( #68737 )
...
The template uses strcmp (to check the received method), so should
include <cstring>
2020-10-22 13:50:39 -07:00
Jonah Williams
37470dfc0b
[devicelab] de-flake iOS launch ( #68790 )
...
* [devicelab] de-flake iOS launch
2020-10-22 13:37:57 -07:00
Jonah Williams
21ca1f9ba5
[flutter_tools] use --no-print-incremental-dependencies for non-resident and test compiles ( #68678 )
2020-10-22 13:34:59 -07:00
Jonah Williams
37042fdb08
[flutter_tools] remove iOS screenshot on failure functionality ( #68650 )
...
* [flutter_tools] remove iOS screenshot on failure functionality
* remove all screenshot code
2020-10-22 13:34:07 -07:00
Jenn Magder
f877266139
Add CocoaPods sudo installation note ( #68542 )
...
* Add CocoaPods sudo installation note
* Refer to instructions
2020-10-22 13:33:35 -07:00
Jenn Magder
04657354f5
Build IPA command ( #67781 )
...
* Build IPA command
* xcarchive -> ipa
2020-10-22 13:32:51 -07:00
Robert Ancell
16b9933d85
Disable header bar when not using GNOME Shell. ( #68452 )
...
Fixes https://github.com/flutter/flutter/issues/68253
2020-10-22 10:24:19 +13:00
Robert Ancell
b200baebd7
Try the Wayland GDK backend, the engine now supports it ( #66519 )
...
* Try the Wayland GDK backend, the engine now supports it
* Update comment from review
* Just do default GTK behaviour
2020-10-22 09:38:11 +13:00
Zachary Anderson
cbcd1321ed
Revert "enable unnecessary_string_escapes and use_raw_strings ( #68302 )" ( #68714 )
...
This reverts commit ae06c19a37
2020-10-21 08:16:13 -07:00
Alexandre Ardhuin
ae06c19a37
enable unnecessary_string_escapes and use_raw_strings ( #68302 )
2020-10-21 16:34:24 +02:00
Jenn Magder
d29cd9beb6
Clean up device logger and port forwarding on drive completion ( #68655 )
2020-10-20 16:01:51 -07:00
Jonah Williams
cb5865d86c
[flutter_tools] add some versions to tool sources, cleanup build.yaml ( #68624 )
2020-10-20 09:50:31 -07:00
Jenn Magder
d81691d0f4
Revert "Build iOS apps using Swift Packages ( #68361 )" ( #68546 )
...
This reverts commit dd9323bdfb
2020-10-19 17:57:32 -07:00
Yegor
ea3b08f333
Respond to HTTP POST requests with 404 in WebAssetServer ( #68492 )
...
* Respond to POST with 404 in WebAssetServer
2020-10-19 16:21:39 -07:00
Jenn Magder
dd9323bdfb
Build iOS apps using Swift Packages ( #68361 )
2020-10-19 15:47:04 -07:00
Jenn Magder
5e17a240bd
Generate only requested platform directories on create ( #68376 )
2020-10-19 14:17:43 -07:00
Jonah Williams
e422d5c724
[flutter_tools] reland: --no-android-gradle-daemon in devicelab ( #68491 )
...
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.
Example:
flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
2020-10-19 10:27:58 -07:00
Jonah Williams
19f363029e
[flutter_tools] increase devFS sync timeout to 60 seconds ( #68488 )
...
The current timeout is too short for some remote workflows. The existing unit test require hitting a real timeout so I've removed it.
See b/171005910
2020-10-19 10:14:37 -07:00
Jonah Williams
ed5482de19
Revert "[flutter_tools] add --android-gradle-daemon option, use in devicelab ( #68409 )" ( #68489 )
...
This reverts commit ddab72e79f
2020-10-19 09:33:52 -07:00
Jonah Williams
ddab72e79f
[flutter_tools] add --android-gradle-daemon option, use in devicelab ( #68409 )
...
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.
Example:
flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
2020-10-19 09:12:21 -07:00
Nobuhiro Tabuki
4e2f82cf93
[flutter_tools] change the IntelliJ plugin detection logic. ( #68020 )
...
This PR suggests improving the IntelliJ plugin "jar" detection logic.
Previously:
The IntelliJ Flutter plugin was contained flutter-intellij.jar.
Currently:
It is named flutter-intellij-X.Y.Z.jar and does not contain META-INF/plugin.xml.
META-INF/plugin.xml is included in flutter-idea-X.Y.Z.jar.
So this PR changes the rules for searching the plugin's jar file.
Concretely, it looks for the jar file containing META-INF/plugin.xml in the plugin's package directory and reads the package version from its META-INF/plugin.xml.
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
2020-10-19 08:19:48 -07:00
Michael Thomsen
c97ea71798
Adjust constraints ( #68437 )
2020-10-19 17:17:13 +02:00
Lau Ching Jun
583db83865
request.mainUri should be fileUri ( #68329 )
2020-10-16 15:23:54 -07:00
Jonah Williams
198e40c9eb
[flutter_tools] retry the driver launch of the application up to 3 times. ( #68334 )
...
We'd like to see how many of these flakes are transient and how many involve the device/machine getting temporarily wedged. Add a retry with no delay to see if it is possible to add sufficient error handling to startApp/installApp to handle this.
2020-10-16 15:07:23 -07:00
Lau Ching Jun
3393566b56
Use multiroot scheme for initial compilation in ResidentRunner recompile ( #68280 )
2020-10-16 10:54:19 -07:00
Jonah Williams
dd93ee301f
[flutter_tools] drive uses correct application package for prebuilt ( #68309 )
...
Both start and stop app create an application package, but only start app used the application binary. Create the application package once and pass it to both start and stop app.
2020-10-16 09:40:08 -07:00
Martin Kustermann
6fae89c8b5
Update package:stack_trace dependency to 1.10.0-nullsafety.4 ( #68132 )
2020-10-16 16:35:20 +02:00
Alexandre Ardhuin
4ce5c2713b
fix the tree ( #68277 )
2020-10-16 10:28:38 +02:00
Shi-Hao Hong
38ebc5588b
[gen_l10n] Create pubspec.yaml in ".dart_tool/flutter_gen" if it does not already exist ( #68206 )
...
* Generate pubspec.yaml for synthetic package if it did not exist prior
2020-10-16 11:34:27 +08:00
Jenn Magder
acde65d14a
Revert noninteractive lldb debugging, timeout warning ( #68245 )
2020-10-15 18:02:15 -07:00
Jonah Williams
4ce27ea0ac
[flutter_tools] update metadata detection to account for invalid yaml ( #68243 )
2020-10-15 16:51:52 -07:00
