Commit Graph

248 Commits

Author SHA1 Message Date
Dan Field
24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081)
This reverts commit 04ea3183ce.
2020-01-02 11:47:28 -08:00
Francisco Magdaleno
04ea3183ce
Revert "Add many more global analyses. (#47875)" (#48080)
This reverts commit e768c92fbc.
2020-01-02 09:25:59 -08:00
Ian Hickson
e768c92fbc
Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Francisco Magdaleno
f2f9d0e4fd
Revert "Flutter Web Driver Support (#47470)" (#47698)
This reverts commit cc1c9649c4.
2019-12-23 15:20:11 -08:00
Angjie Li
cc1c9649c4 Flutter Web Driver Support (#47470) 2019-12-19 19:53:01 -08:00
Lau Ching Jun
2df964581f
Revert "Flutter Web Driver Support (#45951)" (#47389)
This reverts commit 1ef0eadb45.
2019-12-18 17:02:31 -08:00
Angjie Li
1ef0eadb45 Flutter Web Driver Support (#45951)
* Support Flutter Driver test for Flutter Web application.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation issues.

* Support Flutter Driver test for Flutter Web application.

* Fix documentation.

* Remove unused file from dartdoc check.

* Sync to date.

* Revert change to dartdoc.

* Address comments.

* Apply suggestions from code review

Co-Authored-By: Jonah Williams <jonahwilliams@google.com>

* Update copyrights.

* Update allowed list for browsers.

* Verify command line arguments for Drive command is correctly parsed.

* Make waitUntilFirstFrameRasterized throw unimplementedError for Flutter Web Driver.

* Add comment for why sync WebDriver is used.

* Update documentations.

* Add more unit tests and update documentation.

* Configure test.dart so that web_extension_test will be executed with --platform=chrome.

* Revert unnecessary changes.

* Add new file path for Windows to blacklist.

* Reconstruct the structure of flutter_driver/test/src folder to remove filtering logic in dev/bots/test.dart/

* Fix path to web_extension_test.dart.

* Add instructions for how to use WebFlutterDriver.

* Update getLayerTree to use sendCommand instead of _sendCommand.

* Update pubspec files.
2019-12-18 10:45:39 -08:00
Jonah Williams
dfcd6568e8
re-enable build runner tooling tests (#46708) 2019-12-10 13:10:09 -08:00
Jonah Williams
bda9d90804
[flutter_tool] Reland: support --fast-start for Android applications (as an opt-in) (#46140) 2019-12-10 10:26:14 -08:00
Jonah Williams
523ac7b6f5
[flutter_tool] Always re-copy Framework/podspec when regenerating iOS module project (#45877) 2019-12-09 21:18:09 -08:00
Lau Ching Jun
c2eb0681ce
Implement screenshot test for flutter web. (#45530) 2019-12-06 14:25:39 -08:00
Shi-Hao Hong
37e66b2179
gen_l10n.dart tool testing (#44856)
* Add tests to gen_l10n.dart tool

* Separate out LocalizationsGenerator class to improve testability of code

* Add testing dependencies to dev/tools

* Integrate dev/tools testing to flutter CI

* Restructure dev/tools folder for testing

* Fix license headers
2019-12-06 11:35:08 -08:00
Jonah Williams
7f235ea8bc
Mitigation for current tool test skips on CI (#46181) 2019-12-05 23:16:25 -08:00
Jenn Magder
d01de941b9
Revert "Support --fast-start for Android applications (as an opt-in) (#45431)" (#46138)
This reverts commit 2a113165c0.
2019-12-04 18:12:57 -08:00
Jonah Williams
2a113165c0
Support --fast-start for Android applications (as an opt-in) (#45431) 2019-12-04 17:34:25 -08:00
Dan Field
088fa24463
Set the LANG when invoking cocoapods (#45710) 2019-12-02 13:26:32 -08:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Emmanuel Garcia
943f98d3c3
Add integration test for transitive plugin dependencies (#45579) 2019-11-26 08:58:43 -08:00
Todd Volkert
bae92c32e5
Disable tests that fail on non-master branches from running on those branches (#45455)
https://github.com/flutter/flutter/issues/45453
2019-11-24 22:29:28 -08:00
Greg Spencer
a60bf8e23a
Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Danny Tuppeny
927fbe5500
Re-enable asserts on Windows integration tests (#42637)
* Enable asserts

See https://github.com/flutter/flutter/issues/36476

* Remove comment
2019-11-20 17:50:37 +00:00
Jonah Williams
f20471d081 Revert "reland add lifecycle enum and fix the scheduleforcedframe (#45133)" (#45260)
This reverts commit 99324105da.

It was implicated in https://github.com/flutter/flutter/issues/45258
2019-11-20 09:43:15 -08:00
chunhtai
99324105da
reland add lifecycle enum and fix the scheduleforcedframe (#45133)
* reland add lifecycle enum and fix the scheduleforcedframe
2019-11-19 15:45:37 -08:00
chunhtai
7e1920b817
revert added lifecycle enum (#45119) 2019-11-18 13:38:47 -08:00
chunhtai
af48f71497
reland add new enum change (#45012)
This reverts commit 75f310791f.
2019-11-18 10:04:09 -08:00
Kate Lovett
7aa5b07537
Adding flutter_goldens package tests (#44479) 2019-11-15 10:29:19 -08:00
Kaushik Iska
75f310791f Revert "reland add new enum change (#44281) (#44487)" (#44947)
This reverts commit f0794917fc.
2019-11-14 16:49:43 -08:00
chunhtai
f0794917fc
reland add new enum change (#44281) (#44487)
* reland add new enum change (#44281)

This reverts commit ed82bb821c.
2019-11-14 13:27:38 -08:00
Jonah Williams
eeb88f4385
Revert "Demonstrate that artifact invalidation works (#44312)" (#44463)
This reverts commit c1d029b84f.
2019-11-08 12:44:24 -08:00
Jonah Williams
c1d029b84f
Demonstrate that artifact invalidation works (#44312) 2019-11-08 12:32:55 -08:00
Emmanuel Garcia
2c80bc973d
Flip enable-android-embedding-v2 flag (#44369) 2019-11-07 15:18:56 -08:00
xster
d2e87a5d2c
Build ios framework (#44065) 2019-11-06 14:54:15 -08:00
chunhtai
ed82bb821c
revert add new enum change (#44281) 2019-11-06 11:07:24 -08:00
chunhtai
7aebde1904
added new lifecycle state (#39945)
* added new lfecycle state

* update

* update
2019-11-05 20:03:09 -08:00
Yegor
f6eb129597
fix text tests on the web (#44021) 2019-11-05 10:05:16 -08:00
Yegor
5f6ca6838e
Enable heroes_test.dart on the web matrix (#43662) 2019-10-29 12:23:16 -07:00
Yegor
f5f24a6cd1
Enable tests that failed due to CupertinoDynamicColor (#43636) 2019-10-28 13:38:18 -07:00
Yegor
02abd00e93
Cupertino web tests (#43529)
* enable more tests after material fixes
* enable some of the Cupertino tests
2019-10-25 15:03:25 -07:00
Yegor
903ebd714d
Fix and enable most of material tests for Web (#43019) 2019-10-24 21:35:14 -07:00
Ian Hickson
45e9f657c0
ENABLE_ANDROID_EMBEDDING_V2 isn't a general thing. (#43379) 2019-10-23 17:22:07 -07:00
Emmanuel Garcia
30493a35b6
Test Gradle on Windows (#42709) 2019-10-21 16:42:46 -07:00
Ian Hickson
124dc6617f
Clean up test infrastructure (#43030)
See #41880 for history.
2019-10-18 16:35:39 -07:00
Jonah Williams
1982a5c3ec
Revert "Clean up test infrastructure (#41880)" (#42982)
This reverts commit 1781d5c9bb.
2019-10-17 19:47:16 -07:00
Ian Hickson
1781d5c9bb
Clean up test infrastructure (#41880) 2019-10-17 19:22:47 -07:00
Emmanuel Garcia
08c645b3b2
Test the Android embedding v2 (#42708)
* Test the Android embedding v2

* Update integration tests

* Split into shards
2019-10-16 21:26:10 -07:00
Yegor
86f069f1c0
Add most of the widget tests; add more web test shards (#42807) 2019-10-16 09:18:44 -07:00
Yegor
21a18fbe16
enable rendering rests on the Web (#42773) 2019-10-15 15:25:47 -07:00
Yegor
3bc3b323c4
Reland: fix and add painting web tests (#42689) 2019-10-14 21:22:44 -07:00
Yegor
163be41d80
Revert "Fix and enable painting tests on the Web (#42546)" (#42687)
This reverts commit 13a1b1e3b9. It broke the build.
2019-10-14 15:14:16 -07:00
Yegor
13a1b1e3b9
Fix and enable painting tests on the Web (#42546)
fix and enable painting tests on the Web
2019-10-14 14:34:15 -07:00