Elias Yishak
2b218fd1fc
Migrate command usage values ( #139383 )
...
Related to the tracker issue:
- https://github.com/flutter/flutter/issues/128251
This PR migrates the `Usage.command` static method that sent custom dimensions for each command (if applicable). The screenshot below shows the different places where the `usageValues` getter is overwritten to return the necessary custom dimensions for that command.
<img width="285" alt="image" src="https://github.com/flutter/flutter/assets/42216813/e32d5100-0e17-4a4d-8f21-327a8c113a19 ">
2023-12-07 16:12:03 +00:00
Aran Donohue
48eee14f0e
Support --web-header option for flutter run ( #136297 )
...
Adds support for a new --web-header option to flutter run.
Creates a workaround for https://github.com/flutter/flutter/issues/127902
This PR allows adding additional headers for the flutter run web server. This is useful to add headers like Cross-Origin-Embedder-Policy and Cross-Origin-Opener-Policy without the use of a proxy server. These headers are required enable advanced web features. This approach provides flexibility to the developer to make use of the feature as they see fit and is backward-compatible. One tradeoff is that it increases the surface area to support for future changes to the flutter web server.
https://github.com/flutter/flutter/issues/127902 is not fully addressed by this change. The solution for that task will be more opinionated. This PR creates a general-purpose workaround for anyone who needs a solution sooner while the bigger solution is developed.
2023-10-17 19:42:01 +00:00
Derek Xu
406c4dbf77
Add --trace-to-file
option to flutter run
( #135713 )
2023-10-12 13:23:52 -04:00
Jacob MacDonald
daea6e00bf
remove field override, assign to super field instead ( #135165 )
...
Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class.
Related to https://github.com/dart-lang/language/issues/3332 (discovered during investigations into the violation of that lint).
2023-09-21 22:02:12 +00:00
Michael Goderbauer
55b6f049a6
Enable unreachable_from_main lint - it is stable now!!1 ( #129854 )
...
PLUS: clean-up of all the unreachable stuff.
2023-07-06 00:09:01 +00:00
Victoria Ashworth
cd18c8c02f
Workaround for Dart VM timeout ( #127875 )
...
Workaround solution for: https://github.com/flutter/flutter/issues/121231
See https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 Error Case 2 for more information.
Sometimes the `ios-deploy` process does not return the logs from the application. We've been unable to figure out why. This is a solution to workaround that by using `idevicesyslog` alongside `ios-deploy` as a backup in getting the log for the Dart VM url. As explained in https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 , when error case 2 happens, the `idevicesyslog` does successfully find the Dart VM.
Also, in the comments of the code it mentions `syslog` is not written on iOS 13+, this was added in response to this issue: https://github.com/flutter/flutter/issues/41133 .
However, `idevicesyslog` does in fact work (at least for iOS 16), we use it to collect device logs for our CI tests already: 1dc26f80f0/dev/devicelab/lib/framework/devices.dart (L998-L1006)
2023-06-02 17:17:57 +00:00
Michael Goderbauer
5e1ba701ed
enable no_literal_bool_comparisons lint ( #126647 )
2023-05-16 16:14:23 +00:00
Victoria Ashworth
48bb3c0bc9
Use term wireless instead of network ( #124232 )
...
Rename variables, update comments, etc from `network` to `wireless` to keep it more uniform.
Also, move non-overriden messages related to device selection into the file they're used.
Part 7 in breakdown of https://github.com/flutter/flutter/pull/121262 .
2023-04-19 19:59:11 +00:00
Kevin Moore
895879c195
flutter_tools: Flutter Web CLI cleanup ( #124564 )
...
flutter_tools: Flutter Web CLI cleanup
2023-04-12 00:01:15 +00:00
Michael Goderbauer
daaa32bc06
Add CustomDimensions.commandRunIsTest ( #124135 )
2023-04-05 09:30:36 -07:00
Christopher Fujino
b2c65acd5a
[flutter_tools] Remove --no-sound-null-safety #4 ( #124039 )
...
Re-land of https://github.com/flutter/flutter/pull/123297 without any of
the commits at the end attempting to fix customer-testing.
Fixes https://github.com/flutter/flutter/issues/118810
2023-04-04 15:25:27 -07:00
Casey Hillers
6fe54f8811
Revert "[flutter_tools] Remove --no-sound-null-safety #3 " ( #123969 )
...
Revert "[flutter_tools] Remove --no-sound-null-safety #3 "
2023-04-03 00:19:22 +00:00
Chinmay Garde
f6c2b10e1a
[Impeller] Plumb through the impeller-force-gl flag. ( #123828 )
...
[Impeller] Plumb through the impeller-force-gl flag.
2023-03-31 15:13:10 +00:00
Chinmay Garde
7d31fe32f8
[Impeller] Plumb through the enable-vulkan-validation flag. ( #123808 )
...
[Impeller] Plumb through the enable-vulkan-validation flag.
2023-03-30 21:34:19 +00:00
Victoria Ashworth
fa01649a59
Update device selection to wait for wireless devices to load ( #122932 )
...
Update device selection to wait for wireless devices to load
2023-03-29 17:58:07 +00:00
Christopher Fujino
820ec70a8d
[flutter_tools] Remove --no-sound-null-safety #3 ( #123297 )
...
[flutter_tools] Remove --no-sound-null-safety #3
2023-03-29 17:56:23 +00:00
Christopher Fujino
3736274a6d
Revert "[flutter_tools] Remove sound null safety flag ( #123031 )" ( #123280 )
...
Revert "[flutter_tools] Remove sound null safety flag (#123031 )"
2023-03-22 22:53:49 +00:00
Zachary Anderson
7e88acfb0e
[flutter_tool] Adds a flag to disable Impeller ( #122960 )
2023-03-20 22:23:23 -07:00
Christopher Fujino
f4c3facfdd
Revert "Revert "[flutter_tools] Remove sound null safety flag ( #120936 )" ( #122909 )" ( #123031 )
...
[flutter_tools] Remove sound null safety flag #2
2023-03-20 22:32:07 +00:00
Christopher Fujino
f6bc147c91
Revert "[flutter_tools] Remove sound null safety flag ( #120936 )" ( #122909 )
...
This reverts commit 7c3088cf22
.
2023-03-17 11:31:48 -07:00
Christopher Fujino
7c3088cf22
[flutter_tools] Remove sound null safety flag ( #120936 )
...
[flutter_tools] Remove sound null safety flag
2023-03-17 17:48:35 +00:00
Victoria Ashworth
27248d4b64
Separate attached and wireless devices ( #122615 )
...
Separate attached and wireless devices
2023-03-15 16:35:05 +00:00
Bartek Pacia
37fc9ed260
[flutter_tools] Clean up boolArgDeprecated
and stringArgDeprecated
( #122184 )
...
[flutter_tools] Clean up `boolArgDeprecated` and `stringArgDeprecated`
2023-03-13 21:20:19 +00:00
Chris Yang
b81b1e28a3
[flutter_tool] add enable-embedder-api flag ( #121895 )
...
[flutter_tool] add enable-embedder-api flag
2023-03-03 21:13:54 +00:00
Victoria Ashworth
cc26a1aa0c
Update device filtering and introduce isConnected and connectionInterface ( #121359 )
...
Update device filtering and introduce isConnected and connectionInterface
2023-03-03 18:06:16 +00:00
Victoria Ashworth
81052a7d36
Add usage event to track when a iOS network device is used ( #118915 )
...
* Add usage event to track when a iOS network device is used
* update usage event to track percentage of iOS network vs usb devices, update and fix tests
* refactor tracking to happen in usageValues with a custom dimension
2023-01-25 10:57:12 -06:00
Jenn Magder
ada4460502
Audit covariant
usage in tool ( #116930 )
2022-12-15 11:59:34 -08:00
Jackson Gardner
db1c3e208d
Platform binaries reland ( #115502 )
...
You can now specify a --local-web-sdk flag to point to a wasm_release folder. This will make it so that only artifacts that pertain to the web sdk are overridden to point to the wasm_release folder. Other artifacts (such as impellerc) will pull from the cache, or from the --local-engine path if that is specified.
This also uses precompiled platform kernel files for both ddc and dart2js
2022-12-02 14:13:40 -08:00
Jonah Williams
8230ef5e85
Revert "[web] Add --local-web-sdk
flag and use precompiled platform kernels for dart2js and ddc ( #114639 )" ( #115242 )
...
This reverts commit 0e9ee3679c
.
2022-11-13 20:23:26 +00:00
Jackson Gardner
0e9ee3679c
[web] Add --local-web-sdk
flag and use precompiled platform kernels for dart2js and ddc ( #114639 )
...
* Dart2JS build step looks for compiled platform binaries.
* Use new locations of platform binaries.
* Added --local-web-sdk command line flag.
* Need to use the matching frontend server when doing ddc stuff.
* Update packages/flutter_tools/lib/src/test/web_test_compiler.dart
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
* Update packages/flutter_tools/lib/src/runner/flutter_command_runner.dart
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
* Formatting issues.
* Need to use URI format for platform dill.
* Fix resident runner tests.
* Fix analysis issue.
* Fix and add unit tests.
* Add some useful comments.
* Refine doc comments for flags.
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
2022-11-12 01:31:10 +00:00
Jason Simmons
f02cfd48df
Support the --no-devtools flag in "flutter run --machine" ( #113414 )
2022-10-17 16:44:15 +00:00
Lau Ching Jun
2a73ce9b50
Refactor DeviceManager.findTargetDevices()
and FlutterCommand.findAllTargetDevices()
, and add a flag to not show prompt. ( #112223 )
2022-09-23 21:10:35 +00:00
Liam Appelbe
9dbc09de1f
Null safety migration of packages/flutter_tools/test/commands.shard/hermetic, part 3/3 ( #110709 )
...
* Migrate packages/flutter_tools/test/commands.shard/hermetic, part 3/3
* Fix tests
* Chris's comment
2022-09-06 10:22:40 -07:00
Lau Ching Jun
2cfeb0d1e1
Pass device-user in machine mode ( #107747 )
2022-07-15 15:18:05 -07:00
Lau Ching Jun
5976c3702f
Check device type using platformType instead of type check to support proxied devices. ( #107618 )
2022-07-14 14:38:06 -07:00
Christopher Fujino
84c8abd0f6
[flutter_tools] catch StdinException while trying to re-set single char mode ( #107256 )
2022-07-07 22:40:05 +00:00
Christopher Fujino
d31c250e38
[flutter_tools] Fix leaky test ( #105927 )
2022-06-13 16:12:29 -07:00
Christopher Fujino
8bea63287a
[flutter_tools] add shuffle to hermetic run_tests ( #105462 )
2022-06-09 12:53:09 -07:00
Christopher Fujino
712752d2fb
[flutter_tools] return terminal to echo and line mode before exiting resident_runner ( #105283 )
2022-06-06 10:19:40 -07:00
Jenn Magder
003f2b69d2
Pass run and drive --trace-systrace for iOS ( #105321 )
2022-06-03 16:48:11 -07:00
Jenn Magder
208a418abc
flutter drive --enable-software-rendering --skia-deterministic-rendering ( #105161 )
2022-06-02 13:33:08 -07:00
Michael Goderbauer
3fa355c97d
Remove dead code in tools tests ( #104567 )
2022-05-25 12:48:17 -07:00
Christopher Fujino
09686a04c9
[flutter_tools] add --uninstall-first flag and pipe it through to ios-deploy ( #102948 )
2022-05-07 11:49:07 -07:00
Danny Tuppeny
b086473769
Pass multidex flag when using --machine mode ( #101689 )
2022-04-11 12:19:09 -07:00
Zachary Anderson
47f08a3fd6
[flutter_tool] Adds --enable-impeller flag to the run command ( #100835 )
2022-03-26 20:07:24 -07:00
Jenn Magder
a599c23b2b
Disallow running on unsupported devices ( #97338 )
2022-02-01 16:13:03 -08:00
wangying
3138cce7b2
feat: support configure a custom launch url for flutter web ( #95002 )
2022-01-18 09:50:20 -08:00
Jenn Magder
219dd6ca38
Migrate assemble and integration_test_device to null safety ( #96630 )
2022-01-14 15:50:12 -08:00
Gary Qian
02b1146cff
Reland "Exit on deprecated v1 embedding when trying to run or build" ( #92901 ) ( #93566 )
2021-11-12 15:52:32 -08:00
Yegor
24b9346c9b
Revert "Reland "Exit on deprecated v1 embedding when trying to run or build ( #92901 )" ( #93386 )" ( #93518 )
...
This reverts commit eabb7cbc34
.
It broke multiple tests.
2021-11-11 16:45:40 -08:00