Todd Volkert
2c898f6813
Remove writelnStderr ( #16058 )
...
Paying off technical debt...
2018-03-29 05:55:32 -07:00
xster
4565395693
Let iOS auto-signing tool handle Googler scenario ( #16010 )
...
* Let iOS auto-signing tool handle Googler scenario
* Forgot to update tests
2018-03-28 18:58:06 -07:00
Todd Volkert
f8058d7fb2
Make AppContext API not be prone to Future oddities ( #16034 )
...
Follow-up comments to #15984
2018-03-28 15:17:29 -07:00
Alexander Aprelev
bffae21571
Again move mockito to 300plus2 ( #15981 )
...
* Revert "Revert "Move mockito to 3.0.0-alpha. (#15949 )" (#15979 )"
This reverts commit e59651f925
.
* More thenReturn to thenAnswer when mocking Futures
* Revert "More thenReturn to thenAnswer when mocking Futures"
This reverts commit 194d2cf417
as we are reverting engine roll.
* Revert "Revert "More thenReturn to thenAnswer when mocking Futures""
This reverts commit 52c9e96b30
.
* Add dependency override
* Fix issue
2018-03-28 12:07:12 -07:00
Todd Volkert
8d11f5c763
Make AppContext immutable and race-free ( #15984 )
...
This updates AppContext per the recommendations in #15352
Fixes #15352
2018-03-28 10:58:28 -07:00
Alexander Aprelev
e59651f925
Revert "Move mockito to 3.0.0-alpha. ( #15949 )" ( #15979 )
...
This reverts commit a7e6225820
as there are failing tests.
2018-03-27 10:38:20 -07:00
Alexander Aprelev
a7e6225820
Move mockito to 3.0.0-alpha. ( #15949 )
...
* Move mockito to 3.0.0-alpha.
This is needed so it matches mockito version used internally.
* Pick up +2 for the fixes
* Fix whenReturn in fuchsia_remote_debug_protocol
* more thenReturn becomes thenAnswer
* more thenReturn becomes thenAnswer
* more thenReturn becomes thenAnswer
2018-03-27 10:05:16 -07:00
Alexandre Ardhuin
217b2bdaa1
add new lints of linter-0.1.44 and enable unnecessary_parenthesis ( #15585 )
2018-03-21 07:10:14 +01:00
Jonah Williams
ad9506d25a
Traverse dependencies and dev dependencies separately ( #15581 )
...
* traverse dependencies and dev dependencies separately
* separate dev and reg deps
* update pubspecs
* add checksum string and update transitive dep string. Add additional verify command to check checksum
* cleanup comments
* add missing space, quote, run verify-onlu from bot script
* rerun tool with fixed string
* ensure correct working directory and bump versions
* flutter not flutterRoot
2018-03-20 20:03:32 -07:00
Victor Choueiri
7edd5c8d6c
Allow null flutter schema in pubspec ( #15690 )
2018-03-19 14:55:54 -07:00
Matan Lurey
81070893be
Fix Dart2 compatibility with flutter_tools' tests. ( #15699 )
2018-03-19 11:45:44 -07:00
Jason Simmons
1c04f951c8
Warn about missing host build binaries when compiling with a local engine ( #15626 )
...
Fixes https://github.com/flutter/flutter/issues/15361
2018-03-19 11:29:20 -07:00
Alexander Aprelev
43284d70d9
Reland filesystem options support with fix for Windows test. ( #15655 )
...
* Revert "Revert "Reland pass filesystem options (#15622 )" (#15651 )"
This reverts commit 0f3eada066
.
* Fix for windows failing test
* !isEmpty -> isNotEmpty
2018-03-17 12:47:40 -07:00
Jonah Williams
298f4efc54
Fail ios workflow when simctl does not work ( #15628 )
...
* fail ios workflow when simctl does not work
* missed rename commit
* address comments
2018-03-17 10:57:51 -07:00
Alexander Aprelev
0f3eada066
Revert "Reland pass filesystem options ( #15622 )" ( #15651 )
...
This reverts commit bbcf55a5b0
as it breaks hot reload on Windows.
2018-03-17 08:11:52 -07:00
Alexander Aprelev
bbcf55a5b0
Reland pass filesystem options ( #15622 )
...
* Revert "Revert "Pass filesystem-root, filesystem-scheme options through `flutter run, build` and gradle. (#15592 )" (#15621 )"
This reverts commit c663e3367d
.
* Check whether filesystem-root is emtpy.
* Restore broken merge
* Fix windows test
* Adjust regex in test. Invalidate files by file path.
2018-03-17 06:49:15 -07:00
Vyacheslav Egorov
71b2cfb2a0
Turn Dart 2 mode by default. ( #15565 )
2018-03-16 20:29:38 +01:00
Alexander Aprelev
c663e3367d
Revert "Pass filesystem-root, filesystem-scheme options through flutter run, build
and gradle. ( #15592 )" ( #15621 )
...
This reverts commit 0f659fb10b
as it
breaks bin/tasks/gradle_plugin_test.dart.
2018-03-16 12:28:30 -07:00
Alexander Aprelev
0f659fb10b
Pass filesystem-root, filesystem-scheme options through flutter run, build
and gradle. ( #15592 )
...
* Pass filesystem-root, filesystem-scheme options through flutter run/build/gradle.
2018-03-16 11:16:54 -07:00
Alexandre Ardhuin
7667db6362
apply upcomming prefer_const_declarations ( #15498 )
2018-03-14 06:24:49 +01:00
Jonah Williams
d682259eab
Use a set to remove duplicate channel names ( #15392 )
...
* Use a set to remove duplicate channel names
* Add test for git command
2018-03-12 17:04:02 -07:00
Jason Simmons
466d15433f
Use Dart 2 camel case constants ( #15360 )
2018-03-12 11:06:32 -07:00
Jonah Williams
4ace88bfc0
fix spacing issue and add test for supportsHardwareRendering ( #15305 )
...
* fix spacing issue and add test for supportsHardwareRendering
* remove extra async tag
* move spacing to prev line
2018-03-09 09:30:13 -08:00
Todd Volkert
fffb7630c1
Give file system recording serialization a timeout. ( #15217 )
...
Some file I/O is piped from OS processes and never completes,
so without havign a timeout on the recording serialzation, we
end up waiting forever on that I/O to complete.
2018-03-07 11:39:59 -08:00
Mikkel Nygaard Ravn
0d59679624
Make Flutter tooling work on Android without Xcode being installed ( #15161 )
2018-03-07 08:41:23 +01:00
Josh Soref
c5a5945e92
Spelling ( #15229 )
...
* spelling: accommodate
* spelling: allotted
* spelling: anonymous
* spelling: artificial
* spelling: associated
* spelling: asset
* spelling: button
* spelling: canvas
* spelling: compatibility
* spelling: coverage
* spelling: condition
* spelling: decoration
* spelling: deferring
* spelling: diameter
* spelling: direction
* spelling: displacement
* spelling: dropdown
* spelling: needing
* spelling: environment
* spelling: exited
* spelling: expansion
* spelling: explore
* spelling: families
* spelling: horizontal
* spelling: increment
* spelling: indices
* spelling: internationalization
* spelling: labrador
* spelling: localizations
* spelling: midflight
* spelling: milliseconds
* spelling: minimum
* spelling: multiple
* spelling: multiplication
* spelling: navigator
* spelling: overridden
* spelling: package
* spelling: performance
* spelling: platform
* spelling: porsche
* spelling: position
* spelling: preceded
* spelling: precede
* spelling: precedence
* spelling: print
* spelling: property
* spelling: readily
* spelling: reproducibility
* spelling: rounded
* spelling: scroll
* spelling: separate
* spelling: separator
* spelling: services
* spelling: specific
* spelling: specify
* spelling: synchronously
* spelling: through
* spelling: timeout
* spelling: triangle
* spelling: trivial
* spelling: unusual
* spelling: then
* spelling: vertically
* spelling: visible
* spelling: visited
* spelling: voice
2018-03-06 21:36:03 -08:00
Alexander Markov
602e6d74b5
Pass entry points JSON files to front-end server, take 2 ( #15227 )
...
* Pass entry points JSON files to front-end server (#15180 )
* Fix ios/debug build which uses 'flutter build aot': do not require entry points files and disable AOT transformations in this mode
2018-03-06 18:45:45 -08:00
Alexander Markov
01d8e0a143
Revert "Pass entry points JSON files to front-end server" ( #15223 )
...
* Revert "Pass entry points JSON files to front-end server (#15180 )"
This reverts commit 0edea88745
.
Reason: buildbot failures on Mac.
2018-03-06 16:08:37 -08:00
Alexander Markov
0edea88745
Pass entry points JSON files to front-end server ( #15180 )
2018-03-06 14:50:22 -08:00
jcollins-g
050ee9d180
Improve robustness of --version parsing for sdkmanager ( #15029 )
2018-03-01 14:25:03 -08:00
Danny Tuppeny
db1a942479
Show 32/64bit in VS Code headings on Windows ( #15018 )
...
* Show 32/64bit in VS Code headings on Windows
Fixes #14949 .
2018-03-01 17:19:06 +00:00
Jacob Richman
7dbe9e7bcd
Fix cases where previewDart2 and trackWidgetCreation were ( #14994 )
...
accidentally missed due to named parameters being omitted.
2018-03-01 07:19:21 -08:00
jcollins-g
614df6949c
Android license detector in doctor, take two ( #14783 )
...
* Revert "Revert "Add android license verification to doctor and some refactoring" (#14727 )"
This reverts commit d260294752
.
* Add tests, fix sdkManagerEnv and use it consistently, and rearrange Status object model
* AnsiSpinner needs to leave the cursor where it found it.
* fix tests
* Const constructor warning only shows up on windows...?
* Avoid crash if we can't find the home directory
* Make pathVarSeparator return a string in the mock
* Implement review comments
* Fix out-of-order problem on stop
2018-02-28 12:09:52 -08:00
Victor Choueiri
9c895fabf2
Add intelliJ path to doctor output ( #14795 )
2018-02-27 15:19:32 -08:00
Ryan Macnak
a0ffe87bc3
Use fx get-build-dir
and fx netaddr --fuchsia
to make fuchsia_reload more convenient. ( #14854 )
2018-02-26 15:14:09 -08:00
Devon Carew
761cb82c6d
update the IntelliJ metadata templates ( #14867 )
...
* update the IntelliJ metedata templates
* fix test expectation
2018-02-26 07:38:22 -08:00
Alexander Aprelev
c3bbcb6f91
Add --preview-dart-2 to 'flutter drive' ( #14858 )
...
* Add --preview-dart-2 to 'flutter drive'
* Run driver side in --preview-dart-2 mode.
* Fix test
2018-02-24 09:28:58 -08:00
Mikkel Nygaard Ravn
681192a042
Fix test that makes assumptions about the impl of async method ( #14804 )
2018-02-21 20:47:26 +01:00
jcollins-g
ca677011f8
Fix flutter tools packages_test when run off bots ( #14692 )
...
* Fix packages tests when run off bots
* Tweak dependencies to make bots happy
* Review comment
2018-02-21 09:54:07 -08:00
Mikkel Nygaard Ravn
f526805e20
Fix of flutter packages get in plugin project ( #14757 )
2018-02-17 21:25:13 +01:00
xster
f7f1685cac
Make sure broken pod install runs triggers pod install on next flutter build ( #14753 )
2018-02-16 16:05:16 -08:00
Todd Volkert
1686b6d56d
Remove fixed asset bundles - they're no longer used. ( #14729 )
2018-02-16 10:22:52 -08:00
Alexander Aprelev
fe00598ab3
Reintroduce engineDartSdkPath artifact. ( #14742 )
...
This is needed to support running with local engine's dart sdk.
This is follow-up to https://github.com/flutter/flutter/pull/14702 .
2018-02-16 09:20:23 -08:00
Mikkel Nygaard Ravn
57779e7e01
Skip new failing test while investigating ( #14746 )
...
Merging on red tree to get back to green.
2018-02-16 12:05:37 +01:00
Mikkel Nygaard Ravn
2000435728
Move plugin injection to just after pub get ( #14743 )
2018-02-16 10:17:28 +01:00
Mikkel Nygaard Ravn
c2e1bc0322
Revert "Move plugin injection to just after pub get ( #14560 )" ( #14734 )
...
This reverts commit b3e4976ca2
.
2018-02-15 22:55:36 +01:00
Mikkel Nygaard Ravn
b3e4976ca2
Move plugin injection to just after pub get ( #14560 )
2018-02-15 22:17:12 +01:00
Todd Volkert
d260294752
Revert "Add android license verification to doctor and some refactoring" ( #14727 )
...
Reports from that commit included:
* Doctor hanging
* Doctor prompting to install JDK
* AnsiStatus.cancel() printing elapsed time and extra newline
* Printing extra spinner character at the end of each line
2018-02-15 09:13:56 -08:00
Alexander Aprelev
c0c6c60b8f
Use already downloaded dart sdk for frontend_server. ( #14702 )
...
* Use already downloaded dart sdk for frontend_server.
This is follow-up to https://github.com/flutter/flutter/pull/14610
* Remove reference to engine dart-sdk from artifacts
* Remove unused imports
* WIP to switch back to solution where dart sdk is downloaded into bin/cache/dart-sdk, but it is 'flutter precache -a' that can download all dart sdks for other platforms under bin/cache/artifacts/engine/<platform>/dart-sdk
* Download all dart sdks when 'flutter precache -a'
2018-02-15 07:29:42 -08:00
Devon Carew
53b348a50d
have flutter analyze support --preview-dart-2 ( #14582 )
...
* have flutter analyze support --preview-dart-2
* review comments
2018-02-14 16:00:29 -08:00