Michael Goderbauer
a7e3b1a35d
Clean up ignores that are not ignoring anything ( #78493 )
2021-03-19 15:32:46 -07:00
Angjie Li
6515806717
Revert "Fix a legacy TODO ( #77454 )" ( #78584 )
...
This reverts commit 5e4e530e93
2021-03-19 10:08:12 -07:00
Ian Hickson
f3c25fa07a
Align more closely with package:test ( #77118 ) ( #78343 )
2021-03-16 13:58:02 -07:00
Ian Hickson
5e4e530e93
Fix a legacy TODO ( #77454 )
2021-03-16 10:48:02 -07:00
Zachary Anderson
e7e1a04aa3
Revert "Align more closely with package:test ( #77118 )" ( #78329 )
...
This reverts commit 0cbe597540
2021-03-16 09:26:34 -07:00
Ian Hickson
0cbe597540
Align more closely with package:test ( #77118 )
2021-03-15 16:28:02 -07:00
Michael Goderbauer
d637b1874f
non-breaking changes for prefer_mixin lint ( #77837 )
2021-03-11 19:50:03 -08:00
Kate Lovett
9840d65943
Make LocalFileComparator.compare easier to override ( #77825 )
2021-03-10 12:20:04 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint ( #77434 )
2021-03-05 18:38:15 -08:00
Michael Goderbauer
807bb29888
enable prefer_function_declarations_over_variables lint ( #77398 )
2021-03-05 18:29:04 -08:00
Chris Bracken
565e48777a
Roll Engine from 299eb3e710c1 to 67abe7f9a9e4 (13 revisions) ( #77386 )
...
This is a manual roll since it requires adding a new SemanticsAction to
an element in the flutter_test SemanticsAction matchers test which was
added as part of https://github.com/flutter/engine/pull/24734 .
299eb3e710...67abe7f9a9skia-flutter-autoroll@skia.org Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter/engine#24812 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from b321d01eec78 to 4693d6d4f88e (1 revision) (flutter/engine#24811 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 835da00aa6b5 to b321d01eec78 (1 revision) (flutter/engine#24808 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter/engine#24806 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter/engine#24805 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter/engine#24804 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 1b674d73af53 to 835da00aa6b5 (1 revision) (flutter/engine#24803 )
2021-03-05 chris@bracken.jp Update cppwinrt to build 2.0.210304.5 (flutter/engine#24801 )
2021-03-05 skia-flutter-autoroll@skia.org Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter/engine#24799 )
2021-03-05 47866232+chunhtai@users.noreply.github.com Adds set text action for voice access (flutter/engine#24734 )
2021-03-04 jason-simmons@users.noreply.github.com SkParagraph: support multiple default font families (flutter/engine#24662 )
2021-03-04 skia-flutter-autoroll@skia.org Roll Clang Mac from MQQ43_LGr... to MRLGJYv8V... (flutter/engine#24794 )
2021-03-04 jason-simmons@users.noreply.github.com Allow calls to legacyMakeTypeface in the AssetFontManager (flutter/engine#24612 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2021-03-05 10:10:32 -08:00
Michael Goderbauer
ed755fba5e
Enable avoid_unnecessary_containers lint ( #77294 )
2021-03-04 15:29:03 -08:00
Michael Goderbauer
7b251f5f37
Enable use_function_type_syntax_for_parameters lint ( #77163 )
2021-03-04 08:59:17 -08:00
Greg Spencer
c6ef4c75d9
Turn on sized_box_for_whitespace lint, fix instances. ( #77099 )
2021-03-03 17:29:02 -08:00
Michael Goderbauer
0f91f0d48a
Clean-up analysis_options files ( #77098 )
2021-03-02 21:14:03 -08:00
Michael Goderbauer
0f568298d8
enable use_key_in_widget_constructors lint ( #77032 )
2021-03-02 10:14:02 -08:00
Kate Lovett
6ec9014298
Expose the diff from ComparisonResult ( #77014 )
2021-03-02 10:09:03 -08:00
Ferhat
cc9b78fc5c
[web] Treeshake keymaps for web (4% code size reduction in hello world) ( #75945 )
2021-02-25 13:26:03 -08:00
Jonah Williams
db1e9f053f
update all packages ( #76254 )
2021-02-17 17:33:56 -08:00
Jason Simmons
6757c7dd47
Use a null default skip value in testWidgets so it can inherit the group's skip flag ( #76174 )
2021-02-17 14:31:03 -08:00
Sam Rawlins
fcad4e2efe
Remove "unnecessary" imports in flutter_test ( #76157 )
2021-02-16 16:01:05 -08:00
Jonah Williams
7088c5ba2a
Update all packages ( #76143 )
2021-02-16 15:29:12 -08:00
Todd Volkert
835c7fab45
Fix FocusManager constructor ( #75894 )
...
The FocusManager constructor was registering global event handlers
on the shared RawKeyboard instance and the global pointer router.
This posed a few problems: (1) there was no way to unregister these
handlers, and (2) instantiating a second FocusManager would overwrite
the existing focus manager's RawKeyboard handler. This was manifesting
in unexpected ways, such as the fact that constructing a second
BuildOwner (for a parallel tree, for instance) was obliterating the
event handler for the main BuildOwner's focus manager, thus messing
with focus.
This change separates those global event registrations into a
dedicated method, registerGlobalHandlers(), and overrides dispose()
to properly unregister those handlers.
2021-02-12 17:19:20 -08:00
Dan Field
bc1cf49458
roll packages ( #75370 )
2021-02-04 11:41:03 -08:00
Ian Hickson
824042f9b2
Catch cases in tests where people try to tap on widgets that aren't reachable. ( #74798 )
2021-02-03 16:11:02 -08:00
Anas35
091a74dab6
removed new keyword ( #75049 )
2021-02-01 09:59:53 -08:00
Yegor
791edc230d
always pass filterQuality specified in the Image widget to canvas ( #74854 )
2021-01-28 21:54:03 -08:00
Alexandre Ardhuin
d546e1d311
fix for upcoming lint use_named_constants ( #74788 )
2021-01-27 20:20:44 +01:00
Ian Hickson
37a0189773
Don't leak exceptions thrown by message channels ( #74446 )
2021-01-27 11:19:04 -08:00
Jia Hao
8a5ace25a5
Improve performance of Widget Tests ( #70730 )
2021-01-12 17:29:03 -08:00
Ian Hickson
544a41eb55
Remove an obsolete comment from pubspec.yaml ( #73505 )
2021-01-07 15:59:04 -08:00
creativecreatorormaybenot
508c4b4d29
Correct flutter_test flutter_test_configuration.dart documentation ( #70862 )
2020-11-25 13:38:05 -08:00
Michael Goderbauer
7a3a29e71f
Fixes Intrinsics for RenderParagraph and RenderWrap ( #70656 )
2020-11-20 17:24:58 -08:00
Greg Spencer
2d836a99b6
Remove some unnecessary casts, now that changes have rolled from the engine ( #70491 )
2020-11-13 16:28:06 -08:00
Michael Goderbauer
cca1215939
Properly initialize RestorationManager in the TestBinding ( #70398 )
2020-11-12 13:59:05 -08:00
Greg Spencer
86f9ab511e
Revert usages of the binding's platformDispatcher to use window instead ( #70319 )
...
This reverts usages of the binding's platformDispatcher to use window again temporarily, because there isn't a TestPlatformDispatcher yet, and so some tests were failing because they mocked the TestWindow to return certain things (locales) that were returning the real values instead of the test values.
Once I've created a TestPlatformDispatcher to allow fake data to be passed to it, we can go back to using the platformDispatcher in all of these places
2020-11-12 11:17:00 -08:00
Greg Spencer
0937207f5b
Fix Platform channel errors in web tests ( #70252 )
2020-11-12 10:24:07 -08:00
Greg Spencer
bbc0161669
Remove references to Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow ( #69617 )
...
* Remove references to dart:ui.Window, and point usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate
* remove new test platform dispatchers
* Amend documentation
2020-11-09 15:26:29 -08:00
Zachary Anderson
e59ab90ae1
Add Dart SDK constraint to a pubspec ( #70030 )
...
This will unblock the roll of the next Dart SDK
2020-11-07 11:42:05 -08:00
Jonah Williams
6fe800abd5
[null-safety] remove enable experiment flags ( #69930 )
2020-11-05 23:58:11 -08:00
Jonah Williams
0823d625bc
[null-safety] update version constraint ( #69900 )
2020-11-05 11:39:26 -08:00
Jonah Williams
e8efde6a54
[versions] update more null safe versions ( #69892 )
2020-11-05 09:09:03 -08:00
Jason Simmons
9470a7e864
Revert "[null-safety] update Dart SDK constraints ( #69831 )" ( #69854 )
...
This reverts commit e375651cc5
2020-11-04 21:49:59 -08:00
Jonah Williams
e375651cc5
[null-safety] update Dart SDK constraints ( #69831 )
2020-11-04 16:50:24 -08:00
Jonah Williams
580cacf4bd
[versions] roll versions ( #69810 )
2020-11-04 15:38:58 -08:00
Greg Spencer
88809aa247
Standardize dartdoc macro names ( #69445 )
2020-11-02 13:28:05 -08:00
Jacob MacDonald
193fe3e980
Update null safe deps to prepare for the 2.12 sdk version ( #69041 )
...
* update pinned null safety deps
* run update-packages
* add http dep to devicelab package
* rerun update-packages
2020-10-26 14:31:13 -07:00
Alexander Brusher
099ae9b417
Re-enables tests previously failing due to new semantics flag. ( #66916 )
2020-10-22 15:32:03 -07:00
puelo
24d3999783
Generate RawKeyEvents for iOS 13.4+ ( #65193 )
...
* Added RawKeyEvent support for iOS
* Removed unused remnant
* added some missing keys
* Removed trailing whitespaces
* commit for build
* Added mapping names
* Made iOS keycodes generatable and collectable
* Fixed naming and formatting issues
* fixed raw_keyboard_test
2020-10-22 13:33:51 -07:00
Michael Goderbauer
42f3709a5a
Sound null safety for framework and flutter_test ( #68642 )
2020-10-21 10:09:11 -07:00
Greg Spencer
8c03ff8c1d
Mark keys that match a shortcut, but have no action defined as "not handled". ( #67359 )
...
- - When I added notification of key events before processing them as text, it made it so that shortcut key bindings like the spacebar would prevent spaces from being inserted into text fields, which is obviously not desirable (and so that change was reverted). At the same time, we do want to make it possible to override key events so that they can do things like intercept a tab key or arrow keys that change the focus.
This PR changes the behavior of the Shortcuts widget so that if it has a shortcut defined, but no action is bound to the intent, then instead of responding that the key is "handled", it responds as if nothing handled it. This allows the engine to continue to process the key as text entry.
This PR includes:
- Modification of the callback type for key handlers to return a KeyEventResult instead of a bool, so that we can return more information (i.e. the extra state of "stop propagation").
- Modification of the ActionDispatcher.invokeAction contract to require that Action.isEnabled return true before calling it. It will now assert if the action isn't enabled when invokeAction is called. This is to allow optimization of the number of calls to isEnabled, since the shortcuts widget now wants to know if the action was enabled before deciding to either handle the key or to return ignored.
- Modification to ShortcutManager.handleKeypress to return KeyEventResult.ignored for keys which don't have an enabled action associated with them.
- Adds an attribute to DoNothingAction that allows it to mark a key as not handled, even though it does have an action associated with it. This will allow disabling of a shortcut for a subtree.
2020-10-19 11:26:50 -07:00
Xavier Chrétien
f26fbb6bdd
Set slider semantics flag for sliders ( #68019 )
2020-10-19 08:12:03 -07:00
Alexandre Ardhuin
c0176c9ee5
use_is_even_rather_than_modulo ( #68301 )
2020-10-16 20:20:00 +02:00
Martin Kustermann
6fae89c8b5
Update package:stack_trace dependency to 1.10.0-nullsafety.4 ( #68132 )
2020-10-16 16:35:20 +02:00
Dan Field
12f54e17f4
reland List queue search optimization ( #68214 )
...
* Revert "Revert "Improve performance of collectAllElements (#68065 )" (#68207 )"
This reverts commit 46ff57d6f1
2020-10-15 13:46:50 -07:00
Jonah Williams
46ff57d6f1
Revert "Improve performance of collectAllElements ( #68065 )" ( #68207 )
...
This reverts commit 8ba5732c4c
2020-10-15 08:04:59 -07:00
Dan Field
8ba5732c4c
Improve performance of collectAllElements ( #68065 )
2020-10-14 21:32:04 -07:00
Jonah Williams
bdfb07dffd
[flutter_test] export fake from flutter_test ( #68032 )
...
Fake has been moved from mockito to test to facilitate NNBD, re-export this from flutter_test
2020-10-13 11:38:00 -07:00
Sam Rawlins
23c7ee9deb
Bump meta to 1.3.0-nullsafety.4 ( #67744 )
2020-10-12 09:50:30 -07:00
Jonah Williams
4f2fcca6a9
Reland "[null-safety] reland: migrate app side flutter driver to null-safety" ( #67570 )
2020-10-08 17:42:02 -07:00
Alexandre Ardhuin
4acc790252
enable lint cast_nullable_to_non_nullable ( #67629 )
2020-10-08 21:05:43 +02:00
Alexandre Ardhuin
0d8d4f77aa
unnecessary null comparison ( #67525 )
2020-10-08 09:26:30 +02:00
Dan Field
ad49e25a6b
Revert "[null-safety] reland: migrate app side flutter driver to null-safety ( #67441 )" ( #67561 )
...
This reverts commit d411242468
2020-10-07 13:57:49 -07:00
Jonah Williams
ef6c720d40
[flutter_test] handle breaking change to test main ( #67425 )
...
* [flutter_test] handle breaking change to test main . Fixes #67382
2020-10-06 16:52:23 -07:00
Jonah Williams
d411242468
[null-safety] reland: migrate app side flutter driver to null-safety ( #67441 )
...
Reland: #67155
Fixes analysis error caused by landing of material migration, and g3 error caused by moving of fuchsia lib.
2020-10-06 16:51:37 -07:00
Jonah Williams
4818537044
Revert "[null-safety] migrate app dependencies of flutter driver ( #67155 )" ( #67433 )
...
This reverts commit e826442ef4
2020-10-06 10:41:45 -07:00
Jonah Williams
e826442ef4
[null-safety] migrate app dependencies of flutter driver ( #67155 )
...
Ensures all of the libraries that the application side code import are migrated to null safety. full null safety migration is blocked by json rpc 2 and a breaking change to vm service client.
2020-10-06 10:30:15 -07:00
Alexandre Ardhuin
f551178408
migrate material to nullsafety ( #67166 )
...
* migrate material to nullsafety
* address review comments
* address review comments
* fix build
2020-10-06 11:36:50 +02:00
Michael Goderbauer
8998167d0f
Make FlutterErrorDetails.exception non-nullable as documented ( #67364 )
2020-10-05 18:07:02 -07:00
Ming Lyu (CareF)
277a72e3fe
move resampler to handlePointerEvent and fix complex_layout_android__scroll_smoothness with PointerEvent ( #66745 )
2020-10-05 17:17:03 -07:00
Tong Mu
2cdf2f0059
Treat hover events as normal pointer events, and bring them back to Listener ( #63834 )
2020-10-05 12:12:04 -07:00
Dan Field
2cdec25877
Reland dispose images when done ( #67100 ) ( #67177 )
...
* Reland dispose images when done (#67100 )
Changes since last time:
- Test for CanvasKit image rendering
(https://github.com/flutter/flutter/pull/67176 )
- Fix CanvasKit dispose impl
(https://github.com/flutter/engine/pull/21555 )
- Update internal google3 customer with a problematic ImageStream
Listener impl (cl/335091311, cl/335459002)
This reverts commit 473358d93d
2020-10-05 12:03:27 -07:00
Dan Field
473358d93d
Revert dispose images when done ( #67100 )
...
* Revert "docs for image disposal (#67066 )"
This reverts commit bcb2ac5a55#66688 )"
This reverts commit a7954691da
2020-10-01 16:53:50 -07:00
Michael Goderbauer
cba170fbb2
Migrate the tests of flutter_test to null-safety ( #67058 )
2020-10-01 16:27:02 -07:00
Kate Lovett
d1178ae73b
Fix local gold output for flutter/flutter ( #66139 )
2020-10-01 11:17:03 -07:00
Jacob MacDonald
b95c3d7d56
update stack_trace dep (and others) ( #67057 )
2020-10-01 09:54:07 -07:00
Dan Field
a7954691da
Dispose of images after using them ( #66688 )
...
* Dispose of images after using them
Adds ImageInfo.clone, ImageInfo.dispose, and ImageInfo.isCloneOf.
Makes all stateful holders of ui.Image objects properly clone and dispose of them.
Behavior change for ImageStreamCompleter: Removing the last listener after registering at least one listener results in the object being disposed, and new listeners cannot be added, unless a keepAlive handle is created.
Makes all non-stateful holders of ui.Image (i.e. paintImage and RawImage) assert that whoever gave the image to them has not disposed it on them.
2020-10-01 09:48:54 -07:00
Michael Goderbauer
19e07d2beb
Migrate flutter_test ( #66663 )
2020-09-30 17:03:40 -07:00
Mehmet Fidanboylu
95d72bf9d8
Clarify the docs on what scrollUntilVisible does ( #65817 )
2020-09-30 14:58:13 -07:00
Ming Lyu (CareF)
3c321ac80f
cleanup ( #66743 )
2020-09-29 15:32:03 -07:00
Alexandre Ardhuin
c2e43403af
apply upcoming lint cast_nullable_to_non_nullable ( #66455 )
...
* apply upcoming lint cast_nullable_to_non_nullable
* make RenderObjectElement.renderObject non-nullable
2020-09-27 21:29:42 +02:00
Jacob MacDonald
9cee75ba61
update to the latest null safe packages ( #66384 )
...
Updates all null safe dependencies to versions that allow 2.10 stable and 2.11 dev releases.
Also updates flutter_goldens and flutter_goldens_client to allow 2.11 dev.
2020-09-23 11:03:29 -07:00
Dan Field
7eb8447485
Allow new methods to be added to ui.Image for tests ( #65876 )
...
Remove fake image implementations, add createTestImage to flutter_test
2020-09-22 11:55:39 -07:00
Yegor
905feb7771
roll source_span 1.8.0-nullsafety.2 ( #66290 )
2020-09-21 15:02:07 -07:00
Jonah Williams
689ca09cd0
[versions] update to latest source span and roll engine to 4b8477d11573d233e6791204191c0090f733b05d ( #66136 )
2020-09-19 11:22:07 -07:00
Mouad Debbar
5024e1ea02
[web] Inform the engine when read-only flag is flipped ( #65499 )
2020-09-17 15:52:04 -07:00
Christian Mürtz
1415078828
Find text containing in tests ( #65072 )
2020-09-16 16:32:03 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. ( #65568 )
2020-09-16 14:14:06 -07:00
Tong Mu
a48e14308e
Expose GestureBinding.handlePointerEvent, replacing dispatchEvent as the preferred way to dispatch events ( #64846 )
2020-09-15 22:17:06 -07:00
Greg Spencer
199a7c1964
Fix the character field of the RawKeyEvent to hold correct data on non-Android platforms. ( #65667 )
...
This fixes a problem where the character field of the RawKeyEvent was not being set at all for non-Android platforms.
I also updated the key maps, and corrected a problem with the Windows key map where the backquote character wasn't correctly mapped.
2020-09-15 13:02:16 -07:00
Yuqian Li
e1eddb401d
Revert the revert ( #65602 )
2020-09-11 16:20:03 -07:00
Alexander Brusher
68660e127c
Disables test failing due to new semantics flag. ( #65194 )
...
This change disables a failing test prevent PR #20385 from merging.
2020-09-10 16:44:32 -07:00
Ming Lyu (CareF)
28de49e358
Revert "Reland #61998 and update complex_layout ios files ( #64885 )" ( #64990 )
...
This reverts commit df83398687
2020-08-31 18:47:08 -07:00
Ming Lyu (CareF)
df83398687
Reland #61998 and update complex_layout ios files ( #64885 )
2020-08-31 17:23:06 -07:00
Shi-Hao Hong
34541c3073
Revert "A benchmark test case for measuring scroll smoothness ( #61998 )" ( #64883 )
...
This reverts commit 12b7355da1
2020-08-30 18:42:10 +08:00
Ming Lyu (CareF)
12b7355da1
A benchmark test case for measuring scroll smoothness ( #61998 )
2020-08-29 04:28:03 -07:00
Ian Hickson
8a6a76a334
migrate rendering to nullsafety ( #64621 )
2020-08-27 16:38:10 -07:00
Jonah Williams
41e553bbfc
[flutter_tools] migrate flutter_goldens, flutter_goldens client to null-safety ( #64201 )
2020-08-24 15:31:05 -07:00
Jonah Williams
04f7c9d52e
[flutter_tools] update dwds, roll to null-safe file and process ( #64195 )
...
Update to latest dwds, file-nullsafety, and process-nullsafety for #62886
2020-08-19 16:59:52 -07:00
Greg Spencer
041a3eaa84
Standardize the nullability of arguments to raw key data constructors. ( #63523 )
...
This standardizes the handling of nullability for the LogicalKeyboardKey.keyLabel and RawKeyEventData.keyLabel accessors so that they are non-nullable, but can be empty.
Before this change, the keyLabel could be either null or an empty string to indicate that there wasn't a label, which makes it harder to test for, since both need to be checked for. Since an empty string is sufficient, there is no need for it to be nullable.
Also, in raw_keyboard.dart, the web and Windows implementations wouldn't accept null values for parameters in the Map coming from the message, but tests were supplying null for some of them. This makes web and Windows creation of events match the other platforms, and makes the migration of tests to non-nullability easier.
2020-08-19 15:03:17 -07:00
