github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
NaN Commits 822 Branches 1,017 Tags 2 GiB
3676ffe477
Commit Graph

698 Commits

Author SHA1 Message Date
Devon Carew
b6c3ae37f6 send supportsRestart flag when starting an app (#4513) 
* send supportsRestart flag when starting an app

* remove unused imports

* review comments
 2016-06-13 13:16:20 -07:00
Ian Hickson
c9bcf1074e Analyzer was confused when you deleted files (#4528) 
Also, make it clear the screen between results so it's more obvious
what's going on when you have new results (especially when you have
fixed everything).
 2016-06-13 12:20:03 -07:00
Todd Volkert
d2ee6f7838 Rename app.so -> app.dylib (#4522) 2016-06-10 16:57:21 -07:00
Devon Carew
1ff3a2a039 show progress while running the analysis server (#4525) 2016-06-10 16:39:43 -07:00
Jason Simmons
484c36f145 Set the android:debuggable flag when building an APK in debug mode (#4523) 
See https://github.com/flutter/flutter/issues/4438
 2016-06-10 16:06:12 -07:00
Devon Carew
b5c8f2a43f print stack traces from the analysis server (#4507) 2016-06-10 06:48:16 -07:00
Devon Carew
fcd68c8a21 Support route (#4470) 
* support --route in flutter run --resident

* also for the daemon app.start command
 2016-06-08 13:44:54 -07:00
Devon Carew
3ba17136b7 add a restart command to the daemon protocol (#4385) 
* refactor the --resident run option into a separate file

* update daemon to run --resident apps

* re-plumbing daemon start

* send app logs

* update tests

* review changes

* fix test runner

* remove PackageMap.createGlobalInstance; rely on the ctor

* review comments
 2016-06-07 12:13:35 -07:00
Devon Carew
6c96e1a320 use the --resident option on flutter run by default (#4386) 2016-06-06 10:29:27 -07:00
Phil Quitslund
6d2d495369 Merge pull request #4348 from pq/fix_4091 
Fix flutter analyze defaults when files are specified (#4091).
 2016-06-06 10:00:55 -07:00
Chinmay Garde
8756a094a9 Add a FLUTTER_MODE variable to the generated Xcconfig and fix snapshot generation on all targets. (#4362) 
Get rid of the DART_EXPERIMENTAL_INTERPRETER_FLAG.
 2016-06-03 13:55:57 -07:00
pq
ce82bc1b15 Check for user specified args. 2016-06-03 12:52:43 -07:00
pq
305af8b873 Fix flutter analyze defaults when files are specified (#4091). 
Disables current package and current directory analysis when files are specified.

Fixes: https://github.com/flutter/flutter/issues/4091.
 2016-06-03 09:24:54 -07:00
Jason Simmons
00c7734c8b Tools daemon handlers for discovering apps and forwarding device ports (#4324) 2016-06-02 14:00:27 -07:00
Adam Barth
612a097d1f Add --target support to flutter build ios (#4318) 
Fixes #4298
 2016-06-02 08:57:13 -07:00
Devon Carew
9e9dfc3d2d fix a race condition with isolate notification (#4286) 
* fix a race condition with isolate notification

* return a future
 2016-06-01 15:17:04 -07:00
Jason Simmons
49c4064132 Add Dart IO entry points to the snapshotter command line (#4257) 2016-05-31 10:51:28 -07:00
Devon Carew
7c47837c27 show build progress; print app sizes (#4263) 
* show build progress; print app sizes

* add todo

* review comments

* remove unused import
 2016-05-29 15:07:41 -07:00
Devon Carew
49affc4098 make the drive output prettier (#4260) 2016-05-27 22:36:07 -07:00
Devon Carew
111392d7c9 run pub get (w/ symlinks) for flutter drive (#4259) 
* run pub get (w/ symlinks) for flutter drive

* review comments
 2016-05-27 21:42:46 -07:00
Chinmay Garde
989a530350 Don't avoid linking with libSystem to work around issue in dyld. (#4241) 2016-05-27 11:24:10 -07:00
Todd Volkert
51d4ab3324 Fix install for iOS simulator, and add ability to uninstall (#4223) 2016-05-27 11:05:10 -07:00
Yegor
f544abd016 modernize flutter drive w.r.t. debug/profile/release options (#4217) 
* modernize `flutter drive` w.r.t. debug/profil/release options

* make error message prettier
 2016-05-27 10:02:36 -07:00
Devon Carew
ec7517766c Flutter run restart (#4105) 
* working on making a faster flutter run restart

* clean up todos; fire events on isolate changes

* use the Flutter.FrameworkInitialization event

* review comments
 2016-05-26 15:26:14 -07:00
Devon Carew
d6aed1e7c9 add a --quiet option to flutter_tools (#4213) 2016-05-26 13:41:29 -07:00
Devon Carew
9cfa96608c dissallow -release mode on emulators (#4204) 
* dissallow -release mode on emulators

* have the help text print the default mode
 2016-05-26 09:14:51 -07:00
Jason Simmons
5aa9a7fc53 Forward the observatory (but not the diagnostic server) when in profile mode (#4183) 2016-05-25 15:21:11 -07:00
Todd Volkert
0da58802cf Fix aot compiler and linker args 2016-05-25 14:32:57 -07:00
Adam Barth
e8e9d4633c Workaround https://github.com/dart-lang/sdk/issues/26362 (#4171) 
When building AOT, we now run `pub get` instead of printing an error telling
the user to run `pub get`. We can remove this code once the bug reference above
is fixed (should be a couple days).
 2016-05-24 16:29:13 -07:00
Adam Barth
2d726fc0c5 Build app.so instead of app.a on iOS (#4168) 
The app.a wasn't getting pulled into the main executable because we weren't
referencing any of its symbols. Instead, create a dylib that can be packaged
with the application and loaded at runtime.
 2016-05-24 15:49:53 -07:00
Adam Barth
e8a47b6d49 Add --interpreter to flutter build aot (#4159) 
This patch teaches flutter build aot to build `app.a` for use with the Dart
interpreter.
 2016-05-24 12:06:53 -07:00
Adam Barth
cb7a690815 Let flutter build aot select a target platform (#4154) 
Currently only android-arm and ios are supported target platforms.
 2016-05-24 11:21:07 -07:00
Adam Barth
f33596aacb Teach flutter to build app.a (#4141) 
On iOS, we use Xcode to build a static library that contains the precompiled
code. This code is currently unused, but it will be used by the new Xcode
harness to factor out as much complexity as possible into the flutter tool.
 2016-05-24 09:49:31 -07:00
Devon Carew
4764550f9f fail flutter analyze when there are errors (#4117) 2016-05-23 14:39:42 -07:00
Chinmay Garde
66fee3a622 Wire up ios-profile and ios-release. Switching between debug, profile and release starts the build process from scratch. (#4063) 2016-05-23 12:58:42 -07:00
Devon Carew
4962656b1d remove old command aliases (#4103) 2016-05-23 12:06:49 -07:00
Ian Hickson
10c861d6e9 Track number of pending dartdocs too (#4088) 2016-05-20 16:47:44 -07:00
Ian Hickson
94636bd206 Cleanup based on new lints (#4052) 2016-05-20 14:08:46 -07:00
Devon Carew
95f838b072 Update trace.dart (#4055) 2016-05-19 14:06:40 -07:00
Eric Seidel
880f2f785e flutter test now works on mac as well as linux 
@chinmaygarde
 2016-05-19 13:10:15 -07:00
Devon Carew
a48b063a10 rebuild when the build type changes (#4032) 
* rebuild when the build type changes

* handle local engine builds

* also check the timestamp
 2016-05-19 12:49:40 -07:00
Ian Hickson
f284c1a049 Fix tests (#3977) 
Also, make sure that broken tests actually break the bots.

And add a test to make sure that keeps happening.
 2016-05-17 12:45:37 -07:00
Jason Simmons
c192a7e4ca Replace the checked flag in DebuggingOptions with the build mode (#3901) 
This also fixes some related problems affecting "flutter run":
  * FLXes built during AndroidDevice.startApp need to match the build mode
  * APKs should always be rebuilt if the build mode uses AOT compilation
 2016-05-17 12:38:25 -07:00
Collin Jackson
b4313b04b0 Merge pull request #3946 from collinjackson/apk 
Make flutter run generate identical apks to flutter build apk
 2016-05-17 07:30:10 -07:00
Collin Jackson
a312db482d remove the add-files argument to flutter run 2016-05-16 18:33:59 -07:00
Chinmay Garde
0e8f26dd6c Use the correct host toolchain when building from a local engine checkout on Mac. (#3956) 2016-05-16 17:05:39 -07:00
Collin Jackson
00e22284f2 Fix #3891 by making flutter run generate identical apks to flutter build apk 2016-05-16 15:53:18 -07:00
Devon Carew
483922d15c allow per-command analytics suppression (#3919) 
* allow per-command analytics suppression

* rev the usage package dep
 2016-05-15 20:06:27 -07:00
Devon Carew
cc5d1adcfc handle an exit code from android n (#3914) 
* handle an exit code from android n

* review comments
 2016-05-13 16:47:30 -07:00
Yegor
15decfca6e reenable --checked option in flutter drive (#3916) 2016-05-13 16:42:28 -07:00
Devon Carew
40c0d6ea12 Consolidate observatory code (#3892) 
* rename service_protocol.dart to protocol_discovery.dart

* add a wrapper around the obs. protocol

* use json-rpc in run

* consolidate obs. code; implement flutter run --benchmark

* review comments
 2016-05-12 18:15:23 -07:00
Jason Simmons
32846de9f8 Remove ArtifactStore and move flutterRoot into Cache (#3883) 2016-05-12 15:54:35 -07:00
Jason Simmons
a590ee2671 Remove BuildConfigurations (#3879) 
Artifacts from local engine builds will be found based on the --local-engine flag
 2016-05-12 12:22:15 -07:00
Jason Simmons
0f53f7966b Remove Toolchain and extend ToolConfiguration to locate host tools such as sky_snapshot (#3870) 
Host tools can be found in the artifact cache directory for the host platform.
If a developer wants to use a local engine build instead, then provide an
--engine-build flag that selects the specific engine build variant.
 2016-05-11 15:47:26 -07:00
Devon Carew
6635f1cf9b re-enable --checked (#3857) 2016-05-11 12:26:46 -07:00
Devon Carew
826936cd33 use vendored dart sdk; check the expected version of flutter (#3831) 
* use vendored dart sdk; check the expected version of flutter

* search up directories looking for the flutter root
 2016-05-10 16:21:30 -07:00
Devon Carew
52d0434bec create a flutter setup command (#3837) 2016-05-10 15:04:29 -07:00
Devon Carew
067715e302 Send exit for flutter run --resident (#3829) 
* send ext.flutter.exit

* listen for help restart, quit

* refactor into a separate class
 2016-05-10 13:47:00 -07:00
Todd Volkert
43c0c52225 Fix regexp that strips invalid characters from the Uniform Type Identifier 
Fixes #3835
 2016-05-10 13:08:29 -07:00
Phil Quitslund
cc93170894 Merge pull request #3798 from pq/package_map_cleanup 
Analyze update to use in-memory package map.
 2016-05-09 11:53:21 -07:00
Hans Muller
74c3e74fba Call it Flutter Gallery (#3801) 2016-05-09 11:00:54 -07:00
Devon Carew
a5b198e9b9 remove the --checked option (#3799) 2016-05-09 10:58:47 -07:00
pq
46d32794f9 Analyze update to use in-memory package map. 
Updates the analyze command to pass a package map to analysis rather than a file path.

This allows us to avoid creating a needless temporary `.packages` file and host directory and saves us a trip to disk to retrieve the contents when building our URI resolvers for analysis.
 2016-05-09 09:59:16 -07:00
Jason Simmons
2ea3c9471d Fix for how flutter refresh locates the Android package manifest (#3791) 2016-05-09 09:31:46 -07:00
pq
2df43d50d3 Merge branch 'master' into analysis_rework 2016-05-06 08:58:49 -07:00
Devon Carew
bd564a02af avoid sending analytics on ci systems (#3765) 
* avoid sending analytics on ci systems

* review comments
 2016-05-05 19:51:22 -07:00
Jason Simmons
4d0e6984c2 Build tool support for Android x86 targets in 32- or 64-bit modes (#3761) 2016-05-05 16:04:22 -07:00
pq
eb215c14ac Review cleanup. 2016-05-05 15:16:27 -07:00
Devon Carew
a999366482 remove the analyze --benhcmark-expected option (#3755) 2016-05-05 14:26:21 -07:00
pq
3b882fc449 Updated arg default handling and .dartignore support. 2016-05-05 13:25:59 -07:00
pq
e808125c5b Dead code cleanup. 2016-05-05 12:35:52 -07:00
pq
a59a713f75 Analysis re-work to use analyzer APIs. 
Introduces a new Dart analysis wrapper that works directly with the analyzer API (in favor of shelling out to a separate process).

Some consequences:

  * we no longer need to fear parts (simplifying our dart file gathering)
  * we can filter by error code (when needed), rather than by error strings
  * no more IO scraping
  * no need to generate `main()` or to run with `--package-warnings`
  * we now specify an analyzer (and linter) version in the pubspec (we’ll want to make sure this doesn’t diverge too far from the analyzer shipped with the SDK but it does give us some room to play with experimental builds)
  * no more (re)scanning of error source files (and so no more source cache)
  * should generally be a bit simpler and easier to maintain
  * runs a bit faster :)
 2016-05-05 12:08:58 -07:00
Yegor
39e741dfb7 [tools] remove --flutter-repo flag in flutter test (#3728) 2016-05-04 14:08:16 -07:00
Devon Carew
f34d31717c complain on missing entries in flutter.yaml (#3731) 
* complain on missing entries in flutter.yaml

* change to a hard failure
 2016-05-04 12:33:34 -07:00
Devon Carew
1d4cda5d13 fix the benchmark file written by the analyze command (#3725) 2016-05-04 10:01:39 -07:00
Ian Hickson
961f5cd266 Fix framework-side time in profile data (#3706) 2016-05-03 14:45:22 -07:00
Collin Jackson
57d6e8514b Merge pull request #3701 from collinjackson/assets 
Support for putting assets in android/assets folder (like ios/Resources)
 2016-05-03 14:08:47 -07:00
Ian Hickson
4b6af7a42f Provide framework-only timing information (#3699) 
This makes it easier to generate charts that show the engine time and
the framework time separately.
 2016-05-03 13:51:22 -07:00
Collin Jackson
80ef81422d Support for putting assets in android/assets folder (like ios/Resources) 2016-05-03 13:32:35 -07:00
Devon Carew
c9010c91f6 fix analysis errors (#3677) 
* fix analysis errors

* review comments; fix test

* re-add an export for debugPrint
 2016-05-03 09:09:00 -07:00
Eric Seidel
f58fa766c3 Add note about explicit pub get needed. 
@devoncarew @jason-simmons
 2016-05-02 16:14:35 -07:00
Jason Simmons
30d8dc1399 Check the adb install output for errors and stop "flutter run" if package installation fails (#3672) 2016-05-02 14:11:40 -07:00
Jason Simmons
f161f239ef Download Android AOT tools to the artifacts cache and build APKs using these tools (#3649) 
Also update the engine to a build where these tools have been uplaoded
 2016-05-02 11:40:32 -07:00
Adam Barth
21f1827bad Add a sensible error message when jarsigner is missing (#3665) 
Fixes #3624
 2016-05-02 10:27:34 -07:00
Jason Simmons
01a27ca4ae Build ahead-of-time compiled snapshots and incorporate them into Android APKs (#3592) 
This currently requires a local build of the engine.

Run "flutter build aot" to build an AOT snapshot.
Run "flutter build apk --profile" to build a "profile mode" APK that uses AOT.
 2016-04-29 13:44:01 -07:00
Devon Carew
99114cd414 show more errors on missing jarsigner (#3626) 2016-04-28 22:48:01 -07:00
Yegor
81af593745 [tools] download traces only from non-resident runs (#3615) 2016-04-28 13:35:32 -07:00
Devon Carew
26ed1e71f9 simplify the analysis benchmarking code (#3588) 
* simplify the analysis benchmarking code

* review comments
 2016-04-28 10:25:26 -07:00
Yegor
c2cccc7b3b [tools] teach flutter run to get startup trace info (#3589) 2016-04-27 17:58:20 -07:00
Devon Carew
b0dca79671 Flutter run (#3553) 
* rework flutter run

* fix npe with --debug-port

* connect to obs and exit when that conneciton closes

* update todos
 2016-04-27 14:43:42 -07:00
Devon Carew
b0ebc71695 clean up git commits (#3578) 2016-04-27 10:47:52 -07:00
Devon Carew
adac927501 add google analytics to flutter_tools (#3523) 
* add google analytics

* send in the run target type

* track device type targets

* use the real GA code

* review comments

* rev to usage 2.0

* rev to 2.2.0 of usage; add tests

* review comments
 2016-04-26 16:25:11 -07:00
Devon Carew
c69f4396e3 add a benchmarking mode to flutter analyze (#3569) 
* add a benchmarking mode to flutter analyze

* change arg names
 2016-04-26 14:09:16 -07:00
Ian Hickson
b1e684ea63 Fix crash in analyzer if preamble isn't set. (#3525) 2016-04-25 11:25:29 -07:00
Devon Carew
86723ab99e Better devices text (#3519) 
* improve text for devices

* nit

* tweak text
 2016-04-25 10:14:38 -07:00
Devon Carew
ace1a64bfd don't print installing device twice (#3520) 2016-04-25 09:25:47 -07:00
Jason Simmons
cf56caa708 Add a flag to "flutter build apk" that can package additional files into the APK (#3474) 2016-04-21 16:02:08 -07:00
Devon Carew
731c5903c2 cache the source lines when running analyze (#3436) 2016-04-20 11:26:24 -07:00
Devon Carew
80fabfd3dd allow flutter create to re-gen over an existing project (#3419) 
* allow flutter create to re-gen over an existing project

* add a regression test
 2016-04-19 19:30:49 -07:00
Devon Carew
6f0bb20658 rename deploy to release (#3407) 2016-04-19 11:17:00 -07:00
Jason Simmons
8451b669c8 Collect trace data through the observatory HTTP interface (#3393) 2016-04-19 10:38:49 -07:00
Devon Carew
1c0a966384 rename the --develop option to --debug (#3384) 
* rename the --develop option to --debug

* fail if both --debug and --deploy are specified
 2016-04-18 16:41:15 -07:00
Ian Hickson
a9eddd4860 Also analyze the driver host entry points. (#3395) 2016-04-18 16:33:03 -07:00
Ian Hickson
424a6b1d6a Handle files disappearing during analysis (#3390) 2016-04-18 15:19:32 -07:00
Devon Carew
29fdc7a464 rename the --release and --debug flags (#3382) 2016-04-18 13:04:59 -07:00
Phil Quitslund
246a2cb055 Merge pull request #3375 from pq/sdk_opt 
Analyze CLI option to specify a custom Dart SDK.
 2016-04-18 09:44:05 -07:00
pq
4ff0e842e2 Analyze CLI option to specify a custom Dart SDK. 
Handy for testing against specific local SDK builds.

(Note that the option is hidden.)
 2016-04-18 09:03:31 -07:00
Devon Carew
12cac94cda Use arm deploy (#3374) 
* download android-arm-deploy

* wire up --deploy to android-arm-deploy

* fix interpolation
 2016-04-18 09:01:43 -07:00
Devon Carew
f132acaf1d use the new cache code to locate more artifacts (#3361) 
* use the new cache code to locate more artifacts

* add todo

* review comments
 2016-04-15 21:08:03 -07:00
Devon Carew
4678c12098 find all repo packages (#3368) 
* find all repo packages

* .dartignore
 2016-04-15 20:25:57 -07:00
Eric Seidel
711bf72620 Make update-packages cover dev/benchmarks. 
update-packages only looks one level down, instead of
changing that, I'm just adding dev/benchmarks explicitly.

This will unbreak the bots which are dying trying to
flutter drive dev/benchmarks/complex_layout without
pub get having been run there.

@yjbanov @devoncarew
 2016-04-15 12:35:02 -07:00
pq
de25ea22f7 Adding @optionalTypeArgs. 
With the new dev build we've got the updated linter and so can use the `@optionalTypeArgs` annotation (in `meta 0.12.0`).

Bonus: this lets us clean up one more Regexp in the `analyze` command! :)
 2016-04-14 10:03:46 -07:00
Devon Carew
b172dd5a1a run pub for analyze and test (#3310) 
* run pub for analyze and test

* don't run pub when doing repo analysis

* move logic for when to run pub into the commands

* re-write ternary expression
 2016-04-13 19:55:28 -07:00
Eric Seidel
341bd47624 Move flutter drive to use 8183 to not conflict with diagnostic server 
When @jason-simons added the diagnostic server on Android this
happened to conflict with flutter drive's usage of 8182.

We really should fix both of these port users to be dynamic
but this fixes https://github.com/flutter/flutter/issues/3291
for now.

@yjbanov
 2016-04-13 11:22:38 -07:00
Devon Carew
8849cd6b2d add a --deploy flag to build apk (#3249) 
* add a --deploy flag to build apk

* update command description

* use an enum instead of a bool param for build variants

* rename buildForDeploy flag to buildVariant

* review comments
 2016-04-12 09:21:17 -07:00
Devon Carew
b4173e20d4 fix to showing a progress display for long tasks (#3265) 2016-04-12 08:39:24 -07:00
pq
f270c3d069 Migrate enable-strict-call-checks flag to options file. 
As per https://github.com/dart-lang/sdk/issues/25723, moves last command-line flag to `.analysis_options`.
 2016-04-11 14:05:44 -07:00
Phil Quitslund
9b2d2ad9d2 Merge pull request #3245 from pq/lint_fixes 
Analyze Command lint cleanup.
 2016-04-11 13:17:59 -07:00
pq
937f0eaf12 Analyze Command lint cleanup. 
The push to dev-4 allows us to cleanup a few more bits:
  * `api_docs` lint message special casing (lint fixed)
  * `allowedIdentifiersPattern` (lint fixed)
 2016-04-11 11:18:15 -07:00
Devon Carew
2a33e3f0c0 make flutter upgrade less verbose (#3237) 
* more terse flutter upgrade

* fix an issue when updating and the engine update code has changed

* call flutter precache; add a --no-color hidden option

* fix a lint related to getters/setters
 2016-04-11 11:17:09 -07:00
Devon Carew
7ad1e38eac Fix windows crash (#3236) 
* better messaging about windows support

* fix lints
 2016-04-11 08:34:01 -07:00
stevemessick
8847b86681 Add validity checks to create (#3215) 
* Add validity checks to create

* Adjust indent
 2016-04-08 20:37:50 -07:00
Devon Carew
1311ae6ffe add a target for android-x64 (#3224) 
* add a target for android-x64

* update armeabi-v7a to x86_64
 2016-04-08 14:04:46 -07:00
Devon Carew
c00d61f6ec have flutter precache print if there's no work to do (#3213) 
* have flutter precache print if there's no work to do

* tweak precache
 2016-04-08 10:25:30 -07:00
Devon Carew
750796846c move services to using cache.dart (#3211) 2016-04-08 10:23:47 -07:00
Jason Simmons
f7b1799a62 Do not check for an existing package map if a command is going to run "pub get" to update the package map (#3202) 
Also remove a redundant check for the --pub option in the run command
 2016-04-08 09:34:42 -07:00
Adam Barth
412ce9d295 Add flutter precache (#3207) 
This command explicitly populates the flutter tool's cache of binary artifacts.
Also, teach `flutter create` to update the cache in case its the first command
that a user runs.
 2016-04-08 08:51:44 -07:00
Devon Carew
a729b02f1a move the engine download code to dart (#3180) 
* move the engine download code to dart

* fix populating the bin/cache/pkg dir
 2016-04-07 13:31:44 -07:00
Jason Simmons
9d022ed26d Add a command that can capture a Skia picture of a Flutter frame and send it to a file or skiaserve debugger (#3165) 2016-04-07 12:33:11 -07:00
Devon Carew
34a67329fd use --no-precompile (#3175) 
* use --no-precompile

* use the flutter bin cache's sdk
 2016-04-07 11:06:38 -07:00
Devon Carew
40598449ad add cache.dart to help manage the cache dir (#3168) 
* add cache.dart to help manage the cache dir

* sp
 2016-04-07 09:15:58 -07:00
Devon Carew
2383d605cd add the dart vm version to flutter doctor 
* add the dart vm version to flutter doctor

* drop the dart vm change
 2016-04-06 15:11:54 -07:00
Devon Carew
39efe4afef have flutter build emit better help text 2016-04-06 14:29:54 -07:00
Ian Hickson
798dfa2bc9 Fix analyzer warnings 
Fix some legit uses of GlobalKey to specify the type they want.



Fix some sketchy uses of GlobalKey in tests to fake it with "as

dynamic".



Remove some extraneous imports that made the build red.
 2016-04-06 14:14:34 -07:00
Chinmay Garde
b930f0d4ff Update engine and temporarily get rid of custom build directories in flutter build ios 2016-04-06 12:55:48 -07:00
Chinmay Garde
0bf68cc5cb Merge pull request #3140 from chinmaygarde/master 
Add a `--no-codesign` option to `ios build` to disable code signing.
 2016-04-06 12:33:03 -07:00
Devon Carew
e9a24510bd fast fail update-packages 2016-04-05 10:22:36 -07:00
Devon Carew
653566dd23 simplify toolchain setup 2016-04-04 13:10:56 -07:00
Ian Hickson
5291b37fc7 Track how many public Flutter members lack docs 
* Enable the lint require documentation.

* Track how many public Flutter members lack docs

* Rename the .analysis_options file

This makes Atom happier in the flutter_tools package.
 2016-04-04 12:18:13 -07:00
Jason Simmons
379c563b62 Merge pull request #3034 from jason-simmons/gradle_flx_refresh 
Support "flutter refresh" in the Gradle-based sample project
 2016-04-01 12:39:04 -07:00
Devon Carew
18d29583d0 pubspec normalization; remove den 2016-04-01 08:33:22 -07:00
Devon Carew
89143313cb Merge pull request #2981 from devoncarew/no_symlinks 
run pub with --no-package-symlinks
 2016-03-29 19:25:04 -07:00
Devon Carew
fe37825fd5 run pub with --no-package-symlinks 2016-03-29 19:02:14 -07:00
Yegor Jbanov
bfa16b2b5d [driver] fix observatory port # and timeline data extraction 
The way we pick observatory port # has changed and we have broken
logic that handles port 8181. To fix the buildbot, switch to port
8182. We can later figure out what we want to do when we clean up
port handling.

The old VM extention for extracting the timeline data is gone.
Switch to the new '_getVMTimeline' API.
 2016-03-29 13:53:40 -07:00
Devon Carew
4bdc2b872b adjust upgrade command 2016-03-29 09:41:06 -07:00
Adam Barth
055268eae5 Merge pull request #2965 from abarth/rm_analyze_regexp 
Remove two `flutter analyze` regular expressions
 2016-03-28 17:18:46 -07:00
Adam Barth
522030bdda Remove two flutter analyze regular expressions 
We can work around these in code rather than by post-processing the analyzer
output.
 2016-03-28 16:33:39 -07:00
Yegor Jbanov
28b5186746 [driver] propagate exit code from package:test 
Driver returns exit code 0 even when tests fail. This commit fixes it by
propagating the exit code set by `package:test`.
 2016-03-28 16:19:20 -07:00
Adam Barth
2e062dfab4 Use --packages rather than --package-root 
The .packages file is replacing the packages directory of symlinks.
 2016-03-28 15:01:25 -07:00
Adam Barth
3824e88df7 flutter upgrade needed twice if sky_services dependencies change 
Now we run `flutter --version` to update our local cache of packages before
running `pub upgrade`, which reads from that cache.

Fixes #2953
 2016-03-28 12:16:19 -07:00
Jason Simmons
d4bc6d5e0c Add all variants of the Roboto font as assets to Material Design apps 2016-03-28 09:53:16 -07:00
Devon Carew
15b9e1ddb0 add a screenshot command 2016-03-25 22:01:32 -07:00
Chinmay Garde
8cbeb2e983 Merge pull request #2916 from chinmaygarde/master 
Add: flutter build ios [--[no-]simulator]
 2016-03-25 15:56:51 -07:00
Chinmay Garde
66e1006193 Xcodebuild takes an extra parameter for the build directory. 2016-03-25 15:36:45 -07:00
Chinmay Garde
3f9dcfe144 Add: flutter build ios [--[no-]simulator] 
This allows the user to build an iOS application bundle from the command line even if no device is attached to the workstation.
 2016-03-25 14:17:55 -07:00
Devon Carew
2fc8e9a110 create a crash report 2016-03-25 13:29:15 -07:00
krisgiesing
cef24293b7 Merge pull request #2839 from krisgiesing/offscreen_layout 
Allow independent rendering pipelines
 2016-03-24 16:26:36 -07:00
Kris Giesing
bb5a82a726 Allow independent rendering pipelines 
Fixes #2723
 2016-03-24 14:59:21 -07:00
Alhaad Gokhale
ae7734ee12 Merge pull request #2861 from alhaad/run_mojo_with_url 
Allow run_mojo command to run an app at a URL.
 2016-03-24 10:10:31 -07:00
Alhaad Gokhale
58edc7ed9b In run_mojo, rename bundlePath -> targetApp since it may not be a path. 2016-03-24 10:01:00 -07:00
Devon Carew
25f332d8d7 re-work the doctor command 2016-03-23 21:12:29 -07:00
Alhaad Gokhale
35e30235f0 In run_mojo command, parse Uri scheme to decide whether app is on local 
filesystem or not.
 2016-03-23 19:11:04 -07:00
Alhaad Gokhale
c4da1da20c Allow run_mojo command to run an app at a URL. 
Fixes #2113
 2016-03-23 17:13:47 -07:00
Devon Carew
1d20a90cad change how we calculate the temp dir 2016-03-22 12:22:30 -07:00
Chinmay Garde
931d4be5ba Merge pull request #2821 from chinmaygarde/master 
Dont differentiate between ios_arm and ios_x64 in flutter_tools
 2016-03-21 15:02:59 -07:00
Chinmay Garde
c8377d7428 Dont differentiate between ios_arm and ios_x64 in flutter_tools 
All artifacts for iOS are universal.
 2016-03-21 14:41:26 -07:00
Devon Carew
e31395fba1 Merge pull request #2811 from devoncarew/drive_start 
don't wait for the observatory if the app didn't start
 2016-03-21 13:45:21 -07:00
pq
8b321d7de0 Remove analyze tear-off regexp. 
In the spirit of https://github.com/flutter/flutter/issues/1220, remove the tear-off regexp in favor of in-line suppressions (if needed).
 2016-03-21 11:28:11 -07:00
Devon Carew
f1cdf6df39 refactor; fix apk warning 2016-03-21 09:24:56 -07:00
Devon Carew
73d3acd5fd don't wait fot the observatory if the app didn't start 2016-03-21 09:22:53 -07:00
Ian Hickson
a7016062bc Improve flutter create help text. 2016-03-20 20:06:30 -07:00
Hixie
ce4e9cd690 Only require documentation for libraries. 2016-03-18 11:16:12 -07:00
Devon Carew
882f849ccd update listen to work w/ ios devices 2016-03-17 10:42:48 -07:00
Devon Carew
f8374cd966 consolidate build commands under the 'build' command 2016-03-17 07:22:41 -07:00
Devon Carew
8ba214daa2 minor update to flutter daemon 2016-03-15 09:27:58 -07:00
pq
370840ef1f More flutter analyze regexp cleanup 
Runs clean on the repo.  Moving ahead, we can manage exceptions via `.analysis_options` or specific source-level ignores.
 2016-03-14 15:02:55 -07:00
Hixie
797e27edd3 Add @override annotations to flutter framework 2016-03-14 14:02:26 -07:00
Adam Barth
e2744e9a30 Stop using a prebuilt APK 
Instead, require an AndroidManifest.xml and always build an APK.

Fixes #2517
 2016-03-14 13:32:00 -07:00
Ian Hickson
bedd8e9131 Merge pull request #2650 from Hixie/always_always_specify_types 
Even more types
 2016-03-14 10:44:05 -07:00
Devon Carew
5fb315141b Merge pull request #2658 from devoncarew/drive_command 
change the description of the drive command
 2016-03-14 10:27:01 -07:00
Devon Carew
d0afabc358 change the description of the drive command 2016-03-14 09:48:02 -07:00
Ian Hickson
d745e20853 Even more types 2016-03-14 09:41:54 -07:00
Devon Carew
4daee0cc0d misc tool ui cleanup 2016-03-14 09:41:00 -07:00
Devon Carew
f13314867c Merge pull request #2645 from devoncarew/platform_constants 
rename the platform constants
 2016-03-12 12:46:55 -08:00
Adam Barth
95fc5ae070 [rename fixit] *Component* -> *Widget* 
This patch renames StatelessComponent to StatelessWidget and
StatefulComponent to StatefulWidget.

Fixes #2308
 2016-03-12 12:34:05 -08:00
Devon Carew
e939b152af rename the platform constants 2016-03-12 11:08:21 -08:00
Hixie
6795efacab Enable always_specify_types lint 
And fix the zillion issues that uncovered.
 2016-03-12 00:37:31 -08:00
Ian Hickson
43b0104114 Revert "Merge pull request #2639 from Hixie/always_specify_types" 
This reverts commit f41b3411da, reversing
changes made to e33d8d9621.

This was a bad check-in due to my mangling uploading a new version of the branch from a different machine.

This reverts https://github.com/flutter/flutter/pull/2639 and will be replaced by https://github.com/flutter/flutter/pull/2640
 2016-03-12 00:34:37 -08:00
Hixie
d162d98c79 Enable always_specify_types lint 
And fix the zillion issues that uncovered.
 2016-03-11 18:27:32 -08:00
Devon Carew
29df9f5582 show the error code in flutter analyze --watch 2016-03-11 15:59:20 -08:00
pq
0aa07baf70 Migrate flutter analyze config to options. 
More groundwork to get `analyze` and IDE output to agree.

See: https://github.com/dart-lang/sdk/issues/25723
 2016-03-11 14:52:07 -08:00
Phil Quitslund
b9f28e6f75 Merge pull request #2615 from pq/analyze_cleanup 
Analyze command cleanup.
 2016-03-11 14:25:24 -08:00
Jason Simmons
68e71146a7 Run "pub get" if needed in the flutter build command 2016-03-11 14:10:42 -08:00
pq
a2dac85f87 Re-added conflictingNamesPattern. 2016-03-11 13:12:07 -08:00
Devon Carew
5ad6a57007 remove some references to DeviceStore 2016-03-11 11:25:03 -08:00
Devon Carew
94157c91e9 regenerate the i18n files 2016-03-11 10:58:30 -08:00
pq
aedef5139b Analyze command cleanup. 
Removing some special-casing in pursuit of aligning `flutter analyze` output with that provided by server/IDEs.  Specifically:
  * strong-hints (stale, no longer supported)
  * "analyzer says" comment handling in favor of `//ignore`s
  * `conflictingNamePattern` --- no longer needed

Next up some of the error filter regexps...
 2016-03-11 10:35:17 -08:00
Ian Hickson
1b9cd52081 Enable ALL THE LINTS 
Well, all the easy ones, anyway.

For some reason `// ignore:` isn't working for me so I've disabled
lints that need that. Also disabled those that require a ton of work
(which I'm doing, but not in this PR, to keep it reviewable).

This adds:
- avoid_init_to_null
- library_names
- package_api_docs
- package_names
- package_prefixed_library_names
- prefer_is_not_empty
- sort_constructors_first
- sort_unnamed_constructors_first
- unnecessary_getters_setters
 2016-03-10 23:15:31 -08:00
Devon Carew
b9fafc1765 adjust a regex for intl files 2016-03-10 14:21:23 -08:00
Devon Carew
780e4e6212 move the analysis_options to a file 2016-03-10 13:47:20 -08:00
Jason Simmons
3b5fba4022 Merge pull request #2578 from jason-simmons/flx_working_dir 
Add an option to specify a working directory for the FLX builder
 2016-03-10 12:43:35 -08:00
Eric Seidel
3e2a4d9b4d flutter run should fail if pub get fails. 
Previously we were ignoring the return code and continuing.

@devoncarew
 2016-03-10 09:36:09 -08:00
Hixie
c7339de6bc Enable always_declare_return_types lint 
And fix a zillion omissions this uncovered.
 2016-03-09 17:57:39 -08:00
Hixie
8950d3ccc4 Make flutter analyze useful for package conflicts 
Also, resolve our package conflict, since reflectable has been fixed.
 2016-03-09 17:41:05 -08:00
Hixie
5810cd80bd Avoid 'as' keyword 
It has performance implications in release mode.

We'll enable the lint once https://github.com/dart-lang/linter/issues/195 is fixed.
 2016-03-09 15:00:55 -08:00
Jason Simmons
5108a6cc58 Add an option to specify a working directory for the FLX builder 
This allows building an FLX without leaving any temporary files in the app's
source directory
 2016-03-09 14:59:40 -08:00
Alhaad Gokhale
5faf84c3fa Merge pull request #2528 from alhaad/depsfile_hook 
Add `flutter_tools build` hooks to also generate depfile.
 2016-03-09 12:29:31 -08:00
Alhaad Gokhale
b8d64ffe68 Add flutter_tools build hooks to also generate depfile. 
Fixes #1942.
 2016-03-09 11:24:47 -08:00
Devon Carew
2e9fef8c46 fix a regression in flutter logs 2016-03-09 10:48:34 -08:00
Adam Barth
e4b1eab854 Remove //examples/widgets 
Most of the remaining widget examples are actually manual tests. This patch
moves them into //dev/manual_tests. A couple are examples of using services,
which I've moved to //examples/layers/services. The remainder are out-dated and
are removed by this patch.
 2016-03-08 16:37:32 -08:00
John McCutchan
8803cecea1 Refactor DeviceLogReader 2016-03-08 10:38:22 -08:00
Devon Carew
52efc7fb68 implement --watch for flutter analyze 2016-03-07 13:46:42 -08:00
Devon Carew
b52fa986b6 fix rebase 2016-03-07 10:36:04 -08:00
Steve Messick
8cc5312054 Merge remote-tracking branch 'upstream/master' 2016-03-07 05:17:13 -08:00
Devon Carew
93b31a41df fix flutter create 2016-03-04 18:56:26 -08:00
Steve Messick
cea21fb7b1 Merge remote-tracking branch 'upstream/master' 2016-03-04 14:38:55 -08:00
Steve Messick
2e878746a3 Improve message when target not found 2016-03-04 14:36:32 -08:00
Devon Carew
c1caa26989 fix a mac test 2016-03-04 13:10:51 -08:00
Ian Hickson
047276a666 Random fixes to dartdocs, http lib, analyzer 
This is a variety of trivial fixes that I collected while going through the dartdocs.
This does contain some non-comment changes.
 2016-03-03 23:56:40 -08:00
Devon Carew
8283ce87e2 fix the stop command tests 2016-03-03 13:58:49 -08:00
Adam Barth
932b09c33a Merge pull request #2048 from abarth/test2 
Switch from hack_load_vm_file_hook to PlatformPlugin
 2016-03-03 12:11:53 -08:00
Adam Barth
96ec5316b8 Switch from hack_load_vm_file_hook to PlatformPlugin 
This patch switches us from using our previous hacking approach to integrating
with package:test to using the new PlatformPlugin interface.
 2016-03-03 11:23:36 -08:00
Devon Carew
d911aaa6d0 refactot the stop command to not use DeviceStore 2016-03-03 00:22:40 -08:00
Devon Carew
d9d94b1691 Merge pull request #2328 from devoncarew/no_dashes 
clean the project names used for flutter create
 2016-03-02 12:36:56 -08:00
Devon Carew
4c569195f1 clean the project names used for flutter create 2016-03-02 12:36:37 -08:00
Adam Barth
870894fc68 Switch Material Design icons to using the iconfont 
Rather than managing all the Material Design icons manually, we now
manage them using an icon font. The icon font contains glyphs for each
icon in an efficient vector format.

This patch updates the FLX tooling to include the MaterialIcons font and
updates the Icon widget to use the font instead of asset images.

Fixes #2313
Fixes #2218
Fixes #2009
Fixes #994
 2016-03-02 09:32:02 -08:00
Devon Carew
ebf1ecc5bd valdate project names in create 2016-03-01 11:03:59 -08:00
Yegor Jbanov
6d35481cfa add smoke driver test; find by tooltip; retry predicate 2016-02-29 16:50:47 -08:00
Devon Carew
4d93c376c9 improve verbose output 2016-02-27 23:36:02 -08:00
Devon Carew
f9adbcf23d update a todo 2016-02-27 19:56:20 -08:00
Devon Carew
d326991b97 add back a call to device.stop() from the run command 2016-02-27 19:32:02 -08:00
Devon Carew
4e10bf596c improve startup time 2016-02-27 08:19:19 -08:00
Hixie
ba918fea26 flutter analyze: handle missing files 2016-02-26 18:59:07 -08:00
Hixie
a9040433ad Handle lines getting shorter during analysis 2016-02-26 15:37:43 -08:00
Devon Carew
022047f5eb remove the isConnected() method from device 2016-02-26 13:23:48 -08:00
Devon Carew
240e499bc0 Merge pull request #2219 from devoncarew/speed_up_start 
some performance optimizations for starting apps
 2016-02-26 12:21:42 -08:00
Devon Carew
8c95500ea1 some performance optimizations for starting apps 2016-02-26 12:01:41 -08:00
Ian Hickson
c04b4c7580 Merge pull request #2206 from Hixie/analyzer-messages 
Handle conflicting 'library' identifiers
 2016-02-26 11:06:51 -08:00
Adam Barth
44ffb6f453 Merge pull request #2196 from abarth/update_packages 
Move update_packages.dart to `flutter update-packages`
 2016-02-26 11:03:48 -08:00
Hixie
a33e256ab8 Handle conflicting 'library' identifiers 
Also, handle the new directory structure of the flutter repo.
 2016-02-26 10:58:39 -08:00
Devon Carew
58f69e7f97 Merge pull request #2211 from devoncarew/flx_times 
add timing info for flx creation
 2016-02-26 10:44:45 -08:00
Yegor Jbanov
677e63b79d decouple flutter drive from flutter start 
flutter start's method of finding devices to run the app on is not suitable for flutter drive.

This commit also refactors several tool services to allow mocking in unit tests.
 2016-02-26 10:18:24 -08:00
Devon Carew
ee8f325bc0 add timing info for flx creation 2016-02-26 10:03:42 -08:00
Adam Barth
357fbf8a42 Move update_packages.dart to flutter update-packages 
Now that we don't require the Dart SDK to be in your path, it's hard to run
./dev/update_packages.dart. Instead, you can now run `flutter update-packages`.

Fixes #1906
 2016-02-25 16:27:56 -08:00
pq
fdb2819e1e Ignore errors via analysis options. 
Migrates error suppression from regexps to analysis options.
* Ignore TODOs.
* Ignore strong mode field and method overrides (see `InvalidFieldOverride` and `InvalidMethodOverride` in `strong/info.dart`.
* Remove stale regexp to capture refs to dead `dart:ui_internals` URI.
* Remove stale regexp to capture dead strong mode "will need runtime check to cast to type" error (https://github.com/dart-lang/sdk/issues/24542).

5 regexp downs, another small handful (~4) to go! :)
 2016-02-25 13:49:05 -08:00
Devon Carew
4860e63f44 Merge pull request #2153 from devoncarew/add_android_icon 
add an android icon to the starter app
 2016-02-25 00:40:49 -08:00
Devon Carew
5ee1cba149 fix a regression in the android manifest 2016-02-24 23:40:00 -08:00
Devon Carew
f57afa762f add an android icon to the starter app 2016-02-24 23:12:33 -08:00
Devon Carew
bc8e560779 run flutter doctor as part of create 2016-02-24 19:07:19 -08:00
Devon Carew
dc4830b0fa Merge pull request #2123 from devoncarew/device_commands 
additional validation for device commands
 2016-02-24 12:54:28 -08:00