Commit Graph

581 Commits

Author SHA1 Message Date
Adam Barth
bb0d11be38 Merge pull request #2646 from abarth/rename_fixit
Execute rename fixit
2016-03-12 12:41:14 -08:00
Adam Barth
95fc5ae070 [rename fixit] *Component* -> *Widget*
This patch renames StatelessComponent to StatelessWidget and
StatefulComponent to StatefulWidget.

Fixes #2308
2016-03-12 12:34:05 -08:00
Devon Carew
3ce1685d6d update comments for android abi 2016-03-12 11:47:50 -08:00
Devon Carew
79d6bf6d08 Merge pull request #2644 from devoncarew/project_creation
add an atom launch config to the starter app
2016-03-12 11:12:07 -08:00
Devon Carew
e939b152af rename the platform constants 2016-03-12 11:08:21 -08:00
Devon Carew
5b383a0353 Merge pull request #2643 from devoncarew/fix_adb_forward
fix a regression in adb forward
2016-03-12 11:00:08 -08:00
Devon Carew
ce9111b591 fix a regression in adb forward 2016-03-12 10:41:34 -08:00
Devon Carew
e67b67680b Merge pull request #2631 from devoncarew/fix_app_delete
fix a launch issue when the user has deleted the app
2016-03-12 10:34:56 -08:00
Devon Carew
6d19fd1fce add an atom launch config to the starter app 2016-03-12 07:09:07 -08:00
Hixie
6795efacab Enable always_specify_types lint
And fix the zillion issues that uncovered.
2016-03-12 00:37:31 -08:00
Ian Hickson
43b0104114 Revert "Merge pull request #2639 from Hixie/always_specify_types"
This reverts commit f41b3411da, reversing
changes made to e33d8d9621.

This was a bad check-in due to my mangling uploading a new version of the branch from a different machine.

This reverts https://github.com/flutter/flutter/pull/2639 and will be replaced by https://github.com/flutter/flutter/pull/2640
2016-03-12 00:34:37 -08:00
Hixie
d162d98c79 Enable always_specify_types lint
And fix the zillion issues that uncovered.
2016-03-11 18:27:32 -08:00
Devon Carew
f3dc82abda Merge pull request #2616 from devoncarew/show_error_code
show the error codes in flutter analyze --watch
2016-03-11 16:01:41 -08:00
Ian Hickson
1d8117e2d0 Merge pull request #2625 from Hixie/conflictingNamePattern
flutter analyze test
2016-03-11 15:59:25 -08:00
Devon Carew
29df9f5582 show the error code in flutter analyze --watch 2016-03-11 15:59:20 -08:00
Devon Carew
ad7a666a3e fix a launch issue when the user has deleted the app 2016-03-11 15:44:24 -08:00
pq
0aa07baf70 Migrate flutter analyze config to options.
More groundwork to get `analyze` and IDE output to agree.

See: https://github.com/dart-lang/sdk/issues/25723
2016-03-11 14:52:07 -08:00
Hixie
e6b82b6fa9 flutter analyze test
Test that flutter analyze catches no error if two imported libraries
have the same name.

Also, make tests know how to find the flutter root and fix style in one
test to be consistent with the rest of the file.
2016-03-11 14:26:38 -08:00
Phil Quitslund
b9f28e6f75 Merge pull request #2615 from pq/analyze_cleanup
Analyze command cleanup.
2016-03-11 14:25:24 -08:00
Jason Simmons
68e71146a7 Run "pub get" if needed in the flutter build command 2016-03-11 14:10:42 -08:00
pq
a2dac85f87 Re-added conflictingNamesPattern. 2016-03-11 13:12:07 -08:00
Devon Carew
5ad6a57007 remove some references to DeviceStore 2016-03-11 11:25:03 -08:00
Devon Carew
94157c91e9 regenerate the i18n files 2016-03-11 10:58:30 -08:00
pq
aedef5139b Analyze command cleanup.
Removing some special-casing in pursuit of aligning `flutter analyze` output with that provided by server/IDEs.  Specifically:
  * strong-hints (stale, no longer supported)
  * "analyzer says" comment handling in favor of `//ignore`s
  * `conflictingNamePattern` --- no longer needed

Next up some of the error filter regexps...
2016-03-11 10:35:17 -08:00
John McCutchan
5e140b7533 Add DevicePortForwarder with adb fix 2016-03-11 09:26:17 -08:00
Ian Hickson
1b9cd52081 Enable ALL THE LINTS
Well, all the easy ones, anyway.

For some reason `// ignore:` isn't working for me so I've disabled
lints that need that. Also disabled those that require a ton of work
(which I'm doing, but not in this PR, to keep it reviewable).

This adds:
- avoid_init_to_null
- library_names
- package_api_docs
- package_names
- package_prefixed_library_names
- prefer_is_not_empty
- sort_constructors_first
- sort_unnamed_constructors_first
- unnecessary_getters_setters
2016-03-10 23:15:31 -08:00
Devon Carew
83caeb35ed Merge pull request #2584 from devoncarew/redux_analysis_options
move the analysis_options to a file
2016-03-10 14:37:58 -08:00
Eric Seidel
37f0b5dd98 Revert "Add DevicePortForwarder" 2016-03-10 14:23:39 -08:00
Devon Carew
b9fafc1765 adjust a regex for intl files 2016-03-10 14:21:23 -08:00
Yegor
96db7c0a5a Merge pull request #2580 from yjbanov/lower-xcode-version-requirement
[ios] reduce xcode version requirement to 7.0
2016-03-10 14:08:48 -08:00
Devon Carew
780e4e6212 move the analysis_options to a file 2016-03-10 13:47:20 -08:00
John McCutchan
5fcaebbf51 Merge pull request #2506 from johnmccutchan/device_port_forward
Add DevicePortForwarder
2016-03-10 13:23:40 -08:00
Yegor Jbanov
23e634a613 [ios] reduce xcode version requirement to 7.0
Build bots only have 7.0.
2016-03-10 13:08:58 -08:00
John McCutchan
131359f4bc Add DevicePortForwarder 2016-03-10 12:49:07 -08:00
Jason Simmons
3b5fba4022 Merge pull request #2578 from jason-simmons/flx_working_dir
Add an option to specify a working directory for the FLX builder
2016-03-10 12:43:35 -08:00
Yegor
c2b175d1db Merge pull request #2575 from yjbanov/ios-device-discovery
[ios] look for the best available devicetype/runtime when booting
2016-03-10 11:25:56 -08:00
Yegor Jbanov
9383466dd5 [ios] look for the best available devicetype/runtime when booting 2016-03-10 11:04:02 -08:00
Eric Seidel
3e2a4d9b4d flutter run should fail if pub get fails.
Previously we were ignoring the return code and continuing.

@devoncarew
2016-03-10 09:36:09 -08:00
Hixie
c7339de6bc Enable always_declare_return_types lint
And fix a zillion omissions this uncovered.
2016-03-09 17:57:39 -08:00
Hixie
8950d3ccc4 Make flutter analyze useful for package conflicts
Also, resolve our package conflict, since reflectable has been fixed.
2016-03-09 17:41:05 -08:00
Hixie
5810cd80bd Avoid 'as' keyword
It has performance implications in release mode.

We'll enable the lint once https://github.com/dart-lang/linter/issues/195 is fixed.
2016-03-09 15:00:55 -08:00
Jason Simmons
5108a6cc58 Add an option to specify a working directory for the FLX builder
This allows building an FLX without leaving any temporary files in the app's
source directory
2016-03-09 14:59:40 -08:00
Alhaad Gokhale
5faf84c3fa Merge pull request #2528 from alhaad/depsfile_hook
Add `flutter_tools build` hooks to also generate depfile.
2016-03-09 12:29:31 -08:00
Alhaad Gokhale
b8d64ffe68 Add flutter_tools build hooks to also generate depfile.
Fixes #1942.
2016-03-09 11:24:47 -08:00
Devon Carew
2e9fef8c46 fix a regression in flutter logs 2016-03-09 10:48:34 -08:00
Devon Carew
ee5c5970dc fix npe in lastLogcatTimestamp 2016-03-08 19:04:49 -08:00
Adam Barth
e4b1eab854 Remove //examples/widgets
Most of the remaining widget examples are actually manual tests. This patch
moves them into //dev/manual_tests. A couple are examples of using services,
which I've moved to //examples/layers/services. The remainder are out-dated and
are removed by this patch.
2016-03-08 16:37:32 -08:00
John McCutchan
9cb7001a39 Add ServiceProtocolDiscovery 2016-03-08 15:13:48 -08:00
John McCutchan
8803cecea1 Refactor DeviceLogReader 2016-03-08 10:38:22 -08:00
Devon Carew
52efc7fb68 implement --watch for flutter analyze 2016-03-07 13:46:42 -08:00
Devon Carew
b52fa986b6 fix rebase 2016-03-07 10:36:04 -08:00
Steve Messick
913315bc87 Improve the error message when a target is specified but not found.
https://github.com/flutter/flutter/issues/2368
2016-03-07 08:53:33 -08:00
Steve Messick
8cc5312054 Merge remote-tracking branch 'upstream/master' 2016-03-07 05:17:13 -08:00
Devon Carew
93b31a41df fix flutter create 2016-03-04 18:56:26 -08:00
Steve Messick
cea21fb7b1 Merge remote-tracking branch 'upstream/master' 2016-03-04 14:38:55 -08:00
Steve Messick
2e878746a3 Improve message when target not found 2016-03-04 14:36:32 -08:00
Devon Carew
c1caa26989 fix a mac test 2016-03-04 13:10:51 -08:00
Ian Hickson
047276a666 Random fixes to dartdocs, http lib, analyzer
This is a variety of trivial fixes that I collected while going through the dartdocs.
This does contain some non-comment changes.
2016-03-03 23:56:40 -08:00
Yegor Jbanov
e69f6562ed [ios] use xcrun to launch simulator instead of hardcoded path 2016-03-03 16:58:16 -08:00
Yegor Jbanov
58b2c630ab [ios] generate flx on first ios launch 2016-03-03 16:10:03 -08:00
Devon Carew
6ab1ff3511 Merge pull request #2398 from devoncarew/fix_zip
fix the zip tool when building for ios
2016-03-03 15:28:33 -08:00
Devon Carew
361893b180 fix the zip tool when building for ios 2016-03-03 15:18:32 -08:00
Devon Carew
f68d86dab2 show stdout on xcode failures 2016-03-03 15:10:45 -08:00
Devon Carew
8283ce87e2 fix the stop command tests 2016-03-03 13:58:49 -08:00
Adam Barth
932b09c33a Merge pull request #2048 from abarth/test2
Switch from hack_load_vm_file_hook to PlatformPlugin
2016-03-03 12:11:53 -08:00
Devon Carew
6868d24f37 Merge pull request #2380 from devoncarew/atom_validation
Atom validation
2016-03-03 12:10:30 -08:00
Devon Carew
e1f476b6d0 Merge pull request #2378 from devoncarew/refactor_stop
refactor the stop command to not use DeviceStore
2016-03-03 12:06:57 -08:00
Devon Carew
c54d54b7be improve the atom validation 2016-03-03 12:06:30 -08:00
Adam Barth
96ec5316b8 Switch from hack_load_vm_file_hook to PlatformPlugin
This patch switches us from using our previous hacking approach to integrating
with package:test to using the new PlatformPlugin interface.
2016-03-03 11:23:36 -08:00
Devon Carew
d911aaa6d0 refactot the stop command to not use DeviceStore 2016-03-03 00:22:40 -08:00
Devon Carew
0fb288c575 refactor to move an ios specific class out of globals.dart 2016-03-02 21:14:11 -08:00
Eric Seidel
e802858b49 Merge pull request #2329 from chinmaygarde/master
iOS Simulator: Attempt 'sideloading' the updated Flutter application if the application runner is already up
2016-03-02 13:06:27 -08:00
Devon Carew
d9d94b1691 Merge pull request #2328 from devoncarew/no_dashes
clean the project names used for flutter create
2016-03-02 12:36:56 -08:00
Devon Carew
4c569195f1 clean the project names used for flutter create 2016-03-02 12:36:37 -08:00
Chinmay Garde
9f4fdcb866 iOS Simulator: Attempt 'sideloading' the updated Flutter application if the application runner is already up
* This makes the turnaround times < 2 seconds on the iOS simulator.
* Also bumps the engine to use the new engine required to support the flags.
2016-03-02 11:40:10 -08:00
Adam Barth
870894fc68 Switch Material Design icons to using the iconfont
Rather than managing all the Material Design icons manually, we now
manage them using an icon font. The icon font contains glyphs for each
icon in an efficient vector format.

This patch updates the FLX tooling to include the MaterialIcons font and
updates the Icon widget to use the font instead of asset images.

Fixes #2313
Fixes #2218
Fixes #2009
Fixes #994
2016-03-02 09:32:02 -08:00
Devon Carew
ebf1ecc5bd valdate project names in create 2016-03-01 11:03:59 -08:00
Adam Barth
bf97313afb Merge pull request #2276 from abarth/detached_head
Flutter --version can't handle detached HEAD
2016-02-29 17:08:14 -08:00
Yegor Jbanov
6d35481cfa add smoke driver test; find by tooltip; retry predicate 2016-02-29 16:50:47 -08:00
Adam Barth
18a2525fc8 Flutter --version can't handle detached HEAD
Handle this error condition better and tweak some of the formating for the
version string.

Fixes #2162
2016-02-29 16:25:44 -08:00
Adam Barth
ad718a8d1e Teach flutter logs to show only new logs
After this patch, the flutter logs command on Android shows only log messages
since the command was run. Previously, it showed historical logs, which was
confusing.

Fixes #2013
2016-02-29 12:05:07 -08:00
Devon Carew
4d93c376c9 improve verbose output 2016-02-27 23:36:02 -08:00
Devon Carew
f9adbcf23d update a todo 2016-02-27 19:56:20 -08:00
Devon Carew
d326991b97 add back a call to device.stop() from the run command 2016-02-27 19:32:02 -08:00
Devon Carew
4e10bf596c improve startup time 2016-02-27 08:19:19 -08:00
Hixie
ba918fea26 flutter analyze: handle missing files 2016-02-26 18:59:07 -08:00
Hixie
a9040433ad Handle lines getting shorter during analysis 2016-02-26 15:37:43 -08:00
Devon Carew
022047f5eb remove the isConnected() method from device 2016-02-26 13:23:48 -08:00
Devon Carew
240e499bc0 Merge pull request #2219 from devoncarew/speed_up_start
some performance optimizations for starting apps
2016-02-26 12:21:42 -08:00
Devon Carew
8c95500ea1 some performance optimizations for starting apps 2016-02-26 12:01:41 -08:00
Ian Hickson
c04b4c7580 Merge pull request #2206 from Hixie/analyzer-messages
Handle conflicting 'library' identifiers
2016-02-26 11:06:51 -08:00
Adam Barth
44ffb6f453 Merge pull request #2196 from abarth/update_packages
Move update_packages.dart to `flutter update-packages`
2016-02-26 11:03:48 -08:00
Hixie
a33e256ab8 Handle conflicting 'library' identifiers
Also, handle the new directory structure of the flutter repo.
2016-02-26 10:58:39 -08:00
Devon Carew
58f69e7f97 Merge pull request #2211 from devoncarew/flx_times
add timing info for flx creation
2016-02-26 10:44:45 -08:00
Devon Carew
9c9bda23bb string interpolation 2016-02-26 10:22:54 -08:00
Yegor Jbanov
677e63b79d decouple flutter drive from flutter start
flutter start's method of finding devices to run the app on is not suitable for flutter drive.

This commit also refactors several tool services to allow mocking in unit tests.
2016-02-26 10:18:24 -08:00
Devon Carew
ee8f325bc0 add timing info for flx creation 2016-02-26 10:03:42 -08:00
Adam Barth
357fbf8a42 Move update_packages.dart to flutter update-packages
Now that we don't require the Dart SDK to be in your path, it's hard to run
./dev/update_packages.dart. Instead, you can now run `flutter update-packages`.

Fixes #1906
2016-02-25 16:27:56 -08:00
Phil Quitslund
ba7c992861 Merge pull request #2180 from flutter/error_codes
Ignore `flutter analyze` errors via analysis options.
2016-02-25 14:03:38 -08:00
pq
fdb2819e1e Ignore errors via analysis options.
Migrates error suppression from regexps to analysis options.
* Ignore TODOs.
* Ignore strong mode field and method overrides (see `InvalidFieldOverride` and `InvalidMethodOverride` in `strong/info.dart`.
* Remove stale regexp to capture refs to dead `dart:ui_internals` URI.
* Remove stale regexp to capture dead strong mode "will need runtime check to cast to type" error (https://github.com/dart-lang/sdk/issues/24542).

5 regexp downs, another small handful (~4) to go! :)
2016-02-25 13:49:05 -08:00