Commit Graph

900 Commits

Author SHA1 Message Date
Chinmay Garde
915f24866a Change bucket names for iOS and Mac based on buildbot updates. (#3863) 2016-05-11 13:41:44 -07:00
Devon Carew
6635f1cf9b re-enable --checked (#3857) 2016-05-11 12:26:46 -07:00
Jason Simmons
82dbd43e74 Fix the paths for local engine builds targeting the host platform (#3855) 2016-05-11 11:11:34 -07:00
Collin Jackson
e2ab858202 Fix #3825 crash installing onto certain Android devices 2016-05-11 09:32:35 -07:00
Devon Carew
826936cd33 use vendored dart sdk; check the expected version of flutter (#3831)
* use vendored dart sdk; check the expected version of flutter

* search up directories looking for the flutter root
2016-05-10 16:21:30 -07:00
Phil Quitslund
eec3fc60f1 Merge pull request #3838 from pq/sdk_summaries
Turn on SDK summaries in flutter analyze.
2016-05-10 15:22:33 -07:00
Devon Carew
52d0434bec create a flutter setup command (#3837) 2016-05-10 15:04:29 -07:00
pq
a8f96de47d Removed unused import. 2016-05-10 14:37:39 -07:00
pq
d11651d293 Turn on SDK summaries in flutter analyze.
The latest dev build has stable summaries so we should start using them.

(Also ensures that analysis options are propogating to the SDK analysis context --- see:  https://github.com/dart-lang/sdk/issues/26129.)
2016-05-10 14:31:00 -07:00
Devon Carew
067715e302 Send exit for flutter run --resident (#3829)
* send ext.flutter.exit

* listen for help restart, quit

* refactor into a separate class
2016-05-10 13:47:00 -07:00
Todd Volkert
810b3e32a6 Fix regexp that strips invalid characters from the project identifier
Fixes #3835
2016-05-10 13:24:20 -07:00
Todd Volkert
43c0c52225 Fix regexp that strips invalid characters from the Uniform Type Identifier
Fixes #3835
2016-05-10 13:08:29 -07:00
Jason Simmons
6ab77622e4 Update flutter_tools for the "unoptimized" engine build flag and the new output directory naming scheme (#3832) 2016-05-10 12:02:09 -07:00
pq
18d971d492 Remove gratuitous pub resolver from flutter analysis.
Package mapping is already done by the `PackageDependencyTracker` so this extra check is at best not needed.  (At worst could cause an unneeded and costly call to `pub list-package-dirs`!)
2016-05-09 12:21:18 -07:00
Phil Quitslund
cc93170894 Merge pull request #3798 from pq/package_map_cleanup
Analyze update to use in-memory package map.
2016-05-09 11:53:21 -07:00
pq
1e50745df3 Constructor ordering. 2016-05-09 11:33:52 -07:00
Hans Muller
74c3e74fba Call it Flutter Gallery (#3801) 2016-05-09 11:00:54 -07:00
Devon Carew
a5b198e9b9 remove the --checked option (#3799) 2016-05-09 10:58:47 -07:00
pq
46d32794f9 Analyze update to use in-memory package map.
Updates the analyze command to pass a package map to analysis rather than a file path.

This allows us to avoid creating a needless temporary `.packages` file and host directory and saves us a trip to disk to retrieve the contents when building our URI resolvers for analysis.
2016-05-09 09:59:16 -07:00
Jason Simmons
2ea3c9471d Fix for how flutter refresh locates the Android package manifest (#3791) 2016-05-09 09:31:46 -07:00
Jason Simmons
09dde8718b Change the Android activity launch mode to singleTop (#3792) 2016-05-09 09:31:34 -07:00
pq
c973629ed7 Fixed braces. 2016-05-06 13:43:21 -07:00
pq
96de7c4dcc Fix analyzer error messages.
Will have the result of restoring `[static warning]` to `[warning]`, etc.

(This is essentially how we handle it in the analyzer CLI.)
2016-05-06 13:39:48 -07:00
pq
2df43d50d3 Merge branch 'master' into analysis_rework 2016-05-06 08:58:49 -07:00
Devon Carew
bd564a02af avoid sending analytics on ci systems (#3765)
* avoid sending analytics on ci systems

* review comments
2016-05-05 19:51:22 -07:00
Jason Simmons
4d0e6984c2 Build tool support for Android x86 targets in 32- or 64-bit modes (#3761) 2016-05-05 16:04:22 -07:00
pq
eb215c14ac Review cleanup. 2016-05-05 15:16:27 -07:00
Devon Carew
a999366482 remove the analyze --benhcmark-expected option (#3755) 2016-05-05 14:26:21 -07:00
pq
4311ddb461 Duplicate test fix. 2016-05-05 13:39:58 -07:00
pq
3b882fc449 Updated arg default handling and .dartignore support. 2016-05-05 13:25:59 -07:00
pq
e808125c5b Dead code cleanup. 2016-05-05 12:35:52 -07:00
pq
71203e9a89 Analyzer dep commentary fix. 2016-05-05 12:15:26 -07:00
pq
a59a713f75 Analysis re-work to use analyzer APIs.
Introduces a new Dart analysis wrapper that works directly with the analyzer API (in favor of shelling out to a separate process).

Some consequences:

  * we no longer need to fear parts (simplifying our dart file gathering)
  * we can filter by error code (when needed), rather than by error strings
  * no more IO scraping
  * no need to generate `main()` or to run with `--package-warnings`
  * we now specify an analyzer (and linter) version in the pubspec (we’ll want to make sure this doesn’t diverge too far from the analyzer shipped with the SDK but it does give us some room to play with experimental builds)
  * no more (re)scanning of error source files (and so no more source cache)
  * should generally be a bit simpler and easier to maintain
  * runs a bit faster :)
2016-05-05 12:08:58 -07:00
Phil Quitslund
0e515631a1 Merge pull request #3739 from pq/eq_matcher_cleanup
Prefer implict `equals` matcher in test expectations.
2016-05-04 14:16:06 -07:00
Yegor
39e741dfb7 [tools] remove --flutter-repo flag in flutter test (#3728) 2016-05-04 14:08:16 -07:00
pq
79d1d3a7c4 Prefer implict equals matcher in test expectations.
@Hixie: as per our conversation, a little more concise.
2016-05-04 13:58:45 -07:00
Devon Carew
61c003734b checked mode fix; add type annotation (#3737) 2016-05-04 13:41:46 -07:00
Devon Carew
f34d31717c complain on missing entries in flutter.yaml (#3731)
* complain on missing entries in flutter.yaml

* change to a hard failure
2016-05-04 12:33:34 -07:00
Devon Carew
e365453eac better parsing of adb devices output (#3726)
* better parsing of adb devices output

* re-order lines
2016-05-04 12:32:46 -07:00
Devon Carew
e464a81998 remove the packages/flutter_tools/.analysis_options file (#3733) 2016-05-04 11:43:01 -07:00
Devon Carew
1d4cda5d13 fix the benchmark file written by the analyze command (#3725) 2016-05-04 10:01:39 -07:00
Devon Carew
713830964c make the usage text more visible (#3693)
* make the usage text more visible

* update the look of the usage text
2016-05-03 15:17:30 -07:00
Ian Hickson
961f5cd266 Fix framework-side time in profile data (#3706) 2016-05-03 14:45:22 -07:00
Collin Jackson
57d6e8514b Merge pull request #3701 from collinjackson/assets
Support for putting assets in android/assets folder (like ios/Resources)
2016-05-03 14:08:47 -07:00
Ian Hickson
4b6af7a42f Provide framework-only timing information (#3699)
This makes it easier to generate charts that show the engine time and
the framework time separately.
2016-05-03 13:51:22 -07:00
Collin Jackson
80ef81422d Support for putting assets in android/assets folder (like ios/Resources) 2016-05-03 13:32:35 -07:00
Devon Carew
00062761be filter an assertiond log message from ios (#3692) 2016-05-03 12:46:46 -07:00
Devon Carew
c9010c91f6 fix analysis errors (#3677)
* fix analysis errors

* review comments; fix test

* re-add an export for debugPrint
2016-05-03 09:09:00 -07:00
Eric Seidel
f58fa766c3 Add note about explicit pub get needed.
@devoncarew @jason-simmons
2016-05-02 16:14:35 -07:00
Jason Simmons
30d8dc1399 Check the adb install output for errors and stop "flutter run" if package installation fails (#3672) 2016-05-02 14:11:40 -07:00
Jason Simmons
f161f239ef Download Android AOT tools to the artifacts cache and build APKs using these tools (#3649)
Also update the engine to a build where these tools have been uplaoded
2016-05-02 11:40:32 -07:00
Adam Barth
21f1827bad Add a sensible error message when jarsigner is missing (#3665)
Fixes #3624
2016-05-02 10:27:34 -07:00
Devon Carew
66c868e492 Update pubspec.yaml
Pick up a bug fix to the `usage` package.
2016-04-30 08:19:36 -07:00
Jason Simmons
01a27ca4ae Build ahead-of-time compiled snapshots and incorporate them into Android APKs (#3592)
This currently requires a local build of the engine.

Run "flutter build aot" to build an AOT snapshot.
Run "flutter build apk --profile" to build a "profile mode" APK that uses AOT.
2016-04-29 13:44:01 -07:00
Devon Carew
60755f6d9c fix an issue parsing adb output (#3629) 2016-04-29 09:52:44 -07:00
Devon Carew
99114cd414 show more errors on missing jarsigner (#3626) 2016-04-28 22:48:01 -07:00
Yegor
81af593745 [tools] download traces only from non-resident runs (#3615) 2016-04-28 13:35:32 -07:00
Devon Carew
50b1b16db6 rev test to 0.12.13+1 to support 1.17.0-dev dart sdks (#3613) 2016-04-28 12:56:55 -07:00
Adam Barth
b7fd5426b5 Enable avoid_as lint (#3612)
Related to #3608
2016-04-28 11:07:39 -07:00
Devon Carew
26ed1e71f9 simplify the analysis benchmarking code (#3588)
* simplify the analysis benchmarking code

* review comments
2016-04-28 10:25:26 -07:00
Yegor
c2cccc7b3b [tools] teach flutter run to get startup trace info (#3589) 2016-04-27 17:58:20 -07:00
Devon Carew
b0dca79671 Flutter run (#3553)
* rework flutter run

* fix npe with --debug-port

* connect to obs and exit when that conneciton closes

* update todos
2016-04-27 14:43:42 -07:00
Devon Carew
b0ebc71695 clean up git commits (#3578) 2016-04-27 10:47:52 -07:00
Devon Carew
adac927501 add google analytics to flutter_tools (#3523)
* add google analytics

* send in the run target type

* track device type targets

* use the real GA code

* review comments

* rev to usage 2.0

* rev to 2.2.0 of usage; add tests

* review comments
2016-04-26 16:25:11 -07:00
Devon Carew
c69f4396e3 add a benchmarking mode to flutter analyze (#3569)
* add a benchmarking mode to flutter analyze

* change arg names
2016-04-26 14:09:16 -07:00
Jason Simmons
07951ee90f Add a profile build mode flag for building APKs with AOT compilation (#3526)
This is currently hidden for development use.  It will select artifacts from
the android_{Debug,Release}_Deploy output in a local engine build.
2016-04-25 13:36:31 -07:00
Ian Hickson
b1e684ea63 Fix crash in analyzer if preamble isn't set. (#3525) 2016-04-25 11:25:29 -07:00
Devon Carew
86723ab99e Better devices text (#3519)
* improve text for devices

* nit

* tweak text
2016-04-25 10:14:38 -07:00
Devon Carew
4e2657d25a exclude files from build/ when looking for asset variants (#3512)
* exclude files from build/ when looking for asset variants

* exclude some dirs when creating flx files
2016-04-25 10:14:31 -07:00
Devon Carew
ace1a64bfd don't print installing device twice (#3520) 2016-04-25 09:25:47 -07:00
Jason Simmons
cf56caa708 Add a flag to "flutter build apk" that can package additional files into the APK (#3474) 2016-04-21 16:02:08 -07:00
Devon Carew
731c5903c2 cache the source lines when running analyze (#3436) 2016-04-20 11:26:24 -07:00
Devon Carew
435fdbff25 move driver create test to the flutter_tools package (#3433)
* move driver create test to the flutter_tools package

* review comments
2016-04-20 10:48:27 -07:00
Ian Hickson
1b9476c4d9 Hide routes from the API when they're not needed. (#3431)
The 'routes' table is a point of confusion with new developers. By
providing a 'home' argument that sets the '/' route, we can delay the
point at which we teach developers about 'routes' until the point where
they want to have a second route.
2016-04-20 09:33:28 -07:00
Devon Carew
80fabfd3dd allow flutter create to re-gen over an existing project (#3419)
* allow flutter create to re-gen over an existing project

* add a regression test
2016-04-19 19:30:49 -07:00
Devon Carew
dd2bde1918 add a service extension for repaint rainbow (#3409)
* add a service extension for repaint rainbow

* review comments
2016-04-19 12:57:10 -07:00
Devon Carew
6f0bb20658 rename deploy to release (#3407) 2016-04-19 11:17:00 -07:00
Jason Simmons
8451b669c8 Collect trace data through the observatory HTTP interface (#3393) 2016-04-19 10:38:49 -07:00
Yegor
e7657b9462 [driver] "waitFor" command in place of broken "exists" (#3373)
* [driver] "waitFor" command in place of broken "exits"

* [driver] wait using frame callback
2016-04-19 09:49:22 -07:00
Devon Carew
1c0a966384 rename the --develop option to --debug (#3384)
* rename the --develop option to --debug

* fail if both --debug and --deploy are specified
2016-04-18 16:41:15 -07:00
Ian Hickson
a9eddd4860 Also analyze the driver host entry points. (#3395) 2016-04-18 16:33:03 -07:00
Ian Hickson
424a6b1d6a Handle files disappearing during analysis (#3390) 2016-04-18 15:19:32 -07:00
Devon Carew
29fdc7a464 rename the --release and --debug flags (#3382) 2016-04-18 13:04:59 -07:00
Devon Carew
325354f6be add a temporary .analysis_options for flutter_tools (#3376) 2016-04-18 09:50:19 -07:00
Phil Quitslund
246a2cb055 Merge pull request #3375 from pq/sdk_opt
Analyze CLI option to specify a custom Dart SDK.
2016-04-18 09:44:05 -07:00
pq
26519aab23 Fixed spacing. 2016-04-18 09:25:17 -07:00
pq
4ff0e842e2 Analyze CLI option to specify a custom Dart SDK.
Handy for testing against specific local SDK builds.

(Note that the option is hidden.)
2016-04-18 09:03:31 -07:00
Devon Carew
12cac94cda Use arm deploy (#3374)
* download android-arm-deploy

* wire up --deploy to android-arm-deploy

* fix interpolation
2016-04-18 09:01:43 -07:00
Devon Carew
f132acaf1d use the new cache code to locate more artifacts (#3361)
* use the new cache code to locate more artifacts

* add todo

* review comments
2016-04-15 21:08:03 -07:00
Devon Carew
4678c12098 find all repo packages (#3368)
* find all repo packages

* .dartignore
2016-04-15 20:25:57 -07:00
Yegor
9ce995f65e [driver] refactor API to finder objects (#3365) 2016-04-15 16:57:35 -07:00
Eric Seidel
711bf72620 Make update-packages cover dev/benchmarks.
update-packages only looks one level down, instead of
changing that, I'm just adding dev/benchmarks explicitly.

This will unbreak the bots which are dying trying to
flutter drive dev/benchmarks/complex_layout without
pub get having been run there.

@yjbanov @devoncarew
2016-04-15 12:35:02 -07:00
pq
de25ea22f7 Adding @optionalTypeArgs.
With the new dev build we've got the updated linter and so can use the `@optionalTypeArgs` annotation (in `meta 0.12.0`).

Bonus: this lets us clean up one more Regexp in the `analyze` command! :)
2016-04-14 10:03:46 -07:00
Devon Carew
b172dd5a1a run pub for analyze and test (#3310)
* run pub for analyze and test

* don't run pub when doing repo analysis

* move logic for when to run pub into the commands

* re-write ternary expression
2016-04-13 19:55:28 -07:00
Eric Seidel
341bd47624 Move flutter drive to use 8183 to not conflict with diagnostic server
When @jason-simons added the diagnostic server on Android this
happened to conflict with flutter drive's usage of 8182.

We really should fix both of these port users to be dynamic
but this fixes https://github.com/flutter/flutter/issues/3291
for now.

@yjbanov
2016-04-13 11:22:38 -07:00
Adam Barth
d9b73a2b7a Improve docs about why we pin analyzer (#3254) 2016-04-12 12:42:14 -07:00
Devon Carew
8849cd6b2d add a --deploy flag to build apk (#3249)
* add a --deploy flag to build apk

* update command description

* use an enum instead of a bool param for build variants

* rename buildForDeploy flag to buildVariant

* review comments
2016-04-12 09:21:17 -07:00
Devon Carew
b4173e20d4 fix to showing a progress display for long tasks (#3265) 2016-04-12 08:39:24 -07:00
pq
f270c3d069 Migrate enable-strict-call-checks flag to options file.
As per https://github.com/dart-lang/sdk/issues/25723, moves last command-line flag to `.analysis_options`.
2016-04-11 14:05:44 -07:00
Phil Quitslund
9b2d2ad9d2 Merge pull request #3245 from pq/lint_fixes
Analyze Command lint cleanup.
2016-04-11 13:17:59 -07:00