Commit Graph

913 Commits

Author SHA1 Message Date
Jonah Williams
4adb299566
Revert "[Impeller] Temporary flag flip for devicelab tests to use Impeller. (#122224)" (#122236)
This reverts commit 21b8b7297f.
2023-03-08 14:04:25 -08:00
Jonah Williams
21b8b7297f
[Impeller] Temporary flag flip for devicelab tests to use Impeller. (#122224)
[Impeller] Temporary flag flip for devicelab tests to use Impeller.
2023-03-08 21:41:51 +00:00
Jenn Magder
a16e620ec2
Funnel devicelab tests through utils process methods (#122161)
Funnel devicelab tests through utils process methods
2023-03-08 19:44:40 +00:00
stuartmorgan
e65dfba8e1
Add Linux unit tests to plugin template (#120814)
* Add Linux unit tests to plugin template

Adds an example native unit test to the plugin template for Linux,
matching the structure we use for our 1P plugin unit tests. Once these
have been added for all platforms+languages, they will be documented on
a new plugin development page to explain their use.

While ideally we would adjust the engine APIs first to allow for testing
the method call handler directly, it's unclear when we will have time
for that work, and for a complex plugin most of the testing wouldn't be
at that layer anyway, so having the structure in place with the
limitations documented is still a significant improvement over having
nothing in the template.

Part of https://github.com/flutter/flutter/issues/82458

* Add creation test

* Add integration tests

* Missing newlines

* test owner

* Typo
2023-02-15 19:13:11 +00:00
gaaclarke
ddebe833b0
Added integration test for wide gamut support. (#119657)
* Added integration test for wide gamut support.

* cleaned up

* deleted files that can be generated

* switched back to standard flutter in the shell script

* added devicelab task

* removed analysis options

* analyzer

* Fixed task

* made local_run.sh not executable

* analyzer

* removed the logo asset

* added task to ci

* updated pubspec

* analysis errors fixed

* updated pubspec
2023-02-13 22:33:19 +00:00
Chris Bracken
d272a3ab80
Reland: [macos] add flavor options to tool commands (#119564)
* Reland: [macos] add flavor options to tool commands

Adds --flavor option to flutter run and flutter build. Running against
preexisting devicelab flavor tests for feature parity between macOS,
iOS, and Android.

This relands #118421 by alex-wallen which was reverted in #118858 due to
the following test failures:

The bail-out with "Host and target are the same. Nothing to install."
added in `packages/flutter_tools/lib/src/commands/install.dart`
triggered failures in the following tests, which unconditionally attempt
to install the built app, which is unsupported on desktop since the
host and target are the same:

* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout
* https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout

Fixes #64088

* Partial revert: eliminate install check on desktop

The original flavour support patch included a check that triggered a
failure when flutter install is run on desktop OSes. This was
intentional, since the host and target devices are the same and
installation is unnecessary to launch the app on currently-supported
desktop OSes.

Note that Windows UWP apps *do* require installation to run, and we used
to have an install command for those apps, though UWP is no longer
supported.

Since that part of the change was orthogonal to flavour support itself,
I'm reverting that component of the change and we can deal with it
separately if so desired.
2023-01-31 17:37:46 +00:00
stuartmorgan
e3c51a2f2a
Add Windows unit tests to plugin template (#118638)
* Add Windows unit tests to plugin template

Adds an example native unit test to the plugin template for Windows,
matching the format we use for our 1P plugin example app unit tests.
Once these have been added for all platforms+languages, they will be
documented on a new plugin development page to explain their use.

Since we don't appear to be running our current plugin e2e tests for
Windows, this adds a new configuration to run them. I haven't
`led`-tested this, so it may not work, but this will give a starting
point for getting them running.

Part of https://github.com/flutter/flutter/issues/82458

* Minor fix

* Add test owner

* Fix typo

* Fix test feature flag
2023-01-24 18:23:57 +00:00
Jenn Magder
25843bdb5a
Remove macOS impeller benchmarks (#118917)
* Remove macOS impeller benchmarks

* TESTOWNERS
2023-01-21 01:34:53 +00:00
Michael Goderbauer
ab3c82244e
Remove unnecessary null checks in dev/devicelab (#118842) 2023-01-20 18:56:44 +00:00
Jenn Magder
030288d33b
Revert "[macos] add flavor options to commands in the flutter_tool (#118421)" (#118858)
This reverts commit 73096fd96e.
2023-01-20 03:46:45 +00:00
Alex Wallen
73096fd96e
[macos] add flavor options to commands in the flutter_tool (#118421)
* Add new macos target configured for flavors

* Rename Free App copy-Info.plist to Free App Info.plist

* Remove bogus entitlements

* Remove Generated.xcconfig

* Audit project.pbxproj

* Remove unused configs

* share one info.plist

* Modify scheme so that paid app works

* Codesign automatic

* Pipe flavor as scheme into xcodebuild

* Ignore incoming flavor string

* pipe flavor for flutter run to work

* Add devicelab tests

* Error if host and target device are same for flutter install desktop

* Avoid bang (!) by promoting a local.

Co-authored-by: Jenn Magder <magder@google.com>

* Add supportsInstall property

* Override  in test classes

* Add install test on macOS

* Refactor application_package and add tests for package directory

Co-authored-by: a-wallen <stephenwallen@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
2023-01-19 23:52:16 +00:00
Alex Wallen
22520f54df
[macOS] Add timeline summary benchmarks (#118748)
* Add new task runner for impeller enabled complex layout test

* Add new target in .ci.yaml

* Claim ownership of complex_layout_scroll_perf_impeller_macos__timeline_summary

* Task runner for non-impeller enabled scroll test

* Add test target for non impeller complex layout scroll

* claim ownership of the last target

* mark as bringup

Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-19 21:29:19 +00:00
Jenn Magder
ffcf63ae88
Add verbose flag to plugin_dependencies_test to debug flake (#118755) 2023-01-19 00:02:25 +00:00
Alex Wallen
666dccc85e
[macOS] bringup new e2e_summary devicelab test (#118717)
* Add new task runner for animated_complex_opacity_perf_impeller e2e_summary on macos

* Register new target for macos e2e_summary task

* Claim ownership in TESTOWNERS

* Add task runner for animated complex opacity without impeller

* Register new target in .ci.yaml for non-impeller test

* Claim ownership of non-impeller task

Co-authored-by: a-wallen <stephenwallen@google.com>
2023-01-18 22:33:49 +00:00
Loïc Sharma
cea55d99d0
[Linux] Add a 'flutter run' console output test (#118279)
* Add Linux support for the UI integration test project

* Add Linux run console test
2023-01-13 19:17:12 +00:00
Jenn Magder
eaaacdcba9
Allow iOS and macOS plugins to share darwin directory (#115337) 2023-01-09 10:33:03 -08:00
Camille Simon
9fb1ae839e
[iOS] Add task for spell check integration test (#116222)
* Add fix and test

* Add test owner

* Print error for testing

* Make sure locale is the problem

* Test capitalization fix

* Take out Android specific test

* Verify eng fix

* Test fix

* Empty-Commit

* Test all tests

* Up string size for testing

* Remove test

* Undo ci.yaml testing changes

* Test android variant:

* Change to testwidgets

* Add widget tester

* Remove android only attempt

* Revert ci.yaml changes
2022-12-22 02:47:11 +00:00
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints (#117365) 2022-12-20 16:03:21 -08:00
Michael Goderbauer
fdd2d7d64a
Sync analysis_options.yaml & cleanups (#117327) 2022-12-20 14:15:39 -08:00
hellohuanlin
0916375f44
[tools]Build IPA validation UI Polish (#116744)
* [tools]some ui polish for build ipa validation

* do not print out a few success validations

* rename installed type to success for more general usage

* forgot nit after reverting custom validation types and re-use doctor types
2022-12-15 14:43:32 -08:00
stuartmorgan
f1d157bc29
Add an integration test to plugin template example (#117062)
* Add an integration test to plugin template example

Dart unit tests don't exercise host-side plugin code at all, so the
example tests in the plugin template currently have very little
meaningful coverage. This adds an integration test to the example app
when creating a plugin, so that there's an example of how to actually
test that a complete round-trip plugin call works.

This is done as a separate template that's currently only used by the
plugin template because I don't know what a good example for a
non-plugin case would be that isn't largely just a duplicate of the
widget tests. However, the integration test pre-includes conditionals
around the parts that are plugin-specific so that it can more easily be
expanded to other use cases later (e.g., in
https://github.com/flutter/flutter/issues/68818).

Part of https://github.com/flutter/flutter/issues/82458

* Add integration test to expected dependencies of a plugin app

* Test fixes

* Make an explicit test case
2022-12-15 19:49:14 +00:00
Loïc Sharma
41625b6620
Test flutter run does not have unexpected engine logs (#116798) 2022-12-12 22:39:49 +00:00
Siva
7c8e171320
Manual Roll of Flutter Engine from 67254d6e4b03 to 8d83b98c55b3 (#116635)
* Roll Flutter Engine from 67254d6e4b03 to 8d83b98c55b3

* Roll Dart SDK from 35a9facce191 to e517487c5679 (Dart 3.0) (#38105)

* Bump SDK versions.

* Bump Dart SDK version constraints

* Update shrine package to 2.0.1 (null safe version)

* Fix more tests.

* Include patches from Jason for min android sdk version

* Fix analyzer warning
2022-12-08 18:03:51 -08:00
Loïc Sharma
bebea0cc6c
[Windows] Add a flutter run console output test (#116626)
Adds a test to verify the console output of `flutter run --release` on Windows.

Part of: https://github.com/flutter/flutter/issues/111577
2022-12-08 14:05:53 -08:00
Camille Simon
609fe35f13
[Android] Fix Linux Android flavors_test (#116129)
* Remove flaky label

* Have test install debug version

* Fix test

* Undo change

* Properly test change

* Empty-Commit

* Revert testing changes
2022-12-07 00:00:59 +00:00
Loïc Sharma
30c575140a
[Android] Refactor the flutter run Android console output test (#115023)
* [Android] Refactor the flutter run Android console output test

* CI bump
2022-12-06 21:57:25 +00:00
Jonah Williams
08a2635e2b
[devicelab] add benchmark for complex non-intersecting widgets with platform views (#116436) 2022-12-02 21:37:45 +00:00
hellohuanlin
162be5933b
[tools]build IPA validation bundle identifier using the default "com.example" prefix (#116430)
* [tools]build IPA validation bundle identifier using default com.example

* rephrase the warning
2022-12-02 20:49:30 +00:00
hellohuanlin
be81e9eae7
[tools]build ipa validate launch image using template files (#116242)
* [tools]build ipa validate launch image using template files

* reuse more code by sharing the same file key

* fix space
2022-12-02 02:09:50 +00:00
hellohuanlin
e438a12057
[tools]build ipa validate app icon size (#115594)
* [tools]build ipa validate icon size

* add more checks in case apple change the format, and also add device lab tests

* do not depend on collection package
2022-11-29 23:19:02 +00:00
Jonah Williams
dfa3d33328
[devicelab] track performance of animated image filter (#115850)
* [devicelab] track performance of animated image filter

* ++

* make animations repeat and add dispose

* make duration more consistently 10sec
2022-11-29 01:59:19 +00:00
Jenn Magder
efb069474f
Remove unused flutter_attach_test_fuchsia (#115515) 2022-11-17 18:51:55 +00:00
Loïc Sharma
9797d5f1cb
[macOS] Refactor the flutter run macOS console output test (#114645) 2022-11-08 23:00:04 +00:00
Alex Wallen
7020f59ace
[tool] Support --flavor option for flutter install. (#114048)
* Alphabetize setup calls

* Add --flavor as an option for install

* Add verbose logging in install command

* Test that flavors build succeeds with proper flavor and fails with bogus one.

* Remove unused import

* The import was used...

* SQUASH

* Add flavor install test

* Rename test

* Add flavors install integration tests

* correct error message

* remove unused imports

* Delete copy test

* update test target

* Refactor mechanism to read buildInfo

* Remove unused import

* Set affected test targets to bringup: true

Co-authored-by: a-wallen <stephenwallen@google.com>
2022-11-08 22:53:23 +00:00
Zachary Anderson
a84e369bd2
Revert "Allow Flutter golden file tests to be flaky (#114450)" (#114902)
This reverts commit 53e6876226.
2022-11-08 09:26:55 -08:00
Kate Lovett
53e6876226
Allow Flutter golden file tests to be flaky (#114450)
* allow marking a golden check as flaky

* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib

* Pause

* ++

* ++

* Analyzer therapy

* Once more with feeling

* Nits

* Review feedback

* Silly oops

* Test progress

* More tests

* Finish

* Nits

* Analyzer

* Review feedback

Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
Christopher Fujino
0211df9cfc
[flutter_tools] provide --timeout option to flutter drive (#114458) 2022-11-02 18:43:42 +00:00
Jenn Magder
15e694414c
Terminate simulator app on "q" (#114114) 2022-10-27 22:06:35 +00:00
Victoria Ashworth
8aad1190b7
Check for watch companion in build settings (#114078) 2022-10-27 22:05:05 +00:00
Jenn Magder
609b8f3219
Revert part of "Terminate simulator app on "q" (#113581)" (#114083) 2022-10-26 10:26:14 -07:00
Jenn Magder
49405135d7
Update macOS gallery display name (#113658) 2022-10-20 03:23:12 +00:00
Alex Li
3d94b8fd1d
[tool] Install the corresponding APK in flutter run (#113622) 2022-10-19 02:44:30 +00:00
Jenn Magder
4d28e6d064
Terminate simulator app on "q" (#113581) 2022-10-18 22:26:16 +00:00
Jenn Magder
f059dd40ea
Show Xcode compilation errors at end of build, suppress stdout and stderr from Xcode (#113302) 2022-10-17 17:47:25 +00:00
Jenn Magder
7dd65c16c2
Add bitcode deprecation note for add-to-app iOS developers (#112900) 2022-10-06 02:51:23 +00:00
林军华
8e30cc9c56
Revert file naming convention of .aar files to support fuzzy matching in build.gradle (#112149) 2022-10-04 03:37:22 +00:00
Jenn Magder
35afe1bdac
Stop embedding bitcode for iOS in tool (#112831) 2022-10-04 01:41:23 +00:00
Jenn Magder
86e510137b
Update pod repo to pull the latest Flutter pods in plugin_lint_mac (#112237) 2022-09-28 18:14:52 +00:00
Alex Wallen
b22388ee68
Add a flutter app that can resize itself as integration test app. (#112297) 2022-09-26 17:45:19 +00:00
Jenn Magder
60c6cbf0ca
Remove Apple Silicon workarounds from plugin lint test (#111432) 2022-09-20 21:12:39 +00:00
Jenn Magder
7714a8d034
Do not codesign transitive dependency iOS pod resource bundles (#111714) 2022-09-16 18:02:12 +00:00
jensjoha
b7b8b759bc
Add flutter startup benchmark (#111658)
Add flutter startup benchmark for Linux, Windows and MacOs.

Via guide on https://github.com/flutter/flutter/pull/111461#issuecomment-1247113905
2022-09-16 08:41:30 +02:00
Alex Wallen
96b49aae31
[macOS] Add flutter_view example. (#111326) 2022-09-14 23:44:14 +00:00
Jenn Magder
489094ad98
Quiet iOS native test result zipping (#111434) 2022-09-13 23:08:41 +00:00
gaaclarke
d2434a2b60
Added platform channel integration tests for macos (#110606) 2022-09-08 22:39:07 +00:00
Alex Wallen
652ff7a5e6
[macOS] Add platform_view_macos__start_up tests devicelab test suite. (#111041) 2022-09-08 19:35:20 +00:00
Alex Wallen
eac2329ebf
Re-land [macOS] Bring up "flutter_gallery" devicelab, start up test for x86. (#110379) 2022-09-08 16:49:17 +00:00
Alex Wallen
9a4e4bd3d9
Delete flutter_gallery_mac__start_up. (#111147) 2022-09-08 00:00:00 +00:00
hellohuanlin
8e2333dcc7
[platform_view]use cmd to uninstall the app (#111139) 2022-09-07 22:45:26 +00:00
keyonghan
ab77e43566
Migrate Linux android gallery e2e and hybrid tests to build+test (#110533) 2022-09-07 20:19:20 +00:00
Ivan Dlugos
723b82e4f0
Feat: dSYM debug info for iOS & macOS builds (#101586) 2022-09-05 18:16:16 +00:00
Jenn Magder
a4530b7c12
Make module tests pass on Xcode 14 (#110556) 2022-08-30 18:51:20 +00:00
Zachary Anderson
056f11060f
Add several new iOS/Impeller benchmarks (#110358) 2022-08-26 14:06:26 -07:00
Jenn Magder
d65d64d194
Revert "[macOS] Bring up "flutter_gallery" devicelab, start up test for x86. (#110370)" (#110372)
This reverts commit 4770e34859.
2022-08-26 13:48:36 -07:00
Stephen (Alex) Wallen
4770e34859
[macOS] Bring up "flutter_gallery" devicelab, start up test for x86. (#110370) 2022-08-26 20:24:52 +00:00
Stephen (Alex) Wallen
d420016587
[macOS] Bring up "complex_layout" devicelab, compilation test for x86. (#110360) 2022-08-26 19:27:31 +00:00
Jonah Williams
f0ffc85698
Add bad scroller benchmark (#110362) 2022-08-26 18:50:07 +00:00
Stephen (Alex) Wallen
9a34a60c0c
[macOS] Bring up "flutter_gallery_macos__compile" devicelab, compilation test for x86. (#110356) 2022-08-26 17:29:39 +00:00
Stephen (Alex) Wallen
80a635e4a9
[macOS] Bring up "basic_material_app" devicelab, compile tests for x64 macs. (#110296) 2022-08-26 15:29:14 +00:00
Loïc Sharma
4898f1f5c5
[Windows] Add app startup integration test (#110114)
Add a basic integration test for the Windows's app startup. In a subsequent change (https://github.com/flutter/flutter/pull/109816), this test will be updated to verify the app's window isn't visible until after the first frame has been drawn.

Part of https://github.com/flutter/flutter/issues/41980
2022-08-25 18:54:20 -07:00
Stephen (Alex) Wallen
27bfc511ba
[macOS] Bring up "complex_layout" devicelab, startup tests for x64 (#110100) 2022-08-25 23:35:00 +00:00
Stephen (Alex) Wallen
d71a8a7093
[macOS] Bring up "hello_world" devicelab, compilation test for x86. (#109891) 2022-08-24 18:04:42 +00:00
Zachary Anderson
d79a3d7a19
Remove most benchmarks of SkSL warmup (#110040) 2022-08-22 22:31:54 +00:00
Camille Simon
7db25c36ad
Re-land Add Spell Check to EditableText (#109643) 2022-08-17 16:16:02 +00:00
yaakovschectman
4e068a613e
Bring up new Windows start-up tests (#109618)
* Add Windows startup test

* Add new tests for Windows desktop

* Bring up complex layout tests for Win Desktop

* Bring up flutter_view startup test for Windows

* Add Platform View startup test for Windows

* Fix typo in .ci.yaml

* Make basename variable final

* Link to bug in .ci.yaml
2022-08-17 09:38:41 -04:00
Jonah Williams
0ba88d8b43
Revert "Add Spellcheck to EditableText (Android) (#109334)" (#109631)
This reverts commit ff9fe35682.
2022-08-16 14:30:03 -07:00
Camille Simon
ff9fe35682
Add Spellcheck to EditableText (Android) (#109334) 2022-08-16 18:22:45 +00:00
yaakovschectman
bba2ac83b1
Add Compilation DeviceLab test for Windows (#109540)
* Add Windows compilation test (hello_world_windows__compile)

* Add devicelab target to .ci.yaml

* Bringup on new target

* Add license to generated files

* Indicate test ownership

* Delete asset from repo

* Add Windows compilation test (hello_world_windows__compile)

* Add devicelab target to .ci.yaml

* Bringup on new target

* Add license to generated files

* Indicate test ownership

* Delete icon

* Use path.basename

Re triggering tests

* Update test owner to desktop team
2022-08-15 16:26:02 -04:00
hellohuanlin
176f7d7130
[platform_view]run platform view ui test to physical device (#108642) 2022-07-30 06:36:09 +00:00
Jenn Magder
7f1a8f7948
Add usage event when iOS app is archived (#108643) 2022-07-29 22:44:06 +00:00
hellohuanlin
b00bfef3c1
[platform_view]add android deps to platform view test (#108585) 2022-07-28 23:42:07 +00:00
Michael Goderbauer
10a7c9ba22
Unify analysis options (#108462) 2022-07-28 09:07:49 -07:00
Kaushik Iska
f7504f0380
[openpay] Create an OpenPay benchmark (#107838) 2022-07-21 20:01:06 +00:00
ColdPaleLight
1919167540
Added benchmark for early removal of unused raster cache entris mecha… (#107918) 2022-07-20 19:13:06 +00:00
hellohuanlin
da8070d6af
Fix native platform view integration test config (#107679) 2022-07-15 22:56:09 +00:00
Alexandre Ardhuin
93a74ca9f2
remove unused members in executable libs (#107464) 2022-07-12 21:41:08 +00:00
stuartmorgan
6c6ae06381
Add Windows to the platform_channels example (#106754) 2022-06-30 14:54:07 +00:00
JsouLiang
f0200f0106
Add benchmark case for RasterCache (#103338) 2022-06-29 23:54:10 +00:00
Jonah Williams
98f0c3694b
add old gallery page transition (#106701) 2022-06-27 23:36:06 +00:00
hellohuanlin
0dd0c2edca
[platform_view]Send platform message when platform view is focused (#105050) 2022-06-23 00:01:07 +00:00
Dan Field
adec8f23be
Fix impeller name swap (#106350) 2022-06-21 18:17:07 +00:00
Jenn Magder
3f1f0a8170
Add flutter build macos-framework command (#105242) 2022-06-03 10:13:08 -07:00
Dan Field
be7a4227c7
Add a macrobenchmark for laying out text in a list (#104736) 2022-05-26 15:25:10 -07:00
Jenn Magder
dce355d801
Remove google_sign_in plugin from module test (#104657) 2022-05-25 16:13:10 -07:00
Jenn Magder
f3e567c901
Create static plugin frameworks build ios-framework --static (#104576) 2022-05-25 09:03:12 -07:00
Zachary Anderson
80a51e4f97
Adds new_gallery_impeller__transition_perf benchmark for Android (#104126) 2022-05-18 20:07:12 -07:00
Jenn Magder
b90359d5b4
Delete flaky flutter_gallery XCUITest (#103935) 2022-05-18 11:47:07 -07:00
Christopher Fujino
708c363920
Revert "Delete flaky flutter_gallery XCUITest (#103666)" (#103726)
This reverts commit 145be18c16.
2022-05-13 10:42:26 -07:00
Jenn Magder
145be18c16
Delete flaky flutter_gallery XCUITest (#103666) 2022-05-13 10:09:08 -07:00
wangying
b3d7a691f6
Add benchmark for clipper layers raster cache (#102495)
* Add clipper raster cache benchmarks

* fix ci test error

* Add PhysicalModel widget to test

* Set top margin adaptive screen height

* Remove PhysicalModel
2022-05-13 14:04:06 +08:00