Commit Graph

5586 Commits

Author SHA1 Message Date
Pierre-Louis
3e43c3e110
Categorize flutter tool commands (#87747) 2021-10-05 17:28:04 -07:00
stuartmorgan
64fd68ed42
Don't generate plugin registry in ResidentWebRunner (#91281)
* Don't generate plugin registry in ResidentWebRunner

generateDartPluginRegistry was being set to true unconditionally in
ResidentRunner, bypassing the primary check in
DartPluginRegistrantTarget, and the targetPlatform was not set in that
codepath, bypassing the second after the changes in
https://github.com/flutter/flutter/pull/87991. This caused web hot
restarts to be slower due to doing unnecessary work.

This ensures that generateDartPluginRegistry is false in the
ResidentWebRunner to skip that unnecessary step.

Fixes https://github.com/flutter/flutter/issues/91262

* Formatting

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2021-10-05 12:27:53 -07:00
Ian Hickson
126cd7388e
Clean up dependency pins and update all packages (#91109) 2021-10-04 10:28:03 -07:00
Jenn Magder
61e2e86611
Add iOS build -destination flag (#90915) 2021-10-04 10:18:03 -07:00
Christopher Fujino
91dd3276fd
migrate vm service to null safety (#88320) 2021-10-02 10:18:03 -07:00
stuartmorgan
23cea26715
Add dartPluginClass support for Android and iOS (#87991) 2021-10-01 16:03:04 -07:00
Ian Hickson
989f864497
Enable avoid_setters_without_getters (#91067) 2021-10-01 00:58:05 -07:00
stuartmorgan
97fb8c0560
Fix Dart plugin registrant interaction with 'flutter test' (#90288)
Building an application for a desktop platform that transitively included any Dart-based plugins (such as path_provider) broke `flutter test`, because its compilation was overriding the provided main (in this case, the test main) with `generated_main.dart` if it was present. This PR:
- Changes the `flutter test` compilation path to update `generated_main.dart`, so that the tests will work, and will include any registered Dart plugins.
- Makes using `generated_main.dart` during recompile opt-in, to try to reduce the chance of a similar bug happening with other codepaths in the future.

Fixes https://github.com/flutter/flutter/issues/88794
2021-09-30 20:25:13 -07:00
Christopher Fujino
738a7747cc
[flutter_tools] Handle disk device not found (#90996) 2021-09-30 17:28:57 -07:00
Jenn Magder
c48c428e46
Xcode 13 as minimum recommended version (#90906) 2021-09-30 12:23:55 -07:00
Greg Spencer
01af8e5987
Make flutter update-packages run in parallel (#91006)
This modifies the flutter update-packages and flutter update-packages --force-upgrade commands so that the many invocations of "dart pub get" in each repo project run in parallel instead of in series.
2021-09-30 10:26:31 -07:00
Jenn Magder
faaca13f22
Catch FormatException from bad simulator log output (#90966) 2021-09-30 09:33:04 -07:00
Kenzie (Schmoll) Davisson
5a85c0d81c
Launch DevTools from the 'dart devtools' command instead of pub (#90894) 2021-09-29 15:32:24 -07:00
Greg Spencer
ab2b0851a2
Add smoke tests for all the examples, fix 17 broken examples. (#89021)
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
2021-09-28 09:32:06 -07:00
Jason Simmons
cd19bc6007
Do not retry if pub get is run in offline mode (#90394) 2021-09-27 08:18:06 -07:00
Christopher Fujino
61bce1d83b
[flutter_tools] remove non-null check from AndroidValidator (#90090) 2021-09-25 16:53:06 -07:00
Jenn Magder
1b53f7beba
Migrate iOS project to Xcode 13 compatibility (#90304) 2021-09-22 13:23:05 -07:00
Jason Simmons
58056bbe74
Close the IntegrationTestTestDevice stream when the VM service shuts down (#90022) 2021-09-17 19:18:03 -07:00
Liam Appelbe
9afbab8477
Use report_lines flag in flutter coverage (#90142)
* Use the report lines flag

* Handle major version bumps in the version check

* Fix existing tests and add a new test
2021-09-16 11:33:32 -07:00
Ahmed Ashour
eb185d73ce
internationalization: fix select with incorrect message (#90096) 2021-09-16 09:23:22 -07:00
Jenn Magder
ab6f2fc8ce
Set BUILD_DIR when determining if plugins support arm64 simulators (#90088) 2021-09-15 18:37:04 -07:00
Michael Thomsen
b889915997
Change min Dart SDK constraint to track actual version (#88743) 2021-09-14 14:08:36 +02:00
Phil Quitslund
975fcc1f2f
master->main deafult branch migration (#89782) 2021-09-10 15:42:03 -07:00
Chase Latta
aed4315a7d
Replace amber_ctl with pkgctl for Fuchsia (#89785)
Fuchsia is deprecating amber_ctl and replacing it with pkgctl.
This change removes the FuchsiaAmberCtl class and replaces it
with the FuchsiaPkgctl class and updates the usages appropriately.

BUG: fxbug.dev/83865
2021-09-10 10:33:45 -07:00
Jenn Magder
84086d8a9c
Clean up null assumptions in vmservice for null safe migration (#89009) 2021-09-09 19:32:02 -07:00
Jenn Magder
855af29084
Migrate ios_deploy to null safety (#88851) 2021-09-09 17:32:05 -07:00
Jenn Magder
58944e6b88
Revert "Enable caching of CPU samples collected at application startup (#89600)" (#89704)
This reverts commit 619121b095.
2021-09-08 19:37:34 -07:00
Ben Konyi
619121b095
Enable caching of CPU samples collected at application startup (#89600) 2021-09-08 17:22:04 -07:00
Jenn Magder
34ba64738e
Clean up null assumptions in devfs to prep for null safety migration (#88934) 2021-09-08 15:27:05 -07:00
Anis Alibegić
a753d09cc9
Fixed several typos (#89485) 2021-09-07 14:56:04 -07:00
Chris Bracken
1c36271b05
Reduce required Windows CMake version to 3.14 (#89390)
When we landed the CMake minimum requirement constraint for Visual
Studio 2019, we landed it with minimum version 3.15, since that's what
was shipping with the current version of VS 2019 at the time. Looking at
the release notes of earlier versions, it's clear that earlier versions
of Visual Studio 2019 shipped with version 3.14. See:
https://devblogs.microsoft.com/cppblog/visual-studio-cmake-support-clang-llvm-cmake-3-14-vcpkg-and-performance-improvements/

Looking at release notes for CMake 3.15, there are no features/fixes
introduced in that version that we are dependent on.
https://cmake.org/cmake/help/latest/release/3.15.html

Issue: https://github.com/flutter/flutter/issues/88589
2021-09-03 21:05:58 -07:00
arfy slowy
202fc02ca1
fix: typo spelling grammar (#88439) 2021-09-03 15:09:31 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets (#86821) 2021-08-30 15:41:02 -07:00
Sigurd Meldgaard
bce366203a
Stop calling top level pub (#89032)
* Use `dart __deprecated_pub` instead of `pub` to invoke pub from tools

The top level `pub` commmand has been deprecated and will print
a message. It is however implemented via the __deprecated_pub command
that prints no message.
2021-08-30 10:40:10 -07:00
Jenn Magder
e6535f6da1
Changed tool cached properties to late finals (#88923) 2021-08-26 14:01:05 -07:00
Jenn Magder
0cb6d5983c
Migrate fuchsia sdk and dependencies to null safety (#88920) 2021-08-25 19:51:04 -07:00
Jenn Magder
d550d497f1
Migrate some flutter_tools tests to null safety (#88850) 2021-08-25 16:21:04 -07:00
Jenn Magder
125451bc2e
Migrate mac.dart to null safety (#88846) 2021-08-25 13:31:03 -07:00
Zachary Anderson
b4e0472b04
Revert "Use dart pub instead of pub to invoke pub from tools (#88509)" (#88792)
This reverts commit 7c24ff2c5b.
2021-08-24 09:00:22 -07:00
Sigurd Meldgaard
7c24ff2c5b
Use dart pub instead of pub to invoke pub from tools (#88509)
Top level `pub` is being deprecated.
2021-08-24 15:51:08 +02:00
Jonah Williams
fa0782b696
reassign jonahwilliams todos (#88707) 2021-08-23 12:27:07 -07:00
Taha Tesser
d72287522b
[tools] Fix Android Studio duplicate detection (#88384) 2021-08-18 02:02:03 -07:00
Jenn Magder
2d55032939
Migrate dds.dart to null safety (#88382) 2021-08-17 21:12:03 -07:00
Taha Tesser
42a6b7913c
[tools] Add Xcode version to non-verbose Flutter doctor (#87022) 2021-08-17 15:52:03 -07:00
Zachary Anderson
3572a7e8b7
Revert "feat: migrate base/dds.dart to null-safety (#88015)" (#88367) 2021-08-17 11:52:05 -07:00
Jonah Williams
060e4608b1
clean up stale or unnecessary TODOS (#88308) 2021-08-16 21:37:03 -07:00
Jason Simmons
ddb8bfb72b
Fix URL construction in the test entry point generated by the web bootstrap script (#88201) 2021-08-16 14:12:05 -07:00
Jenn Magder
57efbd5310
Rename IOSDeviceInterface to IOSDeviceConnectionInterface (#88144) 2021-08-16 10:27:03 -07:00
Zachary Anderson
c5d5463c30
[flutter_tools] Fix hang in DesktopLogReader (#88178) 2021-08-13 17:12:04 -07:00
Jenn Magder
325cfb0f4c
Make doctor Xcode version requirement clearer (#88137) 2021-08-13 17:07:03 -07:00