Commit Graph

5014 Commits

Author SHA1 Message Date
Jonah Williams
5b956fd8f6
[flutter_tools] split isSupportedForProject test into new file (#52911) 2020-03-19 16:42:05 -07:00
Kirill Pertsev
bae2f2c108
Enables log reader on iOS Simulator to (rudimentary) process multiline messages (#52452) 2020-03-19 15:41:39 -07:00
Jason Simmons
bbc9d4f3a6
Do not check the executable status of gen_snapshot if it has not yet been downloaded (#52574) 2020-03-19 15:01:02 -07:00
Jonah Williams
d20242b703
[flutter_tools] refactor ios install/uninstall to new file (#52891) 2020-03-19 14:53:14 -07:00
Jonah Williams
b21e780aee
[flutter_tools] refactor AotBuilder, removing globals and duplicated kernel compilation (#52896)
Reland of #52091
2020-03-19 14:52:42 -07:00
Jonah Williams
9391e480b2
Revert "[flutter_tools] refactor GenSnapshot and AotBuilder (#52091)" (#52893)
This reverts commit f65421aaca.
2020-03-19 10:16:20 -07:00
Jenn Magder
a61bff2fcf
Show Xcode workspace clean output with verbose flag (#52860) 2020-03-19 09:51:01 -07:00
Jonah Williams
f65421aaca
[flutter_tools] refactor GenSnapshot and AotBuilder (#52091)
Remove dependency injection from GenSnapshot and AotBuilder and update tests to use FakeProcessManager
2020-03-19 09:36:38 -07:00
Jonah Williams
fe310148a1
[flutter_tool] Remove extra usage of .packages in vm service API (#52845) 2020-03-19 09:35:57 -07:00
Dan Field
53dc8db0e8
Do not throw when trying to discover a fuchsia device and the sshConfig is invalid (#52858)
* Do not throw when trying to discover a fuchsia device and the sshConfig is invalid
2020-03-19 09:28:54 -07:00
Jonah Williams
73b6702dee
[flutter_tools] refactor iOS tests for Device.startApp into new file (#52854) 2020-03-18 17:43:25 -07:00
Jenn Magder
ee845255de
Move XcodeProjectInterpreter to globals (#52847) 2020-03-18 15:55:09 -07:00
Jenn Magder
e0ab6fc00c
Move outputPreferences to globals (#52846) 2020-03-18 15:54:26 -07:00
Jonah Williams
0274f170fb
[flutter_tools] have the tool print the current canvaskit mode when toggling (#52841) 2020-03-18 15:51:23 -07:00
Yegor
7b4c195f99
Fix web test flakiness; enable web golden tests (#52789)
* Fix web test flakiness; enable web golden tests

The fix is three-part:

- Only allow one test to load _and_ test at any point in time.
- Use a fresh Chrome instance for each test file.
- Increase Cirrus resources.

The first two changes only fix the "Unknown error loading" error, but not hanging tests. The resource increase also prevents hanging tests.

Other minor changes:

- Remove test batching (it's no longer necessary)
- Fix the Chrome class, which was using the wrong Completer.
2020-03-18 15:11:48 -07:00
Christopher Fujino
2d9902d9ac
Cleanup ios devices (#52568) 2020-03-18 12:51:01 -07:00
Zachary Anderson
e8778da12c
[flutter_tools] Don't crash when analytics fails to initialize (#52775) 2020-03-18 10:00:14 -07:00
Jonah Williams
542feb4736
[flutter_tools] remove unused Snapshot.dart artifact and associated code (#52821) 2020-03-18 09:18:41 -07:00
Jonah Williams
da0788a180
Update fuchsia remote debug protocol to use package:test shim instead of package:test_api (#52706)
This is necessary to ensure the tests can run in google3. Fixes https://b.corp.google.com/issues/151657461
2020-03-18 09:12:46 -07:00
Jonah Williams
b7101b45f5
[flutter_tools] disable added integration test due to Cirrus flakes (#52782) 2020-03-17 19:07:22 -07:00
Jonah Williams
46f0a5f7b5
[flutter_tools] Reland android device cleanup. (#52686) 2020-03-17 17:58:39 -07:00
Jonah Williams
90d6169678
[flutter_tools] refactor the IOSDevicePortForwarder and move tests out of devices_test.dart (#52772)
Updates the IOSDevicePortForwarder to no longer depend on context, or on an IOSDevice instance. Instead, it receives all necessary configuration through the constructor.

Moves the IOSDevicePortForwarder to a separate file.
2020-03-17 17:58:05 -07:00
Jonah Williams
6884086e5c
[flutter_tools] Update to latest dwds APIs (#51004)
Update to latest dwds APIs, moving back to dwds driven hot restart and enabling future work on expression evaluation.
2020-03-17 17:29:53 -07:00
gaaclarke
6990b8b2d3
Added the "trace-whitelist" flag to run. (#52556) 2020-03-17 16:42:20 -07:00
Jonah Williams
f149eec31b
[flutter_tools] always initialize the resident runner from dill (#52497) 2020-03-17 16:37:06 -07:00
Jenn Magder
757b39ba99
Ignore fuchsia device-finder no device error (#52761) 2020-03-17 16:02:45 -07:00
Christopher Fujino
071d4eb2c8
explicitly catch ArgumentError, and add tests (#52757) 2020-03-17 12:55:57 -07:00
Jonas Finnemann Jensen
a4d30c1607
Add a comment for path dependencies in plugin example template (#50978) 2020-03-17 20:31:52 +01:00
Jonah Williams
a7011c4817
[flutter_tools] don't force service worker cache files to be absolute (#52606) 2020-03-17 10:17:03 -07:00
Jenn Magder
93a6057c42
Add SDK location unit tests (#52691) 2020-03-16 16:02:22 -07:00
Jenn Magder
2f216ceee5
Add timeout flag to devices command, pipe through discovery (#51678) 2020-03-16 14:15:00 -07:00
Jonah Williams
028b7dced1
[flutter_tools] remove context from WebWorkflow (#52613) 2020-03-16 11:33:00 -07:00
Michael Thomsen
e167181444
Move flutter_gallery to the testing folder (#52532)
Move Flutter Gallery to dev/integration_tests/ as it is an older copy used only for testing. The current version of the Flutter Gallery now lives in https://github.com/flutter/gallery.
2020-03-16 10:31:42 +01:00
Jenn Magder
73ea37eca9
Revert "Fall back to environment SDKROOT passed from Xcode (#52570)" (#52583)
This reverts commit 8e6e15f915.
2020-03-13 18:29:09 -07:00
Jenn Magder
8e6e15f915
Fall back to environment SDKROOT passed from Xcode (#52570) 2020-03-13 17:16:56 -07:00
Dan Field
98cf01858c
Fetch tags for version command (#52212) 2020-03-13 17:16:03 -07:00
Jonah Williams
bbc5b9d967
Revert "[flutter_tools]: reland android device cleanup (#52542)" (#52579)
This reverts commit 9186dfc34d.
2020-03-13 16:38:59 -07:00
Jonah Williams
3bc36095da
Revert "[flutter_tools]: reland move engine unpack to dart (#52543)" (#52549)
This reverts commit 3e25e60f57.
2020-03-13 09:50:07 -07:00
Jonah Williams
9186dfc34d
[flutter_tools]: reland android device cleanup (#52542) 2020-03-13 09:42:02 -07:00
Jonah Williams
3e25e60f57
[flutter_tools]: reland move engine unpack to dart (#52543)
Reland of #50707
2020-03-13 09:40:55 -07:00
Jonah Williams
b3a37d0273
[flutter_tools] support toggling CanvasKit rendering on with 'k' (#52511) 2020-03-13 07:02:34 -07:00
Jonah Williams
1e8c4572ec
Revert "[flutter_tools] remove globals in AndroidDevices (#52505)" (#52515)
This reverts commit 1bf9d6f4f7.
2020-03-12 18:14:32 -07:00
Christopher Fujino
14d8534c3e
add usbmuxd (#52500) 2020-03-12 17:36:01 -07:00
Jonah Williams
1bf9d6f4f7
[flutter_tools] remove globals in AndroidDevices (#52505) 2020-03-12 15:51:26 -07:00
Zachary Anderson
0cd2ece539
[flutter_tools] Hanlde OSError in places where we've seen it thrown (#52491) 2020-03-12 14:01:01 -07:00
Shi-Hao Hong
183da8f837
[gen_l10n] Fix suppportedLocales list (#52448)
* Fix suppportedLocales list

* Refactor integration tests for gen_l10n tool to catch exceptions
2020-03-12 12:58:13 -07:00
Jonah Williams
d98213c46f
[flutter_tools] reland: Update background isolates when performing hot reload/restart (#52479)
Reland of #52149
2020-03-12 12:48:05 -07:00
Dan Field
02769001d3
Android SDK test fixes (#52144) 2020-03-12 10:53:23 -07:00
Finn
9e848f3c78
Add ignore public member api docs in template (#52422) 2020-03-12 10:36:02 -07:00
Christopher Fujino
38a8845481
move iosworkflow to globals (#52444) 2020-03-12 10:16:28 -07:00
Dmitry Ratushnyy
1b0fd265bd
[ISSUE-30478] Release cache dir lock acquired by a command on sigint or sigterm (#52194) 2020-03-12 09:11:01 -07:00
Zachary Anderson
04a1b78b75
Revert "[flutter_tools] Update background isolates when performing hot reload/restart (#52149)" (#52476)
This reverts commit edd03a1af8.
2020-03-12 09:02:31 -07:00
Jonah Williams
edd03a1af8
[flutter_tools] Update background isolates when performing hot reload/restart (#52149)
When performing a hot restart, collect isolates without an attached flutter view and send a kill signal. These must have been spawned by running main, so restarting without removing them leads to isolate duplication.

When performing a hot reload, ensure that we send a reloadSources command to every isolate and not just uiIsolates.
2020-03-11 15:52:04 -07:00
Jonah Williams
6804cef587
[flutter_tools] throw exception instead of string from startApp (#52365)
When attempting to start an emulator in profile mode, ensure the daemon can exit gracefully
2020-03-11 09:41:52 -07:00
Emmanuel Garcia
4049889d9e
Make --androidx flag a noop in flutter create (#52340) 2020-03-10 20:05:41 -07:00
Jonah Williams
ea3563ea4d
[flutter_tools] update visual studio and validator to remove globals, update test cases (#51680)
Updates VisualStudio and VisualStudioValidator to use constructors instead of global injection. Updates VisualStudio test cases to prefer FakeProcessManager
Updates build_windows test to work without injected VisualStudio
2020-03-10 16:49:23 -07:00
Zachary Anderson
53dce17b35
[flutter_tools] Fallback discovery: Don't crash when an Isolate has no root library (#52354) 2020-03-10 15:31:02 -07:00
Zachary Anderson
78b45fb1b2
[flutter_tools] Throw a tool exit when samples fetch fails (#52355) 2020-03-10 15:21:02 -07:00
Zachary Anderson
7f564b7436
[flutter_tools] Handle StateError in ProtocolDiscovery.uri (#52337) 2020-03-10 14:26:02 -07:00
Jonah Williams
5d289721fc
[flutter_tools] handle null value from sdk version (#52351)
When the AndroidDevice checks for the current API version, it isn't handling a null response. While we can refuse to run on API levels that are unsupported, we should probably assume that a null response = lowest possible API level and allow these to run.
2020-03-10 14:23:18 -07:00
Zachary Anderson
605debfcff
[flutter_tools] Make AndroidConsole check for next line (#52353) 2020-03-10 14:21:01 -07:00
Ben Konyi
66b978a197
Update pub dependencies to roll forward package:test (#52273) 2020-03-10 13:26:02 -07:00
Zachary Anderson
733fc20073
[flutter_tool] Use unzip -t instead of zip -T to verify zip files (#52331) 2020-03-10 12:22:53 -07:00
Jonah Williams
fdb7bd3c0f
[flutter_tools] attempt to fix .first crasher in web loading (#52301) 2020-03-10 12:09:37 -07:00
Jonah Williams
2133343a29
[flutter_tools] cache result of BotDetector in persistent tool state (#52325)
The Azure bot detection can take up to a second to determine if a client is/isn't a bot. To prevent this from slowing down all flutter commands, we can cache the results in the persistent tool state - since we don't expect the same client id to ever become a bot or stop being a bot
2020-03-10 11:35:52 -07:00
Jonah Williams
377879825e
[flutter_tools] prevent StateError when log reader is disposed (#52173)
Previously the AdbLogReader did async setup in the StreamController.onListen callback, specifically it would query the api version and start the adb process. If the log subscription was cancelled before this setup completed, then the log output could (haven't confirmed) get added to a closed controller, causing the above state error.
2020-03-10 11:34:40 -07:00
Jenn Magder
fdd023fa59
Migrate older Xcode projects off the legacy build system (#52288) 2020-03-10 10:11:16 -07:00
Jonah Williams
60d0fef17a
[flutter_tools] move stack_trace_mapper and require.js into memory file system (#52276) 2020-03-09 22:07:34 -07:00
Jonah Williams
3191af1332
[flutter_tools] add more information to obfuscate option documentation (#52282) 2020-03-09 20:09:47 -07:00
Jonah Williams
88b39402ac
[flutter_tools] configure dwds to not serve devtools (#52284) 2020-03-09 19:20:11 -07:00
Jonah Williams
bc43b41d99
[flutter_tools] ensure --track-widget-creation is not enabled for build aot (#52261)
This option was defaulting to on, which was tickling some benchmarks
2020-03-09 17:19:14 -07:00
George Wright
084a7077ce
Revert "Put fuchsia tools into their own directory, and set source_dir to point at them. (#52266)" (#52277)
This reverts commit ffcc776513.
2020-03-09 16:55:58 -07:00
George Wright
ffcc776513
Put fuchsia tools into their own directory, and set source_dir to point at them. (#52266)
This worksaround an issue with the latest version of package_config which doesn't handle
multiple dart packages sharing the same source directory. In this case, the fuchsia dart_tool
targets were sharing a directory with their dependency, :flutter_tools
2020-03-09 15:08:57 -07:00
Angjie Li
665d380f81
Add Android Chrome support to Flutter Web Driver. (#51677)
* Support Android Chrome for Flutter Web Driver.
2020-03-09 13:01:07 -07:00
Dan Field
e13e17009d
Reland fix --version (#52141) 2020-03-06 21:38:35 -08:00
Dan Field
db1f33fd70
Revert "Local engine build mode (#52043)" (#52152)
This reverts commit 4d05ed5deb.
2020-03-06 16:57:18 -08:00
Jonah Williams
c1112d3f7e
[flutter_tools] Reland: Allow providing dart-defines to Android, iOS, macOS builds (#52044) 2020-03-06 14:53:36 -08:00
Christopher Fujino
2e18cd347e
Fix simctl process exceptions not being caught (#51916) 2020-03-06 13:16:01 -08:00
Dan Field
a42d38a2f8
Fix flaky test (#52088) 2020-03-06 13:01:42 -08:00
Jonah Williams
e7d70fbf75
Revert "Fix version command for certain git workflows (#52062)" (#52128)
This reverts commit 20bf43b9eb.
2020-03-06 12:58:00 -08:00
Jenn Magder
a14ac4e3c8
Bump recommended CocoaPods version to 1.8 (#52071) 2020-03-06 12:14:42 -08:00
Jenn Magder
f6a55125d2
Add usage event for failed iOS project migration (#51879) 2020-03-06 12:14:29 -08:00
Zachary Anderson
6c408a0567
Reland: [flutter_tool] Where possible, catch only subtypes of Exception (#52021)
* Reland: [flutter_tool] Where possible, catch only subtypes of Exception

* Add armv7f to getIOSArchForName
2020-03-06 10:22:12 -08:00
Dan Field
20bf43b9eb
Fix version command for certain git workflows (#52062) 2020-03-05 23:51:02 -08:00
Dan Field
4d05ed5deb
Local engine build mode (#52043) 2020-03-05 23:46:02 -08:00
Dan Field
24883e1cf2
Add overrides for FileSystemUtils (#52080) 2020-03-05 22:51:15 -08:00
Jonah Williams
d2f889b4f0
[flutter_tools] Reduce context usage in analyze command and tests (#49589) 2020-03-05 17:20:54 -08:00
Jonah Williams
bafa03e5b5
[flutter_tools] Remove mocking and simplify Dart target tests (#50688) 2020-03-05 17:19:15 -08:00
Jonah Williams
8872d1d8c4
[flutter_tools] Reland: supports tree-shake-icons for web builds (#52054) 2020-03-05 17:18:44 -08:00
Dan Field
6ad807e3a0
More fixes for randomizing test order (#52060) 2020-03-05 17:14:27 -08:00
Jenn Magder
b8472f25ab
Update Maven URL to https (#52042) 2020-03-05 16:00:34 -08:00
Jonah Williams
35bf5ab5d0
[flutter-tools] add awaits to debug a potential timing issue (#52047) 2020-03-05 15:24:28 -08:00
Jonah Williams
b127868db4
[flutter_tools] update web template to remove some absolute paths (#52040) 2020-03-05 13:59:57 -08:00
Jonah Williams
ad16823e4c
[flutter_tools] support new SDK structure for sdkmanager (#51980) 2020-03-05 13:59:20 -08:00
Jonah Williams
c411f588c6
Revert "[flutter_tools] supports tree-shake-icons for web builds (#51808)" (#52045)
This reverts commit aed961993d.
2020-03-05 13:02:22 -08:00
Jonah Williams
ee476a7bd1
Revert "[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714)" (#52041)
This reverts commit ee60eeea3e.
2020-03-05 12:51:42 -08:00
Jonah Williams
ee60eeea3e
[flutter_tools] Allow providing dart-defines to Android, iOS, macOS builds (#51714) 2020-03-05 12:38:40 -08:00
Jonah Williams
aed961993d
[flutter_tools] supports tree-shake-icons for web builds (#51808)
* [flutter_tools] supports tree-shake-icons for web builds

* Update compile.dart

* fix icon_tree_shaker
2020-03-05 12:35:04 -08:00
Jonah Williams
1bf6f0232e
[flutter_tools] support coverage and machine together (#51988) 2020-03-05 12:34:37 -08:00
Jonah Williams
bbf913bc4c
[flutter_tools] resolve requests to web directory in debug mode (#51995) 2020-03-05 12:34:03 -08:00