Commit Graph

1740 Commits

Author SHA1 Message Date
Emmanuel Garcia
81724bd60f
Fallback to protocol discovery if mdns returns null (#45439) 2019-11-25 11:51:54 -08:00
Michael Klimushyn
901eb0fc81
Add a note to generated plugins files (#45557)
There has been some confusion about whether or not
.flutter-plugins-dependencies should be tracked in version control or
not. Added a comment to both it and .flutter-plugins explaining that
it's generated and shouldn't be.

.flutter-plugins-dependencies is parsed through JSON, and the JSON spec
doesn't support comments. So unfortunately the note is living in an
arbitrary "_info" key instead of an obvious top level comment.
2019-11-25 11:47:20 -08:00
Jenn Magder
4cc10a1fb8
Revert "Always compile with isysroot on iOS to point to SDK root (#45436)" (#45555)
Analyzer warning.
2019-11-25 10:46:42 -08:00
Jenn Magder
6b11f18bc0
Always compile with isysroot on iOS to point to SDK root (#45436) 2019-11-25 10:27:22 -08:00
Alexandre Ardhuin
980f14e0c5
implicit-casts:false on flutter_tools (#45153)
* implicit-casts:false on flutter_tools

* use castStringKeyedMap

* address review comments

* address review comments

* fix issues after rebase
2019-11-24 06:54:43 +01:00
Emmanuel Garcia
b6e92003c8
Add .flutter-plugins-dependencies to the project, which contains the app's plugin dependency graph (#45379) 2019-11-22 15:02:20 -08:00
Jonah Williams
b54bb6abbb
Dont crash if the tool cannot delete asset directory during debugging (#45407) 2019-11-22 14:06:05 -08:00
Jonah Williams
35b571ccfc
Revert "Improve time to development by initializing frontend_server concurrently with platform build (#45236)" (#45422) 2019-11-22 13:36:12 -08:00
Jonah Williams
c63c576bca
Reland handle corrupt config file (#45414) 2019-11-22 12:26:51 -08:00
Jonah Williams
60869e0a93
Improve time to development by initializing frontend_server concurrently with platform build (#45236) 2019-11-22 12:26:31 -08:00
xster
942707591d
Revert "catch parse error from corrupt config (#45319)" (#45412) 2019-11-22 10:56:16 -08:00
Jonah Williams
6640c8b9b4
catch parse error from corrupt config (#45319) 2019-11-22 10:09:23 -08:00
Jonah Williams
497ae83c82
Fix experimental incremental web compiler for Windows (#45286) 2019-11-22 10:08:38 -08:00
Yegor
aa3943316b
Fix dartDefines in daemon mode (#45317)
* de-null dartDefines in daemon mode
* remove daemonCommand; pipe through dartDefines into Daemon
* pass dartDefiles in attach; add test for --machine mode
2019-11-22 08:57:14 -08:00
Greg Spencer
a60bf8e23a
Spell check of Flutter docs (#45200)
No code changes, just comments: I spell-checked all the comments in the repo.
2019-11-22 08:43:55 -08:00
Amir Hardon
e43a69a9fe
Allow a no-op default_package key for a plugin platform (#45364) 2019-11-21 16:37:34 -08:00
Zachary Anderson
05226d2a61
Reland: [flutter_tool] Fuchsia AOT builds (#45350)
* Reland: [flutter_tool] Fuchsia AOT builds

* Fixes
2019-11-21 12:55:39 -08:00
Jonah Williams
785e557a43
remove Flags (#45320) 2019-11-21 12:52:52 -08:00
Zachary Anderson
0216953674
Revert "[flutter_tool] Fuchsia AOT builds (#45187)" (#45349)
This reverts commit a57dddd217.
2019-11-21 09:41:46 -08:00
Zachary Anderson
a57dddd217
[flutter_tool] Fuchsia AOT builds (#45187) 2019-11-21 08:32:58 -08:00
Emmanuel Garcia
5df4b7db23
Reland: Attach looks at future observatory URIs (#45307) 2019-11-20 18:51:25 -08:00
Amir Hardon
53c7ca7d5a
Allow unknown fields in pubspec plugin section (#45303) 2019-11-20 17:00:46 -08:00
Jonah Williams
106b8eb9c0
Revert "Reduce some direct package:archive usage (#44608)" (#45291)
This reverts commit 6b5634fed3.
2019-11-20 14:45:32 -08:00
Jonah Williams
6b5634fed3
Reduce some direct package:archive usage (#44608) 2019-11-20 13:32:14 -08:00
Danny Tuppeny
73c32545b7
Fix device daemon test when desktop or web are enabled (#45172) 2019-11-20 11:02:35 +00:00
Emmanuel Garcia
fb5e49082b
Revert "Attach looks at future observatory URIs (#45228)" (#45237)
This reverts commit 2135e9fb1e.
2019-11-19 23:14:25 -08:00
Emmanuel Garcia
2135e9fb1e
Reland: Attach looks at future observatory URIs (#45228) 2019-11-19 21:43:52 -08:00
Jonah Williams
c724504142
Update Android CPU device detection (#45139) 2019-11-19 19:04:17 -08:00
Emmanuel Garcia
7a0911b47a
Revert "Attach looks at future observatory URIs (#44637)" (#45211)
This reverts commit 6d77996d6a.
2019-11-19 16:47:39 -08:00
Emmanuel Garcia
6d77996d6a
Attach looks at future observatory URIs (#44637) 2019-11-19 15:11:41 -08:00
Danny Tuppeny
37eec86294
Allow web server device to use extension if started with --start-paused (#44263)
* Allow web server device to use extension if started with --start-paused

* Fix comment

* Remove browser-launch option that allowed using Chrome without launching Chrome

The web-server device should now be used if you don't want to launch a browser.

* Add tests for WebServerDevice with --start-paused

* Fixes from rebase

* More fixes from rebase

* Fix from rebase

* Fix condition for page refresh in non-debug builds

* Make dwds conditions match with a new getter

* Add missing .device
2019-11-19 20:11:53 +00:00
Jonah Williams
df3505c1f3
Improve performance of build APK (~50%) by running gen_snapshot concurrently (#44534) 2019-11-19 11:26:07 -08:00
Jonah Williams
e236196037
cache sdkNameAndVersion logic for web devices (#45145) 2019-11-19 09:36:24 -08:00
Alexandre Ardhuin
adc7351046
implicit-casts:false on flutter_tools/lib (#44447)
* implicit-casts:false on flutter_tools/lib

* address review comments

* use castStringKeyedMap

* introduce {bool,string,strings}Arg

* fix ci
2019-11-19 07:57:42 +01:00
Jonah Williams
58438fca3f Provide specific field to accept depfiles in target class (#44481)
* add depfile slot to Target class

* Update source.dart

* Update source.dart
2019-11-18 14:09:40 -08:00
Jonah Williams
a7367b650b
Don't log stack traces to console on build failures (#44966) 2019-11-18 14:04:11 -08:00
Christopher Fujino
ff84b3e66d catch IOSDeviceNotFoundError in IOSDevice.startApp() (#45011) 2019-11-18 13:53:55 -08:00
Danny Tuppeny
81f6ba84b9
Switch from using app.progress to app.webLaunchUrl for passing web launch urls (#44268)
* Switch from using app.progress to app.url for passing web launch urls

* Update daemon.md

* Change app.url -> app.webLaunchUrl

* Add tests for app.webLaunchUrl event

* Update tests with recent changes after rebasing
2019-11-18 18:10:15 +00:00
Jonah Williams
2a576b774c
remove no-gen-bytecode flag (#43908) 2019-11-15 13:15:05 -08:00
Zachary Anderson
29c026fac4
[flutter_tool] Don't crash when failing to delete downloaded artifacts (#44933)
* [flutter_tool] Don't crash when failing to delete downloaded artifacts

* Add space

* Add more spaces.
2019-11-15 10:05:45 -08:00
Danny Tuppeny
5376e90fda
Print a message when modifying settings that you may need to reload IDE/editor (#44574)
* Print a message when modifying settings that you may need to reload IDEs/editors

* Add a test for `flutter config` output

* Remove blank line
2019-11-14 17:54:22 +00:00
Jonah Williams
e77c24ef91
Update package test (#44882) 2019-11-14 09:31:36 -08:00
Jenn Magder
25b33a8c3b
Fake locale in doctor_test (#44878) 2019-11-13 19:08:10 -08:00
Jenn Magder
6498f64399
Catch and display version check errors during doctor (#44868) 2019-11-13 18:23:05 -08:00
Jonah Williams
e3cb2c3fcf
Reland: Allow specifying device-vmservice-port and host-vmservice-port (#44853) 2019-11-13 16:02:46 -08:00
Jonah Williams
985da83139
Revert "Allow specifying device-vmservice-port and host-vmservice-port (#44027)" (#44843)
This reverts commit c0af77bf87.
2019-11-13 14:35:07 -08:00
Emmanuel Garcia
0019599411
Build AAR for all build variants by default (#44797) 2019-11-13 13:27:10 -08:00
Jonah Williams
c0af77bf87
Allow specifying device-vmservice-port and host-vmservice-port (#44027) 2019-11-13 13:01:41 -08:00
Emmanuel Garcia
f766871eb9
Forward ProcessException to error handlers (#44783) 2019-11-13 10:02:46 -08:00
Jonah Williams
7caef218b5
refactorings to testbed.run and testbed.test (#44488) 2019-11-12 15:35:59 -08:00
Jonah Williams
2779361b38
Ensure web-server does not force usage of dwds (#44744) 2019-11-12 15:24:45 -08:00
Jonah Williams
3383b564a1
Always link desktop platforms (#44753) 2019-11-12 15:24:18 -08:00
xster
9e0df259df
Show a warning when a module uses a v1 only plugin (#44499) 2019-11-11 15:56:43 -08:00
Yegor
e7073f9a1f
add --dart-defines option (#44083) 2019-11-09 17:08:53 -08:00
Jonah Williams
9fa0f3b2ea
fix test for null flutter root (#44468) 2019-11-08 14:38:44 -08:00
Jonah Williams
978fada33c
Refactor flutter.gradle to use assemble directly (#43876)
Removes multiple re-entrant calls of bundle and aot and replaces them with a single call to assemble. This restores full caching and will allow follow-up performance improvements when building multiple ABIs
2019-11-08 12:41:24 -08:00
Jonah Williams
cc51ad5d08
Reland: enable usage of experimental web compiler (#44400) 2019-11-07 20:13:02 -08:00
chunhtai
6a9b72c16b
fixing todo comments in flutter tests to include url link. (#42691) 2019-11-07 17:34:36 -08:00
Jonah Williams
7535ef735f
Revert "Enable usage of experimental incremental compiler for web (#43576)" (#44396)
This reverts commit e5d6d92498.
2019-11-07 16:32:20 -08:00
Jonah Williams
e5d6d92498
Enable usage of experimental incremental compiler for web (#43576) 2019-11-07 16:29:51 -08:00
Zachary Anderson
12c190f746
[flutter_tool] Stream artifact downloads to files (#44360) 2019-11-07 14:01:57 -08:00
Emmanuel Garcia
b0ad6072ef
Don't print how to consume AARs when building plugins as AARs (#44301) 2019-11-07 10:18:55 -08:00
Emmanuel Garcia
cb614d1339
Fix v1 embedding support heuristic for plugins (#44214) 2019-11-07 08:24:19 -08:00
xster
d2e87a5d2c
Build ios framework (#44065) 2019-11-06 14:54:15 -08:00
Emmanuel Garcia
bb8cf609ec
Build local maven repo when using local engine (#44243) 2019-11-06 12:52:37 -08:00
Jonah Williams
383e90eb13
Use platform appropriate filepaths when constructing asset bundle (#44221) 2019-11-06 12:50:18 -08:00
Jonah Williams
aa333fda25
link platform should be true for profile (#44279) 2019-11-06 12:21:41 -08:00
Kaushik Iska
8e8add524e
[flutter_tool] Screenshot command must require device only for _kDeviceType (#44227)
There are cases where we have access to the observatory without having a device connection accessible.
2019-11-06 10:59:29 -08:00
James D. Lin
1f0c3d462e
Make ProjectFileInvalidator injectable (#44200)
Allow ProjectFileInvalidator to be overridden with a different
implementation.

I stole this from https://github.com/flutter/flutter/pull/39217.
2019-11-05 21:40:48 -08:00
chunhtai
7aebde1904
added new lifecycle state (#39945)
* added new lfecycle state

* update

* update
2019-11-05 20:03:09 -08:00
Michael Klimushyn
02aac5072c
Revert "Exit tool if a plugin supports the embedding v2 but the app doesn't (#44026)"
This missed some plugins that _do_ support the v1 embedding
(shared_preferences as one known case) so caused unexpected breakages.

This reverts commit b94c1a41ca.
2019-11-05 14:38:09 -08:00
Kaushik Iska
7dceec21f7
[flutter_tool] --flutter_runner will download the debug symbols (#44119)
This makes the flutter tool download the debug symbols for Flutter and Dart runners to be used in Fuchsia dev environment.
2019-11-05 14:07:48 -08:00
xster
ba26f926c7
Add Android embedding version analytics (#44043) 2019-11-05 12:38:42 -08:00
Zachary Anderson
372fe290e4
[flutter_tool] Update analytics policy, send event on disable (#43217) 2019-11-05 10:43:52 -08:00
Jonah Williams
0f6c093d68
Remove Source.behavior, fix bug in depfile invalidation (#43945)
* remove Source.behavior, fix bug in depfile invalidation

* more cleanup of assets

* Add skip

* address comments

* Update build_system.dart
2019-11-04 16:37:43 -08:00
Emmanuel Garcia
76957c9da8
build aar prints how to consume the artifacts (#44127) 2019-11-04 16:28:27 -08:00
Emmanuel Garcia
b94c1a41ca Exit tool if a plugin supports the embedding v2 but the app doesn't (#44026) 2019-11-04 13:37:51 -08:00
Jonah Williams
3422540bc4
copy chrome preferences to seeded data dir (#44032) 2019-11-04 09:09:20 -08:00
Jonah Williams
5e1bb20c83
support --no-resident on the web (#44028) 2019-11-04 09:08:40 -08:00
Jonah Williams
f1186b0758
Asset server fix for sourcemaps (#44017) 2019-11-01 22:33:52 -07:00
Emmanuel Garcia
ade8dfac3d
Move the plugin registrant to io.flutter.plugins and add the @Keep annotation (#44011) 2019-11-01 16:58:26 -07:00
Jenn Magder
2e7d9130b2
Observe logging from VM service on iOS 13 (#43915) 2019-11-01 14:37:17 -07:00
Jonah Williams
71740bef74
remove listDartSources (#43950) 2019-11-01 11:06:24 -07:00
Jonah Williams
7d4a968f0c
make more spinner tests not flaky (#43955) 2019-11-01 10:55:15 -07:00
Jonah Williams
0cd8cef8f5
require awaiting Testbed.run (#43952) 2019-11-01 10:55:04 -07:00
Emmanuel Garcia
dea35da040
Log additional Android build failures (#43941) 2019-11-01 10:06:23 -07:00
Jonah Williams
a192e29603
check for instanceof instead of runtimeType and wait for testbed (#43870) 2019-10-31 19:31:42 -07:00
Jonah Williams
a60a47ae2c
Serve correct mime type on release dev server (#43907) 2019-10-31 14:57:34 -07:00
Emmanuel Garcia
175b37247d
Refactor gradle.dart (#43479) 2019-10-31 13:19:15 -07:00
Jonah Williams
79323f7c13
Ensure target platform is passed is always passed to assemble (#43862) 2019-10-30 19:40:19 -07:00
Jonah Williams
79bc6cafc5
implement build aot with assemble for Android target platforms (#43282) 2019-10-30 15:23:25 -07:00
Zachary Anderson
d0d8e6edcb
[flutter_tool] Teach the tool about local engine Fuchsia artifacts (#43759) 2019-10-30 14:11:18 -07:00
Jonah Williams
417449e2f3
Deflake flutter tool logger test (#43800) 2019-10-30 13:09:26 -07:00
Jonah Williams
349d694fb7
Revert "Added a null check for ranges in the sourceReport map. (#43667)" (#43827)
This reverts commit 0dc5ea4a95.
2019-10-30 10:57:35 -07:00
Efthymis Sarmpanis
c5b3b3ac26 Flutter doctor should require java 1.8+ (#41989) 2019-10-30 10:40:27 -07:00
Nate Bosch
7cf362fc31 Handle onError callback with optional argument (#43436)
Check for a binary callback first since a function with an optional
second argument will match both typedefs.

Remove documentation around a synchronous error following some other
error or value - a synchronous error can never follow a value or an
asynchronous error. If there is a synchronous error it will _always_ be
the first thing to happen.

Add a test for a unary error handler and an error handler with an
optional stack trace argument.
2019-10-30 10:39:50 -07:00
Larry McKenzie
0dc5ea4a95 Added a null check for ranges in the sourceReport map. (#43667) 2019-10-30 10:35:45 -07:00
stuartmorgan
f6f6e86eb8
Split desktop config fallback variable by platform (#43758)
The environment variable for all desktop platforms is currently
ENABLE_FLUTTER_DESKTOP to allow backward compatibility with existing
workflows. However, this is actually causing issues since 'flutter
config' provides a better experience (most importantly, IDEs will work
correctly, which is generally not the case with the environemnt
variable). Currently people following old (third-patry) instructions
don't realize that they are missing available functionality, so aren't
looking for the current instructions.

In adddition, this will be confusing as different platform graduate to
channels other than master at different times.

To resolve both issues, the environment variable fallback is now
separate for each desktop platform, and follows a naming scheme
consistent with the web environment variable.
2019-10-29 21:43:25 -07:00
Jonah Williams
9cb2047139
Make Spinner test case use mockStopwatch (#43761) 2019-10-29 21:36:19 -07:00
Jonah Williams
50da3bd062
check if libimobiledevice executables exist (#43767) 2019-10-29 21:35:51 -07:00