Commit Graph

4214 Commits

Author SHA1 Message Date
Danny Tuppeny
801ad5cd5a
Don't terminate Dart process pids from VM Service, record flutter_tools VM pid (#100223)
* Don't terminate Dart process pids from VM Service

These processes may be on another device, and in the case of attach the debugee should not be terminated anyway.
2022-03-23 16:31:31 +00:00
Anurag Roy
74f08c7352
[flutter_tools] Skip version freshness check for non-standard remotes (#97202) 2022-03-22 12:50:21 -07:00
Chris Bracken
fd3c34c9d4
[macOS] Use arm64 snapshot in arm64 App.framework (#100504)
Previously, https://github.com/flutter/flutter/pull/100271 enabled
building universal macOS binaries by default, but included a bug causing
the arm64 App.framework to be built such that the TEXT section
containing the app instructions built by gen_snapshot incorrectly
contained x86_64 instructions rather than arm64 instructions.

When building macOS (and iOS) apps, Flutter builds them in three
components:
* The Runner application: built by Xcode
* The bundled App.framework: built from assembly code generated by
  gen_snapshot from the application's Dart sources.
* The bundled FlutterMacOS.framework: built as part of the engine build
  and packaged by copying the distributed binary framework from our
  artifacts cache.

Building App.framework consists of the following steps:
* For each architecture, invoke gen_snapshot to generate
  architecture-specific assembly code, which is then built to object
  code and linked into an architecture-specific App.framework.
* Use the `lipo` tool to generate a universal binary that includes both
  x86_64 and arm64 architectures.

Previously, we were building architecture specific App.framework
binaries. However, for all architectures we were (mistakenly) invoking
the general `gen_snapshot` tool (which emitted x64 instructions, and
which is now deprecated) instead of the architecture-specific
`gen_snapshot_x86` and `gen_snapshot_arm64` builds which emit
instructions for the correct architecture.

This change introduces a small refactoring, which is to split the
`getNameForDarwinArch` function into two functions:
* `getDartNameForDarwinArch`: the name for the specified architecture as
  used in the Dart SDK, for example as the suffix of `gen_snapshot`.
* `getNameForDarwinArch`: the name for the specified architecture
  as used in Apple tools, for example as an argument to `lipo`. For
  consistency, and to match developer expectations on Darwin platforms,
  this is also the name used in Flutter's build outputs.

Issue: https://github.com/flutter/flutter/issues/100348
2022-03-21 20:36:57 -07:00
Jesús S Guerrero
50f3e47b67
Revert "[flutter_tools] remove pub dependencies from universal #97722" (#100508) 2022-03-21 19:20:10 -07:00
gaaclarke
97258979df
Revert "Starts using the --source flag to compile the dart registrant. (#98046) (#100493) 2022-03-21 13:40:23 -07:00
Dan Field
ff74557c3a
Specify destination when building for macOS (#100315)
Fixes #86590
2022-03-17 16:39:05 -07:00
Jesús S Guerrero
03b4f2bf50
[flutter_tools] process exception during linux_doctor is handled (#100159) 2022-03-17 16:15:22 -07:00
Danny Tuppeny
b39a9473f8
Handle Flutter.Error events and disable structure errors for noDebug mode (#100149) 2022-03-17 16:05:21 -07:00
Christopher Fujino
e99a66a47e
[flutter_tools] check if stream is open before sending message in ios device (#99947) 2022-03-17 15:55:24 -07:00
Chris Bracken
a618ca27a7
[macOS] Enable universal binary builds by default (#100271)
This changes the default build architectures for Flutter macOS apps to
x86_64 and arm64. Previously, we manually excluded arm64 builds via the
EXCLUDE_ARCHS Xcode setting in Flutter's generated xcconfig file. This
eliminates setting EXCLUDE_ARCHS during the build and updates the
default architectures in the tool and in the macos_assemble.sh wrapper.

Issue: https://github.com/flutter/flutter/issues/97681
Umbrella issue: https://github.com/flutter/flutter/issues/60113
2022-03-17 12:28:39 -07:00
Brian Quinlan
f6c4c3df19
Remove unnecessary ignore: override_on_non_overriding_member (#99793) 2022-03-16 19:10:17 -07:00
Gary Qian
63ff7a199b
MigrateConfig and migrate integration testing base (#99092) 2022-03-16 11:10:22 -07:00
iroiroys
6f6b5647f5
Add more specific cause on web development tool error output (#98553) 2022-03-15 18:15:07 -07:00
Lau Ching Jun
722cbc52b8
Add portForwarder for ProxiedDevice. (#100111) 2022-03-15 14:30:21 -07:00
Christopher Fujino
bb4a5fa7ab
[flutter_tools] exec rather than spawn subprocess from bin/internal/shared.sh (#99871) 2022-03-14 13:35:18 -07:00
Ben Konyi
1880066dd3
Update dependencies (#99874) 2022-03-10 14:13:59 -07:00
Chris Yang
291b286417
[tool] Add CADisableMinimumFrameDurationOnPhone to iOS templates (#94509) 2022-03-09 14:15:20 -08:00
Jeff Ward
0aab22807c
First pass at using platform abstraction for plugins (#92672) 2022-03-09 14:10:21 -08:00
Lau Ching Jun
dbed10bb59
Pass 'assume-initialize-from-dill-up-to-date' flag to the frontend server (#99791) 2022-03-09 00:30:17 -08:00
Jenn Magder
dd97133df2
Remove tool crash git.io link shortener (#99574) 2022-03-08 17:00:06 -08:00
Tacca
c8538873c8
95533 min sdk error msgs enhancements (#99550) 2022-03-08 16:20:21 -08:00
Jesús S Guerrero
fbbf3ec471
Support route on ios (#99078) 2022-03-07 11:31:21 -08:00
Anurag Roy
b02150781f
[flutter_tools] Add timeout duration to error and handle exceptions for HttpHostValidator. (#98290) 2022-03-07 11:21:06 -08:00
Jenn Magder
7596a3daf6
Add logging when first frame is not rendering (#99566) 2022-03-04 17:16:21 -08:00
Jonah Williams
59859df126
Add Windows performance benchmark (#99564) 2022-03-04 15:41:14 -08:00
Mathieu Dubois-Briand
020bf31c99
Fix custom-device default forwardPortSuccessRegex (#97719) 2022-03-04 11:06:22 -08:00
Greg Spencer
fa68ecf7c6
Fix the race condition in cache_test.dart (#99423)
This fixes a race condition in test/integration.shard/cache_test.dart which allowed the test to fail if the machine took a very long time to acquire a lock or launch a process.
2022-03-03 12:55:47 -08:00
Jenn Magder
8f360c977a
Update minimum required version to Xcode 13 (#97746) 2022-03-01 16:26:11 -08:00
gaaclarke
fdcd14464c
Starts using the --source flag to compile the dart registrant. (#98046)
* Starts using the `--source` flag to compile the dart registrant.

* updated general.shard tests

* Fixed the resident compiler flow

* added integration test

* made the integration test self contained

* renamed generated_main to dart_plugin_registrant

* cleaned up for review

* added task runner for ci

* added bringup and TESTOWNERS

* updated failure message
2022-03-01 16:24:47 -08:00
Emmanuel Garcia
9cb60c9828
Revert "reads min/target sdk versions from localproperties" (#99191) 2022-02-28 11:41:22 -08:00
Jenn Magder
c80ff45afe
Print events and views when first frame is taking awhile during tracing (#98957) 2022-02-28 11:16:12 -08:00
stuartmorgan
80660b2d5e
Work around VS CMake generation bug (#98945) 2022-02-26 11:56:22 -08:00
Jenn Magder
9369bd3222
Wait for ios-deploy stdout before closing logLine stream (#99041) 2022-02-24 19:21:23 -08:00
Danny Tuppeny
76758ef960
[dap] Don't use --start-paused when running in Profile/Release mode (#98926) 2022-02-24 17:06:24 -08:00
Tacca
37a1aaf8c1
reads min/target sdk versions from localproperties (#98450) 2022-02-24 12:16:15 -08:00
Jenn Magder
320d2cff64
Increase recommended CocoaPods version to 1.11 (#98621) 2022-02-24 12:11:21 -08:00
keyonghan
c178cf859f
Skip can validate flutter version in parallel test in Linux web_tool_tests (#99017) 2022-02-23 14:19:20 -08:00
Alexander Dahlberg
47b5ed3948
Removed no-shuffle tag and fixed order dependency in daemon_test.dart (#98970) 2022-02-23 12:49:07 -08:00
Lau Ching Jun
6a9ac4509b
Add option in ProxiedDevice to only transfer the delta when deploying. (#97462) 2022-02-23 12:09:16 -08:00
Alexander Dahlberg
4a2737401f
Fixed order dependency and removed no-shuffle-tag in build_ios_framew… (#94699)
* Fixed order dependency and removed no-shuffle-tag in build_ios_framework_test.dart

* Removed trailing spaces in build_ios_framework_test.dart

* Removed unnecessary formatting
2022-02-23 08:39:11 +01:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint (#98753) 2022-02-22 14:39:20 -08:00
Zachary Anderson
54a9d65282
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)"" (#98803) 2022-02-19 10:09:26 -08:00
Christopher Fujino
4b2e828924
[flutter_tools] deprecate the dev branch from the feature system (#98689) 2022-02-18 16:24:22 -08:00
Emmanuel Garcia
c8266d34f4
Improve Gradle retry logic (#96554) 2022-02-18 13:54:41 -08:00
Ben Konyi
4add01ab68
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#98769)
This reverts commit ac3c44355a.
2022-02-18 13:28:42 -08:00
Christopher Fujino
081d960237
[flutter_tools] remove flaky web vm service test (#98540) 2022-02-18 11:54:23 -08:00
Tim Sneath
5c7ca2e738
Remove "beta-quality" for Windows (#98614) 2022-02-17 16:44:23 -08:00
Jenn Magder
cef6823637
Dump backtrace when cannot attach to observatory (#98550) 2022-02-16 14:10:18 -08:00
Christopher Fujino
4a11cc4b9c
[flutter_tools] do not validate maven upstream if cloud storage override provided (#98293) 2022-02-15 11:40:15 -08:00
Ben Konyi
2a2f973120
Update flutter_tools to look for new VM service message (#97683)
* Update flutter_tools to look for new VM service message

The Dart SDK will soon move away from the current Observatory message:

"Observatory listening on ..."

To a new message that no longer references Observatory:

"Dart VM Service listening on ..."

This change updates all tests with mocks to check for the new message
and also adds support for the new message in ProtocolDiscovery.

See https://github.com/dart-lang/sdk/issues/46756

* Fix some parsing locations

* Fix analysis failures

* Update message

* Remove extra comment

* Update message

* Add globals prefix
2022-02-15 07:33:57 -08:00
Christopher Fujino
87fe3fe031
rename two unit tests that were not actually being run on CI (#98299) 2022-02-14 17:40:13 -08:00
Jesús S Guerrero
f523ddd2d6
[flutter_tools] remove pub dependencies from universal (#97722) 2022-02-12 12:10:11 -08:00
Jenn Magder
262a963efb
flutter_build_null_unsafe_test print failed build output (#98310) 2022-02-11 22:00:18 -08:00
Christopher Fujino
289988dc62
[flutter_tools] fix type error in flutter update-packages --jobs=n (#98283) 2022-02-11 14:50:18 -08:00
Taha Tesser
d6d3283c8d
Fix flutter gen-l10n help message (#98147) 2022-02-11 01:40:14 -08:00
Brian Quinlan
76855aa893
Add keyLog and connectionFactory to HttpClient implementations (#98045) 2022-02-11 00:35:16 -08:00
Daco Harkes
bb3275b934
Add debugging info to android_plugin_example_app_build_test (#98107) 2022-02-09 09:20:13 -08:00
Emmanuel Garcia
d2b5f34bc4
Revert "Fix how Gradle resolves Android plugin" (#98050) 2022-02-08 12:30:05 -08:00
Emmanuel Garcia
965397cfde
Fix how Gradle resolves Android plugin (#97823) 2022-02-07 11:05:14 -08:00
Danny Tuppeny
c659ad6ace
Add support for attachRequest in DAP, running "flutter attach" (#97652)
* Add support for attachRequest in DAP, which runs "flutter attach"

* Update DAP docs for attachRequest

* Improve doc comments

* Fix comments

* Remove noDebug from attach + create a getter for `debug`

* Fix indent
2022-02-07 18:54:07 +00:00
Christopher Fujino
1d59d8d341
[flutter_tools] increment y instead of m when calling flutter --version on master (#97827) 2022-02-04 13:35:29 -08:00
Lau Ching Jun
26d1da4188
Fix error in type cast. (#97778) 2022-02-04 12:40:11 -08:00
Michael Tamm
1fcb076eb7
[flutter_tools] Fix bundle file not found when flavor contains upperc… (#92660) 2022-02-04 11:55:20 -08:00
stuartmorgan
7eb1035af6
Restructure Windows plugin template (#93511) 2022-02-03 20:30:18 -08:00
Jenn Magder
ac52901c14
Export an IPA for distribution via "flutter build ipa" without --export-options-plist (#97672) 2022-02-02 19:28:25 -08:00
Jonah Williams
0b72d5ca58
[flutter_tool] allow disabling profile mode timeline traces (#97622) 2022-02-02 16:00:16 -08:00
Jason Simmons
ba4d63a47b
Exit the tool if a DevTools subprocess fails when running on a bot (#97613) 2022-02-02 14:55:18 -08:00
Zachary Anderson
e50ca9acbc
Reland: [flutter_tool] Download gen_snapshot.zip for macOS desktop (#97671) 2022-02-02 14:43:55 -08:00
Lau Ching Jun
a504b93774
Addresses the feedbacks in #95738 (#97457) 2022-02-02 13:55:22 -08:00
Zachary Anderson
f82c020071
Revert "[flutter_tool] Download gen_snapshot.zip for macOS desktop (#97627)" (#97664)
This reverts commit 32abf42a00.
2022-02-02 11:29:28 -08:00
Lau Ching Jun
d7688ca093
Change all instance of throwing strings to throw specific error classes. (#97325) 2022-02-02 10:45:18 -08:00
Zachary Anderson
32abf42a00
[flutter_tool] Download gen_snapshot.zip for macOS desktop (#97627) 2022-02-02 10:21:31 -08:00
Collin Jackson
10fbbafe09
[flutter_tools] Use proper project name in templates (#96373) 2022-02-02 06:50:14 -08:00
Jenn Magder
802d872d40
Revert "Export an IPA for distribution via "flutter build ipa" without --export-options-plist" (#97616) 2022-02-01 18:26:23 -08:00
Jenn Magder
6ceb418b58
Export an IPA for distribution via "flutter build ipa" without --export-options-plist (#97243) 2022-02-01 16:13:21 -08:00
Jenn Magder
a599c23b2b
Disallow running on unsupported devices (#97338) 2022-02-01 16:13:03 -08:00
Caio Agiani
29b44f79d9
packages: fix typos recieve => receive (#97488) 2022-01-31 08:43:15 -08:00
Danny Tuppeny
4fa0e0d449
Make DAP tests more tolerant of output that didn't come from the app being tested (#97291)
Fixes #97238.
2022-01-29 10:03:31 +00:00
Christopher Fujino
da88baffd7
[flutter_tools] remove dummy implementation from abstract class .isEnabled() (#96888) 2022-01-28 16:40:12 -08:00
Danny Tuppeny
942de67838
Make remaining DAP tests null-safe (#97368) 2022-01-27 20:08:17 +00:00
Daco Harkes
0e2f51dfd0
FFI plugins (#96225) 2022-01-26 23:44:45 +01:00
Zachary Anderson
657bca4b7f
[tool] Use an arm64 Dart SDK on arm64 macOS (#97189) 2022-01-26 11:30:20 -08:00
Lau Ching Jun
1065826686
ProxiedDevice, connection to a remotely connected device via flutter daemon. (#95738)
Also allow daemon commands to pass binary streams
2022-01-25 23:46:14 -08:00
Christopher Fujino
610b41e88c
[flutter_tools] add validation of paths of contained files to os_utils _unpackArchive() (#96565) 2022-01-25 18:10:12 -08:00
Alexander Aprelev
752de49450
Fix hot-restart test by ensuring updated timestmamp is in the future. (#97247)
On Windows modified timestamps are round down to a second, which can lead to missed file updates.

Fixes https://github.com/flutter/flutter/issues/96677
2022-01-25 14:18:33 -08:00
Jenn Magder
c1710723f7
Take drive screenshot on test failure before app is stopped (#96973) 2022-01-25 11:50:14 -08:00
Christopher Fujino
6b95add2fe
[flutter_tools] auto-migrate dev users to beta (#97028) 2022-01-25 11:00:14 -08:00
Christopher Fujino
78de12b82f
[flutter_tools] Fix bug in background_isolate_test.dart (#97170) 2022-01-25 09:55:10 -08:00
stuartmorgan
2dd8cb1ca2
Don't use example folder as a project type signal (#97157)
The code to generate platform files used to use the presence of an
'example' folder to determine whether or not a project was a plugin (in
which case that generation is bypassed). Later, robust detection was
added based on the pubspec.yaml `plugin` key, but the old check was left
in place. This creates false positives where people who add an example
folder to their app project start getting mysterious failures.

Since the pubspec check is definitive, there's no reason to continue to
use the presence of `example` as an indicator at all.

Fixes https://github.com/flutter/flutter/issues/87007
2022-01-24 19:28:38 -08:00
Jesús S Guerrero
75127a8007
[flutter_tools] support files in flutter analyze #96231 (#97021) 2022-01-24 17:10:16 -08:00
Zachary Anderson
62e745612a
Use frontend_server from the Dart SDK (#97078) 2022-01-24 11:34:57 -08:00
Zachary Anderson
761b109bc8
Adjust lipo thinning input/output for macOS (#97111) 2022-01-24 10:21:22 -08:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers (#96422) 2022-01-21 14:43:59 -08:00
Danny Tuppeny
9d64e94a87
Fix SDK versions for Flutter packages in analyze tests (#96950)
Fixes https://github.com/flutter/flutter/issues/96931.
2022-01-20 14:40:42 -08:00
Jenn Magder
ef8a841035
Take screenshot when drive fails to start app or test (#96828) 2022-01-19 21:35:19 -08:00
Jenn Magder
114185f686
Pass 'build ios' device ID into xcodebuild (#96669) 2022-01-19 10:20:11 -08:00
stuartmorgan
25b2edbda0
Enable inline Dart plugin implementation on Desktop (#96610) 2022-01-19 09:35:23 -08:00
Jenn Magder
3c0f3f4ee1
Add boxes around version freshness alerts (#96152) 2022-01-18 17:28:32 -08:00
wangying
3138cce7b2
feat: support configure a custom launch url for flutter web (#95002) 2022-01-18 09:50:20 -08:00
keyonghan
792a40ed83
Skip flaky test: background_isolate_test.dart: Hot restart kills background isolates (#96678) 2022-01-14 16:20:20 -08:00
Jenn Magder
219dd6ca38
Migrate assemble and integration_test_device to null safety (#96630) 2022-01-14 15:50:12 -08:00
Jonah Williams
e25e1f9037
[framework] dont null assert in _debugVerifyIllFatedPopulation (#96551) 2022-01-14 13:50:29 -08:00
Pooja Bhaumik
79e4ccf649
Fix wrong documentation URL for adding desktop support to existing app (#94399) 2022-01-13 10:55:20 -08:00
Spt
7de1e225de
fix rsync output utf8decode bug (#95881) 2022-01-13 10:20:20 -08:00
stuartmorgan
2df7dca858
Fully support Dart-only mobile and macOS plugins (#96183) 2022-01-13 08:30:22 -08:00
Chris Bracken
20ff180ae8
Update Flutter desktop doc URL in error message (#96559)
When desktop support is not present in an existing project, certain
flutter tool commands raise an error that direct the user to
documentation on how to add desktop support to an existing Flutter
project. In a recent revamp of the webside, the URL was very slightly
changed (flutter.dev -> docs.flutter.dev).

This updates the error message to output the new URL.

Issue: https://github.com/flutter/flutter/issues/94398
2022-01-12 18:21:05 -08:00
Emmanuel Garcia
683590d1c6
Add suggestion for compileSdkVersion warning (#95369) 2022-01-10 20:30:13 -08:00
Zachary Anderson
fb29403c42
Revert "feat(flutter_tools): Added doctor path printing on verbose" (#96414) 2022-01-10 15:35:13 -08:00
Jenn Magder
1c0eade94c
Hide PII from doctor validators for GitHub template (#96250) 2022-01-10 13:20:21 -08:00
Greg Spencer
23e7449a07
Warm cache with all transitive dependencies in flutter update-packages command (#96258) 2022-01-10 10:35:13 -08:00
Jenn Magder
db5c71f448
Fix analyze --watch command iterator (#96264) 2022-01-07 17:15:08 -08:00
crisboarna
0fef7a140a
feat(flutter_tools): Changed NoIdeValidator validation type from error to warning (#95492) 2022-01-06 14:05:19 -08:00
crisboarna
f8e70a8463
feat(flutter_tools): Added doctor path printing on verbose (#95453) 2022-01-06 13:50:19 -08:00
Jenn Magder
18c59cdb1c
Migrate build commands to null safety (#95649) 2022-01-05 16:45:12 -08:00
Jenn Magder
0287449c14
Do not show v1 Android embedding message for non-Android commands (#96148) 2022-01-05 12:55:10 -08:00
Lau Ching Jun
7f0050f5b3
Add a new PrebuiltFlutterApplicationPackage interface. (#95290)
* Add a new PrebuiltFlutterApplicationPackage interface.

* Review feedback

* Rename bundleDir to uncompressedBundle
2022-01-05 07:54:57 -08:00
Zachary Anderson
65c6e88223
Revert "FFI plugins (#94101)" (#96122)
This reverts commit 5257f0290c.
2022-01-04 08:09:12 -08:00
Daco Harkes
5257f0290c
FFI plugins (#94101)
* Building shared C source code as part of the native build for platforms Android, iOS, Linux desktop, MacOS desktop, and Windows desktop.
* Sample code doing a synchronous FFI call.
* Sample code doing a long running synchronous FFI call on a helper isolate.
* Use of `package:ffigen` to generate the bindings.
2022-01-04 10:14:27 +01:00
Christopher Fujino
2d2cd1f5c0
[flutter_tools] Refactor checkVersionFreshness (#95056) 2021-12-28 17:59:16 -08:00
Jenn Magder
aa4ef4cb2a
Revert "[flutter_tools] [iOS] Change UIViewControllerBasedStatusBarAppearance to true to fix rotation status bar disappear in portrait" (#95747) 2021-12-23 14:19:18 -08:00
Jenn Magder
5432688561
Migrate install command to null safety (#95433) 2021-12-22 14:54:10 -08:00
Jenn Magder
a5137399dd
Migrate analyze commands to null safety (#95442) 2021-12-22 12:14:19 -08:00
Lau Ching Jun
df384c4809
Reland "Add an option for flutter daemon to listen on a TCP port (#95418)" (#95689)
Fixes the test brekage and reverts commit caed03df05.
2021-12-22 10:53:31 -08:00
Zachary Anderson
caed03df05
Revert "Add an option for flutter daemon to listen on a TCP port (#95418)" (#95686)
This reverts commit 2b46ea447f.
2021-12-22 08:47:58 -08:00
Lau Ching Jun
2b46ea447f
Add an option for flutter daemon to listen on a TCP port (#95418)
* Add an option for flutter daemon to listen on a TCP port

Added a new class DaemonConnection to reuse the connection handling
between daemon server and client, and handle connection with different
medium (stdio, socket).

Added a new option `listen-on-tcp-port` to the flutter daemon command,
when passed, the daemon will accept commands on a port instead of stdio.

* Review feedback and add test for TcpDaemonStreams

* Review feedbacks
2021-12-22 06:21:04 -08:00
Jenn Magder
c584a5ead4
Migrate fuchsia_device to null safety (#95438) 2021-12-21 18:39:04 -08:00
Chris Yang
1c4128c703
Xcode error message (#94747) 2021-12-21 08:39:18 -08:00
嘟囔
4f5cc21be2
migrate some file to null safety (#92957) 2021-12-16 11:39:12 -08:00
crisboarna
eb1a851f58
feat(flutter_tools): Added doctor host validation feat (#95386) 2021-12-16 08:02:13 -08:00
crisboarna
1fb9b5b3d2
feat(flutter_tools): Added proxy validator IPV6 loopback check (#95159)
* feat(flutter_tools): Added proxy validator IPV6 lookback check

* Remove whitespace.

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2021-12-16 07:56:45 -08:00
Danny Tuppeny
7e1e98c356
Add support for executing custom tools in place of Flutter for DAP (#94475) 2021-12-15 13:29:05 -08:00
Emmanuel Garcia
79bc1bfa89
Add ability to wrap text messages in a box (#94391) 2021-12-15 13:19:11 -08:00
嘟囔
6d1938e647
migrate integration.shard/vmservice_integration_test.dart to null safety (#92812) 2021-12-15 13:09:15 -08:00
Jenn Magder
6ab00756a8
Build Flutter iOS plugins with all valid architectures (#95293) 2021-12-14 16:49:06 -08:00
Chris Yang
e4dadf788b
[tool] xcresult issue discarder (#95273) 2021-12-14 13:29:13 -08:00
Lau Ching Jun
8186fb7435
Use XML format in PlistParser (#94863)
* Switch to use xml in PlistParser

* Review feedbacks: Change dynamic to Object, remove getValueFromFile
2021-12-13 18:22:29 -08:00
Chris Yang
70fea6d250
[tool] XCResult also parses "url" in xcresult bundle (#95054) 2021-12-13 16:04:04 -08:00
Jia Hao
2f80384a7f
[flutter_tools] Remove --enable-background-compilation (#94012) 2021-12-13 10:24:08 -08:00
Lau Ching Jun
5cb09e779a
Removed unused method packagesFile from ApplicationPackage. (#95033)
The method name is confusing and the implementation in different
subclasses are pointing to different things.
2021-12-13 06:46:04 -08:00
Sergey Fedotov
2a4e573dcd
Serve assets with correct content-type header value (#94357) 2021-12-08 12:29:07 -08:00
Jenn Magder
f7bd20fc09
Detect additional ARM ffi CocoaPods error (#94385) 2021-12-07 15:29:03 -08:00
Anna Gringauze
d7466d8963
Update dwds and other packages (#94634) 2021-12-07 14:29:07 -08:00
Gary Qian
da4e997ed3
Short circuit v1 deprecation warning on plugin projects (#94769) 2021-12-07 01:53:50 -08:00
Gary Qian
dd6a11b7aa
Add reason logging to v1 embedding warning message (#94636) 2021-12-06 14:21:58 -08:00
Jia Hao
4517d16b53
[flutter_tools] Fix incorrect todo (#94597) 2021-12-03 11:34:10 -08:00
Yegor
48a5cf9225
[tool] verify download URLs; docs for base URLs (#94178) 2021-12-02 10:11:36 -08:00
Hannes Winkler
bccc9eaca7
Fix a stream lifecycle bug in CustomDeviceLogReader (#94310) 2021-12-01 18:34:04 -08:00
Danny Tuppeny
b865e23aeb
Don't treat stderr output as failures during DAP test teardown (#94335) 2021-12-01 07:19:04 -08:00
Anna Gringauze
ca62470796
De-flake web tool tests (#93948) 2021-11-30 17:39:05 -08:00
Chris Wong
7ef5226799
Migrate to process 4.2.4 (#92630) 2021-11-30 17:14:07 -08:00
Jenn Magder
361d416e6a
Add post-submit failing test to close the tree for #94356 (#94390) 2021-11-29 22:01:32 -08:00
Zachary Anderson
fc60e6690b
Add failing test to close the tree for #94356 (#94365) 2021-11-29 12:34:25 -08:00
Nate Bosch
6d1a840bc5
Roll packages, remove unnecessary overrides (#94172) 2021-11-24 14:43:05 -08:00
Yegor
a2a888ec13
make CIPD url customizable using FLUTTER_STORAGE_BASE_URL (#94137) 2021-11-24 07:53:03 -08:00
Mouad Debbar
30b6b9e7f0
Revert "Update Xcode toolsVersion encoded in generated Main.storyboard (#94084)" (#94164)
This reverts commit 6a3ea7eb83.
2021-11-24 10:12:53 -05:00
Jenn Magder
6a3ea7eb83
Update Xcode toolsVersion encoded in generated Main.storyboard (#94084) 2021-11-23 17:38:02 -08:00
Danny Tuppeny
77fca35877
[DAP] Add a custom event to pass flutter.serviceExtensionStateChanged… (#93870) 2021-11-22 20:12:33 -08:00
Tarekk Mohamed Abdalla
fae84f6714
[gen_l10n] Add support for adding placeholders inside select (#92753) 2021-11-22 20:08:03 -08:00
Andrei Diaconu
924336fcee
Reland 3: Display Features (#93240) 2021-11-20 15:48:06 -08:00
Danny Tuppeny
99e85b1c5f
Disable pause-on-exceptions for (outgoing) isolates during hot restart (#93411) 2021-11-18 22:23:09 -08:00
Jenn Magder
b460d0ee34
Migrate emulators to null safety (#92738) 2021-11-18 22:13:06 -08:00
moko256
570e39d38b
Win32 template: Use {{projectName}} for FileDescription instead of {{description}} (#91959) 2021-11-18 10:03:04 -08:00
Jenn Magder
e56c83a1ac
Migrate build_system targets to null safety (#92869) 2021-11-17 16:31:37 -08:00
Danny Tuppeny
c6d4625232
Ensure the flutter_gen project is correctly created as part of "flutter create" (#92975) 2021-11-17 12:03:04 -08:00
Hans Muller
09d08510d0
Revert "allow full locale in .arb files (#93401)" (#93806)
This reverts commit 16f441188c.
2021-11-17 11:26:16 -08:00
Taha Tesser
16f441188c
allow full locale in .arb files (#93401) 2021-11-17 09:35:47 -08:00
Konoshenko Vlad
ee87f6113e
fix: removed unnecessary checks (#93735) 2021-11-16 18:43:05 -08:00
Gary Qian
02b1146cff
Reland "Exit on deprecated v1 embedding when trying to run or build" (#92901) (#93566) 2021-11-12 15:52:32 -08:00
Christopher Fujino
e8ec8a0dfb
[flutter_tools] Catch lack of flutter tools source missing (#93168) 2021-11-12 14:43:52 -08:00
Jenn Magder
a25dca4a06
Ad-hoc codesign Flutter.framework when code signing is disabled (#93556) 2021-11-12 12:56:03 -08:00
pan
7ce6d414d4
add --extra-gen-snapshot-options support for build_aar command. (#91590) 2021-11-12 11:11:02 -08:00
Jason Simmons
e9519d8a1a
Restore Cache.flutterRoot after overriding it in a test (#93555)
Fixes https://github.com/flutter/flutter/issues/93553
2021-11-12 10:32:13 -08:00
Yegor
24b9346c9b
Revert "Reland "Exit on deprecated v1 embedding when trying to run or build (#92901)" (#93386)" (#93518)
This reverts commit eabb7cbc34.

It broke multiple tests.
2021-11-11 16:45:40 -08:00
Gary Qian
eabb7cbc34
Reland "Exit on deprecated v1 embedding when trying to run or build (#92901)" (#93386) 2021-11-11 14:49:35 -08:00
Kenzie (Schmoll) Davisson
7748731903
Add DevTools version to flutter --version and flutter doctor -v output. (#93065)
* Add DevTools version to `flutter --version` output.

* review comments

* fix test

* add explanatory comment

* dummy commit to kick bots

Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
2021-11-11 14:40:22 -08:00
Core
d8034538bd
feat: enable flavor option on test command (#89045) 2021-11-11 09:23:02 -08:00
stuartmorgan
7e05d103e9
Add support for Visual Studio 2022 (#93426) 2021-11-10 16:43:02 -08:00
Greg Spencer
52ae102f18
Adds tool warning log level and command line options to fail on warning/error output (#92031) 2021-11-10 16:13:04 -08:00
Shueh Chou Lu
e8b3fe8aa6
Use num on plural (#93228) 2021-11-10 08:47:25 -08:00
Zachary Anderson
858a328712
Revert "Exit on deprecated v1 embedding when trying to run or build (#92901)" (#93365)
This reverts commit 6153bbef3e.
2021-11-09 22:22:14 -08:00
Gary Qian
6153bbef3e
Exit on deprecated v1 embedding when trying to run or build (#92901) 2021-11-09 17:38:03 -08:00
Camille Simon
977c35307f
Add warning for bumping Android SDK version to match plugins (#92451) 2021-11-09 12:58:07 -08:00
J-P Nurmi
550281e581
[gen_l10n] retain full output file suffix (#88362) 2021-11-08 13:55:19 -08:00
Jenn Magder
6cbed01db3
Migrate windows_device to null safety (#92956) 2021-11-07 01:27:34 -07:00
Zachary Anderson
2468f315e0
Revert "Reland: display features (#93117)" (#93204)
This reverts commit 9038fac960.
2021-11-06 22:46:46 -07:00
Jenn Magder
31933af486
Update minimum required version to Xcode 12.3 (#93094) 2021-11-05 16:08:04 -07:00
Jenn Magder
296eeb5971
Migrate custom_device to null safety (#92955) 2021-11-05 16:03:03 -07:00
Jenn Magder
f4d1bfedd2
Migrate tracing to null safety (#92849) 2021-11-05 15:58:07 -07:00
Andrei Diaconu
9038fac960
Reland: display features (#93117) 2021-11-05 15:54:25 -07:00
Emmanuel Garcia
15d0a8be1c
Pin to specific plugin version in multidex test (#93148) 2021-11-05 11:17:32 -07:00
Zachary Anderson
7779ad3c60
Revert "Reland engine display features (#89511)" (#93098)
This reverts commit 058dfd49a0.
2021-11-04 23:05:45 -07:00
Andrei Diaconu
058dfd49a0
Reland engine display features (#89511) 2021-11-04 18:37:55 -07:00
Jenn Magder
261ea1baef
Suppress created file list for new "flutter create" projects (#93041) 2021-11-04 10:03:02 -07:00
Yegor
773789344e
[web:tools] always use CanvasKit from the cache when building web apps (#93002) 2021-11-03 17:48:25 -07:00
keyonghan
71e38aaa07
Skip overall_experience_test.dart: flutter run writes and clears pidfile appropriately (#93026) 2021-11-03 16:06:34 -07:00
jensjoha
a6441004aa
[flutter_tools] Instruct compiler before processing bundle (#92255) 2021-11-02 13:46:46 +01:00
Jenn Magder
9e88fe328e
Remove globals_null_migrated.dart, move into globals.dart (#92861) 2021-11-01 17:18:03 -07:00
嘟囔
38b0389121
feat: mirgate test_data/compile_error_project.dart to null safety (#92808) 2021-11-01 17:13:05 -07:00
Jenn Magder
8865212254
Migrate doctor to null safety (#92131) 2021-11-01 12:13:02 -07:00
Chris Yang
04156b6636
[flutter_tools] xcresult parser. (#92604) 2021-10-29 18:29:31 -07:00
Jenn Magder
0c9a420583
Migrate android_device to null safety (#92128) 2021-10-29 17:19:33 -07:00
Jenn Magder
53e04de681
Migrate mdns_discovery and ios simulator to null safety (#92124) 2021-10-29 17:18:03 -07:00
Christopher Fujino
b0810bc939
Fix analysis throwing string (#91435) 2021-10-29 17:02:05 -07:00
嘟囔
41167c957d
feat: migrate macos/macos_device.dart to null safety (#92633) 2021-10-29 16:14:35 -07:00
嘟囔
bd935e5d4f
feat: migrate test_data/project.dart to null safety (#92646) 2021-10-29 11:38:05 -07:00
Wu Zhong
365d76c527
[flutter_tools] [iOS] Change UIViewControllerBasedStatusBarAppearance to true to fix rotation status bar disappear in portrait (#92647) 2021-10-28 19:58:01 -07:00
Danny Tuppeny
57dbf7f7e7
Add support for running tests through debug-adapter (#92587)
* Add support for running tests through debug-adapter

* Improve comments about stdout + remove pedantic
2021-10-28 11:34:05 +01:00
Jenn Magder
aff69e43ef
Add integration_test to flavor test project (#92520) 2021-10-27 12:53:05 -07:00
Jenn Magder
b279ff4178
Run flutter tester with arch -x86_64 on arm64 Mac (#92508) 2021-10-27 10:48:03 -07:00
Jason Simmons
c8504242fd
Remove the pub offline flag from tests of the flutter_tools create command (#92534) 2021-10-27 09:33:05 -07:00
stuartmorgan
ed61608a9d
Set TargetFile define for resident builds (#92511)
Dart plugin registration generation depends on the target main file
being set as a define so that it's available in the environment, but the
resident runner wasn't setting it. That worked for initial builds
because of the re-entrant call to `assemble` (which does set it), but
caused Hot Restart to always re-generate the wrapper using
lib/main.dart.

This ensures that the define is set in that codepath as well.

Fixes https://github.com/flutter/flutter/issues/91535
2021-10-27 09:25:15 -07:00
Danny Tuppeny
de966d8a49
Add a "flutter debug_adapter" command that runs a DAP server (#91802) 2021-10-27 06:48:06 -07:00
Christopher Fujino
acf6464996
skip failing test (#92529) 2021-10-26 18:16:02 -07:00
Emmanuel Garcia
4d79bb02c4
Bump Kotlin version in templates and projects (#92052) 2021-10-25 13:13:03 -07:00
Sigurd Meldgaard
67499b50cc
Add new pub command 'Token' (#91014) 2021-10-25 11:35:27 +02:00
Yegor
ad7727a21c
[web] enable CanvasKit tests using a local bundle fetched from CIPD (#92134) 2021-10-21 11:13:18 -07:00
Ben Konyi
ac3c44355a
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)" (#92220)" (#92235)
This reverts commit ba0321e95d.
2021-10-20 22:05:49 -07:00
Ben Konyi
ba0321e95d
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#92220)
This reverts commit dc7fea8d19.
2021-10-20 19:20:17 -07:00
Christopher Fujino
44bf975115
remove Downloading ... stderr messages (#92211) 2021-10-20 17:13:02 -07:00
Jenn Magder
305a855f6d
Migrate integration test shard test data to null safety (#92147) 2021-10-20 14:58:05 -07:00
Chris Yang
42eb903200
[flutter_tools] iOS: display name defaults to the Title Case of flutter project name. (#91529) 2021-10-20 10:33:02 -07:00
Emmanuel Garcia
2bdbe7238c
Rewire all Dart entrypoints when the Dart plugin registrant is used. (#91856) 2021-10-19 20:23:04 -07:00
Jenn Magder
8ab4de021c
Migrate desktop_device to null safety (#92055) 2021-10-19 12:28:04 -07:00
Jenn Magder
8474f41e90
Migrate xcdevice and ios devices to null safety (#92056) 2021-10-19 12:23:03 -07:00
Gary Qian
0407aa4480
Reland "Add multidex flag and automatic multidex support (#90944)" (#92049) 2021-10-19 02:20:39 -07:00
Christopher Fujino
34ec94a16d
[flutter_tools] migrate web_device.dart to null-safety (#91632) 2021-10-19 01:33:08 -07:00
Emmanuel Garcia
d7631275fe
Bump targetSdkVersion to 31 and organize static values (#91719) 2021-10-15 13:41:48 -07:00
Jenn Magder
a82c50f1f6
Revert "Migrate xcdevice and ios devices to null safety (#91704)" (#91912)
This reverts commit 0065873670.
2021-10-15 09:48:08 -07:00
Jenn Magder
6c9259ae7c
Revert "Migrate desktop_device to null safety (#91705)" (#91911)
This reverts commit 59a6ba7cf8.
2021-10-15 09:41:03 -07:00
Ian Hickson
2f4e3ce5b0
Improve error message for when you're not running chromedriver (#91789) 2021-10-14 22:38:05 -07:00
Jenn Magder
59a6ba7cf8
Migrate desktop_device to null safety (#91705) 2021-10-14 22:33:02 -07:00
Jenn Magder
0065873670
Migrate xcdevice and ios devices to null safety (#91704) 2021-10-14 22:28:02 -07:00
Zachary Anderson
a9c31eca48
Revert "Add multidex flag and automatic multidex support (#90944)" (#91791)
This reverts commit 1d9edde079.
2021-10-13 23:09:50 -07:00
Gary Qian
1d9edde079
Add multidex flag and automatic multidex support (#90944) 2021-10-13 17:48:04 -07:00
omerlevran46
4b1b65118e
[fuchsia] - remove device-finder for device discovery (#91502)
device-finder binary is being from removed from the Fuchsia SDK
in fxb/85985.
2021-10-13 16:04:27 -04:00
Ben Konyi
dc7fea8d19
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)" (#90611)" (#91754)
This reverts commit e89a885fab.
2021-10-13 12:45:45 -04:00
Ben Konyi
e89a885fab
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#90611)
This reverts commit 58944e6b88.
2021-10-13 10:13:30 -04:00
Danny Tuppeny
5fd1d36ecc
Limit 10 second future modification-date in integration test to only where required for reloads (#91300)
This prevents all of the `flutter run` calls immediately re-running `flutter pub get` when it has already been run by test setup code.
2021-10-13 10:44:55 +01:00
Jenn Magder
6987c9fb82
Migrate crash_reporting and github_template (#91516) 2021-10-12 13:48:03 -07:00
Jenn Magder
1dbafdb53b
Migrate protocol_discovery to null safety (#91267) 2021-10-12 12:13:02 -07:00
Ian Hickson
66dd2add7e
Add some more new lints (#91659) 2021-10-12 11:33:04 -07:00
Jenn Magder
1f25644719
Migrate android build target to null safety (#91455) 2021-10-11 17:55:01 -07:00
Ian Hickson
7b01346c5c
Enable no_default_cases lint (#91530) 2021-10-11 10:23:04 -07:00
Jenn Magder
8930e9b892
Catch FormatException parsing XCDevice._getAllDevices (#90967) 2021-10-08 13:08:04 -07:00
Jenn Magder
6253f9018c
Move DeviceManager into null migrated globals library (#91457) 2021-10-08 12:37:48 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Zachary Anderson
5188df0821
Revert gradle roll (#91459)
* Revert "Mark last failing test after gradle update as flaky. (#91423)"

This reverts commit 46a52d03bd.

* Revert "fix android template for Gradle 7 (#91411)"

This reverts commit 51d06d537f.

* Revert "Add explicit version for mac and windows openjdk. (#91408)"

This reverts commit bf429f2771.

* Revert "Update the openjdk version used by linux android tests. (#91405)"

This reverts commit 2144ab8b45.

* Revert "Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642)"

This reverts commit b6459f9b63.
2021-10-07 19:42:24 -07:00
Christopher Fujino
f753168cb6
[flutter_tools] add working directory to ProcessException when pub get fails (#91436) 2021-10-07 18:08:04 -07:00