Commit Graph

5629 Commits

Author SHA1 Message Date
stuartmorgan
97fb8c0560
Fix Dart plugin registrant interaction with 'flutter test' (#90288)
Building an application for a desktop platform that transitively included any Dart-based plugins (such as path_provider) broke `flutter test`, because its compilation was overriding the provided main (in this case, the test main) with `generated_main.dart` if it was present. This PR:
- Changes the `flutter test` compilation path to update `generated_main.dart`, so that the tests will work, and will include any registered Dart plugins.
- Makes using `generated_main.dart` during recompile opt-in, to try to reduce the chance of a similar bug happening with other codepaths in the future.

Fixes https://github.com/flutter/flutter/issues/88794
2021-09-30 20:25:13 -07:00
Christopher Fujino
738a7747cc
[flutter_tools] Handle disk device not found (#90996) 2021-09-30 17:28:57 -07:00
Jenn Magder
c48c428e46
Xcode 13 as minimum recommended version (#90906) 2021-09-30 12:23:55 -07:00
Greg Spencer
01af8e5987
Make flutter update-packages run in parallel (#91006)
This modifies the flutter update-packages and flutter update-packages --force-upgrade commands so that the many invocations of "dart pub get" in each repo project run in parallel instead of in series.
2021-09-30 10:26:31 -07:00
Jenn Magder
faaca13f22
Catch FormatException from bad simulator log output (#90966) 2021-09-30 09:33:04 -07:00
Kenzie (Schmoll) Davisson
5a85c0d81c
Launch DevTools from the 'dart devtools' command instead of pub (#90894) 2021-09-29 15:32:24 -07:00
Greg Spencer
ab2b0851a2
Add smoke tests for all the examples, fix 17 broken examples. (#89021)
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
2021-09-28 09:32:06 -07:00
Jason Simmons
cd19bc6007
Do not retry if pub get is run in offline mode (#90394) 2021-09-27 08:18:06 -07:00
Christopher Fujino
61bce1d83b
[flutter_tools] remove non-null check from AndroidValidator (#90090) 2021-09-25 16:53:06 -07:00
Jenn Magder
1b53f7beba
Migrate iOS project to Xcode 13 compatibility (#90304) 2021-09-22 13:23:05 -07:00
Jason Simmons
58056bbe74
Close the IntegrationTestTestDevice stream when the VM service shuts down (#90022) 2021-09-17 19:18:03 -07:00
Liam Appelbe
9afbab8477
Use report_lines flag in flutter coverage (#90142)
* Use the report lines flag

* Handle major version bumps in the version check

* Fix existing tests and add a new test
2021-09-16 11:33:32 -07:00
Ahmed Ashour
eb185d73ce
internationalization: fix select with incorrect message (#90096) 2021-09-16 09:23:22 -07:00
Jenn Magder
ab6f2fc8ce
Set BUILD_DIR when determining if plugins support arm64 simulators (#90088) 2021-09-15 18:37:04 -07:00
Michael Thomsen
b889915997
Change min Dart SDK constraint to track actual version (#88743) 2021-09-14 14:08:36 +02:00
Phil Quitslund
975fcc1f2f
master->main deafult branch migration (#89782) 2021-09-10 15:42:03 -07:00
Chase Latta
aed4315a7d
Replace amber_ctl with pkgctl for Fuchsia (#89785)
Fuchsia is deprecating amber_ctl and replacing it with pkgctl.
This change removes the FuchsiaAmberCtl class and replaces it
with the FuchsiaPkgctl class and updates the usages appropriately.

BUG: fxbug.dev/83865
2021-09-10 10:33:45 -07:00
Jenn Magder
84086d8a9c
Clean up null assumptions in vmservice for null safe migration (#89009) 2021-09-09 19:32:02 -07:00
Jenn Magder
855af29084
Migrate ios_deploy to null safety (#88851) 2021-09-09 17:32:05 -07:00
Jenn Magder
58944e6b88
Revert "Enable caching of CPU samples collected at application startup (#89600)" (#89704)
This reverts commit 619121b095.
2021-09-08 19:37:34 -07:00
Ben Konyi
619121b095
Enable caching of CPU samples collected at application startup (#89600) 2021-09-08 17:22:04 -07:00
Jenn Magder
34ba64738e
Clean up null assumptions in devfs to prep for null safety migration (#88934) 2021-09-08 15:27:05 -07:00
Anis Alibegić
a753d09cc9
Fixed several typos (#89485) 2021-09-07 14:56:04 -07:00
Chris Bracken
1c36271b05
Reduce required Windows CMake version to 3.14 (#89390)
When we landed the CMake minimum requirement constraint for Visual
Studio 2019, we landed it with minimum version 3.15, since that's what
was shipping with the current version of VS 2019 at the time. Looking at
the release notes of earlier versions, it's clear that earlier versions
of Visual Studio 2019 shipped with version 3.14. See:
https://devblogs.microsoft.com/cppblog/visual-studio-cmake-support-clang-llvm-cmake-3-14-vcpkg-and-performance-improvements/

Looking at release notes for CMake 3.15, there are no features/fixes
introduced in that version that we are dependent on.
https://cmake.org/cmake/help/latest/release/3.15.html

Issue: https://github.com/flutter/flutter/issues/88589
2021-09-03 21:05:58 -07:00
arfy slowy
202fc02ca1
fix: typo spelling grammar (#88439) 2021-09-03 15:09:31 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets (#86821) 2021-08-30 15:41:02 -07:00
Sigurd Meldgaard
bce366203a
Stop calling top level pub (#89032)
* Use `dart __deprecated_pub` instead of `pub` to invoke pub from tools

The top level `pub` commmand has been deprecated and will print
a message. It is however implemented via the __deprecated_pub command
that prints no message.
2021-08-30 10:40:10 -07:00
Jenn Magder
e6535f6da1
Changed tool cached properties to late finals (#88923) 2021-08-26 14:01:05 -07:00
Jenn Magder
0cb6d5983c
Migrate fuchsia sdk and dependencies to null safety (#88920) 2021-08-25 19:51:04 -07:00
Jenn Magder
d550d497f1
Migrate some flutter_tools tests to null safety (#88850) 2021-08-25 16:21:04 -07:00
Jenn Magder
125451bc2e
Migrate mac.dart to null safety (#88846) 2021-08-25 13:31:03 -07:00
Zachary Anderson
b4e0472b04
Revert "Use dart pub instead of pub to invoke pub from tools (#88509)" (#88792)
This reverts commit 7c24ff2c5b.
2021-08-24 09:00:22 -07:00
Sigurd Meldgaard
7c24ff2c5b
Use dart pub instead of pub to invoke pub from tools (#88509)
Top level `pub` is being deprecated.
2021-08-24 15:51:08 +02:00
Jonah Williams
fa0782b696
reassign jonahwilliams todos (#88707) 2021-08-23 12:27:07 -07:00
Taha Tesser
d72287522b
[tools] Fix Android Studio duplicate detection (#88384) 2021-08-18 02:02:03 -07:00
Jenn Magder
2d55032939
Migrate dds.dart to null safety (#88382) 2021-08-17 21:12:03 -07:00
Taha Tesser
42a6b7913c
[tools] Add Xcode version to non-verbose Flutter doctor (#87022) 2021-08-17 15:52:03 -07:00
Zachary Anderson
3572a7e8b7
Revert "feat: migrate base/dds.dart to null-safety (#88015)" (#88367) 2021-08-17 11:52:05 -07:00
Jonah Williams
060e4608b1
clean up stale or unnecessary TODOS (#88308) 2021-08-16 21:37:03 -07:00
Jason Simmons
ddb8bfb72b
Fix URL construction in the test entry point generated by the web bootstrap script (#88201) 2021-08-16 14:12:05 -07:00
Jenn Magder
57efbd5310
Rename IOSDeviceInterface to IOSDeviceConnectionInterface (#88144) 2021-08-16 10:27:03 -07:00
Zachary Anderson
c5d5463c30
[flutter_tools] Fix hang in DesktopLogReader (#88178) 2021-08-13 17:12:04 -07:00
Jenn Magder
325cfb0f4c
Make doctor Xcode version requirement clearer (#88137) 2021-08-13 17:07:03 -07:00
嘟囔
bf3ff7ec71
feat: migrate fuchsia/application_package.dart to null-safe (#88095) 2021-08-13 00:22:07 -07:00
Anurag Roy
758c28b813
[flutter_tools] Reland "Make upgrade only work with standard remotes" (#87731) 2021-08-12 15:52:07 -07:00
Zachary Anderson
f0e832cdea
[flutter_tool] Fix DesktopLogReader to capture all output (#88116) 2021-08-12 14:57:07 -07:00
Ahmed Ashour
5848a1620d
[gen_l10n] to handle arbitrary DateFormat patterns (#86844) 2021-08-12 14:34:52 -07:00
Jenn Magder
9764d861ca
Support flutter create --platform singular flag (#88076) 2021-08-12 11:42:04 -07:00
嘟囔
047d35d8ba
feat: refactor IosProject and MacOSProject to extends XcodeBasedProject to share common (#87930) 2021-08-11 21:47:05 -07:00
嘟囔
a17723d46b
feat: migrate windows/application_package.dart to null-safety (#88081) 2021-08-11 21:02:03 -07:00
嘟囔
d2f9c6c752
feat: migrate base/dds.dart to null-safety (#88015) 2021-08-11 14:47:06 -07:00
嘟囔
4ef8088ce8
feat: migrate macos/application_package.dart to null-safety (#87976) 2021-08-11 14:42:05 -07:00
Greg Spencer
cb651352dd
Fix errors in examples (#87962) 2021-08-11 14:37:06 -07:00
嘟囔
bffa11e2b6
fix: fix BuildableMacOSApp pass no projectBundleId to super error (#87264) 2021-08-06 14:30:07 -07:00
Lau Ching Jun
95217eb72a
Add new hook for setupHotReload and after updating devFS is complete (#87532)
* Add new hook for setupHotReload and after updating devFS is complete

* Handle the case where updateDevFS failed
2021-08-03 21:09:56 -07:00
Anna Gringauze
44d9af80cb
Flutter_tools for web: report error messages with stacks on exit (#87386)
* Flutter_tools for web platform: report error messages with stacks on toolExit

Print error messages and stacks in verbose mode before calling
`throwToolExit` on communication errors to chrome and dwds.

This will help us disagnose CI flakes:

Helps: https://github.com/flutter/flutter/issues/84012
Closes: https://github.com/flutter/flutter/issues/87149

* Added tests

* Extend timeout for testing failure to connect to chrome

* Update rest of chrome tests to await until matching is finished
2021-08-03 10:51:35 -07:00
Ahmed Ashour
92e02457d5
Handle reserved Kotlin keywords (#86518) 2021-08-02 14:35:05 -07:00
Jenn Magder
7424db448d
Exclude arm64 from iOS app archs if unsupported by plugins on x64 Macs (#87362) 2021-07-30 14:44:04 -07:00
Jenn Magder
a69b3ca5d3
Exclude arm64 from iOS app archs if unsupported by plugins (#87244) 2021-07-30 10:54:34 -07:00
Anurag Roy
ade9f6a9f0
[flutter_tools] Improve toolexit error messages for flutter upgrade (#86351) 2021-07-29 22:00:44 -07:00
Taha Tesser
f9aa5842c2
[tools] Fix Android Studio Arctic Fox Java path on macOS (#87267) 2021-07-29 10:24:07 -07:00
Jenn Magder
2f91679058
Show Android SDK path in doctor on partial installation (#87232) 2021-07-28 19:14:02 -07:00
Greg Spencer
0bab3604b0
Make the startup lock message print to stderr. (#86520)
This changes the "Waiting for another flutter command to release the startup lock..." message output so that it appears on stderr instead of stdout. When it appears on stdout, it can mess up collection of the output. For instance, if you run flutter --version --machine and you're expecting JSON output, then you'll get non-JSON output even though the lock is released and you eventually would get what you're asking for.
2021-07-28 15:12:03 -07:00
Jenn Magder
89637e4e47
Replace iOS physical/simulator bools with enum (#87138) 2021-07-27 16:39:04 -07:00
Emmanuel Garcia
e7a9adeeab
Remove AndroidX workarounds (#86911) 2021-07-23 17:41:04 -07:00
Ahmed Ashour
bf132daef3
[gen_l10n] correct variable name when the placeholder requiresFormatting (#86842) 2021-07-22 13:55:18 -07:00
Ahmed Ashour
9492e13c45
Reland [flutter_tools] show only supported sub commands (#86153) 2021-07-22 13:41:03 -07:00
Jenn Magder
81aeb33ce3
Increase Flutter framework minimum iOS version to 9.0 (#86840) 2021-07-22 13:21:05 -07:00
Jonah Williams
7f26dbe0d4
[flutter] remove elevation checker (#86837) 2021-07-21 21:51:06 -07:00
Emmanuel Garcia
0a8c03dc8a
Show warning when an app or plugin uses the V1 Android embedding (#86750) 2021-07-21 12:51:43 -07:00
Ahmed Ashour
f568d929db
[gen_l10n] Support plurals and selects inside string (#86167) 2021-07-21 12:41:06 -07:00
Taha Tesser
94f71f374f
[flutter_tools] Refactor Android Studio Detection on Windows (support 4.x and 202x releases detection) (#86624) 2021-07-20 12:16:03 -07:00
Remi Rousselet
1995da2c0c
Disable the automatic "pub get" if the project is using a third-party tool for linking dependencies. (#86177) 2021-07-19 08:06:03 -07:00
Ahmed Ashour
838ad83705
Explicitly show "Currently not on an official channel." (#84992) 2021-07-15 21:55:39 -07:00
Lau Ching Jun
f25e4fea18
Remove unnecessary variables. (#86444) 2021-07-15 16:56:04 -07:00
Zachary Anderson
09a38d7a17
Revert "Handle reserved Kotlin keywords (#84973)" (#86512)
This reverts commit a67f618a29.
2021-07-15 14:43:53 -07:00
Ahmed Ashour
a67f618a29
Handle reserved Kotlin keywords (#84973) 2021-07-15 14:26:05 -07:00
Jonah Williams
b549e829e8
[flutter_tools] support trailing args (#86431) 2021-07-14 15:51:10 -07:00
Yegor
81c91924f0
[web] use resident resident runner in flutter drive (#86381)
* [web] use resident resident runner in flutter drive
2021-07-14 08:46:38 -07:00
Jonah Williams
63a4013160
Revert "[flutter_tools] let the logger know about machine mode (#86116)" (#86363)
This reverts commit 53d8cba3ec.
2021-07-13 10:39:35 -07:00
Ian Hickson
d3c17acf9d
Run "pub global activate devtools" before overall_experience_test (#85812) 2021-07-12 14:36:05 -07:00
michaellee8
6a51e0c237
[flutter_tools] Add support for launching fuchsia app using session_control (#85752) 2021-07-12 13:26:05 -07:00
Jonah Williams
53d8cba3ec
[flutter_tools] let the logger know about machine mode (#86116) 2021-07-12 10:41:03 -07:00
Jonah Williams
9d70d9d589
[flutter_tools] fix -n workaround (#86142) 2021-07-09 09:41:04 -07:00
Zachary Anderson
c589a0c322
Revert "[flutter_tools] show only supported sub commands (#85125)" (#86131)
This reverts commit 84e576786c.
2021-07-08 15:58:05 -07:00
Zachary Anderson
53125203ea
[flutter_tool] Pin DevTools to 2.4.0 (#86124) 2021-07-08 15:01:00 -07:00
Ahmed Ashour
84e576786c
[flutter_tools] show only supported sub commands (#85125) 2021-07-08 14:56:06 -07:00
Jacob Richman
1a0d873e2e
Switch drive_service from using deprecated version of --record-memory-profile flag. (#86122) 2021-07-08 14:29:41 -07:00
Alexandre Ardhuin
80990c21e2
code formatting (#85783) 2021-07-07 23:06:05 -07:00
Hannes Winkler
a1e9f2057f
[custom-devices] general improvements, add custom-devices subcommand, better error handling (#82043) 2021-07-07 09:16:04 -07:00
Jonah Williams
ba143ae21e
Update devtools_launcher.dart (#85995) 2021-07-06 22:01:02 -07:00
Shi-Hao Hong
b0bd7cf1d8
make app localizations lookup a public method (#84732) 2021-07-01 15:01:03 -07:00
Ahmed Ashour
a3dc90c4f5
Add space before curly parentheses. (#85306) 2021-07-01 13:51:05 -07:00
Ahmed Ashour
529a599ce6
Fix some indentation (#84967) 2021-07-01 13:41:04 -07:00
Shouichi Kamiya
6c2c702f43
Update outdated ios setup link in error message (#84246) 2021-07-01 13:36:05 -07:00
Jenn Magder
f76b292626
Support iOS arm64 simulator (#85642) 2021-06-30 14:31:04 -07:00
Zachary Anderson
407916d44f
Revert "Support iOS arm64 simulator (#85059)" (#85641)
This reverts commit a1020512ef.
2021-06-30 12:44:49 -07:00
Jenn Magder
a1020512ef
Support iOS arm64 simulator (#85059) 2021-06-30 11:56:17 -07:00
Dan Field
e36e62e9a6
Revert "Revert "Audit hashCode overrides outside of packages/flutter (#85370)" (#85451)" (#85567)
This reverts commit 2be0d57fa2.
2021-06-30 09:46:54 -07:00
Filip Hracek
76d5e62f42
Add a more complete app template for Flutter (skeleton) (#83530) 2021-06-28 15:26:04 -07:00