Sangam Shrestha
d261411b4c
Remove redundant useMaterial3: true ( #163376 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
This PR removes redundant useMaterial3: true as described in
https://github.com/flutter/flutter/issues/162818
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
- https://github.com/flutter/flutter/issues/162818
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
2025-03-14 17:50:20 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
derdilla
aaa4d336f6
Test snack bar examples ( #147774 )
...
Adds tests to the last two Snack Bar examples as part of #130459 . Makes the [last example](https://api.flutter.dev/flutter/material/SnackBar-class.html#material.SnackBar.3 ) more usable through the use of standard widgets and visual hierarchy. Constraints on options that are not required by the SnackBar contract have been removed (Overflow threshold works on fixed SnackBars).
2024-05-23 18:54:11 +00:00
Nate
73ecc8a9b2
Reland "if chains → switch expressions" ( #148634 )
...
I did a goof a while back:
Now that [the bug is fixed](e9d403541fhttps://github.com/flutter/flutter/pull/147793
- https://github.com/flutter/flutter/pull/148556
- https://github.com/flutter/flutter/issues/148548
2024-05-20 17:43:00 +00:00
Zachary Anderson
597462a3c4
Revert "if chains → switch expressions" ( #148556 )
...
Reverts flutter/flutter#147793
Introduced https://github.com/flutter/flutter/issues/148548 .
2024-05-17 10:27:02 -07:00
Nate
4734d80f22
if chains → switch expressions (#147793 )
...
Previous "if-chains" pull requests:
- https://github.com/flutter/flutter/pull/144905
- https://github.com/flutter/flutter/pull/144977
- https://github.com/flutter/flutter/pull/145194
- https://github.com/flutter/flutter/pull/146293
- https://github.com/flutter/flutter/pull/147472
<br>
I think this one should be enough to wrap things up!
fixes https://github.com/flutter/flutter/issues/144903
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2024-05-10 00:55:48 -06:00
Greg Spencer
3d67ca4311
Add missing links to examples that aren't linked anywhere ( #130422 )
...
## Description
This adds links to examples that were not linked anywhere.
## Related Issues
- Fixes #129956
## Tests
- Documentation only change
2023-07-12 20:08:05 +00:00
Greg Spencer
e3bc8efd39
Rename Sample classes ( #124080 )
...
Rename Sample classes
2023-04-04 20:34:29 +00:00
Eilidh Southren
17b4c70ff5
[M3] Add customizable overflow property to Snackbar's action ( #120394 )
...
* add actionOverflowThreshold param
* analyzer tings
* https://www.youtube.com/watch?v=NPwyyjtxlzU
* remove erroneous switch changes
* rename test
* remove unwanted switch.dart diff
* remove redundant values
* review changes
2023-02-14 10:07:02 +00:00
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints ( #117365 )
2022-12-20 16:03:21 -08:00
Eilidh Southren
29422d25fe
M3 snackbar [re-land] ( #116218 )
...
* Add M2 defaults and template skeleton
* add MaterialStateColor functionality to ActionTextColor (issue #110402 )
* Add M2 defaults and template skeleton
* updated material 3 tokens
* Updated snackbar demo
* add theme tests
* add gen defaults
* formatting
* more whitespace fixes
* add widget type
* update docs
* code review changes
* Add line overflow functionality
* whitespace fixes
* update M3 animation
* whitespace fixes
* add insetPadding param
* Modifed icon parameter to showCloseIcon
* white space fixes
* test fixes
* rename iconColor to closeIconColor
* debug test fix
* de-britishification
* g3fix
* g3fix
* debug test fix
2022-11-30 19:13:00 +00:00
Kate Lovett
8b32ac7a51
Revert "Update SnackBar to support Material 3" ( #116199 )
...
* Revert "Update SnackBar to support Material 3 (#115750 )"
This reverts commit d58855c499
2022-11-29 19:11:43 +00:00
Eilidh Southren
d58855c499
Update SnackBar to support Material 3 ( #115750 )
...
* Add M2 defaults and template skeleton
* add MaterialStateColor functionality to ActionTextColor (issue #110402 )
* Add M2 defaults and template skeleton
* updated material 3 tokens
* Updated snackbar demo
* add theme tests
* add gen defaults
* formatting
* more whitespace fixes
* add widget type
* update docs
* code review changes
* Add line overflow functionality
* whitespace fixes
* update M3 animation
* whitespace fixes
* add insetPadding param
* Modifed icon parameter to showCloseIcon
* white space fixes
* test fixes
* rename iconColor to closeIconColor
* debug test fix
* de-britishification
2022-11-29 18:02:34 +00:00
Greg Spencer
e617d003fb
Normalize examples ( #111223 )
2022-09-09 21:17:11 +00:00
Michael Goderbauer
2cbad4b3ae
Final chapter: migrate api doc samples to super-parameters ( #104007 )
2022-05-17 15:35:07 -07:00
Greg Spencer
fd9ce27748
Clean up examples, remove section markers and --template args ( #91133 )
...
This does a cleanup of the examples, removing all of the "section" markers and extra comments that we don't need anymore now that the samples are no longer in the source code. It also removes the --template arguments from the {@tool dartpad} and {@tool sample} directives, since those are no longer used. It converts two examples that I discovered were still embedded into linked examples in the examples folder.
I didn't delete the templates from the snippets config folder yet, because there are still embedded samples in the dart:ui package from the engine that use them. Once dart:ui no longer uses the templates, they can be removed.
I bumped the version of the snippets package to pick up a change that allows removal of the --template argument.
2021-10-04 12:16:17 -07:00
Greg Spencer
33403bd28e
Extract Sample code into examples/api ( #87280 )
...
This extracts the sample code out from the API doc comments, and places them in separate files on disk, allowing running of the examples locally, testing them, and building of slightly larger examples.
2021-08-25 09:45:12 -07:00
