Commit Graph

4106 Commits

Author SHA1 Message Date
Christopher Fujino
d07ce92b15
[flutter_tools] Re-land Dump backtrace on ios app startup timeout (#101763) 2022-04-12 13:24:04 -07:00
Christopher Fujino
2a6582997d
Revert "[flutter_tools] Dump backtrace on ios app startup timeout (#101610)" (#101761)
This reverts commit 2978b59be7.
2022-04-12 09:09:32 -07:00
Christopher Fujino
2978b59be7
[flutter_tools] Dump backtrace on ios app startup timeout (#101610) 2022-04-12 08:49:08 -07:00
Emmanuel Garcia
9e0f0fe9d7
Add Gradle stacktrace and debug log level to verbose builds (#101734) 2022-04-11 20:14:08 -07:00
Christopher Fujino
355fd23a79
[flutter_tools] add test for dart binary arch (#101604) 2022-04-11 16:28:37 -07:00
Yang Chao
343713727a
Enable track widget creation when generating Generated.xcconfig (#101123) 2022-04-11 14:29:11 -07:00
Danny Tuppeny
675b961573
Unpause and remove breakpoints when detaching from Flutter process with DAP (#101695) 2022-04-11 21:15:37 +01:00
Danny Tuppeny
b086473769
Pass multidex flag when using --machine mode (#101689) 2022-04-11 12:19:09 -07:00
Jesús S Guerrero
2302daa3aa
Create when offline style (#101589) 2022-04-11 12:14:05 -07:00
Daco Harkes
85aac37ccf
Add more debugging info to android_plugin_example_app_build_test (#101685) 2022-04-11 08:24:09 -07:00
Janko Djuric
78ae72b0b2
[flutter_tools] Add --build-number and --build-name support to web and linux (#100377) 2022-04-10 11:42:39 -07:00
Chris Yang
1755819cb1
Log XCResult before other build issues (#100787) 2022-04-08 16:27:08 -07:00
Jenn Magder
71d52f27fb
Test Flutter.xcframework directory ios-arm64_armv7 or ios-arm64 (#101592) 2022-04-08 16:12:09 -07:00
Michael Goderbauer
a01424773e
Enable unnecessary_import (#101600) 2022-04-08 12:56:45 -07:00
Anna Gringauze
74944d528f
Run update-packages (#101450)
* Run update-packages

* Update DwdsLauncher, disable failing test

* Fix analyze error

Co-authored-by: Jenn Magder <magder@google.com>
2022-04-07 17:07:05 -07:00
Jesús S Guerrero
3394fb4a58
[flutter_tools] fix flutter create --offline (#100941)
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
2022-04-07 17:05:49 -07:00
Emmanuel Garcia
b528310f58
Specify Kotlin version in modules and refactor (#101315) 2022-04-07 13:20:33 -07:00
Jenn Magder
d745eec051
Add --use-application-binary to "flutter install" (#101324) 2022-04-06 13:17:26 -07:00
creativecreatorormaybenot
96add4192e
Use single quotes for dartSdkVersionBounds (#101270)
* Use single quotes for `dartSdkVersionBounds`

* Update update_packages_test.dart

* Update test_project.dart

* Update tests_project.dart

* Update compile_error_project.dart

* Update hot_reload_with_asset.dart

* Update break_on_framework_exceptions_test.dart

* Update basic_project.dart
2022-04-06 09:54:10 -07:00
Lau Ching Jun
7f64e2ae02
Catch errors in ProxiedDevice to make sure we don't crash on errors. (#101332) 2022-04-06 09:51:10 -07:00
gaaclarke
35b18ba2e9
Made flag for debugging build time of user created widgets (#100926)
* Added a bool that allows us to limit debugProfileBuildsEnabled to user
created widgets.

* made it turned on by default

* switched to hashmap

* Cleaned everything up and added tests

* fixed an odd test where it wants to be able to add asserts and run in profile mode

* hixie feedback

* hixie2

* made it default to false

* updated docstring as per dans request
2022-04-05 10:54:21 -07:00
Jenn Magder
839a183ea6
Add note to doctor validator if script is running Rosetta (#101309) 2022-04-05 10:37:35 -07:00
keyonghan
95f4f473ff
[Revert] Skip overall_experience_test.dart: flutter run writes and clears pidfile appropriately (#101267)
* restore test

* use seed 20211102

* restore seed
2022-04-04 13:26:27 -07:00
Michael Goderbauer
dcde8163ce
migrate to super params (#100509) 2022-03-31 11:46:47 -07:00
Gary Qian
ead5b1c2f4
Retire v1 embedding compatibility from automatic multidex support (#100685) 2022-03-31 10:24:42 -07:00
Chris Bracken
1a072f9aee
[winuwp] Add removal warning in config help text (#101086) 2022-03-31 09:30:04 -07:00
David Iglesias
e52b777a2c
[web] flutter.js initialization with ui.webOnlyWarmupEngine (#100177) 2022-03-30 23:00:09 -07:00
Emmanuel Garcia
5c6918933e
Migrate AGP and Gradle versions to 7.1.2/7.4 (#99723) 2022-03-30 20:30:09 -07:00
Ben Konyi
75baed585e
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#100995) 2022-03-30 13:50:13 -07:00
Sigurd Meldgaard
66ed64be4f
Migrate .packages -> package_config.json (#99677) 2022-03-30 13:56:03 +02:00
Christopher Fujino
b4325b68a2
[flutter_tool] Have long-running validators fail (#100936) 2022-03-28 21:57:44 -07:00
Jenn Magder
a452c92d5d
Set ARCHS to single-arch for local engine macOS builds (#100917) 2022-03-28 18:45:06 -07:00
gaaclarke
912873baa7
Relands "Starts using the --source flag to compile the dart registrant. (#98046)" (#100572) 2022-03-28 18:15:10 -07:00
Chris Bracken
bd6beb4ed7
[Linux] Update doctor wording for Linux (#99700)
Removes the beta-quality wording for Linux from messages in the tool.

Issue: https://github.com/flutter/flutter/issues/99697
2022-03-28 15:45:27 -07:00
Chris Bracken
b6bf325d0a
[macOS] Update doctor wording for macOS (#99699)
Removes the beta-quality wording for macOS from messages in the tool.

Issue: https://github.com/flutter/flutter/issues/98680
2022-03-28 15:44:28 -07:00
Christopher Fujino
9c138f9c76
[flutter_tools] warn when doctor takes long (#100805)
* warn when doctor takes long
2022-03-28 14:13:28 -07:00
Jenn Magder
231c1a4b55
Pass ARCHS build setting to flutter assemble on macOS (#100811) 2022-03-28 10:55:14 -07:00
Zachary Anderson
47f08a3fd6
[flutter_tool] Adds --enable-impeller flag to the run command (#100835) 2022-03-26 20:07:24 -07:00
Alex Li
543a7e8588
Android Q transition by default (#100812) 2022-03-25 22:25:07 -07:00
Chris Yang
c01cbd23cc
Add CADisableMinimumFrameDurationOnPhone migration (#100647) 2022-03-25 17:50:09 -07:00
Anurag Roy
e7ab846d14
[flutter_tools] Fix VersionUpstreamValidator to respect FLUTTER_GIT_URL (#100605) 2022-03-25 17:35:10 -07:00
Jenn Magder
12da4a2aff
Filter out some stray Xcode logging during macOS builds (#100707) 2022-03-25 16:35:11 -07:00
Danny Tuppeny
801ad5cd5a
Don't terminate Dart process pids from VM Service, record flutter_tools VM pid (#100223)
* Don't terminate Dart process pids from VM Service

These processes may be on another device, and in the case of attach the debugee should not be terminated anyway.
2022-03-23 16:31:31 +00:00
Anurag Roy
74f08c7352
[flutter_tools] Skip version freshness check for non-standard remotes (#97202) 2022-03-22 12:50:21 -07:00
Chris Bracken
fd3c34c9d4
[macOS] Use arm64 snapshot in arm64 App.framework (#100504)
Previously, https://github.com/flutter/flutter/pull/100271 enabled
building universal macOS binaries by default, but included a bug causing
the arm64 App.framework to be built such that the TEXT section
containing the app instructions built by gen_snapshot incorrectly
contained x86_64 instructions rather than arm64 instructions.

When building macOS (and iOS) apps, Flutter builds them in three
components:
* The Runner application: built by Xcode
* The bundled App.framework: built from assembly code generated by
  gen_snapshot from the application's Dart sources.
* The bundled FlutterMacOS.framework: built as part of the engine build
  and packaged by copying the distributed binary framework from our
  artifacts cache.

Building App.framework consists of the following steps:
* For each architecture, invoke gen_snapshot to generate
  architecture-specific assembly code, which is then built to object
  code and linked into an architecture-specific App.framework.
* Use the `lipo` tool to generate a universal binary that includes both
  x86_64 and arm64 architectures.

Previously, we were building architecture specific App.framework
binaries. However, for all architectures we were (mistakenly) invoking
the general `gen_snapshot` tool (which emitted x64 instructions, and
which is now deprecated) instead of the architecture-specific
`gen_snapshot_x86` and `gen_snapshot_arm64` builds which emit
instructions for the correct architecture.

This change introduces a small refactoring, which is to split the
`getNameForDarwinArch` function into two functions:
* `getDartNameForDarwinArch`: the name for the specified architecture as
  used in the Dart SDK, for example as the suffix of `gen_snapshot`.
* `getNameForDarwinArch`: the name for the specified architecture
  as used in Apple tools, for example as an argument to `lipo`. For
  consistency, and to match developer expectations on Darwin platforms,
  this is also the name used in Flutter's build outputs.

Issue: https://github.com/flutter/flutter/issues/100348
2022-03-21 20:36:57 -07:00
Jesús S Guerrero
50f3e47b67
Revert "[flutter_tools] remove pub dependencies from universal #97722" (#100508) 2022-03-21 19:20:10 -07:00
gaaclarke
97258979df
Revert "Starts using the --source flag to compile the dart registrant. (#98046) (#100493) 2022-03-21 13:40:23 -07:00
Dan Field
ff74557c3a
Specify destination when building for macOS (#100315)
Fixes #86590
2022-03-17 16:39:05 -07:00
Jesús S Guerrero
03b4f2bf50
[flutter_tools] process exception during linux_doctor is handled (#100159) 2022-03-17 16:15:22 -07:00
Danny Tuppeny
b39a9473f8
Handle Flutter.Error events and disable structure errors for noDebug mode (#100149) 2022-03-17 16:05:21 -07:00
Christopher Fujino
e99a66a47e
[flutter_tools] check if stream is open before sending message in ios device (#99947) 2022-03-17 15:55:24 -07:00
Chris Bracken
a618ca27a7
[macOS] Enable universal binary builds by default (#100271)
This changes the default build architectures for Flutter macOS apps to
x86_64 and arm64. Previously, we manually excluded arm64 builds via the
EXCLUDE_ARCHS Xcode setting in Flutter's generated xcconfig file. This
eliminates setting EXCLUDE_ARCHS during the build and updates the
default architectures in the tool and in the macos_assemble.sh wrapper.

Issue: https://github.com/flutter/flutter/issues/97681
Umbrella issue: https://github.com/flutter/flutter/issues/60113
2022-03-17 12:28:39 -07:00
Brian Quinlan
f6c4c3df19
Remove unnecessary ignore: override_on_non_overriding_member (#99793) 2022-03-16 19:10:17 -07:00
Gary Qian
63ff7a199b
MigrateConfig and migrate integration testing base (#99092) 2022-03-16 11:10:22 -07:00
iroiroys
6f6b5647f5
Add more specific cause on web development tool error output (#98553) 2022-03-15 18:15:07 -07:00
Lau Ching Jun
722cbc52b8
Add portForwarder for ProxiedDevice. (#100111) 2022-03-15 14:30:21 -07:00
Christopher Fujino
bb4a5fa7ab
[flutter_tools] exec rather than spawn subprocess from bin/internal/shared.sh (#99871) 2022-03-14 13:35:18 -07:00
Ben Konyi
1880066dd3
Update dependencies (#99874) 2022-03-10 14:13:59 -07:00
Chris Yang
291b286417
[tool] Add CADisableMinimumFrameDurationOnPhone to iOS templates (#94509) 2022-03-09 14:15:20 -08:00
Jeff Ward
0aab22807c
First pass at using platform abstraction for plugins (#92672) 2022-03-09 14:10:21 -08:00
Lau Ching Jun
dbed10bb59
Pass 'assume-initialize-from-dill-up-to-date' flag to the frontend server (#99791) 2022-03-09 00:30:17 -08:00
Jenn Magder
dd97133df2
Remove tool crash git.io link shortener (#99574) 2022-03-08 17:00:06 -08:00
Tacca
c8538873c8
95533 min sdk error msgs enhancements (#99550) 2022-03-08 16:20:21 -08:00
Jesús S Guerrero
fbbf3ec471
Support route on ios (#99078) 2022-03-07 11:31:21 -08:00
Anurag Roy
b02150781f
[flutter_tools] Add timeout duration to error and handle exceptions for HttpHostValidator. (#98290) 2022-03-07 11:21:06 -08:00
Jenn Magder
7596a3daf6
Add logging when first frame is not rendering (#99566) 2022-03-04 17:16:21 -08:00
Jonah Williams
59859df126
Add Windows performance benchmark (#99564) 2022-03-04 15:41:14 -08:00
Mathieu Dubois-Briand
020bf31c99
Fix custom-device default forwardPortSuccessRegex (#97719) 2022-03-04 11:06:22 -08:00
Greg Spencer
fa68ecf7c6
Fix the race condition in cache_test.dart (#99423)
This fixes a race condition in test/integration.shard/cache_test.dart which allowed the test to fail if the machine took a very long time to acquire a lock or launch a process.
2022-03-03 12:55:47 -08:00
Jenn Magder
8f360c977a
Update minimum required version to Xcode 13 (#97746) 2022-03-01 16:26:11 -08:00
gaaclarke
fdcd14464c
Starts using the --source flag to compile the dart registrant. (#98046)
* Starts using the `--source` flag to compile the dart registrant.

* updated general.shard tests

* Fixed the resident compiler flow

* added integration test

* made the integration test self contained

* renamed generated_main to dart_plugin_registrant

* cleaned up for review

* added task runner for ci

* added bringup and TESTOWNERS

* updated failure message
2022-03-01 16:24:47 -08:00
Emmanuel Garcia
9cb60c9828
Revert "reads min/target sdk versions from localproperties" (#99191) 2022-02-28 11:41:22 -08:00
Jenn Magder
c80ff45afe
Print events and views when first frame is taking awhile during tracing (#98957) 2022-02-28 11:16:12 -08:00
stuartmorgan
80660b2d5e
Work around VS CMake generation bug (#98945) 2022-02-26 11:56:22 -08:00
Jenn Magder
9369bd3222
Wait for ios-deploy stdout before closing logLine stream (#99041) 2022-02-24 19:21:23 -08:00
Danny Tuppeny
76758ef960
[dap] Don't use --start-paused when running in Profile/Release mode (#98926) 2022-02-24 17:06:24 -08:00
Tacca
37a1aaf8c1
reads min/target sdk versions from localproperties (#98450) 2022-02-24 12:16:15 -08:00
Jenn Magder
320d2cff64
Increase recommended CocoaPods version to 1.11 (#98621) 2022-02-24 12:11:21 -08:00
keyonghan
c178cf859f
Skip can validate flutter version in parallel test in Linux web_tool_tests (#99017) 2022-02-23 14:19:20 -08:00
Alexander Dahlberg
47b5ed3948
Removed no-shuffle tag and fixed order dependency in daemon_test.dart (#98970) 2022-02-23 12:49:07 -08:00
Lau Ching Jun
6a9ac4509b
Add option in ProxiedDevice to only transfer the delta when deploying. (#97462) 2022-02-23 12:09:16 -08:00
Alexander Dahlberg
4a2737401f
Fixed order dependency and removed no-shuffle-tag in build_ios_framew… (#94699)
* Fixed order dependency and removed no-shuffle-tag in build_ios_framework_test.dart

* Removed trailing spaces in build_ios_framework_test.dart

* Removed unnecessary formatting
2022-02-23 08:39:11 +01:00
Tomasz Gucio
e4351ff053
Enable use_if_null_to_convert_nulls_to_bools lint (#98753) 2022-02-22 14:39:20 -08:00
Zachary Anderson
54a9d65282
Revert "Reland "Enable caching of CPU samples collected at application startup (#89600)"" (#98803) 2022-02-19 10:09:26 -08:00
Christopher Fujino
4b2e828924
[flutter_tools] deprecate the dev branch from the feature system (#98689) 2022-02-18 16:24:22 -08:00
Emmanuel Garcia
c8266d34f4
Improve Gradle retry logic (#96554) 2022-02-18 13:54:41 -08:00
Ben Konyi
4add01ab68
Reland "Enable caching of CPU samples collected at application startup (#89600)" (#98769)
This reverts commit ac3c44355a.
2022-02-18 13:28:42 -08:00
Christopher Fujino
081d960237
[flutter_tools] remove flaky web vm service test (#98540) 2022-02-18 11:54:23 -08:00
Tim Sneath
5c7ca2e738
Remove "beta-quality" for Windows (#98614) 2022-02-17 16:44:23 -08:00
Jenn Magder
cef6823637
Dump backtrace when cannot attach to observatory (#98550) 2022-02-16 14:10:18 -08:00
Christopher Fujino
4a11cc4b9c
[flutter_tools] do not validate maven upstream if cloud storage override provided (#98293) 2022-02-15 11:40:15 -08:00
Ben Konyi
2a2f973120
Update flutter_tools to look for new VM service message (#97683)
* Update flutter_tools to look for new VM service message

The Dart SDK will soon move away from the current Observatory message:

"Observatory listening on ..."

To a new message that no longer references Observatory:

"Dart VM Service listening on ..."

This change updates all tests with mocks to check for the new message
and also adds support for the new message in ProtocolDiscovery.

See https://github.com/dart-lang/sdk/issues/46756

* Fix some parsing locations

* Fix analysis failures

* Update message

* Remove extra comment

* Update message

* Add globals prefix
2022-02-15 07:33:57 -08:00
Christopher Fujino
87fe3fe031
rename two unit tests that were not actually being run on CI (#98299) 2022-02-14 17:40:13 -08:00
Jesús S Guerrero
f523ddd2d6
[flutter_tools] remove pub dependencies from universal (#97722) 2022-02-12 12:10:11 -08:00
Jenn Magder
262a963efb
flutter_build_null_unsafe_test print failed build output (#98310) 2022-02-11 22:00:18 -08:00
Christopher Fujino
289988dc62
[flutter_tools] fix type error in flutter update-packages --jobs=n (#98283) 2022-02-11 14:50:18 -08:00
Taha Tesser
d6d3283c8d
Fix flutter gen-l10n help message (#98147) 2022-02-11 01:40:14 -08:00
Brian Quinlan
76855aa893
Add keyLog and connectionFactory to HttpClient implementations (#98045) 2022-02-11 00:35:16 -08:00
Daco Harkes
bb3275b934
Add debugging info to android_plugin_example_app_build_test (#98107) 2022-02-09 09:20:13 -08:00
Emmanuel Garcia
d2b5f34bc4
Revert "Fix how Gradle resolves Android plugin" (#98050) 2022-02-08 12:30:05 -08:00