Victoria Ashworth
555326b228
Revert "Replace rsync when unzipping artifacts on a Mac ( #126703 )" ( #127430 )
...
This reverts commit 2b3cd7f4d9https://github.com/flutter/flutter/issues/127281 .
2023-05-24 19:21:05 +00:00
Phil Quitslund
d0c0439b8d
fixes to anticipate next Dart linter release ( #127211 )
...
The upcoming linter release notices null literals as unnecessary argument values and flags more `type_literal_in_constant_pattern` cases.
See breakages: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8780744067138629361/+/u/analyze_flutter_flutter/stdout
2023-05-19 21:27:24 +00:00
Victoria Ashworth
2b3cd7f4d9
Replace rsync when unzipping artifacts on a Mac ( #126703 )
...
Instead of using rsync, which has caused errors in the past (https://github.com/flutter/flutter/issues/99785 ), delete the file/directory/link prior to moving it.
Hopefully should let us stop double zipping the FlutterMacOS.framework in the engine: https://github.com/flutter/engine/pull/41306/files
Part of https://github.com/flutter/flutter/issues/126016 .
2023-05-16 16:58:06 +00:00
Tomasz Gucio
99c7e9f088
Add spaces after flow control statements ( #126320 )
2023-05-15 11:07:30 +02:00
Victoria Ashworth
fa01649a59
Update device selection to wait for wireless devices to load ( #122932 )
...
Update device selection to wait for wireless devices to load
2023-03-29 17:58:07 +00:00
Jenn Magder
6e5a530737
Add flags to make App.framework work in app extension ( #123618 )
...
Add flags to make App.framework work in app extension
2023-03-28 23:10:06 +00:00
Loïc Sharma
8f62e34267
[Focus] Add run key command to dump the focus tree ( #123473 )
...
[Focus] Add run key command to dump the focus tree
2023-03-28 00:33:39 +00:00
Sigurd Meldgaard
1fd84f88e9
Always use user-level pub cache ( #121802 )
...
Use the pub cache resolved by pub itself.
To add packages to the flutter.zip download they are packaged as tar.gz and added to the pub-cache on first run by using `pub cache preload`.
2023-03-13 08:38:17 +01:00
Jenn Magder
9fe556705b
Print sub process that failed to run in tool ( #120999 )
2023-02-17 22:02:51 +00:00
Christopher Fujino
c6b636fa51
[flutter_tools] Replace Future.catchError() with Future.then(onError: ...) ( #120637 )
...
* wip run_local_linter.dart
* get run_local_linter.dart working
* slow working implementation
* speed up run_local_linter.dart
* fix run_local_linter.dart
* remove catchError
* another fix
* fix another
* fix
* more fixes
* fix moar
* fix moar
* fix
* finish
* fix tests
* clean up further
* code review
* delete run_local_linter.dart
2023-02-15 19:03:00 +00:00
Ian Hickson
d29668ddb2
Improve network resources doctor check ( #120417 )
...
...and various other minor cleanup:
* Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing.
* Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too.
* Made the logger delete the slow warning when it's finished.
* Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'.
* Added a debug toString to ValidationResult for debugging purposes (not used).
* In http_host_validator:
- Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev).
- Added GitHub as a tested host since when you run `flutter` we hit that immediately.
- Renamed the check "Network resources".
- Updated the `slowWarning` of the check to say which hosts are pending.
- Removed all timeout logic. Timeouts violate our style guide.
- Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient.
- Replaced the `_HostValidationResult` class with `String?` for simplicity.
- Improved the error messages to be more detailed.
- Removed all checks that dependened on the stringification of exceptions. That's very brittle.
- Added a warning specifically for HandshakeException that talks about the implications (MITM attacks).
- Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result.
- Replaced a lot of list-filtering logic with just a single for loop to check the results.
- Replaced code that added a constant to a known-empty list with just returning a constant list.
- Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
2023-02-15 00:02:09 +00:00
Ivan Dlugos
f945ad99c3
Resolve dwarf paths to enable source-code mapping of stacktraces ( #114767 )
...
* feat: add "--resolve-dwarf-paths" to gen_snapshot
* chore: update tests
2023-02-09 23:05:44 +00:00
Peixin Li
906761cf9b
Fix the message strings for xcodeMissing and xcodeIncomplete ( #117922 )
...
* Add macOS to xcodeMissing and xcodeIncomplete
* And unit test
2023-01-04 02:48:00 +00:00
Jenn Magder
49f5980970
Suggest Rosetta when x64 binary cannot be run ( #114558 )
...
* Suggest Rosetta when x64 binary cannot be run
* validator
* Adjust error message
2022-12-01 19:17:07 +00:00
Sam Rawlins
f255390f4d
Remove redundant arguments passed to redirecting factory constructors ( #115497 )
2022-11-17 00:47:14 +00:00
Jenn Magder
8c8bb22222
BufferLogger should log stacktrace ( #113240 )
2022-10-11 20:14:18 +00:00
Jenn Magder
35afe1bdac
Stop embedding bitcode for iOS in tool ( #112831 )
2022-10-04 01:41:23 +00:00
Jason Simmons
2a4adab7f4
Return ErrorHandlingFileSystem backed objects in ErrorHandlingFileSystem file/directory APIs ( #112673 )
2022-09-29 22:57:20 +00:00
Ivan Dlugos
d63442c1da
refactor: strip all local symbols from macOS and iOS App.framework - reduces app size ( #111264 )
2022-09-09 21:13:10 +00:00
Liam Appelbe
ec75399beb
Null safety migration of packages/flutter_tools/test/general.shard, part 1/2 ( #110711 )
...
* Migrate packages/flutter_tools/test/general.shard, part 1/2
* Fix most of the tests
* Fix analysis
* Fix analysis
* Fix test
* Fix analysis
* Fix analysis
* Fix nit
2022-09-08 15:25:27 -07:00
Ivan Dlugos
723b82e4f0
Feat: dSYM debug info for iOS & macOS builds ( #101586 )
2022-09-05 18:16:16 +00:00
Christopher Fujino
08d5d51a98
[flutter_tools] Instantiate shutdown hooks before localfilesystem ( #110693 )
2022-09-02 17:38:56 +00:00
Zachary Anderson
c6ec84e978
[flutter_tools] Pull more arm64 artifacts on Apple Silicon ( #110291 )
2022-08-29 10:33:24 -07:00
Alexander Aprelev
bfdc9a6cfa
Introduce stubbed exclusive parameter to File.create-overridden method ( #109646 )
...
* Introduce stubbed `exclusive` parameter to `File.create`-overridden method.
This is to soften landing of a breaking change https://github.com/dart-lang/sdk/issues/49647
2022-08-17 13:26:08 -07:00
Michael Goderbauer
e27a19e3f8
Remove outdated ignores ( #108924 )
2022-08-03 23:37:05 +00:00
Jesús S Guerrero
6048e07f47
[flutter_tools] join flutter specific with home cache ( #105343 )
2022-07-29 19:58:06 +00:00
Jenn Magder
50474b29ce
Only run pod install on the first iOS build ( #108205 )
2022-07-26 19:39:06 +00:00
Jesús S Guerrero
fae31eecce
[flutter_tools] temporary directory ( #105815 )
2022-06-17 02:58:05 +00:00
Michael Goderbauer
3fa355c97d
Remove dead code in tools tests ( #104567 )
2022-05-25 12:48:17 -07:00
Jenn Magder
c6ced845e3
Remove custom unawaited, prefer dart:async version ( #103212 )
2022-05-07 08:49:04 -07:00
Phil Quitslund
b5e7fb076c
[flutter_tools] rename local functions with _s ( #102688 )
2022-04-27 16:19:07 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Jenn Magder
1756ccc541
Set template and migrate apps to iOS 11 minimum ( #101963 )
2022-04-15 11:34:08 -07:00
Jenn Magder
d4bfb01336
Do not build for iOS armv7 ( #97341 )
2022-04-12 14:44:09 -07:00
Jenn Magder
839a183ea6
Add note to doctor validator if script is running Rosetta ( #101309 )
2022-04-05 10:37:35 -07:00
Michael Goderbauer
dcde8163ce
migrate to super params ( #100509 )
2022-03-31 11:46:47 -07:00
Christopher Fujino
9c138f9c76
[flutter_tools] warn when doctor takes long ( #100805 )
...
* warn when doctor takes long
2022-03-28 14:13:28 -07:00
Lau Ching Jun
d7688ca093
Change all instance of throwing strings to throw specific error classes. ( #97325 )
2022-02-02 10:45:18 -08:00
Christopher Fujino
610b41e88c
[flutter_tools] add validation of paths of contained files to os_utils _unpackArchive() ( #96565 )
2022-01-25 18:10:12 -08:00
Spt
7de1e225de
fix rsync output utf8decode bug ( #95881 )
2022-01-13 10:20:20 -08:00
Emmanuel Garcia
79bc1bfa89
Add ability to wrap text messages in a box ( #94391 )
2021-12-15 13:19:11 -08:00
Ian Hickson
66dd2add7e
Add some more new lints ( #91659 )
2021-10-12 11:33:04 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be24
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Ian Hickson
989f864497
Enable avoid_setters_without_getters ( #91067 )
2021-10-01 00:58:05 -07:00
Christopher Fujino
738a7747cc
[flutter_tools] Handle disk device not found ( #90996 )
2021-09-30 17:28:57 -07:00
Greg Spencer
01af8e5987
Make flutter update-packages run in parallel ( #91006 )
...
This modifies the flutter update-packages and flutter update-packages --force-upgrade commands so that the many invocations of "dart pub get" in each repo project run in parallel instead of in series.
2021-09-30 10:26:31 -07:00
Christopher Fujino
61bce1d83b
[flutter_tools] remove non-null check from AndroidValidator ( #90090 )
2021-09-25 16:53:06 -07:00
Anis Alibegić
a753d09cc9
Fixed several typos ( #89485 )
2021-09-07 14:56:04 -07:00
