Elias Yishak
18b94b7f57
Prevent crashes on range errors when selecting device ( #129290 )
...
Prevent the cli from crashing when a user selects a number that is not valid for `flutter run` device selection
Fixes issue:
- https://github.com/flutter/flutter/issues/129191
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2023-06-22 15:52:25 +00:00
LouiseHsu
e345a830ba
Show warning when attempting to flutter run on an ios device with developer mode turned off ( #125710 )
...
This PR adds a warning when a user attempt to `flutter run -d <device id>` on a device without developer mode enabled.
<img width="738" alt="Screenshot 2023-05-09 at 3 53 18 AM" src="https://github.com/flutter/flutter/assets/36148254/6f473a6a-5a0d-438b-9e6f-06d09eb1f3a9 ">
Also handles multiple partial matches.
<img width="788" alt="Screenshot 2023-05-09 at 3 52 24 AM" src="https://github.com/flutter/flutter/assets/36148254/60c82b3c-d501-4a01-95ad-d6309fe39576 ">
Fixes https://github.com/flutter/flutter/issues/111988
2023-05-22 22:06:15 +00:00
Elias Yishak
0d5875274b
Clearer text about what happens with --disable-telemetry
+ enable-telemetry command ( #125995 )
...
Fixes:
- https://github.com/flutter/flutter/issues/124411
This PR is cleaning up the `--disable-telemetry` help message to make it clear that opting out will opt out of all telemetry collection for flutter and dart commands. It is also adding the opposite flag `--enable-telemetry` which will enable telemetry collection
2023-05-08 13:01:25 +00:00
Elias Yishak
ca3a900d5d
[reland] Update helper message for --suppress-analytics
( #125145 )
...
Relanding: https://github.com/flutter/flutter/pull/124810
Fixes: https://github.com/flutter/flutter/issues/124808
2023-04-19 18:51:08 +00:00
godofredoc
03d725620a
Revert "Update helper message for --suppress-analytics
" ( #125141 )
...
Reverts flutter/flutter#124810
2023-04-19 16:43:29 +00:00
Elias Yishak
3476b96652
Update helper message for --suppress-analytics
( #124810 )
...
Fixes: https://github.com/flutter/flutter/issues/124808
2023-04-19 14:00:20 +00:00
Elias Yishak
51b23bc961
Update runner to handle logic for both analytics packages ( #124606 )
...
Update runner to handle logic for both analytics packages
2023-04-12 19:34:11 +00:00
Elias Yishak
a32f0bb7a0
Add analytics package + setTelemetry method attached ( #124015 )
...
The first of many PRs for transitioning to `package:unified_analytics`.
This PR is only focused on disabling and enabling telemetry via the
`flutter config --[no-]analytics` flag
Fixes: https://github.com/flutter/flutter/issues/121617
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Christopher Fujino <fujino@google.com>
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
2023-04-05 14:08:56 -04:00
Victoria Ashworth
dbc18bbdb8
Add flag to filter by device connection interface ( #124034 )
...
Add flag to filter by device connection interface
2023-04-04 22:33:26 +00:00
Christopher Fujino
b2c65acd5a
[flutter_tools] Remove --no-sound-null-safety #4 ( #124039 )
...
Re-land of https://github.com/flutter/flutter/pull/123297 without any of
the commits at the end attempting to fix customer-testing.
Fixes https://github.com/flutter/flutter/issues/118810
2023-04-04 15:25:27 -07:00
Victoria Ashworth
fa01649a59
Update device selection to wait for wireless devices to load ( #122932 )
...
Update device selection to wait for wireless devices to load
2023-03-29 17:58:07 +00:00
Christopher Fujino
3736274a6d
Revert "[flutter_tools] Remove sound null safety flag ( #123031 )" ( #123280 )
...
Revert "[flutter_tools] Remove sound null safety flag (#123031 )"
2023-03-22 22:53:49 +00:00
Christopher Fujino
f4c3facfdd
Revert "Revert "[flutter_tools] Remove sound null safety flag ( #120936 )" ( #122909 )" ( #123031 )
...
[flutter_tools] Remove sound null safety flag #2
2023-03-20 22:32:07 +00:00
Christopher Fujino
f6bc147c91
Revert "[flutter_tools] Remove sound null safety flag ( #120936 )" ( #122909 )
...
This reverts commit 7c3088cf22
.
2023-03-17 11:31:48 -07:00
Christopher Fujino
7c3088cf22
[flutter_tools] Remove sound null safety flag ( #120936 )
...
[flutter_tools] Remove sound null safety flag
2023-03-17 17:48:35 +00:00
Victoria Ashworth
27248d4b64
Separate attached and wireless devices ( #122615 )
...
Separate attached and wireless devices
2023-03-15 16:35:05 +00:00
Victoria Ashworth
ee42a302ec
Move target devices logic to its own classes and file ( #121903 )
...
Move target devices logic to its own classes and file
2023-03-13 16:14:21 +00:00
Daco Harkes
0521c60cd2
Support --local-engine=ios_debug_sim ( #119524 )
...
Fixes:
* https://github.com/flutter/flutter/issues/119523
2023-02-09 18:32:52 +00:00
Christopher Fujino
374f09e1a6
[flutter_tools] No more implicit --no-sound-null-safety ( #118491 )
...
* remove implicit no-sound-null-safety
* add test
* bump sdk constraint in test file
2023-01-18 20:46:09 +00:00
Andrew Kolos
ee1c59d462
reduce pub output from flutter create ( #118285 )
...
* reduce pub output from flutter create
* fix fake Pub implementations
* fix tests
* Update pub.dart
* replace enum with simpler boolean
* fix tests
* Revert "fix tests"
This reverts commit 8a3182d3b9
.
* Revert "replace enum with simpler boolean"
This reverts commit 445dbc443d
.
* go back to using an enum
2023-01-12 21:42:02 +00:00
Sigurd Meldgaard
b7881e5b64
Align flutter pub get/upgrade/add/remove/downgrade
( #117896 )
...
* Align `flutter pub get/upgrade/add/remove/downgrade`
* Add final . to command description
* Remove trailing whitespace
* Don't print message that command is being run
* Update expectations
* Use relative path
* Remove duplicated line
* Improve function dartdoc
2023-01-10 23:29:09 +00:00
Jackson Gardner
db1c3e208d
Platform binaries reland ( #115502 )
...
You can now specify a --local-web-sdk flag to point to a wasm_release folder. This will make it so that only artifacts that pertain to the web sdk are overridden to point to the wasm_release folder. Other artifacts (such as impellerc) will pull from the cache, or from the --local-engine path if that is specified.
This also uses precompiled platform kernel files for both ddc and dart2js
2022-12-02 14:13:40 -08:00
Jenn Magder
2e51077d19
Do not strip architecture suffixes from host local-engine ( #115320 )
...
* Do not strip suffices from host local-engine
* suffixes
2022-11-15 01:36:49 +00:00
Jonah Williams
8230ef5e85
Revert "[web] Add --local-web-sdk
flag and use precompiled platform kernels for dart2js and ddc ( #114639 )" ( #115242 )
...
This reverts commit 0e9ee3679c
.
2022-11-13 20:23:26 +00:00
Jackson Gardner
0e9ee3679c
[web] Add --local-web-sdk
flag and use precompiled platform kernels for dart2js and ddc ( #114639 )
...
* Dart2JS build step looks for compiled platform binaries.
* Use new locations of platform binaries.
* Added --local-web-sdk command line flag.
* Need to use the matching frontend server when doing ddc stuff.
* Update packages/flutter_tools/lib/src/test/web_test_compiler.dart
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
* Update packages/flutter_tools/lib/src/runner/flutter_command_runner.dart
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
* Formatting issues.
* Need to use URI format for platform dill.
* Fix resident runner tests.
* Fix analysis issue.
* Fix and add unit tests.
* Add some useful comments.
* Refine doc comments for flags.
Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com>
2022-11-12 01:31:10 +00:00
Mouad Debbar
2dd87fbdf2
Fix --local-engine for the new web/wasm mode ( #113759 )
2022-10-24 20:43:09 +00:00
Lau Ching Jun
944a4c9714
Write crash report in temp directory if writing to CWD failed. ( #113316 )
2022-10-12 17:13:24 +00:00
Lau Ching Jun
2a73ce9b50
Refactor DeviceManager.findTargetDevices()
and FlutterCommand.findAllTargetDevices()
, and add a flag to not show prompt. ( #112223 )
2022-09-23 21:10:35 +00:00
Liam Appelbe
ec75399beb
Null safety migration of packages/flutter_tools/test/general.shard, part 1/2 ( #110711 )
...
* Migrate packages/flutter_tools/test/general.shard, part 1/2
* Fix most of the tests
* Fix analysis
* Fix analysis
* Fix test
* Fix analysis
* Fix analysis
* Fix nit
2022-09-08 15:25:27 -07:00
Sigurd Meldgaard
d80e994a62
Reland: Show output from pub get in flutter pub get ( #110851 )
2022-09-08 15:13:23 +02:00
Christopher Fujino
08d5d51a98
[flutter_tools] Instantiate shutdown hooks before localfilesystem ( #110693 )
2022-09-02 17:38:56 +00:00
Pierre-Louis
0c2f7bc2a2
Remove errant double spaces ( #110758 )
2022-09-02 04:00:58 +00:00
Zachary Anderson
0e195e9d46
Revert "Show output from pub get
in flutter pub get
( #106300 )" ( #110478 )
...
This reverts commit 3802eb627e
.
2022-08-29 08:02:50 -07:00
Sigurd Meldgaard
3802eb627e
Show output from pub get
in flutter pub get
( #106300 )
2022-08-29 07:37:19 +00:00
Anurag Roy
47b40601d7
[flutter_tools] Have FlutterValidator fail on non-ideal git config ( #103259 )
2022-06-20 19:05:07 +00:00
Jenn Magder
a56c5e51ae
Migrate some test files to null safety ( #104469 )
2022-05-24 16:53:08 -07:00
Jenn Magder
c6ced845e3
Remove custom unawaited
, prefer dart:async
version ( #103212 )
2022-05-07 08:49:04 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Jonah Williams
944fcda67f
[flutter_tools] remove UWP tooling ( #102174 )
2022-04-26 11:19:07 -07:00
Jesús S Guerrero
3394fb4a58
[flutter_tools] fix flutter create --offline ( #100941 )
...
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
2022-04-07 17:05:49 -07:00
Lau Ching Jun
dbed10bb59
Pass 'assume-initialize-from-dill-up-to-date' flag to the frontend server ( #99791 )
2022-03-09 00:30:17 -08:00
Lau Ching Jun
d7688ca093
Change all instance of throwing strings to throw specific error classes. ( #97325 )
2022-02-02 10:45:18 -08:00
Jenn Magder
1c0eade94c
Hide PII from doctor validators for GitHub template ( #96250 )
2022-01-10 13:20:21 -08:00
crisboarna
eb1a851f58
feat(flutter_tools): Added doctor host validation feat ( #95386 )
2021-12-16 08:02:13 -08:00
Christopher Fujino
e8ec8a0dfb
[flutter_tools] Catch lack of flutter tools source missing ( #93168 )
2021-11-12 14:43:52 -08:00
Kenzie (Schmoll) Davisson
7748731903
Add DevTools version to flutter --version
and flutter doctor -v
output. ( #93065 )
...
* Add DevTools version to `flutter --version` output.
* review comments
* fix test
* add explanatory comment
* dummy commit to kick bots
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
2021-11-11 14:40:22 -08:00
Greg Spencer
52ae102f18
Adds tool warning log level and command line options to fail on warning/error output ( #92031 )
2021-11-10 16:13:04 -08:00
Jenn Magder
9e88fe328e
Remove globals_null_migrated.dart, move into globals.dart ( #92861 )
2021-11-01 17:18:03 -07:00
Jenn Magder
6987c9fb82
Migrate crash_reporting and github_template ( #91516 )
2021-10-12 13:48:03 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00