Commit Graph

1017 Commits

Author SHA1 Message Date
Dan Rubel
1821238279 Refactor flutter command execution (#5892)
* refactor _run to runCmd

* replace requiresProjectRoot getter with call to commandValidator

* replace requiresDevice getter with call to findTargetDevice

* trace command requires a debug connection, not a device

* inline androidOnly getter

* rename command methods to verifyTheRunCmd and runCmd

* move common verification into BuildSubCommand

* rename deviceForCommand to device

* rename methods to verifyThenRunCommand and runCommand
2016-09-16 09:13:35 -04:00
John McCutchan
24ab837240 Support hot reload for applications that don't use the framework (#5868) 2016-09-15 13:18:32 -07:00
Dan Rubel
cc1755aac9 move all analysis options to repo root (#5882)
This moves all of the various .analysis_options* files to the flutter repo root so that it's easier to
* remember to keep them all in sync, and
* easily refer customers to them
2016-09-15 11:59:46 -04:00
John McCutchan
fd50ccdd95 Enable hot mode by default. --no-hot disables it (#5794) 2016-09-13 14:38:05 -07:00
Dan Rubel
672d04e0d0 close sinks cleanup (#5838)
part of https://github.com/flutter/flutter/issues/5789
2016-09-13 14:15:36 -04:00
Dan Rubel
bad957d457 remove unused methods (#5837)
cleanup https://github.com/flutter/flutter/issues/5789
2016-09-13 12:01:04 -04:00
Konstantin Scheglov
0774a6748e Build unlinked summaries for packages on upgrade. (#5816)
* Build unlinked summaries for packages on upgrade.

* Iterate through the packages in folders.

* Rollback the debug change.
2016-09-12 13:58:32 -07:00
Dan Rubel
678da3ac2b cancel open subscription (#5824)
fixes https://github.com/flutter/flutter/issues/5788
2016-09-12 16:32:08 -04:00
Adam Barth
4ea8f302ab Teach flutter upgrade to switch to master (#5827)
To avoid orphaning people on the deprecated alpha branch, this patch teaches
`flutter upgrade` to switch to the master branch.
2016-09-12 13:25:57 -07:00
John McCutchan
718a88d06e Add a --benchmark mode to hot run (#5787) 2016-09-12 12:19:08 -07:00
Chinmay Garde
ffe5700948 Shell instances launched by the tools from the desktop are always non-interactive. (#5778)
In that they never create a window with an OpenGL context and the works.
2016-09-09 16:31:49 -07:00
Chris Bracken
17c7118ab6 Use runCommandAndStreamOutput() to launch driver (#5806)
... in place of manual process wrangling.
2016-09-09 16:08:59 -07:00
Chris Bracken
726d31689d drive: Replace manual pub get with usesPubOption() (#5803) 2016-09-09 15:04:01 -07:00
Chris Bracken
e7601e3fa5 Use .packages for flutter driver tests (#5795)
Fixes flutter drive breakage introduced in d2fda677e1.
2016-09-09 13:57:16 -07:00
Dan Rubel
bb0a6757fc Suggest simulator when no devices (#5770)
When flutter run is used on a Mac and no devices are specified or attached, suggest launching a simulator first. Fixes https://github.com/flutter/flutter/issues/5674
2016-09-08 17:37:39 -04:00
Phil Quitslund
d2fda677e1 Update to Dart 1.20.0-dev.1.0. (#5689)
* Udpate to Dart `1.20.0-dev.1.0`.

Udpate to Dart `1.20.0-dev.1.0` and corresponding `analyzer` package.

* Added `--no-packages-dir`.

* Revert extension to master.

* Added ignores.

* Review nits.

* More nits.
2016-09-08 13:14:08 -07:00
Dan Rubel
3ed3390d0c flutter analyze repo analysis options (#5707)
This updates the flutter analyze command to use the .analysis_options_flutter_analyze in the repo root when either the --flutter-repo flag is supplied or the sources being analyzed reside in the flutter repo.
2016-09-07 22:41:59 -04:00
Chris Bracken
a69c11f349 Replace hardcoded iOS build dir with config-driven lookup (#5732)
Related: b5f763b45e
2016-09-02 17:01:11 -07:00
Dan Rubel
023b7de11f show device list in flutter doctor output (#5697)
* show device list in flutter doctor output
fixes https://github.com/flutter/flutter/issues/5625
2016-09-01 17:55:16 -04:00
Dan Rubel
ef79e7a1c0 improve device matching error message (#5693)
* improve device matching error message
fixes https://github.com/flutter/flutter/issues/5675
2016-09-01 12:37:58 -04:00
Dan Rubel
e20ec2becb implement flutter format (#5606)
Implement flutter format, fixes https://github.com/flutter/flutter/issues/5338
2016-08-31 09:40:17 -04:00
Jason Simmons
4aba536aa9 Support x86/x64 targets in the build apk command (#5660)
Fixes https://github.com/flutter/flutter/issues/5592
2016-08-30 14:13:47 -07:00
Dan Rubel
83bf5d10c0 fix getDeviceById to match exact name (#5657)
* fix getDeviceById to match exact name
fixes https://github.com/flutter/flutter/issues/5508
2016-08-30 14:11:54 -04:00
Ryan Macnak
fa8dc5f88b Do not truncate commands, this inhibits reproduction. (#5607) 2016-08-26 14:48:21 -07:00
Alexandre Ardhuin
886f588df6 Update gradle.dart (#5610) 2016-08-26 07:51:37 -07:00
Dan Rubel
194a9ef3c9 implement flutter packages get/upgrade command (#5603)
* implement flutter packages get/upgrade command
* alias flutter pub
* refactor findProjectRoot for use by multiple commands

fixes https://github.com/flutter/flutter/issues/4994
2016-08-25 22:37:48 -04:00
Chris Bracken
b5f763b45e Support a configurable build directory (#5601)
This change adds a top-level getBuildDirectory func and funcs for
android, aot, asset, ios build products.

Developers may now add a "build-dir" mapping to their
~/.flutter_settings (JSON format) config file. Output directory is
relative to the main flutter application directory.

This change also changes the default build directory for iOS builds to a
subdirectory of the configured build directory, 'build/ios' by default.
2016-08-25 16:38:19 -07:00
John McCutchan
852a00a17b Detect when isolate reload is barred and inform the user (#5602) 2016-08-25 14:23:13 -07:00
Dan Rubel
e47e937682 add flutter channel command (#5561)
* add flutter channel command
fixes https://github.com/flutter/flutter/issues/2513

* fix test

* address comments

* remove unused imports

* fix lints
2016-08-25 15:16:21 -04:00
Dan Rubel
1ea2f4030e enhance flutter upgrade to find project root (#5552)
* enhance flutter upgrade to find project root
fixes https://github.com/flutter/flutter/issues/2990

* address comments

* restore original formatting

* fix lints
2016-08-25 14:59:12 -04:00
Dan Rubel
5f7af56f3e modify runCommandAndStreamOutput to wait until stdout (#5596)
has been fully processed before completing the returned future.
This helps prevent tests that rely on stdout from being flaky.
2016-08-25 14:55:54 -04:00
Yegor
4805d9276a create build directory for startup trace if missing (#5589) 2016-08-24 16:56:26 -07:00
Yegor
0e63e470e4 Revert "Detect when isolate reload is barred and inform the user (#5582)" (#5590)
This reverts commit 09e68c33cc.

AOT snapshotter is broken at this engine rev.

https://flutter-dashboard.appspot.com/api/get-log?ownerKey=ahNzfmZsdXR0ZXItZGFzaGJvYXJkclgLEglDaGVja2xpc3QiOGZsdXR0ZXIvZmx1dHRlci8wOWU2OGMzM2NjZGIzNTVmZWRkNzVhODcxNmRlMDU1MWM3NzJmMmRlDAsSBFRhc2sYgICAgICAwAgM
2016-08-24 16:56:10 -07:00
John McCutchan
09e68c33cc Detect when isolate reload is barred and inform the user (#5582) 2016-08-24 15:36:17 -07:00
Chinmay Garde
1852fdcca8 Fix escaping of spaces when passing launch arguments to the iOS device. (#5574)
`Process.start` seems to be escaping as needed.
2016-08-24 12:57:29 -07:00
Todd Volkert
5f44b2d4e5 Make flutter build ios --simulator default to debug builds (#5540) 2016-08-22 17:14:30 -07:00
Chris Bracken
bfbbef108d Prevent hangs due to bad import/export directives (#5538)
If the input test script contains a bad import, sky_shell will fail to
execute main(), in which case a connection to /runner is never
established and the _ServerInfo.socket never completes.

This change works around this by issuing a request on /shutdown when
sky_shell exits.
2016-08-22 15:30:10 -07:00
Devon Carew
74446d78fc don't resolve symlinks as part of which (#5531)
* don't resolve symlinks as part of which

* update method dartdoc
2016-08-22 14:35:19 -07:00
Todd Volkert
2796d74526 Fail to build for ios simulator in profile or release build mode (#5530) 2016-08-21 21:51:03 -07:00
Jason Simmons
789bfa4271 Do not throw when resolving a local engine if the .packages map does not include the flutter package (#5519) 2016-08-19 14:40:14 -07:00
Devon Carew
b8a60f5bbd suppress exceptions from loader progress display messages (#5510) 2016-08-19 12:47:58 -07:00
John McCutchan
83ab5f8345 Call refreshViews after every restart (#5479) 2016-08-18 16:01:18 -07:00
Jason Simmons
073f64de1a Only call refreshViews if the VM service is available (#5474)
Fixes https://github.com/flutter/flutter/issues/5468
2016-08-18 06:38:35 -07:00
Konstantin Scheglov
d3fd8ddd6f Build sky_engine Dart SDK summary bundle on FlutterEngine.download(). (#5460) 2016-08-17 13:01:19 -07:00
Jason Simmons
80fe689a56 Delete and recreate all affected directories during an artifact cache refresh (#5461)
This will ensure cleanup of any files that existed in previous versions of
the artifacts but have since been removed
2016-08-17 10:55:01 -07:00
Konstantin Scheglov
ade895de4a Revert "Build sky_engine Dart SDK summary bundle on FlutterEngine.download()." (#5455) 2016-08-17 09:17:59 -07:00
John McCutchan
5c14444bfd Trigger a hot reload / full restart based on SIGUSR1 and SIGUSR2 (#5453) 2016-08-17 09:09:45 -07:00
John McCutchan
3a012b326f vmservice redux (#5437) 2016-08-17 09:01:04 -07:00
Devon Carew
53dd5dbd0d print more logging info when tracing (#5419) 2016-08-17 08:19:52 -07:00
Konstantin Scheglov
a8369413e4 Build sky_engine Dart SDK summary bundle on FlutterEngine.download(). (#5426)
* Build sky_engine Dart SDK summary bundle on FlutterEngine.download().

* Tweaks for Devon comments.

* Tweaks for Phil comments.
2016-08-16 21:26:07 -07:00
Jason Simmons
ba53d19253 Roll the engine (#5423)
Also update the AOT builder for changes to the layout of the sky_engine package
2016-08-16 10:41:38 -07:00
Devon Carew
e880d51f00 fix an issue where --hot would not exit (#5421)
* fix an issue where --hot would not exit

* add type annotations
2016-08-16 08:56:31 -07:00
Devon Carew
7ab48f4ef6 tweak the --version text (#5420) 2016-08-16 08:38:19 -07:00
Devon Carew
2259c59be8 update the cache earlier (#5415)
* update the cache earlier

* add documentation
2016-08-15 22:51:40 -07:00
Jason Simmons
f9876cba4c Wait for stopApp to complete before proceeding with the app install/run flow (#5412) 2016-08-15 15:24:00 -07:00
Phil Quitslund
abeb5c7363 Add framework commit date to version output (#5336). (#5367)
Fixes: https://github.com/flutter/flutter/issues/5336
2016-08-15 11:07:37 -07:00
Devon Carew
24f63e2b44 show better errors for gradle build failures (#5374) 2016-08-13 12:30:14 -07:00
Adam Barth
3e27acd74a Update path to entry points config file (#5379) 2016-08-12 21:17:02 -07:00
Todd Volkert
d313feb027 Point to updated location of snapshot.dart (#5375) 2016-08-12 15:08:32 -07:00
John McCutchan
9a0a0d9903 Fix package:<project_package> imports in hot reload mode (#5372) 2016-08-12 13:31:06 -07:00
Phil Quitslund
803fbec51b Add Dart SDK to version info (#4986). (#5337)
* Add Dart SDK to version info (#4986).

Adds a new SDK line to the `flutter —version` output.

* Prefer `Platform.version`.

* Version text fixes.
2016-08-11 16:39:33 -07:00
John McCutchan
cab7c8d7b3 Rename Observatory to VMService (#5349) 2016-08-11 13:14:13 -07:00
John McCutchan
728e2a5689 Add FlutterView and ViewManager and hook them into the ResidentRunner. (#5345)
- [x] Refactor view support into separate classes.
- [x] Make the hot runner grab the main view and call runFromSource on it.
- [x] Remove Device.needsDevFS (because it is always true).
2016-08-11 12:56:47 -07:00
John McCutchan
cf2b2078d4 Send reload / restart time to frame to analytics (#5335) 2016-08-11 10:01:53 -07:00
Devon Carew
6b1597dc0d send the base uri back to debuggers (#5321)
* send the base uri back to debuggers

* add a fullRestart parameter to app.restart

* add await
2016-08-11 09:51:19 -07:00
John McCutchan
ec0f880032 Hot reload: Only sync Dart sources necessary for startup on first launch (#5333)
- [x] Update engine to bring in new snapshotter.
- [x] Use the new snapshotter to quickly determine the minimal set of files necessary to run.
- [x] On first DevFS sync, only sync files necessary to run the application.
- [x] Fix a DevFS unit test failure.
- [x] Include DevFS tests in all.dart.
2016-08-11 07:40:49 -07:00
Phil Quitslund
0fe82c3a6f Update Dart SDK to 1.19.0-dev.4.0. (#5329) 2016-08-10 16:21:58 -07:00
John McCutchan
b314fa5979 Add time to frame tracking to hot run (#5316) 2016-08-10 14:02:44 -07:00
Jason Simmons
2075816df6 Decide whether to compress files in the FLX based on filename extensions (#5317)
Previously the FLX builder compressed assets only if they were not dynamically
generated.  This meant that the license file was not compressed.
2016-08-10 12:37:09 -07:00
Hans Muller
b69a6b95c5 pathname (#5319) 2016-08-10 11:40:39 -07:00
Chinmay Garde
5e2f04173a Account for updated paths during local engine builds. (#5318) 2016-08-10 11:30:07 -07:00
Ian Hickson
a194e59390 Support multilicense LICENSE files generically. (#5310)
Also, add a "flutter build flx --report-licensed-packages" option for
when you need to get the list of the packages affected by licenses.
2016-08-09 20:03:14 -07:00
Jason Simmons
8d5c2540ea Create an empty zip file in ZipToolBuilder if the entry list is empty (#5311)
This can happen if you build an FLX in release mode for an app with no assets
(such as the hello_world example)
2016-08-09 15:50:17 -07:00
Devon Carew
14483586e0 make flutter run work with a pre-built apk (#5307)
* make flutter run work with a pre-built apk

* refactor to remove the buildDir param
2016-08-09 14:38:13 -07:00
Yegor
a0aa0edfc5 --trace-startup: non-zero exit code when fails; enable in iOS runtime (#5309) 2016-08-09 14:12:15 -07:00
John McCutchan
a8198122b8 Enable hot mode for iOS devices (#5308) 2016-08-09 13:02:15 -07:00
John McCutchan
9543366eab Send asset evictions notices to Flutter framework (#5303) 2016-08-09 11:27:12 -07:00
John McCutchan
c13a03fac2 Add analytics for hot reload events (#5300) 2016-08-09 09:36:23 -07:00
Devon Carew
1d0183870b make the apk building part of flutter run optional (#5301) 2016-08-09 09:03:39 -07:00
Devon Carew
4f9e329f0c tweaks to the hot reload messages (#5298) 2016-08-09 07:22:32 -07:00
John McCutchan
4c1dde8d67 Add a control pipe that can trigger reloads / restarts (#5282) 2016-08-09 07:11:24 -07:00
Todd Volkert
6cd90028f6 Include all tools in the cache when --all-platforms is specified (#5296) 2016-08-08 16:18:24 -07:00
John McCutchan
487f28fdc6 Speedup devFS writing and improve status information (#5287) 2016-08-08 12:42:31 -07:00
Devon Carew
30505aef8b support hot mode from the daemon protocol (#5271)
* support hot mode from the daemon protocol

* move method params to constructor
2016-08-05 21:09:42 -07:00
John McCutchan
0a79ffe769 Fix hot restart so that it works with iOS simulators (#5272) 2016-08-05 16:47:15 -07:00
Chris Bracken
49e172e54c Limit font fallback to those in the cache dir (#5270)
This reduces dependence on machine-specific font configuration, making
tests a bit more reproducible.
2016-08-05 15:58:15 -07:00
Jason Simmons
574b2829c8 Update the sky_snapshot command line args to match the latest engine (#5273) 2016-08-05 15:55:43 -07:00
Devon Carew
ce9fcb029f remove the resident cli option (#5263) 2016-08-05 14:16:46 -07:00
Todd Volkert
435ad476d8 Add --all-platforms option to flutter precache (#5254) 2016-08-05 13:11:47 -07:00
John McCutchan
81b4e827e1 Split hot run mode into a separate file (#5233) 2016-08-05 12:04:33 -07:00
Collin Jackson
d2b3976110 Alter iOS template project to be CocoaPods enabled (#4893) 2016-08-05 09:17:13 -07:00
Chris Bracken
0ba0127c1a Support a user-specified observatory port in CoverageCollector (#5217) 2016-08-04 10:43:04 -07:00
Chris Bracken
88536859b4 Correct style in finalizeCoverage parameter list (#5213) 2016-08-03 19:54:33 -07:00
Chris Bracken
a1fa7c94e3 Support passing a custom coverage formatter to finalizeCoverage() (#5208) 2016-08-03 16:58:47 -07:00
Ian Hickson
d7fb51a551 Hot reload UI polish (#5193)
* General improvoments to the loader app:
   * Show a message after 8 seconds if no connection comes in.
   * Show a progress bar as files are being uploaded.
   * Hide the spinner just before launching the application.

* General improvements to the "flutter run" UI:
   * Add "?" key as a silent alias for "h".
   * Make the help text bold so it doesn't get mixed with the logs.
   * Make "R" do a cold restart when hot reload is enabled.

* Supporting features and bug fixes:
   * Add support for string service extensions.

* Other bug fixes:
   * Expose debugDumpRenderTree() outside debug mode.
   * Logger.supportsColor was missing a getter.
   * Mention in the usage docs that --hot requires --resident.
   * Trivial style fixes.
2016-08-02 16:52:57 -07:00
John McCutchan
b11b2a1d46 Add loader screen for --hot mode (#5113) 2016-07-28 13:48:48 -07:00
Ian Hickson
db8ff48dd4 Omit the package names from the license text. (#5102)
This was a minor typo in the original code. It makes the license display
slightly cleaner.
2016-07-27 14:28:53 -07:00
John McCutchan
b6644733c9 Support for synchronizing assets onto a DevFS 2016-07-27 13:28:17 -07:00
pq
72de70250b Merge branch 'dart_1.19.0-dev.0.0' of github.com:pq/flutter into dart_1.19.0-dev.0.0 2016-07-27 11:16:46 -07:00
pq
13c3f9d946 Update Dart (1.19.0-dev.0.0) and analyzer (0.27.4-alpha.19). 2016-07-27 10:44:44 -07:00