Commit Graph

181 Commits

Author SHA1 Message Date
Michael Goderbauer
b0a90aee17
Enable strict-inference (#135043)
Avoids that dynamic accidentally sneaks in, see https://dart.dev/tools/analysis#enabling-additional-type-checks
2023-09-20 19:59:08 +00:00
godofredoc
a70a852c66
Run gsutil with full python3 and full path. (#132805)
This is to prevent failures when the gsutil.py is not executable.
2023-08-17 23:09:44 +00:00
Michael Goderbauer
32aa3128ee
Analyze code snippets in flutter_driver docs (#132337) 2023-08-15 18:02:30 +00:00
Greg Spencer
8b768de18f
Add lint check to make sure samples are linked and have tests (#130523)
## Description

This adds a checker that will check all of the API docs examples to make sure that they are linked from at least one source file in the packages.

It also checks to make sure that all of the examples have an associated test. Since there are a large number that don't have tests at the moment, there is also a large exception list that can be burned down (burn down list is in https://github.com/flutter/flutter/issues/130459).

Because there are missing links currently, this PR will only pass after https://github.com/flutter/flutter/pull/130521 is merged.

## Related Issues

- https://github.com/flutter/flutter/issues/129956
- https://github.com/flutter/flutter/issues/130459

## Tests

- Added test for the checker.
2023-07-18 15:26:09 +00:00
Brandon DeRosier
982e00527c
Manually roll Flutter Engine from 0c41b02cd5a6 to c641f6307f08 (#127514)
Rolls engine to head with
[fixes](https://github.com/flutter/flutter/pull/127505) corresponding to
the [latest Dart roll](https://github.com/flutter/engine/pull/42286).
2023-05-24 14:35:23 -07:00
Tomasz Gucio
99c7e9f088
Add spaces after flow control statements (#126320) 2023-05-15 11:07:30 +02:00
Jason Simmons
6e9c0db206
Manual roll Flutter Engine from ef5c349f04d8 to c784d6d4137d (#126680)
ef5c349f04...c784d6d413

2023-05-12
[skia-flutter-autoroll@skia.org](mailto:skia-flutter-autoroll@skia.org)
Roll Dart SDK from 7ad028c26344 to 4028c7d8b87c (8 revisions)
(https://github.com/flutter/engine/pull/41967)

Requires some update for changes to the Dart analyzer

fixes https://github.com/flutter/flutter/issues/126683
2023-05-12 10:41:54 -07:00
Ian Hickson
806c1f8186
Deprecate these old APIs (#116793)
Deprecate these old APIs
2023-04-06 19:53:50 +00:00
Sigurd Meldgaard
1fd84f88e9
Always use user-level pub cache (#121802)
Use the pub cache resolved by pub itself.
To add packages to the flutter.zip download they are packaged as tar.gz and added to the pub-cache on first run by using  `pub cache preload`.
2023-03-13 08:38:17 +01:00
Lioness100
26b6c1bedd
Fix typos (#121171)
* Fix typos

* lowercase animated & opacity

* Undo typo fix

---------

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
2023-02-23 19:43:21 +00:00
stuartmorgan
c564007f94
Switch analysis to flutter/packages (#120908)
In preparation for the merge of flutter/plugins into flutter/packaegs,
update the cross-repo analysis to flutter/packages rather than
flutter/plugins.

The flutter_plugins.version file is left intentionally for now to avoid
issues with the roller; it will be removed when the roller has been
updated to roll the other repository.
2023-02-21 14:26:08 -05:00
Jesús S Guerrero
d63987f71d
Parser machine logs (#118707)
* remove file reporter optional

* decouple stack trace from metric collections

* update tests; add collect metrics option

* add failed tests property

* add test for multiple stack failed

* change path on result

* create factory method

* throw exception when test file failed to generate

* remove catch of file exception

* handle when no stacktrace on file reporter
2023-02-02 20:04:06 +00:00
Michael Goderbauer
b308555ed1
Enable dangling_library_doc_comments and library_annotations lints (#117365) 2022-12-20 16:03:21 -08:00
Michael Goderbauer
fdd2d7d64a
Sync analysis_options.yaml & cleanups (#117327) 2022-12-20 14:15:39 -08:00
Ian Hickson
9fdb64b7e7
Taboo the word "simply" from our API documentation. (#116061) 2022-12-11 22:43:22 +00:00
godofredoc
61376de9b8
Generate local metadata even when not publishing. (#116087)
* Generate local metadata even when not publishing.

For SLSA compliance we need to separate the fetch, compile and upload
steps of release artifacts. Translating this to the packaging workflows
the fetch step will checkout the prepare_package script at main ToT, the
compile step generate the bundle archives and the recipes will upload
the artifact bundles as part of the upload stage.

This change adds functionality to generate both the release bundle and
the updated metadata file in a way that both files can be uploaded as
part of the upload stage.

Bug: https://github.com/flutter/flutter/issues/115487

* Address comments.

* Update tests.
2022-11-29 04:14:24 +00:00
Jim Graham
92f10ed712
match error statements without relying on volatile human-readable descriptions (#114922)
* match error statements without relying on volatile human readable descriptions

* simplify String list map call
2022-11-09 01:57:52 +00:00
Zachary Anderson
a84e369bd2
Revert "Allow Flutter golden file tests to be flaky (#114450)" (#114902)
This reverts commit 53e6876226.
2022-11-08 09:26:55 -08:00
Kate Lovett
53e6876226
Allow Flutter golden file tests to be flaky (#114450)
* allow marking a golden check as flaky

* add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens/lib

* Pause

* ++

* ++

* Analyzer therapy

* Once more with feeling

* Nits

* Review feedback

* Silly oops

* Test progress

* More tests

* Finish

* Nits

* Analyzer

* Review feedback

Co-authored-by: Yegor Jbanov <yjbanov@google.com>
2022-11-08 01:14:03 +00:00
Jesús S Guerrero
0fe29f5857
Raise an exception when invalid subshard name (#113222) 2022-10-25 17:41:44 +00:00
Casey Hillers
f26dd3730d
[packaging] Run git gc to minimize .git disk footprint (#113467) 2022-10-17 15:43:31 +00:00
Casey Hillers
bc70ae0f57
[packaging] Remove dev references (#113462) 2022-10-17 13:45:19 +00:00
Jesús S Guerrero
8fd46ceeac
Collect metrics - load balancing tests (#108752) 2022-09-30 19:53:35 +00:00
godofredoc
8fbd87065a
Add a script to post-process docs. (#112228) 2022-09-23 18:19:19 +00:00
Ian Hickson
97901da149
Cleaner test.dart output. (#109206) 2022-08-14 08:53:54 +00:00
Ian Hickson
7ded3d91da
API documentation cleanup (#108500) 2022-08-10 22:03:20 +00:00
Ian Hickson
03aa059c3c
Do not abort at first error when tests fail. (#108936) 2022-08-05 16:18:54 -07:00
Greg Spencer
07de84f014
Add StarBorder and StarBorder.polygon, with example. (#108489) 2022-07-28 00:01:05 +00:00
Darren Austin
d9be807192
Updated the analyze.dart deprecation check to only look for beta branch versions. (#105290) 2022-06-06 21:16:49 -07:00
Casey Hillers
a79233cbba
[packaging] Move chromium mirror to flutter mirror (#104222) 2022-05-20 22:03:06 -07:00
Chris Bracken
110c0a7f80
[ci] Add pointer to template image assets wiki (#103787)
Many of our flutter_tools templates include image assets such as
application icons. Adding these will trigger an analysis error from our
CI tooling.

This adds a pointer to the wiki describing the procedure for adding or
updating image assets in the templates:
https://github.com/flutter/flutter/wiki/Managing-template-image-assets

Uncovered while working on https://github.com/flutter/flutter/issues/103371
2022-05-14 10:28:59 -07:00
Michael Goderbauer
8bec125aaf
Avoid analyzing API example code twice, clean-up (#103548) 2022-05-11 21:27:45 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals (#102585) 2022-04-27 09:15:35 +02:00
Jenn Magder
bc0ec85717
Only run test harness tests once instead of every shard (#101218) 2022-04-04 17:27:18 -07:00
godofredoc
875c552c54
Allow different versions of the architecture. (#100345)
If there was a release entry for the same platform and hash the new
entries were filtered out even if the architecture was different.
2022-03-17 21:24:16 -07:00
Jason Simmons
504e669200
Update an analyzer test to support changes to error message text in the latest Dart SDK (#99281)
See https://github.com/flutter/flutter/issues/99248
2022-02-28 10:16:40 -08:00
Zachary Anderson
219bcd329e
Include Dart SDK arch in package info (#97278) 2022-02-02 09:02:02 -08:00
Greg Spencer
e76ad85e01
Output Dart SDK version in published metadata (#96302) 2022-01-07 16:30:14 -08:00
Greg Spencer
3750beacb4
Update platform shims in dev/manual_tests (#94616)
Updates the platform shims in dev/manual_tests so that Windows and Linux can be built. I had to update the Windows shims, because I was unable to build a Windows app there.

Also updates the analyze.dart script to report all license issues simultaneously instead of just dying after the first failure.

The only substantive code changes are in dev/bots/analyze.dart and dev/bots/test/analyze_test.dart
2022-01-07 12:16:24 -08:00
Jonah Williams
fda4094767
[framework] dont allocate forgotten children set in profile/release mode (#94911) 2021-12-14 10:51:30 -08:00
Ian Hickson
bde9f11831
Add a test to verify that we only link to real issue templates (#93528) 2021-11-19 13:13:05 -08:00
Zachary Anderson
366648ae90
Revert "Reland: "Update outdated runners in the benchmarks folder (#91126)" (#92535)" (#93323)
This reverts commit bfe9c59831.
2021-11-09 08:44:56 -08:00
Greg Spencer
bfe9c59831
Reland: "Update outdated runners in the benchmarks folder (#91126)" (#92535) 2021-11-08 21:28:02 -08:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Ian Hickson
2420718389
Remove our extra timeout logic. (#89952) 2021-09-15 09:42:05 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets (#86821) 2021-08-30 15:41:02 -07:00
Greg Spencer
10e4b04010
Switch document generation to use the snippets package (#87231)
Switch document generation to use the snippets package instead of the snippets code in the Flutter repo. In the process, some bugs in sample code analysis have been fixed, and I've fixed some more errors in the samples.

This will allow the snippets package to be developed separately from the Flutter repo, and reduce the code in the Flutter repo.

The snippets code is deleted in this PR.

I also converted some comments in the snippet templates to be regular comments instead of doc comments, because having a doc comment block before the imports causes the Dart import sorter to lose the comment. They should have been regular comments in the first place.

The snippets package resides in the assets-for-api-docs repo.

The sample analysis has also been converted to be run in parallel, and I've bumped the Dartdoc version to 1.0.2.
2021-08-11 19:48:29 -07:00
Chris Bracken
497eb13d03
Migrate python invocations to python3 (#87759)
Python 2 has been end-of-life'd since January 2020, all Python scripts
on which Flutter depends have been migrated to Python 3. This changes
documentation and remaining invocations to explicitly invoke python3.

Issue: https://github.com/flutter/flutter/issues/83043
2021-08-06 14:42:08 -07:00