Rexios
79d5ecc902
[wiki] Remove outdated warning about stale coverage data ( #152560 )
...
Remade https://github.com/flutter/flutter/pull/152529 because the GitHub editor was being dumb and adding trailing newlines without asking
2024-08-02 18:21:58 +00:00
Matan Lurey
888149f9f5
Clarify and cleanup the test-exemption wording in tree-hygiene. ( #152402 )
...
Based off a [discussion on
Discord](https://discord.com/channels/608014603317936148/608018585025118217/1266501306852446421 ),
but I've also anecdotally had a few people ask this before.
Other than a bit of reformatting, I wanted to clarify that the PR
reviewer should still _agree_ an exemption is needed (i.e. not defer
this responsibility entirely to our small volunteer staff of reviewers),
and that _all_ reviewers should feel empowered to push back, and not
wait for a test exemption reviewer to do it. This [matches the guidance
in the
bot](f1b20b6e4c/app_dart/lib/src/service/config.dart (L253-L255)f1b20b6e4c/app_dart/lib/src/service/config.dart (L239-L255)
2024-07-30 16:53:54 -07:00
Rexios
dfedcfe702
[wiki] Remove text saying wiki edits do not get code reviewed ( #152530 )
...
Sequel to https://github.com/flutter/flutter/pull/152529
2024-07-30 03:23:37 +00:00
Kishan Rathore
355fe44f19
docs: Fix typo in data driven fixes test folder section ( #151836 )
...
Previously we were having `corresponding` written as `curresponding`.
2024-07-17 18:10:17 +00:00
Seth Ladd
ba57fa3821
Update Design-Documents.md ( #151472 )
...
Make it more clear that every design doc has a corresponding github tracking issue with appropriate label.
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-07-16 16:01:10 +00:00
Loïc Sharma
ada8def2c9
Add link to design document archive ( #151489 )
2024-07-11 22:58:04 +00:00
Ian Hickson
32c0c39ea5
Mention not @-mentioning people in commit messages in tree hygiene ( #151487 )
...
Update style guide to include anti pattern of mentioning someone in a comment and the flurry of notifications that result.
Came up in a google contributor roundtable discussion.
2024-07-10 15:06:01 +00:00
Nate Wilson
aad381638d
Add a message about spam/brigading ( #150583 )
...
~~I decided to add this message to CODE_OF_CONDUCT.md~~ never mind ð
Let me know if anything should be changed.
2024-07-03 20:18:04 +00:00
Kate Lovett
143847626d
Update deprecation policy ( #151257 )
...
We are pausing our cadence of removing deprecated API from the framework until we can create a new policy.
The last couple of cycles we noticed customers having more difficult migrations, and it being harder to remove the APIs in the scheduled time period. So we need to reevaluate the policy and update it.
This is the policy working as intended. Signals like flutter/tests provide feedback on how we are affecting users - so that for folks that contributed!
Related to https://github.com/flutter/website/pull/10839
2024-07-03 20:01:07 +00:00
derdilla
91b928d52f
Fix link in tree hygene doc ( #151235 )
...
Link in how section of tree hygiene doc pointed to the wrong url for the style-guide doc introduced in [#148790 ](65abc95542
2024-07-03 17:56:46 +00:00
Samuel Wrenn
05f294c711
Fixes for Style Guide for Flutter Repo ( #150167 )
...
Fix broken links, typos, and inconsistent formatting in the Style Guide for Flutter Repo.
Fixes [150164](https://github.com/flutter/flutter/issues/150164 ).
2024-06-26 18:28:03 +00:00
Kate Lovett
62586dc09d
Update old wiki links ( #149544 )
...
Part of https://github.com/flutter/flutter/issues/145009
Finishes updating links in the repo that pointed to the old wiki
2024-06-17 17:26:08 +00:00
Nate Wilson
a8f903223b
Fix markdown hyperlinks in the style guide ( #150071 )
...
Some of the syntax in the migrated [style guide](14df7be3f9/docs/contributing/Style-guide-for-Flutter-repo.md (lazy-programming)#145009 )
<br>
#### Current
> You may hear team members say "embrace the http://www.catb.org/jargon/html/Y/yak-shaving.html [yak
shave]!". This is an encouragement to https://www.youtube.com/watch?v=AbSehcT19u0 [take on the larger effort necessary] to perform a proper fix for a problem rather than just applying a band-aid.
#### This PR
> You may hear team members say "embrace the [yak shave](http://www.catb.org/jargon/html/Y/yak-shaving.html )!". This is an encouragement to [take on the larger effort necessary](https://www.youtube.com/watch?v=AbSehcT19u0 ) to perform a proper fix for a problem rather than just applying a band-aid.
<br>
Workarounds-for-common-issues.md: [**before**](14df7be3f9/docs/wiki_archive/Workarounds-for-common-issues.mdc8d84a71b7/docs/wiki_archive/Workarounds-for-common-issues.md
2024-06-12 18:41:10 +00:00
Kate Lovett
01d1e74af5
Remove abi key permanently from golden file testing ( #149858 )
...
We have fiddled with this a bunch, and there is definitively no way to reliably include this, so I am removing it.
Since CI does not cover all possible values, we can't consistently look up images for local testing. We thought removing it from the look up would work fine, and it did for most tests, but there were still some that could not find an image without it.
A brief history on the abi key
- added in https://github.com/flutter/flutter/pull/143621
- disabled in https://github.com/flutter/flutter/pull/148023
- added back in https://github.com/flutter/flutter/pull/148072
- we thought there was only an issue with alphabetizing keys
- removed from local image look up in https://github.com/flutter/flutter/pull/149696
I updated the docs page to also discuss what makes a good key and what does not based on what we learned here.
2024-06-06 23:05:52 +00:00
Mouad Debbar
7e414e88e0
Fix some links in the "Handling breaking change" section ( #149821 )
...
_Title says it all_
2024-06-06 17:00:51 +00:00
Kate Lovett
1fbcbb73a0
[wiki migration] Leftover wiki pages and links ( #148989 )
...
This is waiting on
- https://github.com/flutter/flutter/pull/148777
- https://github.com/flutter/flutter/pull/148790
After this PR lands, there will likely be 1-2 more clean up PRs, after which the migration will be done!
---
This moves the remaining wiki pages as planned in [flutter.dev/go/migrate-flutter-wiki-spreadsheet](https://docs.google.com/spreadsheets/d/1x65189ZBdNiLRygpUYoU08pwvXD4M-Z157c6pm8deGI/edit?usp=sharing )
It also adds the team labels to the label bot for future PRs.
Changes to the content were only updating cross links, or links to refer to the main branch rather than master.
Remaining links to the wiki will be updated once all other pages have finished moving, they still work in the meantime.
Part of https://github.com/flutter/flutter/issues/145009
2024-05-28 15:12:10 +00:00
Kate Lovett
65abc95542
[wiki migration] Remaining pages under docs/contributing/ ( #148790 )
2024-05-23 15:19:04 -05:00
Kate Lovett
7d891907e3
[wiki migration] Infra team pages ( #148718 )
...
This sorts the wiki pages owned by the Infra team in the docs/ directory as planned in [flutter.dev/go/migrate-flutter-wiki-spreadsheet](https://docs.google.com/spreadsheets/d/1x65189ZBdNiLRygpUYoU08pwvXD4M-Z157c6pm8deGI/edit?usp=sharing )
It also adds the team-infra label to the bot for future PRs.
Image assets were checked in here: https://github.com/flutter/assets-for-api-docs/pull/246
Changes to the content were only updating links. The remaining wiki links will be updated after the rest of the pages are relocated, the original wiki links still work in the meantime.
Part of https://github.com/flutter/flutter/issues/145009
2024-05-21 18:17:10 +00:00
Kate Lovett
bf7d67d80e
[wiki migration] Framework team pages ( #148721 )
...
This sorts the wiki pages owned by the Framework team in the docs/ directory as planned in [flutter.dev/go/migrate-flutter-wiki-spreadsheet](https://docs.google.com/spreadsheets/d/1x65189ZBdNiLRygpUYoU08pwvXD4M-Z157c6pm8deGI/edit?usp=sharing )
It also adds the framework related labels to the bot for future PRs.
Changes to the content were only updating cross links. The remaining wiki links will be updated after the rest of the pages are relocated, the original wiki links still work in the meantime.
Part of https://github.com/flutter/flutter/issues/145009
2024-05-20 23:40:35 +00:00
