github/flutter
7
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2025-06-03 00:51:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
NaN Commits 822 Branches 1,017 Tags 2 GiB
7ad1e38eac
Commit Graph

61 Commits

Author SHA1 Message Date
Devon Carew
7ad1e38eac Fix windows crash (#3236) 
* better messaging about windows support

* fix lints
 2016-04-11 08:34:01 -07:00
Ian Hickson
5291b37fc7 Track how many public Flutter members lack docs 
* Enable the lint require documentation.

* Track how many public Flutter members lack docs

* Rename the .analysis_options file

This makes Atom happier in the flutter_tools package.
 2016-04-04 12:18:13 -07:00
Devon Carew
18d29583d0 pubspec normalization; remove den 2016-04-01 08:33:22 -07:00
Devon Carew
fe37825fd5 run pub with --no-package-symlinks 2016-03-29 19:02:14 -07:00
Adam Barth
522030bdda Remove two flutter analyze regular expressions 
We can work around these in code rather than by post-processing the analyzer
output.
 2016-03-28 16:33:39 -07:00
Kris Giesing
bb5a82a726 Allow independent rendering pipelines 
Fixes #2723
 2016-03-24 14:59:21 -07:00
pq
8b321d7de0 Remove analyze tear-off regexp. 
In the spirit of https://github.com/flutter/flutter/issues/1220, remove the tear-off regexp in favor of in-line suppressions (if needed).
 2016-03-21 11:28:11 -07:00
Devon Carew
f1cdf6df39 refactor; fix apk warning 2016-03-21 09:24:56 -07:00
Hixie
ce4e9cd690 Only require documentation for libraries. 2016-03-18 11:16:12 -07:00
pq
370840ef1f More flutter analyze regexp cleanup 
Runs clean on the repo.  Moving ahead, we can manage exceptions via `.analysis_options` or specific source-level ignores.
 2016-03-14 15:02:55 -07:00
Hixie
797e27edd3 Add @override annotations to flutter framework 2016-03-14 14:02:26 -07:00
Ian Hickson
d745e20853 Even more types 2016-03-14 09:41:54 -07:00
Adam Barth
95fc5ae070 [rename fixit] *Component* -> *Widget* 
This patch renames StatelessComponent to StatelessWidget and
StatefulComponent to StatefulWidget.

Fixes #2308
 2016-03-12 12:34:05 -08:00
Hixie
6795efacab Enable always_specify_types lint 
And fix the zillion issues that uncovered.
 2016-03-12 00:37:31 -08:00
Ian Hickson
43b0104114 Revert "Merge pull request #2639 from Hixie/always_specify_types" 
This reverts commit f41b3411da, reversing
changes made to e33d8d9621.

This was a bad check-in due to my mangling uploading a new version of the branch from a different machine.

This reverts https://github.com/flutter/flutter/pull/2639 and will be replaced by https://github.com/flutter/flutter/pull/2640
 2016-03-12 00:34:37 -08:00
Hixie
d162d98c79 Enable always_specify_types lint 
And fix the zillion issues that uncovered.
 2016-03-11 18:27:32 -08:00
Devon Carew
29df9f5582 show the error code in flutter analyze --watch 2016-03-11 15:59:20 -08:00
pq
0aa07baf70 Migrate flutter analyze config to options. 
More groundwork to get `analyze` and IDE output to agree.

See: https://github.com/dart-lang/sdk/issues/25723
 2016-03-11 14:52:07 -08:00
Phil Quitslund
b9f28e6f75 Merge pull request #2615 from pq/analyze_cleanup 
Analyze command cleanup.
 2016-03-11 14:25:24 -08:00
pq
a2dac85f87 Re-added conflictingNamesPattern. 2016-03-11 13:12:07 -08:00
Devon Carew
94157c91e9 regenerate the i18n files 2016-03-11 10:58:30 -08:00
pq
aedef5139b Analyze command cleanup. 
Removing some special-casing in pursuit of aligning `flutter analyze` output with that provided by server/IDEs.  Specifically:
  * strong-hints (stale, no longer supported)
  * "analyzer says" comment handling in favor of `//ignore`s
  * `conflictingNamePattern` --- no longer needed

Next up some of the error filter regexps...
 2016-03-11 10:35:17 -08:00
Ian Hickson
1b9cd52081 Enable ALL THE LINTS 
Well, all the easy ones, anyway.

For some reason `// ignore:` isn't working for me so I've disabled
lints that need that. Also disabled those that require a ton of work
(which I'm doing, but not in this PR, to keep it reviewable).

This adds:
- avoid_init_to_null
- library_names
- package_api_docs
- package_names
- package_prefixed_library_names
- prefer_is_not_empty
- sort_constructors_first
- sort_unnamed_constructors_first
- unnecessary_getters_setters
 2016-03-10 23:15:31 -08:00
Devon Carew
b9fafc1765 adjust a regex for intl files 2016-03-10 14:21:23 -08:00
Devon Carew
780e4e6212 move the analysis_options to a file 2016-03-10 13:47:20 -08:00
Hixie
c7339de6bc Enable always_declare_return_types lint 
And fix a zillion omissions this uncovered.
 2016-03-09 17:57:39 -08:00
Hixie
8950d3ccc4 Make flutter analyze useful for package conflicts 
Also, resolve our package conflict, since reflectable has been fixed.
 2016-03-09 17:41:05 -08:00
Hixie
5810cd80bd Avoid 'as' keyword 
It has performance implications in release mode.

We'll enable the lint once https://github.com/dart-lang/linter/issues/195 is fixed.
 2016-03-09 15:00:55 -08:00
Devon Carew
52efc7fb68 implement --watch for flutter analyze 2016-03-07 13:46:42 -08:00
Ian Hickson
047276a666 Random fixes to dartdocs, http lib, analyzer 
This is a variety of trivial fixes that I collected while going through the dartdocs.
This does contain some non-comment changes.
 2016-03-03 23:56:40 -08:00
Devon Carew
d911aaa6d0 refactot the stop command to not use DeviceStore 2016-03-03 00:22:40 -08:00
Yegor Jbanov
6d35481cfa add smoke driver test; find by tooltip; retry predicate 2016-02-29 16:50:47 -08:00
Hixie
ba918fea26 flutter analyze: handle missing files 2016-02-26 18:59:07 -08:00
Hixie
a9040433ad Handle lines getting shorter during analysis 2016-02-26 15:37:43 -08:00
Hixie
a33e256ab8 Handle conflicting 'library' identifiers 
Also, handle the new directory structure of the flutter repo.
 2016-02-26 10:58:39 -08:00
pq
fdb2819e1e Ignore errors via analysis options. 
Migrates error suppression from regexps to analysis options.
* Ignore TODOs.
* Ignore strong mode field and method overrides (see `InvalidFieldOverride` and `InvalidMethodOverride` in `strong/info.dart`.
* Remove stale regexp to capture refs to dead `dart:ui_internals` URI.
* Remove stale regexp to capture dead strong mode "will need runtime check to cast to type" error (https://github.com/dart-lang/sdk/issues/24542).

5 regexp downs, another small handful (~4) to go! :)
 2016-02-25 13:49:05 -08:00
pq
b69d249460 Enumerate lints for analysis in synthesized options file. 
This enables us to exclude `library_names` pending a new stable SDK push (see notes: https://github.com/flutter/flutter/pull/1996).  Also excluded are a few lints who's feedback was just getting regexp'ed out.  Moving forward, this will allow us to selectively enable specific lints of interest as well.
 2016-02-23 15:07:55 -08:00
Devon Carew
d5a6fceee5 add a summary option to the doctor class 2016-02-17 09:33:45 -08:00
Devon Carew
2dbceafbc6 introduce globals scoped to the app's context 2016-02-09 22:03:13 -08:00
Adam Barth
3c8cbef973 Rationalize RenderViewport and RenderVirtualViewport 
These classes now share more code and have feature parity.
 2016-02-09 10:30:52 -08:00
Devon Carew
d6b4759fee tweak the output for the analyze command 2016-01-30 22:06:26 -08:00
Devon Carew
d7fbf5302d use status(), error(), and trace() for logging 
rename to printTrace(), printStatus(), and printError()
 2016-01-28 12:44:17 -08:00
Ian Hickson
5494323db9 Move us to HashSet to avoid the overhead of tracking the order 2016-01-23 18:13:13 -08:00
Ian Hickson
62673cf67b Merge pull request #1286 from Hixie/better-analyze 
Make 'flutter analyze' support analyzing arbitrary files
 2016-01-17 22:34:13 -08:00
Ian Hickson
1f6ed67bd9 Make 'flutter analyze' support analyzing arbitrary files 
Before we didn't know how to find the packages of random files. Now we do.
 2016-01-16 13:38:47 -08:00
Ian Hickson
9eb978443b Prepare flutter analyze for dart 1.14 2016-01-16 11:28:13 -08:00
Devon Carew
0f55ebe503 fixes to flutter analyze for the latest dev sdk 2016-01-12 19:04:19 -08:00
Eric Seidel
9257682b01 Remove stray period added from web editor. 2016-01-12 17:09:15 -08:00
Eric Seidel
a6e8fccb90 Correct display error for flutter analyze timing 
Fixes #1213.
 2016-01-12 17:08:38 -08:00
Eric Seidel
001c107858 Teach analyze how to print out the total time spent 
Makes it more obvious that flutter analyze takes a long time.

@Hixie
 2016-01-12 09:20:36 -08:00