Chikamatsu Kazuya
|
c8e34e067c
|
Match CupertinoPageTransitionsBuilder animation duration to CupertinoPageRoute (2) (#161577)
Original PR: #160241 (reverted in #161555 due to regression ), closes
#29068
In addition to the original PR, this includes a fix for the integration
test failure of
[flutter_gallery/transitions_perf_e2e](1b0441c18a/dev/integration_tests/flutter_gallery/test_driver).
Error log is
[here](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8725826401212583777/+/u/run_flutter_gallery__transition_perf_e2e_ios/stdout).
Tested locally on iOS real device and confirmed it passes.
It seems that the next operation of the test was performed before the
page animation was finished because the PR makes the page transition
duration longer.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
|
2025-01-22 19:13:01 +00:00 |
|
Michael Goderbauer
|
10a7c9ba22
|
Unify analysis options (#108462)
|
2022-07-28 09:07:49 -07:00 |
|
Zachary Anderson
|
070309687e
|
Skip Video demo in integration tests of flutter_gallery (#100666)
|
2022-03-24 09:16:46 -07:00 |
|
Ian Hickson
|
61a0add286
|
Enable avoid_redundant_argument_values lint (#91409) (#91462)
|
2021-10-08 09:25:14 -07:00 |
|
Zachary Anderson
|
b9d2177da0
|
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
|
2021-10-07 21:11:07 -07:00 |
|
Ian Hickson
|
5fd259be24
|
Enable avoid_redundant_argument_values lint (#91409)
|
2021-10-07 20:13:02 -07:00 |
|
Dan Field
|
eafadd8b1c
|
Try to dump app again for run_demos.dart (#85048)
|
2021-06-22 10:43:54 -07:00 |
|
Dan Field
|
46c546684f
|
Dump the app if we cannot tap the demo (#84996)
To help deflake https://github.com/flutter/flutter/issues/83298
|
2021-06-21 12:04:43 -07:00 |
|
Dan Field
|
3794884fbb
|
Deflake demo (#84593)
|
2021-06-14 14:41:47 -07:00 |
|
Anis Alibegić
|
c99ed373b3
|
Fixed large amount of spelling errors (#83744)
|
2021-06-02 10:14:06 -07:00 |
|
Phil Quitslund
|
61c30c41b2
|
fix sort_directives violations (#80817)
|
2021-04-21 13:49:03 -07:00 |
|
Jenn Magder
|
f2bb39d6b6
|
Gallery transition tests pass when device rotated (#75672)
|
2021-02-09 10:08:18 -08:00 |
|
Sam Rawlins
|
006638839c
|
Remove "unnecessary" imports. (#74383)
|
2021-01-25 19:04:05 -08:00 |
|
Jonah Williams
|
28ecf05692
|
[null-safety] opt driver tests into null safety (#70245)
|
2020-11-10 16:29:13 -08:00 |
|
Jonah Williams
|
3e41962dff
|
[null-safety] update tests and tool auto-detection for null safe dart (#69405)
Disable null safety auto-detection for the web
|
2020-10-30 13:42:54 -07:00 |
|
Yegor
|
2fa03438de
|
add web_long_running_tests shard containing long-running web tests (#67324)
|
2020-10-29 14:23:02 -07:00 |
|
Michael R Fairhurst
|
7f3c9b6bda
|
Remove unused 'dart:async' imports. (#65568)
|
2020-09-16 14:14:06 -07:00 |
|
Ming Lyu (CareF)
|
360023e2bc
|
Clean up flutter_gallery__transition_perf (#63609)
|
2020-08-13 14:41:04 -07:00 |
|