Commit Graph

576 Commits

Author SHA1 Message Date
Ben Konyi
50c4720913
Update dependencies to pull in new vm_service, dds, dwds, coverage, etc (#98513) 2022-02-18 12:32:08 -08:00
LongCatIsLooong
ad612b59e5
Dump app on keyboard_textfield_test timeout (#98305) 2022-02-13 17:20:18 -08:00
LongCatIsLooong
213f766e35
Use ValueKey finder instead of text finder in keyboard_textfield_test (#97996) 2022-02-07 20:00:19 -08:00
Ian Hickson
ab89ce285f
Clean up the bindings APIs. (#89451) 2022-02-03 14:55:15 -08:00
Harry Terkelsen
03f1d37935
Add a benchmark for a scrolling list of Links (#94638) 2022-02-03 14:38:58 -08:00
Pierre-Louis
a22cf5d6b9
Update packages (#97592)
* update packages

* implement

* remove trailing spaces

* Revert "remove trailing spaces"

This reverts commit d3bffbef57.

* Revert "implement"

This reverts commit 6b6172a827.
2022-02-02 09:16:05 +01:00
Jenn Magder
f085e1a9cd
Add timeout to keyboard finder to diagnose flake (#97258) 2022-01-26 12:00:14 -08:00
Emmanuel Garcia
f01556ab75
Bump Android dependencies that rely on Jcenter (#96558)
* Bump video_player in flutter gallery

* Update packages

* Update dependencies

* Bump device_info

* Update dev/devicelab/bin/tasks/build_ios_framework_module_test.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Update dev/devicelab/bin/tasks/module_custom_host_app_name_test.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Update dev/devicelab/bin/tasks/module_test.dart

Co-authored-by: Jenn Magder <magder@google.com>

* Remove deprecated device_info from ios-frameworks test

Co-authored-by: Jenn Magder <magder@google.com>
2022-01-12 20:13:32 -08:00
Jenn Magder
3e6e996f9e
Run update-packages --force-upgrade (#96325) 2022-01-10 13:55:16 -08:00
Rami
1a3dc1b32a
Update color scheme seed generation to use color utils package (#95175)
* Update color scheme seed generation to use color utils package
2021-12-14 13:53:36 -08:00
Anna Gringauze
d7466d8963
Update dwds and other packages (#94634) 2021-12-07 14:29:07 -08:00
Michael Thomsen
bb906b6b4f
Roll packages to pick up new platform package (#94603) 2021-12-06 10:34:56 +01:00
Darren Austin
418cd95661
Added material_color_utilities as a dependency for flutter package. (#94377) 2021-12-01 14:19:04 -08:00
Nate Bosch
6d1a840bc5
Roll packages, remove unnecessary overrides (#94172) 2021-11-24 14:43:05 -08:00
Mouad Debbar
30b6b9e7f0
Revert "Update Xcode toolsVersion encoded in generated Main.storyboard (#94084)" (#94164)
This reverts commit 6a3ea7eb83.
2021-11-24 10:12:53 -05:00
Jenn Magder
6a3ea7eb83
Update Xcode toolsVersion encoded in generated Main.storyboard (#94084) 2021-11-23 17:38:02 -08:00
Andrei Diaconu
924336fcee
Reland 3: Display Features (#93240) 2021-11-20 15:48:06 -08:00
Gary Qian
02b1146cff
Reland "Exit on deprecated v1 embedding when trying to run or build" (#92901) (#93566) 2021-11-12 15:52:32 -08:00
Yegor
24b9346c9b
Revert "Reland "Exit on deprecated v1 embedding when trying to run or build (#92901)" (#93386)" (#93518)
This reverts commit eabb7cbc34.

It broke multiple tests.
2021-11-11 16:45:40 -08:00
Gary Qian
eabb7cbc34
Reland "Exit on deprecated v1 embedding when trying to run or build (#92901)" (#93386) 2021-11-11 14:49:35 -08:00
Zachary Anderson
858a328712
Revert "Exit on deprecated v1 embedding when trying to run or build (#92901)" (#93365)
This reverts commit 6153bbef3e.
2021-11-09 22:22:14 -08:00
Gary Qian
6153bbef3e
Exit on deprecated v1 embedding when trying to run or build (#92901) 2021-11-09 17:38:03 -08:00
Zachary Anderson
2468f315e0
Revert "Reland: display features (#93117)" (#93204)
This reverts commit 9038fac960.
2021-11-06 22:46:46 -07:00
Andrei Diaconu
9038fac960
Reland: display features (#93117) 2021-11-05 15:54:25 -07:00
Jacob MacDonald
a4fa2affe9
Update packages (#92924) 2021-11-05 12:03:03 -07:00
Zachary Anderson
7779ad3c60
Revert "Reland engine display features (#89511)" (#93098)
This reverts commit 058dfd49a0.
2021-11-04 23:05:45 -07:00
Andrei Diaconu
058dfd49a0
Reland engine display features (#89511) 2021-11-04 18:37:55 -07:00
Emmanuel Garcia
c97a8622bf
Update lockfiles (#92800) 2021-11-01 08:58:13 -07:00
Greg Spencer
5883a6628d
Differentiate between TalkBack versions for semantics tests. (#92602)
Makes the android_semantics_testing test not fail for newer versions of Talkback.

Also, since the test now depends on pub_semver, upgraded the pubspec files.

The only substantive changes in the PR are in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart
2021-10-29 16:38:09 -07:00
Emmanuel Garcia
4d79bb02c4
Bump Kotlin version in templates and projects (#92052) 2021-10-25 13:13:03 -07:00
LongCatIsLooong
e00d87ffcc
[keyboard_textfield_test] wait until the keyboard becomes visible (#92032) 2021-10-19 15:03:04 -07:00
Emmanuel Garcia
d7631275fe
Bump targetSdkVersion to 31 and organize static values (#91719) 2021-10-15 13:41:48 -07:00
Danny Tuppeny
f8f96a4f80
Run "flutter update-packages --force-upgrade" to get latest DDS (#91736) 2021-10-13 10:58:04 -07:00
Ian Hickson
bb5cbdc635
Enable depend_on_referenced_packages lint (#91653) 2021-10-12 11:28:02 -07:00
Zachary Anderson
5188df0821
Revert gradle roll (#91459)
* Revert "Mark last failing test after gradle update as flaky. (#91423)"

This reverts commit 46a52d03bd.

* Revert "fix android template for Gradle 7 (#91411)"

This reverts commit 51d06d537f.

* Revert "Add explicit version for mac and windows openjdk. (#91408)"

This reverts commit bf429f2771.

* Revert "Update the openjdk version used by linux android tests. (#91405)"

This reverts commit 2144ab8b45.

* Revert "Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642)"

This reverts commit b6459f9b63.
2021-10-07 19:42:24 -07:00
Taha Tesser
b6459f9b63
Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642) 2021-10-06 17:01:13 -07:00
Ian Hickson
126cd7388e
Clean up dependency pins and update all packages (#91109) 2021-10-04 10:28:03 -07:00
Littlegnal
1b73a35fba
Change project.buildDir in standalone subprojects property (#91030) 2021-10-01 17:18:05 -07:00
Christopher Fujino
afd84ad425
flutter update-packages (#90994) 2021-09-30 11:38:02 -07:00
Greg Spencer
ab2b0851a2
Add smoke tests for all the examples, fix 17 broken examples. (#89021)
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
2021-09-28 09:32:06 -07:00
Jenn Magder
1b53f7beba
Migrate iOS project to Xcode 13 compatibility (#90304) 2021-09-22 13:23:05 -07:00
Kate Lovett
65d8dd988d
Update md5 method in flutter_goldens_client (#90154) 2021-09-15 17:42:05 -07:00
Anna Gringauze
cd112e551c
Update all packages (#89797) 2021-09-13 12:13:42 -07:00
Jacob MacDonald
383930c2bc
update package dependencies (#89381) 2021-09-02 14:41:05 -07:00
Christopher Fujino
efaa9a4637
update-packages --force-upgrade (#88728) 2021-08-23 12:57:08 -07:00
Christopher Fujino
81eb54bf78
update-packages (#88387) 2021-08-17 18:49:32 -07:00
Gary Qian
a562b3cb3d
Deferred components integration test app (#88030) 2021-08-16 15:32:05 -07:00
Jenn Magder
28dfb44559
Add native iOS screenshots to integration_test (#84611) 2021-08-06 12:45:04 -07:00
Anna Gringauze
cc63c81408
Update all packages (#87579)
- Update dwds and and the rest of the packages

Closes: https://github.com/flutter/flutter/issues/87100
2021-08-03 16:37:48 -07:00
Jacob MacDonald
fdb80f916d
update packages to the latest (#86880) 2021-07-22 13:26:05 -07:00
Anna Gringauze
84c3b56877
Update dwds (and other packages) (#86832)
* Upgrade all packages

In particular, bring in dwds with latest fixes for flakes.

Closes: https://github.com/flutter/flutter/issues/85043
Related: https://github.com/flutter/flutter/issues/85575

* Re-enable fixed tests

* Disable failing test due to DDS issue
2021-07-21 21:47:10 -07:00
Jenn Magder
f50e2316e6
Remove unused build_mode_test (#86808) 2021-07-21 16:01:05 -07:00
Kaushik Iska
df3fe587e8
Validate that min frame number is numeric (#86498) 2021-07-15 17:11:09 -07:00
Eng Zer Jun
57a4b023f1
build: update dependencies (#86433) 2021-07-14 13:46:04 -07:00
Yegor
78e06e716b
[web] move e2e tests from flutter/engine to flutter/flutter (#86119)
* [web] move e2e tests from flutter/engine to flutter/flutter
* flutter update-packages --force-upgrade
2021-07-09 15:31:49 -07:00
Filip Hracek
76d5e62f42
Add a more complete app template for Flutter (skeleton) (#83530) 2021-06-28 15:26:04 -07:00
Jenn Magder
c2980383e8
Run build_tests shard and check in project migrations (#85270) 2021-06-24 17:41:02 -07:00
Jenn Magder
0de6bd41ba
Migrate iOS app deployment target from 8.0 to 9.0 (#85174) 2021-06-24 10:21:05 -07:00
Dan Field
9c0bd18c40
Reland eliminate timeouts from integration tests (#85141) 2021-06-23 13:08:51 -07:00
Dan Field
69f2f8a18b
Revert "Remove per-test timeouts from integration tests (#85098)" (#85133)
This reverts commit b96c3c22ce.
2021-06-23 08:17:27 -07:00
Dan Field
b96c3c22ce
Remove per-test timeouts from integration tests (#85098) 2021-06-23 07:17:28 -07:00
Jonah Williams
03d14a30c8
[versions] remove mockito (#85076) 2021-06-22 17:41:03 -07:00
Jenn Magder
1d2f6c5296
Revert "Set up iOS native integration_tests in ui example project (#84890)" (#84892)
This reverts commit 05d5515732.
2021-06-18 18:05:00 -07:00
Jenn Magder
05d5515732
Set up iOS native integration_tests in ui example project (#84890) 2021-06-18 17:45:11 -07:00
Jonah Williams
cd13c91119
[versions] update dependencies (#84639) 2021-06-15 11:08:57 -07:00
Jenn Magder
697928d21f
Revert "Set up iOS native integration_tests in ui example project (#84596)" (#84641)
This reverts commit ef2879a46f.
2021-06-15 10:09:41 -07:00
Jenn Magder
ef2879a46f
Set up iOS native integration_tests in ui example project (#84596) 2021-06-14 18:04:02 -07:00
Michael Goderbauer
5a2530b28e
Remove unused protobuf dependency (#84148) 2021-06-07 15:34:06 -07:00
Michael Goderbauer
14b2e7ffee
flutter update-packages --force-upgrade (#83911) 2021-06-03 10:50:11 -07:00
Emmanuel Garcia
0bccce6260
[gradle] Unlock all configurations if a local engine is used (#83635) 2021-06-01 13:19:03 -07:00
Jonah Williams
025a3a7da3
[versions] roll package test redux (#83367) 2021-05-26 17:22:28 -07:00
Emmanuel Garcia
fa5883b78e
Add Gradle lockfiles and tool to generate them (#83067) 2021-05-21 13:04:03 -07:00
Jenn Magder
d7e49e559b
Run update packages, pick up file 6.1.1 (#82770) 2021-05-18 13:09:03 -07:00
Chris Bracken
3445cb86f2
Update dependency versions (#82577)
shelf 1.1.2 -> 1.1.4
flutter_template_images 1.0.2 -> 3.0.0
2021-05-14 16:51:36 -07:00
Kenzie Schmoll
766b4509c6
Add 'v' hotkey to open DevTools in the browser (#82227)
* Add 'v' hotkey to open DevTools in the browser
2021-05-13 09:54:10 -07:00
Alexandre Ardhuin
df3662b15e
use throwsA (#82238) 2021-05-11 10:19:01 -07:00
Michael Goderbauer
b8a2456737
Enable library_private_types_in_public_api lint (#81578) 2021-05-10 16:26:16 -07:00
Jonah Williams
2b0d09dd81
[versions] roll versions and add ffi dep (#81403) 2021-04-28 11:19:03 -07:00
Abhishek Ghaskata
a195bcc0cf
Migrate dev/integration_tests/ui to null safety (#80624) 2021-04-27 18:50:51 -07:00
Jonah Williams
7d6e581f61
[versions] roll in latest shelf (#81099) 2021-04-23 20:39:02 -07:00
Jenn Magder
0f899f2b64
Roll packages (#80989) 2021-04-22 15:01:49 -07:00
Jonah Williams
d9638d25d7
migrate from jcenter to mavencentral (#80908) 2021-04-21 21:41:07 -07:00
Jenn Magder
4f3ec01d32
Add frontend_server_client to dependency allowlist (#80912) 2021-04-21 18:13:43 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations (#80817) 2021-04-21 13:49:03 -07:00
Emmanuel Garcia
42f21fd780
Standardize how Java8 is set in gradle files (#80600) 2021-04-19 20:19:03 -07:00
Dan Field
e7b7ebc066
Shake widget inspector from non-debug builds (#80157) 2021-04-14 21:54:03 -07:00
Dan Field
d7da6190ff
roll packages (#80307) 2021-04-13 18:19:02 -07:00
Jonah Williams
443d07b707
[versions] roll to latest test (#79099) 2021-03-31 07:45:40 -07:00
Jia Hao
8158b478d7
Add tests for integration tests to devicelab (#79258) 2021-03-30 22:29:03 -07:00
Jonah Williams
dfc134dd9a
[versions] roll many versions (#79088) 2021-03-25 15:43:44 -07:00
Jenn Magder
2eca1f4033
Migrate dev projects from jcenter to mavenCentral (#78812) 2021-03-22 17:39:02 -07:00
Jonah Williams
74a795d165
roll more versions (#78654) 2021-03-19 15:46:03 -07:00
Jonah Williams
28532edaa5
Update all versions and migrate devicelab framework to package:vm_service (#78557) 2021-03-18 12:38:12 -07:00
Ahmed Saleh
740504d3e6
Refactor: use one subprojects property (#77942) 2021-03-12 16:28:03 -08:00
Jonah Williams
ddcb8d7d6d
Update all versions! (#77153) 2021-03-03 14:11:30 -08:00
Michael Goderbauer
0f568298d8
enable use_key_in_widget_constructors lint (#77032) 2021-03-02 10:14:02 -08:00
Jia Hao
1c179c401f
Bump packages (#76673) 2021-02-24 09:21:03 -08:00
Jenn Magder
9ab50033fc
Build more integration tests during pre-submit (#76554) 2021-02-22 14:04:09 -08:00
Jason Simmons
73ec544238
Update all packages and upgrade to path_provider 2.0.0-nullsafety (#76420) 2021-02-19 16:40:24 -08:00
Jonah Williams
db1e9f053f
update all packages (#76254) 2021-02-17 17:33:56 -08:00
Jonah Williams
7088c5ba2a
Update all packages (#76143) 2021-02-16 15:29:12 -08:00
Ian Hickson
b1cc48748d
Only write the pid-file while listening to SIGUSR signals. (#74533) 2021-02-10 16:06:05 -08:00
Dan Field
bc1cf49458
roll packages (#75370) 2021-02-04 11:41:03 -08:00
Ian Hickson
ac3b9e7f89
Unpin mysteriously pinned packages (#74885) 2021-02-01 14:31:03 -08:00
Michael Goderbauer
0e815a1b87
Bump flutter_gallery_assets (#75026) 2021-02-01 04:51:04 -08:00
Dan Field
5575caa118
vm_service 6.0.1-nullsafety.1, dwds 8.0.2 (#74943) 2021-01-28 18:39:07 -08:00
Ian Hickson
29e604e241
Update packages (#74874) 2021-01-28 00:04:03 -08:00
Jenn Magder
51b3edd45f
Revert "Remove package image dependency (#74763)" (#74869)
This reverts commit ca2d7b3d3c.
2021-01-27 19:50:58 -08:00
Ian Hickson
ca2d7b3d3c
Remove package image dependency (#74763) 2021-01-27 17:19:03 -08:00
Dan Field
71aec53acb
roll packages (#74781) 2021-01-26 21:53:04 -08:00
Dan Field
d1538320d2
Roll packages to null safe (vm_service, test, etc.) (#74671) 2021-01-26 09:15:54 -08:00
Sam Rawlins
006638839c
Remove "unnecessary" imports. (#74383) 2021-01-25 19:04:05 -08:00
Dan Field
1b373f45b7
Remove unused bigquery code and deps (#74532) 2021-01-22 16:21:01 -08:00
Jonah Williams
7ee910b0a8
[flutter_tools] ensure --dart-define can parse args with commas (#73798) 2021-01-15 13:51:32 -08:00
Jonah Williams
22684ead6f
[versions] update all dependencies (#73800) 2021-01-12 15:14:05 -08:00
Jenn Magder
45d71e25ab
Build iOS apps using Swift Packages (#73508) 2021-01-07 15:59:09 -08:00
Ian Hickson
544a41eb55
Remove an obsolete comment from pubspec.yaml (#73505) 2021-01-07 15:59:04 -08:00
Jenn Magder
74d58105d1
Revert "Build iOS apps using Swift Packages (#72761)" (#73437)
This reverts commit 28db5a0fae.
2021-01-06 15:04:16 -08:00
Jenn Magder
28db5a0fae
Build iOS apps using Swift Packages (#72761) 2021-01-06 13:54:53 -08:00
Jenn Magder
d6857bc026
Build/copy macOS frameworks to built products instead of ephemeral directory (#72378) 2020-12-17 14:47:05 -08:00
Jenn Magder
1129e6f86c
Move embedding and linking macOS Flutter frameworks into the tool (#72372) 2020-12-15 12:05:44 -08:00
Jenn Magder
d553aa06c7
Revert "Reland Move embedding and linking macOS Flutter frameworks into the tool (#71965)" (#72012)
This reverts commit 0b6b3eecfe.
2020-12-09 11:19:49 -08:00
Jenn Magder
0b6b3eecfe
Reland Move embedding and linking macOS Flutter frameworks into the tool (#71965) 2020-12-09 09:46:53 -08:00
Jenn Magder
c88ab79bd2
Revert "Move embedding and linking macOS Flutter frameworks into the tool (#71764)" (#71951)
This reverts commit 70f8fdeeed.
2020-12-08 15:28:30 -08:00
Jenn Magder
70f8fdeeed
Move embedding and linking macOS Flutter frameworks into the tool (#71764) 2020-12-08 11:59:17 -08:00
Jenn Magder
e1598c96c0
Update macOS Xcode compatibilityVersion (#71745) 2020-12-04 18:35:19 -08:00
Jenn Magder
e9abf5a940
Profiling Xcode app should use Flutter profile mode (#71748) 2020-12-04 16:59:19 -08:00
Jenn Magder
f0b17f3e26
Remove missing macOS RunnerUITests (#71750) 2020-12-04 15:58:03 -08:00
Emmanuel Garcia
8dd0de7f58
Relands: Migrate template to Gradle 6.7 and AGP 4.1.0 (#71446) 2020-12-01 19:01:09 -08:00
Gary Roumanis
7477524db6
Upgrade deps (#71450) 2020-12-01 09:57:27 -08:00
Amir Hardon
7df04fdbd3
Revert "Migrate template to Gradle 6.7 and AGP 4.1.0 (#70808)" (#71096)
This reverts commit 8e73bab94c.
2020-11-23 12:27:36 -08:00
Emmanuel Garcia
8e73bab94c
Migrate template to Gradle 6.7 and AGP 4.1.0 (#70808) 2020-11-20 13:05:35 -08:00
Jonah Williams
c6290500f8
[flutter_tools] update dependencies (#70797) 2020-11-18 17:29:28 -08:00
Ben Konyi
4cbafda853
Roll package:dds to 1.5.1 and add isCompleted guards around completers in base/dds.dart (#70712) 2020-11-17 16:03:18 -08:00
Jenn Magder
2529e358b6
Move Flutter.framework to build directory instead of ios/Flutter (#70224) 2020-11-17 10:09:29 -08:00
Dan Field
76784651d4
Move package:integration_test to flutter/flutter (#69622) 2020-11-05 17:28:47 -08:00
Jonah Williams
e8efde6a54
[versions] update more null safe versions (#69892) 2020-11-05 09:09:03 -08:00
Jonah Williams
580cacf4bd
[versions] roll versions (#69810) 2020-11-04 15:38:58 -08:00
Emmanuel Garcia
212967449b
Update plugins dependencies for the Gallery test (#69630) 2020-11-03 12:03:18 -08:00
Jonah Williams
18f0a2288e
[flutter_tools] update to vm_service 5.2.0, update to dwds 7.0.0 (#69067)
Rolls in several fixes to web tooling, including better handling of absolute file imports. Updates to latest vm service to unblock null safety mode query

Co-authored-by: Gary Roumanis <grouma@google.com>
Co-authored-by: Anna Gringauze <annagrin@google.com>
2020-10-27 13:55:32 -07:00
Dan Field
36f9af3f55
reland driver vm_service migration (#69126)
* One more reland of "Driver vm service (#68654)" (#69074)" (#69077)" (#69089)"

This reverts commit e5814756a2.

* pub run test
2020-10-27 11:30:24 -07:00
Dan Field
e5814756a2
Revert "Revert "Revert "Driver vm service (#68654)" (#69074)" (#69077)" (#69089)
This reverts commit 05ab0eba19.
2020-10-27 01:47:03 -07:00
Dan Field
05ab0eba19
Revert "Revert "Driver vm service (#68654)" (#69074)" (#69077)
This reverts commit 19ce7a86af.
2020-10-26 19:22:25 -07:00
Jonah Williams
19ce7a86af
Revert "Driver vm service (#68654)" (#69074)
This reverts commit 3ecac303b4.

Co-authored-by: Dan Field <dfield@gmail.com>
2020-10-26 18:56:34 -07:00
Dan Field
3ecac303b4
Driver vm service (#68654)
Migrate flutter_driver to use package:vm_service
2020-10-26 17:09:14 -07:00
Jacob MacDonald
193fe3e980
Update null safe deps to prepare for the 2.12 sdk version (#69041)
* update pinned null safety deps

* run update-packages

* add http dep to devicelab package

* rerun update-packages
2020-10-26 14:31:13 -07:00
Jenn Magder
d81691d0f4
Revert "Build iOS apps using Swift Packages (#68361)" (#68546)
This reverts commit dd9323bdfb.
2020-10-19 17:57:32 -07:00
Jenn Magder
dd9323bdfb
Build iOS apps using Swift Packages (#68361) 2020-10-19 15:47:04 -07:00
Martin Kustermann
6fae89c8b5
Update package:stack_trace dependency to 1.10.0-nullsafety.4 (#68132) 2020-10-16 16:35:20 +02:00
Sam Rawlins
23c7ee9deb
Bump meta to 1.3.0-nullsafety.4 (#67744) 2020-10-12 09:50:30 -07:00