* M3 counter error style
* polish
* Update text_field_template.dart
* Roll Flutter Engine from 3cba105ed0bd to cf0db3e54687 (1 revision) (#108716)
* resolve comments
* Roll Plugins from 257eacb1e2aa to a6d42f1e01d3 (3 revisions) (#108738)
* Override PlaceholderDimensions equality operator to avoid unnecessary TextPainter re-layouts (#108623)
* Roll Flutter Engine from cf0db3e54687 to aa9004449786 (1 revision) (#108734)
* Roll Flutter Engine from aa9004449786 to 6d2fd23404b8 (5 revisions) (#108744)
* Fix lerp to eccentric circle. (#108743)
* Roll Flutter Engine from 6d2fd23404b8 to f182794500dc (4 revisions) (#108749)
* Roll Flutter Engine from f182794500dc to 25e8021c91e4 (1 revision) (#108751)
* Sync with https://github.com/flutter/.github/pull/13 (#108754)
* Roll Flutter Engine from 25e8021c91e4 to e771729efdde (2 revisions) (#108755)
* clean-up analysis_options.yaml (#108747)
* Fix ExpansionTile shows children background when expanded (#107834)
* Create `containsSemantics` to allow for partial matching of semantics in tests. (#108573)
* Roll Flutter Engine from e771729efdde to 7d0f6d2f11df (2 revisions) (#108757)
* Enable conditional_uri_does_not_exist (#108652)
* Roll Flutter Engine from 7d0f6d2f11df to b257966d8daa (3 revisions) (#108763)
* Roll Flutter Engine from b257966d8daa to 60e5eb6f3c2c (3 revisions) (#108766)
* Reland `Linux_samsung_a02 openpay_benchmarks__scroll_perf` (#108466) (#108769)
* [SelectionOverlay]Move the debug statement to the scope of the assertion. (#108508)
* Roll Flutter Engine from 60e5eb6f3c2c to 1c3b1b305ef3 (11 revisions) (#108780)
* Roll Flutter Engine from 1c3b1b305ef3 to b6078110efda (1 revision) (#108782)
* Roll Flutter Engine from b6078110efda to 3b2bd24a1e0b (1 revision) (#108784)
* Roll Flutter Engine from 3b2bd24a1e0b to 0e5392c4c248 (1 revision) (#108788)
* Roll Flutter Engine from 0e5392c4c248 to 4b192569797f (1 revision) (#108793)
* Roll Flutter Engine from 4b192569797f to e0b5edc1131b (2 revisions) (#108798)
* Roll Flutter Engine from e0b5edc1131b to b164c5c86d1c (1 revision) (#108814)
* Update text_field.dart
* Roll Flutter Engine from b164c5c86d1c to eb2b57bdb7bc (4 revisions) (#108821)
* Roll Plugins from a6d42f1e01d3 to 0d6d03a94ed5 (1 revision) (#108822)
* Roll Flutter Engine from eb2b57bdb7bc to 978d8e2dbe35 (2 revisions) (#108825)
* Loupe Android + iOS (#107477)
* added Magnifier for iOS and Android
* Mark `Mac_ios microbenchmarks_ios_flaky` flaky (#108820)
* Deprecate `toggleableActiveColor` (#97972)
* Roll Flutter Engine from 978d8e2dbe35 to 2b3173254281 (4 revisions) (#108830)
* [flutter_tools] Test that DAP process terminates at the end of a session (#108301)
* Roll Flutter Engine from 2b3173254281 to 4e9c8699468a (1 revision) (#108833)
* fix noop toString() diagnostics (#108836)
* [flutter_tools] Migrate more tool tests to null-safety (#108639)
* Revert "Fix ExpansionTile shows children background when expanded" (#108844)
* Roll Flutter Engine from 4e9c8699468a to 6724561b1cf4 (2 revisions) (#108838)
* Marks Linux_android clipper_cache_perf__e2e_summary to be unflaky (#104088)
* Update documentation to match implementation (#108843)
* Reland "Add shadowColor and surfaceTintColor to Dialog and DialogTheme." #108718
* Roll Flutter Engine from 6724561b1cf4 to f3deaba5a359 (8 revisions) (#108847)
* Roll Flutter Engine from f3deaba5a359 to c07e1acfadda (2 revisions) (#108849)
* Roll Flutter Engine from c07e1acfadda to a1e77ae885a0 (5 revisions) (#108850)
* Roll Flutter Engine from a1e77ae885a0 to c4564762773f (2 revisions) (#108853)
* Roll Flutter Engine from c4564762773f to 6cd744bb9706 (1 revision) (#108857)
* Roll Flutter Engine from 6cd744bb9706 to 51296a62d98c (1 revision) (#108860)
* Roll Flutter Engine from 51296a62d98c to 05228ad454bc (1 revision) (#108862)
* Revert "Roll Flutter Engine from 51296a62d98c to 05228ad454bc (1 revision) (#108862)" (#108882)
This reverts commit a880c4ed35.
* Roll Plugins from 0d6d03a94ed5 to e74c42028d39 (5 revisions) (#108887)
* Roll Flutter Engine from 51296a62d98c to 2c282981d849 (6 revisions) (#108899)
* [flutter_test] Add flag to send device pointer events to the framework (#108430)
* Roll Flutter Engine from 2c282981d849 to adba70232a61 (2 revisions) (#108903)
* fix flutter not finding custom device (#108884)
* Force a11y services to off for complex_layout_semantics_perf test (#108906)
* Update `equalsIgnoringHashCodes` to take a list of Strings (#108507)
* [macOS] Use editing intents from engine (#105407)
* Added `IconButtonTheme` and apply it to `IconButton` in M3 (#108332)
* Created IconButtonTheme and apply it to IconButton
* [web] Add onEntrypointLoaded to FlutterLoader. (#108776)
* Roll pub packages (#108919)
* [flutter_test] perf: find.ancestor (#108868)
* Roll Flutter Engine from adba70232a61 to 1188a808e1e0 (4 revisions) (#108922)
* Bump github/codeql-action from 2.1.17 to 2.1.18 (#108923)
* Remove some outdated ignores from framework (#108915)
* Roll Flutter Engine from 1188a808e1e0 to 1743d1db1dda (1 revision) (#108925)
* Clean up ScrollbarPainter (#107179)
* Remove outdated ignores (#108924)
* Add more logs to diagnose Gold flake (#108930)
* M3 counter error style
* polish
* Update text_field_template.dart
* resolve comments
* Update text_field.dart
Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Tomasz Gucio <72562119+tgucio@users.noreply.github.com>
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-authored-by: Ian Hickson <ian@hixie.ch>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Bruno Leroux <leroux_bruno@yahoo.fr>
Co-authored-by: pdblasi-google <109253501+pdblasi-google@users.noreply.github.com>
Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com>
Co-authored-by: xubaolin <xubaolin@oppo.com>
Co-authored-by: Anthony Oleinik <48811365+antholeole@users.noreply.github.com>
Co-authored-by: keyonghan <54558023+keyonghan@users.noreply.github.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Danny Tuppeny <danny@tuppeny.com>
Co-authored-by: Phil Quitslund <pq@users.noreply.github.com>
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com>
Co-authored-by: parkershepherd <me@parkershepherd.com>
Co-authored-by: Darren Austin <darrenaustin@google.com>
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
Co-authored-by: Jia Hao <jiahaog@users.noreply.github.com>
Co-authored-by: Hannes Winkler <hanneswinkler2000@web.de>
Co-authored-by: Matej Knopp <matej.knopp@gmail.com>
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
Co-authored-by: David Iglesias <ditman@gmail.com>
Co-authored-by: Pascal Welsch <pascal@welsch.dev>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Added standard IconButton for M3 with new ButtonStyle field
* Added IconButton examples for standard, filled, filled_tonal, and outlined types
Co-authored-by: Qun Cheng <quncheng@google.com>
Roll dependendencies
This rolls depdendencies to latest using
flutter update-packages --force-upgrade
This change includes three code changes:
* Removes charcode from the dependencies allowlist since it no longer
appears in the transitive closure of dependencies of the flutter,
flutter_test, flutter_driver, flutter_localizations, and
integration_test packages.
* Uses Resolver.create instead of the deprecated Resolver constructor.
The default Resolver constructor has been deprecated in favour of the
static Resolver.create() factory function, which unfortunately happens
to be async. Propagated the async-ness up the chain.
This change was partially reverted and the deprecation ignored in this
patch until package:coverage can be rolled internally at Google.
* Eliminates the use of the deprecated packagesPath parameter to
HitMap.parseJson. This parameter was deprecated and replaced with
packagePath in https://github.com/dart-lang/coverage/pull/370 which
was part of the overall deprecation of the .packages file in Dart
itself https://github.com/dart-lang/sdk/issues/48272. The overall goal
being that end-user code shouldn't need to know about implementation
details such as whether dependency information is stored in a
.packages file or a package_info.json file, but rather use the
package_config package to obtain the package metadata and perform
other functions such as resolving its dependencies to filesystem
paths. packagesPath was replaced by packagePath, which takes the path
to the package directory itself. Internally, package:coverage then
uses package_config to do the rest of the package/script URI
resolution to filesystem paths.
This change was partially reverted and the deprecation ignored in this
patch until package:coverage can be rolled internally at Google.
This is a pre-update prior to updating flutter_template_images in
https://github.com/flutter/flutter/pull/103739
Issue: https://github.com/flutter/flutter/issues/103371
Issue: https://github.com/flutter/flutter/issues/103775
Issue: https://github.com/flutter/flutter/issues/103830
When re-applying the partially-reverted changes to code coverage,
we'll need to patch host_entrypoint.dart internally to await the Future
that we'll be returning rather than a non-async value.
When I added localizations for shortcut keys, I added some that actually can't be shortcut keys, so I'm removing them again. These are mostly Japanese-specific keys that don't even appear on modern keyboards for the most part.
Also, added menuBarMenuLabel for an accessibility label for menu bar menus.
I modified the code for the localization generation scripts to add a --remove-undefined flag that will remove any localizations that don't appear in the canonical locale.
Makes the android_semantics_testing test not fail for newer versions of Talkback.
Also, since the test now depends on pub_semver, upgraded the pubspec files.
The only substantive changes in the PR are in dev/integration_tests/android_semantics_testing/test_driver/main_test.dart
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.
The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.
The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
Switch document generation to use the snippets package instead of the snippets code in the Flutter repo. In the process, some bugs in sample code analysis have been fixed, and I've fixed some more errors in the samples.
This will allow the snippets package to be developed separately from the Flutter repo, and reduce the code in the Flutter repo.
The snippets code is deleted in this PR.
I also converted some comments in the snippet templates to be regular comments instead of doc comments, because having a doc comment block before the imports causes the Dart import sorter to lose the comment. They should have been regular comments in the first place.
The snippets package resides in the assets-for-api-docs repo.
The sample analysis has also been converted to be run in parallel, and I've bumped the Dartdoc version to 1.0.2.
The (new, not yet used) code gen for iOS was setting up a std::map from key codes to logical and physical key codes, but it was using uint32_t, which isn't big enough to hold the Flutter key codes.
Also, iOS needs to be able to filter out function keys, so I added a function key set.
This PR updates the ID used by logical keyboard keys.
The logical key ID is still composed of 2 parts: 32 bits of value, and 8 bits of plane. But the assignment of planes has been drastically changed. HID plane is removed, and unprintable plane and Flutter plane are added. This is to reflect the new generation method for logical key IDs. Now keys that are defined by Flutter but not by dom_key_data are placed into the Flutter plane, including numpad keys, sided modifier keys, and gamepad keys. The values for platform planes have also been adjusted.
The generation script and README have been updated accordingly as well.
A new file, test_utils/key_codes.h is now generated to assist engine unit testing.
All lists generated by the script are now sorted by the key.
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated.
Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
Adds tests to the following behaviors, which have existed without tests:
- When tapping during live testing, a message is printed with widgets that contain the tap location.
- When tapping during live testing, a mark is displayed on screen on the tap location.
This adds iOS key map generation that uses std::maps. It uses std::maps because on iOS if we use NSDictionaries, then when XCode loads the dylib, the initialization of those status NSDictionaries hasn't yet occurred, and it crashes the app. std::maps have a well-defined static behavior, and are correctly initialized.
I also made the naming of variables, fields, etc. consistent for macOS. We variously had macosFoo, macOSFoo, and macOsFoo. I eliminated macOsFoo and macosFoo, since the rest of the repo uses macOSFoo for lowerCamelCase names (with only a few exceptions). I used iOSFoo for iOS.
