yaakovschectman
|
7d37f2a616
|
Opt into CMake policy CMP0135 (#125502)
~Update the windows app template and migration to use `CMP0135` when
cmake version is >= 3.24.~
Update app templates' and examples' CMakeLists.txt to use
`cmake_policy(VERSION`. https://github.com/flutter/packages/pull/3828
should obviate the need for a migration.
Addresses https://github.com/flutter/flutter/issues/116866
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
|
2023-04-28 17:49:54 -04:00 |
|
Lioness100
|
26b6c1bedd
|
Fix typos (#121171)
* Fix typos
* lowercase animated & opacity
* Undo typo fix
---------
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
|
2023-02-23 19:43:21 +00:00 |
|
Tomasz Gucio
|
98576cef58
|
Avoid null terminating characters in strings from Utf8FromUtf16() (#109729)
---------
Co-authored-by: schectman <schectman@google.com>
|
2023-02-13 19:22:37 +01:00 |
|
yaakovschectman
|
455e6aca50
|
Test integration test apps' runner files against current template app (#118646)
* Create template file test
* Add to .ci.yaml
* Add to TESTOWNERS
* Organize test script
* Push license to top of file
* Equals sign
* Utilize path.join
* Expand error message
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
* Fix missing newline string
* Move template file test to analyze.dart
* Fix newline
* Var name
* Fix extension length
* Use ignore-list for filenames
* Update dev/bots/analyze.dart
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
* Indentation
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
|
2023-01-24 17:00:22 -05:00 |
|
yaakovschectman
|
5e50ed972b
|
Test Utf8FromUtf16 (#118647)
|
2023-01-23 16:07:55 -05:00 |
|
Loïc Sharma
|
22f3b4edf5
|
[Windows] Use dark title bar on dark system theme (#111042)
|
2022-09-09 22:23:59 +00:00 |
|
Jenn Magder
|
c075ef058c
|
Revert "[Windows] Use dark title bar on dark system theme" (#110890)
|
2022-09-03 00:18:34 +00:00 |
|
Loïc Sharma
|
2fb5b2729a
|
[Windows] Use dark title bar on dark system theme (#110615)
|
2022-09-02 23:15:12 +00:00 |
|
Loïc Sharma
|
c60cf97c19
|
[Windows] Hide app until first frame is drawn (#109816)
|
2022-08-30 14:26:21 +00:00 |
|
Loïc Sharma
|
4898f1f5c5
|
[Windows] Add app startup integration test (#110114)
Add a basic integration test for the Windows's app startup. In a subsequent change (https://github.com/flutter/flutter/pull/109816), this test will be updated to verify the app's window isn't visible until after the first frame has been drawn.
Part of https://github.com/flutter/flutter/issues/41980
|
2022-08-25 18:54:20 -07:00 |
|