Andrew Kolos
5b2f658ff5
Revert "[tool] Move Java functions to their own file" ( #126569 )
...
Reverts flutter/flutter#126086 .
This PR changed the interfaces of some classes, namely `AndroidSdk`, and deleted a global.
These classes had custom overrides in g3 that were not updated with a g3fix, so this PR has broken tests. See https://b.corp.google.com/issues/281945232 (non-public link)
2023-05-11 17:06:57 +00:00
Andrew Kolos
0a63cd70f1
[tool] Move Java functions to their own file ( #126086 )
...
This is the first step in unifying Java-finding logic across the tool. If curious, see #126029 for an example of what all the changes will probably entail.
Moves java-related functionality like `AndroidSdk.findJavaHome` to a new class, `Java`.
See tracking issue https://github.com/flutter/flutter/issues/126126 for more.
2023-05-11 04:32:25 +00:00
Kevin Moore
7d9f2082f1
tool: Move cdKey to CustomDimensionsEnum ( #125335 )
2023-04-24 22:59:20 +00:00
Christopher Fujino
3736274a6d
Revert "[flutter_tools] Remove sound null safety flag ( #123031 )" ( #123280 )
...
Revert "[flutter_tools] Remove sound null safety flag (#123031 )"
2023-03-22 22:53:49 +00:00
Christopher Fujino
f4c3facfdd
Revert "Revert "[flutter_tools] Remove sound null safety flag ( #120936 )" ( #122909 )" ( #123031 )
...
[flutter_tools] Remove sound null safety flag #2
2023-03-20 22:32:07 +00:00
Christopher Fujino
f6bc147c91
Revert "[flutter_tools] Remove sound null safety flag ( #120936 )" ( #122909 )
...
This reverts commit 7c3088cf22
.
2023-03-17 11:31:48 -07:00
Christopher Fujino
7c3088cf22
[flutter_tools] Remove sound null safety flag ( #120936 )
...
[flutter_tools] Remove sound null safety flag
2023-03-17 17:48:35 +00:00
Jesús S Guerrero
530324d232
Build command dependency injection ( #114383 )
...
* update flutter build command
* update tests
* fix analyze suggestions
2022-11-08 23:38:10 +00:00
Jenn Magder
2f03dda55e
Fix Android Studio version string nullablity, fake AndroidStudio in test ( #113295 )
2022-10-12 18:32:55 +00:00
Jonah Williams
db829c1e20
[flutter_tools] migrate more unit tests to null safety ( #106153 )
2022-06-17 21:34:27 -07:00
Jenn Magder
1c0eade94c
Hide PII from doctor validators for GitHub template ( #96250 )
2022-01-10 13:20:21 -08:00
Jenn Magder
9e88fe328e
Remove globals_null_migrated.dart, move into globals.dart ( #92861 )
2021-11-01 17:18:03 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be24
.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Lau Ching Jun
2acd0007d6
Refactor CustomDimensions in analytics to be type safe ( #82531 )
2021-05-18 20:29:03 -07:00
Jonah Williams
63fc778f41
[flutter_tools] remove mocks from dart plugins test ( #82413 )
2021-05-13 13:14:04 -07:00
Ian Hickson
6beafa7b16
Apply style guide regarding createTempSync pattern ( #81090 )
2021-04-27 14:59:03 -07:00
Jenn Magder
16c73829a6
Migrate reporting library to null safety ( #80320 )
2021-04-15 17:01:34 -07:00
Jenn Magder
a2f67720ef
Migrate test/src/common to null safety ( #79907 )
2021-04-06 22:55:03 -07:00
Jonah Williams
021311ed8a
Revert "[flutter_tools] move process manager into tool ( #75350 )" ( #75639 )
...
This reverts commit 8b6baae44c
.
2021-02-08 09:21:46 -08:00
Jonah Williams
8b6baae44c
[flutter_tools] move process manager into tool ( #75350 )
...
Our current top crasher is an unclear error when ProcessManager fails to resolve an executable path. To fix this, we'd like to being adjusting the process resolution logic and adding more instrumentation to track failures. In order to begin the process, the ProcessManager has been folded back into the flutter tool
2021-02-04 13:19:11 -08:00
Jenn Magder
73506f36f7
Replace MockConfig with TestConfig ( #75044 )
2021-02-01 18:16:05 -08:00
Jonah Williams
18b1e23e89
[flutter_tools] move some fakes out of mocks.dart ( #74992 )
2021-01-29 14:28:18 -08:00
Jonah Williams
e53c48968f
[flutter_tools] remove mock SystemClock ( #74994 )
2021-01-29 14:28:08 -08:00
Jenn Magder
6ecb8cbcfa
Replace MockUsage with TestUsage ( #74946 )
2021-01-28 18:49:04 -08:00
Jenn Magder
ff87150ba9
Revert "Swap MockStdio to FakeStdio in tests ( #74838 )" ( #74867 )
...
This reverts commit 547ed88ab3
.
2021-01-27 19:35:16 -08:00
Jenn Magder
547ed88ab3
Swap MockStdio to FakeStdio in tests ( #74838 )
2021-01-27 17:33:47 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
Jonah Williams
7c618758bb
[flutter_tools] delegate first run message re-display to new class, only if changed ( #73353 )
2021-01-05 18:44:04 -08:00
Jonah Williams
0b88269807
[flutter_tools] remove branch migration and standardize constructor style for version interface ( #70058 )
2020-11-12 15:29:03 -08:00
Jonah Williams
e18533e7ab
[flutter_tools] remove globals from android_workflow ( #69548 )
2020-11-06 10:55:52 -08:00
Jenn Magder
e8fbb43aac
Replace MockFile with memory file system files ( #66941 )
2020-09-29 17:50:33 -07:00
Jenn Magder
2eca1d303c
Use fake command in analytics test ( #58544 )
2020-06-03 21:23:01 -07:00
Zachary Anderson
6f0ed5e142
[flutter_tools] Restore base/platform.dart ( #56410 )
2020-05-06 08:15:39 -07:00
Zachary Anderson
e8778da12c
[flutter_tools] Don't crash when analytics fails to initialize ( #52775 )
2020-03-18 10:00:14 -07:00
Jenn Magder
f6a55125d2
Add usage event for failed iOS project migration ( #51879 )
2020-03-06 12:14:29 -08:00
Zachary Anderson
b9ecebf101
Reland: [flutter_tools] Disable analytics for more bots ( #50641 )
2020-02-12 10:58:02 -08:00
Zachary Anderson
1903ce012e
Revert "[flutter_tools] Disable analytics for more bots ( #50579 )" ( #50622 )
...
This reverts commit 0a38f29c0d
.
2020-02-11 22:47:41 -08:00
Zachary Anderson
0a38f29c0d
[flutter_tools] Disable analytics for more bots ( #50579 )
2020-02-11 15:48:02 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes ( #50368 )
2020-02-11 20:58:27 +01:00
Dan Field
134c2ff076
analytics ordering issue ( #48278 )
2020-01-07 12:23:02 -08:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable ( #47398 )
2020-01-06 11:04:20 -08:00
Ian Hickson
449f4a6673
License update ( #45373 )
...
* Update project.pbxproj files to say Flutter rather than Chromium
Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
* Update the copyright notice checker to require a standard notice on all files
* Update copyrights on Dart files. (This was a mechanical commit.)
* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).
* Clean up the copyrights in non-Dart files. (Manual edits.)
Also, make sure templates don't have copyrights.
* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Alexandre Ardhuin
980f14e0c5
implicit-casts:false on flutter_tools ( #45153 )
...
* implicit-casts:false on flutter_tools
* use castStringKeyedMap
* address review comments
* address review comments
* fix issues after rebase
2019-11-24 06:54:43 +01:00
Jonah Williams
4c677e4148
Extra defensive programming for pub modification time assert ( #43315 )
2019-10-22 22:05:00 -07:00
Jonah Williams
46ea99122b
Revert "Extra defensive programming for pub modification time assert ( #42491 )" ( #43235 )
...
This reverts commit 3597bae6a0
.
2019-10-21 20:54:02 -07:00
Ian Hickson
3597bae6a0
Extra defensive programming for pub modification time assert ( #42491 )
2019-10-21 20:15:20 -07:00
Ian Hickson
08643c41d7
Always fake ProcessManager when you fake Filesystem in tests ( #42369 )
...
...because otherwise, processes that think they're manipulating your
filesystem will be doing crazy things the test is ignoring, leading to
(at best) failures and (at worst) flakes or disk corruption.
2019-10-11 11:23:12 -07:00
Zachary Anderson
cf0d4979c7
[flutter_tool] Re-work analytics events to use labels and values ( #42016 )
2019-10-07 15:04:55 -07:00