Elias Yishak
0d5875274b
Clearer text about what happens with --disable-telemetry + enable-telemetry command ( #125995 )
...
Fixes:
- https://github.com/flutter/flutter/issues/124411
This PR is cleaning up the `--disable-telemetry` help message to make it clear that opting out will opt out of all telemetry collection for flutter and dart commands. It is also adding the opposite flag `--enable-telemetry` which will enable telemetry collection
2023-05-08 13:01:25 +00:00
Elias Yishak
ca3a900d5d
[reland] Update helper message for --suppress-analytics ( #125145 )
...
Relanding: https://github.com/flutter/flutter/pull/124810
Fixes: https://github.com/flutter/flutter/issues/124808
2023-04-19 18:51:08 +00:00
godofredoc
03d725620a
Revert "Update helper message for --suppress-analytics" ( #125141 )
...
Reverts flutter/flutter#124810
2023-04-19 16:43:29 +00:00
Elias Yishak
3476b96652
Update helper message for --suppress-analytics ( #124810 )
...
Fixes: https://github.com/flutter/flutter/issues/124808
2023-04-19 14:00:20 +00:00
Elias Yishak
51b23bc961
Update runner to handle logic for both analytics packages ( #124606 )
...
Update runner to handle logic for both analytics packages
2023-04-12 19:34:11 +00:00
Elias Yishak
a32f0bb7a0
Add analytics package + setTelemetry method attached ( #124015 )
...
The first of many PRs for transitioning to `package:unified_analytics`.
This PR is only focused on disabling and enabling telemetry via the
`flutter config --[no-]analytics` flag
Fixes: https://github.com/flutter/flutter/issues/121617
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Christopher Fujino <fujino@google.com>
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
2023-04-05 14:08:56 -04:00
Lau Ching Jun
944a4c9714
Write crash report in temp directory if writing to CWD failed. ( #113316 )
2022-10-12 17:13:24 +00:00
Liam Appelbe
ec75399beb
Null safety migration of packages/flutter_tools/test/general.shard, part 1/2 ( #110711 )
...
* Migrate packages/flutter_tools/test/general.shard, part 1/2
* Fix most of the tests
* Fix analysis
* Fix analysis
* Fix test
* Fix analysis
* Fix analysis
* Fix nit
2022-09-08 15:25:27 -07:00
Christopher Fujino
08d5d51a98
[flutter_tools] Instantiate shutdown hooks before localfilesystem ( #110693 )
2022-09-02 17:38:56 +00:00
Pierre-Louis
0c2f7bc2a2
Remove errant double spaces ( #110758 )
2022-09-02 04:00:58 +00:00
Anurag Roy
47b40601d7
[flutter_tools] Have FlutterValidator fail on non-ideal git config ( #103259 )
2022-06-20 19:05:07 +00:00
Jenn Magder
c6ced845e3
Remove custom unawaited, prefer dart:async version ( #103212 )
2022-05-07 08:49:04 -07:00
Alexandre Ardhuin
07f1c20474
add missing trailing commas in list/set/map literals ( #102585 )
2022-04-27 09:15:35 +02:00
Lau Ching Jun
d7688ca093
Change all instance of throwing strings to throw specific error classes. ( #97325 )
2022-02-02 10:45:18 -08:00
Jenn Magder
1c0eade94c
Hide PII from doctor validators for GitHub template ( #96250 )
2022-01-10 13:20:21 -08:00
crisboarna
eb1a851f58
feat(flutter_tools): Added doctor host validation feat ( #95386 )
2021-12-16 08:02:13 -08:00
Kenzie (Schmoll) Davisson
7748731903
Add DevTools version to flutter --version and flutter doctor -v output. ( #93065 )
...
* Add DevTools version to `flutter --version` output.
* review comments
* fix test
* add explanatory comment
* dummy commit to kick bots
Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
2021-11-11 14:40:22 -08:00
Jenn Magder
9e88fe328e
Remove globals_null_migrated.dart, move into globals.dart ( #92861 )
2021-11-01 17:18:03 -07:00
Jenn Magder
6987c9fb82
Migrate crash_reporting and github_template ( #91516 )
2021-10-12 13:48:03 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint ( #91409 ) ( #91462 )
2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint ( #91409 )" ( #91461 )
...
This reverts commit 5fd259be24
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint ( #91409 )
2021-10-07 20:13:02 -07:00
Ian Hickson
f25b833f27
Enable avoid_print lint. ( #91444 )
2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. ( #91332 )" ( #91438 )
...
This reverts commit cb378edc9e
2021-10-07 16:16:17 -04:00
Ian Hickson
cb378edc9e
Enable avoid_print lint. ( #91332 )
2021-10-07 09:53:03 -07:00
Lau Ching Jun
2acd0007d6
Refactor CustomDimensions in analytics to be type safe ( #82531 )
2021-05-18 20:29:03 -07:00
Jonah Williams
064eae8c38
[flutter_tools] remove mocks and fix fake imports ( #81309 )
2021-04-27 11:51:41 -07:00
Jenn Magder
e29595d4b6
Remove crash_reporting and github_template from reporting library ( #80139 )
2021-04-09 15:24:15 -07:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
Jonah Williams
7c618758bb
[flutter_tools] delegate first run message re-display to new class, only if changed ( #73353 )
2021-01-05 18:44:04 -08:00
Jonah Williams
1271447bbe
[flutter_tools] remove globals from FlutterValidator, add documentation and move tests to new file ( #67234 )
...
Remove globals from the flutter validator class, and refactor the tests into a separate file. Applies some other cleanup like adding doc comments, and making the doctor validator work like it is documented to work - removing the gen_snapshot check if the artifact is not downloaded instead of downloading all android artifacts.
#47161
2020-10-05 17:58:56 -07:00
Jenn Magder
e8fbb43aac
Replace MockFile with memory file system files ( #66941 )
2020-09-29 17:50:33 -07:00
Jonah Williams
bd3eee75f3
[flutter_tools] rethrow process exceptions as tool exit from gradle build ( #64745 )
...
The flutter tool is currently unable to detect missing permissions in gradle/gradle.bat that would cause a gradle build to fail via process exception. Rather than crashing and exiting, we can display the exception as an error message and tool exit.
While linux/macOS are able to add the +x bit, this is not possible on windows with our current file system/OS API. These crashes represent a substantial amount of crash reporting, but are otherwise not actionable on our end.
2020-09-03 11:55:55 -07:00
James D. Lin
c21b3233e4
[flutter tools] Don't return success if we trigger runZoned's error callback ( #58474 )
2020-06-15 09:35:04 -07:00
Jonah Williams
f5de6aadd4
[flutter_tools] remove zone level overrides of verbose and daemon logging ( #57448 )
...
Make it possible for all FlutterCommands to be global free, by moving instantiation to inside the Zone context. Additionally, provide VerboseLogger and NotifyLogger (daemon) at the top level and remove from command-specific overrides.
This allows removing a work around where web devices needed to look up directly from the context in non-test code.
Technically the output preferences are still zone injected, but these will be moved soon as they were not being used correctly by the top level command (the injection comes after ArgParser reads the overflow values, causing numerous wrap issues)
2020-06-04 16:35:36 -07:00
Zachary Anderson
6f0ed5e142
[flutter_tools] Restore base/platform.dart ( #56410 )
2020-05-06 08:15:39 -07:00
kwkr
1ac09088c3
Fix/use contains ignoring whitespace ( #55887 )
2020-04-28 13:12:12 -07:00
James D. Lin
b7fd24a7dc
[flutter tools] Move _informUserOfCrash into crash_reporting.dart ( #55614 )
2020-04-28 10:34:03 -07:00
Jenn Magder
8109dcc2b4
CrashReportSender dependency injection ( #54924 )
2020-04-20 15:23:09 -07:00
Jenn Magder
fc76fc2a96
Move GitHubTemplateCreator into reporting library ( #55002 )
2020-04-17 10:47:12 -07:00
Jenn Magder
602475e56f
Sanitize error message sent to GitHub crash reporter ( #53936 )
2020-04-06 11:00:22 -07:00
Jenn Magder
85ad699865
Remove URL shortening from GitHub reporter similar issues URL ( #53882 )
2020-04-03 10:32:55 -07:00
Lasse R.H. Nielsen
af5194dbfd
Prepare Flutter for SDK changes to runZoned. ( #52953 )
...
The `runZoned` method deprecates the `onError` parameter.
Invocations using that parameter must use `runZonedGuarded` instead.
This prepares Flutter for the deprecation. The same places need to be migrated to using
`runZonedGuarded` when the SDK change has been ported to Flutter.
Then the deprecated member will be removed in a follow-up CL when the most important
packages have been migrated.
2020-03-24 08:34:17 -07:00
Jenn Magder
f6a55125d2
Add usage event for failed iOS project migration ( #51879 )
2020-03-06 12:14:29 -08:00
Zachary Anderson
b9ecebf101
Reland: [flutter_tools] Disable analytics for more bots ( #50641 )
2020-02-12 10:58:02 -08:00
Zachary Anderson
1903ce012e
Revert "[flutter_tools] Disable analytics for more bots ( #50579 )" ( #50622 )
...
This reverts commit 0a38f29c0d
2020-02-11 22:47:41 -08:00
Zachary Anderson
0a38f29c0d
[flutter_tools] Disable analytics for more bots ( #50579 )
2020-02-11 15:48:02 -08:00
Ian Hickson
449f4a6673
License update ( #45373 )
...
* Update project.pbxproj files to say Flutter rather than Chromium
Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
* Update the copyright notice checker to require a standard notice on all files
* Update copyrights on Dart files. (This was a mechanical commit.)
* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).
* Clean up the copyrights in non-Dart files. (Manual edits.)
Also, make sure templates don't have copyrights.
* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Jenn Magder
7d8f82051b
Suggest GitHub template when flutter tool crashes ( #45360 )
...
* On flutter tool crash suggest GitHub template
* Shorten GitHub URLs
* Whitespace
* Wording tweak from @InMatrix
* Review edits
2019-11-26 14:06:31 -08:00
Alexandre Ardhuin
980f14e0c5
implicit-casts:false on flutter_tools ( #45153 )
...
* implicit-casts:false on flutter_tools
* use castStringKeyedMap
* address review comments
* address review comments
* fix issues after rebase
2019-11-24 06:54:43 +01:00
