Commit Graph

72 Commits

Author SHA1 Message Date
Jonah Williams
14759dc5a4
Revert "[flutter_tools] pin transitive deps during --transitive-closure (#80911)" (#80959)
This reverts commit c2aa193c5f.
2021-04-22 09:39:39 -07:00
Jonah Williams
c2aa193c5f
[flutter_tools] pin transitive deps during --transitive-closure (#80911) 2021-04-21 21:40:48 -07:00
Jenn Magder
4f3ec01d32
Add frontend_server_client to dependency allowlist (#80912) 2021-04-21 18:13:43 -07:00
Jenn Magder
95d7d671c6
Remove analyze --dartdocs flag (#80484) 2021-04-18 09:29:02 -07:00
Jonah Williams
f6f59c58bc
create SDK package allowlist for core packages (#80318) 2021-04-16 14:29:32 -07:00
Alexandre Ardhuin
a6832d4d32
add missing trailing commas (#79299) 2021-03-29 21:29:02 -07:00
Michael Goderbauer
197b440e96
Migrate out custom ignore syntax to flutter_ignore (#78497) 2021-03-19 15:33:05 -07:00
Ian Hickson
f3c25fa07a
Align more closely with package:test (#77118) (#78343) 2021-03-16 13:58:02 -07:00
Zachary Anderson
e7e1a04aa3
Revert "Align more closely with package:test (#77118)" (#78329)
This reverts commit 0cbe597540.
2021-03-16 09:26:34 -07:00
Ian Hickson
0cbe597540
Align more closely with package:test (#77118) 2021-03-15 16:28:02 -07:00
Tong Mu
7abee113e8
[Analyze] Make deprecation note analyzer clearer on quote misuse (#77653)
* Impl

* Escape$

* eofnl

* Make message more clear
2021-03-09 13:21:45 -08:00
Michael Goderbauer
cb867bbedc
Enable unnecessary_await_in_return lint (#77434) 2021-03-05 18:38:15 -08:00
Michael Goderbauer
7e017d318e
Enable file_names and package_names lints (#77087) 2021-03-02 15:24:04 -08:00
Jenn Magder
65e94f51c0
Remove unused flutter_driver_screenshot integration test (#76575) 2021-02-23 19:56:02 -08:00
Yuqian Li
fb552edcb8
Do not analyze files that are not checked in git (#69723) 2020-11-07 05:19:02 -08:00
Dan Field
76784651d4
Move package:integration_test to flutter/flutter (#69622) 2020-11-05 17:28:47 -08:00
Jonah Williams
5fa801718f
[flutter_tools] remove train and inject-plugins command (#67766)
The train command does nothing and was originally added to provide a no-output default for generating app-jit snapshots. The inject-plugins command is only for a repo-only analysis check, which is not necessary since we regenerate during pub get.

#29805
2020-10-09 15:43:39 -07:00
Jonah Williams
14722d3166
[gallery] add linux and windows files to gallery example (#66736)
Check in linux and windows platform code now that they are stable, so that we could use in devicelab in the future. Removed the ICO from the windows example to avoid analysis check, and since it won't be important for benchmarking or UI tests
2020-09-28 10:07:35 -07:00
Darren Austin
4253e42b43
Add .DS_Store to ignore list for the analyzer to run on macos cleanly. (#65530) 2020-09-18 14:37:04 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. (#65568) 2020-09-16 14:14:06 -07:00
Jim Graham
210f7680fc
ignore .idea directory in dart analyzer and analyzer benchmark output (#55235) 2020-07-29 17:16:26 -07:00
Darren Austin
753b84894c
Ignore .idea/* files in the analysis bot. (#61215) 2020-07-20 18:51:04 -07:00
Christopher Fujino
5cfb16b193
Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59876)
This relands #59120, which was reverted in #59870.
2020-06-19 12:03:38 -07:00
Christopher Fujino
0d7ff7a9e7
Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120)" (#59870)
This reverts commit 8665e13801.
2020-06-19 10:52:52 -07:00
Ian Hickson
8665e13801
Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter (#59120) 2020-06-18 18:08:01 -07:00
Michael Goderbauer
584fd5f913
Word substitutions (#59484)
* Word substitutions

* ++
2020-06-16 09:15:43 -07:00
Paul Berry
c32d1387ab
Fix overly specific detection of non-UTF8 files in analyzer bot. (#56295)
An upcoming Dart SDK change
(fa2fd41166)
changes the precise text of the exception generated by `utf8.decode`
if a non-UTF8 file is found.  This is causing a breakage in the Dart
team's `flutter-analyze` bot (and will presumably cause a breakage in
the corresponding Flutter bot as soon as this change is rolled into
Flutter).  To avoid this breakage, the bot shouldn't rely on the exact
exception text; it is sufficient to simply catch a FormatException.
2020-05-04 09:10:20 -07:00
Jonah Williams
0b3f5cfcc0
[flutter_tools] initial support for enable experiment, run, apk, ios, macos (#54617) 2020-04-21 20:39:36 -07:00
Alexandre Ardhuin
f5a9902577
enable avoid_equals_and_hash_code_on_mutable_classes (#52507) 2020-04-06 13:36:01 -07:00
stuartmorgan
685e9d1e47
Add pre-stable support for create on Windows (#51895)
Adds initial support for flutter create of apps and plugins. This is derived from the current FDE example app and sample plugin, adding template values where relevant.

Since the APIs/tooling/template aren't stable yet, the app template includes a version marker, which will be updated each time there's a breaking change. The build now checks that the template version matches the version known by that version of the tool, and gives a specific error message when there's a mismatch, which improves over the current breaking change experience of hitting whatever build failure the breaking change causes and having to figure out that the problem is that the runner is out of date. It also adds a warning to the create output about the fact that it won't be stable.

Plugins don't currently have a version marker since in practice this is not a significant problem for plugins yet the way it is for runners; we can add it later if that changes.

Fixes #30704
2020-03-23 10:42:26 -07:00
Michael Thomsen
e167181444
Move flutter_gallery to the testing folder (#52532)
Move Flutter Gallery to dev/integration_tests/ as it is an older copy used only for testing. The current version of the Flutter Gallery now lives in https://github.com/flutter/gallery.
2020-03-16 10:31:42 +01:00
Casey Hillers
781cd4d87c
Update Devicelab README with new dashboard information (#48908) 2020-02-11 18:25:17 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Jenn Magder
13e30aaec6
Remove android directory from platform_channel_swift example project (#50213) 2020-02-06 11:39:55 -08:00
Greg Spencer
4b4cff94bf
Move stocks example app into dev/benchmarks/test_apps (#49559)
The stocks example app is outdated and deprecated, but we still use it for some benchmark tests. Moving it into the benchmarks directory to indicate its status.
2020-01-30 09:31:07 -08:00
Jonah Williams
ab426858b1
[flutter_tools][web] add favicon to template and update index.html (#49237) 2020-01-28 13:09:18 -08:00
Dan Field
3e63411256 Avoid runtimeType.toString in toString overrides/debugLabels (#48607) 2020-01-14 16:43:01 -08:00
Jonah Williams
5d30c0970a
[flutter_tools][web] Add support for web app manifests and arbitrary resource files (from web/) (#48316) 2020-01-10 09:37:20 -08:00
LongCatIsLooong
d291de086c
Add a diagnostic message for malformed imports in analyze.dart (#38355) 2020-01-09 10:25:58 -08:00
Alexandre Ardhuin
4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Dan Field
24f39d40a4 Revert "Revert "Add many more global analyses. (#47875)" (#48080)" (#48081)
This reverts commit 04ea3183ce.
2020-01-02 11:47:28 -08:00
Francisco Magdaleno
04ea3183ce
Revert "Add many more global analyses. (#47875)" (#48080)
This reverts commit e768c92fbc.
2020-01-02 09:25:59 -08:00
Ian Hickson
e768c92fbc
Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Shi-Hao Hong
7874bca248
Move localization executables to bin folder (#46251) 2019-12-16 17:30:57 -08:00
Alexandre Ardhuin
ec1a015045
implicit-casts:false in dev (#45787) 2019-12-05 22:34:06 +01:00
Ian Hickson
a78fb87dfe
Relicense Shrine demo to match rest of repository (#45718)
* Relicense Shrine demo to match rest of repository

The Shrine demo was Apache-licensed. The code was mostly
Google-written, with contributions from:

 - Michelle Dudley (@michdud)

 - Abhijeeth Padarthi <rkinabhi@gmail.com> (@rkinabhi)

 - @a14n

I contacted all three, and they confirmed their approval for this
change, as described below.

Abhijeeth Padarthi said by e-mail on Thu, Nov 21, 2019 at 5:48 PM:

> hi Ian,
>
> sure :)
>
> let me know if I need to do anything on my end..

Michelle Dudley wrote by e-mail on Sun, Nov 24, 2019 at 2:07 PM:

> Hi Ian,
>
> That would be ok with me.
>
> Thanks,
>
> Michelle

@a14n said on Discord's Flutter server in the #hackers channel at 10:44PM on Thursday, November 21, 2019:

> @Hixie no problem I agree with this relicensing

* Remove shrine loophole from license checker.
2019-11-27 16:25:56 -08:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Michael Goderbauer
f8cafd9dbc
Remove URLs in deprecation annotation (#45215) 2019-11-20 12:45:04 -08:00
Ian Hickson
62e4ab87b3
Update our deprecation style. (#44618) 2019-11-15 19:21:53 -08:00
Ian Hickson
eae05c7daf
Test framework for analyze.dart (#44772)
* Prepare analyze.dart for testing.

* Reorder the file for easier understanding

* Add a test for analyze.dart

* Fix review comments
2019-11-14 13:19:40 -08:00