I previously made a PR (#136140) that used `switch` expressions to make some parts of the Flutter codebase easier to understand. It was assigned to the framework team, and @christopherfujino let me know that it was too large to effectively review and recommended breaking it up into smaller pull requests.
Here's a PR that only targets files in the `dev/` directory. Hopefully this will be easier to work with!
(solves issue https://github.com/flutter/flutter/issues/136139)
Context: https://github.com/flutter/flutter/issues/131862
This PR injects a "realm" component to the storage base URL when the contents of the file `bin/internal/engine.realm` is non-empty.
As documented in the PR, when the realm is `flutter_archives_v2`, and `bin/internal/engine.version` contains the commit hash for a commit in a `flutter/engine` PR, then the artifacts pulled by the tool will be the artifacts built by the presubmit checks for the PR.
This works for everything but the following two cases:
1. Fuchsia artifacts are not uploaded to CIPD by the Fuchsia presubmit builds.
2. Web artifacts are not uploaded to gstatic by the web engine presubmit builds.
For (1), the flutter/flutter presubmit `fuchsia_precache` is driven by a shell script outside of the repo. It will fail when the `engine.version` and `engine.realm` don't point to a post-submit engine commit.
For (2), the flutter/flutter web presubmit tests that refer to artifacts in gstatic hang when the artifacts aren't found, so this PR skips them.
Fixes https://github.com/flutter/flutter/issues/129744
This change:
1. re-enables the Linux packages_autoroller
2. ensures we redact the token from appearing in any logs (in local testing I realized some failure logs might still expose the token)
What actually fixed authentication however was creating and uploading a new GitHub personal access token, not this change.
It's currently failing post-submit because being marked `bringup` it is running in the try pool, which does not have permissions to access the cloud KMS. However, I ran a LED build in the prod pool that succeeded:
3a8f128c35/+/build.proto
* readability refactor
* update post-submits
Update post submit testing status location from LUCI to cocoon. Conductor users will still have to use navigation to pick the correct repository and release candidate to monitor.
* e0f736dab Set error handler (flutter/engine#33402)
* dcd596a99 Roll Dart SDK from 381855557df2 to f3bf9025c141 (1 revision) (flutter/engine#33411)
* 5c2a16e07 Roll Fuchsia Linux SDK from F0_B8WVKY... to IZ7_b83xC... (flutter/engine#33415)
* 4958a245a Roll dart sdk to 1bdb83bddf96c41cc046810c697a2c80bfaaaf19 (flutter/engine#33416)
* d2fd3d852 Roll Fuchsia Mac SDK from t_ky8l6nb... to egBfZMmTP... (flutter/engine#33417)
* d58fc83f1 Roll Dart SDK from 1bdb83bddf96 to 0bc104c3e959 (1 revision) (flutter/engine#33419)
* 8ab172029 Roll Skia from 0a5146ca3ffd to 16fa353926b8 (28 revisions) (flutter/engine#33420)
* Remove fraction translation
* Update codesign.dart
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
* c4b899f63 Roll dart sdk to 7b24ff4d92e2d2136020fc5bedadfe7025861510 (flutter/engine#33309)
* 7956603cc [web] Migrate Flutter Web DOM usage to JS static interop - 12. (flutter/engine#33241)
* 1d0c2ae6f Roll Skia from 1e43dce386c9 to f6e31bf1dcfb (6 revisions) (flutter/engine#33320)
* ed5a2fef0 Roll Skia from f6e31bf1dcfb to 69fecd6c2d85 (1 revision) (flutter/engine#33322)
* 10e0e1534 Revert "[web] Migrate Flutter Web DOM usage to JS static interop - 12. (#33241)" (flutter/engine#33321)
* fix local tests
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
* b2ca1ce53 [web] Migrate Flutter Web to JS static interop - 14. (flutter/engine#32683)
* d3886d6c5 Roll Fuchsia Linux SDK from MbA1RtjV4... to YyokSAVV4... (flutter/engine#32907)
* 0aca7c0a1 Roll Skia from 4f33f5bef8eb to f8e52b27aa70 (4 revisions) (flutter/engine#32911)
* ccf075470 Roll Skia from f8e52b27aa70 to 74742130b08d (2 revisions) (flutter/engine#32913)
* a2d8df99e Roll Skia from 74742130b08d to 82146a7fcde2 (1 revision) (flutter/engine#32914)
* 1e19613db Roll Fuchsia Mac SDK from JVNKiIJWP... to Jki3kG8_P... (flutter/engine#32916)
* 65bc7e348 Roll Dart SDK from 865c2ff0940e to e89b629ed91d (1 revision) (flutter/engine#32917)
* 79152137a Revert "[web] Migrate Flutter Web to JS static interop - 14. (#32683)" (flutter/engine#32919)
* Add impellerc to conductor codesigning list
* Update coductor codesigning for libtessellator.dylib
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
* update console output to specify post release steps
* move post release instructions
* update instructions for beta vs stable
* add logic to differentiate beta and stable steps
