Zachary Anderson
1903ce012e
Revert "[flutter_tools] Disable analytics for more bots ( #50579 )" ( #50622 )
...
This reverts commit 0a38f29c0d
2020-02-11 22:47:41 -08:00
Zachary Anderson
0a38f29c0d
[flutter_tools] Disable analytics for more bots ( #50579 )
2020-02-11 15:48:02 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes ( #50368 )
2020-02-11 20:58:27 +01:00
Zachary Anderson
c23d9cd4ce
[flutter_tools] Print emojis in Windows Terminal ( #50446 )
2020-02-10 10:23:35 -08:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping ( #50322 )
2020-02-07 16:35:55 +01:00
Jonah Williams
82410a5ae7
[flutter_tools] support iOS and macOS with split-debug-info and tree-shake-icons ( #50296 )
2020-02-06 18:39:34 -08:00
Jonah Williams
da4b5d68c4
[flutter_tools] support --split-debug-info option in android builds ( #49650 )
2020-02-05 17:45:24 -08:00
Zachary Anderson
92f7e16312
[flutter_tools] Make OperatingSystemUtils context-free ( #49740 )
2020-01-29 17:51:31 -08:00
Jonah Williams
cb3b7ab487
[flutter_tools] simplify symbol logic for iOS ( #49628 )
2020-01-29 13:43:23 -08:00
Zachary Anderson
68ed5c2baf
[flutter_tool] Hide unsafe std{out,err} operations ( #49561 )
2020-01-28 07:58:02 -08:00
Jonah Williams
3233252cb1
[flutter_tools] only apply --strip to iOS gen_snapshot in release mode ( #49596 )
2020-01-27 19:36:12 -08:00
Jonah Williams
afa24b1a18
[flutter_tools] only strip when bitcode is enabled ( #49595 )
2020-01-27 19:10:27 -08:00
Zachary Anderson
74c1be6ff1
[flutter_tool] Make base/net.dart context free ( #49575 )
2020-01-27 17:53:02 -08:00
Jonah Williams
11621cc798
[flutter_tools] remove dwarf stripping now that linked issue is fixed ( #49563 )
2020-01-27 17:41:55 -08:00
Dan Field
8b2993337a
revert #48985 ( #49572 )
2020-01-27 14:36:02 -08:00
Jonah Williams
347823234f
[flutter_tools] Apply --no-causal-async-stacks and --lazy-async-stacks to profile/release builds ( #49377 )
2020-01-27 10:43:03 -08:00
Jenn Magder
91f7902aad
Move Xcode context fetch to global.dart ( #49458 )
2020-01-25 11:18:02 -08:00
Zachary Anderson
93a5b7d419
[flutter_tool] Don't crash on a failure to write to std{out,err} ( #49380 )
2020-01-25 01:23:01 -08:00
Anthony
b67d5ec6e9
[a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set ( #48985 )
2020-01-17 15:13:01 -08:00
Alexandre Ardhuin
003541499b
use isA<Xxx>() matcher ( #48482 )
2020-01-16 12:43:03 -08:00
Zachary Anderson
29490887e0
Reland: [flutter_tools] File system utilities ( #48757 )
...
* Reland: [flutter_tools] File system utilities
* Remove unused imports
2020-01-14 09:40:39 -08:00
Zachary Anderson
ef62092b9b
Revert "[flutter_tools] File system utilities ( #48738 )" ( #48755 )
...
This reverts commit 0349660622
2020-01-13 14:30:37 -08:00
Zachary Anderson
0349660622
[flutter_tools] File system utilities ( #48738 )
2020-01-13 13:17:45 -08:00
Zachary Anderson
23a3d1014f
[flutter_tool] Make BotDetector context free ( #48605 )
2020-01-13 10:12:06 -08:00
Zachary Anderson
4d096c434f
[flutter_tool] Make CommandHelp context free ( #48584 )
2020-01-10 16:53:01 -08:00
Zachary Anderson
8b139a8c41
[flutter_tool] Use the delegate's toString in the ErrorHandlingFileSystem ( #48597 )
2020-01-10 14:35:49 -08:00
Jonah Williams
749589d896
[flutter_tools] Remove context usage from status and clean up test cases ( #48446 )
2020-01-10 09:36:49 -08:00
Zachary Anderson
23ce192a8f
Reland: Reword flutter run help screen. ( #48423 )
2020-01-09 08:18:03 -08:00
Zachary Anderson
07161e8267
[flutter_tool] Don't use context in ProcessUtils ( #48444 )
2020-01-08 15:20:32 -08:00
Jonah Williams
f7b8d62cbc
[flutter_tool] Refactor Logger and Terminal to (mostly) no longer depend directly on context ( #47269 )
2020-01-08 12:35:12 -08:00
Zachary Anderson
a1bf03f87a
Revert "Esarbanis flutter run help ( #48314 )" ( #48351 )
...
This reverts commit 866fa64dce
2020-01-07 15:06:40 -08:00
Zachary Anderson
866fa64dce
Esarbanis flutter run help ( #48314 )
...
* Reword flutter run help screen.
* As per Hixie request, added Efthymios Sarmpanis to the AUTHORS file
* fix test
Co-authored-by: Efthymis Sarmpanis <e.sarbanis@gmail.com>
2020-01-07 12:10:08 -08:00
Alexandre Ardhuin
4f9b6cf017
enable lint prefer_final_in_for_each ( #47724 )
2020-01-07 16:32:04 +01:00
Jonah Williams
2221a9f514
[flutter_tool] Cache the path context in the flutter tool ( #48250 )
...
recomputing the path context in the getter violates flutter repo style guide and adds a small but measurable overhead to all path operations
2020-01-06 13:57:13 -08:00
Dan Field
ea799d97f4
.. ( #48263 )
2020-01-06 13:30:21 -08:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable ( #47398 )
2020-01-06 11:04:20 -08:00
Dan Field
19c7550540
fix mockStopWatch creation ( #48098 )
2020-01-06 11:03:01 -08:00
Dan Field
5ff7225450
fix io_test ( #48097 )
2020-01-02 19:53:02 -08:00
Jonah Williams
a723c94650
[flutter_tool] restructure ProjectFileInvalidator to no longer directly depend on context ( #45739 )
2019-12-16 18:12:04 -08:00
Zachary Anderson
a72cca137d
[flutter_tool] Print a helpful message on some mDNS failures ( #47157 )
2019-12-16 14:57:29 -08:00
Jonah Williams
23b7853dfd
[flutter_tool] remove ability to disable Fingerprinter with DISABLE_FLUTTER_BUILD_CACHE env variable ( #46913 )
2019-12-12 15:12:53 -08:00
Jonah Williams
8b88c8296f
remove test_api dependency from flutter_tools/base/io ( #46796 )
2019-12-11 13:31:30 -08:00
Zachary Anderson
895ffc80dc
[flutter_tool] Handling of certain unrecoverable filesystem errors ( #46617 )
2019-12-11 12:54:36 -08:00
Jonah Williams
d0526d3f92
[flutter_tool] Prevent accidental calls to io.exit in unit tests ( #46639 )
2019-12-09 18:58:29 -08:00
Jonah Williams
63cc4ad3aa
Revert "[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests ( #46210 )" ( #46630 )
...
This reverts commit b698c9d72e
2019-12-09 13:13:59 -08:00
Jonah Williams
b698c9d72e
[flutter_tool] Prevent accidental calls to io.exit when asserts are active in unit tests ( #46210 )
2019-12-09 13:01:37 -08:00
Jenn Magder
fb69a393b8
Add bitcode and architectures to App.framework build ios framework command ( #46130 )
2019-12-05 12:16:54 -08:00
Ian Hickson
449f4a6673
License update ( #45373 )
...
* Update project.pbxproj files to say Flutter rather than Chromium
Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
* Update the copyright notice checker to require a standard notice on all files
* Update copyrights on Dart files. (This was a mechanical commit.)
* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).
* Clean up the copyrights in non-Dart files. (Manual edits.)
Also, make sure templates don't have copyrights.
* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Jenn Magder
8eb6a925f9
Always compile with isysroot on iOS to point to SDK root ( #45436 ) ( #45560 )
2019-11-25 12:49:18 -08:00
Jenn Magder
4cc10a1fb8
Revert "Always compile with isysroot on iOS to point to SDK root ( #45436 )" ( #45555 )
...
Analyzer warning.
2019-11-25 10:46:42 -08:00
Jenn Magder
6b11f18bc0
Always compile with isysroot on iOS to point to SDK root ( #45436 )
2019-11-25 10:27:22 -08:00
Alexandre Ardhuin
980f14e0c5
implicit-casts:false on flutter_tools ( #45153 )
...
* implicit-casts:false on flutter_tools
* use castStringKeyedMap
* address review comments
* address review comments
* fix issues after rebase
2019-11-24 06:54:43 +01:00
Jonah Williams
785e557a43
remove Flags ( #45320 )
2019-11-21 12:52:52 -08:00
Zachary Anderson
12c190f746
[flutter_tool] Stream artifact downloads to files ( #44360 )
2019-11-07 14:01:57 -08:00
Jonah Williams
7d4a968f0c
make more spinner tests not flaky ( #43955 )
2019-11-01 10:55:15 -07:00
Jonah Williams
417449e2f3
Deflake flutter tool logger test ( #43800 )
2019-10-30 13:09:26 -07:00
Nate Bosch
7cf362fc31
Handle onError callback with optional argument ( #43436 )
...
Check for a binary callback first since a function with an optional
second argument will match both typedefs.
Remove documentation around a synchronous error following some other
error or value - a synchronous error can never follow a value or an
asynchronous error. If there is a synchronous error it will _always_ be
the first thing to happen.
Add a test for a unary error handler and an error handler with an
optional stack trace argument.
2019-10-30 10:39:50 -07:00
Jonah Williams
9cb2047139
Make Spinner test case use mockStopwatch ( #43761 )
2019-10-29 21:36:19 -07:00
Jonah Williams
4c677e4148
Extra defensive programming for pub modification time assert ( #43315 )
2019-10-22 22:05:00 -07:00
Jonah Williams
016ca1a0f1
Catch io.StdinException from failure to set stdin echo/line mode ( #43225 )
2019-10-22 20:35:43 -07:00
Jonah Williams
46ea99122b
Revert "Extra defensive programming for pub modification time assert ( #42491 )" ( #43235 )
...
This reverts commit 3597bae6a0
2019-10-21 20:54:02 -07:00
Ian Hickson
3597bae6a0
Extra defensive programming for pub modification time assert ( #42491 )
2019-10-21 20:15:20 -07:00
Ian Hickson
08643c41d7
Always fake ProcessManager when you fake Filesystem in tests ( #42369 )
...
...because otherwise, processes that think they're manipulating your
filesystem will be doing crazy things the test is ignoring, leading to
(at best) failures and (at worst) flakes or disk corruption.
2019-10-11 11:23:12 -07:00
Alexandre Ardhuin
890b939401
indent formal parameters correctly ( #41644 )
2019-10-04 11:00:18 +02:00
Alexandre Ardhuin
f0553ba58e
Missing trailing commas ( #41473 )
...
* add missing trailing commas
* add more missing trailing commas
* add more and more missing trailing commas
2019-09-30 18:48:23 +02:00
Jonah Williams
c8b3c9b727
use IOOverrides to allow inject file system, write test, find bug ( #40066 )
2019-09-30 08:41:12 -07:00
Zachary Anderson
45f3c8d060
[flutter_tool] Report to analytics when the tool is killed by a signal ( #41493 )
...
* [flutter_tool] Report to analytics when the tool is killed by a signal
* Fix analyzer lint
2019-09-30 07:38:11 -07:00
Alexandre Ardhuin
f11c34109c
fix bad indentations(mainly around collection literals) ( #41355 )
2019-09-27 10:46:45 +02:00
Zachary Anderson
7fa5dd7454
[flutter_tools] Allows adding multiple signal handlers ( #41304 )
2019-09-26 08:12:48 -07:00
Alexandre Ardhuin
b873162194
fix some bad indentations ( #41172 )
2019-09-24 21:03:37 +02:00
Liam Appelbe
b0563e1a3d
Unit test for build.dart::GenSnapshot ( #37642 )
...
* Unit test for build.dart::GenSnapshot
* Fix analysis errors
* Switch to testLogger
2019-09-23 10:09:22 -07:00
Zachary Anderson
e2340c641d
[flutter_tool] Use curly braces around single statment control structures ( #40446 )
2019-09-13 14:51:35 -07:00
Zachary Anderson
73c10e8ced
[flutter_tool] process.dart cleanup ( #39899 )
2019-09-11 18:20:42 -07:00
Zachary Anderson
2c94f2b4d9
[flutter_tool] Kill a timing out process before trying to drain its stdout/err streams ( #40159 )
2019-09-11 08:30:29 -07:00
Zachary Anderson
0f2af976a2
[flutter_tools] Add a timeout to another showBuildSettings command ( #39579 )
2019-09-05 09:50:46 -07:00
Zachary Anderson
b9029c7672
[flutter_tool] Add onError callback to asyncGuard. Use it in Doctor ( #39445 )
2019-09-03 08:14:44 -07:00
Dan Field
eefe9d9527
keep symbols for profile ( #39530 )
2019-08-29 20:54:30 -07:00
Dan Field
cb965495d7
Reland "Relax arguments around local engine, build hello_world with bitcode" ( #39434 )
2019-08-28 15:19:04 -07:00
Emmanuel Garcia
4a1c62c28b
Add missing files in the Gradle wrapper directory ( #39145 )
2019-08-28 14:52:08 -07:00
Jonah Williams
393106fbf5
Revert "Relax requirements around local engine, build hello_world with bitcode ( #39357 )" ( #39431 )
...
This reverts commit 202c1b4224
2019-08-28 13:12:45 -07:00
Dan Field
202c1b4224
Relax requirements around local engine, build hello_world with bitcode ( #39357 )
2019-08-28 10:27:01 -07:00
Zachary Anderson
b7c714e84c
[flutter_tool] Use a timeout for xcode showBuildSettings ( #39280 )
2019-08-28 10:03:53 -07:00
Jonah Williams
6f71ce26d6
Place terminalUi flag on terminal interface ( #39214 )
2019-08-27 14:20:51 -07:00
Zachary Anderson
398ac1f6c8
[flutter_tool] Remove some async file io ( #38654 )
2019-08-20 13:15:08 -07:00
Zachary Anderson
28bedb10da
[flutter_tool] Move http request close under try-catch ( #38894 )
2019-08-20 12:53:59 -07:00
Dan Field
a3221667de
Kill dead code ( #38652 )
2019-08-16 10:10:23 -07:00
Jonah Williams
1df165ea13
Rename iOS arch for macOS release mode (macOS release mode 2 of 3) ( #38645 )
2019-08-15 17:38:35 -07:00
Zachary Anderson
0566971d29
[flutter_tool] Throw tool exit on malformed storage url override ( #38637 )
2019-08-15 14:59:46 -07:00
Alexander Aprelev
f5dcbdab3a
Increase pattern that matches operation duration. ( #36392 )
...
On Flutter HHH buildbot some operations that over a second: 4 digits for milliseconds, rather than 3 that are currently allowed.
2019-08-15 10:16:30 -07:00
Jonah Williams
388d69eb9b
Catch errors thrown into the Zone by json_rpc ( #38486 )
2019-08-14 13:10:41 -07:00
Dan Field
a8fbe02a9d
hide symbols from spotlight ( #37217 )
2019-07-30 14:24:58 -07:00
Dan Field
c953cd19d2
Enable bitcode compilation for AOT ( #36471 )
2019-07-18 22:42:47 -07:00
xster
03220cacd1
Make sure add-to-app build bundle from outer xcodebuild/gradlew sends analytics ( #36122 )
2019-07-17 11:17:04 -07:00
Christopher Fujino
540c747656
Revert "Keep LLDB connection to iOS device alive while running from CLI. ( #36194 )" ( #36293 )
...
This reverts commit 5501a1c1e7
2019-07-16 12:34:49 -07:00
sjindel-google
5501a1c1e7
Keep LLDB connection to iOS device alive while running from CLI. ( #36194 )
...
## Description
Instead of detaching from the spawned App process on the device immediately, keep the LLDB client connection open (in autopilot mode) until the App quits or the server connection is lost.
This replicates the behavior of Xcode, which also keeps a debugger attached to the App after launching it.
## Tests
This change will be covered by all running benchmarks (which are launched via "flutter run"/"flutter drive"), and probably be covered by all tests as well.
I also tested the workflow locally -- including cases where the App or Flutter CLI is terminated first.
## Breaking Change
I don't believe this should introduce any breaking changes. The LLDB client automatically exits when the app dies or the device is disconnected, so there shouldn't even be any user-visible changes to the behavior of the tool (besides the output of "-v").
2019-07-16 19:15:15 +02:00
Zachary Anderson
fa65ddf51d
[flutter_tool] Allow analytics without a terminal attached ( #36208 )
2019-07-16 09:48:49 -07:00
Ian Hickson
d919e694b8
Move tools tests into a general.shard directory in preparation to changing how we shard tools tests ( #36108 )
2019-07-13 11:51:44 -07:00
