Zachary Anderson
45f3c8d060
[flutter_tool] Report to analytics when the tool is killed by a signal ( #41493 )
...
* [flutter_tool] Report to analytics when the tool is killed by a signal
* Fix analyzer lint
2019-09-30 07:38:11 -07:00
Zachary Anderson
7fa5dd7454
[flutter_tools] Allows adding multiple signal handlers ( #41304 )
2019-09-26 08:12:48 -07:00
Jonah Williams
7065e43306
Allow skipping chrome launch with --no-web-browser-launch ( #40627 )
2019-09-25 13:55:54 -07:00
Zachary Anderson
5142238c85
[flutter_tool] Report rss high watermark in command analytics events ( #40988 )
2019-09-25 11:26:06 -07:00
Alexandre Ardhuin
df4bf453ab
more UI-as-code ( #35516 )
2019-09-17 16:23:44 +02:00
Zachary Anderson
e2340c641d
[flutter_tool] Use curly braces around single statment control structures ( #40446 )
2019-09-13 14:51:35 -07:00
Francisco Magdaleno
09bb07f8dd
Adds list required components when VS is not installed ( #40397 )
2019-09-12 18:44:36 -07:00
Zachary Anderson
73c10e8ced
[flutter_tool] process.dart cleanup ( #39899 )
2019-09-11 18:20:42 -07:00
Zachary Anderson
2c94f2b4d9
[flutter_tool] Kill a timing out process before trying to drain its stdout/err streams ( #40159 )
2019-09-11 08:30:29 -07:00
Francisco Magdaleno
362cde43ff
[windows] Searches for pre-release and 'all' Visual Studio installations ( #40011 )
2019-09-10 17:01:53 -07:00
Jenn Magder
12229264e2
Show CocoaPods version in hint text ( #40117 )
2019-09-10 13:26:32 -07:00
Zachary Anderson
0f2af976a2
[flutter_tools] Add a timeout to another showBuildSettings command ( #39579 )
2019-09-05 09:50:46 -07:00
Zachary Anderson
b9029c7672
[flutter_tool] Add onError callback to asyncGuard. Use it in Doctor ( #39445 )
2019-09-03 08:14:44 -07:00
Dan Field
eefe9d9527
keep symbols for profile ( #39530 )
2019-08-29 20:54:30 -07:00
Dan Field
cb965495d7
Reland "Relax arguments around local engine, build hello_world with bitcode" ( #39434 )
2019-08-28 15:19:04 -07:00
Emmanuel Garcia
4a1c62c28b
Add missing files in the Gradle wrapper directory ( #39145 )
2019-08-28 14:52:08 -07:00
Jonah Williams
393106fbf5
Revert "Relax requirements around local engine, build hello_world with bitcode ( #39357 )" ( #39431 )
...
This reverts commit 202c1b4224
2019-08-28 13:12:45 -07:00
Dan Field
202c1b4224
Relax requirements around local engine, build hello_world with bitcode ( #39357 )
2019-08-28 10:27:01 -07:00
Zachary Anderson
b7c714e84c
[flutter_tool] Use a timeout for xcode showBuildSettings ( #39280 )
2019-08-28 10:03:53 -07:00
Jonah Williams
6f71ce26d6
Place terminalUi flag on terminal interface ( #39214 )
2019-08-27 14:20:51 -07:00
Christopher Fujino
d1e0273ecb
refactor cocoapods validator to detect broken install ( #38560 )
2019-08-23 09:21:09 -07:00
Jonah Williams
b2d19d2af5
Add support for macOS release/profile mode (3 of 3) ( #38909 )
2019-08-23 08:46:24 -07:00
Zachary Anderson
398ac1f6c8
[flutter_tool] Remove some async file io ( #38654 )
2019-08-20 13:15:08 -07:00
Zachary Anderson
28bedb10da
[flutter_tool] Move http request close under try-catch ( #38894 )
2019-08-20 12:53:59 -07:00
Todd Volkert
c22ce95e15
Change from using defaults to plutil for Plist parsing ( #38662 )
...
We were using the `defaults` command-line utility to parse
Plist files, but it was never supported by Apple, and it
appears that in an upcoming OS release, it will be less likely
to work:
> WARNING: The defaults command will be changed in an upcoming
> major release to only operate on preferences domains. General
> plist manipulation utilities will be folded into a different
> command-line program.
Fixes https://github.com/flutter/flutter/issues/37701
2019-08-16 17:10:07 -07:00
Dan Field
a3221667de
Kill dead code ( #38652 )
2019-08-16 10:10:23 -07:00
Jonah Williams
1df165ea13
Rename iOS arch for macOS release mode (macOS release mode 2 of 3) ( #38645 )
2019-08-15 17:38:35 -07:00
Zachary Anderson
0566971d29
[flutter_tool] Throw tool exit on malformed storage url override ( #38637 )
2019-08-15 14:59:46 -07:00
Jonah Williams
388d69eb9b
Catch errors thrown into the Zone by json_rpc ( #38486 )
2019-08-14 13:10:41 -07:00
Liam Appelbe
0cf4033404
Switch iOS gen_snapshot from multi-arch binary to multiple binaries ( #37445 )
...
* Switch iOS gen_snapshot from multi-arch binary to multiple binaries
* Make snapshotterPath mutable
2019-08-02 07:43:07 -07:00
Chinmay Garde
9ea78d4488
Revert "Remove multi-arch check in iOS builds ( #37407 )" ( #37413 )
...
This reverts commit 5809219509
2019-08-01 11:43:32 -07:00
Liam Appelbe
5809219509
Remove multi-arch check in iOS builds ( #37407 )
...
* Remove multi-arch check in iOS builds
* Manual roll of https://github.com/flutter/engine/pull/10010
2019-08-01 11:16:21 -07:00
Zachary Anderson
2e183b6233
[flutter_tool] Include the local timezone in analytics timestamp ( #37345 )
2019-07-31 23:28:18 -07:00
Dan Field
a8fbe02a9d
hide symbols from spotlight ( #37217 )
2019-07-30 14:24:58 -07:00
Zachary Anderson
a5d23d2a25
[flutter_tool] More gracefully handle Android sdkmanager failure ( #37194 )
2019-07-30 08:19:58 -07:00
Zachary Anderson
ef146f63bb
[flutter_tool] Clean up usage events and custom dimensions ( #36785 )
2019-07-29 07:24:02 -07:00
Ian Hickson
e8d7306828
Some minor cleanup for flutter_tools ( #36569 )
2019-07-24 10:58:09 -07:00
Dan Field
c953cd19d2
Enable bitcode compilation for AOT ( #36471 )
2019-07-18 22:42:47 -07:00
Todd Volkert
adb2aeebe3
Ensure that cache dirs and files have appropriate permissions ( #28090 )
...
This is a partial re-application of #24669 , which was
reverted due to Fuchsia breakages.
https://github.com/flutter/flutter/issues/24413
2019-07-18 15:29:06 -07:00
xster
03220cacd1
Make sure add-to-app build bundle from outer xcodebuild/gradlew sends analytics ( #36122 )
2019-07-17 11:17:04 -07:00
Jonah Williams
36c37ccab5
Implement feature flag system for flutter tools ( #36138 )
2019-07-16 17:33:28 -07:00
Todd Volkert
aa9a115181
Move reporting files to reporting/ ( #36017 )
...
Slight cleanup of file locations in flutter_tools
to make it easier to see which files are responsible
for data reporting.
2019-07-16 13:21:06 -07:00
Christopher Fujino
540c747656
Revert "Keep LLDB connection to iOS device alive while running from CLI. ( #36194 )" ( #36293 )
...
This reverts commit 5501a1c1e7
2019-07-16 12:34:49 -07:00
sjindel-google
5501a1c1e7
Keep LLDB connection to iOS device alive while running from CLI. ( #36194 )
...
## Description
Instead of detaching from the spawned App process on the device immediately, keep the LLDB client connection open (in autopilot mode) until the App quits or the server connection is lost.
This replicates the behavior of Xcode, which also keeps a debugger attached to the App after launching it.
## Tests
This change will be covered by all running benchmarks (which are launched via "flutter run"/"flutter drive"), and probably be covered by all tests as well.
I also tested the workflow locally -- including cases where the App or Flutter CLI is terminated first.
## Breaking Change
I don't believe this should introduce any breaking changes. The LLDB client automatically exits when the app dies or the device is disconnected, so there shouldn't even be any user-visible changes to the behavior of the tool (besides the output of "-v").
2019-07-16 19:15:15 +02:00
Zachary Anderson
fa65ddf51d
[flutter_tool] Allow analytics without a terminal attached ( #36208 )
2019-07-16 09:48:49 -07:00
Christopher Fujino
102ab1e6d9
Reland bundle ios deps ( #36093 )
...
This updates the flutter tool cache to download binary files for ideviceinstaller, ios-deploy, libimobiledevice, and dynamically linked dependencies from Flutter's GCP bucket.
2019-07-15 09:22:29 -07:00
Christopher Fujino
e91822da24
Revert "Bundle ios dependencies ( #34669 )" ( #36071 )
...
This reverts commit 14d489adc5
2019-07-12 09:03:34 -07:00
Christopher Fujino
14d489adc5
Bundle ios dependencies ( #34669 )
...
This updates the flutter tool to cache binary files for ideviceinstaller, ios-deploy, libimobiledevice, and dynamically linked dependencies from Flutter's GCP bucket.
2019-07-12 08:36:18 -07:00
Jonah Williams
e91b98a41f
Add initial implementation of flutter assemble ( #32816 )
2019-07-11 16:53:17 -07:00
Jonah Williams
34467289d6
Add timer checking and Fake http client to testbed ( #35392 )
2019-07-08 10:04:48 -07:00
Alexandre Ardhuin
758009ba70
more ui-as-code ( #35393 )
...
* more ui-as-code
* address review comments
2019-07-02 21:11:56 +02:00
Alexandre Ardhuin
919dcf53f3
enable lints prefer_spread_collections and prefer_inlined_adds ( #35189 )
2019-06-27 21:23:16 +02:00
Alexandre Ardhuin
fecf99ff1e
enable lint avoid_bool_literals_in_conditional_expressions ( #35055 )
2019-06-25 17:40:05 +02:00
Todd Volkert
bb6c3f8131
Remove flutter_tools support for old AOT snapshotting ( #34895 )
...
Android now exclusively uses ELF shared libraries, and
iOS uses assembly.
2019-06-22 19:30:24 -07:00
Jonah Williams
d7e53d4816
move hack flag to common ( #34754 )
2019-06-19 16:29:11 -07:00
Jonah Williams
a772d4d314
retry on HttpException ( #34526 )
2019-06-17 10:48:01 -07:00
Michael Thomsen
264de26572
Change API doc link to api.dart.dev ( #34388 )
2019-06-14 14:19:36 +02:00
Todd Volkert
8163c0aebb
Re-apply compressionState changes. ( #34341 )
...
This re-applies the changes that were made in #33697 and #33729 ,
but which were reverted in #33792 and #33790 , respectively due to
the Dart SDK not having received the update within Google yet.
The SDK has now rolled, so these changes can be re-applied.
https://github.com/flutter/flutter/issues/32374
https://github.com/flutter/flutter/issues/33791
2019-06-12 13:47:47 -07:00
Jason Simmons
89d887f331
Strip debug symbols from ELF library snapshots ( #34250 )
...
AOT compiled code is now packaged as an ELF library for Android targets.
By default gen_snapshot's output contains debug symbols. The symbols could
be stripped as a separate step, but that requires NDK tools that the user
may not have available.
This change passes a gen_snapshot flag that omits the symbols, and it filters
out a warning printed when that flag is used.
2019-06-11 13:34:24 -07:00
Todd Volkert
1b3fc53595
Consider all non-interactive terminals to be bots ( #34179 )
2019-06-10 16:32:08 -07:00
Emmanuel Garcia
8627ff433b
Allow multi-abi shared libraries in APKs and App bundles ( #34123 )
...
* Gradle generates ELF shared libraries instead of AOT snapshots.
* `flutter build apk/appbundle` supports multiple `--target-platform` and defaults to `android-arm` and `android-arm64`.
* `flutter build apk` now has a flag called `--split-per-abi`.
2019-06-10 13:16:09 -07:00
Jonah Williams
f8f7b89976
Revert "Generate ELF shared libraries and allow multi-abi libs in APKs and App bundles ( #33696 )" ( #34121 )
2019-06-08 18:43:25 -07:00
Emmanuel Garcia
966b15b4a4
Generate ELF shared libraries and allow multi-abi libs in APKs and App bundles ( #33696 )
...
* Gradle generates ELF shared libraries instead of AOT snapshots.
* `flutter build apk/appbundle` supports multiple `--target-platform` and defaults to `android-arm` and `android-arm64`.
* `flutter build apk` now has a flag called `--split-per-abi`.
2019-06-08 18:02:32 -07:00
Zachary Anderson
b847ba5a63
[flutter_tool] Send build timing to analytics ( #34049 )
2019-06-07 13:50:45 -07:00
stuartmorgan
fb8df82c06
Add 'doctor' support for Windows ( #33872 )
...
Moves the logic for finding vcvars64.bat to a new VisualStudio class
that encapsulates finding, and providing information about, VisualStudio
installations. Adds a validator for it, and runs it for Windows
workflows in doctor.
2019-06-06 14:02:27 -07:00
Alexander Aprelev
30dbc4c767
Whitelist adb.exe heap corruption exit code. ( #33951 )
...
* Whitelist adb.exe heap corruption exit code.
In android platform tools 29.0.0 adb.exe shell seems to be exiting with heap corruption exit code, otherwise producing results as expected. This PR whitelists this exit code on Windows.
Fixes https://github.com/flutter/flutter/issues/33938 .
* Fix condition
* Fix 'shell am start' command
* Fix stop command
* Refactor into runAdbMostlyChecked(Sync/Async)
* runAdbMostlyChecked -> runAdbChecked
2019-06-06 12:01:03 -07:00
Zachary Anderson
5180201fe1
[flutter_tool] Track APK sha calculation time ( #33923 )
2019-06-05 15:28:19 -07:00
Todd Volkert
52fc807dd2
Remove references to HttpClientResponseCompressionState ( #33792 )
...
https://github.com/flutter/flutter/issues/33791
2019-06-03 14:53:43 -07:00
Chris Bracken
2467c528f5
Roll engine 69ebe5fb28fc..a4b7d1c2895d (3 commits) ( #33697 )
...
69ebe5fb28..68a3ca46b4#9158 )
68a3ca46b Roll src/third_party/dart 445a23a9bc..0e6b74543c (29 commits) (#9159 )
1d1cff1fa Roll src/third_party/skia 3cd435eecf5e..09f5aedf2cc8 (3 commits) (#9160 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-05-31 21:17:43 -07:00
Jason Simmons
e810512b32
Use Dart's new direct ELF generator to package AOT blobs as shared libraries in Android APKs ( #33611 )
...
This is a replacement for the old implementation of --build-shared-library
that emits an AOT assembly snapshot and feeds it to the Android NDK toolchain.
2019-05-30 16:07:22 -07:00
Jason Simmons
311cde98a6
Reland "Clean up some flutter_tools tests and roll dependencies" ( #33225 )
...
This relands flutter/flutter#33163 with a fix to the integration_ui test.
2019-05-29 19:04:35 -07:00
stuartmorgan
81c38b22cb
Implement macOS support in flutter doctor ( #33277 )
...
Splits Xcode validation out of the iOS validator and into a stand-alone
validator, and groups the CocoaPods validator with that top-level
validator instead of the iOS validator. iOS now validates only the
iOS-specific tools (e.g., ideviceinstaller).
Reorganizes many of the associated clases so that those that are used by
both macOS and iOS live in macos/ rather than ios/. Moves some
validators to their own files as part of the restructuring.
This is the macOS portion of #31368
2019-05-24 22:51:02 -04:00
Chris Bracken
156b4220b4
Americanise spellings ( #33323 )
...
Updates documentation and non-public API to use American spellings for
consistency with the rest of the codebase.
No changes to behaviour... other than how it's spelt.
2019-05-24 19:13:02 -07:00
Chris Bracken
4d9923201b
Correct typos ( #33322 )
...
Corects a bnuch of typeos throuhgout teh Fluter codebsae.
Made use of the `misspell` tool:
https://github.com/client9/misspell
2019-05-24 19:12:45 -07:00
Jonah Williams
a30ffb60ad
Revert "Clean up some flutter_tools tests and roll dependencies ( #33163 )" ( #33206 )
2019-05-22 12:20:02 -07:00
Ian Hickson
e5f81e1048
Clean up some flutter_tools tests and roll dependencies ( #33163 )
...
* Clean up some flutter_tools tests
* Remove arbitrary retry that happens even for fundamental errors, and generally clean up _DevFSHttpWriter.
* Update dependencies (requires fixes; see next commit)
* Fixes for new dependencies.
2019-05-22 09:31:37 -07:00
Zachary Anderson
94ce956f0a
[flutter_tool] Adds support for 'run' for Fuchsia devices ( #32849 )
2019-05-21 08:49:43 -07:00
Devon Carew
50a9c31f5e
reduce retry attempts for flutter creatte --list-samples ( #32833 )
2019-05-16 18:20:30 -07:00
Alexandre Ardhuin
4fa32df141
use null aware operators ( #32711 )
...
* use null aware operators
* rollback changes about null-aware operator
* disable lint prefer_is_not_empty
2019-05-16 22:25:51 +02:00
Kate Lovett
054d9bb2f1
Updating dart.dev related links ( #32641 )
...
* Updating dart.dev related links
* Update packages/flutter_tools/lib/src/base/context.dart
2019-05-14 10:35:00 -07:00
Jonas Termansen
8b9eb3e2b2
Report CompileTime metric in flutter build aot --report-timings. ( #31895 )
...
This is the correct metric to report for compilation time benchmarks rather
than RunTime. Rename the 'gen_snapshot' value to merely 'snapshot' for
backwards compatibility and overall simplicity.
This change simplifies Dart's benchmarking of Flutter by making it easier to
adopt --report-timings (made for Dart to use), which makes the benchmarks
much more robust.
2019-05-02 15:22:43 +02:00
Jonah Williams
4ff467191b
make FlutterProject synchronous ( #31757 )
2019-04-29 08:21:32 -07:00
Jonah Williams
0acd3e6b04
refactor context to be implicit-downcast safe ( #31622 )
2019-04-25 15:51:08 -07:00
Jonah Williams
661e0350fb
Disable all Dart fingerprinters ( #31463 )
2019-04-23 11:58:37 -07:00
Stanislav Baranov
e2a3c2ee45
Remove support for building dynamic patches on Android. ( #31359 )
2019-04-22 10:40:50 -07:00
Jonah Williams
3c8c630f01
Allow disabling all fingerprint caches via environment variable ( #31171 )
2019-04-17 17:27:50 -07:00
Alexander Aprelev
d775908c7e
Download and handle product version of flutter patched sdk ( #31063 )
...
* Support release/debug flavors of flutter_patched_sdk
* Use [anyNamed] instead of [any] for mocking named arguments
* Fix use of local engine in release mode
2019-04-15 21:02:20 -07:00
Jonah Williams
301eaa8c32
Make coverage, like, really fast ( #30811 )
2019-04-15 08:59:28 -07:00
Tim Sneath
529189791c
Replace flutter.io with flutter.dev ( #30562 )
2019-04-05 11:39:30 -07:00
Wai Hon Law
e8d968ed8d
Update repair command for Arch Linux ( #30428 )
...
The current repair command for Arch Linux is no longer valid because
`lib32-libstdc++5` had been removed from multilib.
Actually, `lib32-gcc-libs` from core just work.
Also see https://github.com/flutter/flutter/issues/25035
2019-04-05 07:55:29 -07:00
Vyacheslav Egorov
01e3496ad9
Introduce --report-timings flag for flutter build aot command. ( #30032 )
...
This flag makes flutter build aot report timings for substeps (e.g.
frontend compilation and gen_snapshot) in a machine readable form.
2019-04-03 12:12:18 +02:00
Christopher Fujino
ec93c87c89
Move spinner _defaultSlowWarning message to a new line ( #30071 )
...
* write newline before adding slow restart message to spinner
* update existing test
2019-03-28 10:08:44 -07:00
Jonah Williams
99866f4a3d
Make timeout durations configurable ( #30053 )
2019-03-27 16:21:16 -07:00
Jonah Williams
7d678f2adc
Lazy cache 5: The Empire Strikes Back ( #29986 )
2019-03-27 13:54:09 -07:00
Jonah Williams
164dae3bf1
Revert "Lazy cache 4 ( #29785 )" ( #29985 )
2019-03-26 10:01:22 -07:00
Jonah Williams
d71f324e48
Lazy cache 4 ( #29785 )
2019-03-26 08:45:29 -07:00
Jonah Williams
469a859c72
Enable code generation features in tool ( #29399 )
2019-03-21 13:12:10 -07:00
Jonah Williams
c72f18fcd5
Add builders and engine hash to fingerprint ( #29434 )
2019-03-20 15:40:37 -07:00
Alexandre Ardhuin
a6af422874
some spaces formatting ( #29452 )
...
* some space formattings
* always use blocks in if-else if a block is used
* format spaces in for and while
* allow multiline if conditions
* fix missing space
2019-03-20 23:23:31 +01:00
Christian Wenz
428d104054
Properly escape Android SDK Manager path in error message ( #29134 )
2019-03-15 08:58:33 -07:00
