Commit Graph

371 Commits

Author SHA1 Message Date
Adam Barth
e2744e9a30 Stop using a prebuilt APK
Instead, require an AndroidManifest.xml and always build an APK.

Fixes #2517
2016-03-14 13:32:00 -07:00
Ian Hickson
bedd8e9131 Merge pull request #2650 from Hixie/always_always_specify_types
Even more types
2016-03-14 10:44:05 -07:00
Devon Carew
5fb315141b Merge pull request #2658 from devoncarew/drive_command
change the description of the drive command
2016-03-14 10:27:01 -07:00
Devon Carew
d0afabc358 change the description of the drive command 2016-03-14 09:48:02 -07:00
Ian Hickson
d745e20853 Even more types 2016-03-14 09:41:54 -07:00
Devon Carew
4daee0cc0d misc tool ui cleanup 2016-03-14 09:41:00 -07:00
Devon Carew
f13314867c Merge pull request #2645 from devoncarew/platform_constants
rename the platform constants
2016-03-12 12:46:55 -08:00
Adam Barth
95fc5ae070 [rename fixit] *Component* -> *Widget*
This patch renames StatelessComponent to StatelessWidget and
StatefulComponent to StatefulWidget.

Fixes #2308
2016-03-12 12:34:05 -08:00
Devon Carew
e939b152af rename the platform constants 2016-03-12 11:08:21 -08:00
Hixie
6795efacab Enable always_specify_types lint
And fix the zillion issues that uncovered.
2016-03-12 00:37:31 -08:00
Ian Hickson
43b0104114 Revert "Merge pull request #2639 from Hixie/always_specify_types"
This reverts commit f41b3411da, reversing
changes made to e33d8d9621.

This was a bad check-in due to my mangling uploading a new version of the branch from a different machine.

This reverts https://github.com/flutter/flutter/pull/2639 and will be replaced by https://github.com/flutter/flutter/pull/2640
2016-03-12 00:34:37 -08:00
Hixie
d162d98c79 Enable always_specify_types lint
And fix the zillion issues that uncovered.
2016-03-11 18:27:32 -08:00
Devon Carew
29df9f5582 show the error code in flutter analyze --watch 2016-03-11 15:59:20 -08:00
pq
0aa07baf70 Migrate flutter analyze config to options.
More groundwork to get `analyze` and IDE output to agree.

See: https://github.com/dart-lang/sdk/issues/25723
2016-03-11 14:52:07 -08:00
Phil Quitslund
b9f28e6f75 Merge pull request #2615 from pq/analyze_cleanup
Analyze command cleanup.
2016-03-11 14:25:24 -08:00
Jason Simmons
68e71146a7 Run "pub get" if needed in the flutter build command 2016-03-11 14:10:42 -08:00
pq
a2dac85f87 Re-added conflictingNamesPattern. 2016-03-11 13:12:07 -08:00
Devon Carew
5ad6a57007 remove some references to DeviceStore 2016-03-11 11:25:03 -08:00
Devon Carew
94157c91e9 regenerate the i18n files 2016-03-11 10:58:30 -08:00
pq
aedef5139b Analyze command cleanup.
Removing some special-casing in pursuit of aligning `flutter analyze` output with that provided by server/IDEs.  Specifically:
  * strong-hints (stale, no longer supported)
  * "analyzer says" comment handling in favor of `//ignore`s
  * `conflictingNamePattern` --- no longer needed

Next up some of the error filter regexps...
2016-03-11 10:35:17 -08:00
Ian Hickson
1b9cd52081 Enable ALL THE LINTS
Well, all the easy ones, anyway.

For some reason `// ignore:` isn't working for me so I've disabled
lints that need that. Also disabled those that require a ton of work
(which I'm doing, but not in this PR, to keep it reviewable).

This adds:
- avoid_init_to_null
- library_names
- package_api_docs
- package_names
- package_prefixed_library_names
- prefer_is_not_empty
- sort_constructors_first
- sort_unnamed_constructors_first
- unnecessary_getters_setters
2016-03-10 23:15:31 -08:00
Devon Carew
b9fafc1765 adjust a regex for intl files 2016-03-10 14:21:23 -08:00
Devon Carew
780e4e6212 move the analysis_options to a file 2016-03-10 13:47:20 -08:00
Jason Simmons
3b5fba4022 Merge pull request #2578 from jason-simmons/flx_working_dir
Add an option to specify a working directory for the FLX builder
2016-03-10 12:43:35 -08:00
Eric Seidel
3e2a4d9b4d flutter run should fail if pub get fails.
Previously we were ignoring the return code and continuing.

@devoncarew
2016-03-10 09:36:09 -08:00
Hixie
c7339de6bc Enable always_declare_return_types lint
And fix a zillion omissions this uncovered.
2016-03-09 17:57:39 -08:00
Hixie
8950d3ccc4 Make flutter analyze useful for package conflicts
Also, resolve our package conflict, since reflectable has been fixed.
2016-03-09 17:41:05 -08:00
Hixie
5810cd80bd Avoid 'as' keyword
It has performance implications in release mode.

We'll enable the lint once https://github.com/dart-lang/linter/issues/195 is fixed.
2016-03-09 15:00:55 -08:00
Jason Simmons
5108a6cc58 Add an option to specify a working directory for the FLX builder
This allows building an FLX without leaving any temporary files in the app's
source directory
2016-03-09 14:59:40 -08:00
Alhaad Gokhale
5faf84c3fa Merge pull request #2528 from alhaad/depsfile_hook
Add `flutter_tools build` hooks to also generate depfile.
2016-03-09 12:29:31 -08:00
Alhaad Gokhale
b8d64ffe68 Add flutter_tools build hooks to also generate depfile.
Fixes #1942.
2016-03-09 11:24:47 -08:00
Devon Carew
2e9fef8c46 fix a regression in flutter logs 2016-03-09 10:48:34 -08:00
Adam Barth
e4b1eab854 Remove //examples/widgets
Most of the remaining widget examples are actually manual tests. This patch
moves them into //dev/manual_tests. A couple are examples of using services,
which I've moved to //examples/layers/services. The remainder are out-dated and
are removed by this patch.
2016-03-08 16:37:32 -08:00
John McCutchan
8803cecea1 Refactor DeviceLogReader 2016-03-08 10:38:22 -08:00
Devon Carew
52efc7fb68 implement --watch for flutter analyze 2016-03-07 13:46:42 -08:00
Devon Carew
b52fa986b6 fix rebase 2016-03-07 10:36:04 -08:00
Steve Messick
8cc5312054 Merge remote-tracking branch 'upstream/master' 2016-03-07 05:17:13 -08:00
Devon Carew
93b31a41df fix flutter create 2016-03-04 18:56:26 -08:00
Steve Messick
cea21fb7b1 Merge remote-tracking branch 'upstream/master' 2016-03-04 14:38:55 -08:00
Steve Messick
2e878746a3 Improve message when target not found 2016-03-04 14:36:32 -08:00
Devon Carew
c1caa26989 fix a mac test 2016-03-04 13:10:51 -08:00
Ian Hickson
047276a666 Random fixes to dartdocs, http lib, analyzer
This is a variety of trivial fixes that I collected while going through the dartdocs.
This does contain some non-comment changes.
2016-03-03 23:56:40 -08:00
Devon Carew
8283ce87e2 fix the stop command tests 2016-03-03 13:58:49 -08:00
Adam Barth
932b09c33a Merge pull request #2048 from abarth/test2
Switch from hack_load_vm_file_hook to PlatformPlugin
2016-03-03 12:11:53 -08:00
Adam Barth
96ec5316b8 Switch from hack_load_vm_file_hook to PlatformPlugin
This patch switches us from using our previous hacking approach to integrating
with package:test to using the new PlatformPlugin interface.
2016-03-03 11:23:36 -08:00
Devon Carew
d911aaa6d0 refactot the stop command to not use DeviceStore 2016-03-03 00:22:40 -08:00
Devon Carew
d9d94b1691 Merge pull request #2328 from devoncarew/no_dashes
clean the project names used for flutter create
2016-03-02 12:36:56 -08:00
Devon Carew
4c569195f1 clean the project names used for flutter create 2016-03-02 12:36:37 -08:00
Adam Barth
870894fc68 Switch Material Design icons to using the iconfont
Rather than managing all the Material Design icons manually, we now
manage them using an icon font. The icon font contains glyphs for each
icon in an efficient vector format.

This patch updates the FLX tooling to include the MaterialIcons font and
updates the Icon widget to use the font instead of asset images.

Fixes #2313
Fixes #2218
Fixes #2009
Fixes #994
2016-03-02 09:32:02 -08:00
Devon Carew
ebf1ecc5bd valdate project names in create 2016-03-01 11:03:59 -08:00
Yegor Jbanov
6d35481cfa add smoke driver test; find by tooltip; retry predicate 2016-02-29 16:50:47 -08:00
Devon Carew
4d93c376c9 improve verbose output 2016-02-27 23:36:02 -08:00
Devon Carew
f9adbcf23d update a todo 2016-02-27 19:56:20 -08:00
Devon Carew
d326991b97 add back a call to device.stop() from the run command 2016-02-27 19:32:02 -08:00
Devon Carew
4e10bf596c improve startup time 2016-02-27 08:19:19 -08:00
Hixie
ba918fea26 flutter analyze: handle missing files 2016-02-26 18:59:07 -08:00
Hixie
a9040433ad Handle lines getting shorter during analysis 2016-02-26 15:37:43 -08:00
Devon Carew
022047f5eb remove the isConnected() method from device 2016-02-26 13:23:48 -08:00
Devon Carew
240e499bc0 Merge pull request #2219 from devoncarew/speed_up_start
some performance optimizations for starting apps
2016-02-26 12:21:42 -08:00
Devon Carew
8c95500ea1 some performance optimizations for starting apps 2016-02-26 12:01:41 -08:00
Ian Hickson
c04b4c7580 Merge pull request #2206 from Hixie/analyzer-messages
Handle conflicting 'library' identifiers
2016-02-26 11:06:51 -08:00
Adam Barth
44ffb6f453 Merge pull request #2196 from abarth/update_packages
Move update_packages.dart to `flutter update-packages`
2016-02-26 11:03:48 -08:00
Hixie
a33e256ab8 Handle conflicting 'library' identifiers
Also, handle the new directory structure of the flutter repo.
2016-02-26 10:58:39 -08:00
Devon Carew
58f69e7f97 Merge pull request #2211 from devoncarew/flx_times
add timing info for flx creation
2016-02-26 10:44:45 -08:00
Yegor Jbanov
677e63b79d decouple flutter drive from flutter start
flutter start's method of finding devices to run the app on is not suitable for flutter drive.

This commit also refactors several tool services to allow mocking in unit tests.
2016-02-26 10:18:24 -08:00
Devon Carew
ee8f325bc0 add timing info for flx creation 2016-02-26 10:03:42 -08:00
Adam Barth
357fbf8a42 Move update_packages.dart to flutter update-packages
Now that we don't require the Dart SDK to be in your path, it's hard to run
./dev/update_packages.dart. Instead, you can now run `flutter update-packages`.

Fixes #1906
2016-02-25 16:27:56 -08:00
pq
fdb2819e1e Ignore errors via analysis options.
Migrates error suppression from regexps to analysis options.
* Ignore TODOs.
* Ignore strong mode field and method overrides (see `InvalidFieldOverride` and `InvalidMethodOverride` in `strong/info.dart`.
* Remove stale regexp to capture refs to dead `dart:ui_internals` URI.
* Remove stale regexp to capture dead strong mode "will need runtime check to cast to type" error (https://github.com/dart-lang/sdk/issues/24542).

5 regexp downs, another small handful (~4) to go! :)
2016-02-25 13:49:05 -08:00
Devon Carew
4860e63f44 Merge pull request #2153 from devoncarew/add_android_icon
add an android icon to the starter app
2016-02-25 00:40:49 -08:00
Devon Carew
5ee1cba149 fix a regression in the android manifest 2016-02-24 23:40:00 -08:00
Devon Carew
f57afa762f add an android icon to the starter app 2016-02-24 23:12:33 -08:00
Devon Carew
bc8e560779 run flutter doctor as part of create 2016-02-24 19:07:19 -08:00
Devon Carew
dc4830b0fa Merge pull request #2123 from devoncarew/device_commands
additional validation for device commands
2016-02-24 12:54:28 -08:00
Chinmay Garde
21057de9ae Merge pull request #2118 from chinmaygarde/develop
Remove all inline templates and provide a way to specify templates as resources
2016-02-24 12:47:37 -08:00
Chinmay Garde
038367ad24 Remove all inline templates and provide a way to specify templates as resources 2016-02-24 11:33:07 -08:00
Devon Carew
37290d866e additional validation for device commands 2016-02-24 11:11:23 -08:00
Phil Quitslund
1062c44f4a Merge pull request #2094 from flutter/analyze_fixes
Enumerate lints for analysis in synthesized options file.
2016-02-23 16:36:09 -08:00
pq
b69d249460 Enumerate lints for analysis in synthesized options file.
This enables us to exclude `library_names` pending a new stable SDK push (see notes: https://github.com/flutter/flutter/pull/1996).  Also excluded are a few lints who's feedback was just getting regexp'ed out.  Moving forward, this will allow us to selectively enable specific lints of interest as well.
2016-02-23 15:07:55 -08:00
Collin Jackson
8ab9a8fe03 Remove redundant Material from project created by flutter create 2016-02-23 11:29:55 -08:00
Yegor
3301ae7d09 Merge pull request #2097 from yjbanov/flutter-driver-create
"flutter create" can generate a basic driver test; "flutter drive" gains new options
2016-02-22 17:18:54 -08:00
yjbanov
278630e688 "flutter create" can generate a basic driver test
"flutter create" adds option `--with-driver-test` that adds
dependencies to `flutter_driver` in `pubspec.yaml` and creates
a basic driver test runnable via `flutter drive
--target=test_driver/e2e.dart`

"flutter drive" new options:

- `--keep-app-running` tells the driver to not stop the app after tests
  are done
- `--use-existing-app` tells the driver to not start a new app but use
  an already running instance
2016-02-22 17:10:31 -08:00
Devon Carew
3463d89cf6 remove iosSimulator field from ApplicationPackageStore 2016-02-22 12:37:08 -08:00
Devon Carew
896246ad14 Merge pull request #2079 from devoncarew/more_specific_logging
log for specific adb devices
2016-02-22 12:12:05 -08:00
Chinmay Garde
d299b05ab3 Fix linter error regarding extra braces in string interpolation in devices.dart 2016-02-22 11:51:35 -08:00
Chinmay Garde
f7d94fef8f Update status messages when unsupported devices are detected by the tools 2016-02-22 11:33:17 -08:00
Devon Carew
488e5dcd6c log for specific adb devices 2016-02-21 00:23:13 -08:00
Devon Carew
67046f933d add the ability to start and stop device polling 2016-02-20 22:00:11 -08:00
Adam Barth
ec0ec75b26 Improve the style in the starter app
Fixes #2011
2016-02-20 15:48:55 -08:00
Adam Barth
4aae718f85 Download sky_engine and sky_services from cloud storage
Downloading these packages from cloud storage simplifies our deployment
story because we can upload to cloud storage automatically from the
buildbot.

This patch also switches the responsibility for downloading the engine
artifacts to update_engine.sh. Centralizing this responsibility ensures
that the packages and the binaries are always in sync.
2016-02-20 13:25:01 -08:00
Yegor
38a72a444a Merge pull request #2054 from yjbanov/flutter-drive-cmd
"flutter drive" command
2016-02-19 18:17:52 -08:00
yjbanov
a2b1bd4673 "flutter drive" command
Runs a test app and a driver test simultaneously, then stops the app.

Usage:

```
flutter drive --target=/path/to/test/app.dart
```

This command will look for `/path/to/test/app_test.dart` by
convention. We will expand into other ways of discovering tests in the
future.
2016-02-19 18:11:53 -08:00
Chinmay Garde
d797995632 tvOS, watchOS and old simulators are blacklisted in the tools 2016-02-19 16:29:41 -08:00
Chinmay Garde
5658640128 Fix lint errors 2016-02-19 13:34:16 -08:00
Chinmay Garde
f6a2477dce Always generate legal UTIs for project identifiers. 2016-02-19 12:30:18 -08:00
Devon Carew
0da7463ef0 make the '-o' option in create optional 2016-02-18 14:33:59 -08:00
Devon Carew
d5a6fceee5 add a summary option to the doctor class 2016-02-17 09:33:45 -08:00
Devon Carew
6a6b6539c8 Merge pull request #1947 from devoncarew/less_ios
make the ios development path less mandatory
2016-02-17 00:48:00 -08:00
Devon Carew
7ae6f7f391 make the ios development path less mandatory 2016-02-17 00:38:47 -08:00
Adam Barth
db7294206a Merge pull request #1940 from abarth/improve_android_sdk
Improve error message when Android SDK not found
2016-02-16 17:11:14 -08:00
Adam Barth
bef8d081ed Improve error message when Android SDK not found
Also, look for the Android SDK in the default locations.
2016-02-16 17:02:52 -08:00