Commit Graph

7181 Commits

Author SHA1 Message Date
Ian Hickson
7b01346c5c
Enable no_default_cases lint (#91530) 2021-10-11 10:23:04 -07:00
Ian Hickson
b3f63d38ac
Document why some lints aren't enabled and fix some minor issues. (#91527) 2021-10-09 04:03:03 -07:00
Zachary Anderson
8b245d081f
[flutter_tools] Fix redundant argument value lint (#91534) 2021-10-08 22:59:29 -07:00
Jenn Magder
8930e9b892
Catch FormatException parsing XCDevice._getAllDevices (#90967) 2021-10-08 13:08:04 -07:00
Jenn Magder
6253f9018c
Move DeviceManager into null migrated globals library (#91457) 2021-10-08 12:37:48 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be24.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
Zachary Anderson
5188df0821
Revert gradle roll (#91459)
* Revert "Mark last failing test after gradle update as flaky. (#91423)"

This reverts commit 46a52d03bd.

* Revert "fix android template for Gradle 7 (#91411)"

This reverts commit 51d06d537f.

* Revert "Add explicit version for mac and windows openjdk. (#91408)"

This reverts commit bf429f2771.

* Revert "Update the openjdk version used by linux android tests. (#91405)"

This reverts commit 2144ab8b45.

* Revert "Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642)"

This reverts commit b6459f9b63.
2021-10-07 19:42:24 -07:00
Christopher Fujino
f753168cb6
[flutter_tools] add working directory to ProcessException when pub get fails (#91436) 2021-10-07 18:08:04 -07:00
Majid Hajian
6c10f19b80
add package_name for consistency across all platforms (#88457) 2021-10-07 17:08:02 -07:00
Ian Hickson
f25b833f27
Enable avoid_print lint. (#91444) 2021-10-07 16:48:04 -07:00
Mouad Debbar
c2ea78d231
Revert "Enable avoid_print lint. (#91332)" (#91438)
This reverts commit cb378edc9e.
2021-10-07 16:16:17 -04:00
Jenn Magder
91d1e3ed8b
Default new project to the ios-signing-cert development team (#90021) 2021-10-07 10:23:02 -07:00
Ian Hickson
cb378edc9e
Enable avoid_print lint. (#91332) 2021-10-07 09:53:03 -07:00
Taha Tesser
51d06d537f
fix android template for Gradle 7 (#91411) 2021-10-07 08:00:26 -07:00
Taha Tesser
b6459f9b63
Migrate to Gradle 7.0.2 / AGP 7.0.1 (#90642) 2021-10-06 17:01:13 -07:00
Jenn Magder
afbfc1f33a
Migrate assets, common, icon_tree_shaker to null safety (#91309) 2021-10-06 15:16:33 -07:00
Pierre-Louis
3e43c3e110
Categorize flutter tool commands (#87747) 2021-10-05 17:28:04 -07:00
Michael Goderbauer
dc54c7f7be
Remove accidental print (#91317) 2021-10-05 15:13:03 -07:00
Greg Spencer
8405868db4
Update outdated platform directories in examples (#91125)
The first of three or four changes to update the platform directories of the packages in the Flutter repo that have out date platform code.

This batch includes updating the flutter_view example, updating the sanity check numbers in analyze.dart, and adding some missing Podfiles in the examples. I also eliminated some trailing whitespace in the templates for Android.
2021-10-05 14:52:11 -07:00
stuartmorgan
64fd68ed42
Don't generate plugin registry in ResidentWebRunner (#91281)
* Don't generate plugin registry in ResidentWebRunner

generateDartPluginRegistry was being set to true unconditionally in
ResidentRunner, bypassing the primary check in
DartPluginRegistrantTarget, and the targetPlatform was not set in that
codepath, bypassing the second after the changes in
https://github.com/flutter/flutter/pull/87991. This caused web hot
restarts to be slower due to doing unnecessary work.

This ensures that generateDartPluginRegistry is false in the
ResidentWebRunner to skip that unnecessary step.

Fixes https://github.com/flutter/flutter/issues/91262

* Formatting

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2021-10-05 12:27:53 -07:00
Ian Hickson
2bab6514b0
Enable avoid_implementing_value_types lint (#91078) 2021-10-04 13:48:04 -07:00
Ian Hickson
126cd7388e
Clean up dependency pins and update all packages (#91109) 2021-10-04 10:28:03 -07:00
Jenn Magder
61e2e86611
Add iOS build -destination flag (#90915) 2021-10-04 10:18:03 -07:00
Christopher Fujino
91dd3276fd
migrate vm service to null safety (#88320) 2021-10-02 10:18:03 -07:00
Littlegnal
1b73a35fba
Change project.buildDir in standalone subprojects property (#91030) 2021-10-01 17:18:05 -07:00
stuartmorgan
23cea26715
Add dartPluginClass support for Android and iOS (#87991) 2021-10-01 16:03:04 -07:00
Ian Hickson
4315cdcf76
Some test cleanup for flutter_tools. (#90227) 2021-10-01 10:38:02 -07:00
Ian Hickson
989f864497
Enable avoid_setters_without_getters (#91067) 2021-10-01 00:58:05 -07:00
stuartmorgan
97fb8c0560
Fix Dart plugin registrant interaction with 'flutter test' (#90288)
Building an application for a desktop platform that transitively included any Dart-based plugins (such as path_provider) broke `flutter test`, because its compilation was overriding the provided main (in this case, the test main) with `generated_main.dart` if it was present. This PR:
- Changes the `flutter test` compilation path to update `generated_main.dart`, so that the tests will work, and will include any registered Dart plugins.
- Makes using `generated_main.dart` during recompile opt-in, to try to reduce the chance of a similar bug happening with other codepaths in the future.

Fixes https://github.com/flutter/flutter/issues/88794
2021-09-30 20:25:13 -07:00
Christopher Fujino
738a7747cc
[flutter_tools] Handle disk device not found (#90996) 2021-09-30 17:28:57 -07:00
Jenn Magder
c48c428e46
Xcode 13 as minimum recommended version (#90906) 2021-09-30 12:23:55 -07:00
Christopher Fujino
afd84ad425
flutter update-packages (#90994) 2021-09-30 11:38:02 -07:00
Greg Spencer
01af8e5987
Make flutter update-packages run in parallel (#91006)
This modifies the flutter update-packages and flutter update-packages --force-upgrade commands so that the many invocations of "dart pub get" in each repo project run in parallel instead of in series.
2021-09-30 10:26:31 -07:00
Jenn Magder
faaca13f22
Catch FormatException from bad simulator log output (#90966) 2021-09-30 09:33:04 -07:00
Kenzie (Schmoll) Davisson
5a85c0d81c
Launch DevTools from the 'dart devtools' command instead of pub (#90894) 2021-09-29 15:32:24 -07:00
Nicholas Shahan
3074c9e04b
Add tests for web library platform defines (#90620) 2021-09-28 22:08:04 -07:00
Greg Spencer
ab2b0851a2
Add smoke tests for all the examples, fix 17 broken examples. (#89021)
This adds a smoke test for every single API example. It also fixes 17 tests that had bugs in them, or were otherwise broken, and even fixes one actual bug in the framework, and one limitation in the framework.

The bug in the framework is that NetworkImage's _loadAsync method had await response.drain<List<int>>();, but if the response is null, it will throw a cryptic exception saying that Null can't be assigned to List<int>. The fix was just to use await response.drain<void>(); instead.

The limitation is that RelativePositionedTransition takes an Animation<Rect> rect parameter, and if you want to use a RectTween with it, the value emitted there is Rect?, and one of the examples was just casting from Animation<Rect> to Animation<Rect?>, which is invalid, so I modified RelativePositionedTransition to take a Rect? and just use Rect.zero if the rect is null.
2021-09-28 09:32:06 -07:00
Jason Simmons
cd19bc6007
Do not retry if pub get is run in offline mode (#90394) 2021-09-27 08:18:06 -07:00
Christopher Fujino
61bce1d83b
[flutter_tools] remove non-null check from AndroidValidator (#90090) 2021-09-25 16:53:06 -07:00
Jenn Magder
1b53f7beba
Migrate iOS project to Xcode 13 compatibility (#90304) 2021-09-22 13:23:05 -07:00
chunhtai
8d7068694b
Fixes resident_web_runner_test initialize the mock correctly (#90546) 2021-09-22 12:58:21 -07:00
Jason Simmons
c761c6c2d4
Fix an unnecessary_import analyzer error in the skeleton app template (#90417) 2021-09-20 15:18:37 -07:00
Jason Simmons
58056bbe74
Close the IntegrationTestTestDevice stream when the VM service shuts down (#90022) 2021-09-17 19:18:03 -07:00
Liam Appelbe
9afbab8477
Use report_lines flag in flutter coverage (#90142)
* Use the report lines flag

* Handle major version bumps in the version check

* Fix existing tests and add a new test
2021-09-16 11:33:32 -07:00
Ahmed Ashour
eb185d73ce
internationalization: fix select with incorrect message (#90096) 2021-09-16 09:23:22 -07:00
Jenn Magder
ab6f2fc8ce
Set BUILD_DIR when determining if plugins support arm64 simulators (#90088) 2021-09-15 18:37:04 -07:00
Kate Lovett
65d8dd988d
Update md5 method in flutter_goldens_client (#90154) 2021-09-15 17:42:05 -07:00
Sam Rawlins
bcb5db7758
Remove "unnecessary" imports from packages/ (#89795) 2021-09-15 01:27:02 -07:00
Christopher Fujino
a2cd16ba82
use test logger, which does not allow colors (#90010) 2021-09-14 11:22:02 -07:00
Michael Thomsen
b889915997
Change min Dart SDK constraint to track actual version (#88743) 2021-09-14 14:08:36 +02:00
Jason Simmons
fad5e4cf89
Remove a redundant test case in the flutter_tools create_test (#89872) 2021-09-13 13:37:07 -07:00
Anna Gringauze
cd112e551c
Update all packages (#89797) 2021-09-13 12:13:42 -07:00
Phil Quitslund
975fcc1f2f
master->main deafult branch migration (#89782) 2021-09-10 15:42:03 -07:00
Chase Latta
aed4315a7d
Replace amber_ctl with pkgctl for Fuchsia (#89785)
Fuchsia is deprecating amber_ctl and replacing it with pkgctl.
This change removes the FuchsiaAmberCtl class and replaces it
with the FuchsiaPkgctl class and updates the usages appropriately.

BUG: fxbug.dev/83865
2021-09-10 10:33:45 -07:00
Jason Simmons
2004afae06
Use async timeline events for the phases of the scheduler binding (#88825) 2021-09-10 10:17:05 -07:00
Jenn Magder
51588ab808
Set plugin template minimum Flutter SDK to 2.5 (#89695) 2021-09-09 20:42:03 -07:00
Jenn Magder
84086d8a9c
Clean up null assumptions in vmservice for null safe migration (#89009) 2021-09-09 19:32:02 -07:00
Jenn Magder
855af29084
Migrate ios_deploy to null safety (#88851) 2021-09-09 17:32:05 -07:00
Jason Simmons
a14be9d290
Run the flutter_tools create test in online mode before testing offline mode (#89779)
Offline pub assumes that the pub cache contains all needed packages.  Running
"flutter create" in online mode first will ensure that the pub cache is populated.

Fixes https://github.com/flutter/flutter/issues/89759
2021-09-09 13:31:37 -07:00
Jenn Magder
58944e6b88
Revert "Enable caching of CPU samples collected at application startup (#89600)" (#89704)
This reverts commit 619121b095.
2021-09-08 19:37:34 -07:00
Ben Konyi
619121b095
Enable caching of CPU samples collected at application startup (#89600) 2021-09-08 17:22:04 -07:00
Jenn Magder
34ba64738e
Clean up null assumptions in devfs to prep for null safety migration (#88934) 2021-09-08 15:27:05 -07:00
Ben Konyi
41101b7058
Update DDS to 2.1.2 (#89591) 2021-09-08 12:57:03 -07:00
Anis Alibegić
a753d09cc9
Fixed several typos (#89485) 2021-09-07 14:56:04 -07:00
Emmanuel Garcia
50b0037803
Remove files that are unnecessary in a plugin (#89445) 2021-09-07 11:11:05 -07:00
Chris Bracken
1c36271b05
Reduce required Windows CMake version to 3.14 (#89390)
When we landed the CMake minimum requirement constraint for Visual
Studio 2019, we landed it with minimum version 3.15, since that's what
was shipping with the current version of VS 2019 at the time. Looking at
the release notes of earlier versions, it's clear that earlier versions
of Visual Studio 2019 shipped with version 3.14. See:
https://devblogs.microsoft.com/cppblog/visual-studio-cmake-support-clang-llvm-cmake-3-14-vcpkg-and-performance-improvements/

Looking at release notes for CMake 3.15, there are no features/fixes
introduced in that version that we are dependent on.
https://cmake.org/cmake/help/latest/release/3.15.html

Issue: https://github.com/flutter/flutter/issues/88589
2021-09-03 21:05:58 -07:00
arfy slowy
202fc02ca1
fix: typo spelling grammar (#88439) 2021-09-03 15:09:31 -07:00
Pierre-Louis
1298a9fd54
Adjust plugins and packages .gitignore to be most useful (#88991)
* Update .gitignore.tmpl

* Add pubspec.lock

* Exclude example/pubspec.lock

* Address feedback
2021-09-03 20:22:35 +02:00
Jacob MacDonald
383930c2bc
update package dependencies (#89381) 2021-09-02 14:41:05 -07:00
Kate Lovett
616f9bcffa
Add tag support for executing reduced test sets (#86821) 2021-08-30 15:41:02 -07:00
Sigurd Meldgaard
bce366203a
Stop calling top level pub (#89032)
* Use `dart __deprecated_pub` instead of `pub` to invoke pub from tools

The top level `pub` commmand has been deprecated and will print
a message. It is however implemented via the __deprecated_pub command
that prints no message.
2021-08-30 10:40:10 -07:00
moko256
d0bfe170bf
Use {{projectName}} as BINARY_NAME and CMake project name in UWP template (#87859) 2021-08-26 17:11:05 -07:00
Viral Kachhadiya
24b1a02224
replace localEngineOut with local-engine-out (#85968)
* replace localEngineOut with local-engine-out
* local-engine-out section removed entirely

Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
2021-08-26 14:02:46 -07:00
Jenn Magder
e6535f6da1
Changed tool cached properties to late finals (#88923) 2021-08-26 14:01:05 -07:00
Jenn Magder
0cb6d5983c
Migrate fuchsia sdk and dependencies to null safety (#88920) 2021-08-25 19:51:04 -07:00
Anna Gringauze
a511c436c9
Fix web_tool_tests failure on dart roll (#88914)
Helps: https://github.com/flutter/flutter/issues/88911
2021-08-25 18:22:21 -07:00
Jenn Magder
d550d497f1
Migrate some flutter_tools tests to null safety (#88850) 2021-08-25 16:21:04 -07:00
Zachary Anderson
cff3db1d8e
Account for additional warning text from the tool (#88902) 2021-08-25 14:55:42 -07:00
Jenn Magder
125451bc2e
Migrate mac.dart to null safety (#88846) 2021-08-25 13:31:03 -07:00
Zachary Anderson
b4e0472b04
Revert "Use dart pub instead of pub to invoke pub from tools (#88509)" (#88792)
This reverts commit 7c24ff2c5b.
2021-08-24 09:00:22 -07:00
Sigurd Meldgaard
7c24ff2c5b
Use dart pub instead of pub to invoke pub from tools (#88509)
Top level `pub` is being deprecated.
2021-08-24 15:51:08 +02:00
Christopher Fujino
efaa9a4637
update-packages --force-upgrade (#88728) 2021-08-23 12:57:08 -07:00
Jonah Williams
fa0782b696
reassign jonahwilliams todos (#88707) 2021-08-23 12:27:07 -07:00
Ian Hickson
9f9aa46b7d
Update the timeouts since tests time out after 15 minutes not 30 seconds. (#88061) 2021-08-20 12:52:03 -07:00
Hans Muller
afe58fbab5
Revert "Reland "Android Q transition by default (#82670)" (#88409)" (#88482) 2021-08-18 20:22:04 -07:00
Bernardo Ferrari
6318b5096c
Add favicon to web template (#88141) 2021-08-18 17:12:02 -07:00
Anna Gringauze
2685e866f3
Update dwds and other packages (#88450)
- Update all packages (bringing in dwds 11.2.1)

Closes: https://github.com/flutter/flutter/issues/84012
2021-08-18 14:15:57 -07:00
Jenn Magder
563c8f43e3
Verbosify every command in ios_content_validation_test (#88404) 2021-08-18 10:42:02 -07:00
Alex Li
df399f9a8d
Reland "Android Q transition by default (#82670)" (#88409)
* Reland "Android Q transition by default (#82670)"

This reverts commit 4053b4b16c.

* Fix `overall_experience_test.dart` for flutter_tools
2021-08-18 09:11:27 -07:00
Taha Tesser
d72287522b
[tools] Fix Android Studio duplicate detection (#88384) 2021-08-18 02:02:03 -07:00
Jenn Magder
2d55032939
Migrate dds.dart to null safety (#88382) 2021-08-17 21:12:03 -07:00
Christopher Fujino
81eb54bf78
update-packages (#88387) 2021-08-17 18:49:32 -07:00
Anna Gringauze
831d82c8ea
Fix race conditions in test_driver for tool tests (#88322) 2021-08-17 18:37:04 -07:00
Taha Tesser
42a6b7913c
[tools] Add Xcode version to non-verbose Flutter doctor (#87022) 2021-08-17 15:52:03 -07:00
Zachary Anderson
3572a7e8b7
Revert "feat: migrate base/dds.dart to null-safety (#88015)" (#88367) 2021-08-17 11:52:05 -07:00
Jonah Williams
060e4608b1
clean up stale or unnecessary TODOS (#88308) 2021-08-16 21:37:03 -07:00
Gary Qian
a562b3cb3d
Deferred components integration test app (#88030) 2021-08-16 15:32:05 -07:00
Jason Simmons
ddb8bfb72b
Fix URL construction in the test entry point generated by the web bootstrap script (#88201) 2021-08-16 14:12:05 -07:00