Christopher Fujino
|
c353e641ad
|
run tests under dev/tools as part of framework-misc and get them passing (#136501)
part of https://github.com/flutter/flutter/issues/136500
this should not affect any production code, it merely runs the tests on CI and makes the changes needed to get them passing.
|
2023-10-13 18:48:43 +00:00 |
|
Pierre-Louis
|
0919fb86f1
|
Improve handling of certain icons in RTL (#130979)
Fixes https://github.com/flutter/flutter/issues/130978
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
|
2023-07-21 19:07:39 +02:00 |
|
Pierre-Louis
|
d8f7c3d362
|
Refactor icon update script (#122392)
* x
* docs
|
2023-03-13 22:17:35 +01:00 |
|
Pierre-Louis
|
7855132341
|
Generate a demo for new icons when updating icons (#101190)
* add code to generate new icon demo and make font family optional
* remove trailing spaces
* Update update_icons_test.dart
* remove trailing space
|
2022-04-05 12:56:23 +02:00 |
|
Pierre-Louis
|
6bd0b95728
|
[Icons] Prevent double underscores after replacement (#96904)
* Prevent double underscores after replacement
* add test
* remove trailing space
|
2022-01-30 13:16:32 +01:00 |
|
Pierre-Louis
|
b23f207e2c
|
Improve update_icons.dart script (#93863)
* Update update_icons.dart
* formatting
* more formatting
* simplify safety checks
* add safety checks tests
* formatting
* update copyright
* naming
* revert copyright
* add `fontFamily` option
* tweak diff messages
* Update update_icons.dart
* don't exit if platform adaptive icon not found
* remove trailing spaces
* remove warning and fix insert_chart (outlined) dartdoc
* x
* add error message when exiting due to failed safety checkes
* fix icon reference
* fix rewrite for onetwothree
|
2021-12-08 16:31:48 +01:00 |
|