Jason Simmons
32846de9f8
Remove ArtifactStore and move flutterRoot into Cache ( #3883 )
2016-05-12 15:54:35 -07:00
Phil Quitslund
616d9e2ea8
Merge pull request #3880 from pq/void_setters
...
Turn on `avoid_return_types_on_setters` and cleanup annotated setters.
2016-05-12 12:28:15 -07:00
Jason Simmons
a590ee2671
Remove BuildConfigurations ( #3879 )
...
Artifacts from local engine builds will be found based on the --local-engine flag
2016-05-12 12:22:15 -07:00
pq
e54196d7fc
Turn on avoid_return_types_on_setters
and cleanup annotated setters.
...
It's safe to remove the unneeded `void`s from setters since the blocking issues in the
`always_declare_return_types` lint have been fixed (https://github.com/dart-lang/linter/ ). We can also safely flip the bit on `avoid_return_types_on_setters`.
2016-05-12 11:45:30 -07:00
Devon Carew
7072c8f255
Update version.dart ( #3873 )
2016-05-11 19:58:34 -07:00
Chinmay Garde
f0a8ee2a86
Use debug artifacts on mac host and update engine revision. ( #3875 )
2016-05-11 17:07:12 -07:00
Jason Simmons
0f53f7966b
Remove Toolchain and extend ToolConfiguration to locate host tools such as sky_snapshot ( #3870 )
...
Host tools can be found in the artifact cache directory for the host platform.
If a developer wants to use a local engine build instead, then provide an
--engine-build flag that selects the specific engine build variant.
2016-05-11 15:47:26 -07:00
Devon Carew
45db865079
be more lenient when looking for matching android sdk components ( #3830 )
...
* be more lenient when looking for matching android sdk components
* use a null aware operator
2016-05-11 15:34:24 -07:00
Chinmay Garde
29b8c804da
Update bucket names for each target and host build configuration. ( #3866 )
2016-05-11 14:54:51 -07:00
Chinmay Garde
915f24866a
Change bucket names for iOS and Mac based on buildbot updates. ( #3863 )
2016-05-11 13:41:44 -07:00
Devon Carew
6635f1cf9b
re-enable --checked ( #3857 )
2016-05-11 12:26:46 -07:00
Jason Simmons
82dbd43e74
Fix the paths for local engine builds targeting the host platform ( #3855 )
2016-05-11 11:11:34 -07:00
Collin Jackson
e2ab858202
Fix #3825 crash installing onto certain Android devices
2016-05-11 09:32:35 -07:00
Devon Carew
826936cd33
use vendored dart sdk; check the expected version of flutter ( #3831 )
...
* use vendored dart sdk; check the expected version of flutter
* search up directories looking for the flutter root
2016-05-10 16:21:30 -07:00
Phil Quitslund
eec3fc60f1
Merge pull request #3838 from pq/sdk_summaries
...
Turn on SDK summaries in flutter analyze.
2016-05-10 15:22:33 -07:00
Devon Carew
52d0434bec
create a flutter setup command ( #3837 )
2016-05-10 15:04:29 -07:00
pq
a8f96de47d
Removed unused import.
2016-05-10 14:37:39 -07:00
pq
d11651d293
Turn on SDK summaries in flutter analyze.
...
The latest dev build has stable summaries so we should start using them.
(Also ensures that analysis options are propogating to the SDK analysis context --- see: https://github.com/dart-lang/sdk/issues/26129 .)
2016-05-10 14:31:00 -07:00
Devon Carew
067715e302
Send exit for flutter run --resident ( #3829 )
...
* send ext.flutter.exit
* listen for help restart, quit
* refactor into a separate class
2016-05-10 13:47:00 -07:00
Todd Volkert
810b3e32a6
Fix regexp that strips invalid characters from the project identifier
...
Fixes #3835
2016-05-10 13:24:20 -07:00
Todd Volkert
43c0c52225
Fix regexp that strips invalid characters from the Uniform Type Identifier
...
Fixes #3835
2016-05-10 13:08:29 -07:00
Jason Simmons
6ab77622e4
Update flutter_tools for the "unoptimized" engine build flag and the new output directory naming scheme ( #3832 )
2016-05-10 12:02:09 -07:00
pq
18d971d492
Remove gratuitous pub resolver from flutter analysis.
...
Package mapping is already done by the `PackageDependencyTracker` so this extra check is at best not needed. (At worst could cause an unneeded and costly call to `pub list-package-dirs`!)
2016-05-09 12:21:18 -07:00
Phil Quitslund
cc93170894
Merge pull request #3798 from pq/package_map_cleanup
...
Analyze update to use in-memory package map.
2016-05-09 11:53:21 -07:00
pq
1e50745df3
Constructor ordering.
2016-05-09 11:33:52 -07:00
Hans Muller
74c3e74fba
Call it Flutter Gallery ( #3801 )
2016-05-09 11:00:54 -07:00
Devon Carew
a5b198e9b9
remove the --checked option ( #3799 )
2016-05-09 10:58:47 -07:00
pq
46d32794f9
Analyze update to use in-memory package map.
...
Updates the analyze command to pass a package map to analysis rather than a file path.
This allows us to avoid creating a needless temporary `.packages` file and host directory and saves us a trip to disk to retrieve the contents when building our URI resolvers for analysis.
2016-05-09 09:59:16 -07:00
Jason Simmons
2ea3c9471d
Fix for how flutter refresh locates the Android package manifest ( #3791 )
2016-05-09 09:31:46 -07:00
Jason Simmons
09dde8718b
Change the Android activity launch mode to singleTop ( #3792 )
2016-05-09 09:31:34 -07:00
pq
c973629ed7
Fixed braces.
2016-05-06 13:43:21 -07:00
pq
96de7c4dcc
Fix analyzer error messages.
...
Will have the result of restoring `[static warning]` to `[warning]`, etc.
(This is essentially how we handle it in the analyzer CLI.)
2016-05-06 13:39:48 -07:00
pq
2df43d50d3
Merge branch 'master' into analysis_rework
2016-05-06 08:58:49 -07:00
Devon Carew
bd564a02af
avoid sending analytics on ci systems ( #3765 )
...
* avoid sending analytics on ci systems
* review comments
2016-05-05 19:51:22 -07:00
Jason Simmons
4d0e6984c2
Build tool support for Android x86 targets in 32- or 64-bit modes ( #3761 )
2016-05-05 16:04:22 -07:00
pq
eb215c14ac
Review cleanup.
2016-05-05 15:16:27 -07:00
Devon Carew
a999366482
remove the analyze --benhcmark-expected option ( #3755 )
2016-05-05 14:26:21 -07:00
pq
4311ddb461
Duplicate test fix.
2016-05-05 13:39:58 -07:00
pq
3b882fc449
Updated arg default handling and .dartignore support.
2016-05-05 13:25:59 -07:00
pq
e808125c5b
Dead code cleanup.
2016-05-05 12:35:52 -07:00
pq
71203e9a89
Analyzer dep commentary fix.
2016-05-05 12:15:26 -07:00
pq
a59a713f75
Analysis re-work to use analyzer APIs.
...
Introduces a new Dart analysis wrapper that works directly with the analyzer API (in favor of shelling out to a separate process).
Some consequences:
* we no longer need to fear parts (simplifying our dart file gathering)
* we can filter by error code (when needed), rather than by error strings
* no more IO scraping
* no need to generate `main()` or to run with `--package-warnings`
* we now specify an analyzer (and linter) version in the pubspec (we’ll want to make sure this doesn’t diverge too far from the analyzer shipped with the SDK but it does give us some room to play with experimental builds)
* no more (re)scanning of error source files (and so no more source cache)
* should generally be a bit simpler and easier to maintain
* runs a bit faster :)
2016-05-05 12:08:58 -07:00
Phil Quitslund
0e515631a1
Merge pull request #3739 from pq/eq_matcher_cleanup
...
Prefer implict `equals` matcher in test expectations.
2016-05-04 14:16:06 -07:00
Yegor
39e741dfb7
[tools] remove --flutter-repo flag in flutter test
( #3728 )
2016-05-04 14:08:16 -07:00
pq
79d1d3a7c4
Prefer implict equals
matcher in test expectations.
...
@Hixie: as per our conversation, a little more concise.
2016-05-04 13:58:45 -07:00
Devon Carew
61c003734b
checked mode fix; add type annotation ( #3737 )
2016-05-04 13:41:46 -07:00
Devon Carew
f34d31717c
complain on missing entries in flutter.yaml ( #3731 )
...
* complain on missing entries in flutter.yaml
* change to a hard failure
2016-05-04 12:33:34 -07:00
Devon Carew
e365453eac
better parsing of adb devices output ( #3726 )
...
* better parsing of adb devices output
* re-order lines
2016-05-04 12:32:46 -07:00
Devon Carew
e464a81998
remove the packages/flutter_tools/.analysis_options file ( #3733 )
2016-05-04 11:43:01 -07:00
Devon Carew
1d4cda5d13
fix the benchmark file written by the analyze command ( #3725 )
2016-05-04 10:01:39 -07:00